Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-20 01:25:30 +01:00
Code Issues Projects Releases Wiki Activity
25,838 Commits 50 Branches 748 Tags 793 MiB
de262f553c
Commit Graph

25838 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Scott Taylor
de262f553c In wp-includes/comment-template.php, remove dead code: 
* In `get_comment_reply_link()`, `$link` is set twice before it is used.
* In `Walker_Comment::start_lvl()`, `case 'ul':` is unreachable unless placed before `default:`. 
* In `Walker_Comment::end_lvl()`, `case 'ul':` is unreachable unless placed before `default:`.
* In `comment_form()`, `$id` is conditionally set and never used. 

See #27882.


Built from https://develop.svn.wordpress.org/trunk@28323


git-svn-id: http://core.svn.wordpress.org/trunk@28151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 21:15:17 +00:00
Scott Taylor
6b80da9d96 In Walker::walk() and Walker::paged_walk(), $id_field is set and never used. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28322


git-svn-id: http://core.svn.wordpress.org/trunk@28150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 21:09:19 +00:00
Sergey Biryukov
d711c32138 Update deleted site message in ms_site_check(). 
props boonebgorges.
fixes #28150.
Built from https://develop.svn.wordpress.org/trunk@28321


git-svn-id: http://core.svn.wordpress.org/trunk@28149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:46:15 +00:00
Scott Taylor
013d4dc387 In WP_Image_Editor::get_output_format(), $file_mime and $file_ext are set twice before they are used. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28320


git-svn-id: http://core.svn.wordpress.org/trunk@28148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:37:29 +00:00
Scott Taylor
73b102bd84 In wp-includes/class-wp-customize-setting.php, break is unreachable after return. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28319


git-svn-id: http://core.svn.wordpress.org/trunk@28147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:34:14 +00:00
Scott Taylor
0a4af6d45c In wp-includes/class-wp-admin-bar.php, break is unreachabled after return. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28318


git-svn-id: http://core.svn.wordpress.org/trunk@28146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:29:15 +00:00
Scott Taylor
5bd852c262 In WP_Http_Curl::request(), $theResponse is unused. There are other curl_exec() calls that do not return as well. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28317


git-svn-id: http://core.svn.wordpress.org/trunk@28145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:26:14 +00:00
Scott Taylor
63a210e7c8 In wp-includes/bookmark.php, remove dead code: 
* In `get_bookmarks()`, `$cache` is set twice before it is used. 
* In `sanitize_bookmark_field()`, `break` is unreachable after `return`

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28316


git-svn-id: http://core.svn.wordpress.org/trunk@28144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:22:16 +00:00
Scott Taylor
5f27d149a3 In wp-admin/users.php, break is unreachabled after exit. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28315


git-svn-id: http://core.svn.wordpress.org/trunk@28143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:19:14 +00:00
Scott Taylor
402d8b80fb In core_upgrade_preamble(), $alternate is set then never used. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28314


git-svn-id: http://core.svn.wordpress.org/trunk@28142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:17:18 +00:00
Scott Taylor
e9bb9c0f12 In wp-admin/theme-editor.php, break is unreachabled after exit. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28313


git-svn-id: http://core.svn.wordpress.org/trunk@28141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:16:26 +00:00
Scott Taylor
517dbfaa21 In wp-admin/post.php, break is unreachabled after exit. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28312


git-svn-id: http://core.svn.wordpress.org/trunk@28140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:15:15 +00:00
Scott Taylor
327b38f298 In wp-admin/plugins.php, break is unreachabled after exit. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28311


git-svn-id: http://core.svn.wordpress.org/trunk@28139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:13:14 +00:00
Scott Taylor
ac63c66c5a In wp-admin/plugin-editor.php, break is unreachabled after exit. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28310


git-svn-id: http://core.svn.wordpress.org/trunk@28138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:12:14 +00:00
Scott Taylor
0f8fb8a148 In wp-admin/network/users.php, break is unreachabled after exit. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28309


git-svn-id: http://core.svn.wordpress.org/trunk@28137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:11:14 +00:00
Scott Taylor
64418c0192 In wp-admin/network/themes.php, break is unreachabled after exit. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28308


git-svn-id: http://core.svn.wordpress.org/trunk@28136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:08:14 +00:00
Scott Taylor
f5d23b82bd In wp-admin/link.php, break is unreachabled after exit. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28307


git-svn-id: http://core.svn.wordpress.org/trunk@28135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:06:14 +00:00
Scott Taylor
213a7de0b7 In display_setup_form(), $admin_password is set and (fortunately) not used or displayed. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28306


git-svn-id: http://core.svn.wordpress.org/trunk@28134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 18:04:15 +00:00
Scott Taylor
c2d44c5736 In wp-admin/includes/upgrade.php, remove dead code: 
* In `maybe_create_table()` and `maybe_add_column()`, the response of `$wpdb->query()` is set to a variable that is never used.
* In `make_db_current_silent()`, which is a wrapper for `dbDelta`, a variable is set that is not used. This function appears to be a copy-paste of `make_db_current()`'s `dbDelta()` call but is meant to return nothing, and still does not.  

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28305


git-svn-id: http://core.svn.wordpress.org/trunk@28133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 17:27:15 +00:00
Scott Taylor
aaa3eb07ad In wp-admin/includes/update.php, remove dead code: 
* In `get_core_checksums()`, `$return` is set and never used.
* In `core_update_footer()`, `break` is unnecessary and unreachable after `return`.
* In `get_theme_updates()`, `$themes` is set and never used.
* In `wp_theme_update_row()`, `$theme_name` is the only user of `$themes_allowedtags`... neither are used. 	

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28304


git-svn-id: http://core.svn.wordpress.org/trunk@28132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 17:21:14 +00:00
Scott Taylor
b80cda5d17 In WP_Screen::render_screen_options(), remove dead code: 
* `$wp_list_table` does not need to be imported.
* `$post` is set and never used.

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28303


git-svn-id: http://core.svn.wordpress.org/trunk@28131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 17:14:15 +00:00
Scott Taylor
2e417f0ca4 In get_sample_permalink_html(), $view_link is set and never used. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28302


git-svn-id: http://core.svn.wordpress.org/trunk@28130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 17:11:14 +00:00
Scott Taylor
44e2d48a3c In install_plugin_information(), $title is set in a foreach loop and never used. This appears to be due to copy-pasting a previous foreach loop and not discarding these bits. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28301


git-svn-id: http://core.svn.wordpress.org/trunk@28129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 17:00:18 +00:00
Scott Taylor
e57fa7300d In wp-admin/includes/nav-menu.php, remove dead code: 
* In `_wp_ajax_menu_quick_search()`, in an `else` block, `$post_obj` was set and not used. Another block sets it again and does use it. 
* In `wp_nav_menu_item_post_type_meta_box()`, `$post_type_object` was set and, sadly, never used. `$error` was set and not used. 

See #27882.


Built from https://develop.svn.wordpress.org/trunk@28300


git-svn-id: http://core.svn.wordpress.org/trunk@28128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 16:55:14 +00:00
Scott Taylor
85bdc64173 In update_option_new_admin_email(), $email is set and never used. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28299


git-svn-id: http://core.svn.wordpress.org/trunk@28127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 16:48:14 +00:00
Scott Taylor
6066f85853 In attachment_submit_meta_box(), remove dead code: 
* `$action` doesn't need to be imported.
* `$can_publish` is set and never used, which means it doesn't need...
* `$post_type_object` or `$post_type`, which only served `$can_publish`.

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28298


git-svn-id: http://core.svn.wordpress.org/trunk@28126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 16:45:14 +00:00
Scott Taylor
71ac0f21c2 In get_media_item(), $tags and $_tags are set and never used. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28297


git-svn-id: http://core.svn.wordpress.org/trunk@28125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 16:41:17 +00:00
Scott Taylor
3054b924a3 In WP_Users_List_Table::get_views(), $current_role is set and never used. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28296


git-svn-id: http://core.svn.wordpress.org/trunk@28124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 15:33:15 +00:00
Scott Taylor
209f008d77 In WP_MS_Users_List_Table::get_views(), remove dead code: 
* `$wp_roles` doesn't need to be imported.
* `$current_role` is set and never used.

See #27882.


Built from https://develop.svn.wordpress.org/trunk@28295


git-svn-id: http://core.svn.wordpress.org/trunk@28123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 15:30:14 +00:00
Dominik Schilling
f7539feb4d Custom Header: Fix logic when a theme doesn't set default-text-color. 
fixes #28042.
Built from https://develop.svn.wordpress.org/trunk@28294


git-svn-id: http://core.svn.wordpress.org/trunk@28122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 15:27:54 +00:00
Scott Taylor
970477d25e In WP_Media_List_Table, remove dead code: 
* In `->prepare_items()`, importing `$wpdb` is unnecessary.
* In `->get_columns()`, `$taxonomies` is set twice before it is used.
* In `->display_rows()`, `$taxonomy_object` is set and never used.

See #27882.


Built from https://develop.svn.wordpress.org/trunk@28293


git-svn-id: http://core.svn.wordpress.org/trunk@28121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 15:27:33 +00:00
Scott Taylor
28d98a89f3 In ajax-actions.php, remove dead code: 
* In `wp_ajax_add_tag()`, `$post_type` is set and never used.
* In `wp_ajax_hidden_columns()`, `$hidden` is set twice, but only checks for the existence of `$_POST['hidden']` the first time. The two lines can be combined and work together.
* In `wp_ajax_inline_save()`, `$mode` is set and never used.
* In `wp_ajax_find_posts()`, `$searchand = $search = '';` is leftover cruft, neither variable is used. `$wpdb` does not need to be imported, it is never used.
* In `wp_ajax_wp_fullscreen_save_post()`, `$post_type` is set and never used.
* In `wp_ajax_save_attachment_order()`, `$post` is set and never used.
* In `wp_ajax_send_attachment_to_editor()`, `$title` is set and never used. 

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28292


git-svn-id: http://core.svn.wordpress.org/trunk@28120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 15:19:14 +00:00
Scott Taylor
d433f8f1ed Remove unreachable break statements in wp-admin/edit-tags.php. break is unnecessary after die, exit, and wp_die. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28291


git-svn-id: http://core.svn.wordpress.org/trunk@28119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 14:52:16 +00:00
Scott Taylor
d3dd9916d8 In wp-admin/custom-header.php, $default_color is set twice before it is used. The first is unnecessary. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28290


git-svn-id: http://core.svn.wordpress.org/trunk@28118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 14:51:19 +00:00
Scott Taylor
97e6942e4a Remove unreachable break statements in wp-admin/comments.php. break is unnecessary after die, exit, and wp_die. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28289


git-svn-id: http://core.svn.wordpress.org/trunk@28117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 14:46:16 +00:00
Sergey Biryukov
10ab8b1055 Translate a string added in 3.7 but never translated previously. 
props andrezrv.
fixes #28025.
Built from https://develop.svn.wordpress.org/trunk@28288


git-svn-id: http://core.svn.wordpress.org/trunk@28116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 12:49:15 +00:00
Sergey Biryukov
527a1ea6e3 Use a consistent context to remove duplicate strings. 
props pavelevap.
fixes #28123.
Built from https://develop.svn.wordpress.org/trunk@28287


git-svn-id: http://core.svn.wordpress.org/trunk@28115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 12:34:14 +00:00
Sergey Biryukov
28cafbb868 Add context for 'Previous' and 'Next' theme strings. 
see #28120, for trunk.
Built from https://develop.svn.wordpress.org/trunk@28286


git-svn-id: http://core.svn.wordpress.org/trunk@28114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 12:20:14 +00:00
Sergey Biryukov
d70e8a38fa Add a filter for wp_list_comments() arguments. 
props greenshady, hlashbrooke.
fixes #19581.
Built from https://develop.svn.wordpress.org/trunk@28285


git-svn-id: http://core.svn.wordpress.org/trunk@28113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 11:58:14 +00:00
Dominik Schilling
8b72aebdaa Add missing Dashicons classes to User Admin menu. 
props imath.
see #28144, #26630.
Built from https://develop.svn.wordpress.org/trunk@28284


git-svn-id: http://core.svn.wordpress.org/trunk@28112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 07:58:15 +00:00
Drew Jaynes
2c00d8f9e3 Where a filter no longer exists, it need not be notated. 
Fixes #24444. See r28258.

Built from https://develop.svn.wordpress.org/trunk@28283


git-svn-id: http://core.svn.wordpress.org/trunk@28111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 05:38:15 +00:00
Andrew Nacin
e239dfad43 Multisite: Treat 'www' as a special subdomain, reversing 3.9 regression. 
props jeremyfelt.
fixes #27927.

Built from https://develop.svn.wordpress.org/trunk@28280


git-svn-id: http://core.svn.wordpress.org/trunk@28108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 05:32:36 +00:00
Scott Taylor
ded4871368 In WP_List_Table::display_rows_or_placeholder(), the call to get_column_info() in unnecessary and unused. The call to get_column_count() immediately after makes the same call internally. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28279


git-svn-id: http://core.svn.wordpress.org/trunk@28107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 05:32:15 +00:00
Andrew Nacin
5b63b112f3 Multisite: Fix case sensitivity regressions in 3.9. 
props jeremyfelt.
fixes #27866.

Built from https://develop.svn.wordpress.org/trunk@28276


git-svn-id: http://core.svn.wordpress.org/trunk@28104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 05:24:14 +00:00
Andrew Nacin
7509795517 Custom header: Avoid warnings in the process_default_headers() method. 
props obenland.
fixes #27850.

Built from https://develop.svn.wordpress.org/trunk@28275


git-svn-id: http://core.svn.wordpress.org/trunk@28103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 05:07:13 +00:00
Scott Taylor
9bdbd50ac0 In general-template.php - remove dead code: 
* In `get_calendar()`, `$cache` is set twice. The first is useless. 
* In `wp_default_editor()`, `$user` is (accidentally) assigned in a condition. Since it is never used, this is unnecessary.
* In `language_attributes()`, `$output` is set twice before it is ever used. The first is unnecessary. 
* In `paginate_links()`, `$n` is set twice before it is ever used. The first is unnecessary.

See #27882.


Built from https://develop.svn.wordpress.org/trunk@28274


git-svn-id: http://core.svn.wordpress.org/trunk@28102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 04:58:16 +00:00
Scott Taylor
dd73ad4299 In edit_form_image_editor(), $filename and $title are set and then unused. They shall be removed. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28271


git-svn-id: http://core.svn.wordpress.org/trunk@28099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 04:45:16 +00:00
Andrew Nacin
962e8113ab Customizer: Only tie header button action events to the header controls. 
props danielbachhuber.
fixes #28046. see #27848.

Built from https://develop.svn.wordpress.org/trunk@28269


git-svn-id: http://core.svn.wordpress.org/trunk@28097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 04:30:23 +00:00
Scott Taylor
644024dfc4 Dead code in wp-admin/includes/file.php: 
* In `wp_handle_upload()` and `wp_handle_sideload()`, `$ext` gets conditionally reset... and then is never used.
* In `request_filesystem_credentials()`, `$password` is initialized as an empty string. The variable is never used.

See #27882.


Built from https://develop.svn.wordpress.org/trunk@28268


git-svn-id: http://core.svn.wordpress.org/trunk@28096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 04:22:14 +00:00
Andrew Nacin
6295631a4b Customizer: Avoid hiding 'Remove' buttons unrelated to custom headers. 
props rzen, ehg.
fixes #27848.

Built from https://develop.svn.wordpress.org/trunk@28266


git-svn-id: http://core.svn.wordpress.org/trunk@28094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 04:14:14 +00:00