Commit Graph

6918 Commits

Author SHA1 Message Date
Gary Pendergast
2f53c1ada2 Tests: Use the default_storage_engine MySQL option on newer MySQL versions.
In MySQL 5.5.3, `storage_engine` was deprecated in favour of `default_storage_engine`, and subsequently removed in MySQL 5.7. To avoid errors when running tests on MySQL 5.7, we need to switch between the options based on MySQL version.

Props skithund, jeremyfelt.

Fixes #34692.


Built from https://develop.svn.wordpress.org/trunk@36055


git-svn-id: http://core.svn.wordpress.org/trunk@36020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-21 22:27:25 +00:00
Drew Jaynes
79705d5cc1 Docs: Fix a typo in the 4.4.0 changlog entry in the intermediate_image_sizes_advanced hook doc.
Props morganestes.
Fixes #35190.

Built from https://develop.svn.wordpress.org/trunk@36054


git-svn-id: http://core.svn.wordpress.org/trunk@36019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-21 22:24:27 +00:00
Andrea Fercia
dc31b503ec Accessibility: Remove the revisions limit title attribute from the Publish box.
The revisions limit warning is now always displayed in plain text even when the
limit is not reached yet. Removes the plus "+" from the revisions count number.

Fixes #35029.
Built from https://develop.svn.wordpress.org/trunk@36053


git-svn-id: http://core.svn.wordpress.org/trunk@36018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-21 14:39:28 +00:00
John Blackbourn
779d639c85 Tests: Prevent role capability pollution in Tests_Post_GetPostsByAuthorSql::test_user_has_access_only_to_private_posts_for_certain_post_types().
Built from https://develop.svn.wordpress.org/trunk@36050


git-svn-id: http://core.svn.wordpress.org/trunk@36015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-21 07:16:29 +00:00
John Blackbourn
bfc3302852 Tests: Fix all the things.
See #30017, #32394

Built from https://develop.svn.wordpress.org/trunk@36049


git-svn-id: http://core.svn.wordpress.org/trunk@36014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-21 07:10:27 +00:00
John Blackbourn
405d5ba71d Query: Re-initialise any dynamically-added public query vars before running the public query vars test.
See #35115

Built from https://develop.svn.wordpress.org/trunk@36048


git-svn-id: http://core.svn.wordpress.org/trunk@36013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-21 07:00:28 +00:00
John Blackbourn
3fdd127ce2 Tests: Shave a second off the user capability tests by reusing its user fixtures.
See #30017, #32394

Built from https://develop.svn.wordpress.org/trunk@36047


git-svn-id: http://core.svn.wordpress.org/trunk@36012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-21 06:57:37 +00:00
John Blackbourn
45019c3467 Query: Introduce a unit test which will fail when new public query vars are introduced without also updating the test. This adds an extra layer of explicitness to introducing public query vars in order to avoid introducing unintentional clashes with URL query vars that are already in use.
See #35115 

Built from https://develop.svn.wordpress.org/trunk@36045


git-svn-id: http://core.svn.wordpress.org/trunk@36010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-21 05:49:28 +00:00
John Blackbourn
d4eb85569b Login: Revert [34213] and [35897]. It has become apparent that there is a need for a separate function (and corresponding filter) which allows for the login form action URL to differ from the URL used to access the login form, so that plugins or implementations which change the login URL do not need to worry about handling the form submission at the same URL.
For now, we'll revert to the pre-4.4 behaviour of hard-coding the login form action URL as `wp-login.php` and look at implementing a separate function and corresponding filter in 4.5.

Props KrissieV, salcode, JPry
Fixes #34925
See #35103

Built from https://develop.svn.wordpress.org/trunk@36042


git-svn-id: http://core.svn.wordpress.org/trunk@36007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-21 03:23:29 +00:00
Boone Gorges
26caa329f2 Respect approval status when determining comment page count in comments_template().
Since 4.4, when fetching the first page of comments and the 'newest' comments
are set to display first, `comments_template()` must perform arithmetic to
determine which comments to show. See #8071. This arithmetic requires the
total comment count for the current post, which is calculated with a separate
`WP_Comment_Query`. This secondary comment query did not properly account for
non-approved comment statuses; all unapproved comments should be part of the
comment count for admins, and individual users should have their own
unapproved comments included in the count. As a result, `comments_template()`
was, in some cases, being fooled into thinking that a post had fewer comments
available for pagination than it actually had, which resulted in empty pages
of comments.

We correct this problem by mirroring 'status' and 'include_unapproved' params
of the main comment query within the secondary query used to calculate
pagination.

Fixes #35068.
Built from https://develop.svn.wordpress.org/trunk@36040


git-svn-id: http://core.svn.wordpress.org/trunk@36005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-21 03:07:32 +00:00
John Blackbourn
afc7f43ca0 Comments: When a comment is submitted, ensure the user_ID element in the array that's passed to the preprocess_comment filter gets populated.
Fixes #34997

Built from https://develop.svn.wordpress.org/trunk@36038


git-svn-id: http://core.svn.wordpress.org/trunk@36003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-21 02:47:26 +00:00
Gary Pendergast
ba8b95cdbe Texturize: Transform & into & in tag attributes.
[35709] was overly broad, and stopped transforming `&` characters within tag attributes. So that sites aren't generating invalid HTML, we need to restore this functionality, while continuing to not transform `&` within blocked tags.

Fixes #35008 for trunk.


Built from https://develop.svn.wordpress.org/trunk@36036


git-svn-id: http://core.svn.wordpress.org/trunk@36001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-21 02:43:26 +00:00
Gary Pendergast
dbf5d782ad Query: Remove title from the public query vars list.
[33706] added `title` as a public query var, but there's not really a practical need for this, and it interferes with any plugin that uses `title` as a query var for itself.

Props tyxla.

Fixes #35115 for trunk.


Built from https://develop.svn.wordpress.org/trunk@36034


git-svn-id: http://core.svn.wordpress.org/trunk@35999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-21 00:43:27 +00:00
Drew Jaynes
a28bfe8ba6 Docs: Add missing notations for the optional $tab_index and $extended parameters in the DocBlock for the deprecated the_editor() function.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36033


git-svn-id: http://core.svn.wordpress.org/trunk@35998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-20 21:21:27 +00:00
Andrea Fercia
7849bb7d94 Accessibility: Remove title attributes from the updates links on the Plugin and Themes list tables.
Adds `aria-label` attributes on some links and on the "update nag" link. Adds translator comments.

Fixes #35167.
Built from https://develop.svn.wordpress.org/trunk@36032


git-svn-id: http://core.svn.wordpress.org/trunk@35997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-20 16:09:28 +00:00
Andrew Ozz
6e49a963b1 Responsive images: fix calculations when determining whether to include particular image file in srcset.
Props joemcgill.
Fixes #34955 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36031


git-svn-id: http://core.svn.wordpress.org/trunk@35996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-20 02:39:32 +00:00
Drew Jaynes
5399b2137f Docs: Add missing parameter and return notations to the DocBlock for the deprecated get_usernumposts() function.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36030


git-svn-id: http://core.svn.wordpress.org/trunk@35995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-19 19:41:30 +00:00
Eric Lewis
e844695e12 Docs: Add documentation to wp-blog-header.php.
Fixes #35161.

Built from https://develop.svn.wordpress.org/trunk@36029


git-svn-id: http://core.svn.wordpress.org/trunk@35994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-19 11:20:28 +00:00
Drew Jaynes
013d1178e5 Docs: Add missing parameter and return notations in the DocBlock for get_profile().
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36028


git-svn-id: http://core.svn.wordpress.org/trunk@35993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-19 09:04:26 +00:00
Drew Jaynes
543420158f Docs: Properly mark the $classname parameter as optional.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36027


git-svn-id: http://core.svn.wordpress.org/trunk@35992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-19 09:00:26 +00:00
Drew Jaynes
eb158d65c7 Docs: Add missing parameter and return notations to the DocBlock for the deprecated wp_specialchars() function.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36026


git-svn-id: http://core.svn.wordpress.org/trunk@35991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-19 08:58:25 +00:00
Drew Jaynes
57878dd1b9 Docs: Add missing parameter notations and descriptions in the DocBlock for get_link().
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36025


git-svn-id: http://core.svn.wordpress.org/trunk@35990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-19 08:54:26 +00:00
Drew Jaynes
932c91b766 Docs: Add missing parameter and return notations in the DocBlock for the deprecated _nc() function.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36024


git-svn-id: http://core.svn.wordpress.org/trunk@35989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-19 08:48:27 +00:00
Drew Jaynes
7b1ac33dee Docs: Add a missing summary, parameter, and return descriptiosn to the DocBlock for the deprecated function, get_linkrating().
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36023


git-svn-id: http://core.svn.wordpress.org/trunk@35988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-19 08:23:26 +00:00
Drew Jaynes
df0c1aa0ed Docs: Add a missing notation for the $gmt_time parameter in the DocBlock for spawn_cron().
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36022


git-svn-id: http://core.svn.wordpress.org/trunk@35987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-19 08:20:27 +00:00
Drew Jaynes
decb25a8ae Docs: Add missing DocBlocks for hash_hmac() and _hash_hmac().
Both will be ignored from parsing as and serve as compat functions for PHP's `hash_hmac()`.

Introduced in [18111].

See #32246.

Built from https://develop.svn.wordpress.org/trunk@36021


git-svn-id: http://core.svn.wordpress.org/trunk@35986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-19 05:11:27 +00:00
Drew Jaynes
c10ec122ca Docs: Fix inline comment syntax in _mb_strlen(), an internal compat method for mb_strlen().
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36020


git-svn-id: http://core.svn.wordpress.org/trunk@35985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-19 04:59:33 +00:00
Drew Jaynes
87786b4373 Docs: Add missing DocBlocks for mb_strlen() and _mb_strlen().
Both will be ignored from parsing as and serve as compat functions for PHP's `mb_strlen()`, which is not enabled by default.

Introduced in [32114].

See #32246.

Built from https://develop.svn.wordpress.org/trunk@36019


git-svn-id: http://core.svn.wordpress.org/trunk@35984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-19 04:56:29 +00:00
Drew Jaynes
9e04750fc4 Docs: Fix inline comment syntax in _mb_substr(), an internal compat method for mb_substr().
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36018


git-svn-id: http://core.svn.wordpress.org/trunk@35983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-19 04:50:28 +00:00
Drew Jaynes
be6589730d Docs: Add missing DocBlocks for mb_substr() and _mb_substr().
Both will be ignored from parsing as and serve as compat functions for PHP's `mb_substr()`, which is not enabled by default.

Introduced in [17621].

See #32246.

Built from https://develop.svn.wordpress.org/trunk@36017


git-svn-id: http://core.svn.wordpress.org/trunk@35982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-19 04:47:28 +00:00
Andrea Fercia
67e1f55c4b Accessibility: Remove title attributes and improve accessibility on the "no-js" Menus screen.
When JavaScript is off, the reorder menu item and Edit menu item links now use `aria-label`
attributes instead of title attributes.

Fixes #35134.
Built from https://develop.svn.wordpress.org/trunk@36016


git-svn-id: http://core.svn.wordpress.org/trunk@35981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-19 00:17:26 +00:00
Andrea Fercia
5787972a67 Accessibility: Remove title attributes from the Theme browser.
Also, adds translators comments and removes a no more used variable, see [27748].

Fixes #35140.
Built from https://develop.svn.wordpress.org/trunk@36015


git-svn-id: http://core.svn.wordpress.org/trunk@35980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-19 00:00:29 +00:00
Andrea Fercia
f7f14d94f3 Accessibility: Improvements for the Authentication Check modal dialog "Close X".
Removes the title attribute and uses a `<button>` element instead of a `<div>`.
Also simplifies the CSS and takes care of the hover/focus style.

Fixes #35142.
Built from https://develop.svn.wordpress.org/trunk@36014


git-svn-id: http://core.svn.wordpress.org/trunk@35979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-18 23:51:26 +00:00
Drew Jaynes
05e0d7c3c3 Docs: Add missing parameter and return descriptions to the DocBlocks for _wp_object_name_sort_cb() and _wp_object_count_sort_cb(), both uasort() callbacks.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36013


git-svn-id: http://core.svn.wordpress.org/trunk@35978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-18 23:38:26 +00:00
Drew Jaynes
9b89047bf2 Docs: Add a missing notation for the $context parameter in the DocBlock for _nx_noop().
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36012


git-svn-id: http://core.svn.wordpress.org/trunk@35977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-18 23:16:26 +00:00
Drew Jaynes
13bead9e58 Docs: Fix the syntax for the get_previous_post_link() DocBlock to ensure it's read and parsed as such instead of as a multi-line comment.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36011


git-svn-id: http://core.svn.wordpress.org/trunk@35976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-18 23:14:26 +00:00
Drew Jaynes
f4af7643d8 Docs: Add a missing summary, description, and @since version to the DocBlock for wp_redirect_admin_locations().
Introduced in [19880].

See #32246.

Built from https://develop.svn.wordpress.org/trunk@36010


git-svn-id: http://core.svn.wordpress.org/trunk@35975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-18 23:08:26 +00:00
Drew Jaynes
907e0ce6f1 Docs: Add a missing notation for the $bookmark_id parameter in the DocBlock for clean_bookmark_cache().
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36009


git-svn-id: http://core.svn.wordpress.org/trunk@35974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-18 23:01:28 +00:00
Boone Gorges
31db92d83e Add current-cat-ancestor class to ancestor items in wp_list_categories().
Pairs nicely with `current-cat-parent`.

Props jrchamp, swisssipdy, ardathksheyna, wonderboymusic.
Fixes #10676.
Built from https://develop.svn.wordpress.org/trunk@36008


git-svn-id: http://core.svn.wordpress.org/trunk@35973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-18 18:38:25 +00:00
Aaron Jorbin
0eaedf734f Remove RDIO from oEmbed providers
RDIO is shutting down. https://www.rdio.com/farewell/

Props swissspidy
Fixes #35152


Built from https://develop.svn.wordpress.org/trunk@36007


git-svn-id: http://core.svn.wordpress.org/trunk@35972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-18 18:16:27 +00:00
Boone Gorges
b2f4f73633 Ensure that wp_list_categories() supports comma-separated lists for 'exclude' and 'exclude_tree'.
[34696] introduced a regression whereby comma-separated values for 'exclude'
and 'exclude_tree' would be handled improperly when merging the two parameters,
resulting in category IDs being incorrectly dropped from the combined array.

Props gblsm, hnle.
Fixes #35156.
Built from https://develop.svn.wordpress.org/trunk@36005


git-svn-id: http://core.svn.wordpress.org/trunk@35970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-18 18:12:25 +00:00
Boone Gorges
5d46c03508 Ensure get_terms() results are unique when using 'meta_query'.
The introduction of 'meta_query' to `get_terms()` in 4.4 made it possible for
`get_terms()` to erroneously return duplicate results. To address the issue,
we add the `DISTINCT` keyword to the SQL query when a 'meta_query' parameter
has been provided.

Props @jadpm.
Fixes #35137.
Built from https://develop.svn.wordpress.org/trunk@36003


git-svn-id: http://core.svn.wordpress.org/trunk@35968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-18 17:44:25 +00:00
Sergey Biryukov
3f35196e48 Docs: Fix copy/paste error in wp_remote_retrieve_cookies() description.
Props mark8barnes.
Fixes #35157.
Built from https://develop.svn.wordpress.org/trunk@36002


git-svn-id: http://core.svn.wordpress.org/trunk@35967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-18 17:23:29 +00:00
Sergey Biryukov
ff36a54824 Widgets: Add missing closing tag for spinner after [35317].
Props rabmalin.
Fixes #35150.
Built from https://develop.svn.wordpress.org/trunk@36001


git-svn-id: http://core.svn.wordpress.org/trunk@35966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-18 12:02:28 +00:00
Andrea Fercia
6fdd27a1d6 Accessibility: Remove the title attribute from the Featured Image postbox thumbnail.
The title attribute is now replaced with plain text in a `howto` paragraph, as done for example in the Tags postbox.
Adds an `aria-describedby` attribute on the thumbnail link to target the description.
Also, fixes the focus style on the featured image thumbnail.

Fixes #35076.
Built from https://develop.svn.wordpress.org/trunk@36000


git-svn-id: http://core.svn.wordpress.org/trunk@35965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 23:44:26 +00:00
Pascal Birchler
a7e13d0af9 Editor: Correctly indent definition lists when switching from the visual to the text editor.
Props ocean90, katieburch.
Fixes #23299.
Built from https://develop.svn.wordpress.org/trunk@35999


git-svn-id: http://core.svn.wordpress.org/trunk@35964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 23:06:25 +00:00
Andrea Fercia
e8b900d9f5 Accessibility: Remove title attributes from the Link Manager screen.
Title attributes are now replaced with `aria-label` where appropriate.
Also fixes some typos in the DocBlocks.

Fixes #35135.
Built from https://develop.svn.wordpress.org/trunk@35998


git-svn-id: http://core.svn.wordpress.org/trunk@35963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 22:53:28 +00:00
Pascal Birchler
333bdb535a Remove unused variables after [35995] and [35996].
See #34439.
Built from https://develop.svn.wordpress.org/trunk@35997


git-svn-id: http://core.svn.wordpress.org/trunk@35962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 18:41:27 +00:00
Pascal Birchler
51bb4db622 Network Admin: Remove the list of files which will be deleted when deleting a theme.
Fixes #34439.
Built from https://develop.svn.wordpress.org/trunk@35996


git-svn-id: http://core.svn.wordpress.org/trunk@35961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 18:35:26 +00:00
Pascal Birchler
740d197731 Plugins: Remove the list of files which will be deleted when uninstalling a plugin.
See #34439.
Built from https://develop.svn.wordpress.org/trunk@35995


git-svn-id: http://core.svn.wordpress.org/trunk@35960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 18:31:27 +00:00
Pascal Birchler
7b6c596e92 In WP::handle_404(), make sure $wp_query->post is a WP_Post object before cloning it.
Props igmoweb for initial patch.
See #35013.
Built from https://develop.svn.wordpress.org/trunk@35994


git-svn-id: http://core.svn.wordpress.org/trunk@35959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 18:13:29 +00:00
Drew Jaynes
9572878fab Docs: Add missing parameter notations to the DocBlock for get_author_posts_url().
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35993


git-svn-id: http://core.svn.wordpress.org/trunk@35958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 17:30:43 +00:00
Drew Jaynes
76cc768e90 Docs: Add a better summary, missing @since version, parameter and return descriptions to the DocBlock for _get_widget_id_base().
Introduced in [11484].

See #32246.

Built from https://develop.svn.wordpress.org/trunk@35992


git-svn-id: http://core.svn.wordpress.org/trunk@35957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 17:27:28 +00:00
Drew Jaynes
94575687b9 Docs: Add a missing summary, @since version, and parameter descriptions in the DocBlock for _register_widget_form_callback().
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35991


git-svn-id: http://core.svn.wordpress.org/trunk@35956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 17:23:26 +00:00
Drew Jaynes
c13824b1c0 Docs: Fix syntax for marking parameters optional in the DocBlock for is_active_widget().
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35990


git-svn-id: http://core.svn.wordpress.org/trunk@35955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 17:19:26 +00:00
Drew Jaynes
9de8a1466a Docs: Add a missing summary, @since version, and parameter descriptions to the DocBlock for _register_widget_update_callback().
Introduced in [10798].

See #32246.

Built from https://develop.svn.wordpress.org/trunk@35989


git-svn-id: http://core.svn.wordpress.org/trunk@35954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 17:16:26 +00:00
Boone Gorges
6d4bc4d88e Better focus in tag cloud tests.
We should avoid testing complete markup strings, unless we are specifically
testing for the format of the markup.

Fixes #35138.
Built from https://develop.svn.wordpress.org/trunk@35988


git-svn-id: http://core.svn.wordpress.org/trunk@35953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 17:12:30 +00:00
Boone Gorges
61679499b1 More focused test for post_type in tag cloud links.
We should not be testing the entire tag cloud markup, as it leads to collateral
damage wheneven `wp_generate_tag_cloud()` is touched. See [35984].

See #25566, #35138.
Built from https://develop.svn.wordpress.org/trunk@35987


git-svn-id: http://core.svn.wordpress.org/trunk@35952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 16:56:26 +00:00
Drew Jaynes
28412d2ef2 Docs: Add missing parameter and return descriptions to the DocBlock for _wp_get_user_contactmethods().
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35986


git-svn-id: http://core.svn.wordpress.org/trunk@35951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 16:41:27 +00:00
Drew Jaynes
b6281e857f Docs: Add a missing summary and @since version to the DocBlock for _maybe_update_core().
Introduced in [10583].

See #32246.

Built from https://develop.svn.wordpress.org/trunk@35985


git-svn-id: http://core.svn.wordpress.org/trunk@35950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 16:38:26 +00:00
Boone Gorges
20651de171 Introduce 'tag-link-position-x' class to tag cloud links.
The new class describes the cardinal position of a link in the cloud, allowing
more fine-grained CSS and JS targeting.

Props Mte90, chmac.
Fixes #5172.
Built from https://develop.svn.wordpress.org/trunk@35984


git-svn-id: http://core.svn.wordpress.org/trunk@35949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-17 16:27:28 +00:00
Andrea Fercia
2cc4ca6875 Accessibility: Improvements for the "Send Trackbacks" postbox.
Adds an `aria-describedby` attribute targeting the input field description and styles the description as a... description.

Fixes #35123.
Built from https://develop.svn.wordpress.org/trunk@35983


git-svn-id: http://core.svn.wordpress.org/trunk@35948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 23:37:26 +00:00
Drew Jaynes
d5a9811f02 Docs: Add a missing summary, parameter, and return notations to the DocBlock for strip_shortcode_tag().
Introduced in [18952].

See #32246.

Built from https://develop.svn.wordpress.org/trunk@35982


git-svn-id: http://core.svn.wordpress.org/trunk@35947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 23:23:26 +00:00
Drew Jaynes
81abb11839 Docs: Add a missing notation for the $args parameter in the DocBlock for wp_get_post_revisions().
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35981


git-svn-id: http://core.svn.wordpress.org/trunk@35946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 23:18:26 +00:00
Drew Jaynes
7b19006ce1 Docs: Add missing parameter and return notations to the DocBlock for _wp_sanitize_utf8_in_redirect().
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35980


git-svn-id: http://core.svn.wordpress.org/trunk@35945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 23:15:27 +00:00
Drew Jaynes
bc4a65a036 Docs: Clarify the summary and add missing parameter notations to the DocBlock for _wp_delete_tax_menu_item().
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35979


git-svn-id: http://core.svn.wordpress.org/trunk@35944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 23:11:25 +00:00
Sergey Biryukov
20d779ea8c Widgets: Remove extra quotes from widget title in WP_Widget_RSS, accidentally added in [33814].
Props ShinichiN.
Fixes #34978 for trunk.
Built from https://develop.svn.wordpress.org/trunk@35978


git-svn-id: http://core.svn.wordpress.org/trunk@35943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 22:35:27 +00:00
Andrea Fercia
f83c787887 Accessibility: Correctly associate the search input label in the new Themes favorites tab introduced in [35527].
Fixes #35122.
Built from https://develop.svn.wordpress.org/trunk@35977


git-svn-id: http://core.svn.wordpress.org/trunk@35942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 22:30:27 +00:00
Pascal Birchler
fa9b71e423 Docs: Document the default value for the $validate parameter in the validate_current_theme hook docs.
See #32246.
Built from https://develop.svn.wordpress.org/trunk@35976


git-svn-id: http://core.svn.wordpress.org/trunk@35941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 20:10:25 +00:00
Pascal Birchler
b6c660c38f Docs: Clarify the return value for wp_create_categories().
See #32246.
Built from https://develop.svn.wordpress.org/trunk@35975


git-svn-id: http://core.svn.wordpress.org/trunk@35940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 19:59:27 +00:00
Pascal Birchler
1b86ccd006 Docs: Correct a parameter name for the press_this_redirect_in_parent filter.
See #32246.
Built from https://develop.svn.wordpress.org/trunk@35974


git-svn-id: http://core.svn.wordpress.org/trunk@35939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 19:43:26 +00:00
Pascal Birchler
624cb1445d Docs: Correct a parameter name for the force_filtered_html_on_import filter.
See #32246.
Built from https://develop.svn.wordpress.org/trunk@35973


git-svn-id: http://core.svn.wordpress.org/trunk@35938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 19:40:26 +00:00
Pascal Birchler
4e6e728703 Docs: Correct a parameter name for the validate_current_theme filter.
See #32246.
Built from https://develop.svn.wordpress.org/trunk@35972


git-svn-id: http://core.svn.wordpress.org/trunk@35937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 19:36:28 +00:00
Pascal Birchler
4a6d77c8e5 Docs: Correct a parameter name for the allow_subdirectory_install filter.
See #32246.
Built from https://develop.svn.wordpress.org/trunk@35971


git-svn-id: http://core.svn.wordpress.org/trunk@35936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 19:32:26 +00:00
Pascal Birchler
2e35e20010 Docs: Correct a parameter name for the do_mu_upgrade filter.
See #32246.
Built from https://develop.svn.wordpress.org/trunk@35970


git-svn-id: http://core.svn.wordpress.org/trunk@35935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 19:30:28 +00:00
John Blackbourn
26dfc6159f Correct a parameter name for the allow_password_reset filter so its entry on developer.wordpress.org displays correctly.
See #32246

Built from https://develop.svn.wordpress.org/trunk@35969


git-svn-id: http://core.svn.wordpress.org/trunk@35934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 19:20:26 +00:00
Drew Jaynes
3cba9d7f61 Docs: Add missing parameter descriptions to the DocBlock for WP_Query::set_found_posts().
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35968


git-svn-id: http://core.svn.wordpress.org/trunk@35933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 18:11:26 +00:00
Drew Jaynes
ee0335e930 Docs: Add a missing summary to the DocBlock for WP_Locale::rtl_src_admin_notice().
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35967


git-svn-id: http://core.svn.wordpress.org/trunk@35932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 18:08:26 +00:00
Drew Jaynes
c9a11ae9f2 Docs: Mark the upgrade_XX() functions to be ignored from parsing for the Code Reference.
There is no great value in generating reference pages for these funcitons as they explicitly serve a core-only purpose.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@35966


git-svn-id: http://core.svn.wordpress.org/trunk@35931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 17:59:27 +00:00
Drew Jaynes
36367e7f6e Docs: Add missing DocBlocks, including summaries and @since versions, to the __construct() and init() methods in WP_Scripts.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35965


git-svn-id: http://core.svn.wordpress.org/trunk@35930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 17:48:27 +00:00
Drew Jaynes
25eca6974e Docs: Add a missing summary, @since version, and parameter descriptions to the DocBlock for wp_xmlrpc_server::pingback_error().
Introduced in [23329]. Also corrects return descriptions for two deprecated methods.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@35964


git-svn-id: http://core.svn.wordpress.org/trunk@35929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 17:38:27 +00:00
Drew Jaynes
7614bd71d3 Docs: Add a missing summary, @since version, and parameter descriptions to the DocBlock for wp_xmlrpc_server::add_enclosure_if_new().
Introduced in [10383].

See #32246.

Built from https://develop.svn.wordpress.org/trunk@35963


git-svn-id: http://core.svn.wordpress.org/trunk@35928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 17:32:28 +00:00
Drew Jaynes
92dd7b7447 Docs: Add missing notations for the unused $args parameter in the blogger_getTemplate() and blogger_setTemplate() methods in wp_xmlrpc_server.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35962


git-svn-id: http://core.svn.wordpress.org/trunk@35927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 17:26:28 +00:00
Drew Jaynes
d057c51893 Docs: Add missing property and method summaries in DocBlocks for Walker_PageDropdown.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35961


git-svn-id: http://core.svn.wordpress.org/trunk@35926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 16:36:28 +00:00
Sergey Biryukov
ae37057114 KSES: Allow the reversed attribute for <ol>.
Props lancewillett.
Fixes #35079.
Built from https://develop.svn.wordpress.org/trunk@35960


git-svn-id: http://core.svn.wordpress.org/trunk@35924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 09:54:26 +00:00
Sergey Biryukov
6ffc7914f1 I18N: Add a unit test for before_last_bar().
Props realloc.
Fixes #35073.
Built from https://develop.svn.wordpress.org/trunk@35959


git-svn-id: http://core.svn.wordpress.org/trunk@35923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 08:04:26 +00:00
Sergey Biryukov
f9f77d86d8 Accessibility: Add missing label for the theme upload input.
See [11152] for plugins.

Props mercime.
Fixes #35113.
Built from https://develop.svn.wordpress.org/trunk@35958


git-svn-id: http://core.svn.wordpress.org/trunk@35922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 07:56:29 +00:00
Drew Jaynes
fcd35518d9 Docs: Add a missing notation for the $args parameter in the DocBlock for wp_xmlrpc_server::_multisite_getUsersBlogs().
Also adds a missing `@since` version. The method was introduced in [12852].

See #32246.

Built from https://develop.svn.wordpress.org/trunk@35957


git-svn-id: http://core.svn.wordpress.org/trunk@35921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 05:49:26 +00:00
Drew Jaynes
489023e001 Docs: Add a missing summary and @since version to the DocBlock for wp_xmlrpc_server::serve_request().
Introduced in [11789].

See #32246.

Built from https://develop.svn.wordpress.org/trunk@35956


git-svn-id: http://core.svn.wordpress.org/trunk@35920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 05:43:26 +00:00
Drew Jaynes
4ced4fce3a Docs: Add missing summaries and @since versions to DocBlocks for the _get_display_callback(), _get_update_callback(), and _get_form_callback() methods in WP_Widget.
Introduced in [10764].

See #32246.

Built from https://develop.svn.wordpress.org/trunk@35955


git-svn-id: http://core.svn.wordpress.org/trunk@35919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 05:39:25 +00:00
Drew Jaynes
2dda796547 Docs: Add variadic markers to the optional $object_id parameter notation for WP_User::has_cap().
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35954


git-svn-id: http://core.svn.wordpress.org/trunk@35918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 05:32:28 +00:00
Andrea Fercia
c69481a410 Accessibility: Remove title attributes from the Plugin Cards on the Plugin install screen.
Fixes #35050.
Built from https://develop.svn.wordpress.org/trunk@35953


git-svn-id: http://core.svn.wordpress.org/trunk@35917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 22:33:28 +00:00
Andrea Fercia
6dac60da98 Accessibility: add missing labels for Plugins and Themes checkboxes in the Updates screen.
Also, adds translator comments and improves readability.

Props SergeyBiryukov, afercia, oaron for the initial patch.
Fixes #34774.
Built from https://develop.svn.wordpress.org/trunk@35952


git-svn-id: http://core.svn.wordpress.org/trunk@35916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 22:18:30 +00:00
Sergey Biryukov
c2fcab7d82 I18N: After [35884], remove html_entity_decode() for the thousands separator in WP_Locale::init(), use the &nbsp; entity directly.
We can't `get_option( 'blog_charset' )` here, because the database may not be available.

Fixes #10373.
Built from https://develop.svn.wordpress.org/trunk@35951


git-svn-id: http://core.svn.wordpress.org/trunk@35915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 21:35:29 +00:00
Dominik Schilling
bc6b11d0de Revert [35949].
Passing an object to `wp_list_pluck()` throws also a fatal error, see https://3v4l.org/9YsaD.

See #35087.
Built from https://develop.svn.wordpress.org/trunk@35950


git-svn-id: http://core.svn.wordpress.org/trunk@35914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 19:50:29 +00:00
Pascal Birchler
ac940d0587 Ensure wp_list_pluck() throws a warning when not being passed an array.
We should not paper over the code and hide warnings from developers by casting values to an array.

See #35087.
Built from https://develop.svn.wordpress.org/trunk@35949


git-svn-id: http://core.svn.wordpress.org/trunk@35913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 18:29:29 +00:00
Rachel Baker
719239ca1e Comments: Use an integer as the default value for comment_post_ID in wp_insert_comment to match database column.
Props MikeHansenMe, juanfra, rabmalin. 
Fixes #34956


Built from https://develop.svn.wordpress.org/trunk@35948


git-svn-id: http://core.svn.wordpress.org/trunk@35912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 15:13:27 +00:00
Andrea Fercia
282e7c36eb Accessibility: Add an ARIA role button to links that behave like buttons when JavaScript is on.
Introduces a simple way to give a proper semantics of `button` to links that behave
like UI controls when JavaScript is on and behave like actual links when JavaScript
is off. First implementation on the Terms list table.

Patch prepared during WordCamp US 2015 Contributor Day.

Props mcapybara, garusky, takayukister.

See #26504.
Fixes #34867.
Built from https://develop.svn.wordpress.org/trunk@35947


git-svn-id: http://core.svn.wordpress.org/trunk@35911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 13:25:28 +00:00
Dion Hulse
8db5455eea Filesystem: Avoid PHP warnings when using the FTP Sockets class.
See #35026 

Built from https://develop.svn.wordpress.org/trunk@35946


git-svn-id: http://core.svn.wordpress.org/trunk@35910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 03:12:26 +00:00
Dion Hulse
bda1b2ace9 Filesystem: Revert [33648] and [34733] unfortunately these have caused issues for some servers, while fixing it for others.
See #28013

Fixes #34976 for trunk
Fixes #34976 for trunk

Built from https://develop.svn.wordpress.org/trunk@35944


git-svn-id: http://core.svn.wordpress.org/trunk@35908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 02:36:28 +00:00
Weston Ruter
3fdb8bafc4 Customize: Ensure that "Change" button appears when there are only 2 themes.
Fixes defect introduced in [35535].

Props igmoweb.
See #34549.
Fixes #35081.

Built from https://develop.svn.wordpress.org/trunk@35943


git-svn-id: http://core.svn.wordpress.org/trunk@35907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 01:21:26 +00:00
Dion Hulse
060476a1f2 Filesystem API: Cast the port to an int in the FTPSockets class. PemFTP requires that the port be specified as an integer, not a numeric string.
Fixes #35088

Built from https://develop.svn.wordpress.org/trunk@35942


git-svn-id: http://core.svn.wordpress.org/trunk@35906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 00:29:26 +00:00
Drew Jaynes
10367a4692 Docs: Add missing parameter and return descriptions to the DocBlock for WP_Rewrite::iis7_url_rewrite_rules().
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35941


git-svn-id: http://core.svn.wordpress.org/trunk@35905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 23:58:27 +00:00
Drew Jaynes
af5f4a0d9c Docs: Add missing parameter documentation for the $args parameter in the DocBlock for WP_Http_Streams::test().
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35940


git-svn-id: http://core.svn.wordpress.org/trunk@35904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 23:54:26 +00:00
Drew Jaynes
338b618fc0 Docs: Remove an extra 'arguments' introduced in [35938].
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35939


git-svn-id: http://core.svn.wordpress.org/trunk@35903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 23:52:25 +00:00
Drew Jaynes
edb1dc0f36 Docs: Add missing parameter documentation for the $args parameter in the DocBlock for WP_Http_Curl::test().
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35938


git-svn-id: http://core.svn.wordpress.org/trunk@35902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 23:43:26 +00:00
Drew Jaynes
64ea48f76a Docs: Add missing parameter and return descriptions to the DocBlock for WP_Http_Curl::stream_body().
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35937


git-svn-id: http://core.svn.wordpress.org/trunk@35901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 23:41:26 +00:00
Drew Jaynes
8d884c25a3 Docs: Clarify documentation for WP_Role::has_cap() to more clearing indicate that the method checks for capabilities against the role rather than the user.
Also updates syntax in the DocBlock summary and description.

Props GunGeekATX for the initial patch.
Fixes #35080.

Built from https://develop.svn.wordpress.org/trunk@35935


git-svn-id: http://core.svn.wordpress.org/trunk@35899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 20:05:27 +00:00
Boone Gorges
3bc0e35684 Omit cpage query var in comment link if comment pagination is disabled.
WP 4.4 changed the way comment pagination is calculated. See #8071. In the
context of `get_comment_link()`, these changes introduced a regression that
causes `cpage` (or its pretty-permalink correlate `comment-page-x`) to appear
in comment links when comment pagination is disabled. The current changeset
fixes the regression.

Fixes #34946.
Built from https://develop.svn.wordpress.org/trunk@35933


git-svn-id: http://core.svn.wordpress.org/trunk@35897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 19:46:46 +00:00
Boone Gorges
b6dbe1cea9 Don't use array_merge() when building comment children arrays.
`array_merge()` is much slower than building the combined array using a
`foreach` loop. The performance difference was causing a speed regression with
the `get_children()` functionality introduced in 4.4.

Props rogerhub.
Fixes #35025.
Built from https://develop.svn.wordpress.org/trunk@35931


git-svn-id: http://core.svn.wordpress.org/trunk@35895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 19:37:43 +00:00
Drew Jaynes
0c59fd02bb Docs: Add missing parameter and return descriptions to the DocBlock for WP_Http_Curl::stream_headers().
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35930


git-svn-id: http://core.svn.wordpress.org/trunk@35894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 19:21:35 +00:00
Drew Jaynes
f32fba3dab Docs: Add more complete property and method documentation for Walker_Page.
* Adds missing DocBlock summaries
* Adds missing `@param` descriptions
* Marks some optional parameters as such
* Reorders some DocBlock tags

See #32246.

Built from https://develop.svn.wordpress.org/trunk@35929


git-svn-id: http://core.svn.wordpress.org/trunk@35893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 18:06:31 +00:00
Drew Jaynes
fc9fa08592 Docs: Add a missing description for the $id parameter in the DocBlock for Walker_PageDropdown::start_el(), which is implemented by Walker but unused by the subclass method.
Also marks the other optional parameters as such.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@35928


git-svn-id: http://core.svn.wordpress.org/trunk@35892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 17:54:27 +00:00
Drew Jaynes
0fbe903434 Docs: Document the $id parameter for Walker_Comment::start_el(), which is implemented by Walker but unused in the subclass method.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35927


git-svn-id: http://core.svn.wordpress.org/trunk@35891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 17:50:26 +00:00
Drew Jaynes
5817eea3c9 Docs: Document the $id parameter for Walker_CategoryDropdown::start_el(), which is implemented by Walker but unused in the subclass method.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35926


git-svn-id: http://core.svn.wordpress.org/trunk@35890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 17:47:30 +00:00
Andrea Fercia
b5f5dff136 Authentication modal dialog: the spinner should disappear when loading is done.
Also, when using spinners as background images, the re-painted area should be the
smallest possible one. See similar performance issue in #33311.

Fixes #34951.
Built from https://develop.svn.wordpress.org/trunk@35925


git-svn-id: http://core.svn.wordpress.org/trunk@35889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 16:40:27 +00:00
Andrea Fercia
0faf2dd57b Accessibility: Remove title attributes from the Network Themes list table.
Title attributes in the "Themes" screen and in the "Edit Site" screen Themes tab
are now replaced with `aria-label` attributes. Also, replaces string
concatenation with `add_query_arg()` and `sprintf()` to allow translator
comments to be properly parsed and for better code readability.

Props SergeyBiryukov, afercia.
Fixes #35051.
Built from https://develop.svn.wordpress.org/trunk@35924


git-svn-id: http://core.svn.wordpress.org/trunk@35888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 16:07:39 +00:00
Sergey Biryukov
d0b7dd489e I18N: Remove <strong> tags from translatable strings in WP_Customize_Manager::register_controls() and WP_Customize_Header_Image_Control::render_content().
Add translator comments.

See #35039.
Built from https://develop.svn.wordpress.org/trunk@35923


git-svn-id: http://core.svn.wordpress.org/trunk@35887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 12:54:27 +00:00
Dion Hulse
ca7a95df36 Update random_compat to latest master (~1.1.5)
Changes:
 * Checks `disable_classes` for `COM()` before using to avoid PHP Warnings
 * Uses `stream_set_chunk_size()` to avoid reading 8KiB from `/dev/urandom` unintentionally.
See #34948

Built from https://develop.svn.wordpress.org/trunk@35922


git-svn-id: http://core.svn.wordpress.org/trunk@35886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 07:46:28 +00:00
Sergey Biryukov
36e8fa050f Docs: Capitalize 'URL' correctly in the_guid() DocBlock. Fix a typo.
See #32246.
Built from https://develop.svn.wordpress.org/trunk@35920


git-svn-id: http://core.svn.wordpress.org/trunk@35884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 05:21:26 +00:00
Dion Hulse
e8b2a769ee HTTP: Partially revert [34283] which removed the 1024bit certificates from our trust store.
Most browsers no longer trust 1024bit certificates, or certificates signed by them, instead verifying them by a trusted intermediate or a cross-sign from another trusted certificate.

Unfortunately, as it turns out, OpenSSL prior to 1.0.1g cannot correctly handle certificates chains such as this, even if one of the intermediates is trusted.
The solution is that we need to continue to trust the 1024bit legacy root certificates forthe foreseeable future

This adds the following certificates back into our trust store:
{{{
GTE CyberTrust Global Root
Thawte Server CA
Thawte Premium Server CA
Verisign Class 3 Public Primary Certification Authority
Verisign Class 3 Public Primary Certification Authority - G2
ValiCert Class 1 VA
ValiCert Class 2 VA
RSA Root Certificate 1
Entrust.net Secure Server CA
Equifax Secure Global eBusiness CA
Equifax Secure eBusiness CA 1
America Online Root Certification Authority 1
America Online Root Certification Authority 2
NetLock Business (Class B) Root
NetLock Express (Class C) Root
Verisign Class 3 Public Primary Certification Authority
}}}

Props rmccue
Fixes #34935 for trunk.

Built from https://develop.svn.wordpress.org/trunk@35919


git-svn-id: http://core.svn.wordpress.org/trunk@35883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 05:20:28 +00:00
John Blackbourn
4836d6c700 Correct the position of the $alt parameter's @param doc in image_add_caption().
See #32246

Built from https://develop.svn.wordpress.org/trunk@35918


git-svn-id: http://core.svn.wordpress.org/trunk@35882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 03:01:25 +00:00
Jeremy Felt
72c6868fae MS: Fix pagination in MS Sites List Table when entering a page number.
When a page number is manually entered in the sites list table and no bulk action is selected, add `paged` as a query argument to the redirect.

Fixes #32982.

Built from https://develop.svn.wordpress.org/trunk@35917


git-svn-id: http://core.svn.wordpress.org/trunk@35881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:59:27 +00:00
John Blackbourn
aace0e33c1 Correct some @param doc names in the WP_Tax_Query and WP_User_Query classes.
See #32246

Built from https://develop.svn.wordpress.org/trunk@35916


git-svn-id: http://core.svn.wordpress.org/trunk@35880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:50:27 +00:00
John Blackbourn
3f38dfa688 Correct a parameter name in the @param docs for get_home_url().
See #32246

Built from https://develop.svn.wordpress.org/trunk@35915


git-svn-id: http://core.svn.wordpress.org/trunk@35879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:45:27 +00:00
John Blackbourn
593cc9abbd Add missing @param docs to wp_safe_redirect() and wp_sanitize_redirect().
See #32246

Built from https://develop.svn.wordpress.org/trunk@35914


git-svn-id: http://core.svn.wordpress.org/trunk@35878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:43:25 +00:00
John Blackbourn
9f7165d522 Add missing @param doc to wp_hash().
See #32246

Built from https://develop.svn.wordpress.org/trunk@35913


git-svn-id: http://core.svn.wordpress.org/trunk@35877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:39:26 +00:00
John Blackbourn
c2248060fe Add missing variadic markers to the optional parameters of do_action() and apply_filters().
See #32246

Built from https://develop.svn.wordpress.org/trunk@35912


git-svn-id: http://core.svn.wordpress.org/trunk@35876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:36:25 +00:00
John Blackbourn
2984cdf457 Revert [35910].
Built from https://develop.svn.wordpress.org/trunk@35911


git-svn-id: http://core.svn.wordpress.org/trunk@35875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:35:26 +00:00
John Blackbourn
de7ccd262a Built from https://develop.svn.wordpress.org/trunk@35910
git-svn-id: http://core.svn.wordpress.org/trunk@35874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:33:25 +00:00
John Blackbourn
48380c58a5 Add missing @param doc to wp_check_password() and update the check_password filter docs.
See #32246

Built from https://develop.svn.wordpress.org/trunk@35909


git-svn-id: http://core.svn.wordpress.org/trunk@35873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:30:26 +00:00
John Blackbourn
b2e373d64d Correct the name of the @param doc for WP_Query::parse_tax_query().
See #32246

Built from https://develop.svn.wordpress.org/trunk@35908


git-svn-id: http://core.svn.wordpress.org/trunk@35872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:08:26 +00:00
John Blackbourn
6bb33fb2f4 Add a missing @param doc to wp_update_term_count().
See #32246

Built from https://develop.svn.wordpress.org/trunk@35907


git-svn-id: http://core.svn.wordpress.org/trunk@35871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:04:26 +00:00
John Blackbourn
e059193943 Remove a redundant @param tag from the_taxonomies().
See #32246

Built from https://develop.svn.wordpress.org/trunk@35906


git-svn-id: http://core.svn.wordpress.org/trunk@35870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 02:02:27 +00:00
Andrea Fercia
fa80eb011f Accessibility: remove title attributes from the available headers in the (no more used) custom-header.php screen.
Fixes #35062.
Built from https://develop.svn.wordpress.org/trunk@35905


git-svn-id: http://core.svn.wordpress.org/trunk@35869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 00:09:27 +00:00
Pascal Birchler
47306630ca Docs: Improve documentation for format_for_editor() and the 'the_editor_content' filter it is hooked to.
Props AramZS for initial patch.
Fixes #34866.
Built from https://develop.svn.wordpress.org/trunk@35904


git-svn-id: http://core.svn.wordpress.org/trunk@35868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 19:22:26 +00:00
Sergey Biryukov
d5d5d64e3d I18N: Use better context for post statuses.
See #35054.
Built from https://develop.svn.wordpress.org/trunk@35903


git-svn-id: http://core.svn.wordpress.org/trunk@35867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 19:18:26 +00:00
Sergey Biryukov
fe131bacd1 I18N: Use better context for comment statuses.
See #35054.
Built from https://develop.svn.wordpress.org/trunk@35902


git-svn-id: http://core.svn.wordpress.org/trunk@35866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 19:11:26 +00:00
Sergey Biryukov
5b29dbbf09 I18N: Add missing context for 'Trash' strings.
Fixes #35054.
Built from https://develop.svn.wordpress.org/trunk@35901


git-svn-id: http://core.svn.wordpress.org/trunk@35865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 19:03:26 +00:00
Sergey Biryukov
34ce39c782 List tables: After [34006], remove unnecessary context from 'View' string, for consistency with other strings in the same context.
Props MikeHansenMe, subharanjan.
Fixes #34914.
Built from https://develop.svn.wordpress.org/trunk@35900


git-svn-id: http://core.svn.wordpress.org/trunk@35864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 18:37:26 +00:00
Sergey Biryukov
346cce3c48 Customizer: Change "Display Header Text" checkbox label to "Display Site Title and Tagline", to make it clearer that it affects both settings.
Props juanfra, vlad.olaru.
Fixes #31829.
Built from https://develop.svn.wordpress.org/trunk@35899


git-svn-id: http://core.svn.wordpress.org/trunk@35863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 17:50:28 +00:00
Sergey Biryukov
bff39f181e Credits: After [26354], replace another instance of the "Contributing to WordPress" Codex link with http://make.wordpress.org/.
Remove redundant translator comments, add comments for placeholders instead.

See #25806.
Built from https://develop.svn.wordpress.org/trunk@35898


git-svn-id: http://core.svn.wordpress.org/trunk@35862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 15:24:27 +00:00
Pascal Birchler
2981d66990 Login: After [34213], use the login_post scheme again for login forms.
See #34925.
Built from https://develop.svn.wordpress.org/trunk@35897


git-svn-id: http://core.svn.wordpress.org/trunk@35861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 14:03:26 +00:00
Pascal Birchler
b804b26269 Admin: After [35128], make the 'Configure' link work again for dashboard widgets.
See #34987.
Built from https://develop.svn.wordpress.org/trunk@35896


git-svn-id: http://core.svn.wordpress.org/trunk@35860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 13:57:26 +00:00
Sergey Biryukov
8ad27a1405 Docs: Improve documentation for wp_count_terms().
Props bordoni, swissspidy.
Fixes #34861.
Built from https://develop.svn.wordpress.org/trunk@35895


git-svn-id: http://core.svn.wordpress.org/trunk@35859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 12:11:27 +00:00
Andrea Fercia
188d41b53c Dashboard: remove not clickable spaces between icons and links in the "At a Glance" panel. Also, some CSS cleanup.
Props 5um17 for the initial patch.
Fixes #27813.
Built from https://develop.svn.wordpress.org/trunk@35894


git-svn-id: http://core.svn.wordpress.org/trunk@35858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 12:01:30 +00:00
Jeremy Felt
b24fd73bd0 MS: Update "Add New Site" address description text for accuracy.
Add hyphens to the list of allowed characters and add the `description` class to helper text paragraph tag.

Props thomaswm for the initial patch.
Fixes #26388.

Built from https://develop.svn.wordpress.org/trunk@35893


git-svn-id: http://core.svn.wordpress.org/trunk@35857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 03:13:27 +00:00
Mel Choyce
09b5c2b3d0 Customizer: Bold pixel value under Site Icon to match the Custom Header instructions.
Props karmatosed.
Fixes #35039.

Built from https://develop.svn.wordpress.org/trunk@35892


git-svn-id: http://core.svn.wordpress.org/trunk@35856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-13 00:14:27 +00:00
Joe Hoyle
6e27cd7944 Remove accidental .svn addition to .gitignore
Introduced in 35890, oops!

Built from https://develop.svn.wordpress.org/trunk@35891


git-svn-id: http://core.svn.wordpress.org/trunk@35855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 18:27:26 +00:00
Joe Hoyle
ee94a28953 REST API: Improve formatting of failed validation errors.
If a validation_callback returns a WP_Error it should give the same response format as if it returned `false`. This makes programmatically reading the validation errors better.

Props bradyvercher for initial patch.
Fixes #35028.

Built from https://develop.svn.wordpress.org/trunk@35890


git-svn-id: http://core.svn.wordpress.org/trunk@35854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 18:23:28 +00:00
Drew Jaynes
c06143270e Docs: Document the optional $args parameter in wp_delete_term() in the hash notation style.
Props slushman, swissspidy.
Fixes #34862.

Built from https://develop.svn.wordpress.org/trunk@35889


git-svn-id: http://core.svn.wordpress.org/trunk@35853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 16:27:27 +00:00
Sergey Biryukov
3f61b6bafa Docs: Improve documentation for request_filesystem_credentials() and the corresponding filter.
Props swissspidy, danhgilmore, slushman.
Fixes #34858.
Built from https://develop.svn.wordpress.org/trunk@35888


git-svn-id: http://core.svn.wordpress.org/trunk@35852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 16:16:26 +00:00
Sergey Biryukov
56a31f392b Docs: Remove @todo entry from get_archives_link(), as all optional arguments are now documented.
See #34856.
Built from https://develop.svn.wordpress.org/trunk@35887


git-svn-id: http://core.svn.wordpress.org/trunk@35851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 15:55:27 +00:00
Sergey Biryukov
3da5165287 Docs: Document optional parameters in get_archives_link().
Props kiranpotphode.
Fixes #34856.
Built from https://develop.svn.wordpress.org/trunk@35886


git-svn-id: http://core.svn.wordpress.org/trunk@35850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 15:52:27 +00:00
Pascal Birchler
54b8c3e53b Docs: Fix some minor DocBlock alignment issues.
See #32246.
Built from https://develop.svn.wordpress.org/trunk@35885


git-svn-id: http://core.svn.wordpress.org/trunk@35849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 15:37:28 +00:00
Sergey Biryukov
e20fb91e54 I18N: In WP_Locale::init(), replace space as a thousands separator with a non-breaking space.
* If PHP version is 5.4.0 or greater, a regular space as a thousands separator is replaced with a non-breaking space, decoded using the `blog_charset` option.
* If PHP version is 5.2.x or 5.3.x, `&nbsp;` or `&#160;` as a thousands separator is replaced with a regular space, as multiple bytes are not supported there.

Fixes #10373.
Built from https://develop.svn.wordpress.org/trunk@35884


git-svn-id: http://core.svn.wordpress.org/trunk@35848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 02:06:35 +00:00
Sergey Biryukov
386e788efb Editor: Move 'Password protected' and 'Private' options description directly after 'Visibility' setting description.
Props christophherr.
Fixes #34919.
Built from https://develop.svn.wordpress.org/trunk@35883


git-svn-id: http://core.svn.wordpress.org/trunk@35847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 01:56:29 +00:00
Sergey Biryukov
f0cdd8d0b4 Docs: Correct wp_debug_mode() description to clarify that WP_DEBUG_DISPLAY is true by default.
Props jrf.
Fixes #34960.
Built from https://develop.svn.wordpress.org/trunk@35882


git-svn-id: http://core.svn.wordpress.org/trunk@35846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 01:49:26 +00:00
Sergey Biryukov
d53a13ee87 Fix typo in wp-admin/setup-config.php.
Props obrienlabs.
Fixes #34916.
Built from https://develop.svn.wordpress.org/trunk@35881


git-svn-id: http://core.svn.wordpress.org/trunk@35845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 01:45:27 +00:00
Sergey Biryukov
89e0d7dc9e I18N: In wp_maybe_decline_date(), bail early if translation functions are not available, e.g. in SHORTINIT mode.
Fixes #34967 for trunk.
Built from https://develop.svn.wordpress.org/trunk@35880


git-svn-id: http://core.svn.wordpress.org/trunk@35844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 01:42:38 +00:00
Sergey Biryukov
224d20e99b Revert [35878].
See #34967.
Built from https://develop.svn.wordpress.org/trunk@35879


git-svn-id: http://core.svn.wordpress.org/trunk@35843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 01:41:34 +00:00
Sergey Biryukov
746c697099 I18N: In wp_maybe_decline_date(), bail early if translation functions are not available, e.g. in SHORTINIT mode.
Fixes #34967 for trunk.
Built from https://develop.svn.wordpress.org/trunk@35878


git-svn-id: http://core.svn.wordpress.org/trunk@35842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 01:35:35 +00:00
Drew Jaynes
1ae97a2078 Docs: Update the summary for the comment_form_fields hook docs to explicitly mention inclusion of the textarea element as a filterable element.
Previously [35723]

Props bappidgreat.
Fixes #34973.

Built from https://develop.svn.wordpress.org/trunk@35877


git-svn-id: http://core.svn.wordpress.org/trunk@35841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 01:07:27 +00:00
John Blackbourn
36679a6e89 Avoid a PHP notice when trying to access the post_parent property of hierarchical post type nav menu items.
FIxes #34446

Built from https://develop.svn.wordpress.org/trunk@35876


git-svn-id: http://core.svn.wordpress.org/trunk@35840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-12 01:06:29 +00:00
Andrea Fercia
24afea92c2 When editing terms, properly display an admin notice-warning when tag_ID is empty.
Also, avoids two related PHP notices when empty or not set (and thus the global `$tag` is a WP_Error object).

Fixes: #34515.
Built from https://develop.svn.wordpress.org/trunk@35875


git-svn-id: http://core.svn.wordpress.org/trunk@35839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 22:49:41 +00:00
Pascal Birchler
1294c2bc3a Admin Menu: Deprecate add_object_page() and add_utility_page().
These functions are not used in core and are just wrappers for `add_menu_page()`.

Fixes #23108.
Built from https://develop.svn.wordpress.org/trunk@35874


git-svn-id: http://core.svn.wordpress.org/trunk@35838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 22:12:26 +00:00
Pascal Birchler
ba9475786a Dashboard: Do not show "Search Engines Discouraged" text when the blog_public option is not set.
Search engines are only discouraged from indexing the site when the option is explicitly set to `0`.

Fixes #34860.
Built from https://develop.svn.wordpress.org/trunk@35873


git-svn-id: http://core.svn.wordpress.org/trunk@35837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 22:03:26 +00:00
John Blackbourn
4a934d72bb Ensure that all the capabilities that any users have are being tested. This ensures that if new capabilities are introduced in the future, tests will be required for them.
See #35024

Built from https://develop.svn.wordpress.org/trunk@35872


git-svn-id: http://core.svn.wordpress.org/trunk@35836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 22:00:27 +00:00
John Blackbourn
8854836a0a Introduce tests for the unfiltered_upload capability, which no user should have (unless the ALLOW_UNFILTERED_UPLOADS constant is defined).
See #35024

Built from https://develop.svn.wordpress.org/trunk@35871


git-svn-id: http://core.svn.wordpress.org/trunk@35835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 21:55:26 +00:00
Pascal Birchler
5fa8ea8c6b Passwords: Hide weak password confirmation checkbox when password strength improves.
Props subharanjan for initial patch.
Fixes #34950.
Built from https://develop.svn.wordpress.org/trunk@35870


git-svn-id: http://core.svn.wordpress.org/trunk@35834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 21:54:27 +00:00
John Blackbourn
a2c79a2fc6 Correct the hash notation documentation introduced in [34891].
See #32147

Built from https://develop.svn.wordpress.org/trunk@35869


git-svn-id: http://core.svn.wordpress.org/trunk@35833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 20:16:27 +00:00
Drew Jaynes
2cad8ec9e3 Docs: Remove indentation from a wrapped line in the DocBlock description for get_post_type_labels() to prevent incorrect formatting when parsed.
With the false indentation in place, the parser for the Code Reference incorrectly interprets it as a block quote.

Fixes #35019.

Built from https://develop.svn.wordpress.org/trunk@35868


git-svn-id: http://core.svn.wordpress.org/trunk@35832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 18:42:27 +00:00
Sergey Biryukov
6d90a7b0cb Post Template: Pass the post ID to the_guid and get_the_guid filters.
Props danielbachhuber for initial patch.
Fixes #35015.
Built from https://develop.svn.wordpress.org/trunk@35867


git-svn-id: http://core.svn.wordpress.org/trunk@35831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 16:39:26 +00:00
Andrea Fercia
70330165c4 Accessibility: on the Updates screen, remove a redundant title attribute.
Removes the title attribute from the Plugin details link and adds the Plugin name hidden with `screen-reader-text` within the link text.

Props Cheffheid.
Fixes #35001.
Built from https://develop.svn.wordpress.org/trunk@35866


git-svn-id: http://core.svn.wordpress.org/trunk@35830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 16:32:26 +00:00
Drew Jaynes
b3d28ad0b9 Administration: Improve the message displayed in the login form modal when a user's session has expired.
Props obrienlabs.
Fixes #34340.

Built from https://develop.svn.wordpress.org/trunk@35865


git-svn-id: http://core.svn.wordpress.org/trunk@35829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 16:01:28 +00:00
Drew Jaynes
0fcf24a38e Docs: Document the optional $options parameter for wp_register_widget_control() as a hash notation.
Props stephanethomas.
Fixes #34855.

Built from https://develop.svn.wordpress.org/trunk@35864


git-svn-id: http://core.svn.wordpress.org/trunk@35828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 15:24:28 +00:00
John Blackbourn
62b3d21229 Add assertions for role names as capabilities in the capabilities tests. This ensures the role name is only available as a capability to the corresponding role.
See #35007

Built from https://develop.svn.wordpress.org/trunk@35863


git-svn-id: http://core.svn.wordpress.org/trunk@35827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 11:07:29 +00:00
Gary Pendergast
f76712f652 About: Add a fallback -webkit-calc() to about.css
We forgot to run `grunt precommit` before [35834] was committed.

This change doesn't need to be backported to the 4.4 branch, as it only affects Chrome < 26, it's really just to clean up the behaviour of `grunt precommit`.

See #34663.



Built from https://develop.svn.wordpress.org/trunk@35862


git-svn-id: http://core.svn.wordpress.org/trunk@35826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 03:53:26 +00:00
Eric Lewis
6be07725fb Add inline documentation for get_page_by_path().
Fixes #34964.

Built from https://develop.svn.wordpress.org/trunk@35861


git-svn-id: http://core.svn.wordpress.org/trunk@35825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 03:50:26 +00:00
Eric Lewis
b07bb412ee Don't suppress error messages in database function calls.
Fixes #21870.

Built from https://develop.svn.wordpress.org/trunk@35860


git-svn-id: http://core.svn.wordpress.org/trunk@35824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 03:40:26 +00:00
Gary Pendergast
49e2977b7e Build Tools: Update grunt-contrib-imagemin to v1.0.0
This updates `imagemin` to 4.0.0, which fixes an error when running `grunt imagemin:core`.

Props netweb.

Fixes #35003.


Built from https://develop.svn.wordpress.org/trunk@35859


git-svn-id: http://core.svn.wordpress.org/trunk@35823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 03:39:23 +00:00
Boone Gorges
f4f2116edd Be sure to force-delete when cleaning up fixtures in get_comment_link() tests.
Introduced in [35857].

Mega-super-anti-props boonebgorges.
Built from https://develop.svn.wordpress.org/trunk@35858


git-svn-id: http://core.svn.wordpress.org/trunk@35822 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 02:47:25 +00:00
Boone Gorges
cef6eee086 Share fixtures in get_comment_link() tests.
See #30017.
Built from https://develop.svn.wordpress.org/trunk@35857


git-svn-id: http://core.svn.wordpress.org/trunk@35821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 02:27:27 +00:00
Dominik Schilling
6fb81e3338 L10n: Use an absolute path for the is_dir() check when looking for installed translations.
Avoids warnings when `open_basedir` restrictions are in effect.

Props Profforg.
Fixes #34526.
Built from https://develop.svn.wordpress.org/trunk@35856


git-svn-id: http://core.svn.wordpress.org/trunk@35820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-10 23:09:27 +00:00
Andrea Fercia
81b70b5af7 Updates screen: make the new strings introduced in [35854] translatable.
Props walbo.
Fixes #34763.
Built from https://develop.svn.wordpress.org/trunk@35855


git-svn-id: http://core.svn.wordpress.org/trunk@35819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-10 19:24:26 +00:00
Andrea Fercia
984e1321ba Accessibility: the iframes used for the update progress in the Updates screen need title attributes to describe their content.
Fixes #34763.
Built from https://develop.svn.wordpress.org/trunk@35854


git-svn-id: http://core.svn.wordpress.org/trunk@35818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-10 17:21:29 +00:00
Rachel Baker
9dd574bd99 Comments: Comments don’t need no Post ID when created, so they don’t be needing one to be edited.
In `wp_update_comment()` only check if the given `comment_post_ID` is valid if it isn’t `0`.  This allows comments that were created programmatically via `wp_insert_comment()` without the (optional) `comment_post_ID` parameter to be edited.

Props subharanjan for the initial patch.
Fixes #34954


Built from https://develop.svn.wordpress.org/trunk@35853


git-svn-id: http://core.svn.wordpress.org/trunk@35817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-10 15:17:29 +00:00
Boone Gorges
812060f940 Improve handling for WP_Error objects in get_the_terms().
`wp_get_object_terms()` can return a `WP_Error` object. As such, the
`get_the_terms()` cache wrapper should handle them properly. To wit:

* Don't try to map an error object to `get_term()`. Introduced in [35032].
* Don't cache an error object as taxonomy relationships. Introduced in at least [16487], maybe earlier.

Props stephenharris.
Fixes #34723.
Built from https://develop.svn.wordpress.org/trunk@35850


git-svn-id: http://core.svn.wordpress.org/trunk@35814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-10 03:35:27 +00:00
John Blackbourn
6fd3c9fc64 Comments: Commit tests missed in [35848].
See #28617

Built from https://develop.svn.wordpress.org/trunk@35849


git-svn-id: http://core.svn.wordpress.org/trunk@35813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-10 03:16:25 +00:00
John Blackbourn
a027edc277 Comments: The year is 2003. Permalinks are a new thing and everyone's using Blogger. It's a time when opening a modal window in JavaScript to view a section of a website is not a completely weird thing, although many users get annoyed by it. b2 has recently become WordPress, and with it comes a bunch of functionality that will become stale over the next decade, remnants of simpler times.
Twelve years later, after no fewer than three themes have intentionally implemented popup comments in their functionality, before being abandoned for at least the last six years, we've reached a time where we can put this era behind us. A time when we can remove comment popup functionality from WordPress.

If this breaks the internet, I'll eat my hat.

Fixes #28617

Built from https://develop.svn.wordpress.org/trunk@35848


git-svn-id: http://core.svn.wordpress.org/trunk@35812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-10 03:06:30 +00:00
John Blackbourn
8826804952 Formatting: Don't make links inside <script> and <style> tags clickable.
Fixes #30162
Props ninos-ego, adamsilverstein

Built from https://develop.svn.wordpress.org/trunk@35847


git-svn-id: http://core.svn.wordpress.org/trunk@35811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-09 23:55:32 +00:00
Andrea Fercia
2ae5db3856 Accessibility: remove no-purpose title attributes from the login screen.
Also, it's hard to convey the ironic tone of the sentences used for these title attributes in languages other than English.

Fixes #34943.
Built from https://develop.svn.wordpress.org/trunk@35846


git-svn-id: http://core.svn.wordpress.org/trunk@35810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-09 22:20:29 +00:00
Rachel Baker
17061829e4 Docs: Better param descriptions and fix incorrect param name within REST API deprecated functions
`rest_handle_deprecated_function`: you get better parameter descriptions.
`rest_handle_deprecated_argument`: you get a corrected parameter name ($replacement->$message), appropriate i18n translation hints, and better parameter descriptions.

Props ocean90.
Fixes #34908


Built from https://develop.svn.wordpress.org/trunk@35845


git-svn-id: http://core.svn.wordpress.org/trunk@35809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-09 21:26:29 +00:00
Drew Jaynes
a4cd391d50 Docs: Move the hook doc for the view_mode_post_types filter to directly precede the apply_filters() line.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35844


git-svn-id: http://core.svn.wordpress.org/trunk@35808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-09 16:17:27 +00:00
Dominik Schilling
7551362d57 About Page: Add release video and update post embed.
Props camikaos, siobhan, rosso99, wonderboymusic.
See #34663.
Built from https://develop.svn.wordpress.org/trunk@35839


git-svn-id: http://core.svn.wordpress.org/trunk@35803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-08 23:23:26 +00:00
Dominik Schilling
ba4a508daf Install/Upgrade: Keep indexing bots away until a site is ready to be seen.
Built from https://develop.svn.wordpress.org/trunk@35837


git-svn-id: http://core.svn.wordpress.org/trunk@35801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-08 21:56:27 +00:00
Scott Taylor
f642373090 About Page: use ReverbNation instead of Cloudup to avoid Ad Blocker cruff with tracking pixels. Adjust the layout accordingly, and improve the layout at smaller breakpoints.
Props melchoyce.
See #34663.

Built from https://develop.svn.wordpress.org/trunk@35834


git-svn-id: http://core.svn.wordpress.org/trunk@35798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-08 20:25:28 +00:00
Dominik Schilling
dc7ff95661 About Page: Remove three superfluous parentheses.
Props jaspermdegroot.
See #34663.
Built from https://develop.svn.wordpress.org/trunk@35833


git-svn-id: http://core.svn.wordpress.org/trunk@35797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-08 18:15:26 +00:00
Dominik Schilling
d5475667b0 About Page: Use w.org CDN for images.
See #34663.
Built from https://develop.svn.wordpress.org/trunk@35832


git-svn-id: http://core.svn.wordpress.org/trunk@35796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-08 17:57:26 +00:00
Michael Arestad
d23bd49fdd Administration: Adds a height to number inputs.
Number inputs didn't match the height of other form elements. Now they have a height of 28px and 40px on mobile. Both align with the sizes of other elements.

Props valendesigns. 
Fixes #28984.

Built from https://develop.svn.wordpress.org/trunk@35831


git-svn-id: http://core.svn.wordpress.org/trunk@35795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-08 16:07:25 +00:00