Commit Graph

5140 Commits

Author SHA1 Message Date
Dominik Schilling
06b4f99e18 Dashboard: Use _draft_or_post_title() to display (no title) if no post title is set. see #25824.
Built from https://develop.svn.wordpress.org/trunk@26337


git-svn-id: http://core.svn.wordpress.org/trunk@26238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-23 14:13:09 +00:00
Dion Hulse
f392843074 Theme Installer: Fix the Theme Preview function, and bring the button handling/styling inline with the Customizer. Fixes #26129
Built from https://develop.svn.wordpress.org/trunk@26317


git-svn-id: http://core.svn.wordpress.org/trunk@26221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-22 04:03:10 +00:00
Dion Hulse
61ed60c619 Themes: Move the escaping of content from JS back to PHP. This allows us to take advantage of the display() WP_Theme method to translate the text properly, and to strip out any HTML tags we don't wish to display. Fixes #26100. See #25948
Built from https://develop.svn.wordpress.org/trunk@26316


git-svn-id: http://core.svn.wordpress.org/trunk@26220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-22 02:34:10 +00:00
Dion Hulse
b7872fd70a Use static strings instead of a impossible-to-translate string in the Automatic updates debug email. Props SergeyBiryukov. Fixes #25667
Built from https://develop.svn.wordpress.org/trunk@26313


git-svn-id: http://core.svn.wordpress.org/trunk@26217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-22 02:00:10 +00:00
Dion Hulse
893262f742 Themes: Add a get_theme_update_available() function to retrieve an update link and use it on the Themes page. See #26078
Built from https://develop.svn.wordpress.org/trunk@26282


git-svn-id: http://core.svn.wordpress.org/trunk@26187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-20 02:57:10 +00:00
Dion Hulse
0755f5a2dc Translate the debug update email for development installs. Props Nao for initial patch. See #25667
Built from https://develop.svn.wordpress.org/trunk@26279


git-svn-id: http://core.svn.wordpress.org/trunk@26184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-20 02:04:10 +00:00
Dion Hulse
5862ddbd8f Appearance: Fix a PHP Notice when the update transient isn't available (for example, due to a timeout or being used offline). See #25948
Built from https://develop.svn.wordpress.org/trunk@26278


git-svn-id: http://core.svn.wordpress.org/trunk@26183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-20 01:40:09 +00:00
Andrew Nacin
ad52b4ddd4 Remove whitespace from the inside of a <textarea> element, added in [26138] with inline documentation.
see #25662.

Built from https://develop.svn.wordpress.org/trunk@26273


git-svn-id: http://core.svn.wordpress.org/trunk@26178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-19 19:35:10 +00:00
Dion Hulse
f29b2e02ac Plugin Deletion: Properly clear the cache when multiple plugins are deleted. Props jdgrimes. Fixes #26065
Built from https://develop.svn.wordpress.org/trunk@26262


git-svn-id: http://core.svn.wordpress.org/trunk@26168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-19 04:08:09 +00:00
Scott Taylor
da05f7435b For unit tests that call wpmu_create_blog(), Blog factory, or installation code that attempts to clear transients: suppress database errors on setUp and restore on tearDown.
There are a few places in core that were preventing this from working by explicity setting `$wpdb->suppress_errors` to `false`. Instead, they should inherit the value that existed before errors were suppressed.

This allows Multisite unit tests to run without explosive database errors, and allows `$wpdb->suppress_errors` to be overridden all the way down the chain.

Fixes #26102.

Built from https://develop.svn.wordpress.org/trunk@26252


git-svn-id: http://core.svn.wordpress.org/trunk@26158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-18 20:45:11 +00:00
Sergey Biryukov
0df020b516 Remove unused global reference. props jeremyfelt. fixes #26103.
Built from https://develop.svn.wordpress.org/trunk@26251


git-svn-id: http://core.svn.wordpress.org/trunk@26157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-18 20:19:09 +00:00
Matt Thomas
7fe71ffe81 Style and positioning fixes to form elements in the Publish box:
- Make select element text #555 to match others
- Make Cancel links vertically align with buttons
- Make sure the spacing between buttons and cancel links is always consistent
- Override active button styles for responsive states so button size doesn't change when active
- Reduce font size of date select element to match date text inputs

Fixes #26082, props aubreypwd.


Built from https://develop.svn.wordpress.org/trunk@26247


git-svn-id: http://core.svn.wordpress.org/trunk@26153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-18 18:53:10 +00:00
Sergey Biryukov
83adea3986 Remove debug cruft. props nbachiyski. see #25791.
Built from https://develop.svn.wordpress.org/trunk@26245


git-svn-id: http://core.svn.wordpress.org/trunk@26152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-18 13:18:09 +00:00
Andrew Nacin
89005c8b31 Add level-X classes to the posts list table rows.
props jhned.
fixes #25791.

Built from https://develop.svn.wordpress.org/trunk@26244


git-svn-id: http://core.svn.wordpress.org/trunk@26151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-17 20:40:09 +00:00
Sergey Biryukov
35ec8405f0 Fix date comparison in dashboard_relative_date(). fixes #26033.
Built from https://develop.svn.wordpress.org/trunk@26242


git-svn-id: http://core.svn.wordpress.org/trunk@26149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-17 03:30:09 +00:00
Sergey Biryukov
ecd594b5a6 PHPDoc and i18n fixes for dashboard widgets.
props dimadin for initial patch.
see #25824.
Built from https://develop.svn.wordpress.org/trunk@26241


git-svn-id: http://core.svn.wordpress.org/trunk@26148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-17 03:21:10 +00:00
Andrew Nacin
963b2aa574 Merge wp_dashboard_recent_quickdrafts() into wp_dashboard_quick_press(). see #25824.
Built from https://develop.svn.wordpress.org/trunk@26221


git-svn-id: http://core.svn.wordpress.org/trunk@26129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 20:40:15 +00:00
Andrew Nacin
2cc8ed1594 Dash cleanup.
* Use wp_add_dashboard_widget() rather than add_meta_box().
 * Use original functions like wp_dashboard_primary(), wp_dashboard_right_now(), wp_dashboard_quick_press() (where possible).
 * Only include plugins section of the news widget when appropriate, which necessitates the set_current_screen() via the ajax action.
 * Remove some debug cruft that was preventing caching and invalidation.
 * Simplify lots of things where possible.
see #25824.

Built from https://develop.svn.wordpress.org/trunk@26220


git-svn-id: http://core.svn.wordpress.org/trunk@26128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 20:15:10 +00:00
Andrew Nacin
1832d880a5 Sort themes by name on the new themes.php page. see #25948.
Built from https://develop.svn.wordpress.org/trunk@26216


git-svn-id: http://core.svn.wordpress.org/trunk@26124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 16:42:10 +00:00
Andrew Nacin
52ecbebba3 Remove debug cruft. props dimadin. see #25948.
Built from https://develop.svn.wordpress.org/trunk@26215


git-svn-id: http://core.svn.wordpress.org/trunk@26123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 16:40:09 +00:00
Dion Hulse
8d65f7dc7c Updates: When a failed Background Update occurs, only show the failed update nag if the user hasn't yet updated if it was an early abort. Props SergeyBiryukov. Fixes #25887 for trunk
Built from https://develop.svn.wordpress.org/trunk@26186


git-svn-id: http://core.svn.wordpress.org/trunk@26095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 02:31:11 +00:00
Andrew Ozz
188fce6c9b Heartbeat: clean up code style, better naming, better code structure. Props carldanley, props evansolomon.
Changes:
- Add connectNow() public method to trigger a connection immediately.
- Remove the "skipping" when no data to send.
- Change the default interval to 60 sec.
- Fix resetting the next connection time when changing the interval.
See #25073.
Built from https://develop.svn.wordpress.org/trunk@26169


git-svn-id: http://core.svn.wordpress.org/trunk@26078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-14 18:41:10 +00:00
Dion Hulse
9109f107c4 Bacground Updates: Move the 'automatic_updates_complete' hook to only fire when some updates have actually been completed. Props nacin. Fixes #25841
Built from https://develop.svn.wordpress.org/trunk@26164


git-svn-id: http://core.svn.wordpress.org/trunk@26075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-14 06:29:09 +00:00
Dion Hulse
4fbc450f52 Background Updates: Add a 'automatic_updates_complete' hook that fires after any updates have run. Props pento. Fixes #25841
Built from https://develop.svn.wordpress.org/trunk@26155


git-svn-id: http://core.svn.wordpress.org/trunk@26066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-14 05:08:09 +00:00
Dion Hulse
a71cd00cdb Background Updates: Spread them over the hour. Props Pento. Fixes #25833 for trunk
Built from https://develop.svn.wordpress.org/trunk@26149


git-svn-id: http://core.svn.wordpress.org/trunk@26060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-14 04:04:10 +00:00
Dion Hulse
02841470a1 Background Updates: Fix a PHP Fatal error which could be encountered on some systems when using FTP. Fixes #25817 for trunk.
Built from https://develop.svn.wordpress.org/trunk@26148


git-svn-id: http://core.svn.wordpress.org/trunk@26059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-14 02:02:09 +00:00
Andrew Nacin
809b335f7a Merge the new dashboard design into core.
Merges https://github.com/growthdesigner/wp-dash.

props lessbloat, joen, helen, dbernar1, kraftbj, ryelle, tillkruess, grapplerulrich, markjaquith.
see #25824.

Built from https://develop.svn.wordpress.org/trunk@26144


git-svn-id: http://core.svn.wordpress.org/trunk@26055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 22:09:10 +00:00
Andrew Nacin
dce9327f2a Update the Themes screen, merging THX into core.
* Name: THX38
 * Description: Update the Themes screen with a new design and experience.
 * Tags: visually-focused, bigger-screenshots, fast, mobile-friendly, backbone-driven
 * Author: matveb, shaunandrews, melchoyce, designsimply, shelob9
 * URI: http://wordpress.org/plugins/thx38/

fixes #25948


Built from https://develop.svn.wordpress.org/trunk@26141


git-svn-id: http://core.svn.wordpress.org/trunk@26052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 20:58:05 +00:00
Matt Thomas
87ce6cc5c3 Bring in the widgets component of MP6. See #25858.
* A cleaner UI, with a simpler design for available and inactive widgets, and more emphasis on your sidebars.
* Available widgets and sidebars expand to two columns at larger screen sizes making it easier to manage sites with lots of sidebars.
* New dropzone indicator for empty sidebars.

Props shaunandrews, joen, iammattthomas.


Built from https://develop.svn.wordpress.org/trunk@26140


git-svn-id: http://core.svn.wordpress.org/trunk@26051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 20:06:06 +00:00
Sergey Biryukov
9119d189dd Inline documentation for hooks in wp-admin/includes/class-wp-comments-list-table.php.
props siobhyb, kpdesign.
fixes #25662.
Built from https://develop.svn.wordpress.org/trunk@26138


git-svn-id: http://core.svn.wordpress.org/trunk@26049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 19:47:10 +00:00
Helen Hou-Sandí
603c1aff6d Merge the color schemes component from MP6. Introduces Light, Blue, and Midnight.
Color scheme selection on your own profile page gives you a preview and autosaves the selection.

Also introduces the usage of a preprocessor for core files, namely Sass. For 3.8, we will not expand its implementation past the color schemes. This does require Ruby as well as Sass 3.3.0+ due to the usage of the sourcemap option.

Note that only the default color scheme is available when running out of src. Use build to test the rest as well as the color picker.

props ryelle, melchoyce, tillkruess, drw158, littlethingsstudio, helen. see #25858, #22862.

Built from https://develop.svn.wordpress.org/trunk@26137


git-svn-id: http://core.svn.wordpress.org/trunk@26048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 19:38:38 +00:00
Sergey Biryukov
74f77b85a6 Use get_current_site() instead of the $current_site global when possible.
props jeremyfelt.
fixes #25158.
Built from https://develop.svn.wordpress.org/trunk@26120


git-svn-id: http://core.svn.wordpress.org/trunk@26032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 03:23:10 +00:00
Sergey Biryukov
eae4e5936f Use case-insensitive comparison for email addresses. fixes #25779.
Built from https://develop.svn.wordpress.org/trunk@26115


git-svn-id: http://core.svn.wordpress.org/trunk@26027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 02:41:09 +00:00
Andrew Ozz
541d22e18d Fix the X-UA-Compatible header for IE8, fixes #25575
Built from https://develop.svn.wordpress.org/trunk@26089


git-svn-id: http://core.svn.wordpress.org/trunk@26007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-11 18:02:10 +00:00
Sergey Biryukov
8d659b278c Fix docblock formatting. fixes #25893.
Built from https://develop.svn.wordpress.org/trunk@26081


git-svn-id: http://core.svn.wordpress.org/trunk@26001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-11 13:32:10 +00:00
Sergey Biryukov
e15b51efa3 Pass correct 'type' parameter to 'upgrader_process_complete' action in Theme_Upgrader.
props bamadesigner.
fixes #25882 for trunk.
Built from https://develop.svn.wordpress.org/trunk@26049


git-svn-id: http://core.svn.wordpress.org/trunk@25974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-08 17:04:09 +00:00
Andrew Ozz
0743625aed Add X-UA-Compatible meta tag in the admin, locking the compatibility mode in IE to the highest supported document mode. Fixes #25575.
Built from https://develop.svn.wordpress.org/trunk@26029


git-svn-id: http://core.svn.wordpress.org/trunk@25959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-06 23:49:09 +00:00
Sergey Biryukov
23de998e29 Fix inverted logic for displaying the 'Broken Theme' string. props pavelevap. fixes #25465.
Built from https://develop.svn.wordpress.org/trunk@26027


git-svn-id: http://core.svn.wordpress.org/trunk@25957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-06 22:40:08 +00:00
Sergey Biryukov
72d4b140fb Make Twenty Fourteen the default theme. props markmcwilliams. fixes #25702.
Built from https://develop.svn.wordpress.org/trunk@26024


git-svn-id: http://core.svn.wordpress.org/trunk@25955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-06 20:02:09 +00:00
Dion Hulse
c9683257db Core Upgrader: Include an unmodified $wp_version in Core_Upgrader::upgrade(). This protects against cases where the global $wp_version has been modified. See #25772
Built from https://develop.svn.wordpress.org/trunk@26017


git-svn-id: http://core.svn.wordpress.org/trunk@25948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-05 06:23:10 +00:00
Dion Hulse
9d011a0556 Core Upgrader success statistics: Pass the version of WordPress we're upgrading from, as well as the version being upgraded to. Props nacin. See #25772 for trunk
Built from https://develop.svn.wordpress.org/trunk@26016


git-svn-id: http://core.svn.wordpress.org/trunk@25947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-05 06:20:09 +00:00
Dion Hulse
38a69e4ccc Remove dead code from the Plugin Upgrader class. Props jdgrimes. Fixes #25470
Built from https://develop.svn.wordpress.org/trunk@26015


git-svn-id: http://core.svn.wordpress.org/trunk@25946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-05 05:48:10 +00:00
Dion Hulse
b511346319 When checking filesystem permissions for core updates, only check the permissions of the files which we need to alter. Props nacin for initial patch. Fixes #25771 for trunk
Built from https://develop.svn.wordpress.org/trunk@26014


git-svn-id: http://core.svn.wordpress.org/trunk@25945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-05 05:43:09 +00:00
Dion Hulse
21a3164b3b Add a filter to the Background Updates debug email, matches the filter used on the non-debug post-update emails. Props pento. Fixes #25756
Built from https://develop.svn.wordpress.org/trunk@26013


git-svn-id: http://core.svn.wordpress.org/trunk@25944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-05 02:15:10 +00:00
Scott Taylor
ba3f75b3c3 Pass $args to the export_wp action in export_wp(), which is currently passed no arguments.
Props nickdaugherty.
Fixes #25574.


Built from https://develop.svn.wordpress.org/trunk@26011


git-svn-id: http://core.svn.wordpress.org/trunk@25942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-05 01:27:08 +00:00
Sergey Biryukov
cd45adaa0b Pass comment ID and comment post ID to get_comment_class() in WP_Comments_List_Table::single_row().
props drozdz.
fixes #25814.
Built from https://develop.svn.wordpress.org/trunk@26001


git-svn-id: http://core.svn.wordpress.org/trunk@25934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-04 11:00:11 +00:00
Andrew Nacin
d0cfa40983 Add jshintrc to qunit.
props jorbin.
see #25187.

Built from https://develop.svn.wordpress.org/trunk@25992


git-svn-id: http://core.svn.wordpress.org/trunk@25925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-30 14:39:10 +00:00
Andrew Nacin
a8ef13972c When an HTTPS request to api.wordpress.org fails, try an insecure HTTP request and issue a warning.
Certain versions of cURL appear to claim OpenSSL support but fail to work. We need to not trap users on older versions while we work this out, and instead fall back to an insecure request.

see #25716 for trunk.

Built from https://develop.svn.wordpress.org/trunk@25956


git-svn-id: http://core.svn.wordpress.org/trunk@25915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-27 21:09:10 +00:00
Drew Jaynes
4cf7175d6f Inline documentation for hooks in wp-admin/includes/schema.php.
Props johnafish, kpdesign.
Fixes #25498.

Built from https://develop.svn.wordpress.org/trunk@25938


git-svn-id: http://core.svn.wordpress.org/trunk@25897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-26 20:29:10 +00:00
Drew Jaynes
94a3ee8d68 Inline documentation for hooks in wp-admin/includes/nav-menu.php.
Props Faison.
Fixes #25474.

Built from https://develop.svn.wordpress.org/trunk@25935


git-svn-id: http://core.svn.wordpress.org/trunk@25894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-26 17:48:11 +00:00
Andrew Nacin
1a2f89d5d0 Avoid a notice for an undefined $checksums variable when updating from pre-3.7 to post-3.7.
props GaryJ.
fixes #25689 for trunk.

Built from https://develop.svn.wordpress.org/trunk@25915


git-svn-id: http://core.svn.wordpress.org/trunk@25878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-25 20:15:10 +00:00
Andrew Nacin
70fd806759 Revert r25824:25875 from the core.svn.wordpress.org repository.
These commits were accidentally re-synced commits from develop.svn.wordpress.org due to a race condition. Thankfully, the history of this repository matters fairly little. It also happened only for trunk.


git-svn-id: http://core.svn.wordpress.org/trunk@25876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-25 02:29:52 +00:00
Andrew Nacin
ac2e70227f Make some changes to the email templates to account for the fact that an auto update offer might not be to the latest version.
For example, 3.7.2 install is served a 3.7.3 update, but the current version is 3.8.1.

This commit also allows for core update notification emails to be sent even when we are unable to run an auto update due to filesystem configuration (VCS checkout or file permissions). But, since these emails go through WP_Automatic_Updater, they will not be sent if the updater is outright disabled.

fixes #25654.

Built from https://develop.svn.wordpress.org/trunk@25873


git-svn-id: http://core.svn.wordpress.org/trunk@25873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 23:00:01 +00:00
Andrew Nacin
d680f71d91 Show the nag we show for a stuck .maintenance file when an auto update failed.
see #25654.

Built from https://develop.svn.wordpress.org/trunk@25872


git-svn-id: http://core.svn.wordpress.org/trunk@25872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:59:53 +00:00
Andrew Nacin
ff711dba63 "some files" instead of "certain files". Less stuffy.
props markjaquith.
see #25652.

Built from https://develop.svn.wordpress.org/trunk@25871


git-svn-id: http://core.svn.wordpress.org/trunk@25871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:59:45 +00:00
Andrew Nacin
bed7a78426 New, better error message when we realize we won't be able to copy a file and continue with the update.
fixes #25652.

Built from https://develop.svn.wordpress.org/trunk@25870


git-svn-id: http://core.svn.wordpress.org/trunk@25870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:59:37 +00:00
Andrew Nacin
d61e188f23 Only enforce disk free space checks when doing background updates.
see #25652.

Built from https://develop.svn.wordpress.org/trunk@25869


git-svn-id: http://core.svn.wordpress.org/trunk@25869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:59:29 +00:00
Andrew Nacin
5361a8abca Spell out duplicate hook locations.
props DrewAPicture.
fixes #25658.

Built from https://develop.svn.wordpress.org/trunk@25868


git-svn-id: http://core.svn.wordpress.org/trunk@25868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:59:20 +00:00
Andrew Nacin
4b559801ae Updates: Disable maintenance mode once we've finished copying files, to minimize disruption.
props dd32.
fixes #25655.

Built from https://develop.svn.wordpress.org/trunk@25866


git-svn-id: http://core.svn.wordpress.org/trunk@25866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:59:05 +00:00
Andrew Nacin
3b7e540f00 Updates: Saner stats and rollback handling. WP.org now collects basic stats on non-auto updates as they have been hugely informative.
props dd32 for initial patch.
fixes #25657.

Built from https://develop.svn.wordpress.org/trunk@25863


git-svn-id: http://core.svn.wordpress.org/trunk@25863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:58:40 +00:00
Andrew Nacin
de7977d66c Move upgrader_process_complete for core to its proper place in Core_Upgrader.
This means it will be firing as a JS redirect is taking place if the update is from pre-3.4. Acceptable.

props dd32.
fixes #25659.

Built from https://develop.svn.wordpress.org/trunk@25861


git-svn-id: http://core.svn.wordpress.org/trunk@25861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:58:23 +00:00
Andrew Nacin
b134f540e2 Rename the automatic_updates_send_email filter to auto_core_update_send_email. (Final name change.)
fixes #25653. Also:
 * Fully document all new hooks, methods, and classes in the upgrader.
 * Rename 'language' to 'translation' inside the upgrader.
 * Improve the readability of the crazy do-while loop in the is_vcs_checkout() method.

Built from https://develop.svn.wordpress.org/trunk@25859


git-svn-id: http://core.svn.wordpress.org/trunk@25859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:57:58 +00:00
Andrew Nacin
04bbb52c7c Commit [25823] should not have renamed AUTOMATIC_UPDATER_DISABLED to AUTOMATIC_UPDATES_DISABLED.
The proper constant is AUTOMATIC_UPDATER_DISABLED. Keep the filter in line with that too.

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25851


git-svn-id: http://core.svn.wordpress.org/trunk@25851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:56:54 +00:00
Andrew Nacin
aea50d4b4c Use correct variable. fixes #10787.
Built from https://develop.svn.wordpress.org/trunk@25843


git-svn-id: http://core.svn.wordpress.org/trunk@25843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:55:46 +00:00
Andrew Nacin
83b20ee7f9 Notify administrators of successful, failed, and pending core updates.
Blocks future background updates after critical failures, but allow retries in certain situations. More in the ticket.

fixes #10787.

Built from https://develop.svn.wordpress.org/trunk@25841


git-svn-id: http://core.svn.wordpress.org/trunk@25841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:55:30 +00:00
Andrew Nacin
27d04f9e5e Delete expired transients on database upgrades.
Reverts [25416], which had all transients being cleared. This leaves much to be desired, but we don't want a core update to be blamed for breaking a site that incorrectly assumes transients aren't transient.

props dartiss, pento.
fixes #20316.

Built from https://develop.svn.wordpress.org/trunk@25838


git-svn-id: http://core.svn.wordpress.org/trunk@25838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:55:02 +00:00
Andrew Nacin
fa4f4033f7 Introduce email templates for automatic background updates.
The four templates are:
 1. We successfully updated their site. If any of their themes or plugins are out of date, it also mentions that. ('success')
 2. We are not configured to update their site, so we notify them of the new release. ('notify')
 3. We tried but failed to update their site. The error was early in the process, so no harm, no foul. This is the same as template #2, plus one sentence. ('fail')
 4. We tried to update their site, and failed while copying files. ('critical')

With assistance from markjaquith.

see #10787.

Built from https://develop.svn.wordpress.org/trunk@25837


git-svn-id: http://core.svn.wordpress.org/trunk@25837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:54:54 +00:00
Andrew Nacin
93eefa2af3 set_current_screen() is now unnecessary in Automatic_Upgrader_Skin, which is good because it breaks things in the network admin.
fixes #25622.

Built from https://develop.svn.wordpress.org/trunk@25836


git-svn-id: http://core.svn.wordpress.org/trunk@25836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:54:46 +00:00
Andrew Nacin
a3561e7e07 In automatic background updates, standardize on 'update'.
New, final filter names:
 * auto_update_{$type} (plugin, theme, core, language)
 * automatic_updates_is_vcs_checkout
 * automatic_updates_disabled

New class name is WP_Automatic_Updater. Method names include update() and should_update().

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25835


git-svn-id: http://core.svn.wordpress.org/trunk@25835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:54:38 +00:00
Dion Hulse
8abd2f86d5 Silence PHP warnings from disk_free_space(). disk_free_space() will produce a warning in error conditions in addition to returning false, this includes a case where the bytes free is greater than PHP_INT_MAX (which is a error condition we don't need to check).
See #25576, #22704

Built from https://develop.svn.wordpress.org/trunk@25831


git-svn-id: http://core.svn.wordpress.org/trunk@25831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:54:05 +00:00
Dion Hulse
66f01957a0 For Background updates, ensure that only one update process runs at the same time by using the options table as a lock.
This prevents multiple cron spawns and/or long-running updates from causing multiple update processes to spin up.
This also fixes a case where the upgrader might kick in for ( ! is_main_network() || ! is_main_site() ) in mulisite installs.
See #22704

Built from https://develop.svn.wordpress.org/trunk@25828


git-svn-id: http://core.svn.wordpress.org/trunk@25828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:40 +00:00
Andrew Nacin
8ae8e01b67 Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone.
see #27704.

Built from https://develop.svn.wordpress.org/trunk@25825


git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:14 +00:00
Andrew Nacin
564b008f67 Add editimage.min.js to $_old_files. see #24999.
Built from https://develop.svn.wordpress.org/trunk@25897


git-svn-id: http://core.svn.wordpress.org/trunk@25809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 19:27:09 +00:00
Andrew Nacin
0ceb189b7b Confirm delete_site_option() exists before calling it during an update.
This function won't yet exist when updating from 2.7 [sic].

fixes #25682 for trunk.

Built from https://develop.svn.wordpress.org/trunk@25893


git-svn-id: http://core.svn.wordpress.org/trunk@25805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 18:18:12 +00:00
Andrew Nacin
0976999929 Remove debug code from WP_Automatic_Updater::send_email().
props markmcwilliams for initial patch.
see #25678.

Built from https://develop.svn.wordpress.org/trunk@25891


git-svn-id: http://core.svn.wordpress.org/trunk@25803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 01:51:09 +00:00
Andrew Nacin
7b772e5c58 Introduce a send_core_update_notification_email filter to control whether to send update notifications.
Currently, this is dependent on whether the automatic updater is enabled (generally). This is likely to be decoupled in a future release.

This refocuses the auto_core_update_send_email filter to specifically be for success/fail emails for auto updates, while the new filter is more general.

see #25603.

Built from https://develop.svn.wordpress.org/trunk@25882


git-svn-id: http://core.svn.wordpress.org/trunk@25794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-23 19:47:09 +00:00
Ryan Boren
b87d4b77e5 Pinking shears
Built from https://develop.svn.wordpress.org/trunk@25880


git-svn-id: http://core.svn.wordpress.org/trunk@25792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-23 14:38:10 +00:00
Andrew Nacin
a387c3bef9 Make some changes to the email templates to account for the fact that an auto update offer might not be to the latest version.
For example, 3.7.2 install is served a 3.7.3 update, but the current version is 3.8.1.

This commit also allows for core update notification emails to be sent even when we are unable to run an auto update due to filesystem configuration (VCS checkout or file permissions). But, since these emails go through WP_Automatic_Updater, they will not be sent if the updater is outright disabled.

fixes #25654.

Built from https://develop.svn.wordpress.org/trunk@25873


git-svn-id: http://core.svn.wordpress.org/trunk@25785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 21:19:09 +00:00
Andrew Nacin
58c18f0c32 Show the nag we show for a stuck .maintenance file when an auto update failed.
see #25654.

Built from https://develop.svn.wordpress.org/trunk@25872


git-svn-id: http://core.svn.wordpress.org/trunk@25784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 21:15:09 +00:00
Andrew Nacin
13dd29126a "some files" instead of "certain files". Less stuffy.
props markjaquith.
see #25652.

Built from https://develop.svn.wordpress.org/trunk@25871


git-svn-id: http://core.svn.wordpress.org/trunk@25783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 18:41:10 +00:00
Andrew Nacin
fabf119cf3 New, better error message when we realize we won't be able to copy a file and continue with the update.
fixes #25652.

Built from https://develop.svn.wordpress.org/trunk@25870


git-svn-id: http://core.svn.wordpress.org/trunk@25782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 18:21:10 +00:00
Andrew Nacin
d5fdd66f9d Only enforce disk free space checks when doing background updates.
see #25652.

Built from https://develop.svn.wordpress.org/trunk@25869


git-svn-id: http://core.svn.wordpress.org/trunk@25781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 18:18:09 +00:00
Andrew Nacin
74488bdcb0 Spell out duplicate hook locations.
props DrewAPicture.
fixes #25658.

Built from https://develop.svn.wordpress.org/trunk@25868


git-svn-id: http://core.svn.wordpress.org/trunk@25780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 17:22:11 +00:00
Andrew Nacin
a160441c81 Updates: Disable maintenance mode once we've finished copying files, to minimize disruption.
props dd32.
fixes #25655.

Built from https://develop.svn.wordpress.org/trunk@25866


git-svn-id: http://core.svn.wordpress.org/trunk@25778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 17:20:10 +00:00
Andrew Nacin
097c0fd0b6 Updates: Saner stats and rollback handling. WP.org now collects basic stats on non-auto updates as they have been hugely informative.
props dd32 for initial patch.
fixes #25657.

Built from https://develop.svn.wordpress.org/trunk@25863


git-svn-id: http://core.svn.wordpress.org/trunk@25775 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 09:49:09 +00:00
Andrew Nacin
64bd5aa564 Move upgrader_process_complete for core to its proper place in Core_Upgrader.
This means it will be firing as a JS redirect is taking place if the update is from pre-3.4. Acceptable.

props dd32.
fixes #25659.

Built from https://develop.svn.wordpress.org/trunk@25861


git-svn-id: http://core.svn.wordpress.org/trunk@25773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 04:37:09 +00:00
Andrew Nacin
5a0b227316 Rename the automatic_updates_send_email filter to auto_core_update_send_email. (Final name change.)
fixes #25653. Also:
 * Fully document all new hooks, methods, and classes in the upgrader.
 * Rename 'language' to 'translation' inside the upgrader.
 * Improve the readability of the crazy do-while loop in the is_vcs_checkout() method.

Built from https://develop.svn.wordpress.org/trunk@25859


git-svn-id: http://core.svn.wordpress.org/trunk@25771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-21 22:29:09 +00:00
Andrew Nacin
ee489a2e81 Commit [25823] should not have renamed AUTOMATIC_UPDATER_DISABLED to AUTOMATIC_UPDATES_DISABLED.
The proper constant is AUTOMATIC_UPDATER_DISABLED. Keep the filter in line with that too.

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25851


git-svn-id: http://core.svn.wordpress.org/trunk@25763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-18 21:24:10 +00:00
Andrew Nacin
c00bba9e8b Use correct variable. fixes #10787.
Built from https://develop.svn.wordpress.org/trunk@25843


git-svn-id: http://core.svn.wordpress.org/trunk@25755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-18 17:16:10 +00:00
Andrew Nacin
ee20af1fad Notify administrators of successful, failed, and pending core updates.
Blocks future background updates after critical failures, but allow retries in certain situations. More in the ticket.

fixes #10787.

Built from https://develop.svn.wordpress.org/trunk@25841


git-svn-id: http://core.svn.wordpress.org/trunk@25753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-18 16:30:11 +00:00
Andrew Nacin
859da01c4a Delete expired transients on database upgrades.
Reverts [25416], which had all transients being cleared. This leaves much to be desired, but we don't want a core update to be blamed for breaking a site that incorrectly assumes transients aren't transient.

props dartiss, pento.
fixes #20316.

Built from https://develop.svn.wordpress.org/trunk@25838


git-svn-id: http://core.svn.wordpress.org/trunk@25750 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-18 07:48:09 +00:00
Andrew Nacin
5f3e90a112 Introduce email templates for automatic background updates.
The four templates are:
 1. We successfully updated their site. If any of their themes or plugins are out of date, it also mentions that. ('success')
 2. We are not configured to update their site, so we notify them of the new release. ('notify')
 3. We tried but failed to update their site. The error was early in the process, so no harm, no foul. This is the same as template #2, plus one sentence. ('fail')
 4. We tried to update their site, and failed while copying files. ('critical')

With assistance from markjaquith.

see #10787.

Built from https://develop.svn.wordpress.org/trunk@25837


git-svn-id: http://core.svn.wordpress.org/trunk@25749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-18 06:33:10 +00:00
Andrew Nacin
325ccd0a14 set_current_screen() is now unnecessary in Automatic_Upgrader_Skin, which is good because it breaks things in the network admin.
fixes #25622.

Built from https://develop.svn.wordpress.org/trunk@25836


git-svn-id: http://core.svn.wordpress.org/trunk@25748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-17 23:24:09 +00:00
Andrew Nacin
a65661abee In automatic background updates, standardize on 'update'.
New, final filter names:
 * auto_update_{$type} (plugin, theme, core, language)
 * automatic_updates_is_vcs_checkout
 * automatic_updates_disabled

New class name is WP_Automatic_Updater. Method names include update() and should_update().

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25835


git-svn-id: http://core.svn.wordpress.org/trunk@25747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-17 23:21:10 +00:00
Dion Hulse
924e35d66a Silence PHP warnings from disk_free_space(). disk_free_space() will produce a warning in error conditions in addition to returning false, this includes a case where the bytes free is greater than PHP_INT_MAX (which is a error condition we don't need to check).
See #25576, #22704

Built from https://develop.svn.wordpress.org/trunk@25831


git-svn-id: http://core.svn.wordpress.org/trunk@25743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-17 18:40:10 +00:00
Dion Hulse
1c8d882e13 For Background updates, ensure that only one update process runs at the same time by using the options table as a lock.
This prevents multiple cron spawns and/or long-running updates from causing multiple update processes to spin up.
This also fixes a case where the upgrader might kick in for ( ! is_main_network() || ! is_main_site() ) in mulisite installs.
See #22704

Built from https://develop.svn.wordpress.org/trunk@25828


git-svn-id: http://core.svn.wordpress.org/trunk@25740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-17 05:24:09 +00:00
Andrew Nacin
9432acde4e Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone.
see #27704.

Built from https://develop.svn.wordpress.org/trunk@25825


git-svn-id: http://core.svn.wordpress.org/trunk@25737 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-17 04:02:09 +00:00
Andrew Nacin
191efaef61 Make WP_Automatic_Upgrader a proper object that gets instantiated. Renames nearly all of its methods.
Also renames wp_auto_updates_maybe_update() to wp_maybe_auto_update().

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25823


git-svn-id: http://core.svn.wordpress.org/trunk@25735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-17 00:55:09 +00:00
Dion Hulse
640f73ecd2 Remove a duplicate semicolon that snuck in. Props JustinSainton. See #18200
Built from https://develop.svn.wordpress.org/trunk@25822


git-svn-id: http://core.svn.wordpress.org/trunk@25734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-17 00:12:10 +00:00
Dion Hulse
376a0a55c7 Allow the WordPress.org Language update API to disallow automated background updates for a specific language pack. See #18200
Built from https://develop.svn.wordpress.org/trunk@25818


git-svn-id: http://core.svn.wordpress.org/trunk@25730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 22:27:09 +00:00
Dion Hulse
ed07bab4b4 When a plugin enables Background Plugin updates, don't deactivate the plugin during update as we require a browser to reactivate it afterwards. See #22704
Built from https://develop.svn.wordpress.org/trunk@25817


git-svn-id: http://core.svn.wordpress.org/trunk@25729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 19:48:10 +00:00
Andrew Nacin
bccefbbd83 Merge the should_auto_update() and can_auto_update() methods. see #22704.
Built from https://develop.svn.wordpress.org/trunk@25815


git-svn-id: http://core.svn.wordpress.org/trunk@25727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 19:35:09 +00:00
Dion Hulse
085f5c5fb9 Fix a issue where the translation name isn't showing up in the Background Update emails, caused by a PHP Warning/missing variable in [25806]. See #18200
Built from https://develop.svn.wordpress.org/trunk@25812


git-svn-id: http://core.svn.wordpress.org/trunk@25724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 17:07:08 +00:00
Dion Hulse
8c35982ae8 Avoid a few PHP Warnings when files don't exist and use a better method to locate the local filepath.
See #18201

Built from https://develop.svn.wordpress.org/trunk@25811


git-svn-id: http://core.svn.wordpress.org/trunk@25723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 15:20:10 +00:00
Andrew Nacin
ba0ebf3736 Include translations in the update bubbles (as +1 if there are any). see #18200.
Built from https://develop.svn.wordpress.org/trunk@25810


git-svn-id: http://core.svn.wordpress.org/trunk@25722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 14:34:10 +00:00
Dion Hulse
84cec7b526 Remove the no longer used Headerless_Upgrader_Skin class, it's been replaced by Language_Pack_Upgrader_Skin.
See #18200, [25806]

Built from https://develop.svn.wordpress.org/trunk@25807


git-svn-id: http://core.svn.wordpress.org/trunk@25719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 04:19:09 +00:00
Dion Hulse
1c8e79353a Language Packs: Many many fixes such as:
- Add a "Update Translations" stand-alone button to the updates page
- Shift Language feedback to before update process completion action links & limit the verbosity of output (name + success/errors)
- Simplify/combine the language update descriptive string to only include a plugin/theme name
- Properly handle cache clearing after language updates to prevent langs being repeditively updated
- Display a "All items up to date" string when there's nothing to do
- Reduce the 'Connection Information' from a <h2> to a <h3> to remove duplicate h2's and screen icons from update screens
- Fix the Direct filesystem method not being used for Language updates because WP_LANG_DIR doesn't exist (check it's parent for writable instead)
See #18200, #22704


Built from https://develop.svn.wordpress.org/trunk@25806


git-svn-id: http://core.svn.wordpress.org/trunk@25718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 04:15:09 +00:00
Andrew Nacin
9fe39c464a Avoid numerous potential PHP warnings when dealing with the pre-r25801 get_core_checksums() return value.
Warnings included current(), filestat(), and md5_file().

see #18201. see #22704.

Built from https://develop.svn.wordpress.org/trunk@25805


git-svn-id: http://core.svn.wordpress.org/trunk@25717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 04:02:09 +00:00
Andrew Nacin
4542fbb2ae Significantly simplify get_core_checksums(), as the caching and chunking was causing too much grief.
Make sure we only do our pre-flight is_writable check when the file exists.

see #18201. see #22704.

Built from https://develop.svn.wordpress.org/trunk@25801


git-svn-id: http://core.svn.wordpress.org/trunk@25713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 23:03:10 +00:00
Andrew Nacin
9507d22243 Use correct variable. see #22704.
Built from https://develop.svn.wordpress.org/trunk@25800


git-svn-id: http://core.svn.wordpress.org/trunk@25712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 22:07:09 +00:00
Andrew Nacin
95831a8a67 Remove accidental debug cruft in [25780]. see #22704.
Built from https://develop.svn.wordpress.org/trunk@25799


git-svn-id: http://core.svn.wordpress.org/trunk@25711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 21:24:09 +00:00
Andrew Nacin
2100fa65fd Avoid our pre-flight writable checks if get_core_checksums() doesn't exist yet.
Thus, it will not work for 3.6 => 3.7, only 3.7+.

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25798


git-svn-id: http://core.svn.wordpress.org/trunk@25710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 20:35:10 +00:00
Andrew Nacin
a6188bc84a Only add error data to the files_not_writable WP_Error if the install already has [25775] and [25796] applied.
see #22704.

Built from https://develop.svn.wordpress.org/trunk@25797


git-svn-id: http://core.svn.wordpress.org/trunk@25709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 20:01:09 +00:00
Andrew Nacin
82547b21b6 In show_message(), only print error data if it is a string.
see #25576, [25775].

Built from https://develop.svn.wordpress.org/trunk@25796


git-svn-id: http://core.svn.wordpress.org/trunk@25708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 19:51:10 +00:00
Andrew Nacin
26c03ea5fb Core Updates: Verify that all files we're about to copy are actually writable, when using the direct transport.
Once we begin to copy core files, all bets are off. This allows us to fail early when we'll otherwise need to stop midway through due to permissions issues, which is a particularly bad problem when only some files have permissions issues.

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25794


git-svn-id: http://core.svn.wordpress.org/trunk@25706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 19:18:10 +00:00
Andrew Nacin
eeaad19a26 Use FS_CHMOD_FILE rather than an explicit 0644 in copy_dir() and _copy_dir().
This occurs when we can't copy a file. We chmod it and try again.

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25793


git-svn-id: http://core.svn.wordpress.org/trunk@25705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 19:14:10 +00:00
Dion Hulse
592123951b Fix a misspelling of the filter we're checking for, s/fs_method/filesystem_method/.
My bad. See #22704, [25781].

Built from https://develop.svn.wordpress.org/trunk@25787


git-svn-id: http://core.svn.wordpress.org/trunk@25699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 14:55:09 +00:00
Andrew Nacin
e503d0e2ec Hide auto updates from update-core.php directly in get_core_updates(). see #22704.
Built from https://develop.svn.wordpress.org/trunk@25783


git-svn-id: http://core.svn.wordpress.org/trunk@25696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 05:07:10 +00:00
Andrew Nacin
957df34182 Automatic updates: An error code containing 'do_rollback' can be used to trigger a rollback.
This could enable the triggering of a rollback in update_core() in wp-admin/includes/update-core.php.

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25782


git-svn-id: http://core.svn.wordpress.org/trunk@25695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 02:59:10 +00:00
Andrew Nacin
cdede88a23 Automatic updates: Include error data in the follow-up API request.
props dd32.
see #22704.

Built from https://develop.svn.wordpress.org/trunk@25781


git-svn-id: http://core.svn.wordpress.org/trunk@25694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 23:33:10 +00:00
Andrew Nacin
9b56d4d11f Parse absolute paths out of error data. see #22704.
Built from https://develop.svn.wordpress.org/trunk@25780


git-svn-id: http://core.svn.wordpress.org/trunk@25693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 22:25:08 +00:00
Dion Hulse
4dcca90887 Remove PHP4 compat code from the ZipArchive unzip handler, and pass the failure reason into the WP_Error return.
See #22704

Built from https://develop.svn.wordpress.org/trunk@25779


git-svn-id: http://core.svn.wordpress.org/trunk@25692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 21:55:09 +00:00
Andrew Nacin
4fa3687e6a Account for the possible failure of disk_free_space() in update_core().
see #22704, #25576.

Built from https://develop.svn.wordpress.org/trunk@25778


git-svn-id: http://core.svn.wordpress.org/trunk@25691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 21:15:10 +00:00
Andrew Nacin
3e3c085db3 Auto updates: Only attempt a roll back when we've hit a critical error code.
Specifically, this means when we've failed in copying files.

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25777


git-svn-id: http://core.svn.wordpress.org/trunk@25690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 21:03:09 +00:00
Andrew Nacin
145dbde82f Account for possible failures by disk_free_space(), as well as the potential need to copy the unzipped files.
see #25576.

Built from https://develop.svn.wordpress.org/trunk@25776


git-svn-id: http://core.svn.wordpress.org/trunk@25689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 20:58:09 +00:00
Andrew Nacin
1516b990f1 In the upgrader, only print additional error data if it is a string.
As in [25576], we sometimes want to return additional data that is not necessarily meant for UI consumption.

see #25576.

Built from https://develop.svn.wordpress.org/trunk@25775


git-svn-id: http://core.svn.wordpress.org/trunk@25688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 20:20:10 +00:00
Andrew Nacin
d68a80217f In unzip_file(), confirm we have enough available disk space before extracting.
"enough" is calculated by adding up the uncompressed size of the files in the archive, then adding a 20% buffer.

props dd32.
fixes #25576.

Built from https://develop.svn.wordpress.org/trunk@25774


git-svn-id: http://core.svn.wordpress.org/trunk@25687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 20:15:09 +00:00
Andrew Nacin
2d898df04f More specific error codes in the core upgrader when copying language, plugin, and theme files. see #22704.
Built from https://develop.svn.wordpress.org/trunk@25772


git-svn-id: http://core.svn.wordpress.org/trunk@25685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 19:38:10 +00:00
Andrew Nacin
4c90c3cb31 Add explicit link to the installation being updated in debugging emails. see #22704.
Built from https://develop.svn.wordpress.org/trunk@25770


git-svn-id: http://core.svn.wordpress.org/trunk@25683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-12 20:18:10 +00:00
Andrew Nacin
de1d3c8261 Silence possible warnings from is_dir(). fixes #25572.
Built from https://develop.svn.wordpress.org/trunk@25764


git-svn-id: http://core.svn.wordpress.org/trunk@25677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-11 17:11:10 +00:00
Andrew Nacin
29f5f5b5fd Refine error codes throughout the upgrader so we can better detect at what stage updates fail.
see #22704.

Built from https://develop.svn.wordpress.org/trunk@25763


git-svn-id: http://core.svn.wordpress.org/trunk@25676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-11 16:06:11 +00:00
Andrew Nacin
2a8dcbae1f Auto updates: For follow-up API call when an update fails, send back the version attempted. see #22704.
Built from https://develop.svn.wordpress.org/trunk@25755


git-svn-id: http://core.svn.wordpress.org/trunk@25668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-10 14:46:11 +00:00
Dion Hulse
186a5379e8 After a upgrade fails, and we successfully rollback to a previous version, Don't send the version we rolled back to to the API, just that it was successful. See [25750]. See #22704
Built from https://develop.svn.wordpress.org/trunk@25752


git-svn-id: http://core.svn.wordpress.org/trunk@25665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-10 01:57:08 +00:00
Dion Hulse
0b9f198994 In the event that an Automatic Upgrade fails, send a failure status on the next API request to indicate that it failed, and if the rollback was successful.
See #22704

Built from https://develop.svn.wordpress.org/trunk@25750


git-svn-id: http://core.svn.wordpress.org/trunk@25663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-10 01:32:09 +00:00
Andrew Nacin
f0eb99952c Make sure when resizing an image according to ratio we do not end up with a zero-pixel width or height.
props plocha.
fixes #25038.

Built from https://develop.svn.wordpress.org/trunk@25744


git-svn-id: http://core.svn.wordpress.org/trunk@25657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-09 19:07:17 +00:00
Helen Hou-Sandí
75eb364ced Show a label for the "Home" page nav menu item checkbox. props SergeyBiryukov. props ericlewis for the initial patch. fixes #25410.
Built from https://develop.svn.wordpress.org/trunk@25741


git-svn-id: http://core.svn.wordpress.org/trunk@25654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-09 18:47:09 +00:00
Dion Hulse
543d84a379 Upgrader: Create Directories with a minimum of 0755 and files with a minimum of 0644 when upgrading, which matches pre-3.7 behaviour. Fixes #20069
Built from https://develop.svn.wordpress.org/trunk@25739


git-svn-id: http://core.svn.wordpress.org/trunk@25652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-09 16:47:09 +00:00
Scott Taylor
7a7b9c89ec Use parens to ensure that RegEx OR matches the front when determining that mime-type matches audio|video in attachment_submitbox_metadata().
Props kovshenin.
See #23926.


Built from https://develop.svn.wordpress.org/trunk@25727


git-svn-id: http://core.svn.wordpress.org/trunk@25640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-08 15:32:10 +00:00
Andrew Nacin
a00df382a3 Move the revisions upgrade handler to POST, to avoid esoteric metadata stomping.
props SergeyBiryukov.
see #25023.
for trunk.

Built from https://develop.svn.wordpress.org/trunk@25719


git-svn-id: http://core.svn.wordpress.org/trunk@25632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-07 18:35:09 +00:00
Drew Jaynes
ec96affcad Inline documentation for hooks in wp-admin/includes/bookmark.php.
Props johnafish, kpdesign.
Fixes #25494.

Built from https://develop.svn.wordpress.org/trunk@25706


git-svn-id: http://core.svn.wordpress.org/trunk@25620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-07 02:19:09 +00:00
Andrew Nacin
a8ea7828e9 Be as sure as possible that WordPress is not under version control when deciding if we should do automatic updates.
see #22704.

Built from https://develop.svn.wordpress.org/trunk@25700


git-svn-id: http://core.svn.wordpress.org/trunk@25615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-06 15:46:09 +00:00
Andrew Nacin
f29acee299 Don't modify post_author during a quick edit when the post type doesn't support authors.
props ocean90.
fixes #16645.

Built from https://develop.svn.wordpress.org/trunk@25698


git-svn-id: http://core.svn.wordpress.org/trunk@25613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-06 13:15:09 +00:00
Andrew Nacin
e8e5f48905 Run _fix_attachment_links() when post_status is future or private in addition to publish.
Fixes regression caused by [20308].

props jond3r.
fixes #25268.

Built from https://develop.svn.wordpress.org/trunk@25697


git-svn-id: http://core.svn.wordpress.org/trunk@25612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-06 12:56:09 +00:00
Andrew Nacin
d93d8b850d Reverse the order of roles in wp_dropdown_roles(). Reset to 'subscriber' when the default role is removed and when a save is invalid.
props garyc40, wonderboymusic.
fixes #14578.

Built from https://develop.svn.wordpress.org/trunk@25695


git-svn-id: http://core.svn.wordpress.org/trunk@25610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-06 10:56:09 +00:00
Andrew Nacin
e4dc691e75 Hide the "If you take over" string from the post locked dialog when the override_post_lock filter is used to prevent an override.
props azaozz.
fixes #24930.

Built from https://develop.svn.wordpress.org/trunk@25694


git-svn-id: http://core.svn.wordpress.org/trunk@25609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-06 10:46:09 +00:00
Andrew Nacin
8392f942a4 Send current SSL status to the plugin information API endpoint so we can render screenshots over SSL if appropriate. fixes #11009.
Built from https://develop.svn.wordpress.org/trunk@25691


git-svn-id: http://core.svn.wordpress.org/trunk@25607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-05 10:59:12 +00:00
Andrew Nacin
4c63d45139 Avoid counting auto-drafts in sticky.
props nofearinc.
fixes #25127.

Built from https://develop.svn.wordpress.org/trunk@25678


git-svn-id: http://core.svn.wordpress.org/trunk@25594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-03 01:16:10 +00:00
Andrew Nacin
49af5f34d7 Post lists table: When counting a user's posts, use get_post_stati() instead of hardcoded internal statuses.
props creativeinfusion.
fixes #24818.

Built from https://develop.svn.wordpress.org/trunk@25676


git-svn-id: http://core.svn.wordpress.org/trunk@25592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-03 01:00:09 +00:00
Andrew Nacin
be366723d2 Don't use a double negative.
props TobiasBg.
fixes #18201.

Built from https://develop.svn.wordpress.org/trunk@25674


git-svn-id: http://core.svn.wordpress.org/trunk@25590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-02 21:50:09 +00:00
Andrew Nacin
524b62c5f6 Links manager: Restrict field length based on DB schema.
props solarissmoke, vinod-dalvi.
fixes #17296, #12264.

Built from https://develop.svn.wordpress.org/trunk@25670


git-svn-id: http://core.svn.wordpress.org/trunk@25586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-02 21:11:10 +00:00
Dominik Schilling
e4c8d56b76 Replace use of global $user_ID in favor of get_current_user_id(). fixes #25372.
Built from https://develop.svn.wordpress.org/trunk@25669


git-svn-id: http://core.svn.wordpress.org/trunk@25585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-02 21:10:09 +00:00
Andrew Nacin
7de2054ece Show a proper error message on the dashboard when the current theme is broken.
Clean up Appearance -> Themes when we don't have enough information to show for a broken theme.

Clean up broken/ugly "alt" row styling when we are displaying broken themes.

props johnbillion for initial patch.
fixes #21670.

Built from https://develop.svn.wordpress.org/trunk@25666


git-svn-id: http://core.svn.wordpress.org/trunk@25582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-02 20:50:09 +00:00
Scott Taylor
6a5d2f8fb0 Rather than adding a taxonomy arg to get_category(), convert all uses of get_category() in core to get_term(). By doing so, we negate the need to call _make_cat_compat() in a few places that are only looking for a single property.
Fixes #8722.


Built from https://develop.svn.wordpress.org/trunk@25662


git-svn-id: http://core.svn.wordpress.org/trunk@25578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-02 19:59:10 +00:00
Andrew Nacin
01484339b9 More string cleanups.
Built from https://develop.svn.wordpress.org/trunk@25658


git-svn-id: http://core.svn.wordpress.org/trunk@25575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-02 18:51:10 +00:00
Andrew Nacin
bc842ab011 This error message should have a period.
Built from https://develop.svn.wordpress.org/trunk@25656


git-svn-id: http://core.svn.wordpress.org/trunk@25573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-02 17:45:09 +00:00
Andrew Nacin
32376e99be Rollback is not a verb.
Built from https://develop.svn.wordpress.org/trunk@25655


git-svn-id: http://core.svn.wordpress.org/trunk@25572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-02 17:44:09 +00:00
Dion Hulse
55822259df Automatic Updates: Remove some debug from [25649] See #22704
Built from https://develop.svn.wordpress.org/trunk@25651


git-svn-id: http://core.svn.wordpress.org/trunk@25568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-30 00:30:10 +00:00
Dion Hulse
30b921d10e Automatic Updates: Disable Automatic updates for Mercurial(HG) and Bazaar(bzr) version control systems in addition to Git and SVN. Props jamescollins. See #22704
Built from https://develop.svn.wordpress.org/trunk@25650


git-svn-id: http://core.svn.wordpress.org/trunk@25567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-30 00:25:10 +00:00
Dion Hulse
75475ed773 Automatic Updates: Add a rollback functionality upon installation failure, the rollback package will be available for partial-updates for automatic updates and be similar to our existing partial builds (but in reverse).
A further iteration of this is to also detect whitescreens (fatals) after a auto update, and trigger the rollback for that too.
See #22704

Built from https://develop.svn.wordpress.org/trunk@25649


git-svn-id: http://core.svn.wordpress.org/trunk@25566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-30 00:21:09 +00:00
Dion Hulse
7ed4059230 MD5 file verification: Prevent md5_file() warnings when files don't exist, additionally, don't verify wp-content files as they can be updated separately, as well as WP_CONTENT_DIR being set elsewhere. See #22704 See #18201
Built from https://develop.svn.wordpress.org/trunk@25648


git-svn-id: http://core.svn.wordpress.org/trunk@25565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-29 23:08:09 +00:00
Dion Hulse
6e9ba8be22 Automatic Updates: Skip doing the sanity checking MD5 before deciding if we should use a partial build or not, This change means we always use a partial build for automatic updates. See #22704
Built from https://develop.svn.wordpress.org/trunk@25647


git-svn-id: http://core.svn.wordpress.org/trunk@25564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-29 23:00:09 +00:00
Drew Jaynes
39d7e0df8a Improve inline documentation for Walker_Nav_Menu, Walker_Nav_Menu_Edit, Walker_Nav_Menu_Checklist.
Includes previously undocumented parameters.

See #23406.

Built from https://develop.svn.wordpress.org/trunk@25643


git-svn-id: http://core.svn.wordpress.org/trunk@25560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-28 21:02:09 +00:00
Drew Jaynes
858343ed71 Inline documentation for Walker_Category_Checklist.
See #23406.

Built from https://develop.svn.wordpress.org/trunk@25642


git-svn-id: http://core.svn.wordpress.org/trunk@25559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-28 18:08:10 +00:00
Andrew Nacin
e3798dc013 Fix strict notice. see #22704.
Built from https://develop.svn.wordpress.org/trunk@25635


git-svn-id: http://core.svn.wordpress.org/trunk@25552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-28 06:33:10 +00:00
Andrew Nacin
00d2c39c48 Changes to automatic background updates in preparation for Beta 1.
* Show a notice for beta testers on update-core.php explaining the status of their install. Three possibilities: auto updates are enabled, auto updates are disabled because the install doesn't support SSL HTTP requests, and auto updates are disabled because it is a VCS checkout.
 * Improve the output of the email, for maximum debugging potential. Failures are clearly labeled and the email leads testers to the support forums and Trac.
 * Try to create wp-content/languages in the upgrader if it doesn't exist. Our mkdir isn't recursive, so trying to create wp-content/languages/plugins could fail.
 * Abstract out version control checkout determination into a public method. The filter is now auto_upgrade_is_vcs_checkout, still subject to change.

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25633


git-svn-id: http://core.svn.wordpress.org/trunk@25550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-27 23:21:10 +00:00
Drew Jaynes
2befec291f Inline documentation for hooks in wp-admin/includes/class-wp-plugin-install-list-table.php.
Props naomicbush.
Fixes #25357.

Built from https://develop.svn.wordpress.org/trunk@25630


git-svn-id: http://core.svn.wordpress.org/trunk@25547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-26 02:48:09 +00:00
Helen Hou-Sandí
9d5c2eb55f Make sure the attachment file exists before calling filesize() on it. props DrewAPicture. fixes #25170.
Built from https://develop.svn.wordpress.org/trunk@25608


git-svn-id: http://core.svn.wordpress.org/trunk@25525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-24 20:23:10 +00:00
Andrew Nacin
00c545606e Introduce wp_get_user_contact_methods() as a public version of _wp_get_user_contactmethods.
props johnnyb.
fixes #24273.

Built from https://develop.svn.wordpress.org/trunk@25606


git-svn-id: http://core.svn.wordpress.org/trunk@25523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-24 18:14:09 +00:00
Dion Hulse
7669224311 Automatic Updates: Correct a typo of a constant, s/DISABLE_FILE_MODS/DISALLOW_FILE_MODS/. See #22704
Built from https://develop.svn.wordpress.org/trunk@25599


git-svn-id: http://core.svn.wordpress.org/trunk@25516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-24 07:16:09 +00:00
Dion Hulse
65caf043c0 Automatic Core Updates: Enable Core Automatic Updates for Security releases, Development nightly releases, and, Language packs. See #22704
For more information on Automatic Core Updates, See #22704 and http://wp.me/p2AvED-1Lo


Built from https://develop.svn.wordpress.org/trunk@25598


git-svn-id: http://core.svn.wordpress.org/trunk@25515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-24 03:36:09 +00:00
Helen Hou-Sandí
9796e54574 Saner CSS for row actions - now we can just target .row-actions instead of both .row-actions and .row-actions-visible. CSS for .row-actions-visible remains for now due to usage in plugins. Visibility is controlled by toggling a .visible class. fixes #25403.
Built from https://develop.svn.wordpress.org/trunk@25592


git-svn-id: http://core.svn.wordpress.org/trunk@25509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-24 01:54:09 +00:00
Andrew Nacin
9cf6436ff3 Ignore unauthorized meta keys in meta_form(). fixes #18786.
Built from https://develop.svn.wordpress.org/trunk@25591


git-svn-id: http://core.svn.wordpress.org/trunk@25508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-24 01:31:10 +00:00
Drew Jaynes
bdcc067c4c Inline documentation for hooks in wp-admin/includes/revision.php.
Fixes #25283.

Built from https://develop.svn.wordpress.org/trunk@25587


git-svn-id: http://core.svn.wordpress.org/trunk@25504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-23 22:45:10 +00:00
Dion Hulse
c4a20fd9fe Language Packs: Integrate Language Packs into the Auto-upgrader. See #18200 See #22704
Built from https://develop.svn.wordpress.org/trunk@25568


git-svn-id: http://core.svn.wordpress.org/trunk@25486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-23 09:38:09 +00:00
Andrew Nacin
187c26415f Add a language pack upgrader class.
At the conclusion of any upgrade, after the transients are refreshed from the API, pending translations are downloaded and installed to wp-content/languages.

props dd32.
see #18200.

Built from https://develop.svn.wordpress.org/trunk@25566


git-svn-id: http://core.svn.wordpress.org/trunk@25484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-23 02:08:10 +00:00
Dion Hulse
c43600ea4b First pass at documenting the WP_Filesystem methods. This also introduces stubs of the methods into the base class which are documented, which subclasses can override, some methods were cleaned up at the same time.
See #18476 See #23122. Props kurtpayne, bananastalktome, and, DrewAPicture 

Built from https://develop.svn.wordpress.org/trunk@25560


git-svn-id: http://core.svn.wordpress.org/trunk@25478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-22 04:44:10 +00:00
Drew Jaynes
e6e033aa08 Inline documentation for hooks in wp-admin/includes/ajax-actions.php.
Fixes #25374.

Built from https://develop.svn.wordpress.org/trunk@25558


git-svn-id: http://core.svn.wordpress.org/trunk@25477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-21 20:47:09 +00:00
Drew Jaynes
c5abe8acaa Make the WP_List_Table::months_dropdown() query results filterable.
Introduces the `months_dropdown_results` filter.

Fixes #17022.

Built from https://develop.svn.wordpress.org/trunk@25556


git-svn-id: http://core.svn.wordpress.org/trunk@25476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-21 18:35:09 +00:00
Dion Hulse
a54a345cff Add a missing . in the Hook documentation from r25542 See #22704
Built from https://develop.svn.wordpress.org/trunk@25543


git-svn-id: http://core.svn.wordpress.org/trunk@25463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-21 07:02:11 +00:00
Dion Hulse
2c3a35491b WordPress Core Automatic Updates: Add a filter as to whether or not to send the site administrator a summary of executed updates. Props JustinSainton. See #22704
Built from https://develop.svn.wordpress.org/trunk@25542


git-svn-id: http://core.svn.wordpress.org/trunk@25462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-21 07:00:10 +00:00
Dion Hulse
a82b463610 When using download_url(), if the resource supplies a Content-MD5 header, verify the downloaded file against it. Fixes #20074
Built from https://develop.svn.wordpress.org/trunk@25541


git-svn-id: http://core.svn.wordpress.org/trunk@25461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-21 06:54:09 +00:00
Dion Hulse
6737d0a202 Upgrader: Perform a MD5 file verification check on the files during upgrade. This ensures that both a Partial upgrade build can be used, and that all the files were copied into place correctly.
Props pento for initial patch. Fixes #18201

Built from https://develop.svn.wordpress.org/trunk@25540


git-svn-id: http://core.svn.wordpress.org/trunk@25460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-21 06:49:11 +00:00
Helen Hou-Sandí
c7e2071893 Make it possible to filter comment screen by post type; no UI. props johnbillion, c3mdigital. fixes #18596.
Built from https://develop.svn.wordpress.org/trunk@25526


git-svn-id: http://core.svn.wordpress.org/trunk@25446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-20 20:16:11 +00:00
Drew Jaynes
11080f459c Inline documentation for hooks in wp-admin/includes/plugin-install.php.
Props naomicbush.
See #25229.

Built from https://develop.svn.wordpress.org/trunk@25511


git-svn-id: http://core.svn.wordpress.org/trunk@25431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-20 02:22:10 +00:00
Helen Hou-Sandí
6c121d303d Add a class to the bulk actions wrapper div. props nofearinc. fixes #25197.
Built from https://develop.svn.wordpress.org/trunk@25509


git-svn-id: http://core.svn.wordpress.org/trunk@25429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-19 21:01:09 +00:00
Helen Hou-Sandí
52426794c1 Restore post formats to bulk editing. props azaozz, SergeyBiryukov, DrewAPicture. fixes #24096.
Built from https://develop.svn.wordpress.org/trunk@25505


git-svn-id: http://core.svn.wordpress.org/trunk@25426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-19 17:47:08 +00:00
Sergey Biryukov
8595facd73 Some more tweaks for the documentation in wp-admin/includes/ms.php. see #25229.
Built from https://develop.svn.wordpress.org/trunk@25497


git-svn-id: http://core.svn.wordpress.org/trunk@25418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-19 16:06:12 +00:00
Dion Hulse
aa0fb26397 WordPress Core Automatic Updates: Add a post-upgrade summary email to the WordPress install's admin email address. See #22704
Built from https://develop.svn.wordpress.org/trunk@25496


git-svn-id: http://core.svn.wordpress.org/trunk@25417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-19 08:46:09 +00:00
Dion Hulse
340e129deb Upgrader: Fix the order of arguements passed to wp_parse_args() in the Upgrader, introduced with [25272]. See #22704
Built from https://develop.svn.wordpress.org/trunk@25495


git-svn-id: http://core.svn.wordpress.org/trunk@25416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-19 08:40:10 +00:00
Sergey Biryukov
27a75e12ad Update inline documentation for hooks in wp-admin/includes/ms.php.
props jamescollins.
see #25229.
Built from https://develop.svn.wordpress.org/trunk@25486


git-svn-id: http://core.svn.wordpress.org/trunk@25407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-19 00:05:09 +00:00
Sergey Biryukov
e6cef58106 Clean up the documentation for hooks in wp-admin/includes/plugin.php.
props DrewAPicture.
see #25229.
Built from https://develop.svn.wordpress.org/trunk@25482


git-svn-id: http://core.svn.wordpress.org/trunk@25403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-18 19:36:09 +00:00
Sergey Biryukov
37e3b91285 Inline documentation for hooks in wp-admin/includes/ms.php.
props enej, DrewAPicture.
see #25229.
Built from https://develop.svn.wordpress.org/trunk@25481


git-svn-id: http://core.svn.wordpress.org/trunk@25402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-18 18:22:09 +00:00
Sergey Biryukov
31ddfcca58 Correct @since for hooks in wp-admin/includes/plugin.php. see #25229.
Built from https://develop.svn.wordpress.org/trunk@25477


git-svn-id: http://core.svn.wordpress.org/trunk@25398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-18 11:58:10 +00:00
Peter Westwood
8f621ffc78 Inline documentation for hooks in wp-admin/includes/plugin.php
See #25229 props dllh

Built from https://develop.svn.wordpress.org/trunk@25474


git-svn-id: http://core.svn.wordpress.org/trunk@25395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-18 07:38:12 +00:00
Sergey Biryukov
14db24911f Deprecate the_attachment_links(), unused since [6910]. props vinod dalvi. fixes #25340.
Built from https://develop.svn.wordpress.org/trunk@25472


git-svn-id: http://core.svn.wordpress.org/trunk@25393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-17 09:08:08 +00:00
Dion Hulse
f98f5d0a36 WordPress Upgrades: When defining the default filesystem permissions for files/directories, base the value on the existing ABSPATH & index.php file permissions - so as to respect the executable bit (if set) and not set global read if not required.
This sets a minimum permission set to 750 and 640 for directories and files, so any systems requring less permission than that will still need to define the constants themselves. Fixes #20069 

Built from https://develop.svn.wordpress.org/trunk@25469


git-svn-id: http://core.svn.wordpress.org/trunk@25390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-17 08:06:09 +00:00
Dion Hulse
59d5e858f7 WordPress Core Automatic Updates: Remove some debug. See #22704
Built from https://develop.svn.wordpress.org/trunk@25468


git-svn-id: http://core.svn.wordpress.org/trunk@25389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-17 04:08:09 +00:00
Dion Hulse
cc84220ab5 WordPress Core Automatic Updates: Switch from using a transient for locking the upgrade process, to using a site option. See #22704
Built from https://develop.svn.wordpress.org/trunk@25467


git-svn-id: http://core.svn.wordpress.org/trunk@25388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-17 02:28:09 +00:00
Andrew Nacin
d3b89d43fc Add nginx detection to the Permalink Settings screen.
Introduces got_url_rewrite() and a corresponding filter, which should now be used in lieu of the got_rewrite filter in got_mod_rewrite().

This does not write or even suggest nginx configuration; rather, it prevents nginx from being considered as either Apache or as an unrecognized server.

props johnbillion.
fixes #25098.

Built from https://develop.svn.wordpress.org/trunk@25456


git-svn-id: http://core.svn.wordpress.org/trunk@25377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-16 20:07:09 +00:00
Andrew Nacin
4587da663f Allow callback args to be passed from wp_add_dashboard_widget() to add_meta_box().
props jdgrimes.
fixes #25152.

Built from https://develop.svn.wordpress.org/trunk@25454


git-svn-id: http://core.svn.wordpress.org/trunk@25375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-16 18:07:10 +00:00
Andrew Nacin
188f763120 Use get_terms() in the ajax tag search.
props Chouby.
fixes #25231.

Built from https://develop.svn.wordpress.org/trunk@25452


git-svn-id: http://core.svn.wordpress.org/trunk@25373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-16 17:51:08 +00:00
Andrew Nacin
6931079cec Multisite blogs table: Convert the archived field from enum to tinyint to match the other status fields. fixes #12832.
Built from https://develop.svn.wordpress.org/trunk@25448


git-svn-id: http://core.svn.wordpress.org/trunk@25369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-15 23:12:11 +00:00
Dion Hulse
d39f430f64 WordPress Core Automatic Updates: Remove an accidental closure which isn't supported in PHP 5.2. See #22704
Built from https://develop.svn.wordpress.org/trunk@25447


git-svn-id: http://core.svn.wordpress.org/trunk@25368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-15 01:26:09 +00:00
Andrew Nacin
fef6081046 Move to JSON for three api.wordpress.org endpoints. see #25311.
Built from https://develop.svn.wordpress.org/trunk@25441


git-svn-id: http://core.svn.wordpress.org/trunk@25362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-14 19:31:08 +00:00
Scott Taylor
daa4b531e8 Fix several esoteric errors related to AJAX unit tests for comments:
* `wp_ajax_get_comments()` relies on the `$post_id` global - even though `$_POST['p']` is passed to every action in the test methods. If `$post_id` is still lingering in between tests and doesn't match `p` in the request, the cap check might pass while the queries for comments will blow up. I added `unset( $GLOBALS['post_id'] )` to `Tests_Ajax_GetComments::setUp()`.
* If the global `$post_id` is empty, but `$_REQUEST['p']` is not, `$post_id` is now set to `absint( $_REQUEST['p'] )` and sanity-checked in `wp_ajax_get_comments()`.
* `map_meta_cap()` always assumes that `get_comment()` succeeds when checking for the `edit_comment` cap. It doesn't. I added sanity checks in a few places where it will break early if `get_post()` or `get_comment()` are empty.
* `wp_update_comment()` always assumes `get_comment()` succeeds. It doesn't. I added a check for empty.

All AJAX unit tests run and pass in debug mode. All general unit tests pass against these changes.

Fixes #25282.


Built from https://develop.svn.wordpress.org/trunk@25438


git-svn-id: http://core.svn.wordpress.org/trunk@25360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-14 18:36:09 +00:00
Sergey Biryukov
a55d3abd5f Inline documentation for hooks in wp-admin/includes/comment.php.
props mordauk.
see #25229.
Built from https://develop.svn.wordpress.org/trunk@25434


git-svn-id: http://core.svn.wordpress.org/trunk@25356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-14 01:01:08 +00:00
Scott Taylor
5df8338e0a Fix some undefined index notices related to Comment unit tests:
* There are several places where a `$_POST` index was unchecked before setting a variable
* In `wp_notify_postauthor()`, `$comment` was being returned null, but its properties were being accessed.
* In `check_ajax_referer()`, 3 different values can be checked for nonce on `$_REQUEST`, but only 1 had an `isset()`

See #25282.


Built from https://develop.svn.wordpress.org/trunk@25433


git-svn-id: http://core.svn.wordpress.org/trunk@25355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-13 22:18:08 +00:00
Scott Taylor
e8c656a045 * Avoid notices in tests/ajax/Autosave by bailing early when get_post() returns nothing.
* Check for the existence of `$_POST['catslist']` before using it in `wp_ajax_autosave()`.

See #25282.


Built from https://develop.svn.wordpress.org/trunk@25430


git-svn-id: http://core.svn.wordpress.org/trunk@25354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-13 21:22:11 +00:00
Dion Hulse
dd8e15f612 Upgrader: Allow plugins to short-circuit the package download. Props rmccue and DrewAPicture. Fixes #22378
Built from https://develop.svn.wordpress.org/trunk@25427


git-svn-id: http://core.svn.wordpress.org/trunk@25351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-13 12:53:08 +00:00
Sergey Biryukov
680a7a596d Avoid a PHP warning in network admin if a constant corresponding to a drop-in is not defined. fixes #25301.
Built from https://develop.svn.wordpress.org/trunk@25425


git-svn-id: http://core.svn.wordpress.org/trunk@25350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-13 09:37:10 +00:00
Dion Hulse
89682d2013 WordPress Core Automatic Updates: Pass the Filesystem path as $context to request_filesystem_credentials(). See #22704
Built from https://develop.svn.wordpress.org/trunk@25422


git-svn-id: http://core.svn.wordpress.org/trunk@25347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-13 06:53:09 +00:00
Dion Hulse
4678d33216 WordPress Core Automatic Updates: Add the first slice of Automatic Upgrades, This is presently disabled, and requires a filter to enable ( 'auto_upgrade_core' ). See #22704
Built from https://develop.svn.wordpress.org/trunk@25421


git-svn-id: http://core.svn.wordpress.org/trunk@25346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-13 06:19:12 +00:00
Sergey Biryukov
533519086e Better alignment for wp_prepare_revisions_for_js() inline docs. see #25283.
Built from https://develop.svn.wordpress.org/trunk@25420


git-svn-id: http://core.svn.wordpress.org/trunk@25345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 23:15:10 +00:00
Sergey Biryukov
b01adf9615 Inline documentation fixes and additions for wp-admin/revision.php and wp-admin/includes/revision.php.
props adamsilverstein.
see #25283.
Built from https://develop.svn.wordpress.org/trunk@25419


git-svn-id: http://core.svn.wordpress.org/trunk@25344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 22:59:08 +00:00
Andrew Nacin
52feff7a75 Clear all transients (regardless of expiration) on all database upgrades. see #20316.
Built from https://develop.svn.wordpress.org/trunk@25416


git-svn-id: http://core.svn.wordpress.org/trunk@25341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 21:14:10 +00:00
Andrew Nacin
e6bf2a293f Add populate_network_meta filter to populate_network().
props jeremyfelt.
fixes #25020.

Built from https://develop.svn.wordpress.org/trunk@25414


git-svn-id: http://core.svn.wordpress.org/trunk@25340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 20:49:09 +00:00
Andrew Nacin
717ec20ac7 Fix comma placement in [25179].
props gradyetc.
see #15004, fixes #25298.

Built from https://develop.svn.wordpress.org/trunk@25413


git-svn-id: http://core.svn.wordpress.org/trunk@25339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 20:16:11 +00:00
Helen Hou-Sandí
0758df9758 Add file size to attachment publish meta box. props desrosj. fixes #25170.
Built from https://develop.svn.wordpress.org/trunk@25403


git-svn-id: http://core.svn.wordpress.org/trunk@25333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 15:10:09 +00:00
Sergey Biryukov
b533a2bd94 Consistently call skin methods in WP_Upgrader. fixes #25254.
Built from https://develop.svn.wordpress.org/trunk@25370


git-svn-id: http://core.svn.wordpress.org/trunk@25320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 02:43:10 +00:00
Sergey Biryukov
0232d1cfd8 Fix invalid markup when searching for installed themes. fixes #25288.
Built from https://develop.svn.wordpress.org/trunk@25369


git-svn-id: http://core.svn.wordpress.org/trunk@25319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-12 00:03:10 +00:00
Dion Hulse
26ebfca466 Make use of the mbstring.func_overload helper functions in WP_Filesystem so byte lengths are properly determined. See #25259 Fixes #25237
Built from https://develop.svn.wordpress.org/trunk@25349


git-svn-id: http://core.svn.wordpress.org/trunk@25311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-11 08:27:10 +00:00
Dion Hulse
83ebc727e8 Switch unzip_file() over to using the mbstring.func_override helper functions. See #25259
Built from https://develop.svn.wordpress.org/trunk@25347


git-svn-id: http://core.svn.wordpress.org/trunk@25309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-11 08:09:08 +00:00
Andrew Nacin
8fe0d246fb Ignore user ID post data.
Built from https://develop.svn.wordpress.org/trunk@25316


git-svn-id: http://core.svn.wordpress.org/trunk@25278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-10 17:58:09 +00:00
Scott Taylor
d39c01d30e Consistently wrap author and excerpt nodes with CDATA in feeds.
Fixes #18056.


Built from https://develop.svn.wordpress.org/trunk@25315


git-svn-id: http://core.svn.wordpress.org/trunk@25277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-10 16:55:09 +00:00
Dion Hulse
068df26686 Switch to using HTTPS connections for Plugin and Theme API requests when SSL is available. See #18577
Built from https://develop.svn.wordpress.org/trunk@25308


git-svn-id: http://core.svn.wordpress.org/trunk@25270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-09 07:54:11 +00:00
Dion Hulse
2caf5fe381 Upgrader: Deprecate a few mostly unused functions, wp_update_plugin(), wp_update_theme(), and, wp_update_core().
wp_update_core() was still used, as it was never updated to make use of the newer Skins. Fixes #21874

Built from https://develop.svn.wordpress.org/trunk@25307


git-svn-id: http://core.svn.wordpress.org/trunk@25269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-09 06:45:08 +00:00
Dion Hulse
023a4c7336 WP_Filesyste: SSH2 PHP Extension support: Fix a case where defining a custom FS_CHMOD_FILE / FS_CHMOD_DIR constant wouldn't take effect due to chmod() failing with a invalid path. Fixes #23589
Built from https://develop.svn.wordpress.org/trunk@25306


git-svn-id: http://core.svn.wordpress.org/trunk@25268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-09 03:05:09 +00:00
Dion Hulse
7a6fad844a WP_Filesystem: Let the code breathe, add some additional whitespace between method definitions and comments.
Built from https://develop.svn.wordpress.org/trunk@25305


git-svn-id: http://core.svn.wordpress.org/trunk@25267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-09 02:55:09 +00:00
Dion Hulse
6d1ffc62ea WP_Filesystem: Ensure that all files are read/written correctly by verifying the return values from fwrite() and using FTP_BINARY mode (ASCII converts line endings as per the spec). See #25237
Built from https://develop.svn.wordpress.org/trunk@25304


git-svn-id: http://core.svn.wordpress.org/trunk@25266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-09 02:43:08 +00:00
Helen Hou-Sandí
8798685de5 Alignment standards for [25296]. props DrewAPicture. see #25171.
Built from https://develop.svn.wordpress.org/trunk@25300


git-svn-id: http://core.svn.wordpress.org/trunk@25263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-07 22:07:09 +00:00
Sergey Biryukov
05d55a400b Avoid PHP notices when configuring the Incoming Links dashboard widget. fixes #25250.
Built from https://develop.svn.wordpress.org/trunk@25298


git-svn-id: http://core.svn.wordpress.org/trunk@25261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-07 18:17:10 +00:00
Helen Hou-Sandí
304426cece Add dynamic classes for attachment metadata submitbox sections. see #22333, #25171.
Built from https://develop.svn.wordpress.org/trunk@25297


git-svn-id: http://core.svn.wordpress.org/trunk@25260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-07 16:20:09 +00:00
Helen Hou-Sandí
89421ddeaa Add media_submitbox_misc_sections and audio_submitbox_misc_sections filters to allow removing or adding of attachment submitbox sections containing attachment metadata. props desroj, DrewAPicture. fixes #25171.
Built from https://develop.svn.wordpress.org/trunk@25296


git-svn-id: http://core.svn.wordpress.org/trunk@25259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-07 16:19:10 +00:00
Scott Taylor
a4841da471 Use get_the_title() when dealing with post_type-like items in the admin.
Props nacin, DrewAPicture.
Fixes #14975.


Built from https://develop.svn.wordpress.org/trunk@25285


git-svn-id: http://core.svn.wordpress.org/trunk@25249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 17:08:08 +00:00
Andrew Nacin
5e0040a6ca Add new ajax_query_attachments_args filter.
props alex-ye.
fixes #24285.

Built from https://develop.svn.wordpress.org/trunk@25279


git-svn-id: http://core.svn.wordpress.org/trunk@25243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 15:18:09 +00:00
Sergey Biryukov
897ddbd76c Use correct array key for filling the attachment title in image_attachment_fields_to_save(). props pross.
Use wp_basename() to avoid issues with UTF-8 characters.
fixes #25236.
Built from https://develop.svn.wordpress.org/trunk@25277


git-svn-id: http://core.svn.wordpress.org/trunk@25242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 14:10:09 +00:00
Dion Hulse
db6cf37f91 WP_Filesystem: FTP Sockets: Avoid using the file_exists() / is_exists() / exists() PemFTP functionality as it's buggy on ncFTPd servers, switching to listing the file instead which is what we use for the FTP Extension transport. Fixes #14049
Built from https://develop.svn.wordpress.org/trunk@25274


git-svn-id: http://core.svn.wordpress.org/trunk@25240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 08:29:09 +00:00
Dion Hulse
443aa35cfc Upgrader: Make clearing the Plugin and Theme update caches optional during install and upgrade proceedures. See #22704
Built from https://develop.svn.wordpress.org/trunk@25272


git-svn-id: http://core.svn.wordpress.org/trunk@25238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 01:33:09 +00:00
Scott Taylor
bb0761e475 Remove redundant checks in some update functions. Adds some readability/coding standards cleanup.
Props miqrogroove, azaozz.
Fixes #22828.

Built from https://develop.svn.wordpress.org/trunk@25256


git-svn-id: http://core.svn.wordpress.org/trunk@25224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-05 17:05:15 +00:00
Scott Taylor
31f26dc3ce Remove lingering instances of call time pass-by-reference, limited to instances of callable - use $this instead of &$this.
Props jdgrimes.
See #25160.


Built from https://develop.svn.wordpress.org/trunk@25254


git-svn-id: http://core.svn.wordpress.org/trunk@25222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-05 16:34:09 +00:00
Scott Taylor
ffe8f1b13a Remove unnecessary checks before setting $wp_settings_* arrays. Adds unit test for setting a nonexistent variable to a multi-dimensional array.
Props scribu.
Fixes #17884.


Built from https://develop.svn.wordpress.org/trunk@25240


git-svn-id: http://core.svn.wordpress.org/trunk@25210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-04 19:07:09 +00:00
Dion Hulse
4231f4668a Core Auto Updates: Add a initial skin to allow capturing the output from the upgrader without displaying it (such as we need during cron calls).
This has been copied almost verbatim from the automatic-updater plugin with a few style tweaks and additional upgrade-possible check. See #22704

Built from https://develop.svn.wordpress.org/trunk@25228


git-svn-id: http://core.svn.wordpress.org/trunk@25198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-04 07:17:09 +00:00
Dion Hulse
bc02809fe3 Upgrader: Split the UI "skins" out from the main Upgrader file into a seperate file to reduce the length of the files. See #22704
Built from https://develop.svn.wordpress.org/trunk@25227


git-svn-id: http://core.svn.wordpress.org/trunk@25197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-04 06:35:10 +00:00
Sergey Biryukov
89aed6d7e8 Avoid 'Only variables should be passed by reference' notice on plugin search. props daankortenbach. fixes #25217.
Built from https://develop.svn.wordpress.org/trunk@25210


git-svn-id: http://core.svn.wordpress.org/trunk@25182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-02 13:54:10 +00:00
Sergey Biryukov
eccd3e42df Deprecate wp_nav_menu_locations_meta_box(), unused since [23441]. props DrewAPicture. fixes #24942.
Built from https://develop.svn.wordpress.org/trunk@25209


git-svn-id: http://core.svn.wordpress.org/trunk@25181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-02 11:26:09 +00:00
Sergey Biryukov
0d0c87041c Move get_real_file_to_edit() upper in the file for consistency with the existing order of functions. Some phpdoc fixes and additions. see #23680.
Built from https://develop.svn.wordpress.org/trunk@25208


git-svn-id: http://core.svn.wordpress.org/trunk@25180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-02 11:19:10 +00:00
Sergey Biryukov
6760d294bb Update phpdoc for get_user_to_edit(), get_userdata(), and get_user_by(). props tivnet. fixes #24992.
Built from https://develop.svn.wordpress.org/trunk@25204


git-svn-id: http://core.svn.wordpress.org/trunk@25176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-02 03:25:09 +00:00
Sergey Biryukov
00c9232a19 Move get_real_file_to_edit() to wp-admin/includes/deprecated.php. props iamfriendly. fixes #23680.
Built from https://develop.svn.wordpress.org/trunk@25201


git-svn-id: http://core.svn.wordpress.org/trunk@25173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-01 12:37:12 +00:00
Dion Hulse
d221f04e60 Plugin Upgrader: Plugin_Upgrader::upgrade() returns nothing in event of success, every other install(), upgrade() and bulk_upgrade() method returns true, so return true;
Built from https://develop.svn.wordpress.org/trunk@25181


git-svn-id: http://core.svn.wordpress.org/trunk@25153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-30 07:38:09 +00:00
Dion Hulse
d3bd82f0ac Theme Upgrader: Be super-careful and check the contents of the $wp_theme_directories variable before merging it, if someone has changed it directly, or worse, unset it, this could've resulted in the $protected_directories being empty. See [25082] See #22501
Built from https://develop.svn.wordpress.org/trunk@25180


git-svn-id: http://core.svn.wordpress.org/trunk@25152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-30 07:35:09 +00:00
Andrew Nacin
af70c14d6d Add signup_id primary key to $wpdb->signups, and add better indexes.
props josephscott, pento, barry.
see #15004.

Built from https://develop.svn.wordpress.org/trunk@25179


git-svn-id: http://core.svn.wordpress.org/trunk@25151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-30 04:30:08 +00:00
Andrew Nacin
f16aee063e Avoid validating wildcard hostnames in populate_network() when multisite is already activated.
props jeremyfelt.
fixes #25182.

Built from https://develop.svn.wordpress.org/trunk@25171


git-svn-id: http://core.svn.wordpress.org/trunk@25146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-29 19:31:09 +00:00
Andrew Nacin
aa6d5ddb3e Don't create an edit link to a non-UI post type in the media list table.
props johnbillion.
fixes #20453.

Built from https://develop.svn.wordpress.org/trunk@25140


git-svn-id: http://core.svn.wordpress.org/trunk@25120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-27 20:49:10 +00:00
Andrew Nacin
f137f63e13 Network Admin: Hide the bulk actions checkbox for the main site.
props ericlewis.
fixes #24463.

Built from https://develop.svn.wordpress.org/trunk@25125


git-svn-id: http://core.svn.wordpress.org/trunk@25105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-26 18:46:08 +00:00
Sergey Biryukov
ca17a6161a Avoid displaying multiple instances of the same feature pointers on a single screen. props nacin. fixes #25022 for trunk.
Built from https://develop.svn.wordpress.org/trunk@25117


git-svn-id: http://core.svn.wordpress.org/trunk@25097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-24 22:34:10 +00:00
Sergey Biryukov
61e5d3e5c1 Remove unused variable. props jeremyfelt. fixes #25121.
Built from https://develop.svn.wordpress.org/trunk@25098


git-svn-id: http://core.svn.wordpress.org/trunk@25080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-23 00:19:09 +00:00
Andrew Nacin
d06c049d51 Fix various typos in inline documentation. props nofearinc, fixes #25119.
Built from https://develop.svn.wordpress.org/trunk@25094


git-svn-id: http://core.svn.wordpress.org/trunk@25078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-22 22:01:08 +00:00
Andrew Nacin
9b0e21493d In the admin, do not use auto-generated Gravatar images for comment authors.
This makes it easier to recognize Gravatars (or lack thereof) when moderating comments.

props solarissmoke.
fixes #7054.


Built from https://develop.svn.wordpress.org/trunk@25091


git-svn-id: http://core.svn.wordpress.org/trunk@25075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-22 20:08:08 +00:00
Helen Hou-Sandí
eb44516e48 Add more descriptive classes to submit meta box sections. props nofearinc. fixes #22333.
Built from https://develop.svn.wordpress.org/trunk@25083


git-svn-id: http://core.svn.wordpress.org/trunk@25068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-22 15:24:10 +00:00
Dion Hulse
8a70215404 Theme Installer/Updater: Handle custom Theme directories when updating themes, and installing new themes. Fixes #22501
Built from https://develop.svn.wordpress.org/trunk@25082


git-svn-id: http://core.svn.wordpress.org/trunk@25067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-22 04:50:09 +00:00
Dion Hulse
46daa240b9 Sanitize the plugin path in _get_plugin_data_markup_translate() to a WP_PLUGIN_DIR-relative path. The function is designed in mind for receiving relative paths, but may be used with a absolute path.
This change makes the function path-agnostic, and can accept either relative or absolute (converting to relative internally). Fixes #20813

Built from https://develop.svn.wordpress.org/trunk@25081


git-svn-id: http://core.svn.wordpress.org/trunk@25066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-22 04:03:09 +00:00
Dion Hulse
ff290a88bf Add a note that the FTP Password will not be stored on the server to the FTP credentials page. Fixes #16492
Built from https://develop.svn.wordpress.org/trunk@25071


git-svn-id: http://core.svn.wordpress.org/trunk@25056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-21 07:07:09 +00:00
Dion Hulse
907ca6cd30 Add a filter on the Plugin and Theme installers table listing API args, this allows for plugins to hook in and add custom args to plugins_api() and themes_api() for the Plugin/Theme listing tabls. Fixes #18169
Built from https://develop.svn.wordpress.org/trunk@25070


git-svn-id: http://core.svn.wordpress.org/trunk@25055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-21 06:52:12 +00:00
Dion Hulse
1b9ab9f66f WP_Filesystem: Use the FTP_* path override constants during upgrades for prefixed paths, ie. use FTP_BASE for ABSPATH/sub-dir as well as just for ABSPATH/. Props vericgar for initial patch. See #14401
Built from https://develop.svn.wordpress.org/trunk@25057


git-svn-id: http://core.svn.wordpress.org/trunk@25043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-20 06:47:08 +00:00
Dion Hulse
ad980384f2 Check to see if mbstring.func_overload is configured to affect string functions before switching charsets. Props SergeyBiryukov. Fixes #25063
Built from https://develop.svn.wordpress.org/trunk@25056


git-svn-id: http://core.svn.wordpress.org/trunk@25042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-20 06:24:09 +00:00
Dion Hulse
8156e29a98 WP_Upgrader: Don't activate maintenance mode in bulk_upgrade() when no Themes or Plugins are specified. This doesn't affect Core, but rather, plugins who use the upgrade routines and do not do precautionary tests. Props jamescollins. Fixes #24496
Built from https://develop.svn.wordpress.org/trunk@25048


git-svn-id: http://core.svn.wordpress.org/trunk@25035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-17 05:36:11 +00:00
Andrew Nacin
19e485ce42 In populate_network(), insert the first site as blog_id 1, overriding any auto-increment DB seed. props wpmuguru, fixes #16568.
Built from https://develop.svn.wordpress.org/trunk@25038


git-svn-id: http://core.svn.wordpress.org/trunk@25025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-16 20:08:09 +00:00
Andrew Nacin
f71a4ae220 Add a maxlength attribute to the post password input, reflecting the current DB field length.\
props RayBernard, DrewAPicture.
see #24792.


Built from https://develop.svn.wordpress.org/trunk@25035


git-svn-id: http://core.svn.wordpress.org/trunk@25022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-16 19:56:09 +00:00
Ryan Boren
e2c8edc22d Be consistent with the arguments passed to the theme_action_links filter. Stop passing stylesheet from class-wp-ms-themes-list-table.php.
Props georgestephanis
fixes #24478

Built from https://develop.svn.wordpress.org/trunk@25032


git-svn-id: http://core.svn.wordpress.org/trunk@25019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-16 15:47:10 +00:00
Sergey Biryukov
aadd546d48 Avoid PHP notices in get_sample_permalink() and get_sample_permalink_html(). Remove unused global reference. props ocean90. fixes #25005.
Built from https://develop.svn.wordpress.org/trunk@25028


git-svn-id: http://core.svn.wordpress.org/trunk@25015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-15 16:25:12 +00:00
Dominik Schilling
129e4a6e3b Remove unused cat JavaScript file. props carldanley. fixes #24989.
Built from https://develop.svn.wordpress.org/trunk@25020


git-svn-id: http://core.svn.wordpress.org/trunk@25011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-15 03:13:20 +00:00
Jon Cave
ee8ac47db1 Add javascript files deleted in [25013] to $_old_files. See #23486.
Built from https://develop.svn.wordpress.org/trunk@25019


git-svn-id: http://core.svn.wordpress.org/trunk@25010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-15 03:13:12 +00:00
Ryan Boren
3a5f483e14 Set RTL body class for iframes.
Props mitchoyoshitaka
see #24149


git-svn-id: http://core.svn.wordpress.org/trunk@24994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-06 17:35:43 +00:00
Andrew Nacin
8211e6172a Add data types to @param documentation for the _page_rows() method of the posts list table. props c3mdigital, fixes #24872.
git-svn-id: http://core.svn.wordpress.org/trunk@24985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-05 22:10:03 +00:00
Mark Jaquith
e553e85ebb Remove $pagenow global from three functions that don’t use it.
Props jeremyfelt. Fixes #24920.

git-svn-id: http://core.svn.wordpress.org/trunk@24974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-02 04:42:08 +00:00
Andrew Nacin
91c3637bbb Update about page for new screenshot and new video encoding. Remove old screenshots directory. fixes #24832.
git-svn-id: http://core.svn.wordpress.org/trunk@24942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-01 13:29:29 +00:00
Andrew Nacin
21a1fe8d4b Use wp_safe_remote_request() and friends instead of reject_unsafe_urls = true.
fixes #24646.



git-svn-id: http://core.svn.wordpress.org/trunk@24917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-31 06:52:13 +00:00
Andrew Nacin
ae1fe1a0d6 Add missing gettext. This is not a new string; it already exists a few lines up. props alex-ye, fixes #24880.
git-svn-id: http://core.svn.wordpress.org/trunk@24885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-29 19:48:41 +00:00
Andrew Nacin
3441fa2faf Rename post_lock_text hook to post_locked_dialog, and lock_taken_over_dialog to post_lock_lost_dialog. fixes #24830 for trunk.
git-svn-id: http://core.svn.wordpress.org/trunk@24884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-29 19:40:13 +00:00
Aaron Campbell
f055ac27d1 Make the show_post_locked_dialog filter hide both the post locked and post taken over dialogs
props azaozz, DH-Shredder. Fixes #24830 for trunk.


git-svn-id: http://core.svn.wordpress.org/trunk@24883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-29 19:25:26 +00:00
Mark Jaquith
f1b2c07df3 Delete old autosave if new autosave has same content as the post.
Props nacin. Fixes #7392 for trunk.

git-svn-id: http://core.svn.wordpress.org/trunk@24878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-29 19:06:08 +00:00
Jon Cave
5c57c78afa Fix potential SQLi through improper use of API functions.
git-svn-id: http://core.svn.wordpress.org/trunk@24875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-29 18:16:47 +00:00
Andrew Nacin
e0c4fc0032 Fix pass by reference issue. see #24873.
git-svn-id: http://core.svn.wordpress.org/trunk@24866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-29 17:53:24 +00:00
Mark Jaquith
b53325cad3 Revisions: Fix PHP loading of comparison to first revision, and premature rendering of tooltip.
Props aaroncampbell, markjaquith. Fixes #24873 for trunk.

git-svn-id: http://core.svn.wordpress.org/trunk@24864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-29 17:26:03 +00:00
Andrew Nacin
e91002f4fb Remove unnecessary cap checks from [24854]. You need these capabilities (or equivalent) to access the screens for these feature pointers. see #24832.
git-svn-id: http://core.svn.wordpress.org/trunk@24855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-29 06:43:30 +00:00
Mark Jaquith
8abd5bb815 Tooltips for 3.6 features: Revisions, Post Locking.
Props siobhan. See #24832 for trunk.

git-svn-id: http://core.svn.wordpress.org/trunk@24853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-29 06:17:01 +00:00
Mark Jaquith
1f312bc6ef Fix wrong use of esc_html_e().
Props ocean90. Fixes #24854 for trunk.

git-svn-id: http://core.svn.wordpress.org/trunk@24840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-29 01:00:59 +00:00
Mark Jaquith
ab09a13efa Rename the new 'left'/'right' flags on the _wp_post_revision_field_$field filter to 'from'/'to'.
Fixes #24848 for trunk.

git-svn-id: http://core.svn.wordpress.org/trunk@24835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-28 23:28:21 +00:00
Andrew Nacin
c1d022dc12 Terms list table: Only show 'View' links for public taxonomies. props SergeyBiryukov. fixes #24692.
git-svn-id: http://core.svn.wordpress.org/trunk@24824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-28 21:06:19 +00:00
Mark Jaquith
3cc3334fe8 Remove our revisions easter egg, as it doesn't have a place in our new UI.
There will be opportunities for other easter eggs. This one has had its decade.

Fixes #24852 for trunk. Props noahsilverstein.

git-svn-id: http://core.svn.wordpress.org/trunk@24820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-28 20:56:14 +00:00
Andrew Ozz
19fb0f1153 Add "experimental" to heartbeat phpdoc, fixes #24855 for trunk.
git-svn-id: http://core.svn.wordpress.org/trunk@24818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-28 20:54:48 +00:00
Jon Cave
3999883feb Remove unnecessary secret_salt_warning().
If salts/keys are not defined in wp-config.php then they will be generated
automatically and stored in the database. [19771] also deals with values
that are duplicated or set to default.

Fixes #14803.


git-svn-id: http://core.svn.wordpress.org/trunk@24813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-28 19:45:57 +00:00
Mark Jaquith
1e189c9689 Add some missing PHPDoc @since lines.
Fixes #24742. Props DrewAPicture.

git-svn-id: http://core.svn.wordpress.org/trunk@24804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-27 23:11:03 +00:00
Andrew Nacin
d07cc7be81 Don't show "Preview" for locked, non-public post types. props aaroncampbell. fixed #24139.
git-svn-id: http://core.svn.wordpress.org/trunk@24799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-27 06:57:42 +00:00
Mark Jaquith
84c50056b7 Reinstate 'label' property of nav menu items. Fixes a regression from [22234].
Fixes #24840. Props johnbillion.

git-svn-id: http://core.svn.wordpress.org/trunk@24798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-27 06:50:59 +00:00
Andrew Nacin
c8fe64a602 Revisions changes.
* Eliminates the bloated Revisions meta box in favor of 'Revisions: #' in the publish box.
 * Adds ability to compare autosave to current post, when revisions are disabled.
 * Makes autosaves stand out visually, including "Restore This Autosave".

Also:
 * Adds missing capability check for restoring a revision.
 * When no revision matches the post's current modified time, avoid marking an autosave as 'current'.
 * Fixes wp_get_post_autosave() to return an autosave even when revisions are disabled.
 * Add 'check_enabled' arg to wp_get_post_revisions(); false avoids the wp_revisions_enabled() check.
 * Adds a responsive slider that is narrower for fewer versions. props markjaquith.

see #24804.



git-svn-id: http://core.svn.wordpress.org/trunk@24790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-24 06:08:14 +00:00
Andrew Nacin
bc0a60920d Remove curly quotes from auto content generation for audio tracks on upload. Texturize should be doing this on display.
props tollmanz.
fixes 24810.



git-svn-id: http://core.svn.wordpress.org/trunk@24788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-24 05:47:00 +00:00
Andrew Nacin
1b9eb340af Do set_url_scheme() for Preview action link in the posts list table. props reidburke, fixes #23886.
git-svn-id: http://core.svn.wordpress.org/trunk@24780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-23 15:04:55 +00:00
Andrew Nacin
2c67dea9bc Media: Add awareness to Attachment Display Settings that audio and video can be embedded.
Also:
 * Add file length metadata to Attachment Details.
 * Round the kb/s bitrate on post.php.

fixes #24449.



git-svn-id: http://core.svn.wordpress.org/trunk@24777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-23 05:39:08 +00:00
Andrew Nacin
c2a543566c Move _local_storage_notice() to admin/includes/template.php. props azaozz, see #24756.
git-svn-id: http://core.svn.wordpress.org/trunk@24762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-22 05:09:49 +00:00
Mark Jaquith
13c63d211a Revisions: Pinned controls, layout tweaks, copy tweaks, misc.
* When you scroll down the diff view, the controls will pin to the top.
* The revisions meta view was cleaned up. Copy changes.
* Loading indicator in the center of the screen (so it follows as you scroll).
* Tooltips "flip" when you cross the center line, so that they don't hit the container edge and wrap for later revisions.
* The "Restore" button's inactive state is handled on render, instead of after.
* Make sure we always have a current revision, even if the timestamp doesn't work out on the most recent one.

See #24804. Props markjaquith, nacin, ocean90, aaroncampbell.

git-svn-id: http://core.svn.wordpress.org/trunk@24761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-22 05:05:45 +00:00
Mark Jaquith
e9afe4c5d1 Fixes and tweaks for the metabox accordion.
* Fixed hover issues in Customizer.
* Toned down the default active/hover style (as it is normally not the top level menu, and should not be so prominent).
* Allow the active section to be closed.
* Other misc fixes.

Props ocean90, helen. Fixes #23449.

git-svn-id: http://core.svn.wordpress.org/trunk@24734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-18 17:42:53 +00:00
Andrew Nacin
94555444ab If two revisions were created at the same time, mark the one with the greater ID as current. Also avoid flagging autosaves as current. fixes #24782.
git-svn-id: http://core.svn.wordpress.org/trunk@24730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-18 14:10:33 +00:00
Andrew Nacin
8d9a830c3c Remove stray character.
git-svn-id: http://core.svn.wordpress.org/trunk@24726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-17 21:09:14 +00:00
Peter Westwood
398ce8ecdf Fix a strict standards error in the plugin search when search for an already installed plugin.
Fixes #24747 props SergeyBiryukov.


git-svn-id: http://core.svn.wordpress.org/trunk@24725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-17 21:08:05 +00:00
Andrew Nacin
18a208af1b Inline docs for admin/includes/revision.php. props DrewAPicture, fixes #24742.
git-svn-id: http://core.svn.wordpress.org/trunk@24722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-17 20:39:35 +00:00
Andrew Nacin
8d65dc2469 Use wp_slash() in places where we improperly used the DB API instead. see #21767.
git-svn-id: http://core.svn.wordpress.org/trunk@24713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-16 14:19:03 +00:00
Mark Jaquith
24553b2f03 Improvements to output of revisions author data.
* Do not output "false" if avatars are disabled. props ocean90.
* Cache the author data separately to cut down on calls to `get_the_author_meta()` and `get_avatar()`. props nacin.

Fixes #24743.

git-svn-id: http://core.svn.wordpress.org/trunk@24708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-15 23:01:27 +00:00
Mark Jaquith
4e934c9e02 No PHP time limit when generating diffs.
Fixes #24757. Props nacin.

git-svn-id: http://core.svn.wordpress.org/trunk@24707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-15 22:53:48 +00:00
Dominik Schilling
99973e4738 Nav Menus: Hide the rearrange section in no-js. see #14045.
git-svn-id: http://core.svn.wordpress.org/trunk@24702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-13 16:38:14 +00:00
Andrew Nacin
e46e52ec0f ID3 1.9.7.
props wonderboymusic.
fixes #24737.



git-svn-id: http://core.svn.wordpress.org/trunk@24696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-13 00:37:36 +00:00
Helen Hou-Sandí
0da48b8335 Tweaks to the accordion:
* Enqueues JS in `do_accordion_sections()`.
* Top and bottom rounded corners for the nav menu accordion.
* Better RTL and no-JS.

props lessbloat, DrewAPicture, aaroncampbell, helen. fixes #23449.


git-svn-id: http://core.svn.wordpress.org/trunk@24680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-12 18:16:29 +00:00
Andrew Nacin
eaa4370237 Remove 'sorted' from do_accordion_sections(). fixes #23450.
git-svn-id: http://core.svn.wordpress.org/trunk@24674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-12 15:43:00 +00:00
Mark Jaquith
e8b9088c5f Revisions: Cleanup, bug fixes, refactoring, polish.
* Hide the tooltip initially.
* Fix a bug with routing.
* Further separate the Slider model and view, refactoring its code.
* More reliance on events than direct calls between areas.
* Smarter background diff loading (single mode). Loads the diffs closest to your position first.
* Removed a bunch of manual templating and `render()` methods. Now relies more on the WP Backbone Views functionality.
* include the requested `id` in `ensure:load`.
* new trigger: `ensure`, for `ensure()` attempts, regardless of whether they are already loaded.
* pass along a promise in both `ensure` and `ensure:load`.
* in `ensure`, remove requests for diffs we aready have

See #24425.

git-svn-id: http://core.svn.wordpress.org/trunk@24671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-12 14:01:39 +00:00
Mark Jaquith
7cf1702442 Fix a PHP 5.4-ism that slipped in.
git-svn-id: http://core.svn.wordpress.org/trunk@24670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-12 07:26:11 +00:00
Mark Jaquith
ef8ff9efac Revisions: sort by date, not modified, to match revisions meta box.
See #24425.

git-svn-id: http://core.svn.wordpress.org/trunk@24668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-12 05:41:39 +00:00
Mark Jaquith
13a7d2a743 Revisions: Loading indicator, cleanup, bug fixes.
* Loading indicator when the user is waiting for a trip to the server.
* Bug fixes for diff priming.
* Fix the date display.
* Forget about local comparator, instead order by `modified` on the server.
* Initialize the frame model before the view (this was the source of a LOT of heartache).

git-svn-id: http://core.svn.wordpress.org/trunk@24667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-12 05:11:56 +00:00
Mark Jaquith
c44ce3b6e6 Revisions: real URLs and preloading of the requested diff.
* Real URLs are being used now, using pushState. `?revision={id}` or `?from={from}&to={to}`.
* Drop the redundant `action=edit` from the URLs (this is the default).
* The initial comparison is preloaded, whether a single revision or a compare-two situation.

See #24425.

git-svn-id: http://core.svn.wordpress.org/trunk@24664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-11 22:56:48 +00:00
Andrew Nacin
25d9d478ac Compare GMT to GMT. see #24425.
git-svn-id: http://core.svn.wordpress.org/trunk@24663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-11 20:57:47 +00:00
Andrew Nacin
031d959efd Modify todo in wp_ajax_autosave(). fixes #23665.
git-svn-id: http://core.svn.wordpress.org/trunk@24651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-11 00:06:52 +00:00
Andrew Nacin
bcd2644d92 Proper translation of '<time> ago' in revisions. props johnbillion, fixes #24721.
git-svn-id: http://core.svn.wordpress.org/trunk@24643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-10 16:15:18 +00:00
Andrew Nacin
51e89cca30 Fix the chown and chgrp methods for the filesystem API's SSH2 transport. fixes #24277.
git-svn-id: http://core.svn.wordpress.org/trunk@24626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-10 04:15:13 +00:00
Andrew Nacin
7d53bd66ed Use maybe_unserialize() in upgrade.php's private get_option() function. This actually predates maybe_unserialize() ([2487], [3234]). props leewillis77. fixes #24365.
git-svn-id: http://core.svn.wordpress.org/trunk@24625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-10 04:01:20 +00:00
Mark Jaquith
35b08acc8d Pass back dateUnix (a unix timestamp) for better sorting of revisions in Backbone.
Props duck_. See #24425.

git-svn-id: http://core.svn.wordpress.org/trunk@24615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-09 19:21:25 +00:00
Andrew Nacin
c80a049db3 In populate_options(), only query the option names we are checking against. No need to load the entire table into memory. props leewillis77. fixes #24620.
git-svn-id: http://core.svn.wordpress.org/trunk@24614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-09 19:14:33 +00:00
Daryl Koopersmith
590bf668e9 Revisions: Debounce fetching Diffs when revisions are updated.
Fixes navigation and casting bugs.

See #24425.


git-svn-id: http://core.svn.wordpress.org/trunk@24611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-09 09:57:58 +00:00
Daryl Koopersmith
2f9ef11796 Revisions: Reduce points where IDs are cast in JS. See #24425.
git-svn-id: http://core.svn.wordpress.org/trunk@24605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-09 07:55:50 +00:00
Andrew Nacin
740d141e1d Support IIS 8 and above.
props hurtige for initial patch.
fixes #23533.



git-svn-id: http://core.svn.wordpress.org/trunk@24594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-08 20:27:06 +00:00
Andrew Nacin
c2db94d10c Use meta caps edit_post, read_post, and delete_post directly, rather than consulting the post type object. map_meta_cap() handles that for us. props markjaquith, kovshenin. fixes #23226.
git-svn-id: http://core.svn.wordpress.org/trunk@24593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-08 20:05:42 +00:00
Andrew Nacin
7f488b4096 Use correct variable when calling request_filesystem_credentials() in delete_theme(). see #24210.
git-svn-id: http://core.svn.wordpress.org/trunk@24590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-08 17:10:47 +00:00
Andrew Nacin
44abe2e502 Use wp_basename() in newer media code for filenames to avoid encoding issues on display. props SergeyBiryukov, fixes #23267.
git-svn-id: http://core.svn.wordpress.org/trunk@24585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-08 13:55:50 +00:00
Andrew Nacin
7f396bfab0 Avoid possible array collision in dbDelta when recording index adds. props apimlott, wonderboymusic. fixes #21272.
git-svn-id: http://core.svn.wordpress.org/trunk@24584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-08 13:54:19 +00:00
Andrew Nacin
55b3c67413 Revert [23394] until there is a consensus on target="_blank" (or not) for these external links. see #20839.
git-svn-id: http://core.svn.wordpress.org/trunk@24583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-08 13:04:07 +00:00
Dominik Schilling
4fc5e70228 Revisions improvements
* Corrected routing behavior
* Simplified CSS for tooltips
* Compare two mode for RTL
* Support for posts without titles 

props adamsilverstein, ocean90. see #24425.

git-svn-id: http://core.svn.wordpress.org/trunk@24578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-06 10:48:14 +00:00
Mark Jaquith
5f19c95249 Gracefully slide down the "{Name} is editing" notice portion of the post row, so everything isn't shifting down in an instant and throwing off people's clicks.
fixes #24553. props kadamwhite, johnbillion.

git-svn-id: http://core.svn.wordpress.org/trunk@24576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-05 23:17:25 +00:00
Mark Jaquith
759298f8b8 Instead of saying that scaling up images will result in fuzzy images, just say that it's not supported (because it isn't).
fixes #23713. props ericlewis.

git-svn-id: http://core.svn.wordpress.org/trunk@24562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-05 15:45:43 +00:00
Andrew Nacin
6500a24719 Call shortcode functions directly. props kovshenin, fixes #24505.
git-svn-id: http://core.svn.wordpress.org/trunk@24547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-03 20:19:00 +00:00
Andrew Ozz
5d1439e247 Heartbeat: fix comment spelling
git-svn-id: http://core.svn.wordpress.org/trunk@24544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-03 01:59:46 +00:00
Dominik Schilling
2bf327f3b2 Revisions UI: Fix table colgroup (Say what?) for post titles when they haven't been changed. see #24425.
git-svn-id: http://core.svn.wordpress.org/trunk@24529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-29 17:45:02 +00:00
Andrew Ozz
b8b66e2cc1 Nonce refresh:
- Update the heartbeat nonce when refreshing nonces on the Edit Post screen.
- After a user logs in from the auth-check dialog, speed up heatrbeat to check/refresh nonces on the Edit Post screen.
- Speeding up heartbeat: bring back the setting how long it should last (how many ticks).
- Add 'heartbeat-nonces-expired' jQuery event when nonces have expired and the user is logged in.
See #23295, see #23216.

git-svn-id: http://core.svn.wordpress.org/trunk@24528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-29 01:31:44 +00:00
Andrew Ozz
7862ae7294 Post locked dialog: remove the "Go to" part from the button as it's not translatable. Fixes #24547.
git-svn-id: http://core.svn.wordpress.org/trunk@24527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-27 21:59:48 +00:00
Sergey Biryukov
c3b321d0bd Consistently use get_post_format_string() to get Standard post format name with the correct context. props johnbillion. fixes #23503.
git-svn-id: http://core.svn.wordpress.org/trunk@24522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-27 06:56:45 +00:00
Mark Jaquith
77abb9ff01 Cleanup of the revisions screen, both on the PHP API side, and the JS.
* Much simpler PHP API
* Cleaner and more Backbone-y JS API
* Consequently, does batch queries; this now scales up to hundreds of revisions

Currently missing, but much easier considering the cleaned up base:

* Compare two mode
* RTL

props koopersmith, nacin, adamsilverstein, ocean90. see #24425

git-svn-id: http://core.svn.wordpress.org/trunk@24520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-26 21:06:50 +00:00
Sergey Biryukov
34d0f347ad Revert to storing a hash of the slashed password. fixes #24367. see #17018.
git-svn-id: http://core.svn.wordpress.org/trunk@24508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-25 11:14:50 +00:00
Sergey Biryukov
2ebbe00b55 Remove obsolete translator comment. props zeo. fixes #24464.
git-svn-id: http://core.svn.wordpress.org/trunk@24505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-23 08:30:30 +00:00
Andrew Nacin
3864f4cedf Remove redundant swfupload-all.js file.
git-svn-id: http://core.svn.wordpress.org/trunk@24488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-21 09:26:18 +00:00
Andrew Nacin
96ee267343 Better validation of the URL used in core HTTP requests.
git-svn-id: http://core.svn.wordpress.org/trunk@24480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-21 06:07:47 +00:00
Andrew Nacin
c0c884b522 Better cap checks in _wp_translate_post_data().
git-svn-id: http://core.svn.wordpress.org/trunk@24478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-21 06:00:59 +00:00
Andrew Nacin
3bfb59b39d More robust escaping in the plugin/theme upgrader.
git-svn-id: http://core.svn.wordpress.org/trunk@24474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-21 05:54:40 +00:00
Andrew Nacin
be01fce99f Show a relative path in an upload error message.
git-svn-id: http://core.svn.wordpress.org/trunk@24463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-21 02:29:26 +00:00
Mark Jaquith
1b84d2140a Prevent an offset error if the first menu item is a separator.
props phill_brown. fixes #23182

git-svn-id: http://core.svn.wordpress.org/trunk@24455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-20 16:45:45 +00:00
Andrew Nacin
d80469f8a5 Fix storage of illegal_names. Add an upgrade routine to fix bad values.
props SergeyBiryukov.
see #23418.
for trunk.



git-svn-id: http://core.svn.wordpress.org/trunk@24448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-19 22:06:42 +00:00
Andrew Nacin
3231e8cbd0 Pass $post to hooks in edit-form-advanced.php including edit_form_advanced and edit_form_after_*. fixes #24611.
git-svn-id: http://core.svn.wordpress.org/trunk@24446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-19 21:10:51 +00:00
Helen Hou-Sandí
bd231c209f Add post format icons to the radio chooser. This also trims empty margins from the sprites to make them usable in RTL and make positioning numbers more sane. props ryelle, kovshenin for the initial patch. fixes #24519.
git-svn-id: http://core.svn.wordpress.org/trunk@24429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-07 17:15:53 +00:00
Dominik Schilling
0bba1877c4 Remove post format icons next to header on edit post screen. fixes #24502. see #24452.
git-svn-id: http://core.svn.wordpress.org/trunk@24415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-06 14:45:25 +00:00
Mark Jaquith
5626969d0b Restore post format previewing.
props azaozz. fixes #24483

git-svn-id: http://core.svn.wordpress.org/trunk@24414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-06 14:39:08 +00:00
Sergey Biryukov
115866d483 Fix E_STRICT notice in WP_Theme_Install_List_Table::_js_vars(). see #24356.
git-svn-id: http://core.svn.wordpress.org/trunk@24409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-05 16:51:07 +00:00
Andrew Ozz
5642a56311 Post locks:
- When a post is locked, ensure the 'Go back' button doesn't reload the same screen. If no referrer, change the button from 'Go back' to 'Go to All Posts'/'Go to All Pages' etc.
- Remove restriction on checking locks only for posts.
See #23697.



git-svn-id: http://core.svn.wordpress.org/trunk@24408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-05 03:01:59 +00:00
Andrew Ozz
0fff739949 Heartbeat: rename some vars/args to make them more intuitive, don't set user_id on every request, see #23216
git-svn-id: http://core.svn.wordpress.org/trunk@24406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-05 00:13:40 +00:00
Dominik Schilling
9c5c9dc805 Replace the global $id from manage_media_custom_column action with $post-ID. Missed in [24337]. props nickdaugherty. fixes #24476.
git-svn-id: http://core.svn.wordpress.org/trunk@24396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-01 09:40:00 +00:00
Mark Jaquith
89fd06e44b First pass at removing Post Format UI.
see #24452. fixes #24455.

git-svn-id: http://core.svn.wordpress.org/trunk@24388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-30 21:33:46 +00:00
Sergey Biryukov
5c23d5908a Avoid 'Only variables should be assigned by reference' warnings during installation. props sunnyratilal. fixes #24438.
git-svn-id: http://core.svn.wordpress.org/trunk@24381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-28 17:06:39 +00:00
Sergey Biryukov
7bcdd673ed Remove unnecessary esc_attr() call and redundant title attributes. props zeo. fixes #24437.
git-svn-id: http://core.svn.wordpress.org/trunk@24380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-28 04:53:46 +00:00
Sergey Biryukov
e67ce959c5 Fix E_STRICT notice in WP_MS_Themes_List_Table::single_row(). fixes #24356.
git-svn-id: http://core.svn.wordpress.org/trunk@24379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-28 04:10:10 +00:00
Sergey Biryukov
b13b659365 Fix E_STRICT notice in wp_get_popular_importers(). see #24356.
git-svn-id: http://core.svn.wordpress.org/trunk@24378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-28 03:53:59 +00:00
Sergey Biryukov
4b13a1ffa4 Fix E_STRICT notices in walkers. props dvarga. see #24356.
git-svn-id: http://core.svn.wordpress.org/trunk@24377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-28 03:29:15 +00:00
Mark Jaquith
58e02a1530 Remove unnecessary parenthetical that should have been "e.g." instead of "i.e." anyway.
see #23119

git-svn-id: http://core.svn.wordpress.org/trunk@24356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-25 16:52:26 +00:00
Sergey Biryukov
ed8fc60775 Remove unused variable. props zeo. fixes #24412.
git-svn-id: http://core.svn.wordpress.org/trunk@24346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-24 16:50:50 +00:00
Andrew Nacin
7cc15a2e7f Remove use of global $id from comment_form() and the media list table. see #24330.
git-svn-id: http://core.svn.wordpress.org/trunk@24337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-23 18:40:16 +00:00
Sergey Biryukov
bb1e5b4d33 Use numbered placeholders. see #24389.
git-svn-id: http://core.svn.wordpress.org/trunk@24327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-22 21:26:36 +00:00
Andrew Nacin
797ee34bc3 Remove /extend/ from URLs to wordpress.org/plugins, /themes, and /mobile, as those are all now top-level. see #24389.
git-svn-id: http://core.svn.wordpress.org/trunk@24320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-22 21:01:57 +00:00
Andrew Ozz
d306a85654 Add more specific error messages when upgrading themes and plugins and the package cannot be extracted (no files), props SergeyBiryukov, fixes #24223
git-svn-id: http://core.svn.wordpress.org/trunk@24313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-22 16:57:20 +00:00
Andrew Ozz
a26190eb2e Post locks:
- Change from IDs to classes for the notification-dialog divs so they can be reused.
- Do not check post locks if the dialog's html is not present.
- Do not check post locks if there is only one user on a single site install.
See #23697.

git-svn-id: http://core.svn.wordpress.org/trunk@24304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-20 19:36:29 +00:00
Ryan Boren
ad4a081c0c Pinking shears
git-svn-id: http://core.svn.wordpress.org/trunk@24303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-20 12:10:58 +00:00
Ryan Boren
5b7e9c8a1c Display the post format UI when there is structured data associated with the post regardless of the screen option.
Props kovshenin
see #24327


git-svn-id: http://core.svn.wordpress.org/trunk@24282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-17 15:12:50 +00:00
Ryan Boren
9eff7bb71a Don't show both "update failed" and "update successful" messages when upgrading a theme fails due to connectivity problems.
Props SergeyBiryukov
fixes #23027


git-svn-id: http://core.svn.wordpress.org/trunk@24276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-16 12:46:36 +00:00
Andrew Ozz
2f0c58960a Separate the nonces update from checking the post lock. Fix scheduling the logged out check. See #23697, see #23295.
git-svn-id: http://core.svn.wordpress.org/trunk@24273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-16 03:47:09 +00:00
Sergey Biryukov
421f66a7bb Add file header to post-formats.php. props DrewAPicture. fixes #24349.
git-svn-id: http://core.svn.wordpress.org/trunk@24267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-15 23:14:45 +00:00
Andrew Ozz
7255abb66c Fix showing and hiding of UI elements when disabling the Post Formats UI, props kovshenin, see #24327
git-svn-id: http://core.svn.wordpress.org/trunk@24264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-15 20:43:09 +00:00
Dominik Schilling
cf47737813 Revisions: Correct check for ensuring comparison always from newer to older revision. props adamsilverstein. fixes #24340.
git-svn-id: http://core.svn.wordpress.org/trunk@24263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-15 19:09:39 +00:00
Dominik Schilling
6d0173ba11 RTL support for the new post Format UI. see #24326.
git-svn-id: http://core.svn.wordpress.org/trunk@24258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-14 19:01:57 +00:00
Ryan Boren
66472f11a0 phpdoc improvements for wp_dashboard_quota()
Props DrewAPicture, h4ck3rm1k3


git-svn-id: http://core.svn.wordpress.org/trunk@24246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-14 12:37:30 +00:00
Andrew Nacin
46097dec37 Pass blog_id to the wpmu_drop_tables filter. props mitchoyoshitaka. see #24320.
git-svn-id: http://core.svn.wordpress.org/trunk@24245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-11 21:58:40 +00:00
Sergey Biryukov
4b174612ab Prevent menu items with '0' label from being removed on menu saving. props MikeHansenMe, kovshenin. fixes #23051.
git-svn-id: http://core.svn.wordpress.org/trunk@24235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-10 18:03:09 +00:00
Sergey Biryukov
7aca821e4c Display consistent labels in Image post format UI for users with and without unfiltered_html capability. props tollmanz. fixes #24304. see #24291.
git-svn-id: http://core.svn.wordpress.org/trunk@24232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-10 14:41:58 +00:00
Sergey Biryukov
013d0d06c6 Remove debug cruft. props kovshenin. see #23930.
git-svn-id: http://core.svn.wordpress.org/trunk@24231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-10 12:26:46 +00:00
Sergey Biryukov
c5a028821b Use esc_textarea(), not esc_html(), for escaping textarea content. props johnbillion. fixes #24300.
git-svn-id: http://core.svn.wordpress.org/trunk@24230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-10 02:06:34 +00:00
Sergey Biryukov
74638ccb5a Fix typos in phpdoc. props TheLastCicada. fixes #24302.
git-svn-id: http://core.svn.wordpress.org/trunk@24229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-10 01:39:30 +00:00
Sergey Biryukov
fb6293b714 Use correct escaping function. props tollmanz. fixes #24300.
git-svn-id: http://core.svn.wordpress.org/trunk@24228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-09 23:53:24 +00:00
Mark Jaquith
f63001eb2c Improve the UX and flow of the Image post format.
* Drag-and-drop
* Textarea for HTML/URL hidden to start
* Bigger click target for entering Media modal
* Image preview height-contrained to 300 pixels
* Hid the alignment, size, etc options that didn't have an effect anyway
* Got wp-format-{format} into the <body> class

props DrewAPicture, aaroncampbell, markjaquith, azaozz. see #24291.

git-svn-id: http://core.svn.wordpress.org/trunk@24226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-09 22:45:14 +00:00
Sergey Biryukov
415a5c60da * Pass ellipsis as a parameter to wp_html_excerpt() instead of appending it manually.
* Consolidate the logic to avoid appending ellipsis if the entire string is shown.
* Show ellipsis after truncated filenames and post titles.

props solarissmoke, bpetty, SergeyBiryukov. fixes #11446.

git-svn-id: http://core.svn.wordpress.org/trunk@24214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-09 00:22:02 +00:00
Sergey Biryukov
08bef7a3cb Use wp_trim_words() in Recent Drafts widget. fixes #24292.
git-svn-id: http://core.svn.wordpress.org/trunk@24212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-08 23:06:41 +00:00
Andrew Ozz
d0c5c59c94 Post locks and autosave:
- Move nonces refreshing from autosave to lock checking.
- Do autosave only when there is something to save.
See #23295

git-svn-id: http://core.svn.wordpress.org/trunk@24209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-08 22:52:55 +00:00
Sergey Biryukov
57c10eadbb Use ellipsis instead of three dots. props tjsingleton, jordie23, wojtek.szkutnik, DrewAPicture, SergeyBiryukov. see #8714.
git-svn-id: http://core.svn.wordpress.org/trunk@24207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-08 21:27:31 +00:00
Mark Jaquith
5ee1a961a4 Ensure that draft posts cannot be given a non-unique post slug when using Quick Edit.
fixes #22902. props SergeyBiryukov.

git-svn-id: http://core.svn.wordpress.org/trunk@24206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-08 21:26:17 +00:00
Dominik Schilling
cbec9880a7 Revisions UI: RTL support. (And inline docs.)
props DrewAPicture, adamsilverstein. fixes #23897.

git-svn-id: http://core.svn.wordpress.org/trunk@24205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-08 21:22:01 +00:00
Mark Jaquith
57b1dd212b Go back to plain text diffs between revisions instead of attempting partial rendering.
fixes #24254

git-svn-id: http://core.svn.wordpress.org/trunk@24192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-07 20:34:58 +00:00
Andrew Nacin
a518fb0c94 Fix usage of undeclared variables.
* the_weekday_date() needs the global $currentday
 * ms_site_check() needs the global $current_site
 * media list table does not need to check for $total_orphans
 * upgrader has no $feedback variable, appears to be copypasta from other upgrade APIs
 * install_themes_feature_list() has no $features variable, return array() instead of a new return type of WP_Error

see #24210.



git-svn-id: http://core.svn.wordpress.org/trunk@24189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-07 16:35:03 +00:00
Andrew Nacin
3b4a087007 remove_filter() only accepts three arguments: filter, callback, and priority. An accepted args parameter is only used for adds.
props rlerdorf.
see #24210.



git-svn-id: http://core.svn.wordpress.org/trunk@24188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-07 15:55:31 +00:00
Andrew Nacin
b34ca3234e Remove manual printing of userSettings as utils.js receives this as inline script data (since 3.5). see #24210.
git-svn-id: http://core.svn.wordpress.org/trunk@24187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-07 15:49:20 +00:00
Sergey Biryukov
e2dde2765c Update the instructions on Edit Menus screen. props DrewAPicture. fixes #24261.
git-svn-id: http://core.svn.wordpress.org/trunk@24185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-07 14:55:14 +00:00
Ryan Boren
164b3e71e6 Update some copy in the Post Formats UI.
see #24227


git-svn-id: http://core.svn.wordpress.org/trunk@24184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-07 13:56:07 +00:00
Sergey Biryukov
23479edf3f Avoid PHP notices in Media Library if an attachment parent does not exist. props trepmal, viniciusmassuchetto, alex-ye, adamsilverstein for initial patches. fixes #22312. fixes #23154.
git-svn-id: http://core.svn.wordpress.org/trunk@24182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-07 11:46:35 +00:00
Dominik Schilling
8ebc1c654e Revisions: Mark deprecated arguments in wp_list_post_revisions().
* Second argument is now a string, which controls the revision type
* Back compat for $args['type']
* Remove lines for the old form-table format, since it's now just a list 

props a.hoereth. fixes #24213.

git-svn-id: http://core.svn.wordpress.org/trunk@24175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-04 12:54:00 +00:00
Dominik Schilling
ea1cecebee Revisions UI: Add translation contexts and remove unneeded lines.
props nao. fixes #23917.

git-svn-id: http://core.svn.wordpress.org/trunk@24157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-02 10:12:19 +00:00
Andrew Nacin
2ea564da8b Terms list table:
* Don't call single_row() with an undeclared and unused $taxonomy argument.
 * Don't define optional parameters before required parameters in the _rows() method. Make them required.
 * Move empty( $terms ) check above other operations. This function was improperly returning an else case until [24123].

props rlerdorf.
see #24210.



git-svn-id: http://core.svn.wordpress.org/trunk@24127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-29 13:39:28 +00:00
Andrew Nacin
17ddaa8de0 delete_user_setting() and remove_action() were getting called with too many args. props rlerdorf. see #24210.
git-svn-id: http://core.svn.wordpress.org/trunk@24125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-29 13:25:15 +00:00
Sergey Biryukov
dace3f0b6d Remove redundant echo calls from list tables. Don't mix string concatenation with direct output. see #24210.
git-svn-id: http://core.svn.wordpress.org/trunk@24123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-29 01:10:50 +00:00
Mark Jaquith
1b554db95a Post format UI refresh.
* Post format switcher does not go away after clicking
* Refresh of format switcher style
* Highlighting of active post format
* Prompt text goes under the switcher
* Better animations

see #24046. props wonderboymusic, johnjamesjacoby, aaroncampbell, PeteMall.

Also, because I forgot it on [24006]: props saracannon.

git-svn-id: http://core.svn.wordpress.org/trunk@24098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-26 12:22:55 +00:00
Mark Jaquith
082e067a2d Screen option for Post Format UI.
props nacin. see #23930.

git-svn-id: http://core.svn.wordpress.org/trunk@24092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-25 07:28:33 +00:00
Mark Jaquith
90fc15e6d9 post-new.php?format=X will pre-fill the format, to allow for Post-Format-chosen-first editor jump-starting.
props kovshenin, wonderboymusic. fixes #24116.

git-svn-id: http://core.svn.wordpress.org/trunk@24081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-25 02:44:23 +00:00
Andrew Nacin
e7b2915ecd dbDelta: When parsing out the DEFAULT value, avoid being too greedy. props hbanken, fixes #15948.
git-svn-id: http://core.svn.wordpress.org/trunk@24065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-22 22:00:50 +00:00
Andrew Nacin
00b7fa589a Remove ancient 'lookup' quicktag from the text editor. This had called up answers.com.
props mboynes, jonbishop, SergeyBiryukov.
fixes #23322.



git-svn-id: http://core.svn.wordpress.org/trunk@24052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-22 20:17:25 +00:00
Andrew Nacin
b11654ce74 Revert [23871] - Customize should be added to the menu, but not hacked in as first. see #21413.
git-svn-id: http://core.svn.wordpress.org/trunk@24048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-22 19:33:39 +00:00
Andrew Nacin
d095eac796 Ensure that the resulting post time is localized after the date is changed. props SergeyBiryukov. fixes #24072.
git-svn-id: http://core.svn.wordpress.org/trunk@24046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-22 19:04:02 +00:00
Andrew Ozz
d2a8f064aa Post locks:
- Show 'Saving revision...' while autosaving after a post has been taken over. Change to 'Your latest changes were saved as a revision.' when autosave completes.
- Make sure a user exists before using $user->display_name.
- Add 'post_lock_text' action for extending the message text.

git-svn-id: http://core.svn.wordpress.org/trunk@24042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-22 03:08:51 +00:00
Dominik Schilling
9313710f79 Post Formats: Change post screen icon on selection. props markjaquith. fixes #24140.
git-svn-id: http://core.svn.wordpress.org/trunk@24039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-19 22:00:10 +00:00
Mark Jaquith
2d382c1a5c Post Formats: use the content body for the body of the Quote post format.
* Searchable, better editing tools
* Less cluttered Post Format UI

props kovshenin, DrewAPicture. see #24009

git-svn-id: http://core.svn.wordpress.org/trunk@24034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-18 18:07:58 +00:00
Andrew Nacin
ef3d64ccd9 Pass $post to display_post_states filter (in _post_states()).
git-svn-id: http://core.svn.wordpress.org/trunk@24028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-18 15:02:30 +00:00
Sergey Biryukov
5f2f48135b Rename some variables for consistency. Remove redundant absint() call. see #24010.
git-svn-id: http://core.svn.wordpress.org/trunk@24024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-18 00:40:36 +00:00
Mark Jaquith
412161de03 Standardize post format postmeta keys around the ones already used by the Crowd Favorite plugin.
props wonderboymusic. fixes #24010.

git-svn-id: http://core.svn.wordpress.org/trunk@24021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-17 20:57:44 +00:00
Dominik Schilling
45a9b723ee Revisions: Clean up JavaScript variable names, see #23901.
git-svn-id: http://core.svn.wordpress.org/trunk@24019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-17 19:34:21 +00:00
Mark Jaquith
56d5d62a19 New Post Format UI chooser treatment in response to testing.
* Bigger icons
* Format description under each
* UI hides after choice
* Saving without choosing implies "Standard"
* Helpful text, with "Change format" link

see #24046. props lessbloat, wonderboymusic.

git-svn-id: http://core.svn.wordpress.org/trunk@24006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-17 04:08:46 +00:00
Dominik Schilling
731f040664 Revisions UI: Remove the "To:" prefix from the header when viewing a single revision. Also prefix a revision field with a label.
props SergeyBiryukov, adamsilverstein, faishal. fixes #23903.

git-svn-id: http://core.svn.wordpress.org/trunk@23994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-15 18:40:17 +00:00
Mark Jaquith
21bb61466a Only say we accept a raw video/audio embed code for unfiltered_html users.
props wonderboymusic. see #23961

git-svn-id: http://core.svn.wordpress.org/trunk@23985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-14 01:21:47 +00:00
Andrew Ozz
e315287283 Fix accidental revert of revisions comparison in [23981]
git-svn-id: http://core.svn.wordpress.org/trunk@23982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-13 00:45:47 +00:00
Andrew Ozz
76302d7d3c Post locks: make sure we never overwrite a draft when it's locked, clean up wp_ajax_autosave() and make wp-refresh-post-lock a bit more robust, see #23697
git-svn-id: http://core.svn.wordpress.org/trunk@23981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-13 00:41:15 +00:00
Mark Jaquith
94c5f0aca1 Use ID3 data for audio and video
fixes #23926. props wonderboymusic, SergeyBiryukov, johnbillion.

git-svn-id: http://core.svn.wordpress.org/trunk@23979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-12 22:27:24 +00:00
Andrew Ozz
44752d0dad Revisions: compare revisions by date in wp_ajax_revisions_data(), deprecate the $parent arg in wp_list_post_revisions() as now revisions always include a copy of the current post, props adamsilverstein, see #23901
git-svn-id: http://core.svn.wordpress.org/trunk@23975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-12 19:29:21 +00:00
Sergey Biryukov
97e19c7c3a Fix typo in upgrade_100(). props tivnet, bpetty. fixes #24020.
git-svn-id: http://core.svn.wordpress.org/trunk@23949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-10 16:04:36 +00:00
Sergey Biryukov
e3e667056d Add alt attribute for selected image. see #19570.
git-svn-id: http://core.svn.wordpress.org/trunk@23940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-09 17:12:47 +00:00
Sergey Biryukov
af0815a45c Fix inconsistent id attributes. props kovshenin. fixes #24006.
git-svn-id: http://core.svn.wordpress.org/trunk@23939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-09 17:08:25 +00:00
Helen Hou-Sandí
bd4cc15d68 Remove unnecessary label, placeholder, and class for a hidden input. see #23938.
git-svn-id: http://core.svn.wordpress.org/trunk@23931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-07 16:49:56 +00:00
Andrew Ozz
33dd4b3d69 Revisions:
- Store the post format as meta on revisions (including autosaves).
- Add post formats data (post meta) when autosaving.
- Only add non-empty post formats data to revisions.
- Correct the post format when previewing a published post.
Props kovshenin, see #19570, see #20564.


git-svn-id: http://core.svn.wordpress.org/trunk@23928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-06 23:18:52 +00:00
Andrew Ozz
50ff2315a6 Post formats: connect labels with fields, move the two css blocks dealing with formats next to each other, see #23938
git-svn-id: http://core.svn.wordpress.org/trunk@23926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-06 21:40:58 +00:00
Sergey Biryukov
8d546ad739 Avoid an undefined index notice in wp_read_video_metadata(). props ocean90. fixes #23953.
git-svn-id: http://core.svn.wordpress.org/trunk@23923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-06 00:29:12 +00:00
Helen Hou-Sandí
42412f66b1 Show labels and remove improperly-used placeholders for post format fields. props Ipstenu, azaozz. see #23938.
git-svn-id: http://core.svn.wordpress.org/trunk@23918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-05 02:37:13 +00:00
Andrew Nacin
bc7082a7c3 WP_Upgrader: Add upgrader_process_complete hooks and add a abort_if_destination_exists flag (default is true). props dd32. see #18200.
git-svn-id: http://core.svn.wordpress.org/trunk@23912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-04 21:10:54 +00:00
Andrew Nacin
3015605cae Use get_post() in lieu of direct query in wp_ajax_replyto_comment(). fixes #23940.
git-svn-id: http://core.svn.wordpress.org/trunk@23907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-04 18:44:38 +00:00
Mark Jaquith
90c2110475 A little more revisions js/php cleanup. see #23901. props kovshenin, ocean90.
git-svn-id: http://core.svn.wordpress.org/trunk@23904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-04 16:03:21 +00:00
Andrew Nacin
14e31c8ec6 Use correct option name when deleting embed_autourls. props SergeyBiryukov. see #23715.
git-svn-id: http://core.svn.wordpress.org/trunk@23902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-04 15:55:53 +00:00
Mark Jaquith
2a38966a97 Further cleanup of revisions code. Probably not the last.
see #23901. props adamsilverstein, azaozz, ocean90.

git-svn-id: http://core.svn.wordpress.org/trunk@23898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-04 07:53:49 +00:00
Andrew Nacin
10d898ecbb Remove _wp_delete_nav_menu(). wp_delete_nav_menu() should instead remove the menu from theme locations, which was the only difference between the functions. see #23119.
git-svn-id: http://core.svn.wordpress.org/trunk@23897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-04 04:28:12 +00:00
Andrew Nacin
b62d398742 Replace $user_id removed in [23889] with a direct function call. see #23665.
git-svn-id: http://core.svn.wordpress.org/trunk@23890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-03 04:37:50 +00:00
Andrew Nacin
b77e90c5bf No need to check for the presence of a current user in a privileged ajax action. see #23665.
git-svn-id: http://core.svn.wordpress.org/trunk@23889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-03 04:34:14 +00:00
Sergey Biryukov
ea4acee9f9 Use correct escaping function. see #23900.
git-svn-id: http://core.svn.wordpress.org/trunk@23878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-29 22:20:18 +00:00
Helen Hou-Sandí
c08fb9d182 Since post format meta for images now takes an attachment ID only, make sure we label it appropriately and don't do things like esc_url() the value. fixes #23900.
git-svn-id: http://core.svn.wordpress.org/trunk@23874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-29 20:56:18 +00:00
Mark Jaquith
fec4b66f5b Sanity checks on image metadata to avoid warnings, etc.
fixes #23733. props wonderboymusic.

git-svn-id: http://core.svn.wordpress.org/trunk@23873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-29 20:51:35 +00:00
Mark Jaquith
925e7f5bd6 Make sure the first revision is seen as coming from emptiness, so it can be restored.
props adamsilverstein. fixes #23898.

git-svn-id: http://core.svn.wordpress.org/trunk@23872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-29 20:50:09 +00:00
Mark Jaquith
8c4aeb9188 Add "Customize" as first item under Appearance menu.
fixes #21413. props ryanhellyer, obenland, DrewAPicture

git-svn-id: http://core.svn.wordpress.org/trunk@23871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-29 20:39:54 +00:00
Mark Jaquith
1127ad37a8 Use the revisioned post format metadata when previewing.
fixes #23539. props kovshenin.

git-svn-id: http://core.svn.wordpress.org/trunk@23862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-29 12:08:42 +00:00
Sergey Biryukov
fc26b5e683 Remove duplicate array keys. props kovshenin. see #19570.
git-svn-id: http://core.svn.wordpress.org/trunk@23861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-29 11:07:09 +00:00
Mark Jaquith
fb78aa819e Use jQuery.on() properly. Add some slideUp()/slideDown() transitions to ease post format switches. see #19570
git-svn-id: http://core.svn.wordpress.org/trunk@23853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-29 07:06:21 +00:00
Mark Jaquith
c93e0231af Post Format UI.
* Icons
* Selection
* Prompt text
* Special fields
* Styling
* Sparkles

This is going to need testing, polish, and love.

see #19570. props melchoyce, helen, wonderboymusic, lessbloat, rachelbaker, aaroncampbell, DrewAPicture, ryelle.

git-svn-id: http://core.svn.wordpress.org/trunk@23843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-29 03:35:41 +00:00
Mark Jaquith
ab9b0206c8 Make sure that the ID of the right revision is not less than the ID of the left revision
see #23497

git-svn-id: http://core.svn.wordpress.org/trunk@23832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-28 02:49:55 +00:00
Mark Jaquith
6b79783e63 correct a revision/tooltip mismatch.
props adamsilverstein. see #23497

git-svn-id: http://core.svn.wordpress.org/trunk@23831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-28 01:51:12 +00:00
Mark Jaquith
271030746c RTL for Nav Menu tweaks. see #23641. see #23645. props lessbloat
git-svn-id: http://core.svn.wordpress.org/trunk@23808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-27 08:53:26 +00:00
Peter Westwood
9d6988a221 Revisions: UI Update.
* Refines the UI to make it clearer and easier to use
* Introduces weighted tickmarks
* Fixes comparison bugs.

See #23497 props adamsilverstein


git-svn-id: http://core.svn.wordpress.org/trunk@23769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-21 15:54:11 +00:00
Mark Jaquith
ebdcf967a3 Show a playable audio/video preview on the Edit Attachment screen.
props wonderboymusic. fixes #23726

git-svn-id: http://core.svn.wordpress.org/trunk@23768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-21 05:17:25 +00:00
Mark Jaquith
12d3fc7999 Add functions for generating metadata for video and audio, using the
ID3 library. Also allows themes/plugins to add thumbnail support
to these media types. Think stuff like album art, movie covers, and
video freeze-frames.

props wonderboymusic. fixes #23673

git-svn-id: http://core.svn.wordpress.org/trunk@23766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-21 04:55:42 +00:00
Helen Hou-Sandí
d6fee50fd3 Lose the added column for post formats in the posts list table and add an icon before the title instead. Icons are clickable to filter the list table down to posts of that post type and format. props melchoyce for the icons. fixes #16047.
git-svn-id: http://core.svn.wordpress.org/trunk@23765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-21 03:23:39 +00:00
Andrew Ozz
667e779968 Post locks: contain focus inside the dialog when tabbing, remove outline when focus is on the text, see #23697
git-svn-id: http://core.svn.wordpress.org/trunk@23763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-21 00:57:27 +00:00
Ryan Boren
9890179bce Make the before() and after() methods in Bulk_Plugin_Upgrader_Skin and Bulk_Theme_Upgrader_Skin declarations match Bulk_Upgrader_Skin. Eliminates strict standards warning.
Props charlestonsw
fixes #23807


git-svn-id: http://core.svn.wordpress.org/trunk@23749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-19 03:24:51 +00:00
Ryan Boren
dfd8479246 Fix i18n for revision diff strings displaying human time.
Props johnbillion
fixes #23723


git-svn-id: http://core.svn.wordpress.org/trunk@23743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-18 17:58:30 +00:00
Ryan Boren
830c802c90 Don't allow changing the post format from quick edit and bulk edit. These do not have sufficient context to set the post format.
Props kovshenin
fixes #23426


git-svn-id: http://core.svn.wordpress.org/trunk@23742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-18 17:24:24 +00:00
Ryan Boren
469d1a3099 Escape form action urls with esc_url() rather than esc_attr().
Props SergeyBiryukov
fixes #23266


git-svn-id: http://core.svn.wordpress.org/trunk@23739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-18 14:01:25 +00:00
Andrew Ozz
30ad180d6a Create one autosave per user rather than a single autosave for all users. Remove unused code from autosave.js and wp_ajax_autosave(). See #23665.
git-svn-id: http://core.svn.wordpress.org/trunk@23735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-16 21:15:43 +00:00
Andrew Ozz
10f565cd6c Post locks: when a dialog is shown move focus to the text, see #23697
git-svn-id: http://core.svn.wordpress.org/trunk@23733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-16 20:46:37 +00:00
Mark Jaquith
53d12e91bc Introduce [audio] and [video] shortcodes, and use MediaElement.js to play them.
props wonderboymusic. see #23282.

git-svn-id: http://core.svn.wordpress.org/trunk@23729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-16 05:25:44 +00:00
Mark Jaquith
9bd740f616 Accessibility revamp for nav menus.
props lessbloat. fixes #14045

git-svn-id: http://core.svn.wordpress.org/trunk@23727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-16 04:47:19 +00:00
Andrew Ozz
99488cb638 Post locks: add Preview button when post is locked, fix the suggested places, see #23312
git-svn-id: http://core.svn.wordpress.org/trunk@23725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-15 21:09:20 +00:00
Sergey Biryukov
63dfa74c9f Remove unused variables. props GaryJ. fixes #23789.
git-svn-id: http://core.svn.wordpress.org/trunk@23712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-15 17:08:04 +00:00
Sergey Biryukov
099c3c6422 Remove unused variable. props DrewAPicture. fixes #23782.
git-svn-id: http://core.svn.wordpress.org/trunk@23710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-15 16:23:36 +00:00
Mark Jaquith
83bb916b81 Turn the Nav Menu meta boxes into an accordion. Less sprawling and overwhelming.
* Registration stays the same — they're meta boxes
* Call `do_accordion_sections()` instead of `do_meta_boxes()` and they render as an accordion

props DrewAPicture, lessbloat, jkudish. fixes #23450. see #23449

git-svn-id: http://core.svn.wordpress.org/trunk@23707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-15 13:16:38 +00:00
Andrew Ozz
21c2d8662c Logged out warnings: remove the logged out warning from autosave when in login_grace_period, see #23295
git-svn-id: http://core.svn.wordpress.org/trunk@23699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-14 21:31:02 +00:00
Andrew Ozz
d46102d258 Logged out warnings, heartbeat: remove nopriv_autosave as it doubles the functionality of the logged out warnings, move wp_ajax_nopriv_heartbeat() under No-privilege Ajax handlers in ajax-actions.php, see #23295, see #23216
git-svn-id: http://core.svn.wordpress.org/trunk@23692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-13 23:54:12 +00:00
Andrew Ozz
e9245269a7 Autosave to the browser's sessionStorage, compare this autosave to the post content on page load and let the user restore it when the data is not the same. First run, see #23220
git-svn-id: http://core.svn.wordpress.org/trunk@23683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-13 10:08:16 +00:00
Andrew Ozz
3b4b058275 Post locks on the posts list screen: new icons for the lock, props empireoflight, show avatar for the user currently editing, props dh-shredder, see #23312
git-svn-id: http://core.svn.wordpress.org/trunk@23681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-13 00:28:07 +00:00
Sergey Biryukov
28248c1b08 Make get_home_path() return consistent slashes. fixes #23175.
git-svn-id: http://core.svn.wordpress.org/trunk@23669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-12 11:04:14 +00:00
Sergey Biryukov
f86b1502a0 Fix fatal error in WP_User_Query when searching users by URL. Move wp_is_large_network() to wp-includes. fixes #23683 for trunk.
git-svn-id: http://core.svn.wordpress.org/trunk@23664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-12 09:19:55 +00:00
Sergey Biryukov
f29bb91f05 Fix missing i18n in auto-draft titles. fixes #23565.
git-svn-id: http://core.svn.wordpress.org/trunk@23663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-12 08:57:27 +00:00
Andrew Ozz
edb9333d40 Check post locks with heartbeat and display modal notifications when a post is locked or a user takes over editing, props dh-shredder, see #23697
git-svn-id: http://core.svn.wordpress.org/trunk@23661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-12 03:22:30 +00:00
Sergey Biryukov
539ad97c8b Replace deprecated WP_Screen::is_network property with WP_Screen::in_admin( 'network' ). props bpetty. fixes #23215.
git-svn-id: http://core.svn.wordpress.org/trunk@23658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-09 03:52:27 +00:00
Peter Westwood
51db623107 Revisions: Updates to the new Revisions UI.
Various Updates including:
 * i18n fixes
 * Added tracking of what revision ID was restored
 * async fetching of diffs so that slider works sooner even with many revisions

See #23497 props adamsilverstein, ethitter


git-svn-id: http://core.svn.wordpress.org/trunk@23639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-07 15:32:26 +00:00
Sergey Biryukov
831afad92c When adding a new user in the admin, strip slashes from the password sent to the user by email. props hakre for initial patch. fixes #17018.
git-svn-id: http://core.svn.wordpress.org/trunk@23634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-07 06:00:16 +00:00
Sergey Biryukov
caf591b7aa Declare the variable before using it. props danielbachhuber. fixes #23710.
git-svn-id: http://core.svn.wordpress.org/trunk@23632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-07 04:46:19 +00:00
Ryan Boren
da7db424de Call them network upgrades rather than network updates to better indicate that they are DB upgrades rather than code/file upgrades.
Improve the contextual help for the Network Upgrade screen.

Props DrewAPicture
fixes #23540


git-svn-id: http://core.svn.wordpress.org/trunk@23619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-05 17:02:31 +00:00
Helen Hou-Sandí
fffc2e1ab1 Prevent an unseemly gap on the edit screen when nothing else displays before normal meta boxes. Give better HTML and visual structure to items added via edit_form_after_title and edit_form_after_editor. Using a class of .edit-form-section will now get you a 20px bottom margin; perfect for your additions to the post edit screen. fixes #23240.
git-svn-id: http://core.svn.wordpress.org/trunk@23615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-04 23:22:17 +00:00
Sergey Biryukov
581975e9bf Add description for wp_dashboard_rss_output(). props aaronholbrook for initial patch. fixes #23301.
git-svn-id: http://core.svn.wordpress.org/trunk@23606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-04 04:34:39 +00:00
Sergey Biryukov
f288da4b7b Use correct variable. see [23575]. see #21767.
git-svn-id: http://core.svn.wordpress.org/trunk@23584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-02 21:10:12 +00:00
Andrew Nacin
7b47322e22 Ensure the referer functions operate completely on unslashed data: wp_referer_field(), wp_original_referer_field(), wp_get_referer(), wp_get_original_referer().
Use wp_slash() instead of addslashes().

see #21767.



git-svn-id: http://core.svn.wordpress.org/trunk@23578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 17:58:43 +00:00
Andrew Nacin
76c03073d9 Remove an unslash in the deprecated WP_User_Search, as search_term is already unslashed in the constructor. see #21767.
git-svn-id: http://core.svn.wordpress.org/trunk@23577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 17:57:49 +00:00
Andrew Nacin
237f810852 Unslash early, directly on the superglobal. see #21767.
git-svn-id: http://core.svn.wordpress.org/trunk@23576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 17:57:08 +00:00
Andrew Nacin
4e06d41b9f Assume that url_shorten() receives unslashed data, as it does in core usage. see #21767.
git-svn-id: http://core.svn.wordpress.org/trunk@23575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 17:56:31 +00:00
Ryan Boren
f3a83744e9 Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
git-svn-id: http://core.svn.wordpress.org/trunk@23567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 17:14:09 +00:00
Ryan Boren
68b11a7c8f Use prepare instead of escape.
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 17:01:01 +00:00
Ryan Boren
5f809d1d22 Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 17:00:25 +00:00
Sergey Biryukov
4aca3c1e89 Consistently apply 'preview_post_link' filter. fixes #19378.
git-svn-id: http://core.svn.wordpress.org/trunk@23560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 16:46:25 +00:00
Ryan Boren
43a7e695e9 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
git-svn-id: http://core.svn.wordpress.org/trunk@23554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 16:28:40 +00:00
Sergey Biryukov
0bb47182a4 Remove redundant esc_url() call. props pauldewouters. fixes #23643.
git-svn-id: http://core.svn.wordpress.org/trunk@23553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 16:27:03 +00:00
Andrew Nacin
401e88e387 Ignore protected meta keys in meta_form(). see #18786.
git-svn-id: http://core.svn.wordpress.org/trunk@23534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-28 19:51:29 +00:00
Andrew Nacin
afd9cbced9 Make Twenty Thirteen the default theme.
Has the added benefit of ensuring the WordPress Beta Tester plugin allows updates of Twenty Thirteen.

props JustinSainton.
fixes #23573.



git-svn-id: http://core.svn.wordpress.org/trunk@23529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-28 19:01:07 +00:00
Peter Westwood
5c533c9b27 Revisions: Fix up some half renamed variables that break the view and display a mismash of split and combined views. See #23497 props adamsilverstein.
git-svn-id: http://core.svn.wordpress.org/trunk@23509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-28 16:48:33 +00:00
Peter Westwood
5133b4990b Revisions: Fix up some bugs I introduced while reviewing the mega revisions patch - when comparing two historical revisions only one half of the diff would load
See #23497 props adamsilverstein.


git-svn-id: http://core.svn.wordpress.org/trunk@23508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-28 16:10:45 +00:00
Peter Westwood
9bd192fab3 Revisions: First pass an implementing a new UI/UX for reviewing the revisions of posts. See #23497 props adamsilverstein for the initial patch.
This implements a new revisions ui using Backbone and preserves all the old methods of "integration" so the change should be transparent to plugins using revisi
ons with CPTs.

This is the first pass and so there are a number of things still to be resolved, more details in the ticket. Feedback welcomed.


git-svn-id: http://core.svn.wordpress.org/trunk@23506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-28 15:14:34 +00:00
Sergey Biryukov
ccd6e6aeec Don't override filtered screen options on Widgets screen. props bradyvercher. fixes #23239.
git-svn-id: http://core.svn.wordpress.org/trunk@23503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-28 07:40:11 +00:00
Andrew Ozz
9a827a485e Post locks: use heartbeat to dynamically update locked posts on the Posts screen, first run, see #23312
git-svn-id: http://core.svn.wordpress.org/trunk@23487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-25 23:17:10 +00:00
Sergey Biryukov
5777e5a949 Rename 'no_tagcloud' taxonomy label to 'not_found', for consistency with the post type label of the same key. fixes #23597.
git-svn-id: http://core.svn.wordpress.org/trunk@23484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-25 19:39:38 +00:00
Sergey Biryukov
bf1ca6b9ca Move 'no_tagcloud' argument to the taxonomy labels object. props DrewAPicture for initial patch. fixes #23597.
git-svn-id: http://core.svn.wordpress.org/trunk@23483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-25 18:35:05 +00:00
Andrew Ozz
9c2ebc4c60 Heartbeat API: add nopriv actions, add JS 'heartbeat-send' event, see #23216
git-svn-id: http://core.svn.wordpress.org/trunk@23481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-25 02:32:22 +00:00
Sergey Biryukov
b5c34dc411 Fix typo in phpdoc. see #17515.
git-svn-id: http://core.svn.wordpress.org/trunk@23457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-19 23:40:03 +00:00
Helen Hou-Sandí
ad85d07189 Edit screen UI for post formats: a first run for functionality.
* Adds a very basic tabbed interface for selecting a post format (requires JS).
* Extra fields, which are post meta, are shown/hidden based on the selected format.
* Introduce a helper function for retrieving formats-specific metadata: `get_post_format_meta()`.
* Image selection uses the media modal, although without filtering or from URL support at the moment.

props rachelbaker, wonderboymusic, aaroncampbell, helen. see #19570.


git-svn-id: http://core.svn.wordpress.org/trunk@23449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-18 19:11:24 +00:00
Andrew Nacin
83e0ce2ac1 Remove unused variables reset by wp_reset_vars(). Many of these haven't been used since b2. see #21767.
git-svn-id: http://core.svn.wordpress.org/trunk@23445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-16 18:28:41 +00:00
Mark Jaquith
52c46736df Improve the UX of the Nav Menus screen. Kill the tabs, and change to a
dropdown, unless you have zero or one menus (which is the most common),
in which case you jump right into editing your sole menu.

Do assignment to location using checkboxes in the main menu editing
section instead of the backwards menu => location assignment in a
random meta box.

More to come, but this gets us started.

props lessbloat, DrewAPicture, jkudish. see #23119

git-svn-id: http://core.svn.wordpress.org/trunk@23441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-16 04:53:59 +00:00
Sergey Biryukov
bc2ff9d342 Deprecate wp_convert_bytes_to_hr() in favor of size_format(). props F J Kaiser. fixes #19067.
git-svn-id: http://core.svn.wordpress.org/trunk@23439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-16 03:07:56 +00:00
Sergey Biryukov
6bcd1665eb Add missing inline descriptions. see #19067.
git-svn-id: http://core.svn.wordpress.org/trunk@23437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-16 02:52:57 +00:00
Sergey Biryukov
34862544fe Correct return value for comment_exists(). fixes #20494.
git-svn-id: http://core.svn.wordpress.org/trunk@23433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-15 18:49:07 +00:00
Sergey Biryukov
2312092aad Allow filtering attachments by Author name in Media Library. props greuben. fixes #16044.
git-svn-id: http://core.svn.wordpress.org/trunk@23430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-15 17:33:28 +00:00
Mark Jaquith
d48d025403 "LGPL License" is redundant.
props wonderboymusic, jakub.tyrcha. fixes #15585

git-svn-id: http://core.svn.wordpress.org/trunk@23425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-15 16:26:46 +00:00
Ryan Boren
cc5ed3a485 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 22:51:06 +00:00
Mark Jaquith
00dbfdf89e Document the mysterious seventh parameter of add_meta_box().
props wonderboymusic, markjaquith. fixes #17515

git-svn-id: http://core.svn.wordpress.org/trunk@23397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 18:37:34 +00:00
Mark Jaquith
ddd1b94184 Link post formats in posts list table. Use a dash for standard, like we do for absence of tags. see #16047 Next: use icons, not text descriptions.
git-svn-id: http://core.svn.wordpress.org/trunk@23396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 18:34:51 +00:00
Mark Jaquith
dab5a6ef7d Fix some tabbing issues on the post editing screen. Add Media no longer skipped when going backwards from content. Save Draft no longer skipped when going forwards from content.
props adamsilverstein. fixes #23195 and #22933

git-svn-id: http://core.svn.wordpress.org/trunk@23395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 18:30:09 +00:00
Helen Hou-Sandí
1c816c795b Open external links to plugin homepages, plugin author homepages, and theme author homepages in a new window/tab. props SergeyBiryukov. fixes #20839.
git-svn-id: http://core.svn.wordpress.org/trunk@23394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 16:20:01 +00:00
Mark Jaquith
2fb915f860 Display post formats in the posts list table.
props nacin, garyc40, DrewAPicture, wonderboymusic, aaroncampbell.

fixes #16047

git-svn-id: http://core.svn.wordpress.org/trunk@23392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 16:10:05 +00:00
Andrew Ozz
6c41e93fec Heartbeat API: throttle down when the window looses focus or when the user is inactive, always send 'screen_id', change the interval settings to 'fast' (5sec), 'standard' (15sec) and 'slow' (60sec), the interval can be changed from PHP, see #23216
git-svn-id: http://core.svn.wordpress.org/trunk@23382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-03 07:03:27 +00:00
Andrew Nacin
55ba72f46e Confirm a user exists before deleting them in wp_delete_user() and wpmu_delete_user(). props scribu, fixes #23067.
git-svn-id: http://core.svn.wordpress.org/trunk@23380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 04:41:02 +00:00
Sergey Biryukov
2967871d34 Return WP_Error from wp_crop_image() if saving has failed. props macbrink. fixes #23325.
git-svn-id: http://core.svn.wordpress.org/trunk@23374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 02:01:59 +00:00
Andrew Nacin
91e3f2b866 Clean up rendering of the title column in the posts list table. Simplify branching. Use get_userdata() rather than get_user_by( 'id' ). Change string to '%s is currently editing'. see #23312.
git-svn-id: http://core.svn.wordpress.org/trunk@23372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 01:54:06 +00:00
Andrew Ozz
0674bbfa8a Posts screen: show when a post is "locked", hide the checkbox, Quick Edit and Trash links, props dh-shredder, see #23312
git-svn-id: http://core.svn.wordpress.org/trunk@23371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 01:31:06 +00:00
Andrew Ozz
98bf511b56 Heartbeat API: first run, see #23216
git-svn-id: http://core.svn.wordpress.org/trunk@23355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-29 06:15:25 +00:00
Helen Hou-Sandí
28f6c5bcf4 Remove the long-broken and questionably useful [more]/[less] toggle for hierarchical taxonomies in Quick/Bulk Edit. Nobody seems to have noticed in the nearly 3 years it's been broken. fixes #23006
git-svn-id: http://core.svn.wordpress.org/trunk@23354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-28 22:36:15 +00:00
Sergey Biryukov
72784ad6c2 Consistently use a helper function instead of directly printing the disabled attribute.
Remove an erroneous esc_attr() call.

fixes #23194.

git-svn-id: http://core.svn.wordpress.org/trunk@23352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-28 03:23:01 +00:00
Sergey Biryukov
3e917ac75f Make sure the post exists before checking its ID. fixes #23026.
git-svn-id: http://core.svn.wordpress.org/trunk@23351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-28 02:55:06 +00:00
Sergey Biryukov
3d8a1289d2 Add missing inline descriptions.
props momo360modena, aaronholbrook.
see #20494, fixes #23304.

git-svn-id: http://core.svn.wordpress.org/trunk@23350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-28 02:20:47 +00:00
Sergey Biryukov
428e9baba7 Correct return value for WP_Filesystem_Base::gethchmod(). props bananastalktome. fixes #23121.
git-svn-id: http://core.svn.wordpress.org/trunk@23349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-28 01:55:39 +00:00
Dion Hulse
33d913220b Core Update: Fix a issue which caused automatic upgrades from 2.7 to 3.5+ to fail. Pre-2.7 WP_Filesystem::wp_content_dir() returned unslashed paths. Introduced in [22227]. See #23177
git-svn-id: http://core.svn.wordpress.org/trunk@23297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-11 10:16:45 +00:00
Andrew Nacin
1fa8476425 Ensure we wp_die() at the end of an ajax action. see #23055.
git-svn-id: http://core.svn.wordpress.org/trunk@23293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-07 03:59:44 +00:00
Andrew Nacin
5d980a8e8e Whenever we have compat fields to render, send a dummy menu_order field (which was always sent in 3.4) to ensure an unchecked checkbox can still be processed by attachment_fields_to_save. fixes #22868.
git-svn-id: http://core.svn.wordpress.org/trunk@23290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-05 03:50:28 +00:00
Peter Westwood
f683fc7677 Tighten our braces. Fixes #23118 props evansolomon.
git-svn-id: http://core.svn.wordpress.org/trunk@23265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-04 10:13:51 +00:00
Dion Hulse
9f6638747d Upgrade: When upgrading from WordPress 3.5, if an empty twentytwelve theme directory exists, remove it to allow the installation of Twenty Twelve. See #22856. For trunk
git-svn-id: http://core.svn.wordpress.org/trunk@23253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-03 07:42:16 +00:00
Andrew Nacin
f0a8acc6b6 Don't stomp existing sizes inside wp_save_image().
props markoheijnen.
see #22985.
for trunk.



git-svn-id: http://core.svn.wordpress.org/trunk@23246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-03 05:23:36 +00:00
Andrew Nacin
5491a56363 Remove deleted files on upgrade, including wp-app.php and class-wp-atom-server.php.
props duck_
see #22855
for trunk



git-svn-id: http://core.svn.wordpress.org/trunk@23203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-26 20:34:30 +00:00
Helen Hou-Sandí
b1f1579604 its <=> it's in documentation, along with a rogue the, The, and looses. props trepmal. fixes #22665.
git-svn-id: http://core.svn.wordpress.org/trunk@23191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-20 15:55:32 +00:00
Dion Hulse
39a19e1d76 When copying new bundled themes & plugins, bail early if the distro doesn't include the bundled item. This prevents us from creating an empty directory in the destination when the source doesn't exist. See #22856
git-svn-id: http://core.svn.wordpress.org/trunk@23179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-15 03:09:50 +00:00
Andrew Nacin
de3a5b8694 Use 3 * HOUR_IN_SECONDS rather than 10800.
git-svn-id: http://core.svn.wordpress.org/trunk@23175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-12 07:30:28 +00:00
Andrew Nacin
cfe6e9ed09 Rip keyboard shortcuts out of the image editor help. props helenyhou. fixes #22786.
git-svn-id: http://core.svn.wordpress.org/trunk@23106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 09:21:27 +00:00
Mark Jaquith
1419b404a8 Add the ability to click "Edit" and kick out to the advanced image editor from within the Media modal. New window, with "Refresh" offered on your return. fixes #22743. props koopersmith, nacin, helenyhou.
git-svn-id: http://core.svn.wordpress.org/trunk@23095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 05:52:19 +00:00
Mark Jaquith
68524f7c6f Run the attachment_fields_to_save filter even if we don't get the fields we used to get. props nacin. fixes #22774
git-svn-id: http://core.svn.wordpress.org/trunk@23094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 05:34:17 +00:00
Andrew Nacin
08401b9e3c Fix branchhing in edit_post() where attachment_fields_to_save would only run when the alt text was sent. It should run whenever an attachment is saved. props sc0ttclark. fixes #22774.
git-svn-id: http://core.svn.wordpress.org/trunk@23088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 03:50:31 +00:00
Daryl Koopersmith
8efc323e2e Add hidden fields via attachment_fields_to_edit to the existing compat output. props nacin. fixes #22769.
git-svn-id: http://core.svn.wordpress.org/trunk@23086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 03:28:21 +00:00
Andrew Nacin
173806d7a1 Restore the Description field to the media UI in 3.5.
We tried in vain -- a noble but ultimately failed effort -- to reduce the number of fields for attachments from four (title, caption, alt, description) to one (caption for images, title otherwise). Alternative text needed to stay for accessibility reasons, of course.

Eventually title returned due to heavy plugin reliance. Description is too used by too many plugins (often times incorrectly -- the caption is more likely the proper field), hence its less-than-triumphant return today.

Version 3.5 has tried to streamline media in a number of ways. Removing fields may have been too much at once, as it forced not only a user interface change, but a paradigm change as well.

Finally, on upload we populate the description field with IPTC/EXIF captions, rather than the caption field. See #22768, this should be fixed. For now, Description stays.

This commit also restores 'Title' attribute editing to the main tab of the Edit Image dialog. The "Title" field no longer populates title attributes for <img> tags by design (for accessibility and other purposes, see #18984). So, here is a more obvious 'workaround' for the tooltip community.

Finally, this:
 * Cleans up the post.php attachment editor, including by showing a prettier form of the mime type.
 * Enables plugins to specifically hide attachment_fields_to_edit from either post.php (where you can create meta boxes) or the modal (which you may not want to clutter), for compatibility reasons.
 * Hides the 'Describe this file...' placeholder when a field is read-only in the modal.

props nacin, helenyhou.
fixes #22759.



git-svn-id: http://core.svn.wordpress.org/trunk@23083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 00:41:06 +00:00
Andrew Nacin
a13a011265 Translate the 'First Steps with WordPress' Codex link. props SergeyBiryukov, fixes #22767.
git-svn-id: http://core.svn.wordpress.org/trunk@23082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 22:51:24 +00:00
Andrew Nacin
ce11438e77 Media list table: Fix the categories column, hidden thanks to a typo. props eddiemoya, fixes #22764. see #21240, #21391.
git-svn-id: http://core.svn.wordpress.org/trunk@23081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 22:49:51 +00:00
Mark Jaquith
bc8ddb3e64 Intelligently make media fields readonly when the user cannot update or do anything with them. props koopersmith, helenyhou, nacin. fixes #22613
git-svn-id: http://core.svn.wordpress.org/trunk@23072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 10:29:24 +00:00
Andrew Nacin
40ae89369f Admin ajax: Roll back new-style error sending in set-post-thumbnail. The JS handlers know to parse an unrecognized response (like -1 or 0) as a failure. see #21776. see #22750.
git-svn-id: http://core.svn.wordpress.org/trunk@23058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 02:34:00 +00:00
Andrew Nacin
0bd02ac6bb Use correct button class hierarchy to ensure the 'Update' button is button-large. see #21598.
git-svn-id: http://core.svn.wordpress.org/trunk@23044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 22:02:25 +00:00
Ryan Boren
a200c702e0 Only show Delete in media modal if the user can delete.
Props nacin, koopersmith
fixes #22711


git-svn-id: http://core.svn.wordpress.org/trunk@23032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 18:33:51 +00:00
Ryan Boren
63662a9b7b In the QuickPress media modal, use the new post id when a post is published.
Props nacin, koopersmith
fixes #22673


git-svn-id: http://core.svn.wordpress.org/trunk@22994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 07:17:10 +00:00
Andrew Nacin
5d0933d884 Bring Featured Images back into the main media dialog.
Most users don't realize that the Featured Image meta box exists; if they do, few use it.

Restores the old meta box UI, including the admin_post_thumbnail_html filter. If a plugin is using _wp_post_thumbnail_html() in conjunction with Thickbox elsewhere, it will also magically still work.

Specific underlying changes:
 * Converts the modal view to use the view manager, which means that a call to open() will automatically call render and attach if necessary.
 * Doesn't automatically set a state in wp.media, to allow code to customize the states to be added before activation.

props koopersmith.
fixes #21776.



git-svn-id: http://core.svn.wordpress.org/trunk@22979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 02:38:10 +00:00
Andrew Nacin
27bf82201b Allow the 'Uploaded to this post' view to be sorted, saving the resulting order as menu_order.
This functionality is designed to be backwards compatible with manual querying for attachments by menu_order.

props koopersmith.
see #22607.



git-svn-id: http://core.svn.wordpress.org/trunk@22967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-02 16:06:31 +00:00
Ryan Boren
b7b54c00e9 Namespace the dashboard widget nonce to avoid collisions with plugins.
git-svn-id: http://core.svn.wordpress.org/trunk@22964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-02 00:12:43 +00:00
Andrew Nacin
cb3b72f3be Remove stray single quote in attachment_submit_meta_box(). props Yogi T. fixes #22674.
git-svn-id: http://core.svn.wordpress.org/trunk@22962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-01 18:59:16 +00:00
Ryan Boren
22bc8cc437 Properly pass WordPress uploading errors to wp.Uploader.
Props koopersmith
fixes #22655


git-svn-id: http://core.svn.wordpress.org/trunk@22954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 15:40:09 +00:00
Ryan Boren
f07c7f5163 Refine media state machine methods.
* state( id ) becomes setState( id )
* get( id ) becomes state( id )
* state() stays the same
* previous() becomes lastState()

Props koopersmith
fixes #22652


git-svn-id: http://core.svn.wordpress.org/trunk@22952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 15:19:11 +00:00
Ryan Boren
ea3e47bc08 Add a create_posts check to _wp_translate_postdata(). Move the edit_post check to the top of the function.
Props nacin
fixes #22417


git-svn-id: http://core.svn.wordpress.org/trunk@22950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 14:03:47 +00:00
Ryan Boren
d4abd95449 Scope button classes so they can be used on the frontend without interfering with theme styles.
Props helenyhou, koopersmith
fixes #22644


git-svn-id: http://core.svn.wordpress.org/trunk@22948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 13:40:59 +00:00
Andrew Nacin
24b82f2c3b Nonces for dashboard controls.
git-svn-id: http://core.svn.wordpress.org/trunk@22930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 00:01:02 +00:00
Ryan Boren
27d943786b Introduce API to add back the description field in the new media popup.
Props nacin
fixes #22642


git-svn-id: http://core.svn.wordpress.org/trunk@22929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-29 23:52:30 +00:00
Andrew Nacin
a8d599eae5 Fix disabling of the link manager on upgrade from 3.4.2 when there are no links.
In the 3.4 branch we bumped the DB version past the version used for disabling links in trunk, preventing it from running. In the future, we must avoid increasing branch DB version bumps to HEAD.

props SergeyBiryukov.
fixes #22626.



git-svn-id: http://core.svn.wordpress.org/trunk@22911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-29 00:37:30 +00:00
Andrew Nacin
346e45c56b Adjust size of the 'Clear List' list table button. Fix placement of other buttons next to bulk actions. props johnbillion, SergeyBiryukov, fixes #22621.
git-svn-id: http://core.svn.wordpress.org/trunk@22906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-28 22:20:45 +00:00
Andrew Nacin
fe3ace4f05 Feature pointers:
* Finalize the text for the media pointer. Offer it for translation.
 * Remove the favorites pointer.
fixes #22454.



git-svn-id: http://core.svn.wordpress.org/trunk@22874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 18:58:07 +00:00
Ryan Boren
cc9b248937 Always send nocache_headers() for admin-ajax.php. This prevents iOS from caching ajax calls. http://stackoverflow.com/questions/12506897/is-safari-on-ios-6-caching-ajax-results
Turn off multi selection uploads for mobile devices. Currently Plupload cannot upload multiple files in iOS Safari. Only the first file makes it to the queue. 

Empty wp on unload to work around caching in iOS Safari.

Props azaozz, miqrogroove, nacin

fixes #22552


git-svn-id: http://core.svn.wordpress.org/trunk@22872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 16:17:53 +00:00
Ryan Boren
939a47ba48 Add a delete link to the media modal.
Props merty, nacin, koopersmith
fixes #22524


git-svn-id: http://core.svn.wordpress.org/trunk@22869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 15:50:59 +00:00
Ryan Boren
11c5f2c1fc Only show the image edit button for image attachments. Props markoheijnen. fixes #22596
git-svn-id: http://core.svn.wordpress.org/trunk@22867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 15:06:02 +00:00
Ryan Boren
d4159bf041 In wp_image_editor(), use wp_image_editor_supports() to check for rotation capabilities rather than directly checking the existence of the imagerotate function.
In WP_Image_Editor_GD::test(), check for existence of imagerotate if the rotate capability is required.

Props DH-Shredder
fixes #22597


git-svn-id: http://core.svn.wordpress.org/trunk@22863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 14:36:55 +00:00
Ryan Boren
e55bebac25 Show a better message ondmins on link-manager.php, link-add.php, link.php when links are disabled.
Props nacin
fixes #22569


git-svn-id: http://core.svn.wordpress.org/trunk@22855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 00:20:27 +00:00
Ryan Boren
b7c0d84c7f In media_upload_flash_bypass(), pass the post id in the media-new.php url.
In media-new.php, use post_id from REQUEST if passed and the current user can edit the post.
Fixes adding media with the browser uploader.

Props nacin, ocean90
fixes #22572


git-svn-id: http://core.svn.wordpress.org/trunk@22853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 23:10:19 +00:00
Andrew Nacin
4e9e4bf2cf Back compat for media_buttons_context, which is not the correct filter for adding new media buttons. If you want to add additional media buttons, use the media_buttons action instead. fixes #22559.
git-svn-id: http://core.svn.wordpress.org/trunk@22848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 22:32:35 +00:00
Ryan Boren
7df6a903f5 In wp.media.editor:send, revert back to the old field names used by media_upload_form_handler() for easier back compat.
Fix notices in wp_ajax_send_attachment_to_editor().

Props nacin, azaozz, miqrogroove
fixes #22553


git-svn-id: http://core.svn.wordpress.org/trunk@22847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 22:08:50 +00:00
Ryan Boren
5b94b6b43e In media_buttons(), consult global post_ID if get_post() comes up with nothing.
Default postID to 0 in wp_enqueue_media().

Props nacin
fixes #22085


git-svn-id: http://core.svn.wordpress.org/trunk@22846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 22:03:37 +00:00
Andrew Nacin
c1e9ddd316 Don't use wp_send_json_* handlers in the upload-attachment XHR handler.
The difference is the content type: application/json (which jQuery deserializes automatically for us) and the default text/html.

jQuery correctly handles application/json requests for IE, so we can continue to use the wp_send_json_* handlers elsewhere. Plupload rolls its own requests and does not handle application/json correctly. So, keep the standard text/html content type on upload-attachment.

props koopersmith.
see #22446.



git-svn-id: http://core.svn.wordpress.org/trunk@22845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 20:12:50 +00:00
Andrew Nacin
ab5c08a120 Media: When inserting an attachment, if the item is unattached (no post_parent), attach it to the post. fixes #22085.
git-svn-id: http://core.svn.wordpress.org/trunk@22843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 16:34:42 +00:00
Ryan Boren
8dc401468e Make is_upload_space_available() available for front end page loads. Fixes fatal error when calling wp_editor() from the front end.
Props scribu, itworx
fixes #22585


git-svn-id: http://core.svn.wordpress.org/trunk@22840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 14:42:43 +00:00
Andrew Nacin
262ee531cb Only pass the current screen to the list table constructor when we have a screen to work with. This is not the case for admin-ajax requests. fixes #22570.
git-svn-id: http://core.svn.wordpress.org/trunk@22838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 03:39:29 +00:00
Andrew Nacin
450b96a773 Use correct variable in wp_ajax_save_attachment(). see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 02:50:01 +00:00
Ryan Boren
52dcf95dcd Gettext markup for a welcome screen string. Props SergeyBiryukov, xibe. fixes #22546
git-svn-id: http://core.svn.wordpress.org/trunk@22831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-23 16:42:31 +00:00
Andrew Nacin
efd9913490 Mustn't forget to hide the legacy media uploader! see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 13:23:27 +00:00
Andrew Nacin
9120cf3375 WP_Image_Editor: the last stand.
* Have wp_get_image_editor() rather than WP_Image_Editor::get_instance(). Having static factory methods would be less confusing if there weren't also static methods tied to individual editor implementations.
 * Lazy-load the WP_Image_Editor base class and editor implementations.
 * Have WP_Image_Editor_GD::supports_mime_type() actually check which types it supports.
 * Deprecate gd_edit_image_support() in favor of wp_image_editor_supports().

props DH-Shredder, scribu, markoheijnen. fixes #22356. see #6821.



git-svn-id: http://core.svn.wordpress.org/trunk@22817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 09:52:16 +00:00
Andrew Nacin
67b5e59b68 Two initial feature pointers for WordPress 3.5: plugin favorites and the media dialog. One offered for translation. props nacin, lessbloat, DrewAPicture. see #22454.
git-svn-id: http://core.svn.wordpress.org/trunk@22815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 09:24:11 +00:00
Daryl Koopersmith
0d08430cfe Media: Replace the thumbnail on post.php using a request variable instead of the referer. props ocean90. fixes #21391.
git-svn-id: http://core.svn.wordpress.org/trunk@22807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-22 03:43:16 +00:00
Dion Hulse
bcbfb232f7 Correct get_home_path() for cases where WordPress is installed in a subdirectory called /wp/, previously it would match on /wp-admin instead of /wp causing an incorrect return path. Props SergeyBiryukov. Fixes #20449
git-svn-id: http://core.svn.wordpress.org/trunk@22800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 22:39:59 +00:00
Andrew Nacin
55a6c62e76 Support attachment_fields_to_save and attachment_fields_to_edit for attachments going through post.php. see #22186. see #21391.
git-svn-id: http://core.svn.wordpress.org/trunk@22783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 18:53:00 +00:00
Peter Westwood
ecbbb81587 Posting: Improve the capability checking _wp_translate_postdata() when updating posts.
* Use the specific post_type's 'edit_post' cap
* Pass the ID of the post being edited.

Fixes #22417


git-svn-id: http://core.svn.wordpress.org/trunk@22769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 16:34:57 +00:00
Daryl Koopersmith
bfc8690006 Media: Backwards compatibility for the many send_to_editor filters. props nacin. see #22186, #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 16:02:20 +00:00
Andrew Nacin
9b54e5c380 Have the media modal direct users to media-new.php for the browser uploader. fixes #22444.
git-svn-id: http://core.svn.wordpress.org/trunk@22765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 15:30:48 +00:00
Andrew Nacin
229a919b27 media-new.php: Remove unused scripts, strings, error handling, save handling, and save button. fixes #22083.
git-svn-id: http://core.svn.wordpress.org/trunk@22764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 15:10:17 +00:00
Andrew Nacin
75c464671d Revert accidental changes to admin/includes/media.php in [22755]. see #22083.
git-svn-id: http://core.svn.wordpress.org/trunk@22759 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 14:04:24 +00:00
Andrew Nacin
1935e74233 Properly nest the if tag. props helenyhou. see #21391.
git-svn-id: http://core.svn.wordpress.org/trunk@22757 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 13:32:26 +00:00
Andrew Nacin
e276fc44be Have media-new.php return simple rows of basic attachment data, with an 'Edit' link next to each taking them to post.php (in a new window). Not ideal, but this is largely a fallback screen at this point.
This is bolted on to existing code, the vast majority of which is destined to be ripped out in 3.6 once things settle.

see #22083.



git-svn-id: http://core.svn.wordpress.org/trunk@22755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 13:05:44 +00:00
Andrew Nacin
96576a2dca Properly refresh the thumbnail on post.php after an image edit. props ocean90. see #21391.
git-svn-id: http://core.svn.wordpress.org/trunk@22749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 12:05:24 +00:00
Andrew Nacin
9ad10730c0 Non-images don't have alternative text. props helenyhou. see #21391.
git-svn-id: http://core.svn.wordpress.org/trunk@22748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 12:03:35 +00:00
Andrew Nacin
8f3a9e1907 Stop inserting title attributes for images inserted into the editor by modifying get_image_send_to_editor(), not the generic get_image_tag().
see #18984, [22409].



git-svn-id: http://core.svn.wordpress.org/trunk@22747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 11:50:30 +00:00
Daryl Koopersmith
ff482e86fb Media: Add filters for image-only libraries. see #22514, #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 11:04:23 +00:00
Daryl Koopersmith
5b11aea8f5 Media: Dynamically generate attachment filters using get_post_mime_types().
Moves `get_post_mime_types()` from `wp-admin/includes/post.php` to `wp-includes/post.php`.

fixes #22514, see #21390.


git-svn-id: http://core.svn.wordpress.org/trunk@22743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 10:18:59 +00:00
Andrew Nacin
3da5e3a7fc Fix up the 'Attach' dialog on upload.php.
We are de-emphasising attaching (see [22630]) but this is existing
core functionality and will remain for now. This commit just cleans
it up a bit so as to be less embarrassing.

props lessbloat, helenyhou.
fixes #20164.



git-svn-id: http://core.svn.wordpress.org/trunk@22723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 18:50:15 +00:00
Daryl Koopersmith
b75ec467b2 Media: Whoops. Remove error_log. see [22699], #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 02:40:31 +00:00
Daryl Koopersmith
b1f720c616 Media: Improve media buttons on the front end.
* Use a less specific selector (the body, actually) to delegate opening the media dialog.
* Allow the editor ID to be the empty string so the `media_buttons` action can be called without arguments.

see #22284, #21390.


git-svn-id: http://core.svn.wordpress.org/trunk@22699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-20 02:35:30 +00:00
Andrew Nacin
c185f0c9bd Use correct variable. see #17860.
git-svn-id: http://core.svn.wordpress.org/trunk@22689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 21:43:47 +00:00
Andrew Nacin
d88922565e Less insane multiple role handling in the users list table.
If the user has more than one role, opt to show the first role that is
'editable', if present. Otherwise, fall back to the remaining roles.

In the future, we should show a comma-separated list of all roles,
editable or otherwise, and this list should be filterable, either by user,
or by the roles which can appear. Probably both.

In multisite, only hide users that have no capabilities (in case they
possess a leftover, empty wp_xx_capabilities key from the MU days),
not users that have no role, as they may have a cap but no role.

see #22361. fixes #17860.



git-svn-id: http://core.svn.wordpress.org/trunk@22686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 19:16:31 +00:00
Andrew Nacin
4b9ef4ee05 Remove errant return. props SergeyBiryukov. see #22186.
git-svn-id: http://core.svn.wordpress.org/trunk@22679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 09:48:34 +00:00
Andrew Nacin
bd158c503f Move code from image_attachment_fields_to_edit() to get_attachment_fields_to_edit(). The level of abstraction is unnecessary, and it makes it more difficult to call only the filter in the new media modal. Also, that function is sloooow. see #22186.
git-svn-id: http://core.svn.wordpress.org/trunk@22673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 08:10:38 +00:00
Andrew Nacin
479d27013a Avoid doing all of the extra work in get_attachment_fields_to_edit() for fields we will just discard. We just need the filter, and the taxonomies. see #22186.
git-svn-id: http://core.svn.wordpress.org/trunk@22670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 07:20:47 +00:00
Daryl Koopersmith
bda3b4c53d Media: Properly display selected featured image data if the featured image is not in the first section of the library. see #22494, #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 06:56:54 +00:00
Andrew Nacin
97032e08aa Revert page on front changes. Reverts [22127] [22129] [22135] [22136]. see #16379.
git-svn-id: http://core.svn.wordpress.org/trunk@22653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 01:28:32 +00:00
Andrew Ozz
c4fd7d119b Welcome screen: clean up the css, improve the html, add RTL styles, props helenyhou TobiasBg ocean90, fixes #21368, see #22453
git-svn-id: http://core.svn.wordpress.org/trunk@22638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 21:51:39 +00:00
Andrew Nacin
dc0786c0ae Pull the list of popular importers from WordPress.org.
These are the importers we suggest on import.php, prompting the user to
install the relevant plugin for the import they want to go through.

If the API is inaccessible, it falls back to a hard-coded list that should
be kept sync'd with the API with each major version of WordPress. This API
enables us to add new importers between releases, as they are completed or
if services gain quick adoption. As a last resort, we can also temporarily
disable importers that are broken (due to API changes, for example).

The importer currently returns English strings (which are then run through
translate() for existing strings), but the locale is passed to the API,
allowing us to ship translated strings if we wish to be adventurous.

props dllh for the assist.
fixes #18977.



git-svn-id: http://core.svn.wordpress.org/trunk@22632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 07:20:04 +00:00
Andrew Nacin
c5f94e316e Media Library list table: Rename 'Attached to' to 'Uploaded to'.
In 3.5, we have chosen to de-emphasize the "attaching" part of the
post-attachment relationship. Existing functionality remains the same,
but UI emphasis is now placed on "parent" being where the item was
originally uploaded.

fixes #22439.



git-svn-id: http://core.svn.wordpress.org/trunk@22630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 06:56:05 +00:00
Andrew Nacin
0a888e8aa0 Prevent notices when post_id is not passed to the old media upload forms. props ldebrouwer. fixes #22465.
git-svn-id: http://core.svn.wordpress.org/trunk@22628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 06:42:14 +00:00
Ryan Boren
33ac1bd021 Show the update nag in the network admin.
Props Mamaduka
fixes #20959


git-svn-id: http://core.svn.wordpress.org/trunk@22618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-16 21:52:48 +00:00
Andrew Nacin
f68b6006de wp_generate_attachment_metadata() should not call WP_Image_Editor if there's nothing to resize. props mdawaffe. fixes #22438.
git-svn-id: http://core.svn.wordpress.org/trunk@22571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-14 14:26:52 +00:00
Daryl Koopersmith
fd6b847330 Media: Make edit gallery button use new media. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-14 09:06:10 +00:00
Daryl Koopersmith
5ed166d269 Media: Activate the featured image toolbar when the media dialog is first opened. see #21390, #21776.
git-svn-id: http://core.svn.wordpress.org/trunk@22561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-14 02:39:54 +00:00
Ryan Boren
02d80201fa In wp_crop_image(), preserve both src_file and src. src_file must be preserved even when url fopen is used so that we don't try to save to a filename based on the url.
see #6821


git-svn-id: http://core.svn.wordpress.org/trunk@22553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-13 00:03:55 +00:00
Daryl Koopersmith
2d87f983ad Media: Add Embed from URL tab.
Note: There is a bug that currently blocks adding several successive embeds.

see #21390.


git-svn-id: http://core.svn.wordpress.org/trunk@22547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-12 05:57:12 +00:00
Daryl Koopersmith
82213846c3 Media: Add backwards compatibility for attachment_fields_to_edit and attachment_fields_to_save. see #22186.
git-svn-id: http://core.svn.wordpress.org/trunk@22541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-11 01:26:42 +00:00
Ryan Boren
31e669df5a Pass an attachment ID, not a file path, to _load_image_to_edit_path() from wp_crop_image(). This fixes handling of attachments that require url fopen to access the image.
Allow passing urls instead of just file paths to WP_Image_Editor_Imagick::load() and WP_Image_Editor_GD::load() so that attachments requiring URL fopen can be handled.

see #6821


git-svn-id: http://core.svn.wordpress.org/trunk@22538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 20:42:27 +00:00
Daryl Koopersmith
30e0a600bf Media: Add title, caption, and alt text, and attachment info to sidebar.
* Improve sidebar styles.
* Separate the hybrid title/caption field.
* Improve the sidebar image thumbnail.
* Remove filenames from inside the non-image icon thumbnail.
* Properly sync title/caption/alt.

see #21390.


git-svn-id: http://core.svn.wordpress.org/trunk@22532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 18:25:04 +00:00
Daryl Koopersmith
ead998c57d Media: Keep the selected featured image in the media modal in sync with the page. fixes #22404, see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 08:40:35 +00:00
Daryl Koopersmith
bed08350f4 Media: Backwards compatibility for media_upload_tabs.
* Adds `createIframeStates()` to the `MediaFrame` view. It creates states and bindings for the `media_upload_tabs` output, and is included on `MediaFrame.Post` by default.
* Hijacks `tb_remove()` when the media modal is open to ensure the modal closes correctly.
* Adds a `chromeless` parameter to thickbox media tab URLs to render the UI without the old row of tabs.

see #22186, #21390.


git-svn-id: http://core.svn.wordpress.org/trunk@22523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 07:51:37 +00:00
Andrew Nacin
e14ff50cfb Don't allow non-image uploads for custom headers and backgrounds. props kovshenin. fixes #22149.
git-svn-id: http://core.svn.wordpress.org/trunk@22521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-10 05:36:37 +00:00
Ryan Boren
d3463e4aea WP_Image_Editor improvements.
* Make test() and supports_mime_type() static.
* Add required_methods argument to get_instance(). Allows requesting an implementation that has certain methods/capabilities.
* Whitespace cleanup

Props markoheijnen
see #6821


git-svn-id: http://core.svn.wordpress.org/trunk@22510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-09 19:38:54 +00:00
Daryl Koopersmith
405470d264 Media: Make "update featured image" button primary. see #21776, #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-09 11:28:43 +00:00
Peter Westwood
06830f4501 Multisite: When displaying the upload quota and space used in the dashboard widget format them nicely.
git-svn-id: http://core.svn.wordpress.org/trunk@22498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-09 10:47:43 +00:00
Peter Westwood
b2ca616d1e Multisite: Move all the functions which calculate upload space usage to wp-includes so they apply correctly with front-end editors.
Fixes #22357 props wonderboymusic.


git-svn-id: http://core.svn.wordpress.org/trunk@22497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-09 10:35:42 +00:00
Daryl Koopersmith
87caf47c0f Media: Update featured images to use the media frame. fixes #21776, see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-09 10:13:39 +00:00
Daryl Koopersmith
0a67c025e5 Media: Add wp_enqueue_media to easily include all media dependencies.
Also, media templates now print on `wp_footer`.

props sushkov. fixes #22060, see #21390.


git-svn-id: http://core.svn.wordpress.org/trunk@22489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-09 04:57:25 +00:00
Andrew Nacin
9d7cb4ac7a Translate. see #19956.
git-svn-id: http://core.svn.wordpress.org/trunk@22486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-09 04:40:56 +00:00
Daryl Koopersmith
0a5cdbb838 Media: Rename the "Beta Media" button to "Add Media". fixes #19956, see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-09 04:35:38 +00:00
Andrew Nacin
b9b9ebeeae Forms with the class .wp-upload-form will now have their submit button disabled until a file is selected. props kovshenin, helenyhou, lessbloat, SergeyBiryukov, tommcfarlin. fixes #20855.
git-svn-id: http://core.svn.wordpress.org/trunk@22459 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 23:54:03 +00:00
Andrew Nacin
c26f579b13 Put the label outside the span to ensure margins when the text wraps. props waclawjacek. fixes #19254.
git-svn-id: http://core.svn.wordpress.org/trunk@22444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 21:41:31 +00:00
Andrew Ozz
1276bcefb5 More retina backgrounds and bits, props saracannon, empireoflight and lessbloat, see #21019
git-svn-id: http://core.svn.wordpress.org/trunk@22439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 20:54:08 +00:00
Andrew Nacin
039279db28 Only call wp_get_object_terms() if get_object_term_cache() says there is no cache (false), which is different than no terms. props wonderboymusic, fixes #16505.
git-svn-id: http://core.svn.wordpress.org/trunk@22433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 20:00:51 +00:00
Andrew Nacin
69d63c243d Fix the 'Change' button in the users list table. props c3mdigital. fixes #22034.
git-svn-id: http://core.svn.wordpress.org/trunk@22423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 18:34:46 +00:00
Andrew Nacin
a5c0829f35 Remove the post-format-standard term on upgrade if it exists in the database. fixes #20697.
git-svn-id: http://core.svn.wordpress.org/trunk@22422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 18:01:31 +00:00
Andrew Nacin
dd50d7d0e0 restrict_manage_users action. props jakemgold, johnjamesjacoby. fixes #19295.
git-svn-id: http://core.svn.wordpress.org/trunk@22414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 07:59:46 +00:00
Andrew Nacin
28777ee3c4 Always return an integer from post_exists(). props barrykooij. fixes #21607.
git-svn-id: http://core.svn.wordpress.org/trunk@22410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 23:27:21 +00:00
Andrew Nacin
224a21db80 Stop adding title attributes to images (in the old media uploader). props martythornley. fixes #18984.
git-svn-id: http://core.svn.wordpress.org/trunk@22409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 23:23:03 +00:00
Andrew Nacin
9e2d46819e Revert [22387]. see #14466. see #22374.
git-svn-id: http://core.svn.wordpress.org/trunk@22406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 22:36:24 +00:00
Andrew Ozz
cbd737470c Kill use of colons in class names, props SergeyBiryukov, fixes #21152
git-svn-id: http://core.svn.wordpress.org/trunk@22396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 01:01:52 +00:00
Andrew Nacin
c2257fcba3 Remove methods that override but do nothing. props jeremyfelt for initial patch. fixes #22368.
git-svn-id: http://core.svn.wordpress.org/trunk@22395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 00:52:49 +00:00
Andrew Nacin
9fadd65859 HiDPI versions of the generic menu page icon. props empireoflight, lessbloat. see #21019.
git-svn-id: http://core.svn.wordpress.org/trunk@22393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 00:25:18 +00:00
Andrew Nacin
bc93c0fdc5 Prefix sidebar IDs on the widgets screen with "sidebar-". props batmoo. fixes #14466.
git-svn-id: http://core.svn.wordpress.org/trunk@22387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-05 23:17:25 +00:00
Ryan Boren
6757005b59 Welcome screen refresh. Now with icons. Props lessbloat, empireoflight. fixes #21368
git-svn-id: http://core.svn.wordpress.org/trunk@22379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-05 21:12:46 +00:00
Andrew Nacin
32ad332432 Update Thickbox images for HiDPI. props lessbloat. see #21019.
git-svn-id: http://core.svn.wordpress.org/trunk@22378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-05 21:00:15 +00:00
Ryan Boren
44774b52ab Fix strict warnings for WP_Plugins_List_Table::bulk_actions() and WP_Plugins_List_Table::single_row(). Props kurtpayne. fixes #22224
git-svn-id: http://core.svn.wordpress.org/trunk@22376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-05 18:29:20 +00:00
Ryan Boren
b10f343480 Consistent escaping in admin_color_scheme_picker(). Props johnjamesjacoby. fixes #22326
git-svn-id: http://core.svn.wordpress.org/trunk@22375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-05 18:16:23 +00:00
Ryan Boren
3eabc7db5a Use esc_attr() for attributes. Props johnjamesjacoby. fixes #22327
git-svn-id: http://core.svn.wordpress.org/trunk@22373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-05 18:04:50 +00:00
Andrew Nacin
e79b028a08 When approving and then replying to a comment, approve the parent comment before inserting the reply. props trepmal, fixes #22000.
git-svn-id: http://core.svn.wordpress.org/trunk@22370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-05 16:49:10 +00:00
Ryan Boren
53c0024945 Use wp_basename() instead of basename() so that multibyte characters are not stomped. Props SergeyBiryukov. fixes #21217
git-svn-id: http://core.svn.wordpress.org/trunk@22367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-05 14:33:56 +00:00
Ryan Boren
ad724f3b7b Attachment editor improvements. Put the non-editable metadata into the submit/publish box.
Props helenyhou
see #21391


git-svn-id: http://core.svn.wordpress.org/trunk@22364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-05 14:04:22 +00:00
Daryl Koopersmith
f7c1aaf26d Add a sidebar to the media modal.
* Adds `wp.media.view.Sidebar`, to aid in rendering the sidebar.
* Removes the `directions` from the `Attachments` view and shifts search into a separate view (`wp.mce.view.Search`) that can be relocated at will. This also serves to simplify the `Attachments` view by removing the nested `list` and `$list` parameters.
* Show the toolbar on the featured image workflow, effectively requiring confirmation before closing the dialog.

see #21390, #21776, #21808.


git-svn-id: http://core.svn.wordpress.org/trunk@22321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-29 06:56:23 +00:00
Daryl Koopersmith
53ccb09bce Give media a heart transplant.
Revises the concept of the media controller and workspace views (i.e. two central points of control) to be more granular. The main media object is now the `Frame`, which is a hybrid view and state machine.

The state machine is a collection of states, which are just generic instances of `Backbone.Model`. This circumvents the problem of juggling global parameters when changing states. Each state contains its own event loop. All events are also forwarded to the frame itself (as is the case in all model/collection relationships).

The frame view contains several regions, each of which can be overridden without harming or re-rendering the other regions. These work well when used in conjunction with the state machine events.

This removes the upload sidebar (don't worry, visible upload UI will return). Drag and drop uploading still works. The ability to upload has been abstracted into its own view (instead of being attached to the central workspace view).

Editing galleries is temporarily broken — the gallery creation and editing experiences will be unified in a future patch.

Adds events to detect dragging changes in `wp.Uploader` and adds methods to detect and leverage browser support for CSS3 transitions.

see #21390, #21809.


git-svn-id: http://core.svn.wordpress.org/trunk@22320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-28 23:29:17 +00:00
Andrew Nacin
f965ff1c84 Cast image metadata focal_length and shutter_speed to strings to restore previous behavior when stripslashes_deep() converted these values. Avoids rounding errors without making a determination of which digit we should round to. props jcakec. fixes #22259.
git-svn-id: http://core.svn.wordpress.org/trunk@22319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-28 16:17:56 +00:00
Andrew Nacin
076ede55f2 Split by [\r\n\t ] rather than \s to avoid UTF-8 issues. props SergeyBiryukov. fixes #21625.
git-svn-id: http://core.svn.wordpress.org/trunk@22306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-25 21:09:42 +00:00
Andrew Nacin
fac0ce8ec7 Flush rewrite rules when page_on_front is updated. props SergeyBiryukov. fixes #21274.
git-svn-id: http://core.svn.wordpress.org/trunk@22301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-25 20:20:24 +00:00
Andrew Nacin
d08bf937de Comment that the add_users capability was never used and has its days numbered. see #16719.
git-svn-id: http://core.svn.wordpress.org/trunk@22300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-25 20:18:24 +00:00
Peter Westwood
4f2173666d i18n: Fix the usage of sprintf replacements in the Multisite admin include files. See #22260.
git-svn-id: http://core.svn.wordpress.org/trunk@22271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-23 11:28:36 +00:00
Ryan Boren
f742b675be Populate WPLANG site option when setting up a network. Props SergeyBiryukov. fixes #21726
git-svn-id: http://core.svn.wordpress.org/trunk@22257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-17 20:29:53 +00:00
Ryan Boren
1714e085e4 Don't create {$blog_id}_user-settings, {$blog_id}_user-settings-time, and {$blog_id}_dashboard_quick_press_last_post_id user options when a super admin visits a site they aren't a member of. Instead, rely solely on the wp-settings cookie.
fixes #22178


git-svn-id: http://core.svn.wordpress.org/trunk@22256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-17 18:58:09 +00:00
Ryan Boren
bcbc0b65ac Allow numbers in screen option IDs. Fixes setting posts per page for custom post types containing 0-9. Props SergeyBiryukov. fixes #18323
git-svn-id: http://core.svn.wordpress.org/trunk@22253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-17 13:09:17 +00:00
Andrew Ozz
e6fe8c83a3 Tab indexes: when tabbing out of the editors make sure the next focused element is the expected/default action, fix focusing the next field when picking a date for future post, props lessbloat, fixes #21340
git-svn-id: http://core.svn.wordpress.org/trunk@22250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-16 21:38:35 +00:00
Ryan Boren
ba79e04c10 In populate_network(), distinguish between upgrading from single to multisite and creating a new network in an existing multisite environment. When creating a new network steps related to setting up the main site must be skipped since the main site is created after populate_network() runs. Further, the global should not be modified since populating a new network does not involve switching to that network and making it current. fixes #22090
git-svn-id: http://core.svn.wordpress.org/trunk@22240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-15 21:41:29 +00:00
Andrew Nacin
26445266d4 In nav menus, avoid firing the magic WP_Post getter for potentially non-existent properties, which results in a metadata cache hit. see #22189.
git-svn-id: http://core.svn.wordpress.org/trunk@22234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-15 14:19:45 +00:00
Dion Hulse
93ad22d868 Replace the hard coded version and PHP/MySQL requirements in update-core.php by pulling in the new version.php file during installation. Fixes #22015 #11639. See #21789
git-svn-id: http://core.svn.wordpress.org/trunk@22227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-14 03:47:36 +00:00
Dion Hulse
04448de6bb When upgrading a site to/from a Beta, alpha, or non-stable release, overwrite any existing bundled themes & plugins with the version from the release zip. See #21789
git-svn-id: http://core.svn.wordpress.org/trunk@22226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-14 02:14:17 +00:00
Daryl Koopersmith
3ee553c6bc Add a nonce to wp_ajax_save_attachment. see #21390, #21807.
git-svn-id: http://core.svn.wordpress.org/trunk@22212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-12 16:02:45 +00:00
Daryl Koopersmith
b3655c12b7 Media Modal: Check for empty keys when saving attachment captions. see #21390, #21807.
git-svn-id: http://core.svn.wordpress.org/trunk@22200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-11 21:37:44 +00:00
Ryan Boren
da8d7a347a Check for WP_Error return from WP_Image_Editor::get_instance().
Props markoheijnen
see #6821


git-svn-id: http://core.svn.wordpress.org/trunk@22192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-11 18:59:41 +00:00
Andrew Nacin
6f55c9a548 Trailing slash the URL for the 'Visit' link in network/sites.php.
git-svn-id: http://core.svn.wordpress.org/trunk@22190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-11 17:48:42 +00:00
Daryl Koopersmith
1daa774b27 Caption editing in the media modal library.
* Adds a `describe` option to the workflow controller to support inline caption editing.
* For images, descriptions are mapped to the `caption` attribute.
* For other media items, descriptions are mapped to the `title` attribute.
* Descriptions are saved when the textarea's `change` event fires (i.e. when the textarea is blurred).

fixes #21807, see #21390.


git-svn-id: http://core.svn.wordpress.org/trunk@22173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-10 23:32:48 +00:00
Andrew Nacin
4d1bc9bb6d Retina/span spinner cleanup. Restores CSS classes no longer used by core. props lessbloat. fixes #21456.
git-svn-id: http://core.svn.wordpress.org/trunk@22167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-10 20:34:19 +00:00
Andrew Nacin
f27e7f051f Align QuickPress fields. props lessbloat. fixes #21754.
git-svn-id: http://core.svn.wordpress.org/trunk@22146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-09 19:07:09 +00:00
Andrew Nacin
1617e5ebdf Move the static front page saving routine to a single sanitize_option() callback for show_on_front. page_on_front and page_for_posts are now manually set by this callback, and not separately by options.php. see #16379.
git-svn-id: http://core.svn.wordpress.org/trunk@22136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-08 21:25:13 +00:00
Andrew Nacin
d8936dc1aa Pass the screen context directly to get_sample_permalink_html(). see #16379.
git-svn-id: http://core.svn.wordpress.org/trunk@22129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-07 03:44:30 +00:00
Ryan Boren
90288a07b7 Better UI for doing "Page on Front".
Props SergeyBiryukov, lessbloat, nacin.

see #16379


git-svn-id: http://core.svn.wordpress.org/trunk@22127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-06 15:19:29 +00:00
Ryan Boren
51920e1858 Consolidate some strings. Props pavelevap, SergeyBiryukov. see #21728
git-svn-id: http://core.svn.wordpress.org/trunk@22124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-05 19:04:34 +00:00
Daryl Koopersmith
1deab58658 Use the new media modal to insert galleries into TinyMCE and the text editor.
'''Galleries'''

* Gallery insertion from the new media modal (into TinyMCE, the text editor, etc).
* Gallery previews in TinyMCE now use the `wp.mce.views` API.
* Disables the TinyMCE `wpgallery` plugin.
* Gallery previews consist of the first image of the gallery and the appearance of a stack. This will later be fleshed out to include more images/functionality (including editing the gallery, gallery properties, and showing the number of images in the gallery).
* Multiple galleries can be added to a single post.
* The gallery MCE view provides a bridge between the `wp.shortcode` and `Attachments` representation of a gallery, which allows the existing collection to persist when a gallery is initially created (preventing a request to the server for the query).


'''Shortcodes'''

* Renames `wp.shortcode.Match` to `wp.shortcode` to better expose the shortcode constructor.
* The `wp.shortcode` constructor now accepts an object of options instead of a `wp.shortcode.regexp()` match.
* A `wp.shortcode` instance can be created from a `wp.shortcode.regexp()` match by calling `wp.shortcode.fromMatch( match )`.
* Adds `wp.shortcode.string()`, which takes a set of shortcode parameters and converts them into a string.* Renames `wp.shortcode.prototype.text()` to `wp.shortcode.prototype.string()`.
* Adds an additional capture group to `wp.shortcode.regexp()` that records whether or not the shortcode has a closing tag. This allows us to improve the accuracy of the syntax used when transforming a shortcode object back into a string.

'''Media Models'''

* Prevents media `Query` models from observing the central `Attachments.all` object when query args without corresponding filters are set (otherwise, queries quickly amass false positives).
* Adds `post__in`, `post__not_in`, and `post_parent` as acceptable JS attachment `Query` args.
* `Attachments.more()` always returns a `$.promise` object.

see #21390, #21809, #21812, #21815, #21817.


git-svn-id: http://core.svn.wordpress.org/trunk@22120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-05 04:23:59 +00:00
Ryan Boren
1f9d02abc6 Avoid 'Only variables should be assigned by reference' warning. Props wonderboymusic. see #21865
git-svn-id: http://core.svn.wordpress.org/trunk@22117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-04 18:37:43 +00:00
Ryan Boren
7a86de87fb Reduce use of global. Use get_blog_details() instead. fixes #22090
git-svn-id: http://core.svn.wordpress.org/trunk@22108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-04 12:40:09 +00:00
Andrew Nacin
4cbc20ada1 Pass the post date to wp_upload_dir() during sideloads, just as we do uploads. Ensures that sideloaded images make it into the right uploads directory.
props solarisssmoke, fixes #16777.



git-svn-id: http://core.svn.wordpress.org/trunk@22105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-03 18:49:37 +00:00
Daryl Koopersmith
a918ec9135 Refine button styles, notably the gray buttons.
* Crisper edges, fewer outer shadows.
* Higher contrast borders on the gray buttons.
* Separates `button-large` from `button-primary`, and removes the `regular` override class.

props hugobaeta, helenyhou, lessbloat. see #21598.


git-svn-id: http://core.svn.wordpress.org/trunk@22099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-02 23:38:21 +00:00
Ryan Boren
b4d0be2d1a Introduce WP_Image_Editor, WP_Image_Editor_Imagick, and WP_Image_Editor_GD. Abstracts image editing API and adds support for ImageMagick.
Props DH-Shredder, kurtpayne, markoheijnen
see #6821


git-svn-id: http://core.svn.wordpress.org/trunk@22094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-01 20:59:06 +00:00
Ryan Boren
82ae25da11 Respect ssl for the image src link in edit_form_image_editor(). see #21391
git-svn-id: http://core.svn.wordpress.org/trunk@22093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-01 19:51:23 +00:00
Ryan Boren
9fc9d42d0a * Register blog-id-cache group as global
* Introduce clean_blog_cache() so we can run it independently of refresh_blog_details() which assumes the blog still exists and get_blog_details() can be called.
* Don't db escape cache keys in get_blog_id_from_url()
* prepare() the query in get_blog_id_from_url()
* Return 0 for all failures in get_blog_id_from_url()
* clean_blog_cache() after dropping tables in wpmu_delete_blog() to make sure the cache is for real cleaned.



git-svn-id: http://core.svn.wordpress.org/trunk@22092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-01 18:03:23 +00:00
Ryan Boren
21d38d35d4 Initialize to avoid notice. Props bradyvercher. fixes #22050
git-svn-id: http://core.svn.wordpress.org/trunk@22091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-01 16:09:16 +00:00
Andrew Nacin
b0e29340e1 Provide no-customize fallback to the welcome screen. Use the customize overlay rather than a page reload. see #21368.
git-svn-id: http://core.svn.wordpress.org/trunk@22089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-01 14:58:05 +00:00
Ryan Boren
a820d7481b Handle screen arg in WP_Comments_List_Table constructor. Avoids warning when calling WP_Screen::get() later. fixes #22039
git-svn-id: http://core.svn.wordpress.org/trunk@22085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-29 10:05:15 +00:00
Dion Hulse
298b6b269f Make WP_Filesystem_Base::getnumchmodfromh() return the expected values when the executable bit is set in the input. Props Keruspe. Fixes #20365
git-svn-id: http://core.svn.wordpress.org/trunk@22083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-29 01:33:15 +00:00
Andrew Nacin
b821458a03 Map 'all' to no status for get_comments() in the list table. See #21101.
git-svn-id: http://core.svn.wordpress.org/trunk@22081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-28 21:46:24 +00:00
Andrew Ozz
d62abf57d6 Fix "add media" icon in DFW for IE < 9, restore media-button.png, add media-button-2x.png and make them background images, see #21019
git-svn-id: http://core.svn.wordpress.org/trunk@22077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-28 00:33:40 +00:00
Daryl Koopersmith
eb54ac6373 Move wp_max_upload_size and dependencies to wp-includes. props johnjamesjacoby. see #21390, fixes #21867.
git-svn-id: http://core.svn.wordpress.org/trunk@22073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-27 20:59:57 +00:00
Daryl Koopersmith
0c42e6121a Add QuickPress support for new media workflow.
* Adds the code required to include the new media scripts, styles, and settings to `media_button()`.
* Improves script dependencies, namely making `media-upload` require `media-views`.
* Some CSS tweaks for the making the new button work well with QuickPress.

see #21390, fixes #22021.


git-svn-id: http://core.svn.wordpress.org/trunk@22072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-27 20:04:34 +00:00
Andrew Nacin
582d46c937 Make Twenty Twelve the default theme for new installs. props markoheijnen, SergeyBiryukov. see #21789.
git-svn-id: http://core.svn.wordpress.org/trunk@22054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-27 07:47:51 +00:00
Daryl Koopersmith
a9d3197c28 Media JS: Move the modal box's title from being stored in the modal view to being stored as an attribute on the workflow. Update modal titles for both the post media and featured image workflows. see #21390, #21776.
git-svn-id: http://core.svn.wordpress.org/trunk@22044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-27 06:20:22 +00:00
Andrew Nacin
2cdd7b7840 Don't give a 'Beta Media' string to the translators that is only temporary.
git-svn-id: http://core.svn.wordpress.org/trunk@22039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-27 05:19:34 +00:00
Daryl Koopersmith
eec758fd26 BUTTON.
Add a "Beta Media" button to the post editor. Currently, it is only capable of inserting images. Other attachment types and galleries need not apply... yet.

* Added `wp.media.string.image( attachment, props )` for generating an image as a string from an attachment and relevant attachment display properties.
* Properly localized the gallery workflow.
* Added `Workflow.update()`, which closes the modal, triggers an `update` event, and resets the selection.
* Added `wp.mce.media` to manage the various media workflows for editors.

see #21813, #21814, #21390.


git-svn-id: http://core.svn.wordpress.org/trunk@22036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-27 04:09:43 +00:00
Andrew Nacin
fc5fb63599 Browse and install your wordpress.org plugin favorites from the plugin installer. props Otto42, Japh, DrewAPicture. fixes #22002.
git-svn-id: http://core.svn.wordpress.org/trunk@22026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-27 00:47:01 +00:00
Daryl Koopersmith
9e7a77aeda Limit the featured image workflow to images only.
Adds the ability to set the values used to instantiate both the Workflow's library and selection.
Renames the Workflows internal `_pending` variable to prevent conflicts with a similarly named internal `Backbone.Model` variable.

see #21390, #21776.


git-svn-id: http://core.svn.wordpress.org/trunk@22022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-26 21:40:02 +00:00
Daryl Koopersmith
9e51aebdd7 Media JS: Add support for filtering Attachment collections by mime type. see #21390, #21776, #21809.
git-svn-id: http://core.svn.wordpress.org/trunk@22021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-26 20:50:13 +00:00
Andrew Nacin
1acd8b556f New HiDPI spinner. Uses clean <span class="spinner"></span> markup.
Be on the lookout for weirdness.
props lessbloat. see #21456.



git-svn-id: http://core.svn.wordpress.org/trunk@22019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-26 19:57:44 +00:00
Andrew Nacin
51ad055a68 New design and content for the welcome panel. First pass.
props lessbloat, helenyhou, georgestephanis, sabreuse, ryelle.
see #21368.



git-svn-id: http://core.svn.wordpress.org/trunk@22018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-26 19:44:43 +00:00
Dion Hulse
a41af6219a Move win_is_writable() from wp-admin/includes to wp-includes so that it's always available for get_temp_dir(). Fixes #20778
git-svn-id: http://core.svn.wordpress.org/trunk@22009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-26 05:08:26 +00:00
Andrew Nacin
1009245fa1 Remove the 'Size of the post box' (default_post_edit_rows) option. This will instead be handled by a user cookie tracking the resizing of both TinyMCE and the main textarea. see #21718.
git-svn-id: http://core.svn.wordpress.org/trunk@22006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-26 03:17:28 +00:00
Andrew Nacin
a6c93e2f65 Always attempt to embed URLs in content, removing the Auto-embeds (autoembed_urls) option.
Remove the UI for setting the default width and height for embeds. Width was confusing as it
was blank by default (inheriting the content width from the theme, or 500px). The height is
now calculated as 1.5x the content width, or 1000px, whichever is smaller.

The [embed] shortcode can still receive manual height and width attributes. This just removes
the global settings.

props wonderboymusic. see #21719.



git-svn-id: http://core.svn.wordpress.org/trunk@21998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-25 07:10:09 +00:00
Andrew Nacin
557d9313a7 Introduce constants to allow for easier expression of time periods in seconds. Adds MINUTE_IN_SECONDS, HOUR_IN_SECONDS, DAY_IN_SECONDS, WEEK_IN_SECONDS, YEAR_IN_SECONDS. props nbachiyski, SergeyBiryukov. fixes #20987.
git-svn-id: http://core.svn.wordpress.org/trunk@21996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-25 05:26:19 +00:00
Andrew Nacin
d9105470c3 Use get_bloginfo('version', 'display') for displaying the WP version number in the admin. Can allow for filtering -- for example, showing the SVN revision. props SergeyBiryukov, see #18629.
git-svn-id: http://core.svn.wordpress.org/trunk@21986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-24 21:27:28 +00:00
Andrew Nacin
68061acf95 Add restrict_manage_comments hook. props hardy101. fixes #21344.
git-svn-id: http://core.svn.wordpress.org/trunk@21985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-24 21:23:43 +00:00
Ryan Boren
25ed7f52c3 The edit-tags screen ID does not contain the post_type. Fallback to post_type in the REQUEST. Fixes AJAX term addtions from edit-tags.php. fixes #21871
git-svn-id: http://core.svn.wordpress.org/trunk@21982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-24 20:39:53 +00:00
Andrew Ozz
1924ec4117 Add menu-vs-2x.png and 2x media-button.png, pngcrush all in wp-admin/images, props empireoflight, see #21019
git-svn-id: http://core.svn.wordpress.org/trunk@21980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-24 19:44:42 +00:00
Andrew Nacin
87511d1aa7 Add back the space between class names removed in [21914]. see #21871.
git-svn-id: http://core.svn.wordpress.org/trunk@21974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-24 16:42:50 +00:00
Andrew Nacin
70ad7496a6 Deprecate wp_create_thumbnail(). props obenland. fixes #21555.
git-svn-id: http://core.svn.wordpress.org/trunk@21956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-23 17:48:24 +00:00
Andrew Nacin
76bc5c7c21 Better alignment in the ustom fields metabox. props SergeyBiryukov, ocean90, fixes #21847.
git-svn-id: http://core.svn.wordpress.org/trunk@21955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-23 17:42:46 +00:00
Andrew Nacin
e4c209f18b Remove old autosave collision code from edit_post(). props miqrogroove.
This code, which could block autosaves when drafts had future timestamps,
dates to before autosaves were saved as revisions and is no longer necessary.

fixes #21858.



git-svn-id: http://core.svn.wordpress.org/trunk@21949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-22 02:11:09 +00:00
Andrew Nacin
33af30eb7f Use the regular post type UI for editing single media items (attachments).
* Attachments now go through post.php, edit_post(), the like, and have show_ui set to true.
 * Taxonomies attached to the media library now appear in the admin menu (if show_ui).
 * Editing, cropping, uploading, etc. is still very rough, but mostly functional.

API-wise:
 * New function: get_taxonomies_for_attachments(). Like get_taxonomies(), for taxonomies specifically registered against attachments.
 * Brings taxonomy support from the posts list table to the media list table. Expect them to converge soon.
 * wp_insert_attachment() now handles taxonomies like wp_insert_post(). Also expect them to converge soon.
 * New edit_form_after_title hook.

props helenyhou, ocean90. see #21391.



git-svn-id: http://core.svn.wordpress.org/trunk@21948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-21 22:52:54 +00:00
Peter Westwood
8b9ab93511 Export: Ignore auto-drafts when building the list of users for the export file. Fixes #21960.
git-svn-id: http://core.svn.wordpress.org/trunk@21946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-21 21:48:52 +00:00
Andrew Nacin
51326aaf91 Reset $taxonomy in single_row's default branch. props tott. fixes #21240.
git-svn-id: http://core.svn.wordpress.org/trunk@21945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-21 20:28:25 +00:00
Andrew Nacin
c1b0670c2d Updates and fixes to the new button styles. By default, buttons are now the same size as they were in 3.4. Then there is a smaller button (designed for minor elements) and a larger button (designed for things like Publish and Save Changes). Better focus styles. props lessbloat. see #21598.
git-svn-id: http://core.svn.wordpress.org/trunk@21944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-21 19:34:23 +00:00
Peter Westwood
fa8a509ff3 Posting: Improve the invalid date protection code based on feedback from nacin.
* Introduce a wp_checkdate() function with a single filter to centralise the code that validates dates.
 * Improve the error message
 * Correctly handle the return value of wp_insert_post which is not always a WP_Error on failure

Fixes #17180


git-svn-id: http://core.svn.wordpress.org/trunk@21922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-20 10:46:50 +00:00
Peter Westwood
c05f6dc6dd Posting: Make it much harder to create posts with invalid dates by enforcing the post date tests in the UI and the backend code.
Previously you could quite easily send a new post into the back of beyond by specifying an invalid date like the 30th Feb and this was very confusing.
Sometimes it would seem to work and sometimes the post would end up very far in the past - depending on the mysql version and other factors.

Fixes #17180 props jkudish.


git-svn-id: http://core.svn.wordpress.org/trunk@21921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-19 21:43:35 +00:00
Andrew Nacin
52320dc5b3 It is 'Alternative Text', not 'Alternate Text'. props alecrust, RyanJKoehler. fixes #21176.
git-svn-id: http://core.svn.wordpress.org/trunk@21917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-19 16:55:43 +00:00
Ryan Boren
a3cfe28527 Reduce reliance on global variables in the list tables. Allow passing a screen ID to the list tables so that ajax handlers can set the needed screen.
Props nacin
fixes #21871


git-svn-id: http://core.svn.wordpress.org/trunk@21914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-19 12:43:31 +00:00
Andrew Nacin
2d1eae820f Avoid mangling UTF-8 strings that may be present in image metadata. props SergeyBiryukov for the unit tests [UT665]. fixes #9417.
git-svn-id: http://core.svn.wordpress.org/trunk@21905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-18 23:38:25 +00:00
Andrew Nacin
cfdab676fa Replace QuickPress labels with gray prompt texts. Stylish, but also done for localization purposes (string lengths). props ocean90. fixes #21754.
git-svn-id: http://core.svn.wordpress.org/trunk@21894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-18 18:45:44 +00:00
Andrew Nacin
96d002c4dd Return term slugs rather than term names in attachment_fields_to_edit() as that is what we are dealing with. props eddiemoya, fixes #20765.
git-svn-id: http://core.svn.wordpress.org/trunk@21889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-18 17:34:01 +00:00
Andrew Nacin
0d43250e2d Move the Cancel button for replying and quick-editing a comment to after the primary update/reply button so tabbing from the comment field takes you to the primary action. see #21340.
git-svn-id: http://core.svn.wordpress.org/trunk@21883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-17 22:13:53 +00:00
Andrew Nacin
db118bdee8 Remove unused $t_time variable. props ocean90. fixes #18531.
git-svn-id: http://core.svn.wordpress.org/trunk@21880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-17 02:12:09 +00:00
Andrew Ozz
b443373e8e Admin menu: add phpdoc/inline comments describing the usage of the param $icon_url in add_menu_page(), add string 'none' to be used when a menu icon is added from CSS, switch core items in the admin menu to use 'none', fixes #21349
git-svn-id: http://core.svn.wordpress.org/trunk@21877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-16 22:51:44 +00:00
Andrew Nacin
63f80ff4af Basic phpdoc for admin includes media.php. props c3mdigital. fixes #21144.
git-svn-id: http://core.svn.wordpress.org/trunk@21871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-16 18:31:42 +00:00
Andrew Nacin
37537626e3 Don't use hard-coded indexes when dealing with an array of roles. props elyobo. fixes #19222.
git-svn-id: http://core.svn.wordpress.org/trunk@21866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-16 16:24:33 +00:00
Andrew Nacin
e914a04335 Trim incoming searches on the users list table. props tollmanz. fixes #21318.
git-svn-id: http://core.svn.wordpress.org/trunk@21864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-16 16:11:01 +00:00
Andrew Nacin
f431b408da Combine some strings. props pavelevap. fixes #21087.
git-svn-id: http://core.svn.wordpress.org/trunk@21857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-15 19:57:05 +00:00
Andrew Nacin
7fd32ab9fc Fold Privacy Settings into Reading Settings, moving blog_public (search engine/robots) to options-reading and removing options-privacy.
When blog_public only has two values (as judged by whether the blog_privacy_selector action is used), convert from radio buttons to a checkbox, and rename from 'Site Visibility' to a more specific 'Search Engine Visibility'.

The text and implementation may change a bit. see #16416.



git-svn-id: http://core.svn.wordpress.org/trunk@21838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-13 17:28:57 +00:00
Andrew Nacin
285660c2a1 Correct return values for two deprecated media admin functions. props SergeyBiryukov. fixes #21518.
git-svn-id: http://core.svn.wordpress.org/trunk@21835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-13 17:09:41 +00:00
Andrew Nacin
54e24f964a Disable multisite quotas by default on new installs. props mpvanwinkle77. fixes #21513.
git-svn-id: http://core.svn.wordpress.org/trunk@21827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-12 15:48:40 +00:00
Andrew Nacin
dc49f24a6c Remove ms-files.php rewriting from WordPress multisite. fixes #19235.
Keep existing networks compatible with a ms_files_rewriting network option.



git-svn-id: http://core.svn.wordpress.org/trunk@21823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-11 22:22:20 +00:00
Andrew Nacin
9d204841ee Remove AtomPub from core.
* Will be replaced with http://wordpress.org/extend/plugins/atom-publishing-protocol/.
 * Introduces an action, xmlrpc_rsd_apis, to add APIs to xmlrpc.php?rsd.
 * Introduces support for 'error' being 403 and 50x in class-wp.php.
 * Removes 'Remote Publishing' from Writing Settings (see [21804]). Keeps the remote_publishing settings section.

DB version is bumped to generate the new wp-app rewrite rule and remove the old enable_app option.

props wonderboymusic.
fixes #21509.



git-svn-id: http://core.svn.wordpress.org/trunk@21818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-11 20:11:39 +00:00
Andrew Nacin
2676491ceb Indicate on themes.php when a theme is a child that requires a parent theme. fixes #17944.
git-svn-id: http://core.svn.wordpress.org/trunk@21816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-11 19:12:37 +00:00
Ryan Boren
54d7300755 Avoid 'Creating default object from empty value' warning in PHP 5.4. Props SergeyBiryukov, knutsp. fixes #21716
git-svn-id: http://core.svn.wordpress.org/trunk@21815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-11 18:54:56 +00:00
Daryl Koopersmith
7fb2c8b4f7 Use JS Attachment models in wp.Uploader. fixes #21868.
Moves the uploading Attachments queue from the media workspace view to the uploader itself. This ensures that all attachments are added to the central attachmnet store.

Updates wp.Uploader to pass Attachment models to callbacks instead of Plupload file objects. Attachments in the process of uploading have a reference to the file object (which can be fetched by calling `attachment.get('file');`).

Also updates the customizer to be compatible with the API changes.


git-svn-id: http://core.svn.wordpress.org/trunk@21814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-11 16:55:58 +00:00
Andrew Nacin
87c947a987 Use network_site_url() for wp-signup.php. props markjaquith. see #19796.
git-svn-id: http://core.svn.wordpress.org/trunk@21813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-11 12:27:25 +00:00
Andrew Nacin
1080c1e4ee Use the key we found using array_search() to unset it from the array. props hakre. fixes #16562.
git-svn-id: http://core.svn.wordpress.org/trunk@21812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-11 02:12:34 +00:00
Andrew Nacin
d6b2024a7d Remove old edit_*_per_page usermeta keys.
These per-page values were when the post type or taxonomy name has a hyphen.
Previously, these were converted to underscores. This changed in [21322].

fixes #18958.



git-svn-id: http://core.svn.wordpress.org/trunk@21811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-11 02:08:29 +00:00
Andrew Nacin
670105e1fb Remove 'hwstring_small' from attachment metadata and deprecate get_udims(). props SergeyBiryukov. fixes #21518.
git-svn-id: http://core.svn.wordpress.org/trunk@21808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-11 01:38:26 +00:00
Andrew Nacin
884a89055b Don't show 'Uncategorized' in the category column on edit.php if there are no categories (including the default one). props ocean90. fixes #21240.
git-svn-id: http://core.svn.wordpress.org/trunk@21806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-11 01:31:53 +00:00
Andrew Nacin
26dc1e74e5 Turn XML-RPC on and remove the option on the Writing Settings page.
props markoheijnen for the initial patch.

Introduces a new filter, xmlrpc_enabled.

Respects any current callbacks registered to the pre_option_enable_xmlrpc
and option_enable_xmlrpc filters, for anyone forcing it off via code.

fixes #21509.



git-svn-id: http://core.svn.wordpress.org/trunk@21804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-11 00:37:31 +00:00
Andrew Nacin
e3cb5634b4 Wrap the unused options line in populate_options().
git-svn-id: http://core.svn.wordpress.org/trunk@21803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-11 00:08:58 +00:00
Ryan Boren
3205818a04 Add missing closedir() to wpmu_delete_blog(). Props timfs. fixes #21780
git-svn-id: http://core.svn.wordpress.org/trunk@21801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-10 21:16:03 +00:00
Ryan Boren
d8013dfc0a Deprecate get_default_post_to_edit(). Props SergeyBiryukov. fixes #21677
git-svn-id: http://core.svn.wordpress.org/trunk@21800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-10 20:39:45 +00:00
Ryan Boren
3a5cf2395d When reassigning posts and links during user deletion, clear the post and link caches. Props kurtpayne. fixes #20447
git-svn-id: http://core.svn.wordpress.org/trunk@21798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-10 19:56:08 +00:00
Ryan Boren
daa6757a9b Check for an empty post in wp_popular_terms_checklist(). _wp_ajax_add_hierarchical_term() doesn't set up global post info. Props SergeyBiryukov. see #21309
git-svn-id: http://core.svn.wordpress.org/trunk@21791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-10 16:45:49 +00:00
Daryl Koopersmith
67894a3407 New button styles.
Using the new buttons:

* Button classes are now stackable.
* All buttons should use a base class of "button".
* Buttons default to the gray style (formerly "button-secondary"). Buttons can add a style by adding additional classes. To make a primary button, add the "button-primary" class.
* Buttons can be rendered in various sizes. In addition to the default size, you can add "button-large", "button-small", or "button-tiny".

For backwards compatibility reasons, "button-primary" and "button-secondary" both work as standalone classes.

get_submit_button() has been adjusted to handle shorthand button classes (i.e. button classes can be passed without the "button-" prefix).

props lessbloat, helenyhou, trepmal, nacin. see #21598.



git-svn-id: http://core.svn.wordpress.org/trunk@21789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-08 04:58:34 +00:00
Andrew Nacin
1af8c36086 Allow easy registration of taxonomy columns on post (and custom post type) list table screens.
To register a column for a list table, use the new manage_taxonomies_for_{$post_type}_columns
filter. Introduces show_admin_column => true for register_taxonomy(), which automatically
displays that column on all associated post types.

props jtsternberg, SergeyBiryukov for initial patches.
fixes #21240.



git-svn-id: http://core.svn.wordpress.org/trunk@21788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-08 03:18:36 +00:00
Andrew Nacin
aa543734b8 Fix adding and updating from the Custom Fields meta box. Broken in [21205]. props SergeyBiryukov. see #21829 for trunk.
git-svn-id: http://core.svn.wordpress.org/trunk@21781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-07 15:49:20 +00:00
Daryl Koopersmith
12c21bf931 First pass at integrating featured images with the new media workflow.
Updates the featured image when the publish/update button is clicked (rather than instantly). Uses the existing post_thumbnail_meta_box() function. Does not remove the old featured image meta box JS, ajax handler, or CSS.

see #21776, #21390.


git-svn-id: http://core.svn.wordpress.org/trunk@21770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-06 08:49:35 +00:00
Ryan Boren
fafbaa51e4 Change the number of themes shown per page in themes.php from 999 to 36 so that infinite scroll engages. 36 was chosen to match the per page limit for theme-install.php
git-svn-id: http://core.svn.wordpress.org/trunk@21768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-05 20:33:34 +00:00
Andrew Nacin
fb36abe6b7 Always URL-encode a stylesheet directory value before using it in a URL. These situations are saved by wp_nonce_url(), but we should not depend on that. see #21749, for trunk only.
git-svn-id: http://core.svn.wordpress.org/trunk@21755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-04 22:35:12 +00:00
Andrew Nacin
d476c22aa1 Fix old-school Preview links when a theme directory contains spaces. Fix the theme-editor.php link from MS themes screens when a theme directory contains spaces. see #21749.
git-svn-id: http://core.svn.wordpress.org/trunk@21752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-04 22:25:25 +00:00
Ryan Boren
fd3b312310 Remove the filter setting when searching media. Props helenyhou. fixes #19452
git-svn-id: http://core.svn.wordpress.org/trunk@21750 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-04 21:20:51 +00:00
Ryan Boren
f7a8369422 Remove not so useful author column sorting. Props scribu. fixes #17141
git-svn-id: http://core.svn.wordpress.org/trunk@21743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-04 20:57:18 +00:00
Ryan Boren
999d31c237 Make the callback optional for add_settings_section(). Props lightningspirit. fixes #21630
git-svn-id: http://core.svn.wordpress.org/trunk@21742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-04 20:55:20 +00:00
Andrew Nacin
d31f7b3793 Restore global references that broke the media and comment list tables. Todo, make list tables rely far less on global state. see #21309.
git-svn-id: http://core.svn.wordpress.org/trunk@21736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-04 18:23:51 +00:00
Ryan Boren
cfb35a9d85 Use get_post() instead of global $post.
Make the $post argument to get_post() optional, defaulting to the current post in The Loop.

Props nacin
see #21309


git-svn-id: http://core.svn.wordpress.org/trunk@21735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-04 16:29:28 +00:00
Andrew Nacin
3cd8b94ba1 Fix placeholders in 'Welcome to WordPress' successful update messages. props SergeyBiryukov. see #21511.
git-svn-id: http://core.svn.wordpress.org/trunk@21703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-03 21:57:53 +00:00
Andrew Nacin
b3cd5dacb1 Don't call self_admin_url() or esc_url() when declaring that WordPress updated successfully, as they may not exist in the current (just updated) version.
props SergeyBiryukov.
see #21511.
for trunk.



git-svn-id: http://core.svn.wordpress.org/trunk@21702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-03 21:56:12 +00:00
Andrew Nacin
55e3541896 Only show network-only plugins in the network admin. props SergeyBiryukov. see #21187, for trunk.
git-svn-id: http://core.svn.wordpress.org/trunk@21700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-03 19:42:31 +00:00
Mark Jaquith
77563d1614 Fix the adding of link categories through the "Add Link" screen. props yoavf. fixes #21590 for trunk
git-svn-id: http://core.svn.wordpress.org/trunk@21688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-31 18:20:28 +00:00
Ryan Boren
f0c8b8d0e7 Introduce WP_Screen::in_admin() for determining which admin the screen is in.
Change is_*_admin() to reference in_admin() with fallback to the WP_*_ADMIN constants during early bootstrap. This allows unit tests and ajax handlers to set the admin context.

fixes #21742


git-svn-id: http://core.svn.wordpress.org/trunk@21687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-31 17:16:46 +00:00
Daryl Koopersmith
a54da100ce Fix a misnamed variable, which caused the query-attachments ajax handler to ignore all input. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@21682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-31 04:32:25 +00:00
Andrew Nacin
75052955cc Add get-attachment and query-attachments Ajax handlers. props koopersmith. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@21681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-31 02:58:51 +00:00
Ryan Boren
c55cf716da Use set_url_scheme(). Props johnbillion, MarcusPope. see #19037 #20759
git-svn-id: http://core.svn.wordpress.org/trunk@21664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-30 13:33:00 +00:00
Andrew Nacin
9a07332682 Update old files array:
* Remove old names for jQuery UI Effects files. see #21736.
 * Remove un-minified version of Jcrop and jQuery Color. see #21692, #20728.
 * Remove .dev.css and .dev.js. see #21633.



git-svn-id: http://core.svn.wordpress.org/trunk@21660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-30 02:35:30 +00:00
Andrew Nacin
3331a345bc Update some code comments from .dev.js to .js. props georgestephanis. see #21633.
git-svn-id: http://core.svn.wordpress.org/trunk@21659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-30 02:15:57 +00:00
Ryan Boren
52b3f498e6 Add tags_input, page_template, and post_category get magic to WP_Post.
Deprecate get_post_to_edit() and wp_get_single_post().
Props scribu
see #21309


git-svn-id: http://core.svn.wordpress.org/trunk@21651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-28 19:08:28 +00:00
Andrew Nacin
bdec91100c Remove paths to where theme files are located from theme details on themes.php. props lessbloat, see #17944.
git-svn-id: http://core.svn.wordpress.org/trunk@21650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-28 18:48:50 +00:00
Ryan Boren
9267d41910 Initialize to avoid 'Creating default object from empty value' warning in PHP 5.4.4.
git-svn-id: http://core.svn.wordpress.org/trunk@21647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-28 18:03:12 +00:00
Andrew Nacin
770ee9720a Add new 'flexible-header' tag for themes. Add it to Twenty Ten and Twenty Eleven. [21533] added it for Twenty Twelve.
props lancewillett. fixes #21065.



git-svn-id: http://core.svn.wordpress.org/trunk@21604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-24 15:22:14 +00:00
Ryan Boren
18a1783423 Update phpdoc for functions that return WP_Post. Soft deprecate get_page(). see #21309
git-svn-id: http://core.svn.wordpress.org/trunk@21598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-23 20:34:41 +00:00
Ryan Boren
f56d8278bb Remove return ref from all calls to get_post()
Return WP_Post from get_default_post_to_edit()
Replace all calls to get_page() with get_post()
see #21309


git-svn-id: http://core.svn.wordpress.org/trunk@21597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-23 20:01:10 +00:00
Andrew Nacin
33d56c303c Remove references to still-existing files from the old files array. see #20980.
git-svn-id: http://core.svn.wordpress.org/trunk@21594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-23 00:58:43 +00:00
Andrew Nacin
aec38ee1af Remove Prototype and script.aculo.us from core.
Continue to register them, pulling from ajax.googleapis.com. This is only being done for backwards compatibility;
libraries in use will continue to be local sources.

In the process, update to the latest versions of Prototype (1.7.1, June 5) and script.aculo.us (1.9.0, from 2010).

props helenyhou.
fixes #21661, #16664, #16665.



git-svn-id: http://core.svn.wordpress.org/trunk@21593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-23 00:51:08 +00:00
Andrew Ozz
e00b17aac6 Replace the dark spinner with the light on the widgets screen and retire wpspin_dark.gif, props helenyhou and lessbloat, fixes #20957
git-svn-id: http://core.svn.wordpress.org/trunk@21577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-22 02:02:37 +00:00
Andrew Nacin
bfaaa3d8ab Remove unused multisite option 'language'. props wonderboymusic. fixes #21545.
git-svn-id: http://core.svn.wordpress.org/trunk@21551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-20 16:43:44 +00:00
Ryan Boren
65f5267604 Send Content-Type with charset for iframe_header(). Props SergeyBiryukov, sergey.s.betke@novgaro.ru. fixes #19454
git-svn-id: http://core.svn.wordpress.org/trunk@21538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-17 14:19:03 +00:00
Andrew Nacin
e79a56793c Disable the Link Manager on any future upgrade if it is still enabled but there are no links. see #21307.
git-svn-id: http://core.svn.wordpress.org/trunk@21536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-16 23:08:07 +00:00
Ryan Boren
15dd7f70b0 Remove post type from post nonces. Fixes attachment deletion when EMPTY_TRASH_DAYS is 0. Props c3mdigital, kurtpayne, SergeyBiryukov. fixes #21194
git-svn-id: http://core.svn.wordpress.org/trunk@21504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-14 18:39:15 +00:00
Andrew Nacin
84c3a86036 Hide the link manager from the UI on upgrade, if the site has no links. New DB option, link_manager_enabled.
Enforce this by denying the 'manage_links' capability, which hides the All Links, Add New Link, and Link Categories screens. Hide WP_Widget_Links and the UI for the default_link_category as well.

Convert all references to 'posts and links' when handling reassignment on user deletion to just 'posts'.

see #21307.



git-svn-id: http://core.svn.wordpress.org/trunk@21501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-13 16:18:42 +00:00
Andrew Nacin
720e09ff5b Stop adding default links and the 'Blogroll' link category on install. props wonderboymusic. see #21307.
git-svn-id: http://core.svn.wordpress.org/trunk@21500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-13 15:55:15 +00:00
Andrew Ozz
64033c4645 Remove unused images, props helenyhou, coffee2code, ocean90, fixes #20980
git-svn-id: http://core.svn.wordpress.org/trunk@21498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-11 02:36:01 +00:00
Ryan Boren
cbd6a8becd Allow passing stdClass and WP_User to wp_insert_user() and wp_update_user(). Introduce WP_User::to_array(). Eliminate uses of get_object_vars() when passing to wp_*_user(). fixes #21429
git-svn-id: http://core.svn.wordpress.org/trunk@21496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-10 15:36:54 +00:00
westi
c702fe6657 Multisite: Fix the new get_space_used() function to correctly calculate Megabytes used and update some phpdoc. Props SergeyBiryukov.
git-svn-id: http://core.svn.wordpress.org/trunk@21474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-08 07:17:33 +00:00
nacin
4e5fd4de46 Introduce wpdb::get_charset_collate() to return the DEFAULT CHARACTER SET and COLLATE for use in table schemas.
props simonwheatley, pento. fixes #18451.



git-svn-id: http://core.svn.wordpress.org/trunk@21471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-08 06:13:48 +00:00
azaozz
6a5a3a81b6 Accessibility: enhance the Screen Options and Help tabs open/close, see #21326
git-svn-id: http://core.svn.wordpress.org/trunk@21457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-06 04:26:37 +00:00
ryan
5ca54e7d2f Deprecate get_blog_option(), add_blog_option(), update_blog_option(), and delete_blog_option().
Use the regular option functions wrapped in switch_to_blog() and restore_current_blog() instead.

Group multiple operations within a single switch where possible.

fixes #21432


git-svn-id: http://core.svn.wordpress.org/trunk@21414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-03 17:51:42 +00:00
nacin
7127ed1197 Move most instances of new WP_User to get_userdata(). see #21120.
git-svn-id: http://core.svn.wordpress.org/trunk@21413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-03 01:06:05 +00:00
westi
4443baaab9 Multisite: Rework the upload space usage tracking code so as to be fully pluggable.
* Moves some admin only functions into wp-admin/includes/ms.php from wp-includes/ms-functions.php
 * Reworked the variable naming to be more in line with the Coding Standards
 * Introduced a new get_space_used() function instead of calculating it in multiple places.

Fixes #21181 props dllh and jkudish for inital work on this.


git-svn-id: http://core.svn.wordpress.org/trunk@21387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-01 13:52:06 +00:00
ryan
7b49ad8493 Introduce get_edit_user_link(). Props scribu, georgestephanis, johnbillion. fixes #14787 see #20307
git-svn-id: http://core.svn.wordpress.org/trunk@21364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-30 18:30:03 +00:00
azaozz
99496fb30c Widgets: add localization context for 'Add' and 'Edit', props nacin, fixes #21338
git-svn-id: http://core.svn.wordpress.org/trunk@21356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-27 03:56:27 +00:00
azaozz
93979aa0ef Widgets: Add the name of the widget to the Add and Edit buttons on the Accessible Widget Management Screen, props cannona, fixes #21338
git-svn-id: http://core.svn.wordpress.org/trunk@21355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-27 03:33:38 +00:00
ryan
44ef6d8e80 Deprecate and stub _media_button. fixes #21317
git-svn-id: http://core.svn.wordpress.org/trunk@21353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-26 21:33:01 +00:00
ryan
1c175f829e Deprecate and stub _insert_into_post_button(). fixes #20427
git-svn-id: http://core.svn.wordpress.org/trunk@21352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-26 21:30:06 +00:00
ryan
2417e42fe5 Improved phpdoc for file.php. Props tommcfarlin. fixes #21328
git-svn-id: http://core.svn.wordpress.org/trunk@21350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-26 15:08:30 +00:00
ryan
e02ea8023e Remove debug cruft. Props ocean90. fixes #21315
git-svn-id: http://core.svn.wordpress.org/trunk@21349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-26 15:01:44 +00:00
ryan
fdae8f9b42 Fix some spelling errors. Props thee17. fixes #21191
git-svn-id: http://core.svn.wordpress.org/trunk@21333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-25 18:06:13 +00:00
ryan
73addbbd24 More screen reader text for list table checkboxes and theme install search. Props MikeLittle, SergeyBiryukov. see #21325
git-svn-id: http://core.svn.wordpress.org/trunk@21323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-25 16:18:14 +00:00
ryan
f45383244d Fix per_page screen option for custom post types and taxonomies. Don't convert taxonomy and post type slugs from hyphen to underscore when saving the per_page usermeta. Props nacin. see #18958
git-svn-id: http://core.svn.wordpress.org/trunk@21322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-25 16:13:13 +00:00
ryan
72e4f612e2 Add screen reader text for search fields in theme-install.php. Props MikeLittle. see #21325
git-svn-id: http://core.svn.wordpress.org/trunk@21318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-24 18:31:03 +00:00
ryan
c36145c9aa Add screen reader text to checkboxes in list tables. Props MikeLittle, nacin. see #21325
git-svn-id: http://core.svn.wordpress.org/trunk@21317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-24 18:01:22 +00:00
ryan
91ab52d443 For get_settings_errors(), make sure errors from transient get added to the global variable and not unset when checking for an error of a specific setting. Also always return an array, as noted in the documentation. Props obenland. fixes #20833
git-svn-id: http://core.svn.wordpress.org/trunk@21315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-24 15:13:46 +00:00
azaozz
34535097b7 Remove nearly all tabindex attributes from the admin, leaving them only where absolutely necessary (for now that's only the toolbar).
Add tabindex="-1" for the menu images links to avoid double tab stops there when the menu is expanded.

Fix/add auto-focus on the first input fields on the Add/Edit Post, all taxonomy, all edit taxonomy, Log In and Edit Comment screens.

See #21340.

git-svn-id: http://core.svn.wordpress.org/trunk@21311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-24 00:15:15 +00:00
azaozz
2309fcb9d7 TinyMCE: fix tabbig in and out of the editor, fixes #20834
git-svn-id: http://core.svn.wordpress.org/trunk@21300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-22 02:33:53 +00:00
nacin
dcb200efc9 Fix order of @param's for deactivate_plugins(). props Viper007Bond, fixes #21269.
git-svn-id: http://core.svn.wordpress.org/trunk@21291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-20 15:09:40 +00:00
westi
4c33feb5ef Multisite: Tidy up [21256] and introduce/correct PHPDoc for a few other media upload functions.
Fixes #21179 props SergeyBiryukov.


git-svn-id: http://core.svn.wordpress.org/trunk@21260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-11 10:20:15 +00:00
westi
2039e3a8f0 Multisite: Make it easy to replace or augment the over-quota message displayed when you try and upload new media and you have reached your quota.
Fixes #21179 props dllh, jkudish. 


git-svn-id: http://core.svn.wordpress.org/trunk@21256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-10 13:33:44 +00:00
nacin
cacce8add0 Fix the 'Display item date' configuration option for the Incoming Links dashboard widget. props Latz, SergeyBiryukov, fixes #20644.
git-svn-id: http://core.svn.wordpress.org/trunk@21249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-09 19:16:53 +00:00
markjaquith
109768b788 Hide UI for Attachment taxonomies if show_ui is false for that taxonomy. props simonwheatley. fixes #21104
git-svn-id: http://core.svn.wordpress.org/trunk@21240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-09 04:56:50 +00:00
markjaquith
09f66013f5 Do not display an error message when a plugin or theme being updated is found to already be up to date. Note the fact, and call it success. props solarissmoke. fixes #19752
git-svn-id: http://core.svn.wordpress.org/trunk@21236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-09 03:40:32 +00:00
markjaquith
ecea277a8a Insert a proper line break (instead of an HTML line break) into the "first comment". props nacin. fixes #16712
git-svn-id: http://core.svn.wordpress.org/trunk@21234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-09 03:19:02 +00:00
dd32
509b845abc Make get_home_path() work in more cases by being case insensitive and sanitzing Windows paths. In some cases (such as differing case of hostnames or paths in the site/home options, or when SCRIPT_FILENAME contains forward slashes) the function was failing to return the correct path, and would instead return /. Props to SergeyBiryukov for the initial patch. Fixes #20449 Fixes #10447
git-svn-id: http://core.svn.wordpress.org/trunk@21224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-06 13:54:15 +00:00
dd32
2a708450ec WP_Filesystem: Return symlinked directory names correctly, previously the FTP extensions would return it as 'source -> dest' instead of simply 'source'. Props kurtpayne. Fixes #17846
git-svn-id: http://core.svn.wordpress.org/trunk@21223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-06 11:39:39 +00:00
dd32
18e83f9c36 WP_Filesystem: When recursivly searching for a directory path, only search for unfound directory entries. This solves a case where the same directory may be entered twice inadvertantly when nested directories using the same name exist. Fixes #20652
git-svn-id: http://core.svn.wordpress.org/trunk@21222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-06 11:19:46 +00:00
dd32
6c6d746637 WP_Filesystem: Correct a rare case where the FTP directory will be detected incorrectly when the final path token exists higher in the chain, for example /x/x/Z/x/Z/ would be detected as /x/x/Z/. Fixes #20934
git-svn-id: http://core.svn.wordpress.org/trunk@21221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-06 10:41:32 +00:00
markjaquith
6a1d888ea5 Better image extension regexes, so we don't just grab the "jpe" from "jpeg" files in media_sideload_image(). props sivel. fixes #16693
git-svn-id: http://core.svn.wordpress.org/trunk@21219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-05 20:51:55 +00:00
nacin
4b82f5c42d require_once dashboard.php in wp_ajax_dashboard_widgets() so it is testable. props kurtpayne. fixes #UT41.
git-svn-id: http://core.svn.wordpress.org/trunk@21203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-30 15:07:39 +00:00
nacin
9d20dfc4e1 Enforce multisite plugins menu preference in map_meta_cap(). This means a simple current_user_can('activate_plugins') check will handle the 'Enable administration menus' setting.
Remove bogus checks for enabling/disabling the 'themes' menu (something core does not handle out of the box) when in the network admin.

fixes #21123.



git-svn-id: http://core.svn.wordpress.org/trunk@21198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-30 12:40:25 +00:00
nacin
b43393e9db Cap checks for links in the upgrader, for plugins. fixes #19824.
git-svn-id: http://core.svn.wordpress.org/trunk@21197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-30 12:19:13 +00:00
nacin
fffff45c25 Cap checks in the upgrader so we do not show links the user cannot access. props linuxologos for the initial patch. see #19824.
Also fixes a rare fatal error when theme_info is not set when updating a theme that is already up to date.



git-svn-id: http://core.svn.wordpress.org/trunk@21195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-30 12:08:18 +00:00
markjaquith
f010e00284 Prevent child pages from being visually promoted to the top level after Quick Edit. props ssamture. fixes #18615
git-svn-id: http://core.svn.wordpress.org/trunk@21192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-30 09:28:15 +00:00
markjaquith
ab1c5db441 Prevent child categories from being visually promoted to the top level after Quick Edit. props ssamture. fixes #19474
git-svn-id: http://core.svn.wordpress.org/trunk@21191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-30 09:00:26 +00:00
markjaquith
70eae0e09b Standardize our "View Post" new-tab/no-new-tab behavior. Committed this thirtieth day of June, Anno Domini MMXII. May peace and good sense forever reign in this realm. Uh... Amen.
props SergeyBiryukov. fixes #11406.

git-svn-id: http://core.svn.wordpress.org/trunk@21189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-30 08:49:26 +00:00
nacin
dfa7b94b83 Add inline documentation for wp_edit_attachments_query(). props simonwheatley, SergeyBiryukov. fixes #21105.
git-svn-id: http://core.svn.wordpress.org/trunk@21179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-29 15:09:14 +00:00
markjaquith
0d124a2286 Google Gears is dead. Long live its HTML5 replacement that does not in any way work for our purposes. props azaozz. fixes #20981
git-svn-id: http://core.svn.wordpress.org/trunk@21176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-29 03:34:02 +00:00
markjaquith
55278fa7a4 Pass the post ID to the admin_post_thumbnail_html filter. props helenyhou. fixes #20891
git-svn-id: http://core.svn.wordpress.org/trunk@21173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-28 20:41:04 +00:00
nacin
a90957aca0 Inline documentation for image_attachment_fields_to_save(). props Moraleida.me. fixes #20803.
git-svn-id: http://core.svn.wordpress.org/trunk@21171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-28 20:31:28 +00:00
markjaquith
168cc20a42 Allow tel: and fax: protocols. Wrangle the last hardcoded protocol enumeration so that it uses wp_allowed_protocols(). fixes #21081
git-svn-id: http://core.svn.wordpress.org/trunk@21170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-28 20:30:10 +00:00
nacin
a7249bfee8 Move the 'Delete' bulk action to the bottom in the network themes list tables. Symmetry with the plugins list tables. props trepmal. fixes #21032.
git-svn-id: http://core.svn.wordpress.org/trunk@21164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-28 20:05:15 +00:00
nacin
868ce1dfdd Remove dead conditionals from the media and post list tables. props wpmuguru, SergeyBiryukov. fixes #20781.
git-svn-id: http://core.svn.wordpress.org/trunk@21162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-28 19:58:43 +00:00
nacin
149eff94a1 WP.org no longer returns this old structure. The title of the item is the plugin name in full. fixes #21012.
git-svn-id: http://core.svn.wordpress.org/trunk@21160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-28 19:34:25 +00:00
markjaquith
06bc3bf328 Autofocus the search box on the Theme and Plugin installation pages. Faster flow for people who know what they are looking for. props SergeyBiryukov. fixes #21080. see #21027.
git-svn-id: http://core.svn.wordpress.org/trunk@21143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-26 20:55:46 +00:00
nacin
3a215028ea Allow switch_theme() to take a single $stylesheet argument.
It now effectively has two function definitions:
function switch_theme( $stylesheet )
function switch_theme( $template, $stylesheet )

fixes #21075.



git-svn-id: http://core.svn.wordpress.org/trunk@21131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-26 05:21:04 +00:00