Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-12-27 19:47:42 +01:00
Code Issues Projects Releases Wiki Activity
45,031 Commits 50 Branches 749 Tags 806 MiB
e05557e222
Commit Graph

727 Commits

Author SHA1 Message Date
Andrew Nacin
6500a24719 Call shortcode functions directly. props kovshenin, fixes #24505. 
git-svn-id: http://core.svn.wordpress.org/trunk@24547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-07-03 20:19:00 +00:00
Andrew Nacin
3231e8cbd0 Pass $post to hooks in edit-form-advanced.php including edit_form_advanced and edit_form_after_*. fixes #24611. 
git-svn-id: http://core.svn.wordpress.org/trunk@24446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-06-19 21:10:51 +00:00
Andrew Nacin
797ee34bc3 Remove /extend/ from URLs to wordpress.org/plugins, /themes, and /mobile, as those are all now top-level. see #24389. 
git-svn-id: http://core.svn.wordpress.org/trunk@24320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-05-22 21:01:57 +00:00
Sergey Biryukov
415a5c60da * Pass ellipsis as a parameter to wp_html_excerpt() instead of appending it manually. 
* Consolidate the logic to avoid appending ellipsis if the entire string is shown.
* Show ellipsis after truncated filenames and post titles.

props solarissmoke, bpetty, SergeyBiryukov. fixes #11446.

git-svn-id: http://core.svn.wordpress.org/trunk@24214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-05-09 00:22:02 +00:00
Andrew Nacin
b34ca3234e Remove manual printing of userSettings as utils.js receives this as inline script data (since 3.5). see #24210. 
git-svn-id: http://core.svn.wordpress.org/trunk@24187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-05-07 15:49:20 +00:00
Andrew Nacin
00b7fa589a Remove ancient 'lookup' quicktag from the text editor. This had called up answers.com. 
props mboynes, jonbishop, SergeyBiryukov.
fixes #23322.



git-svn-id: http://core.svn.wordpress.org/trunk@24052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-04-22 20:17:25 +00:00
Mark Jaquith
94c5f0aca1 Use ID3 data for audio and video 
fixes #23926. props wonderboymusic, SergeyBiryukov, johnbillion.

git-svn-id: http://core.svn.wordpress.org/trunk@23979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-04-12 22:27:24 +00:00
Sergey Biryukov
8d546ad739 Avoid an undefined index notice in wp_read_video_metadata(). props ocean90. fixes #23953. 
git-svn-id: http://core.svn.wordpress.org/trunk@23923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-04-06 00:29:12 +00:00
Mark Jaquith
fec4b66f5b Sanity checks on image metadata to avoid warnings, etc. 
fixes #23733. props wonderboymusic.

git-svn-id: http://core.svn.wordpress.org/trunk@23873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-29 20:51:35 +00:00
Mark Jaquith
ebdcf967a3 Show a playable audio/video preview on the Edit Attachment screen. 
props wonderboymusic. fixes #23726

git-svn-id: http://core.svn.wordpress.org/trunk@23768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-21 05:17:25 +00:00
Mark Jaquith
12d3fc7999 Add functions for generating metadata for video and audio, using the 
ID3 library. Also allows themes/plugins to add thumbnail support
to these media types. Think stuff like album art, movie covers, and
video freeze-frames.

props wonderboymusic. fixes #23673

git-svn-id: http://core.svn.wordpress.org/trunk@23766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-21 04:55:42 +00:00
Ryan Boren
469d1a3099 Escape form action urls with esc_url() rather than esc_attr(). 
Props SergeyBiryukov
fixes #23266


git-svn-id: http://core.svn.wordpress.org/trunk@23739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-18 14:01:25 +00:00
Helen Hou-Sandí
fffc2e1ab1 Prevent an unseemly gap on the edit screen when nothing else displays before normal meta boxes. Give better HTML and visual structure to items added via edit_form_after_title and edit_form_after_editor. Using a class of .edit-form-section will now get you a 20px bottom margin; perfect for your additions to the post edit screen. fixes #23240. 
git-svn-id: http://core.svn.wordpress.org/trunk@23615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-04 23:22:17 +00:00
Andrew Nacin
7b47322e22 Ensure the referer functions operate completely on unslashed data: wp_referer_field(), wp_original_referer_field(), wp_get_referer(), wp_get_original_referer(). 
Use wp_slash() instead of addslashes().

see #21767.



git-svn-id: http://core.svn.wordpress.org/trunk@23578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-01 17:58:43 +00:00
Ryan Boren
5f809d1d22 Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes(). 
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-01 17:00:25 +00:00
Ryan Boren
43a7e695e9 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767 
git-svn-id: http://core.svn.wordpress.org/trunk@23554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-01 16:28:40 +00:00
Ryan Boren
cc5ed3a485 Change all core API to expect unslashed rather than slashed arguments. 
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-14 22:51:06 +00:00
Mark Jaquith
dab5a6ef7d Fix some tabbing issues on the post editing screen. Add Media no longer skipped when going backwards from content. Save Draft no longer skipped when going forwards from content. 
props adamsilverstein. fixes #23195 and #22933

git-svn-id: http://core.svn.wordpress.org/trunk@23395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-08 18:30:09 +00:00
Andrew Nacin
5d980a8e8e Whenever we have compat fields to render, send a dummy menu_order field (which was always sent in 3.4) to ensure an unchecked checkbox can still be processed by attachment_fields_to_save. fixes #22868. 
git-svn-id: http://core.svn.wordpress.org/trunk@23290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-01-05 03:50:28 +00:00
Mark Jaquith
1419b404a8 Add the ability to click "Edit" and kick out to the advanced image editor from within the Media modal. New window, with "Refresh" offered on your return. fixes #22743. props koopersmith, nacin, helenyhou. 
git-svn-id: http://core.svn.wordpress.org/trunk@23095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-06 05:52:19 +00:00
Daryl Koopersmith
8efc323e2e Add hidden fields via attachment_fields_to_edit to the existing compat output. props nacin. fixes #22769. 
git-svn-id: http://core.svn.wordpress.org/trunk@23086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-06 03:28:21 +00:00
Andrew Nacin
173806d7a1 Restore the Description field to the media UI in 3.5. 
We tried in vain -- a noble but ultimately failed effort -- to reduce the number of fields for attachments from four (title, caption, alt, description) to one (caption for images, title otherwise). Alternative text needed to stay for accessibility reasons, of course.

Eventually title returned due to heavy plugin reliance. Description is too used by too many plugins (often times incorrectly -- the caption is more likely the proper field), hence its less-than-triumphant return today.

Version 3.5 has tried to streamline media in a number of ways. Removing fields may have been too much at once, as it forced not only a user interface change, but a paradigm change as well.

Finally, on upload we populate the description field with IPTC/EXIF captions, rather than the caption field. See #22768, this should be fixed. For now, Description stays.

This commit also restores 'Title' attribute editing to the main tab of the Edit Image dialog. The "Title" field no longer populates title attributes for <img> tags by design (for accessibility and other purposes, see #18984). So, here is a more obvious 'workaround' for the tooltip community.

Finally, this:
 * Cleans up the post.php attachment editor, including by showing a prettier form of the mime type.
 * Enables plugins to specifically hide attachment_fields_to_edit from either post.php (where you can create meta boxes) or the modal (which you may not want to clutter), for compatibility reasons.
 * Hides the 'Describe this file...' placeholder when a field is read-only in the modal.

props nacin, helenyhou.
fixes #22759.



git-svn-id: http://core.svn.wordpress.org/trunk@23083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-06 00:41:06 +00:00
Mark Jaquith
bc8ddb3e64 Intelligently make media fields readonly when the user cannot update or do anything with them. props koopersmith, helenyhou, nacin. fixes #22613 
git-svn-id: http://core.svn.wordpress.org/trunk@23072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 10:29:24 +00:00
Ryan Boren
d4abd95449 Scope button classes so they can be used on the frontend without interfering with theme styles. 
Props helenyhou, koopersmith
fixes #22644


git-svn-id: http://core.svn.wordpress.org/trunk@22948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-30 13:40:59 +00:00
Ryan Boren
27d943786b Introduce API to add back the description field in the new media popup. 
Props nacin
fixes #22642


git-svn-id: http://core.svn.wordpress.org/trunk@22929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-29 23:52:30 +00:00
Ryan Boren
cc9b248937 Always send nocache_headers() for admin-ajax.php. This prevents iOS from caching ajax calls. http://stackoverflow.com/questions/12506897/is-safari-on-ios-6-caching-ajax-results 
Turn off multi selection uploads for mobile devices. Currently Plupload cannot upload multiple files in iOS Safari. Only the first file makes it to the queue. 

Empty wp on unload to work around caching in iOS Safari.

Props azaozz, miqrogroove, nacin

fixes #22552


git-svn-id: http://core.svn.wordpress.org/trunk@22872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-27 16:17:53 +00:00
Ryan Boren
11c5f2c1fc Only show the image edit button for image attachments. Props markoheijnen. fixes #22596 
git-svn-id: http://core.svn.wordpress.org/trunk@22867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-27 15:06:02 +00:00
Ryan Boren
b7c0d84c7f In media_upload_flash_bypass(), pass the post id in the media-new.php url. 
In media-new.php, use post_id from REQUEST if passed and the current user can edit the post.
Fixes adding media with the browser uploader.

Props nacin, ocean90
fixes #22572


git-svn-id: http://core.svn.wordpress.org/trunk@22853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-26 23:10:19 +00:00
Andrew Nacin
4e9e4bf2cf Back compat for media_buttons_context, which is not the correct filter for adding new media buttons. If you want to add additional media buttons, use the media_buttons action instead. fixes #22559. 
git-svn-id: http://core.svn.wordpress.org/trunk@22848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-26 22:32:35 +00:00
Ryan Boren
5b94b6b43e In media_buttons(), consult global post_ID if get_post() comes up with nothing. 
Default postID to 0 in wp_enqueue_media().

Props nacin
fixes #22085


git-svn-id: http://core.svn.wordpress.org/trunk@22846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-26 22:03:37 +00:00
Andrew Nacin
efd9913490 Mustn't forget to hide the legacy media uploader! see #21390. 
git-svn-id: http://core.svn.wordpress.org/trunk@22828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-22 13:23:27 +00:00
Andrew Nacin
9120cf3375 WP_Image_Editor: the last stand. 
* Have wp_get_image_editor() rather than WP_Image_Editor::get_instance(). Having static factory methods would be less confusing if there weren't also static methods tied to individual editor implementations.
 * Lazy-load the WP_Image_Editor base class and editor implementations.
 * Have WP_Image_Editor_GD::supports_mime_type() actually check which types it supports.
 * Deprecate gd_edit_image_support() in favor of wp_image_editor_supports().

props DH-Shredder, scribu, markoheijnen. fixes #22356. see #6821.



git-svn-id: http://core.svn.wordpress.org/trunk@22817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-22 09:52:16 +00:00
Daryl Koopersmith
0d08430cfe Media: Replace the thumbnail on post.php using a request variable instead of the referer. props ocean90. fixes #21391. 
git-svn-id: http://core.svn.wordpress.org/trunk@22807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-22 03:43:16 +00:00
Andrew Nacin
55a6c62e76 Support attachment_fields_to_save and attachment_fields_to_edit for attachments going through post.php. see #22186. see #21391. 
git-svn-id: http://core.svn.wordpress.org/trunk@22783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-21 18:53:00 +00:00
Andrew Nacin
9b54e5c380 Have the media modal direct users to media-new.php for the browser uploader. fixes #22444. 
git-svn-id: http://core.svn.wordpress.org/trunk@22765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-21 15:30:48 +00:00
Andrew Nacin
229a919b27 media-new.php: Remove unused scripts, strings, error handling, save handling, and save button. fixes #22083. 
git-svn-id: http://core.svn.wordpress.org/trunk@22764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-21 15:10:17 +00:00
Andrew Nacin
75c464671d Revert accidental changes to admin/includes/media.php in [22755]. see #22083. 
git-svn-id: http://core.svn.wordpress.org/trunk@22759 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-21 14:04:24 +00:00
Andrew Nacin
1935e74233 Properly nest the if tag. props helenyhou. see #21391. 
git-svn-id: http://core.svn.wordpress.org/trunk@22757 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-21 13:32:26 +00:00
Andrew Nacin
e276fc44be Have media-new.php return simple rows of basic attachment data, with an 'Edit' link next to each taking them to post.php (in a new window). Not ideal, but this is largely a fallback screen at this point. 
This is bolted on to existing code, the vast majority of which is destined to be ripped out in 3.6 once things settle.

see #22083.



git-svn-id: http://core.svn.wordpress.org/trunk@22755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-21 13:05:44 +00:00
Andrew Nacin
96576a2dca Properly refresh the thumbnail on post.php after an image edit. props ocean90. see #21391. 
git-svn-id: http://core.svn.wordpress.org/trunk@22749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-21 12:05:24 +00:00
Andrew Nacin
9ad10730c0 Non-images don't have alternative text. props helenyhou. see #21391. 
git-svn-id: http://core.svn.wordpress.org/trunk@22748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-21 12:03:35 +00:00
Andrew Nacin
8f3a9e1907 Stop inserting title attributes for images inserted into the editor by modifying get_image_send_to_editor(), not the generic get_image_tag(). 
see #18984, [22409].



git-svn-id: http://core.svn.wordpress.org/trunk@22747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-21 11:50:30 +00:00
Daryl Koopersmith
b75ec467b2 Media: Whoops. Remove error_log. see [22699], #21390. 
git-svn-id: http://core.svn.wordpress.org/trunk@22700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-20 02:40:31 +00:00
Daryl Koopersmith
b1f720c616 Media: Improve media buttons on the front end. 
* Use a less specific selector (the body, actually) to delegate opening the media dialog.
* Allow the editor ID to be the empty string so the `media_buttons` action can be called without arguments.

see #22284, #21390.


git-svn-id: http://core.svn.wordpress.org/trunk@22699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-20 02:35:30 +00:00
Andrew Nacin
4b9ef4ee05 Remove errant return. props SergeyBiryukov. see #22186. 
git-svn-id: http://core.svn.wordpress.org/trunk@22679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-19 09:48:34 +00:00
Andrew Nacin
bd158c503f Move code from image_attachment_fields_to_edit() to get_attachment_fields_to_edit(). The level of abstraction is unnecessary, and it makes it more difficult to call only the filter in the new media modal. Also, that function is sloooow. see #22186. 
git-svn-id: http://core.svn.wordpress.org/trunk@22673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-19 08:10:38 +00:00
Andrew Nacin
479d27013a Avoid doing all of the extra work in get_attachment_fields_to_edit() for fields we will just discard. We just need the filter, and the taxonomies. see #22186. 
git-svn-id: http://core.svn.wordpress.org/trunk@22670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-19 07:20:47 +00:00
Andrew Nacin
0a888e8aa0 Prevent notices when post_id is not passed to the old media upload forms. props ldebrouwer. fixes #22465. 
git-svn-id: http://core.svn.wordpress.org/trunk@22628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-17 06:42:14 +00:00
Daryl Koopersmith
fd6b847330 Media: Make edit gallery button use new media. see #21390. 
git-svn-id: http://core.svn.wordpress.org/trunk@22568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-14 09:06:10 +00:00
Daryl Koopersmith
82213846c3 Media: Add backwards compatibility for attachment_fields_to_edit and attachment_fields_to_save. see #22186. 
git-svn-id: http://core.svn.wordpress.org/trunk@22541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-11 01:26:42 +00:00
Daryl Koopersmith
bed08350f4 Media: Backwards compatibility for media_upload_tabs. 
* Adds `createIframeStates()` to the `MediaFrame` view. It creates states and bindings for the `media_upload_tabs` output, and is included on `MediaFrame.Post` by default.
* Hijacks `tb_remove()` when the media modal is open to ensure the modal closes correctly.
* Adds a `chromeless` parameter to thickbox media tab URLs to render the UI without the old row of tabs.

see #22186, #21390.


git-svn-id: http://core.svn.wordpress.org/trunk@22523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-10 07:51:37 +00:00
Daryl Koopersmith
0a67c025e5 Media: Add wp_enqueue_media to easily include all media dependencies. 
Also, media templates now print on `wp_footer`.

props sushkov. fixes #22060, see #21390.


git-svn-id: http://core.svn.wordpress.org/trunk@22489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-09 04:57:25 +00:00
Andrew Nacin
9d7cb4ac7a Translate. see #19956. 
git-svn-id: http://core.svn.wordpress.org/trunk@22486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-09 04:40:56 +00:00
Daryl Koopersmith
0a5cdbb838 Media: Rename the "Beta Media" button to "Add Media". fixes #19956, see #21390. 
git-svn-id: http://core.svn.wordpress.org/trunk@22485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-09 04:35:38 +00:00
Andrew Nacin
c26f579b13 Put the label outside the span to ensure margins when the text wraps. props waclawjacek. fixes #19254. 
git-svn-id: http://core.svn.wordpress.org/trunk@22444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-07 21:41:31 +00:00
Andrew Nacin
039279db28 Only call wp_get_object_terms() if get_object_term_cache() says there is no cache (false), which is different than no terms. props wonderboymusic, fixes #16505. 
git-svn-id: http://core.svn.wordpress.org/trunk@22433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-07 20:00:51 +00:00
Andrew Nacin
224a21db80 Stop adding title attributes to images (in the old media uploader). props martythornley. fixes #18984. 
git-svn-id: http://core.svn.wordpress.org/trunk@22409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-06 23:23:03 +00:00
Ryan Boren
53c0024945 Use wp_basename() instead of basename() so that multibyte characters are not stomped. Props SergeyBiryukov. fixes #21217 
git-svn-id: http://core.svn.wordpress.org/trunk@22367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-05 14:33:56 +00:00
Ryan Boren
ad724f3b7b Attachment editor improvements. Put the non-editable metadata into the submit/publish box. 
Props helenyhou
see #21391


git-svn-id: http://core.svn.wordpress.org/trunk@22364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-05 14:04:22 +00:00
Andrew Nacin
4cbc20ada1 Pass the post date to wp_upload_dir() during sideloads, just as we do uploads. Ensures that sideloaded images make it into the right uploads directory. 
props solarisssmoke, fixes #16777.



git-svn-id: http://core.svn.wordpress.org/trunk@22105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-10-03 18:49:37 +00:00
Ryan Boren
82ae25da11 Respect ssl for the image src link in edit_form_image_editor(). see #21391 
git-svn-id: http://core.svn.wordpress.org/trunk@22093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-10-01 19:51:23 +00:00
Andrew Ozz
d62abf57d6 Fix "add media" icon in DFW for IE < 9, restore media-button.png, add media-button-2x.png and make them background images, see #21019 
git-svn-id: http://core.svn.wordpress.org/trunk@22077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-28 00:33:40 +00:00
Daryl Koopersmith
0c42e6121a Add QuickPress support for new media workflow. 
* Adds the code required to include the new media scripts, styles, and settings to `media_button()`.
* Improves script dependencies, namely making `media-upload` require `media-views`.
* Some CSS tweaks for the making the new button work well with QuickPress.

see #21390, fixes #22021.


git-svn-id: http://core.svn.wordpress.org/trunk@22072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-27 20:04:34 +00:00
Andrew Nacin
2cdd7b7840 Don't give a 'Beta Media' string to the translators that is only temporary. 
git-svn-id: http://core.svn.wordpress.org/trunk@22039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-27 05:19:34 +00:00
Daryl Koopersmith
eec758fd26 BUTTON. 
Add a "Beta Media" button to the post editor. Currently, it is only capable of inserting images. Other attachment types and galleries need not apply... yet.

* Added `wp.media.string.image( attachment, props )` for generating an image as a string from an attachment and relevant attachment display properties.
* Properly localized the gallery workflow.
* Added `Workflow.update()`, which closes the modal, triggers an `update` event, and resets the selection.
* Added `wp.mce.media` to manage the various media workflows for editors.

see #21813, #21814, #21390.


git-svn-id: http://core.svn.wordpress.org/trunk@22036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-27 04:09:43 +00:00
Andrew Nacin
1acd8b556f New HiDPI spinner. Uses clean <span class="spinner"></span> markup. 
Be on the lookout for weirdness.
props lessbloat. see #21456.



git-svn-id: http://core.svn.wordpress.org/trunk@22019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-26 19:57:44 +00:00
Andrew Ozz
1924ec4117 Add menu-vs-2x.png and 2x media-button.png, pngcrush all in wp-admin/images, props empireoflight, see #21019 
git-svn-id: http://core.svn.wordpress.org/trunk@21980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-24 19:44:42 +00:00
Andrew Nacin
33af30eb7f Use the regular post type UI for editing single media items (attachments). 
* Attachments now go through post.php, edit_post(), the like, and have show_ui set to true.
 * Taxonomies attached to the media library now appear in the admin menu (if show_ui).
 * Editing, cropping, uploading, etc. is still very rough, but mostly functional.

API-wise:
 * New function: get_taxonomies_for_attachments(). Like get_taxonomies(), for taxonomies specifically registered against attachments.
 * Brings taxonomy support from the posts list table to the media list table. Expect them to converge soon.
 * wp_insert_attachment() now handles taxonomies like wp_insert_post(). Also expect them to converge soon.
 * New edit_form_after_title hook.

props helenyhou, ocean90. see #21391.



git-svn-id: http://core.svn.wordpress.org/trunk@21948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-21 22:52:54 +00:00
Andrew Nacin
c1b0670c2d Updates and fixes to the new button styles. By default, buttons are now the same size as they were in 3.4. Then there is a smaller button (designed for minor elements) and a larger button (designed for things like Publish and Save Changes). Better focus styles. props lessbloat. see #21598. 
git-svn-id: http://core.svn.wordpress.org/trunk@21944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-21 19:34:23 +00:00
Andrew Nacin
52320dc5b3 It is 'Alternative Text', not 'Alternate Text'. props alecrust, RyanJKoehler. fixes #21176. 
git-svn-id: http://core.svn.wordpress.org/trunk@21917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-19 16:55:43 +00:00
Andrew Nacin
96d002c4dd Return term slugs rather than term names in attachment_fields_to_edit() as that is what we are dealing with. props eddiemoya, fixes #20765. 
git-svn-id: http://core.svn.wordpress.org/trunk@21889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-18 17:34:01 +00:00
Andrew Nacin
63f80ff4af Basic phpdoc for admin includes media.php. props c3mdigital. fixes #21144. 
git-svn-id: http://core.svn.wordpress.org/trunk@21871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-16 18:31:42 +00:00
Ryan Boren
f56d8278bb Remove return ref from all calls to get_post() 
Return WP_Post from get_default_post_to_edit()
Replace all calls to get_page() with get_post()
see #21309


git-svn-id: http://core.svn.wordpress.org/trunk@21597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-08-23 20:01:10 +00:00
Ryan Boren
15dd7f70b0 Remove post type from post nonces. Fixes attachment deletion when EMPTY_TRASH_DAYS is 0. Props c3mdigital, kurtpayne, SergeyBiryukov. fixes #21194 
git-svn-id: http://core.svn.wordpress.org/trunk@21504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-08-14 18:39:15 +00:00
ryan
44ef6d8e80 Deprecate and stub _media_button. fixes #21317 
git-svn-id: http://core.svn.wordpress.org/trunk@21353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-26 21:33:01 +00:00
ryan
1c175f829e Deprecate and stub _insert_into_post_button(). fixes #20427 
git-svn-id: http://core.svn.wordpress.org/trunk@21352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-26 21:30:06 +00:00
westi
4c33feb5ef Multisite: Tidy up [21256] and introduce/correct PHPDoc for a few other media upload functions. 
Fixes #21179 props SergeyBiryukov.


git-svn-id: http://core.svn.wordpress.org/trunk@21260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-11 10:20:15 +00:00
westi
2039e3a8f0 Multisite: Make it easy to replace or augment the over-quota message displayed when you try and upload new media and you have reached your quota. 
Fixes #21179 props dllh, jkudish. 


git-svn-id: http://core.svn.wordpress.org/trunk@21256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-10 13:33:44 +00:00
markjaquith
109768b788 Hide UI for Attachment taxonomies if show_ui is false for that taxonomy. props simonwheatley. fixes #21104 
git-svn-id: http://core.svn.wordpress.org/trunk@21240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-09 04:56:50 +00:00
markjaquith
6a1d888ea5 Better image extension regexes, so we don't just grab the "jpe" from "jpeg" files in media_sideload_image(). props sivel. fixes #16693 
git-svn-id: http://core.svn.wordpress.org/trunk@21219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-05 20:51:55 +00:00
nacin
a90957aca0 Inline documentation for image_attachment_fields_to_save(). props Moraleida.me. fixes #20803. 
git-svn-id: http://core.svn.wordpress.org/trunk@21171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-06-28 20:31:28 +00:00
ryan
6e030d2ed4 Preserve context when searching in the media upload form. Props SergeyBiryukov. fixes #20856 
git-svn-id: http://core.svn.wordpress.org/trunk@21008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-06-06 16:00:08 +00:00
azaozz
6499a905a3 Image captions: revert label change back to "Caption", fixes #18311 
git-svn-id: http://core.svn.wordpress.org/trunk@20826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-05-18 02:50:05 +00:00
ryan
fa13d2cf18 Update upload-html-bypass string to reflect that the uploader is no longer new. Props Ipstenu. fixes #20627 
git-svn-id: http://core.svn.wordpress.org/trunk@20735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-05-07 16:48:35 +00:00
azaozz
e8beafd57b Change the image caption shortcode format to [caption ...]<a><img /></a> caption text + html[/caption]. That way HTML tags in captions are better supported and the shortcode wouldn't break when using the wrong quotes. Props sushkov, nacin, fixes #18311 
git-svn-id: http://core.svn.wordpress.org/trunk@20679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-05-02 01:14:52 +00:00
azaozz
f58a801e62 Fix typo in the error message shown when a device doesn't support uploading, props SergeyBiryukov, fixes #20410 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-04-20 01:10:39 +00:00
azaozz
817b932ed1 Don't hide links to the upload form and show an error for mobile devices that cannot upload, see #20410 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-04-12 00:16:37 +00:00
azaozz
1d12cd07b0 Introduce wp_is_mobile() and use it instead of $is_iphone global, see #20014 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-04-10 01:19:30 +00:00
nacin
d5cc12048e Use _callback, rather than an unhelpful 2, for a preg_replace callback function name. Add proper phpdoc. see #20369. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-04-06 20:05:31 +00:00
duck_
1480a33d25 Simplify caption cleanup callbacks; if the function was called we know that the 0 index is set. See #20369. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-04-06 19:52:34 +00:00
azaozz
f06fb15878 Pluck a tab (whitespace), props SergeyBiryukov, see #20369 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-04-06 18:26:14 +00:00
azaozz
2441cb0cae Fix second callback when filtering caption text for shortcode, props SergeyBiryukov, fixes #20369 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-04-06 17:38:49 +00:00
ryan
d3134e2688 Allow selecting custom header and background images from the media library. Props aaroncampbell, sabreuse, greuben. fixes #19840 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-04-05 00:20:28 +00:00
nacin
a95f3d243a Revert label change in [20282]. see #18311. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-03-28 20:32:29 +00:00
markjaquith
dc82254e2f Wrap attachment delete link in <p> for semantics and alignment. props aaroncampbell, lancewillett. fixes #19785 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-03-28 20:28:34 +00:00
nacin
9cca792f6c Revert UI for caption fields to pre-[19982], keeping textarea for the caption field. No monospaced font, revert label. see #18311. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-03-24 13:37:42 +00:00
azaozz
3015057d58 Don't use class="code" for the captions textareas as it resets RTL, see #18311 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-03-21 22:48:36 +00:00
azaozz
ca3ab6c5c2 Add support for line breaks to the caption textareas, see #18311 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-03-14 21:53:11 +00:00
azaozz
f3b63e4537 Set proper HTML5 input types in the admin, props georgestephanis, fixes #17863 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-03-10 01:23:48 +00:00
azaozz
9f4408c741 Based on the current UX feedback, remove the "Insert Link" UI from under the caption fields, see #18311 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-03-05 07:31:31 +00:00
ryan
e4ce1046b0 Pass post id to get_upload_iframe_src() instead of relying on a global. Props tott. fixes #20003 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-02-27 19:23:03 +00:00
azaozz
73c87020c7 HTML in image captions, first run, see #18311 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-02-24 01:58:18 +00:00
nacin
bfeb575df9 Use relative paths for admin-ajax.php to avoid cross-domain issues with IDN domains in IE and Opera. props SergeyBiryukov, fixes #18952. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-02-08 16:12:11 +00:00
ryan
c924060858 Remove extraneuos newlines 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-21 18:42:11 +00:00
ryan
6bba5a265b Pinking shears 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-01 04:51:35 +00:00
azaozz
5ec6bd4833 Sanitize options for resizing in the uploader, props mhauan, nacin, fixes #19399 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-30 21:05:22 +00:00
azaozz
3fcae6d702 Output the "After a file has been uploaded..." message by using the post-upload-ui action, fixes #18764 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-21 20:46:15 +00:00
azaozz
6c38abc51d Show Insert into post button in the media library when the current post supports editor (not the attachment parent), props SergeyBiryukov, fixes #18912 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-19 04:28:39 +00:00
azaozz
7f9b0fcc1e Don't show the uploader on iPads (it's pointless), fixes #19004 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-18 08:43:16 +00:00
azaozz
af14c4fdb0 Change text prompt in HTML uploader, props jane, fixes #19276 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-18 01:25:27 +00:00
nacin
f0eebf3376 Remove extra space. props danielbachhuber. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-17 04:41:51 +00:00
azaozz
8f4fd39550 Add big-file-upload-warning for IE and Opera, left-align the percentage in the progress bar, see #19228 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-14 23:21:16 +00:00
azaozz
e09e8f465c Filter the link href when inserting external image in the editor, props DrewAPicture, fixes #18445 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-14 19:35:32 +00:00
azaozz
a491abfbb2 Media Lib: fix displaying file headers in IE7, delegate the Show/Hide JS, prevent displaying upload error for the same file twice, see #19228 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-13 18:37:30 +00:00
azaozz
7123026a3b Add error message when a big file fails to upload, expose the XHR request in plipload and abort() it, see #19228 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-13 02:01:13 +00:00
azaozz
9961962861 Uploader: fix file-size-exceeded error handling, see #18206 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-12 00:52:26 +00:00
nacin
64ab05ab09 Normal sentence case. see #19228. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-11 20:32:20 +00:00
azaozz
a37b440bac Bring back the multi-file/html uploader switching, see #19228 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-11 19:40:23 +00:00
ryan
61fca35691 Don't show 'Use as featured image' in the image insert dialog if the post type does not support thumbnails. Props SergeyBiryukov. fixes #18669 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-11 19:38:34 +00:00
azaozz
6074eda69d Uploader: fix progress bar JS and update the style (light blue bars), see #18206 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-10 20:33:26 +00:00
nacin
087eb4e30a Rename attachment link button from 'Post URL' to 'Attachment Post URL.' props jeremyclarke, fixes #13544. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-09 19:23:31 +00:00
azaozz
eca4184725 Revert media.php too, see #19174 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-08 22:42:20 +00:00
azaozz
623220187a Remove the Resize files checkbox for now (revisit in 3.4), fixes #19174 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-08 22:23:40 +00:00
nacin
534578f339 Space out two strings. props ocean90, fixes #19167. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-05 20:21:12 +00:00
azaozz
f7fa2684e8 Uploader: split "Drop files here -or-..." on two lines, see #18206 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-05 18:09:38 +00:00
azaozz
84a23bfd81 Remove the Cancel Upload button, fixes #19050 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-03 01:47:12 +00:00
azaozz
b63ffa3f38 Disable the Cancel Upload button after the upload has finished or if it was interrupted, fixes #19050 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-10-31 21:38:28 +00:00
ryan
62afab8db3 Pinking shears 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-10-24 19:13:23 +00:00
nacin
7ed04cc2f3 Deprecate media_upload_(image|audio|video|file)(), type_url_form_(image|audio|video|file)(). These now wrap wp_media_upload_handler() and wp_media_insert_url_form(). see #17578. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-10-23 17:58:06 +00:00
nacin
1387dfd1f2 Fix media/audio/file URL insertion. Strip slashes off title text. Leave red X to images only. fixes #14996. fixes #17578. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-10-18 19:32:40 +00:00
azaozz
e849d3b270 Use IE conditionals when adding the ie8 class, introduce _wp_admin_html_begin(), props scribu, fixes #18966 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-10-17 20:57:32 +00:00
duck_
6926503ebf Fix notices in wp_iframe() and iframe_header() by referencing $wp_htmltag_class as a global. See r18975 and #18314. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-10-15 10:43:55 +00:00
azaozz
0f2431e25a RTL, IE7 and IE7 RTL fixes, add class="ie8" to the html tag, see #18314 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-10-15 07:33:01 +00:00
azaozz
000208b86d Fix visibility of Select Files button in IE7, change border color when hovering over the drag drop area of the uploader, see #18918, see #18206 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-10-12 22:24:53 +00:00
azaozz
eb792ad204 Add translation comment, props ocean90, fixes #18881 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-10-08 03:14:41 +00:00
azaozz
7672731d95 Fix prepending $editor_id to the Add Media link, see #17578 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-10-07 19:12:55 +00:00
azaozz
18630a3d5a Add cap check before showing a link to image options, improved handling for translation, props SergeyBiryukov, see #18881 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-10-07 16:59:33 +00:00
azaozz
4878bc6ca0 As per the recommendations: make the text inside the files drop box larger, improve the explanation about the "resize image" checkbox, see #18206 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-10-06 09:57:50 +00:00
nacin
7afd7005aa Align the bytes. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-10-05 22:57:17 +00:00
nacin
330cf9d4a4 type_url_form_image() becomes wp_media_insert_url_form(), media_upload_image() becomes wp_media_upload_handler(). type_url_form_* and media_upload_* are restored as wrappers. Don't deprecate yet. see #17578. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-10-05 22:36:03 +00:00
nacin
593bce9f3e UI touches for the single media button. see #17578. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-10-05 21:07:04 +00:00
nacin
cb1477ecfd Merge the four media buttons into one. 
* Lots of red.
 * Removes the type_url_form_\$type filter, where \$type is audio, video, file, or image.
 * Replacement filter is a generic type_url_form_media filter for the new unified form.
 * Some functions have gone missing; they'll be restored and deprecated in a later pass.
see #17578.



git-svn-id: http://svn.automattic.com/wordpress/trunk@18831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-09-30 06:22:29 +00:00
azaozz
75432d53b0 Clean up remnants from having negative Post_IDs, props markjaquith, fixes #18235 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-09-29 21:47:52 +00:00
azaozz
fea5c38ef4 Add filter so the users can select custom image sizes added by themes and plugins, props alexkingorg, fixes #18520 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-09-28 17:27:48 +00:00
duck_
29c5eaadfd Remove extraneous closing script tag. Props ryanhellyer. See r18482, #18206. Fixes #18760. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18758 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-09-23 14:36:57 +00:00
azaozz
ae2219cd30 Update plupload to 1.5b and add "drop area" for drag and drop uploading, see #18206 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-09-18 02:25:23 +00:00
duck_
551198c5ca Don't obliterate $title if $desc isn't set. Props kawauso. Fixes #18185. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-09-17 18:27:32 +00:00
azaozz
2605391379 Improve handling of plupload init and add a filter, stop including cookies in the init (not needed with plupload), see #18206 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-09-15 05:30:58 +00:00
westi
0668193437 When inserting a Gallery to be ordered by Date/Time use the post_date field for ordering rather than ID so that if the user/plugin has updated this to reflect the date/time when an image was captured we order correctly. Fixes #17485 props SergeyBiryukov. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-08-24 11:37:25 +00:00
azaozz
1cdec6ff6e Merge most admin css files, first run, see #18314 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-08-21 03:46:43 +00:00
azaozz
9a65f6e237 Fix handling of resizing images after upload, props ocean90, see #18206 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-08-06 21:04:15 +00:00
azaozz
d012143326 Fix send_to_editor() and Insert/Upload buttons URLs, see #17144 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-08-06 01:35:02 +00:00
azaozz
f634dd5af4 Editor API enhancement, first run (still needs some work), see #17144 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-08-03 10:19:00 +00:00
azaozz
07bf8b352e Remove tabs from JS, props duck_, see #18206 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-07-31 08:44:29 +00:00
azaozz
34467767ff Add SWFUpload back for plugins that queue it directly, fix some escaping in media.php, see #18206 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-07-29 19:21:21 +00:00
azaozz
c5657820fb Remove debug bits, see #18206 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-07-29 09:03:24 +00:00
azaozz
91a8720fff Pluploader take 1, props jacobwg, see #18206 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-07-29 08:59:35 +00:00
azaozz
5256d7951f <!DOCTYPE html> for all, fixes #18202 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-07-22 00:25:41 +00:00
ryan
db253a3fe7 Perform a cap check on attachments in media_upload_form_handler(). For trunk 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-28 21:44:56 +00:00
ryan
593659b8d0 Hardening. Santizers for WPLANG and new_admin_email. Prevent stomping ID and filter. Validate locale filename. Props westi. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-27 15:56:42 +00:00
dd32
ed5785c9ef Only hide the browser uploader by default if the Flash uploader is enabled. Fixes #17772 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-12 12:47:18 +00:00
ryan
81a5f821fb Sanitize guid on save and display. Sanitize mime type on save. Don't allow changing mime type via edit form handlers. Protect hidden meta. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-05-22 23:19:42 +00:00
azaozz
33b0327924 Add JS detection to wp_iframe output, remove "display:none" from the Flash uploader button, props jacobwg, fixes #17473 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-05-19 16:12:13 +00:00
nacin
16e649f95f Remove type attribute from textarea. props solarissmoke. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-04-07 08:30:08 +00:00
ryan
924f783fda Add some nonce checks to the uploaders. Props duck_. For trunk. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-03-28 21:30:59 +00:00
ryan
498c93cb81 Revert [17327] and [15858]. Props markmcwilliams, JohnONolan, et al. see #16298 #8352 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-01-22 03:25:29 +00:00
ryan
55d6d8af12 PHP4 compat. Props SergeyBiryukov, westi. see #16080 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-01-03 19:19:34 +00:00
nacin
9009245db5 Tag textareas escaped earlier with textarea_escaped. see #15454. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-25 17:58:01 +00:00
westi
56584f6801 Ensure that images added using Press This get the correct source url set. Fixes #15841 props duck_. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-23 15:41:05 +00:00
nacin
e1eec3925a More @since. props SergeyBiryukov, fixes #15445. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-20 09:25:21 +00:00
ryan
3a66c698ee Remove some unnecessary esc_textarea() calls. Props garyc40. see #15454 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-16 17:48:20 +00:00
ryan
3949ce12d0 Pink trailing whites. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-13 21:21:50 +00:00
nacin
20bbf977a2 Fix the background colors for the Select Files upload buttons. props TECannon. fixes #8545. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-07 19:42:57 +00:00
nacin
fed2907095 Fix notice. props vericgar, fixes #11976. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-05 03:01:42 +00:00
scribu
c45f3936a7 More s/upgrade/update. Props michaelh. See #15656 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-03 09:16:28 +00:00
nacin
85c0930679 define isRtl in the media upload iframe. props filosofo, fixes #15639. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-02 12:44:48 +00:00
markjaquith
5f15bf9db2 Prevent media upload links from being clicked before lightbox is ready to handle them. fixes #15621 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-01 20:41:47 +00:00
ryan
3f72e340d6 Update since phpdoc. Props demetris. fixes #15445 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-01 19:24:38 +00:00
nacin
69b3167678 Revert [15688], [15689], [15691]. Try again in 3.2. see #14966. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-22 17:17:26 +00:00
ryan
07d265659b get_media_item_args, swfupload_post_params, and swfupload_success_handler filters. Props simonwheatley. fixes #13817 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-19 00:04:04 +00:00
nacin
931cecae63 Include a single-column option in gallery settings. props husobj, fixes #14836. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-18 03:30:55 +00:00
ryan
847499e531 Pinking shears 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-17 18:47:34 +00:00
markjaquith
6482610f9a esc_textarea() and application for obvious textarea escaping. props alexkingorg. fixes #15454 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-17 17:12:01 +00:00
scribu
2dcfb8a55f Make media_handle_sideload() return attachment id instead of URL. Props joostdevalk. Fixes #15432 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-15 12:53:11 +00:00
nacin
81a8f2d3ce Use square brackets instead of braces for string access. props hakre, fixes #13900. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-13 09:53:55 +00:00
nacin
fa3c017451 Use spaces for alignment. see #15343 [16236] 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-09 00:42:35 +00:00
westi
136df0f262 Encode quotes and chevrons in the HTML editor version of the generated captions too. Fixes #15343. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-08 17:15:14 +00:00
nbachiyski
9f5c506a9f Introduce and use translate_nooped_plural(). Fixes #13996 
* _n_noop() and _nx_noop() now return associative arrays for greater clarity
 * translate_nooped_plural() takes one such associative array and translates it
 * it works on both the result from _n_noop() and from _nx_noop()
 * this breaks backwards compatibility, but I doubt any plugin uses it (I will do a global grep to confirm)
 * translate_nooped_plural() is applied where applicable


git-svn-id: http://svn.automattic.com/wordpress/trunk@16073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-29 13:12:14 +00:00
markjaquith
fc6e89da45 Expand submit_button() capabilities. Replace all (or almost all) manual HTML instances in WP. props sbressler. see #15064 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-28 21:56:43 +00:00
ryan
2b86361848 Don't show private attachment taxonomies in the uploader. see #14746 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-28 18:53:09 +00:00
westi
39fceab5b4 Add a filter to the mime type list displayed in the iframe media uploader when viewing the media library. Fixes #6348 props wojtek.szkutnik 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-28 12:41:37 +00:00
ryan
779b8ff334 Default send to editor to true if the post parent is empty. Props blepoxp. fixes #14133 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-22 20:17:17 +00:00
nacin
54c498f974 Remove Lucida Grande from the sans serif font stack. fixes #8352, props iammattthomas. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-20 10:30:28 +00:00
nacin
4e666d5d44 Move some post and taxonomy functions from admin/includes to wp-includes in preparation for QuickPress template tag. Moves get_tags_to_edit, get_terms_to_edit, get_default_post_to_edit, media_buttons, _media_button, get_upload_iframe_src. Also introduce get_media_buttons as a wrapper for media_buttons. props jorbin, see #14966. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-03 02:58:59 +00:00
nacin
5a20c05d27 Phpdoc argument/@param cleanups. props duck_, see #14783. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-09-07 11:21:11 +00:00
dd32
fe89d62154 Fix typo in type_url_form_video() help text. Props mako09. Fixes #14003 for trunk 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-06-20 04:13:57 +00:00
markjaquith
100e81c448 Add ?ver=DATE query strings to all images that changed since 2.9, to expire browser cache. Bump versions on all CSS/JS files modified in that process. fixes #13562. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-31 06:33:46 +00:00
nbachiyski
8545387795 Prevent a notice if $_REQUEST['post_id'] is missing. Just use 0 in this case, which will be the same as using intval on an undefined value. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-27 11:42:46 +00:00
nacin
8845d1f61f Hide Flash uploader and theme/plugin editor documentation feature, if no JS. Also some validation fixes in the theme editor. props ocean90. see #13383. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-26 03:57:55 +00:00
markjaquith
e3ffb4c442 Update upload quota filled message to mention the limit and not suggest file deletion. fixes #13479 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-25 17:53:31 +00:00
nacin
427a63a92a s/onclick/onClick/. props Gazzer from wp-testers. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-24 05:15:55 +00:00
dd32
da25731eae We're not as bold as some people make us out to be. Move the maximum upload size from a Heading to a paragraph text. Fix screen formatting on Multisite when over quota. see #12853 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-21 12:57:49 +00:00
markjaquith
20cb3ed21b Add nonce protection for setting/removing featured post image. fixes #13438 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-18 22:08:49 +00:00
wpmuguru
80a8899c0b boldly go where no man has gone before, see #12853 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-16 18:44:51 +00:00
wpmuguru
be5268eefc show upload limit in media upload UI, see #12853 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-15 23:57:32 +00:00
nacin
54a46870d3 Escape slash in inline JS for SWFUploader. props zeo, see #13383. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-15 06:14:06 +00:00
nacin
c6d21e7fbb Introduce _ex(), a hybrid between _e() and _x() -- translate with context, then echo. props westi, see #13395. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-14 21:46:25 +00:00
nacin
518b19a404 esc_url the URL from get_upload_iframe_src. props jshreve, see #13383. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-14 15:03:59 +00:00
nacin
7bd274899d Append closing td/tr to output instead of directly echoing it. props jshreve, see #13383. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-14 01:54:21 +00:00
ryan
7b7243d94a Strip trailing whites. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-03 20:26:11 +00:00
ryan
172aa06718 Revert [14347] and [14372]. It broke more than we expected. Try again in 3.1. see #13051 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-03 18:16:22 +00:00
ryan
91354eefee Escape links by default. Props alexkingorg. see #13051 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-02 22:53:59 +00:00
dd32
18a81ac245 Use the correct field when determining if the parent can support the Post Editor. See #12792 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-18 09:09:45 +00:00
nacin
9b76fb2563 More tweaks for thumbnail support when no editor support for custom post types. see #12792, props scribu. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-16 21:45:16 +00:00
nacin
0de035558e Fix notice in get_media_items(). 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-10 12:49:58 +00:00
markjaquith
07a523894a Make thumbnail work for custom post types even if the editor is not being displayed. props scribu. fixes #12792 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-06 11:20:47 +00:00
dd32
ee058cca62 Change UI labels from "Post Thumbnails" to "Featured Image". See #12554 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-02 06:12:49 +00:00
dd32
949d9a0362 Do not add rel="attachment" for direct(File URL, not Post URL) links to non-media files in "Insert into Post". Fixes #7040 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-03-29 09:57:34 +00:00
nacin
8c8bf5039f Remove unnecessary ternary operators such as (expr) ? true : false. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-03-19 21:15:00 +00:00
nacin
20eae9d24a Use disabled() form helper. fixes #12581 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-03-11 17:12:23 +00:00
nacin
d6c51469c2 s/onClick/onclick/. props TobiasBg, see #12429 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-03-06 20:06:32 +00:00
dd32
9e31757e40 Display an Attachment Icon if an Attachment thumbnail is not available. Fixes display of Upload edit fields. Fixes #12328 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-03-06 08:00:42 +00:00
dd32
0c2e896156 A Better Flash upload button, Adds a Hover and Active styling, Adds a distinctive border to the button. Props ocean90. Fixes #12420 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-03-01 11:57:03 +00:00
nacin
093beae9f1 s/onClick/onclick/. props TobiasBg fixes #12429 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-28 19:39:06 +00:00
ryan
a55b30dcaf Pass overrides. Allow ref array calling. Props tychay. fixes #12278 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-22 16:54:51 +00:00
dd32
8e74ffb282 Allow Deletion of Media Alt text. Props reaperhulk. Fixes #11805 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-21 11:21:32 +00:00
nacin
00706d68ce Use admin_url() for images in wp-admin, to allow for filtering. Props mdawaffe, see #12300 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-20 21:09:49 +00:00
nacin
f58329a718 Improved IPTC and EXIF handling. Drag a wider net and also try to avoid numeric attachment slugs where possible. Props miqrogroove. See #11417 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-20 09:17:34 +00:00
nacin
d93a202841 Allow class/method array pair in wp_iframe() when checking callback name in determining whether to include media stylessheet. Props technosailor, fixes #11976 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-20 08:19:44 +00:00
dd32
679250491d Variable Cleanup, Unused variables, Typo'd variables, unused code blocks. Fixes #12299 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-20 02:01:46 +00:00
nacin
cfa428b8d2 Use stripos() instead of strpos() with strtolower(). For PHP < 5 we have stripos() in compat.php. Fixes #11176 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-14 02:27:19 +00:00
nacin
b4f362264e Don't use deprecated functions. see #11388 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-13 10:35:10 +00:00
markjaquith
ec16dee2f3 Revert quote swap from [12955]. Fixes media upload links. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-06 07:31:38 +00:00
ryan
a7e2f2533b Fix delete media nonces. Props nacin. fixes #12085 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-05 17:59:18 +00:00
ryan
79007568a6 Merge mu_media_buttons() into media_buttons(). see #11644 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-04 20:28:52 +00:00
ryan
f3939dd8fd Add wp-admin/includes/ms-deprecated.php. Deprecate wpmu_checkAvailableSpace. Introduce is_upload_space_available(). see #11762 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-01-25 19:46:24 +00:00
ryan
94859834fc i18n fixes. Props nbachiyski. fixes #11954 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-01-21 21:37:43 +00:00
ryan
6da55f7792 Trailing whitespace cleanup 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-01-15 22:11:12 +00:00
azaozz
3f3846e2fc Remove unneeded empty span and add form closing tag in media.php, props Simek and hakre, fixes #11569 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-30 08:19:34 +00:00
matt
1e15d7c64a More cleanup of the edit media screen: 
* Simplified table to not need rowspan, and other markup where possible.
* Put more elements in a paragraph tag for better spacing.
* Brought edit image buton under the image.
* Everything is now in line with WordPress Coding Standards, particularly with regards to spacing and attribute quotes.
* Minor styling for better alignment.

TODO: We show the file URL here, but for images we should show the URL to each size, with its dimensions.



git-svn-id: http://svn.automattic.com/wordpress/trunk@12543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-25 23:04:48 +00:00
matt
6f824a6b3e Media editing: When you have many custom taxonomies this page can get rather long, or just normally, so adding a "save" button to the top as well, for easy access. 
There was no place on this page that actually linked to the item being edited, so I hyperinked the thumbnail.


git-svn-id: http://svn.automattic.com/wordpress/trunk@12542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-25 22:22:21 +00:00
azaozz
066f37c885 Display "Dimensions" only for image attachments, fixes #11403 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-12 07:02:26 +00:00
azaozz
d4d309a1c6 Disable trash for attachments for now pending improvements in 3.0, fixes #11149 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-12 06:40:16 +00:00
markjaquith
805bdb9365 Provide visual feedback for "Use as thumbnail" when clicked immediately after uploading the image. fixes #11140 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-10 08:03:26 +00:00
markjaquith
8a3607998c Do not show "Use as thumbnail" in standalone media browser, but DO show it when you upload a new image on a post. fixes #11366 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-10 07:04:01 +00:00
markjaquith
bf264bb66d Post/Page Image was too generic a name. Post/Page Thumbnail is more clear, even if you can create very large thumbnail images if you so choose. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-10 06:14:36 +00:00
ryan
1c90385918 Allow registering post image support per post type. fixes #11364 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-09 15:39:20 +00:00
markjaquith
df73d335a9 Yet more standardization around Post/Page Image instead of Post/Page Thumbnail 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-08 21:27:53 +00:00
markjaquith
0415ab7b42 Standardize around "post image" instead of "post thumbnail" 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-08 16:34:04 +00:00
ryan
e5d2d65a36 Standardize on 'Undo'. Props caesarsgrunt. fixes #11299 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-01 20:00:33 +00:00
azaozz
fded0ca661 Remove oEmbed references and auto-insert of shortcodes from the UI, fixes #11288 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-01 09:22:48 +00:00
azaozz
8f3af1eb02 Hide Cancel link in the browser uploader on Media Library screen. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-11-30 20:58:12 +00:00
ryan
0874bf7d4f escape hrefs. Props Denis-de-Bernardy. fixes #10056 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-11-30 16:55:50 +00:00
azaozz
00a9b90dc9 Flash through red when sending an item to the trash, flash through green when undoing it, props caesarsgrunt, see #4529 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-11-28 02:56:15 +00:00
azaozz
281f46ecbd Fix typo, props nacin, fixes #8557 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-11-26 08:13:31 +00:00
ryan
6d1ba22c9d Fix warnings 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-11-20 19:46:10 +00:00
ryan
3e17d8b880 Remove reference to non-existent field. Props scribu. fixes #11098 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-11-20 15:26:14 +00:00
azaozz
c8dd53cdc3 Submit the "Save all changes" form by pressing Enter, props abackstrom, fixes #8557 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-11-20 06:07:54 +00:00
ryan
c831a9e3ef Add context to strings. Props nbachiyski. fixes #10738 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-11-19 22:49:16 +00:00
azaozz
95ee97e9ad Add labels to image info in the media library, fixes #8886 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-11-17 00:11:49 +00:00
azaozz
f53bef8bd9 Don't show trashed attachments in gallery tab count, props aldenta, fixes #11147 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-11-16 07:54:02 +00:00
azaozz
903ff7a22f Fix style of text fields in IE6 in the uploader, better regex for Link URL presets buttons 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-11-16 07:16:34 +00:00
azaozz
573c9fe1e4 Fix improper selection of radio buttons, improve JS for storing image settings, fixes #11021 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-11-16 01:37:30 +00:00
azaozz
fb1bb44d60 Remove all instances of "Trash" from the UI when Trash is disabled, replace trash actions with "Delete permanently", props caesarsgrunt, see #4529 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-11-10 10:38:19 +00:00
azaozz
1c24715413 Don't pre-fill empty image alt when inserting into a post. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-11-10 00:09:40 +00:00
ryan
41823a3171 Call get_post_image_id() only if current_theme_supports( 'post-thumbnails' ). 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-11-02 18:00:41 +00:00
azaozz
a55fd568d4 Trash undo for the uploader, props caesarsgrunt, see #4529 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-10-30 07:09:55 +00:00
markjaquith
34f36995f2 Consolidate post_mime_type code. props scribu. fixes #10992 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-10-26 17:56:28 +00:00
azaozz
f5c253376e When inserting the embed shortcode in TinyMCE replace it with a placeholder image, update the 'wordpress', 'wpeditimage' and 'wpgallery' TinyMCE plugins, fix the audio and video "From URL" tabs in the uploader popup to accept only URLs for embedding, see #10337 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-10-24 11:43:42 +00:00
markjaquith
0bb1056228 Save some clicks and optimize for the Upload, Set as thumbnail flow. props scribu. see #10928 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-10-21 07:27:33 +00:00
azaozz
76f6b9706e Merge set-post-thumbnail-handler.js with post.js, move Post Thumbnail meta-box to /includes/meta-boxes.php, see #10928 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-10-19 20:23:35 +00:00
markjaquith
d3f3b6bed1 Only show Use for thumbnail link for image attachments. see #10928 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-10-19 16:36:21 +00:00
azaozz
7e9d95d543 Separate fields for image alt and image caption in the uploader. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-10-19 05:09:41 +00:00
azaozz
9783a2415a Properly escape filename when sending to editor, props hakre sivel, fixes #10252 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-10-18 06:14:16 +00:00
markjaquith
af407e7e3f Post thumbnail removal functionality (only allowed for replacement before). props scribu. see #10928 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-10-15 12:57:16 +00:00
markjaquith
a0cd792aae Constrain admin thumbnail display to width of meta box while in sidebar. Add filters. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-10-10 07:41:42 +00:00
markjaquith
d7a30e235f First pass on canonical post thumbanils. Admin-side GUI only. Theme functions to follow. see #10928 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-10-07 22:18:09 +00:00
ryan
d89bf58bd3 Pass args to mysql2date() in the correct order. Props filosofo, fabifott. fixes #10866 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-10-01 17:50:28 +00:00
azaozz
48932f96fe Image Editor improvements, see #10528 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-09-24 01:54:07 +00:00
ryan
607ec769f0 Press This fixes. Props noel. fixes #10784 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-09-17 20:36:59 +00:00
azaozz
1c161c23c2 Image editing (first run). Includes code by stephanreiter, see #10528 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-09-10 22:07:33 +00:00
ryan
e8c32c03b0 Pass logged_in cookie to async-upload. Props nbachiyski. fixes #10739 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-09-08 15:22:42 +00:00
westi
499a4d63cc Always filter the url in the media upload form. Fixes #10707 props nbachiyski. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-09-01 20:44:17 +00:00
azaozz
a50bce6e70 Add global JS vars and actions to the media uploader iframe 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-08-24 00:09:39 +00:00
azaozz
be026258fa "Trash" updates, props caesarsgrunt, see #4529 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-08-19 08:35:24 +00:00
azaozz
39e4f05a15 Trash status updates for posts, pages, comments and attachments, props caesarsgrunt, see #4529 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-07-30 13:39:34 +00:00
westi
a809b6a57f Fix typo in type_url_from_video() link text description. Fixes #10071 props Denis-de-Bernardy. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-07-09 21:21:57 +00:00
ryan
2f090d1e30 Don't lose upload error messages. Props filosofo. fixes #10238 for trunk 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-06-25 06:09:22 +00:00
westi
897f52c524 Remove the cruft. Fixes #10227 for trunk props sirzooro. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-06-20 18:50:31 +00:00
azaozz
6615e5390c Fix the flash uploader button font, props demetris, fixes #10113 for trunk 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-06-13 09:37:19 +00:00
westi
0de9090898 Ensure the errors array is always defined so as to always have something to return 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-30 09:55:32 +00:00
azaozz
0fc93e28fd Trim white space 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-26 22:42:23 +00:00
azaozz
51e5201348 Fix the inserting of caption shortcode when the upload path contains "align" 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-26 22:33:02 +00:00
ryan
2df887bd07 Trim tailing whitespace 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-24 23:47:49 +00:00
markjaquith
3ebf837ced Deprecate sanitize_url() and clean_url() in favor of esc_url_raw() and esc_url() 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-18 16:00:33 +00:00
markjaquith
119b39cec2 deprecate wp_specialchars() in favor of esc_html(). Encode quotes for esc_html() as in esc_attr(), to improve plugin security. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-18 15:11:07 +00:00
azaozz
697923e9f0 Update SWFUpload to 2.2.0.1, see #9413 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-17 12:29:58 +00:00
markjaquith
bdf8e8fb38 Use a semantic class name for text targeted to screen readers. props filosofo. fixes #9791 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-12 22:40:56 +00:00
ryan
e8025581b3 Revert line that breaks browser uploader 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-08 20:45:04 +00:00
azaozz
a1bb97313f Cast to string in array_key_exists() in media.php, props lusuonline, fixes #9749 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-07 17:28:51 +00:00