desrosj
82b673d043
Site Health: Revert [46323-46325] for further discussion of how the admin email verification should be filtered.
...
See #48153 .
Built from https://develop.svn.wordpress.org/trunk@46361
git-svn-id: http://core.svn.wordpress.org/trunk@46160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 18:53:00 +00:00
Andrea Fercia
f86d225d26
Accessibility: Improve and modernize user interface controls: Improve new styles for the color picker.
...
Props audrasjb, garrett-eclipse.
Fixes #48131 .
Built from https://develop.svn.wordpress.org/trunk@46360
git-svn-id: http://core.svn.wordpress.org/trunk@46159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 18:05:59 +00:00
antpb
6531c237e7
Media: Prevents clipping of text when scaling image edit screen.
...
This reapplies [46354] clean as the previous commit had remnants of an unrelated patch.
Props sabernhardt, audrasjb, afercia.
See #47115 .
Built from https://develop.svn.wordpress.org/trunk@46359
git-svn-id: http://core.svn.wordpress.org/trunk@46158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 17:56:57 +00:00
desrosj
ae29987a17
Site Health: Improve the message displayed to sites not utilizing HTTPS.
...
The new message better illustrates that there are many potential benefits of using HTTPS, not just a few.
Props garrett-eclipse, dkarfa, ocean90, afragen, desrosj.
Fixes #48118 .
Built from https://develop.svn.wordpress.org/trunk@46358
git-svn-id: http://core.svn.wordpress.org/trunk@46157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 17:54:58 +00:00
desrosj
2abcce6dfc
Bundled Themes: Update Twenty Twenty.
...
This brings `trunk`’s version of Twenty Twenty in-sync with GitHub.
For a complete list of changes since [46271], see 932b16248...dd7032f
Props anlino, ianbelanger, nielslange, acosmin, netweb, williampatton, adhitya03, phpdocs, acalfieri, itowhid06, littlebigthing, aristath, karmatosed, poena.
See #48110 .
Built from https://develop.svn.wordpress.org/trunk@46357
git-svn-id: http://core.svn.wordpress.org/trunk@46156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 17:41:57 +00:00
Andrea Fercia
6566808e8a
Accessibility: Improve and modernize user interface controls: Improve the new form controls styles and heights.
...
Improves cross-browsers rendering and addresses most of the reported edge cases.
See #47477 .
Built from https://develop.svn.wordpress.org/trunk@46356
git-svn-id: http://core.svn.wordpress.org/trunk@46155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 17:24:59 +00:00
antpb
247e7eb7d5
Media: Revert [46354] preventing bad clipping of text in image details page.
...
See #47115 .
Built from https://develop.svn.wordpress.org/trunk@46355
git-svn-id: http://core.svn.wordpress.org/trunk@46154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 17:12:59 +00:00
antpb
7c8028febf
Media: Prevents clipping of text when scaling image edit screen.
...
Props sabernhardt, audrasjb, afercia.
See #47115 .
Built from https://develop.svn.wordpress.org/trunk@46354
git-svn-id: http://core.svn.wordpress.org/trunk@46153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 16:34:58 +00:00
Andrew Ozz
38e6958698
Media: Move wp_get_original_image_path()
to wp-content/post.php
to make it easier to access from plugins.
...
Props pbiron.
See #47873 .
Built from https://develop.svn.wordpress.org/trunk@46353
git-svn-id: http://core.svn.wordpress.org/trunk@46152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 16:28:59 +00:00
desrosj
7d667995b4
Built/Test Tools: Ignore the node_modules
folder in Twenty Twenty.
...
Ignore the `node_modules` folder in Twenty Twenty in SVN, and when running `grunt build` or `grunt jshint:themes`.
See #48110 .
Built from https://develop.svn.wordpress.org/trunk@46352
git-svn-id: http://core.svn.wordpress.org/trunk@46151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 15:59:00 +00:00
desrosj
abff73f0e0
Docs: Correct WP_Styles_Registry
documentation.
...
This change updates the file’s docblock to correctly indicate `WordPress`/`Blocks` as the `@package`/`@subpackage`, updates the `_doing_it_wrong()` versions to `5.3.0` instead of the Gutenberg plugin versions, and removes some stray `gutenberg` text domains.
Props david.binda.
Fixes #48181 .
Built from https://develop.svn.wordpress.org/trunk@46351
git-svn-id: http://core.svn.wordpress.org/trunk@46150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 15:44:59 +00:00
Andrea Fercia
20e781f44d
Accessibility: Improve and modernize user interface controls: Remove the CSS transform 1 pixel shift from the buttons active state.
...
Props Joen.
See #34904 .
Built from https://develop.svn.wordpress.org/trunk@46350
git-svn-id: http://core.svn.wordpress.org/trunk@46149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 10:53:57 +00:00
Sergey Biryukov
2afdc64723
Comments: Add rel="nofollow ugc"
attribute to links in comments.
...
UGC stands for User Generated Content, and the `ugc` attribute value is recommended for links within user generated content, such as comments and forum posts.
See https://webmasters.googleblog.com/2019/09/evolving-nofollow-new-ways-to-identify.html .
Props audrasjb, joostdevalk, dkarfa, SergeyBiryukov.
Fixes #48022 .
Built from https://develop.svn.wordpress.org/trunk@46349
git-svn-id: http://core.svn.wordpress.org/trunk@46148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 01:30:58 +00:00
desrosj
8cb7c5c764
Upgrade/Install: Fix the Install Now button in the plugin overlay when running WordPress on a specific port.
...
Props garrett-eclipse, pierlo, afragen.
Fixes #48077 .
Built from https://develop.svn.wordpress.org/trunk@46348
git-svn-id: http://core.svn.wordpress.org/trunk@46147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 00:05:57 +00:00
Sergey Biryukov
6e25a991a6
Twenty Nineteen: Remove trailing comma after selector in sass/site/primary/_posts-and-pages.scss
.
...
Props itowhid06.
Fixes #48171 .
Built from https://develop.svn.wordpress.org/trunk@46347
git-svn-id: http://core.svn.wordpress.org/trunk@46146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-29 22:40:57 +00:00
Sergey Biryukov
736403a26e
REST API: Combine array
and object
cases in WP_REST_Meta_Fields::get_default_for_type()
to remove duplicated line.
...
Add missing description for `$type` parameter.
Props itowhid06, dkarfa.
Fixes #48169 .
Built from https://develop.svn.wordpress.org/trunk@46346
git-svn-id: http://core.svn.wordpress.org/trunk@46145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-29 22:34:57 +00:00
Andrea Fercia
dfcdb40c8f
Accessibility: Improve and modernize user interface controls: Improve the radio buttons blue dot alignment.
...
Props desrosj, garrett-eclipse, afercia.
See #47498 .
Built from https://develop.svn.wordpress.org/trunk@46345
git-svn-id: http://core.svn.wordpress.org/trunk@46144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-29 21:56:56 +00:00
Andrea Fercia
8ef586a897
Accessibility: Improve and modernize user interface controls: Make the secondary buttons border blue.
...
Props drw158, youknowriad, kjellr, melchoyce, talldanwp, audrasjb.
See #34904 .
Built from https://develop.svn.wordpress.org/trunk@46344
git-svn-id: http://core.svn.wordpress.org/trunk@46143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-29 21:53:57 +00:00
Sergey Biryukov
7da7edbc57
Coding Standards: Remove inline assignments and extra whitespace in tests/multisite/network.php
.
...
Props garrett-eclipse, jrf.
See #48142 .
Built from https://develop.svn.wordpress.org/trunk@46343
git-svn-id: http://core.svn.wordpress.org/trunk@46142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-29 12:22:57 +00:00
Sergey Biryukov
7a91c1ee74
Docs: Improve comments in tests/multisite/network.php
per the documentation standards.
...
Props garrett-eclipse, jrf.
See #48142 .
Built from https://develop.svn.wordpress.org/trunk@46342
git-svn-id: http://core.svn.wordpress.org/trunk@46141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-29 12:19:57 +00:00
Sergey Biryukov
5f2c7142a1
Docs: Improve documentation for ::display()
methods in various list tables.
...
Props itowhid06.
Fixes #47947 .
Built from https://develop.svn.wordpress.org/trunk@46341
git-svn-id: http://core.svn.wordpress.org/trunk@46140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-29 11:04:58 +00:00
Andrea Fercia
55b1dc642e
Accessibility: After [46337]: make the select elements background white also on hover, active, and focus states.
...
See #47477 .
See #48128 .
Built from https://develop.svn.wordpress.org/trunk@46340
git-svn-id: http://core.svn.wordpress.org/trunk@46139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-28 16:45:57 +00:00
Andrea Fercia
7d769a9234
Accessibility: Improve and modernize user interface controls. Style the select elements disabled state.
...
Props adhitya03, MarcosAlexandre, kjellr.
See #47477 .
Fixes #48129 .
Built from https://develop.svn.wordpress.org/trunk@46339
git-svn-id: http://core.svn.wordpress.org/trunk@46138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-28 16:35:59 +00:00
Andrew Ozz
dd44ab5a58
Fix the context (right-click) menu when clicking the placeholder for the post title field on the classic Edit Post screen.
...
Props masummdar, audrasjb, afercia.
Fixes #47318 .
Built from https://develop.svn.wordpress.org/trunk@46338
git-svn-id: http://core.svn.wordpress.org/trunk@46137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-28 16:20:57 +00:00
Andrea Fercia
becc682bcf
Accessibility: Improve and modernize user interface controls. Make the select elements background white.
...
Props adhitya03.
See #47477 .
Fixes #48128 .
Built from https://develop.svn.wordpress.org/trunk@46337
git-svn-id: http://core.svn.wordpress.org/trunk@46136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-28 16:15:59 +00:00
Sergey Biryukov
07a753cb35
Docs: Add documentation for WP_Comments_List_Table::display()
.
...
Props itowhid06, dinhtungdu.
Fixes #47929 .
Built from https://develop.svn.wordpress.org/trunk@46336
git-svn-id: http://core.svn.wordpress.org/trunk@46135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-27 23:03:58 +00:00
whyisjake
d4c6ebeb89
Comments: Avoid PHP notice in get_comment_reply_link()
for null
comment.
...
If there is no global comment, or the input comment is null, return early to prevent warnings.
Fixes #41846
Props birgire, earnjam
Built from https://develop.svn.wordpress.org/trunk@46335
git-svn-id: http://core.svn.wordpress.org/trunk@46134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-27 14:46:57 +00:00
Andrea Fercia
188416bd55
Login and Registration: Revert divs and restore paragraphs after [46256].
...
Fixes #42888 .
Built from https://develop.svn.wordpress.org/trunk@46334
git-svn-id: http://core.svn.wordpress.org/trunk@46133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 22:20:56 +00:00
whyisjake
304c19dbac
Options: register_uninstall_hook()
causes large amounts of unnecessary option updates.
...
Prevent extra database read/writes from the the hook.
Props jeichorn, MikeHansenMe, DrewAPicture, Rahe, tha_sun, mikeschroder.
Fixes #31792 .
Built from https://develop.svn.wordpress.org/trunk@46333
git-svn-id: http://core.svn.wordpress.org/trunk@46132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 22:08:57 +00:00
whyisjake
b6f7c0cbc4
Administration: Ensure visual consistency with large titles in the sidebar.
...
Custom posts, and other menu titles that are long aren't wrapping correctly.
Props jagirbaheshwp, munyagu, harshbarach, hareesh-pillai, pratikkry, naveenkharwar, mukesh27, dushanthi, worldweb, audrasjb
Fixes #42201
Built from https://develop.svn.wordpress.org/trunk@46332
git-svn-id: http://core.svn.wordpress.org/trunk@46131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 21:51:57 +00:00
Andrea Fercia
66dd6814e7
Media: Restore the original Image Editor columns layout after [46326].
...
Fixes #47116 .
Built from https://develop.svn.wordpress.org/trunk@46331
git-svn-id: http://core.svn.wordpress.org/trunk@46130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 20:37:57 +00:00
whyisjake
c034f5b4c3
Menus: Replace http with https in placeholders.
...
Encourage the use of https with the placeholder text in menus.
Fixes #46312
Props aksl95, audrasjb, celloexpressions, SergeyBiryukov, jorbin.
Built from https://develop.svn.wordpress.org/trunk@46330
git-svn-id: http://core.svn.wordpress.org/trunk@46129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 20:32:55 +00:00
Sergey Biryukov
1d334b273e
Tests: Correct ::assertArrayHasKey()
capitalization in [46252].
...
Props dkarfa, david.binda.
Fixes #48155 .
Built from https://develop.svn.wordpress.org/trunk@46329
git-svn-id: http://core.svn.wordpress.org/trunk@46128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 20:31:58 +00:00
John Blackbourn
f73a22a98a
Themes: Add a test to ensure get_template_part()
does not return a value.
...
This function must not be modified to return anything due to existing themes which output the return value, for example via `echo get_template_part( ... )`.
See #40969
Built from https://develop.svn.wordpress.org/trunk@46328
git-svn-id: http://core.svn.wordpress.org/trunk@46127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 20:26:59 +00:00
whyisjake
3c0f10e397
Themes: Docblock cleanup for get_theme_root_uri()
...
In the function docblock of `get_theme_root_uri()`, the argument types of `$stylesheet_or_template` and `$theme_root` do not match. Default values of arguments are boolean but in function doc they are stated as strings.
Props subrataemfluence, williampatton, garrett-eclipse.
Fixes #44397 .
Built from https://develop.svn.wordpress.org/trunk@46327
git-svn-id: http://core.svn.wordpress.org/trunk@46126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 20:21:58 +00:00
Andrea Fercia
93dd6d907a
Accessibility: Media: Make the Image Editor buttons text visible.
...
User interface controls that use only icons aren't ideal for many users.
Universal icons are rare. Icons must communicate meaning but their actual meaning varies depending on many factors including the users cultural background.
Moreover, users with cognitive impairments and speech recognition users need interface controls with visible text to be able to operate them.
- shortens some of the buttons text to: Rotate left, Rotate right, Flip vertical, Flip horizontal
- moves the Undo and Redo buttons underneath the main buttons group
Props nrqsnchz, melchoyce, karmatosed, sabernhardt, mikeschroder.
Fixes #47116 .
Built from https://develop.svn.wordpress.org/trunk@46326
git-svn-id: http://core.svn.wordpress.org/trunk@46125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 17:16:57 +00:00
desrosj
8affbd6404
Docs: Correct typos introduced in [46324]
...
Props TimothyBlynJacobs.
See #48153 .
Built from https://develop.svn.wordpress.org/trunk@46325
git-svn-id: http://core.svn.wordpress.org/trunk@46124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 16:32:58 +00:00
desrosj
1e8ed99eca
Site Health: Consolidate documentation for the admin_email_check_interval
filter.
...
See #48153 .
Built from https://develop.svn.wordpress.org/trunk@46324
git-svn-id: http://core.svn.wordpress.org/trunk@46123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 15:45:58 +00:00
desrosj
0f99e345fa
Site Health: Allow the capability required for the site admin email verification screen to be filtered.
...
Props desrosj, Clorith.
Fixes #48153 .
Built from https://develop.svn.wordpress.org/trunk@46323
git-svn-id: http://core.svn.wordpress.org/trunk@46122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 15:41:57 +00:00
Sergey Biryukov
8bb8e77ace
Code Modernisation: Introduce the spread operator in do_action()
.
...
Rather than relying on `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@46322
git-svn-id: http://core.svn.wordpress.org/trunk@46121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 13:53:58 +00:00
Andrea Fercia
abb00ee8a4
Media: Fix JavaScript TypeError after [45376].
...
Props desrosj, afercia.
Fixes #48021 .
Built from https://develop.svn.wordpress.org/trunk@46321
git-svn-id: http://core.svn.wordpress.org/trunk@46120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 13:06:56 +00:00
Gary Pendergast
2a8854ca9d
Build Tools: Pass the current uid/gid to Docker containers.
...
This prepares for an upcoming change to the Docker images, which improves file permission handling.
See #47767 .
Built from https://develop.svn.wordpress.org/trunk@46320
git-svn-id: http://core.svn.wordpress.org/trunk@46119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 04:58:58 +00:00
Sergey Biryukov
0a5cd17f98
Login and Registration: Standardize on 6 * MONTH_IN_SECONDS
over 180 * DAY_IN_SECONDS
for admin_email_check_interval
filter.
...
[45788] changed the first instance, but not the second.
Props tmatsuur.
Fixes #48144 .
Built from https://develop.svn.wordpress.org/trunk@46319
git-svn-id: http://core.svn.wordpress.org/trunk@46118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 02:29:58 +00:00
Sergey Biryukov
8ef4150dc6
REST API: Use delta comparison for floating date test added in [46279] to avoid race conditions.
...
See #48113 .
Built from https://develop.svn.wordpress.org/trunk@46318
git-svn-id: http://core.svn.wordpress.org/trunk@46117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 01:40:58 +00:00
Sergey Biryukov
da8ebc6fc9
Coding Standards: Remove inline assignment in test_wp_delete_term_should_invalidate_cache()
.
...
See #48142 .
Built from https://develop.svn.wordpress.org/trunk@46317
git-svn-id: http://core.svn.wordpress.org/trunk@46116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 01:34:58 +00:00
Sergey Biryukov
6e8f550770
General: Correct strict comparison in WP_Links_List_Table::column_categories()
introduced in [46313].
...
`$cat_id` is a string, `$category` is an integer.
See #48142 .
Built from https://develop.svn.wordpress.org/trunk@46316
git-svn-id: http://core.svn.wordpress.org/trunk@46115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 01:24:56 +00:00
Sergey Biryukov
148322a970
Docs: Improve documentation for _post_states()
and get_post_states()
.
...
Add documentation for `_media_states()`.
See #47110 .
Built from https://develop.svn.wordpress.org/trunk@46315
git-svn-id: http://core.svn.wordpress.org/trunk@46114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 00:57:58 +00:00
whyisjake
a351243928
General: Further phpcs cleanup.
...
In [46312] and [46313] we attempted to do some phpcs cleanup. This commit cleans up three issues that were introduced in [46309].
Fixes #48142 .
Props: whyisjake, garrett-eclipse, desrosj
Built from https://develop.svn.wordpress.org/trunk@46314
git-svn-id: http://core.svn.wordpress.org/trunk@46113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 00:37:58 +00:00
whyisjake
d53b773a47
General: Further phpcs cleanup.
...
In [46312] we attempted to do some `phpcs` cleanup. This commit cleans up three issues that were introduced in [46309].
Fixes #48142 .
Props whyisjake, garrett-eclipse.
Built from https://develop.svn.wordpress.org/trunk@46313
git-svn-id: http://core.svn.wordpress.org/trunk@46112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-25 23:38:57 +00:00
whyisjake
38dc032e66
General: Linter cleanup
...
`phpcbf` was able to clean up a few files. Tests were breaking as a result of code formatting.
Fixes #48142
Props whyisjake
Built from https://develop.svn.wordpress.org/trunk@46312
git-svn-id: http://core.svn.wordpress.org/trunk@46111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-25 22:53:58 +00:00