Commit Graph

63 Commits

Author SHA1 Message Date
nacin
2c789f296a Make current_screen an action, not a filter. see #18785.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 03:34:55 +00:00
nacin
a16fe7f86f Deprecate add_contextual_help() for get_current_screen()->add_help_tab(). fixes #19020.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 03:29:55 +00:00
nacin
02dfdbbbf4 s/Screen Info/Overview/g, see #19020.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 00:34:31 +00:00
nacin
5b248a72c8 'Overview' for old-style help tabs, not 'Screen Info.' props jane. see #19020.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-30 20:58:39 +00:00
nacin
65fde75e85 WP_Screen: Whitelist -new and -add screens, and prevent edit-comments and edit-tags from being mashed on. fixes #19353.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-28 22:58:51 +00:00
nacin
f9ee8ccfd2 Use a scalpel to dissect names passed to convert_to_screen(). Carefully watch for post type names, suffixes we need to detect and remove, and when we need to remove 'edit-' from the start of a hookname. see #19353.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-28 18:33:40 +00:00
koopersmith
5ff76fd777 Remove help sidebar background when no sidebar exists. props chrisbliss18, see #18197, [19361].
git-svn-id: http://svn.automattic.com/wordpress/trunk@19430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-23 22:14:03 +00:00
ryan
ff358379c9 Move convert_to_screen() back to template.php to avoid fatal errors with plugins and themes that direct include template.php into the front end. Flag this bad behavior with _doing_it_wrong(). Props nacin. fixes #19342
git-svn-id: http://svn.automattic.com/wordpress/trunk@19428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-23 21:29:33 +00:00
nacin
dd697967bf Change show/hide storage mechanism for show_welcome_panel. 0 = hide, 1 = show, 2 = show if the multisite owner. Make welcome panel dismissable without JS (openable too via the URL). fixes #19338, fixes #19127.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-23 18:30:45 +00:00
nacin
5f60ab4076 Remove $post_type global usage from media list table. Correct $post_type to 'attachment' for upload screens. see #18722.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-21 20:48:57 +00:00
koopersmith
c65d96de08 Help tabs: remove scrollbar and max-height. see #19155.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-20 01:03:17 +00:00
ryan
66388c185e Don't fallback to default post type or taxonomy if given an invalid post type or taxonomy. Use typenow as the canonical post type. Props nacin. see #19131
git-svn-id: http://svn.automattic.com/wordpress/trunk@19321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-17 18:01:08 +00:00
nacin
ab5f3aa79c Remove default help text. Keep the default_help filter in place for plugins. fixes #19154.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-06 18:13:06 +00:00
nacin
31c84c9d7b Use call_user_func_array() as call_user_func() cannot pass by reference. see #18785.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-04 15:06:11 +00:00
nacin
0a825c74be Pass $tab array to callback execution for help tabs. see #18785.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-04 15:04:58 +00:00
nacin
9741ce2773 Allow is_network and is_user to work for all screen instances. see #18785.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-03 23:00:46 +00:00
azaozz
8454367edf Revert the look and functionality of Screen Options ans Help links/tabs, see #18197, see #18785
git-svn-id: http://svn.automattic.com/wordpress/trunk@19131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-03 20:26:09 +00:00
azaozz
f73e6b3228 Revert placement of Help and Screen Options to under the admin bar on the right, see #18197, see #18785
git-svn-id: http://svn.automattic.com/wordpress/trunk@19130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-03 17:08:12 +00:00
nacin
bfb98c193e s/add_help_sidebar/set_help_sidebar/g and introduce screen->remove_help_tab($id) and screen->remove_help_tabs(). see #19020, #18785.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 20:14:10 +00:00
nacin
3932addc50 Reverse variable assignment order. D'oh. see #19108.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 04:24:17 +00:00
nacin
6c9e82de0a Use more obvious variables in WP_Screen. see #18785.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-01 21:36:04 +00:00
nacin
13db43d2d3 Always run the old contextual_help filter. see #18785.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-31 21:37:43 +00:00
nacin
29e469f151 Consistently set taxnow/typenow and the current screen's post_type/taxnomy, whenever it can be detected. Allow WP_Screen::get() to accept a post type as a hook_name. Fixes issues with the meta box $page/$screen argument. fixes #19080. see #18785.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-31 21:28:17 +00:00
nacin
aa6eb9729a Fix copypasta in in WP_Screen. see #19095, props SergeyBiryukov.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-31 16:57:29 +00:00
nacin
1e6e52e1c1 Add missing keyword. fixes #19046, see #18785.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-25 16:05:39 +00:00
nacin
68225fdf13 Make convert_to_screen() more resilient. see #18785.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-25 06:54:23 +00:00
ryan
62afab8db3 Pinking shears
git-svn-id: http://svn.automattic.com/wordpress/trunk@19054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-24 19:13:23 +00:00
ryan
ad3eb8f7ab Fallback to the default post type only if it is registed for the taxonomy. Props nacin. see #18785
git-svn-id: http://svn.automattic.com/wordpress/trunk@19053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-24 19:10:56 +00:00
nacin
12de7d1e2d Move WP_Screen to a full registry. Have convert_to_screen() return a WP_Screen object. Improve and verify values for post_type and taxonomy. see #18785. also fixes #14886.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-24 18:34:08 +00:00
nacin
29f6c203cd screen.php tidying. Doc fixes and improvements. Improve logic in ::show_screen_options(). Remove regex in ::set_parentage(). Better variable names. Streamline get_screen_icon(). Whitespace. see #18785.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-24 06:40:15 +00:00
nacin
a4a58839d0 Deprecate favorite_actions(). see #18785.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-24 06:10:36 +00:00
nacin
c62a9fe508 Rework get_hidden_meta_boxes() to leverage a full WP_Screen object. Prevents custom post types from having their explicity supported meta boxes being hidden by default. see #18958.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-23 19:22:27 +00:00
nacin
11a800a3d9 Move welcome panel link to a 'Show on screen' checkbox. see #11651.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-19 21:43:21 +00:00
nacin
936107846c Restore object handling in add_contextual_help(). see #18785.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-12 16:24:55 +00:00
nacin
aa06a7de9f Don't instantiate WP_Screen in convert_to_screen() for now. see #18785.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-12 16:22:50 +00:00
nacin
07a664da92 Restore $screen argument for contextual_help* filters. see #18785.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-11 21:45:28 +00:00
nacin
7bf1ec1a01 Store screen help and options as static data against WP_Screen. Individual screen objects no longer hold data it can't re-generate on construction or otherwise fetch. convert_to_screen() now returns a WP_Screen object. Various globals are gone. Introduces WP_Screen::get_option(). Allows for a formal factory to be introduced later. see #18785.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-11 21:32:16 +00:00
nacin
35dd66044a Enforce IDs for add_help_tab(). props mbijon. Restore default_contextual_help, for now. see #18785.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-11 19:29:09 +00:00
nacin
50078431dc Use local method when handling back compat screen layout column filter. The function serves as a wrapper for but one object. see #18785.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-07 05:26:44 +00:00
nacin
850ea83baf Move the Screen Options tab to the top and introduce a new 'overview' screen option, which accepts content for the top of this tab. see #18785.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-07 05:23:33 +00:00
nacin
cc199b6358 Remove redundant help tab title from the tab body. see #18785.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-07 05:00:38 +00:00
nacin
795ca8d394 Revert [18861], [18862], [18864], [18874], [18879], and [18880]. see #18785.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-07 04:57:12 +00:00
koopersmith
fb31c6f302 Refine new help styles. see #18690.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-05 23:15:19 +00:00
azaozz
f9ebf31d4a Revert 'auto' column setting, props markjaquith, see #18863
git-svn-id: http://svn.automattic.com/wordpress/trunk@18889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-05 18:46:21 +00:00
azaozz
d0ceca2496 Make $current_screen->add_option() easier to use, see #18690
git-svn-id: http://svn.automattic.com/wordpress/trunk@18879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-04 17:21:59 +00:00
azaozz
bc6411bb52 Deprecate favorite_actions(), add_contextual_help(), add_screen_option(), move meta_box_prefs() and get_screen_icon() in WP_Screen, see #18690
git-svn-id: http://svn.automattic.com/wordpress/trunk@18874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-04 03:32:12 +00:00
azaozz
bbafdfa0e5 Use add_option() method, introduce add_option_context() method for adding specific text above the screen options, see #18690
git-svn-id: http://svn.automattic.com/wordpress/trunk@18867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-03 04:00:57 +00:00
koopersmith
dbd18bea3d Help style refresh, part 1. A few elements left to add/tweak. see #18690.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-02 18:19:49 +00:00
azaozz
3575537e5f Add screen_options with contextual content, see #18690
git-svn-id: http://svn.automattic.com/wordpress/trunk@18864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-02 06:59:36 +00:00
nacin
f626113f33 Add phpdoc for two WP_Screen methods. props jorbin, see #18785.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-02 00:04:30 +00:00