Commit Graph

607 Commits

Author SHA1 Message Date
Mark Jaquith
13a7d2a743 Revisions: Loading indicator, cleanup, bug fixes.
* Loading indicator when the user is waiting for a trip to the server.
* Bug fixes for diff priming.
* Fix the date display.
* Forget about local comparator, instead order by `modified` on the server.
* Initialize the frame model before the view (this was the source of a LOT of heartache).

git-svn-id: http://core.svn.wordpress.org/trunk@24667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-12 05:11:56 +00:00
Mark Jaquith
2940a03ae5 Revisions: Use jQuery animation.
The CSS3 animations caused issues because the element was still there, and there is no standard way to know when a CSS3 animation is done.

See #24425.

git-svn-id: http://core.svn.wordpress.org/trunk@24660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-11 18:43:12 +00:00
Mark Jaquith
ef5e733dbf Revisions: Bunch of refactoring and code cleanup
* Extracted a lot of model-y stuff from the view code.
* Slider now has a proper model, with communication with other models.
* Use of `get( foo )` instead of `findWhere({ id: foo })`.
* Properly set the `from` diff when routing single mode.
* Bind `prev()` and `next()` to their model.
* Tick marks are now percentage based, which means the slider resizes with the browser, without JS resize events.
* When scrubbing, the position of the scrubber is considered a hover, so you can fall off the timeline while still scrubbing and the tooltips will persist.
* Tooltips fade in and out.
* Tooltips hang around for a grace period instead of immediately going away. More forgiving.
* Unused code paths removed.
* Got rid of a bunch of view-to-view communication.
* Use `_.times()` instead of a `for` loop.
* Removed premature `Math.floor()` and `Math.ceil()` calls that were making things not add up to 100%.

See #24425.

git-svn-id: http://core.svn.wordpress.org/trunk@24658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-11 09:14:14 +00:00
Helen Hou-Sandí
561a323362 Add sliding animations to the accordion. props kovshenin, DrewAPicture, helen. fixes #23890.
git-svn-id: http://core.svn.wordpress.org/trunk@24644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-10 16:32:09 +00:00
Andrew Nacin
e0ba6b979f Avoid a scrollbar in the iframe used for plugin sandboxing. props kovshenin. see #10840.
git-svn-id: http://core.svn.wordpress.org/trunk@24631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-10 04:56:28 +00:00
Mark Jaquith
8035bd88ad Revisions: Get rid of an unneccessary ID. IDs are a bad idea.
See #24425.

git-svn-id: http://core.svn.wordpress.org/trunk@24629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-10 04:37:50 +00:00
Mark Jaquith
561db4a6da Tick marks are back for revisions
* Simple tick marks
* Tooltips snap to tick marks
* Tooltips arrow reverses side for LTR/RTL
* Fix for routing issue where just the hash is changed in the URL bar relating to compare two mode

see #24425. props adamsilverstein, ocean90.

git-svn-id: http://core.svn.wordpress.org/trunk@24595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-08 21:37:03 +00:00
Andrew Nacin
22b6c3bcc9 Prevent overflow of the parent term dropdown in the new term form. props desrosj, fixes #23397.
git-svn-id: http://core.svn.wordpress.org/trunk@24588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-08 16:55:59 +00:00
Dominik Schilling
4fc5e70228 Revisions improvements
* Corrected routing behavior
* Simplified CSS for tooltips
* Compare two mode for RTL
* Support for posts without titles 

props adamsilverstein, ocean90. see #24425.

git-svn-id: http://core.svn.wordpress.org/trunk@24578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-06 10:48:14 +00:00
Mark Jaquith
5f19c95249 Gracefully slide down the "{Name} is editing" notice portion of the post row, so everything isn't shifting down in an instant and throwing off people's clicks.
fixes #24553. props kadamwhite, johnbillion.

git-svn-id: http://core.svn.wordpress.org/trunk@24576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-05 23:17:25 +00:00
Dominik Schilling
b95c432870 Revisions: CSS cleanup, see #24425.
git-svn-id: http://core.svn.wordpress.org/trunk@24574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-05 22:15:37 +00:00
Mark Jaquith
7296424bd2 Push menu settings checkboxes down to a new line to avoid weird overlaps in some languages.
props SergeyBiryukov. see #24546.

git-svn-id: http://core.svn.wordpress.org/trunk@24566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-05 18:39:21 +00:00
Mark Jaquith
37db654d60 Revisions improvements
* Consolidated router code
* Corrected routing behavior
* Tooltip model
* Removed mouse dragging code

props adamsilverstein, ocean90. see #24425.

git-svn-id: http://core.svn.wordpress.org/trunk@24565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-05 17:44:47 +00:00
Dominik Schilling
f6ca108240 Revisions UI update:
* Restore Compare two mode
* Restore tooltips
* RTL support
* First pass for URL routing and history

props adamsilverstein, see #24425.

git-svn-id: http://core.svn.wordpress.org/trunk@24549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-03 20:27:19 +00:00
Mark Jaquith
77abb9ff01 Cleanup of the revisions screen, both on the PHP API side, and the JS.
* Much simpler PHP API
* Cleaner and more Backbone-y JS API
* Consequently, does batch queries; this now scales up to hundreds of revisions

Currently missing, but much easier considering the cleaned up base:

* Compare two mode
* RTL

props koopersmith, nacin, adamsilverstein, ocean90. see #24425

git-svn-id: http://core.svn.wordpress.org/trunk@24520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-26 21:06:50 +00:00
Helen Hou-Sandí
bd231c209f Add post format icons to the radio chooser. This also trims empty margins from the sprites to make them usable in RTL and make positioning numbers more sane. props ryelle, kovshenin for the initial patch. fixes #24519.
git-svn-id: http://core.svn.wordpress.org/trunk@24429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-07 17:15:53 +00:00
Helen Hou-Sandí
b9c5b62965 Change the post format icons sprite to be vertical rather than horizontal in order to allow it to be used for wider items such as labels. RTL tweak for the icon in the posts list table. See #16047, #24519.
git-svn-id: http://core.svn.wordpress.org/trunk@24426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-07 15:11:42 +00:00
Helen Hou-Sandí
99c0762fca Remove obsolete CSS related to post formats UI. See #24452, #24502.
git-svn-id: http://core.svn.wordpress.org/trunk@24418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-06 15:40:17 +00:00
Daryl Koopersmith
49ec824b9f Improve contrast of revision diffs. Fixes #24422.
git-svn-id: http://core.svn.wordpress.org/trunk@24355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-25 16:48:37 +00:00
Sergey Biryukov
d7840ecf2f Auto-expand the menus accordion if JavaScript is disabled. fixes #24402.
git-svn-id: http://core.svn.wordpress.org/trunk@24348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-24 20:50:10 +00:00
Andrew Ozz
a26190eb2e Post locks:
- Change from IDs to classes for the notification-dialog divs so they can be reused.
- Do not check post locks if the dialog's html is not present.
- Do not check post locks if there is only one user on a single site install.
See #23697.

git-svn-id: http://core.svn.wordpress.org/trunk@24304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-20 19:36:29 +00:00
Andrew Ozz
d1c33dea55 Post format retina icons for both color themes, props melchoyce, aaroncampbell. See #24290, see #24331.
git-svn-id: http://core.svn.wordpress.org/trunk@24294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-19 02:05:52 +00:00
Andrew Ozz
2ae4b8e73e Post format image: fix distorted image preview on iPads, see #24046
git-svn-id: http://core.svn.wordpress.org/trunk@24292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-19 00:49:58 +00:00
Andrew Ozz
7255abb66c Fix showing and hiding of UI elements when disabling the Post Formats UI, props kovshenin, see #24327
git-svn-id: http://core.svn.wordpress.org/trunk@24264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-15 20:43:09 +00:00
Dominik Schilling
6d0173ba11 RTL support for the new post Format UI. see #24326.
git-svn-id: http://core.svn.wordpress.org/trunk@24258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-14 19:01:57 +00:00
Dominik Schilling
91880a5459 RTL: Fix some issues on nav menu screen. see #24326.
git-svn-id: http://core.svn.wordpress.org/trunk@24256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-14 18:26:41 +00:00
Mark Jaquith
917fbaa81c Improvements of Image format dropzone
* Limit drag-drop Image format zone to HTML5 runtime
* Only keep the first file dropped
* Only upload image files
* Fix CSS for the progress bar

props azaozz. see #24291.

git-svn-id: http://core.svn.wordpress.org/trunk@24236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-10 18:49:05 +00:00
Mark Jaquith
f63001eb2c Improve the UX and flow of the Image post format.
* Drag-and-drop
* Textarea for HTML/URL hidden to start
* Bigger click target for entering Media modal
* Image preview height-contrained to 300 pixels
* Hid the alignment, size, etc options that didn't have an effect anyway
* Got wp-format-{format} into the <body> class

props DrewAPicture, aaroncampbell, markjaquith, azaozz. see #24291.

git-svn-id: http://core.svn.wordpress.org/trunk@24226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-09 22:45:14 +00:00
Dominik Schilling
62b1b71b02 Revisions UI: Redesigned slider handlers.
Also:
* Fix diff header styling in grey admin theme
* Prevent an overlap of the compare two checkbox on smaller screens

props melchoyce, DrewAPicture, adamsilverstein. fixes #24276.

git-svn-id: http://core.svn.wordpress.org/trunk@24219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-09 10:07:26 +00:00
Dominik Schilling
cbec9880a7 Revisions UI: RTL support. (And inline docs.)
props DrewAPicture, adamsilverstein. fixes #23897.

git-svn-id: http://core.svn.wordpress.org/trunk@24205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-08 21:22:01 +00:00
Dominik Schilling
2f1777986c Revisions UI: Just another update - Now with improved tick marks and tooltips.
props adamsilverstein. see #23935.

git-svn-id: http://core.svn.wordpress.org/trunk@24174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-03 23:17:06 +00:00
Dominik Schilling
ea1cecebee Revisions UI: Add translation contexts and remove unneeded lines.
props nao. fixes #23917.

git-svn-id: http://core.svn.wordpress.org/trunk@24157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-02 10:12:19 +00:00
Dominik Schilling
0de35b1035 Revisions: Remove the ID from the "restored by" line. props adamsilverstein. see #18733.
git-svn-id: http://core.svn.wordpress.org/trunk@24156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-02 09:35:35 +00:00
Dominik Schilling
45ccae1092 Revisions UI update:
* Style status loading as a regular update message like on the other screens
 * Move compare two checkbox to diff header to avoid an overlap on long post titles
 * Restore color shades for the scope of changes visualisation 
 * Show tooltips while moving the slider handle
 * Diff header styling
 * Move color declarations to classic/fresh stylesheets
 * Sync admin color stylesheets

props jrbeilke for initial patch. see #23935.

git-svn-id: http://core.svn.wordpress.org/trunk@24119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-28 10:56:57 +00:00
Helen Hou-Sandí
4885096f98 Better responsive CSS for post format switcher. Remove some JS debug cruft. props wonderboymusic. see #24046.
git-svn-id: http://core.svn.wordpress.org/trunk@24114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-26 23:47:21 +00:00
Sergey Biryukov
cd1ccc3f3d Remove excess margin on the menus accordion in IE7. props bobbravo2. fixes #24095.
git-svn-id: http://core.svn.wordpress.org/trunk@24112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-26 16:10:43 +00:00
Sergey Biryukov
6cf5361850 Remove unused variable and CSS class. see #24046.
git-svn-id: http://core.svn.wordpress.org/trunk@24099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-26 12:36:12 +00:00
Mark Jaquith
1b554db95a Post format UI refresh.
* Post format switcher does not go away after clicking
* Refresh of format switcher style
* Highlighting of active post format
* Prompt text goes under the switcher
* Better animations

see #24046. props wonderboymusic, johnjamesjacoby, aaroncampbell, PeteMall.

Also, because I forgot it on [24006]: props saracannon.

git-svn-id: http://core.svn.wordpress.org/trunk@24098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-26 12:22:55 +00:00
Mark Jaquith
082e067a2d Screen option for Post Format UI.
props nacin. see #23930.

git-svn-id: http://core.svn.wordpress.org/trunk@24092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-25 07:28:33 +00:00
Mark Jaquith
031be1e97d Restore the title visibility for Asides (but keep autogeneration fallback).
see #24011.

git-svn-id: http://core.svn.wordpress.org/trunk@24085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-25 04:46:58 +00:00
Andrew Nacin
b11654ce74 Revert [23871] - Customize should be added to the menu, but not hacked in as first. see #21413.
git-svn-id: http://core.svn.wordpress.org/trunk@24048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-22 19:33:39 +00:00
Mark Jaquith
18aab9531a Hide the post title and auto-generate based on the post body, for the status and aside post formats.
props kovshenin. see #24011.

git-svn-id: http://core.svn.wordpress.org/trunk@24043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-22 04:00:25 +00:00
Andrew Ozz
d2a8f064aa Post locks:
- Show 'Saving revision...' while autosaving after a post has been taken over. Change to 'Your latest changes were saved as a revision.' when autosave completes.
- Make sure a user exists before using $user->display_name.
- Add 'post_lock_text' action for extending the message text.

git-svn-id: http://core.svn.wordpress.org/trunk@24042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-22 03:08:51 +00:00
Dominik Schilling
9313710f79 Post Formats: Change post screen icon on selection. props markjaquith. fixes #24140.
git-svn-id: http://core.svn.wordpress.org/trunk@24039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-19 22:00:10 +00:00
Mark Jaquith
8b78d60800 Hide Media button for Status and Aside post types.
props kovshenin. fixes #24013.

git-svn-id: http://core.svn.wordpress.org/trunk@24037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-19 20:40:47 +00:00
Dominik Schilling
670c0e173f Revisions UI: Disable previous and next buttons when you're on the first, and last node. Put revision ticks above the slider range. props lessbloat for initial patch. see #23899.
git-svn-id: http://core.svn.wordpress.org/trunk@24020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-17 20:12:25 +00:00
Mark Jaquith
56d5d62a19 New Post Format UI chooser treatment in response to testing.
* Bigger icons
* Format description under each
* UI hides after choice
* Saving without choosing implies "Standard"
* Helpful text, with "Change format" link

see #24046. props lessbloat, wonderboymusic.

git-svn-id: http://core.svn.wordpress.org/trunk@24006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-17 04:08:46 +00:00
Dominik Schilling
731f040664 Revisions UI: Remove the "To:" prefix from the header when viewing a single revision. Also prefix a revision field with a label.
props SergeyBiryukov, adamsilverstein, faishal. fixes #23903.

git-svn-id: http://core.svn.wordpress.org/trunk@23994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-15 18:40:17 +00:00
Mark Jaquith
697bf3d70e Only remove ONE piece of media from the content in setup_postdata().
props wonderboymusic. fixes #24052.

git-svn-id: http://core.svn.wordpress.org/trunk@23984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-14 01:11:44 +00:00
Dominik Schilling
57dca8c80e Set a height for post title input
Firefox ​ignores the line-height because it declares line-height with `normal !important` in one of it's browser stylesheets. This can result in missing dots above umlauts.

props helen, lessbloat.
fixes #23189


git-svn-id: http://core.svn.wordpress.org/trunk@23976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-12 21:19:22 +00:00