Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-02 16:59:35 +01:00
Code Issues Projects Releases Wiki Activity
39,890 Commits 50 Branches 747 Tags 785 MiB
e2ea3f7f30
Commit Graph

13596 Commits

Author SHA1 Message Date
Gary Pendergast
4c3d541e23 Block Editor: Fix the link to the classic editor when incompatible meta boxen are detected. 
Props tmatsuur, mukesh27.
Fixes #45935.

Built from https://develop.svn.wordpress.org/trunk@45618


git-svn-id: http://core.svn.wordpress.org/trunk@45429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-11 06:01:58 +00:00
Sergey Biryukov
7369ff02f5 Coding Standards: Remove extra whitespace in list tables' column_cb() methods. 
See #47632.
Built from https://develop.svn.wordpress.org/trunk@45617


git-svn-id: http://core.svn.wordpress.org/trunk@45428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-09 21:11:58 +00:00
Sergey Biryukov
9a5f538153 Coding Standards: Remove extra whitespace in wp-admin/includes/image-edit.php. 
See #47632.
Built from https://develop.svn.wordpress.org/trunk@45616


git-svn-id: http://core.svn.wordpress.org/trunk@45427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-09 21:05:57 +00:00
Sergey Biryukov
6a696f6051 I18N: Move code out of translatable string in a _deprecated_argument() message in wp_stream_image(), wp_save_image_file(), and image_edit_apply_changes(). 
Props ramiy.
Fixes #47406.
Built from https://develop.svn.wordpress.org/trunk@45615


git-svn-id: http://core.svn.wordpress.org/trunk@45426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-09 20:57:56 +00:00
Sergey Biryukov
bb365054b8 Menus: Remove extra whitespace from URLs in Walker_Nav_Menu_Edit::start_el(). 
Props alexeyskr, SergeyBiryukov.
Fixes #47666.
Built from https://develop.svn.wordpress.org/trunk@45614


git-svn-id: http://core.svn.wordpress.org/trunk@45425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-09 20:45:56 +00:00
Sergey Biryukov
29e5155969 Filesystem API: Check correct variable in WP_Filesystem_Direct::dirlist() after [45611]. 
Props zinigor.
Fixes #47668. See #47632.
Built from https://develop.svn.wordpress.org/trunk@45613


git-svn-id: http://core.svn.wordpress.org/trunk@45424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-09 15:58:57 +00:00
Gary Pendergast
4be25f3d06 Coding Standards: Fix instances of WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase. 
See #46732.

Built from https://develop.svn.wordpress.org/trunk@45612


git-svn-id: http://core.svn.wordpress.org/trunk@45423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-09 06:29:57 +00:00
Gary Pendergast
abcbee954f Coding Standards: Fix instances of WordPress.PHP.NoSilencedErrors.Discouraged. 
Noteable changes:
- The `magic_quotes_runtime` and `magic_quotes_sybase` settings were removed in PHP 5.4, so no longer need to be set.
- Some functions that use external libraries can generate errors that can't be tested for, so are globally allowed to silence errors.
- Quite a few functions would cause errors if `safe_mode` was set. This setting was removed in PHP 5.4.
- Only a handful of `header()` calls needed corresponding `headers_sent()` checks for unit tests to pass, but more may need to be added as the nightlies builds are tested.

See #46732.

Built from https://develop.svn.wordpress.org/trunk@45611


git-svn-id: http://core.svn.wordpress.org/trunk@45422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-09 05:45:58 +00:00
Andrew Ozz
4a273484f3 TinyMCE: fix flickering inline toolbar when hovering over the buttons there and the vertical scrollbar is not shown (the page height is less than the window height). Improves/removes the previous fix for similar flickering but only in RTL, see #42018. 
Props joakimsilfverberg, mukesh27, kokers, Howdy_McGee, noisysocks, azaozz.
Fixes #44911.
Built from https://develop.svn.wordpress.org/trunk@45610


git-svn-id: http://core.svn.wordpress.org/trunk@45421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-09 01:11:55 +00:00
Gary Pendergast
c71bc1513e Coding Standards: Add missing translator comments to the default themes. 
All default themes now have translator comments for all strings with placeholders!

See #46732.

Built from https://develop.svn.wordpress.org/trunk@45609


git-svn-id: http://core.svn.wordpress.org/trunk@45420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-09 01:10:00 +00:00
Gary Pendergast
82935b0343 Theme Editor: Hide the recommendation to create a child theme when editing a child theme. 
Props mukesh27, davidbaumwald.
Fixes #44889.

Built from https://develop.svn.wordpress.org/trunk@45608


git-svn-id: http://core.svn.wordpress.org/trunk@45419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-08 03:15:56 +00:00
Gary Pendergast
ec07a7e565 Coding Standards: Fix the remaining issues in /tests. 
All PHP files in `/tests` now conform to the PHP coding standards, or have exceptions appropriately marked.

Travis now also runs `phpcs` on the `/tests` directory, any future changes to these files must conform entirely to the WordPress PHP coding standards. 🎉

See #47632.


Built from https://develop.svn.wordpress.org/trunk@45607


git-svn-id: http://core.svn.wordpress.org/trunk@45418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-08 00:56:56 +00:00
laurelfulford
83e19085a3 Twenty Thirteen: Add styles for the new Group block. 
Add styles for the new Group block to the theme, to make sure nested blocks display correctly when using the wide and full alignments. 

Props @kjellr.
Fixes #46778.


Built from https://develop.svn.wordpress.org/trunk@45606


git-svn-id: http://core.svn.wordpress.org/trunk@45417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-07 20:49:55 +00:00
laurelfulford
5b4b6d98ce Twenty Nineteen: Add styles for the new Group block. 
Add styles for the new Group block to the theme, to make sure nested blocks display correctly when using the wide and full alignments. 

Props @kjellr, @dianeco.
Fixes #46750.


Built from https://develop.svn.wordpress.org/trunk@45605


git-svn-id: http://core.svn.wordpress.org/trunk@45416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-07 20:11:57 +00:00
Gary Pendergast
28a8f31ffa Coding Standards: Add missing translator comments. 
Twentys Eleven, Sixteen, and Seventeen now have translator comments for all their strings.

Also, WPCS now doesn't show missing translator comment warnings for test files.

See #47632.


Built from https://develop.svn.wordpress.org/trunk@45604


git-svn-id: http://core.svn.wordpress.org/trunk@45415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-05 08:04:57 +00:00
Gary Pendergast
14c7533162 Coding Standards: Fix all WordPress.DB.PreparedSQLPlaceholders issues. 
See #47632.


Built from https://develop.svn.wordpress.org/trunk@45603


git-svn-id: http://core.svn.wordpress.org/trunk@45414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-05 05:43:55 +00:00
Gary Pendergast
87675d288b Coding Standards: Fix all WordPress.WhiteSpace.PrecisionAlignment issues. 
See #47632.


Built from https://develop.svn.wordpress.org/trunk@45602


git-svn-id: http://core.svn.wordpress.org/trunk@45413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-05 05:21:56 +00:00
Gary Pendergast
f69c20859e Coding Standards: Fix all WordPress.CodeAnalysis.AssignmentInCondition issues. 
`WordPress.CodeAnalysis.AssignmentInCondition.FoundInWhileCondition` can be ignored, as this is allowed in Core.

See #47632.


Built from https://develop.svn.wordpress.org/trunk@45601


git-svn-id: http://core.svn.wordpress.org/trunk@45412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-05 03:14:56 +00:00
Gary Pendergast
d378f0a8f4 Coding Standards: Upgrade WPCS to 2.1.1. 
Noteable changes:
- WPCS now throws warnings when non-strict comparisons are used. There are quite a few of them in Core. 🙃
- WPCS now detects and warns for assignments in loop conditions.

See #47632.


Built from https://develop.svn.wordpress.org/trunk@45600


git-svn-id: http://core.svn.wordpress.org/trunk@45411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-05 02:50:56 +00:00
Gary Pendergast
a02b5cc2a8 Coding Standards: Mark the handful of hook names with uppercase characters or hyphens as ignored. 
See #47632.


Built from https://develop.svn.wordpress.org/trunk@45599


git-svn-id: http://core.svn.wordpress.org/trunk@45410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-05 01:45:56 +00:00
Sergey Biryukov
b8be081e7e Text Changes: Use consistent question wording in database connection error messages. 
Props Presskopp.
See #44878.
Built from https://develop.svn.wordpress.org/trunk@45598


git-svn-id: http://core.svn.wordpress.org/trunk@45409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-04 10:58:56 +00:00
Sergey Biryukov
4af4c78a27 Text Changes: Use consistent question wording for plugin and theme deletion confirmations. 
Props johnjamesjacoby, Presskopp.
Fixes #44878.
Built from https://develop.svn.wordpress.org/trunk@45597


git-svn-id: http://core.svn.wordpress.org/trunk@45408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-04 09:56:57 +00:00
Sergey Biryukov
abe3ec288b Twenty Nineteen: Fix markup errors in twentynineteen_add_ellipses_to_nav(): 
* Add missing i18n for `aria-label` attribute.
* Remove redundant screen reader text superseded by `aria-label`.
* Remove unnecessary `id` and `class` attributes.

Props afercia, chetan200891, ianbelanger.
Fixes #47067.
Built from https://develop.svn.wordpress.org/trunk@45596


git-svn-id: http://core.svn.wordpress.org/trunk@45407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-04 09:23:55 +00:00
Sergey Biryukov
d1815a5c91 Twenty Nineteen: Adjust markup in twentynineteen_add_ellipses_to_nav() for better readability. 
See #47067.
Built from https://develop.svn.wordpress.org/trunk@45595


git-svn-id: http://core.svn.wordpress.org/trunk@45406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-04 09:15:58 +00:00
Sergey Biryukov
f84ab5e19f Twenty Nineteen: Update package.json with the latest package versions to pass npm audit. 
Props netweb.
Fixes #47631.
Built from https://develop.svn.wordpress.org/trunk@45594


git-svn-id: http://core.svn.wordpress.org/trunk@45405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-04 00:38:58 +00:00
Sergey Biryukov
3a57fee891 Script Loader: Remove unnecessary jquery dependency for wp-sanitize.js. 
The file is written in plain JavaScript.

Props sstoqnov.
Fixes #47324.
Built from https://develop.svn.wordpress.org/trunk@45593


git-svn-id: http://core.svn.wordpress.org/trunk@45404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-04 00:33:57 +00:00
Sergey Biryukov
f154cd0780 Bundled Themes: Remove extra semicolons from CSS files. 
Props shashank3105, ianbelanger.
Fixes #47178.
Built from https://develop.svn.wordpress.org/trunk@45592


git-svn-id: http://core.svn.wordpress.org/trunk@45403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-04 00:27:58 +00:00
Sergey Biryukov
268c64913e Query: Make sure $climits variable in WP_Query::get_posts() is always defined to avoid a PHP notice. 
Props juiiee8487, agengineering.
Fixes #47638.
Built from https://develop.svn.wordpress.org/trunk@45591


git-svn-id: http://core.svn.wordpress.org/trunk@45402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-03 01:14:57 +00:00
Gary Pendergast
4803fc405e Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in wp-includes. 
See #47632.


Built from https://develop.svn.wordpress.org/trunk@45590


git-svn-id: http://core.svn.wordpress.org/trunk@45401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-02 23:42:58 +00:00
Gary Pendergast
55b2d94cca Formatting: Revert the changes to wpautop() in [45585,45587]. 
See #27350.

Built from https://develop.svn.wordpress.org/trunk@45589


git-svn-id: http://core.svn.wordpress.org/trunk@45400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-02 11:22:56 +00:00
Gary Pendergast
073f379fd3 Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in tests. 
See #47632.


Built from https://develop.svn.wordpress.org/trunk@45588


git-svn-id: http://core.svn.wordpress.org/trunk@45399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-02 04:43:57 +00:00
Gary Pendergast
b57d185bb1 Formatting: Improve performance of wpautop() on large paragraphs. 
Following [45585], older versions of PHP could segfault when attempting to autop paragraphs with 10,000+ characters.

Rather than having to negative lookahead for every character in the paragraph (which could run into recursion limits), we can quickly jump ahead to the next tag and start checking from there.

See #27350.


Built from https://develop.svn.wordpress.org/trunk@45587


git-svn-id: http://core.svn.wordpress.org/trunk@45398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-02 03:29:55 +00:00
Gary Pendergast
d7b95b1a86 Docs: Update some function docs and signatures. 
- Update the `_wp_specialchars()` docs to match the function signature.
- Update the `human_time_diff()` function signature to match the docs.

Props subrataemfluence.
Fixes #46845.


Built from https://develop.svn.wordpress.org/trunk@45586


git-svn-id: http://core.svn.wordpress.org/trunk@45397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-02 01:45:58 +00:00
Gary Pendergast
23de362563 Clean up stray <p> tags added by wpautop() inside block level tags. 
`autop()` can sometimes get confused and not clean up stray `<p>` or `</p>` tags inside block level elements, which produces sub-optimal HTML. While browsers can generally handle it, there's no need to make things harder for them if we don't have to.

Props pento, ayubi, pbearne, jond, azaozz, 1994rstefan, dionysous, MikeHansenMe, jorbin, miqrogroove, niallkennedy.
Fixes #27350.



Built from https://develop.svn.wordpress.org/trunk@45585


git-svn-id: http://core.svn.wordpress.org/trunk@45396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-02 01:31:56 +00:00
Adam Silverstein
4568c13df8 Taxonomy: add a new 'terms_pre_query' filter to short circuit WP_Term_Query 'get_terms' queries. 
Add a new `terms_pre_query` filter which returns null by default. Return a non-null value to bypass WordPress's default `get_terms` queries.

Props jarocks, boonebgorges, spacedmonkey.
Fixes #41246.


Built from https://develop.svn.wordpress.org/trunk@45584


git-svn-id: http://core.svn.wordpress.org/trunk@45395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-01 20:48:58 +00:00
Gary Pendergast
cf3fa9f7c8 Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in wp-admin. 
See #47632.


Built from https://develop.svn.wordpress.org/trunk@45583


git-svn-id: http://core.svn.wordpress.org/trunk@45394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-01 12:52:01 +00:00
Gary Pendergast
b2d5a4216c Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in the base directory. 
See #47632.


Built from https://develop.svn.wordpress.org/trunk@45582


git-svn-id: http://core.svn.wordpress.org/trunk@45393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-01 08:27:58 +00:00
Gary Pendergast
0d23be600e Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in the default themes. 
See #47632


Built from https://develop.svn.wordpress.org/trunk@45581


git-svn-id: http://core.svn.wordpress.org/trunk@45392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-01 08:23:57 +00:00
Gary Pendergast
55af0f0d0a Coding Standards: Fix/ignore the WordPress.NamingConventions.ValidFunctionName violations. 
See #47632


Built from https://develop.svn.wordpress.org/trunk@45580


git-svn-id: http://core.svn.wordpress.org/trunk@45391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-01 08:01:57 +00:00
Gary Pendergast
072682b1ed Multisite: Use size_format() in display_space_usage(). 
Deleted code is the best code.

Fixes #28239.


Built from https://develop.svn.wordpress.org/trunk@45579


git-svn-id: http://core.svn.wordpress.org/trunk@45390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-01 03:47:56 +00:00
Gary Pendergast
abc0f7dd32 Formatting: Trim leading whitespace in esc_url(). 
Props toszcze.
Fixes #36369.


Built from https://develop.svn.wordpress.org/trunk@45578


git-svn-id: http://core.svn.wordpress.org/trunk@45389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-01 03:29:57 +00:00
Gary Pendergast
f3ece5149f Formatting: Don't add <p> tags inside <svg> tags. 
Inline `<svg>`s should generally work, as browsers should just ignore `<p>` or `<br/>` tags that shouldn't be inside the `<svg>`. To keep things neat, however, it's better not add them in the first place.

Props jared_smith, nacin, pento.
Fixes #9437.


Built from https://develop.svn.wordpress.org/trunk@45577


git-svn-id: http://core.svn.wordpress.org/trunk@45388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-07-01 03:19:58 +00:00
Sergey Biryukov
93f3335f13 Twenty Seventeen: Correct the CSS selectors intended to fix hover colors for MediaElement controls. 
This is a follow-up to the previous fix in [45146], which didn't work as expected.

Props ryokuhi.
Fixes #47543. See #40843.
Built from https://develop.svn.wordpress.org/trunk@45576


git-svn-id: http://core.svn.wordpress.org/trunk@45387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-29 00:51:58 +00:00
youknowriad
405efef86c Build/Test Tools: Fix the hello e2e test assertion. 
The previous assertion was always valid because we assumed it returned a single object,
while in reality it was returning an array.

Props hideokamoto.
Fixes #47622.

Built from https://develop.svn.wordpress.org/trunk@45575


git-svn-id: http://core.svn.wordpress.org/trunk@45386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-28 11:34:58 +00:00
Gary Pendergast
691ffce019 Formatting: Add correct <p> tags near <hr> tags. 
It can be tricky to know when `wpautop()` should add `<p>` tags, but one thing we can be certain about is that they really shouldn't be anywhere near `<hr>` tags.

Now they aren't.

Props solarissmoke, MattyRob, pento.
Fixes #14674.


Built from https://develop.svn.wordpress.org/trunk@45574


git-svn-id: http://core.svn.wordpress.org/trunk@45385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-28 07:16:56 +00:00
Gary Pendergast
dd38e9cc0b Formatting: Add support for seconds to human_time_diff(). 
The web has gotten so much faster since `human_time_diff()` was created, we need to be able to measure time differences with much finer granularity. Now, we can.

Props johnjamesjacoby, pento.
Fixes #35655.


Built from https://develop.svn.wordpress.org/trunk@45573


git-svn-id: http://core.svn.wordpress.org/trunk@45384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-28 06:44:57 +00:00
Andrea Fercia
00704114e0 Accessibility: Make the Media modal an ARIA modal dialog. 
For a number of years, the Media modal missed an explicit ARIA role and the required attributes for modal dialogs.

This was confusing for assistive technology users, since they may not realize they're inside a dialog, and that consequently the keyboard interactions may be different from the rest of the page. Lack of an explicit label for the dialog was confusing as well, since assistive technology users didn't have an immediate sense of what the dialog is for.

This change makes the Media modal meet the ARIA Authoring Practices recommendations, helping users better understand the purpose and interactions with the modal. Also, it makes sure to hide the rest of the page content from assistive technologies, until support for `aria-modal="true"` improves.

Additionally:
- moves the modal H1 heading to the beginning of the modal content 
- changes the modal left menu position to make visual and DOM order match 
- improves the `wp.media.view.FocusManager` documentation

Fixes #47145.

Built from https://develop.svn.wordpress.org/trunk@45572


git-svn-id: http://core.svn.wordpress.org/trunk@45383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-27 12:33:56 +00:00
youknowriad
1714484132 Build/Test Tools: Make the local env scripts executable. 
See #45165.

Built from https://develop.svn.wordpress.org/trunk@45571


git-svn-id: http://core.svn.wordpress.org/trunk@45382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-27 12:06:55 +00:00
youknowriad
5cf8452ae9 Build/Test Tools: Add the e2e tests setup. 
- Adds a local environment based on docker
 - Adds the e2e tests setup
 - Adds a "Hello World" e2e test to serve as a template

Props gziolo, herregroen, mcsf.
Fixes #45165.

Built from https://develop.svn.wordpress.org/trunk@45570


git-svn-id: http://core.svn.wordpress.org/trunk@45381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-27 11:28:19 +00:00
Gary Pendergast
d2a64fdabd Formatting: Don't convert smilies in ignored tags that have attributes. 
Smilies in ignored tags are not supposed to be converted to emoji, but this can malfunction if the tag has attributes. For example, the Preformatted block with add a `class` to the `<pre>` tag.

Props pento, jikamens.
Fixes #47489.


Built from https://develop.svn.wordpress.org/trunk@45569


git-svn-id: http://core.svn.wordpress.org/trunk@45380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-27 02:05:52 +00:00
Sergey Biryukov
573daa129c Users: Pass $length, $special_chars, and $extra_special_chars parameters to the random_password filter in wp_generate_password(). 
Props roytanck.
Fixes #47092.
Built from https://develop.svn.wordpress.org/trunk@45568


git-svn-id: http://core.svn.wordpress.org/trunk@45379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-27 00:48:53 +00:00
Sergey Biryukov
9d7bd11631 Docs: Correct @since for admin/edit-comments.js, introduced in [3736]. 
See #47581.
Built from https://develop.svn.wordpress.org/trunk@45567


git-svn-id: http://core.svn.wordpress.org/trunk@45378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-26 18:19:52 +00:00
Sergey Biryukov
e23ce44744 REST API: Call WP_REST_Server::get_compact_response_links() and ::get_raw_data() static methods the right way. 
Props andizer, TimothyBlynJacobs.
Fixes #47578.
Built from https://develop.svn.wordpress.org/trunk@45566


git-svn-id: http://core.svn.wordpress.org/trunk@45377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-26 18:07:54 +00:00
John Blackbourn
bab5ed2df5 Docs: Correct and improve the docs for a few nonce-related functions. 
See #47110

Built from https://develop.svn.wordpress.org/trunk@45565


git-svn-id: http://core.svn.wordpress.org/trunk@45376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-25 17:07:52 +00:00
Andrew Ozz
05c9032a0b Editor: Fix undefined $locked var in edit-form-blocks.php when the show_post_locked_dialog filter is used to disable displaying of the dialog. 
Props aprea.
Fixes #47604.
Built from https://develop.svn.wordpress.org/trunk@45564


git-svn-id: http://core.svn.wordpress.org/trunk@45375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-25 15:03:52 +00:00
Andrea Fercia
ba24a8f6d3 Plugins: Fix the plugin details modal layout after [45520]. 
Props mukesh27, marybaum, audrasjb.
Fixes #47561.

Built from https://develop.svn.wordpress.org/trunk@45563


git-svn-id: http://core.svn.wordpress.org/trunk@45374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-25 14:11:55 +00:00
Peter Wilson
bb965baeec Cron: Fix condition reversed in [45559]. 
In [45559] a test for not-falsey was reversed to a falsey check.

Props obenland.
Fixes #47589.

Built from https://develop.svn.wordpress.org/trunk@45562


git-svn-id: http://core.svn.wordpress.org/trunk@45373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-22 13:43:52 +00:00
atimmer
73ad55051b Docs: Improve JSDoc for media/views/attachment/details.js. 
Props maartenleenders, boblinthorst, dfangstrom.
Fixes #47588.

Built from https://develop.svn.wordpress.org/trunk@45561


git-svn-id: http://core.svn.wordpress.org/trunk@45372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-22 13:02:52 +00:00
Peter Wilson
b0e82d2cc4 Cron API: Prevent caching of WP Cron requests. 
Add `Cache-Control` and `Expires` HTTP headers to prevent caching of requests to WP Cron on systems supporting fastcgi_finish_request(). 

The fastcgi_finish_request() call prevents the setting of further HTTP headers by caching plugins subsequently loaded.

Props kingkero.
Fixes 47396.


Built from https://develop.svn.wordpress.org/trunk@45560


git-svn-id: http://core.svn.wordpress.org/trunk@45371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-22 11:13:51 +00:00
Peter Wilson
fdb8ff4980 Code is Poetry: CS Fixes required in wp-cron.php. 
See #47396, #41057.


Built from https://develop.svn.wordpress.org/trunk@45559


git-svn-id: http://core.svn.wordpress.org/trunk@45370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-22 11:12:51 +00:00
atimmer
225de4e6eb Docs: Improve JSDoc for admin/edit-comments.js. 
Props manuelaugustin, diedeexterkate, thulshof, Xyfi, ireneyoast.
Fixes #47581.

Built from https://develop.svn.wordpress.org/trunk@45558


git-svn-id: http://core.svn.wordpress.org/trunk@45369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-20 14:45:51 +00:00
Adam Silverstein
bcc4ecb1f6 Themes: improve search by trimming search string. 
Fix an issue where searching installed themes for an empty string resulted in matching all themes.

Props afercia, desrosj, hesyifei, evalarumbe.
Fixes #39041.

Built from https://develop.svn.wordpress.org/trunk@45557


git-svn-id: http://core.svn.wordpress.org/trunk@45368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-20 14:15:53 +00:00
Sergey Biryukov
89e7a75d96 Date/Time: Eliminate use of date_default_timezone_set() for determining DST status on General Options screen. 
Time calculations should not need to rely on manipulating global PHP configuration state.

Props Rarst.
Fixes #46483.
Built from https://develop.svn.wordpress.org/trunk@45556


git-svn-id: http://core.svn.wordpress.org/trunk@45367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-20 14:11:53 +00:00
Sergey Biryukov
a06e914bae Date/Time: Add more supported formats to wp_maybe_decline_date(). 
Props SergeyBiryukov, Rarst.
Fixes #37411.
Built from https://develop.svn.wordpress.org/trunk@45555


git-svn-id: http://core.svn.wordpress.org/trunk@45366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-20 13:47:52 +00:00
desrosj
bd239b4be8 XML-RPC: Merge similar translation strings. 
Props ramiy.
Fixes #47039.
Built from https://develop.svn.wordpress.org/trunk@45554


git-svn-id: http://core.svn.wordpress.org/trunk@45365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-20 12:53:52 +00:00
atimmer
8756207ef2 Comments: Open comment quick edit on double click. 
In [42767] the quick edit button changed from a link to a button. This caused the jQuery code that selects on a link to no longer work. This commit restores the previous behavior.

Fixes #47572.
See #43382, #38677.

Built from https://develop.svn.wordpress.org/trunk@45553


git-svn-id: http://core.svn.wordpress.org/trunk@45364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-20 10:06:51 +00:00
desrosj
470177a906 Help/About: Improve wording of PHP Error Protection section. 
Props pedromendonca, garrett-eclipse.
See #47475.
Fixes #47538.
Built from https://develop.svn.wordpress.org/trunk@45551


git-svn-id: http://core.svn.wordpress.org/trunk@45362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-20 09:52:54 +00:00
Sergey Biryukov
f0e9ffdebb Plugins: When validating plugin's WordPress and PHP requirements, check for Requires at least and Requires PHP headers in the plugin's main PHP file. 
This allows for blocking plugin activation if it requires a higher version of PHP or WordPress, and does not have a `readme.txt` file.

If the headers are defined in both `readme.txt` and the main plugin file, precedence is given to the plugin file.

Props afragen, Otto42, Ipstenu.
Fixes #46938.
Built from https://develop.svn.wordpress.org/trunk@45546


git-svn-id: http://core.svn.wordpress.org/trunk@45357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-18 03:24:52 +00:00
Sergey Biryukov
55d05b56c3 Bootstrap/Load: Set expiration of the recovery mode cookie to the same amount of time for which the token in it is valid: a week by default. 
Props david.binda, TimothyBlynJacobs.
Fixes #47480.
Built from https://develop.svn.wordpress.org/trunk@45545


git-svn-id: http://core.svn.wordpress.org/trunk@45356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-17 19:17:54 +00:00
Sergey Biryukov
038c980a42 Bootstrap/Load: Return a 403 error code when the recovery mode cookie is invalid or expired, or the exit recovery mode nonce check failed. 
Props david.binda, spacedmonkey.
Fixes #47479.
Built from https://develop.svn.wordpress.org/trunk@45544


git-svn-id: http://core.svn.wordpress.org/trunk@45355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-17 18:37:55 +00:00
Andrew Ozz
88ffa41ee3 Media: Ignore errors coming from image_resize_dimensions() when creating sub-sizes (for now). It returns false when the requested size is larger than the original image and should be skipped. This triggers new WP_Error in WP_Image_Editor::resize(). 
See #40439.
Built from https://develop.svn.wordpress.org/trunk@45543


git-svn-id: http://core.svn.wordpress.org/trunk@45354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-16 01:33:51 +00:00
Sergey Biryukov
4e4ef1170b I18N: Merge duplicate strings in notifications displayed when a new user has been created or added to the site. 
Props ramiy.
Fixes #35746.
Built from https://develop.svn.wordpress.org/trunk@45542


git-svn-id: http://core.svn.wordpress.org/trunk@45353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-15 18:57:52 +00:00
Andrew Ozz
6b74e27d04 Media: fix support for arrays for the crop setting for registered image sub-sizes in wp_get_registered_image_subsizes(). 
See #40439.
Built from https://develop.svn.wordpress.org/trunk@45541


git-svn-id: http://core.svn.wordpress.org/trunk@45352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-15 17:17:52 +00:00
Andrew Ozz
da7839dc45 After [45538]: fix another WPCS "strict comparison" fix. 
Props birgire.
See #40439.
Built from https://develop.svn.wordpress.org/trunk@45540


git-svn-id: http://core.svn.wordpress.org/trunk@45351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-15 16:24:52 +00:00
Andrew Ozz
5987caeecc After [45538]: fix a WPCS fix and make couple of var names consistent. 
See #40439.
Built from https://develop.svn.wordpress.org/trunk@45539


git-svn-id: http://core.svn.wordpress.org/trunk@45350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-15 01:32:53 +00:00
Andrew Ozz
05302bd054 Save progress of intermediate image creation after upload. First run. 
- Introduces `wp_get_missing_image_subsizes()` and `wp_update_image_subsizes()` to generate image sub-sizes that are missing or were not created after the upload.
- Adds a way to display errors that happened while creating sub-sizes.
- Introduces `wp_create_image_subsizes()` intended for use after an image was uploaded. It saves/updates the image metadata immediately after each sub-size is created. This fixes the (long standing) problem when some of the sub-size image files were created but there was a timeout or an error and the metadata was not saved. Until now such uploads were considered "failed" which usually resulted in the user trying to upload the same image again, creating even more "orphan" image files.

Note that the patch also includes some unrelated WPCS fixes.

Props mikeschroder, azaozz.
See #40439.
Built from https://develop.svn.wordpress.org/trunk@45538


git-svn-id: http://core.svn.wordpress.org/trunk@45349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-15 01:02:52 +00:00
Sergey Biryukov
8a2daa7648 Menus: Set better default for $args parameter in Walker_Nav_Menu methods, to match the documented parameter type. 
Props trasweb.
Fixes #47524.
Built from https://develop.svn.wordpress.org/trunk@45537


git-svn-id: http://core.svn.wordpress.org/trunk@45348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-14 11:26:52 +00:00
Sergey Biryukov
0239fe6d10 Administration: Adjust code for "Manage widgets or menus" item on "Welcome to WordPress" panel to avoid an extra space after [42343]. 
Props Presskopp, davidbaumwald.
Fixes #47536.
Built from https://develop.svn.wordpress.org/trunk@45536


git-svn-id: http://core.svn.wordpress.org/trunk@45347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-14 00:29:52 +00:00
desrosj
3d61f81536 Docs: Fix typos in Services_JSON DocBlocks. 
Props mukesh27.
Fixes #47401.
Built from https://develop.svn.wordpress.org/trunk@45535


git-svn-id: http://core.svn.wordpress.org/trunk@45346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-13 19:19:52 +00:00
Andrew Ozz
d38e15e59d Fix displaying of the "An updated version of WordPress is available." notice when running the latest nightly build. Note that it is still displayed when running a local build or from /src. 
Props afragen, audrasjb, SergeyBiryukov.
Fixes #45202.
Built from https://develop.svn.wordpress.org/trunk@45532


git-svn-id: http://core.svn.wordpress.org/trunk@45343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-13 16:43:53 +00:00
Andrea Fercia
d69a3e6f90 Accessibility: Handle one more case of focus loss when switching view in the Media Views. 
See #43169.

Built from https://develop.svn.wordpress.org/trunk@45531


git-svn-id: http://core.svn.wordpress.org/trunk@45342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-13 16:22:52 +00:00
Andrew Ozz
727838a11b Add a Recovery Mode Exit button to the notice. This fixes it in responsive view. 
Props desrosj, karmatosed, chetan200891, afercia, afragen, garrett-eclipse.
Fixes #47070.
Built from https://develop.svn.wordpress.org/trunk@45529


git-svn-id: http://core.svn.wordpress.org/trunk@45340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-13 16:00:52 +00:00
desrosj
7be747f86d Customize: Remove “Update” link for themes on multisite installs. 
In [38887], installing themes in the Customizer was disabled for multisite installs. However, an update link continues to be displayed when a theme update is available. Clicking the link causes a JavaScript error.

This removes that update link because updates cannot actually be performed in the Customizer in this situation.

Props desrosj, earnjam, mukesh27, audrasjb, garrett-eclipse.
Fixes #46997.
Built from https://develop.svn.wordpress.org/trunk@45527


git-svn-id: http://core.svn.wordpress.org/trunk@45338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-13 15:31:52 +00:00
Andrea Fercia
c622fb4fe1 Media: Make sure the bottom media toolbar content is fully visible with Internet Explorer 11. 
Props mspatovaliyski.
Fixes #47502.

Built from https://develop.svn.wordpress.org/trunk@45526


git-svn-id: http://core.svn.wordpress.org/trunk@45337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-13 14:12:52 +00:00
Weston Ruter
2ca468889a Bundled Theme: Fix malformed Google Font URL for Twenty Twelve due to double-encoding of + 
Amends [45485].
Fixes #47282.

Built from https://develop.svn.wordpress.org/trunk@45525


git-svn-id: http://core.svn.wordpress.org/trunk@45336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-12 23:33:50 +00:00
Andrea Fercia
340fd28d82 Accessibility: Improve focus management in the Media Views. 
- keeps focus management only where necessary to avoid focus losses
- removes focus management where a specific user workflow was assumed
- makes the "Attachment Details" navigation buttons really disabled when there are no next or previous attachments
- adds inline comments to clarify all the usages of focus()

Fixes #43169.

Built from https://develop.svn.wordpress.org/trunk@45524


git-svn-id: http://core.svn.wordpress.org/trunk@45335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-12 21:03:52 +00:00
Andrea Fercia
9f579ea448 Administration: Improve the horizontal centering of the Site Health tabs. 
Props dkarfa, davidbaumwald, Clorith, tinkerbelly, afercia.
Fixes #46881.

Built from https://develop.svn.wordpress.org/trunk@45522


git-svn-id: http://core.svn.wordpress.org/trunk@45333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-12 19:31:52 +00:00
Andrea Fercia
9f7f9d2d89 Administration: Fix the responsive layout after changes to the Screen Options and Help buttons position. 
Fixes #45094.

Built from https://develop.svn.wordpress.org/trunk@45520


git-svn-id: http://core.svn.wordpress.org/trunk@45331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-12 19:21:54 +00:00
Andrew Ozz
d0c1b77cda Privacy tools: 
- Move the (remaining) privacy tools related functions from `wp-admin/includes/file.php` to `wp-admin/includes/privacy-tools.php`.
- Move the `WP_User_Request` class to a separate file.

See #43895.
Built from https://develop.svn.wordpress.org/trunk@45519


git-svn-id: http://core.svn.wordpress.org/trunk@45330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-10 23:54:53 +00:00
Sergey Biryukov
3b69e493f6 I18N: Merge duplicate "authenticity could not be verified" strings, fix comma placement on About page. 
Props pedromendonca, garrett-eclipse.
Fixes #47475.
Built from https://develop.svn.wordpress.org/trunk@45515


git-svn-id: http://core.svn.wordpress.org/trunk@45326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-10 14:14:51 +00:00
Peter Wilson
a5e57d7245 Site health: Introduce view_site_health_checks capability. 
Introduces the faux primitive capability `view_site_health_checks` available to single site admins and multisite super-admin to view the site health page within the admin.

The capability is mapped to the `install_plugins` capability without being dependent on the file system being writable. This fixes a bug where the feature couldn't be used by sites unable to write to the file system or managed through version control.

The capability is granted on the `user_has_cap` filter.

Props birgire, Clorith, palmiak, peterwilsoncc, spacedmonkey.
Fixes #46957.


Built from https://develop.svn.wordpress.org/trunk@45507


git-svn-id: http://core.svn.wordpress.org/trunk@45318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-10 07:42:52 +00:00
Andrea Fercia
f57e10a35d Accessibility: Fix the order of the Previous, Next, and Close buttons in the Attachment Details modal. 
Making the visual and DOM order match benefits keyboard users who navigate documents sequentially and expect the focus order to be consistent with the sequential reading order.

Fixes #47458.

Built from https://develop.svn.wordpress.org/trunk@45506


git-svn-id: http://core.svn.wordpress.org/trunk@45317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-09 15:48:53 +00:00
John Blackbourn
c9b51df3d0 I18N: Allow the length of automatically generated excerpts to be localized. 
This introduces three new strings that can be used to control the maximum length of automatically generated excerpts for posts, comments, and draft post previews in the dashboard. Optionally combined with the existing word count type control this allows languages which include many multibyte characters to specify more appropriate maximum excerpt lengths.

Props miyauchi, birgire, johnbillion

Fixes #44541

Built from https://develop.svn.wordpress.org/trunk@45505


git-svn-id: http://core.svn.wordpress.org/trunk@45316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-08 18:42:52 +00:00
John Blackbourn
eeba1c1244 HTTP API: Ensure the http_api_debug hook is fired for all responses. 
This means that logging and debugging functionality can access the error code and error message for erroneous responses under all conditions. The hook is not fired when a request is short-circuited with the `pre_http_request` filter, because this filter itself can be used in that situation.

Fixes #25747

Built from https://develop.svn.wordpress.org/trunk@45504


git-svn-id: http://core.svn.wordpress.org/trunk@45315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-08 17:10:52 +00:00
Andrea Fercia
935c35fe34 Accessibility: Improve the Screen Options and Help buttons order. 
- makes the buttons visual order match the DOM order
- also, restores the focus style on the "hero" primary button after [34948]

Props vrimill, mukesh27 for reporting and testing.
Fixes #45094.

Built from https://develop.svn.wordpress.org/trunk@45503


git-svn-id: http://core.svn.wordpress.org/trunk@45314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-08 16:31:53 +00:00
Andrea Fercia
be14c6e5c6 Administration: Improve the Screen Options and Help buttons focus style after [45501]. 
Amends [45501].
See #46749.

Built from https://develop.svn.wordpress.org/trunk@45502


git-svn-id: http://core.svn.wordpress.org/trunk@45313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-08 16:07:52 +00:00
Andrea Fercia
17034e2a4e Administration: Remove extra border from the Screen Options and Help buttons. 
The extra border was visible in the responsive view for smaller screens after [32844].

Props jitendrabanjara1991.
Fixes #46749.

Built from https://develop.svn.wordpress.org/trunk@45501


git-svn-id: http://core.svn.wordpress.org/trunk@45312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-08 14:50:52 +00:00
Andrew Ozz
7cee029897 Privacy tools: remove some left-over code and fix inline comment. 
See #43895.


Built from https://develop.svn.wordpress.org/trunk@45500


git-svn-id: http://core.svn.wordpress.org/trunk@45311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-08 00:30:51 +00:00
Andrea Fercia
6a9bcaeaa9 Accessibility: Improve accessibility of all the media views form controls. 
- changes the media views form controls to have explicitly associated labels with for/id attributes
- adds a few missing labels / aria-labels
- improves a few existing labels / aria-labels
- improves semantics in a few places, by adding visually hidden headings, fieldset + legend elements, aria-describedby attributes
- improves the image custom size input fields and their labelling
- adds `role="status"` to the "saved" indicator so that status messages are announced to assistive technologies
- swaps the columns source order in the image details template, to make visual and DOM order match
- swaps the "Replace" and "Back" buttons source order in the Replace Image view, to make visual and DOM order match
- gallery settings: move checkbox label to the right: checkboxes are supposed to have labels on the right
- merge similar strings, unified to "Drop files to upload" (removed "Drop files here", and "Drop files anywhere to upload")
- makes the "upload-ui" consistent across the media views
- hides the IE 11 "X" `::-ms-clear` button in the Insert from URL field, as it conflicts with the uploading spinner
- adds comments to all the media templates to clarify their usage
- slightly increases vertical spacing between form fields in the media sidebar
- removes some CSS selectors introduced as backwards compatibility for WordPress pre-4.4
- removes some CSS still targeting Internet Explorer 7 and 8

Fixes #47141.
Fixes #47122.

Built from https://develop.svn.wordpress.org/trunk@45499


git-svn-id: http://core.svn.wordpress.org/trunk@45310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-07 20:45:02 +00:00
Andrea Fercia
314bfab180 Regenerate the REST API fixtures after [45443]. 
See #38517.

Built from https://develop.svn.wordpress.org/trunk@45498


git-svn-id: http://core.svn.wordpress.org/trunk@45309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-07 20:24:52 +00:00
Andrea Fercia
d5333b9593 Fix the media player controls bar width in the media views. 
Props vaishalipanchal, chetan200891.
Fixes #47457.

Built from https://develop.svn.wordpress.org/trunk@45497


git-svn-id: http://core.svn.wordpress.org/trunk@45308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-07 13:29:52 +00:00
Sergey Biryukov
056b9c47a2 Docs: Fix typo in comment_class() DocBlock. 
Props mbabker.
Fixes #47499.
Built from https://develop.svn.wordpress.org/trunk@45496


git-svn-id: http://core.svn.wordpress.org/trunk@45307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-06 23:52:51 +00:00
Sergey Biryukov
baa2cd69b8 Media: Restore correct arrow direction in RTL in Attachment Details modal. 
Reverts [29264]. As we now have a build task to replace dashicons for RTL, the CSS rules no longer worked as expected and had the opposite effect.

Props ramiy, SergeyBiryukov.
Fixes #46289.
Built from https://develop.svn.wordpress.org/trunk@45495


git-svn-id: http://core.svn.wordpress.org/trunk@45306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-06 01:25:52 +00:00
Sergey Biryukov
53719315b4 I18N: Merge duplicate "Original" strings used in the same context (referring to image size). 
Props mukesh27.
Fixes #47486.
Built from https://develop.svn.wordpress.org/trunk@45494


git-svn-id: http://core.svn.wordpress.org/trunk@45305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-05 15:23:52 +00:00
Sergey Biryukov
3f9bf72d69 I18N: Correct encoding for wp-includes/widgets/class-wp-widget-calendar.php, accidentally saved in ANSI instead of UTF-8. 
See #47485.
Built from https://develop.svn.wordpress.org/trunk@45493


git-svn-id: http://core.svn.wordpress.org/trunk@45304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-05 15:09:53 +00:00
Sergey Biryukov
16dfde180c I18N: Merge duplicate "A calendar of your site’s posts" strings used in the Calendar widget and the Calendar block in the editor. 
Props jorgefilipecosta, ramiy.
Fixes #47485.
Built from https://develop.svn.wordpress.org/trunk@45492


git-svn-id: http://core.svn.wordpress.org/trunk@45303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-05 15:03:53 +00:00
Sergey Biryukov
8c449d3312 Posts, Post Types: Switch the order of arguments for implode() in the_meta() to match the function notation. 
Props loyaltymanufaktur.
Fixes #47481.
Built from https://develop.svn.wordpress.org/trunk@45491


git-svn-id: http://core.svn.wordpress.org/trunk@45302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-05 00:16:54 +00:00
desrosj
4c0620bdf8 Privacy: Remove inline CSS within personal data request list tables. 
The `.hidden` class can be used to show and hide UI elements instead.

Props birgire, pratikthink, garrett-eclipse.
Fixes #44839.
Built from https://develop.svn.wordpress.org/trunk@45490


git-svn-id: http://core.svn.wordpress.org/trunk@45301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-04 23:40:55 +00:00
Sergey Biryukov
aa59cb8359 Docs: Correct parameter name for wp_new_user_notification_email_admin filter. 
Props needle.
Fixes #47476.
Built from https://develop.svn.wordpress.org/trunk@45489


git-svn-id: http://core.svn.wordpress.org/trunk@45300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-04 12:48:55 +00:00
Sergey Biryukov
32d761ce7d I18N: Merge duplicate "Status" and "Info" strings on Site Health screens. 
Props ramiy.
Fixes #47227.
Built from https://develop.svn.wordpress.org/trunk@45488


git-svn-id: http://core.svn.wordpress.org/trunk@45299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-06-01 22:10:52 +00:00
Sergey Biryukov
13da094c39 Upgrade/Install: Correct operator precedence for an error code in WP_Ajax_Upgrader_Skin::error(). 
Props jrf.
Fixes #47441.
Built from https://develop.svn.wordpress.org/trunk@45487


git-svn-id: http://core.svn.wordpress.org/trunk@45298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-31 14:14:52 +00:00
Sergey Biryukov
410eb3501b Build/Test Tools: Add $current_screen to the list of globals to unset in WP_UnitTestCase_Base::go_to(). 
Props mauteri.
Fixes #47439.
Built from https://develop.svn.wordpress.org/trunk@45486


git-svn-id: http://core.svn.wordpress.org/trunk@45297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-31 14:07:51 +00:00
Felix Arntz
3c40573f77 Bundled Theme: Load Google fonts with display=fallback parameter for better UX in case the font cannot be loaded. 
Providing this query parameter ensures the stylesheet contains the `font-display: fallback` rule. This changeset also updates the Open Sans font used by core accordingly.

Props westonruter.
Fixes #47282.

Built from https://develop.svn.wordpress.org/trunk@45485


git-svn-id: http://core.svn.wordpress.org/trunk@45296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-31 10:10:54 +00:00
Sergey Biryukov
0d40c54f9b CSS Coding Standards: Use unitless values for line-height in wp-admin/css/media.css. 
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46530. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45484


git-svn-id: http://core.svn.wordpress.org/trunk@45295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-30 16:45:50 +00:00
Sergey Biryukov
412ffd0aaf Media: Move tag cloud styles that accidentally ended up in Media section after the reorganization in [16136] to a more appropriate place. 
Remove styles for `wp-admin/update-core.php` accidentally duplicated in Media section as part of the same reorganization.

See #46530.
Built from https://develop.svn.wordpress.org/trunk@45483


git-svn-id: http://core.svn.wordpress.org/trunk@45294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-30 16:40:52 +00:00
youknowriad
ebb0b92081 Block Editor: Update packages to the ones slated for WP5.2.2 
- Fix the template validation notice
 - Fix for focus jumps when typing in meta attributes

Packages updated:

 - @wordpress/block-editor@2.0.3
 - @wordpress/block-library@2.4.6
 - @wordpress/e2e-tests@1.1.6
 - @wordpress/edit-post@3.3.6
 - @wordpress/editor@9.2.6
 - @wordpress/format-library@1.4.6

Props aduth, desrosj.
Fixes #47429.

Built from https://develop.svn.wordpress.org/trunk@45481


git-svn-id: http://core.svn.wordpress.org/trunk@45292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-30 15:41:57 +00:00
desrosj
349d95f27a Docs: Add missing function documentation for list_plugin_updates(). 
Introduced in [9543].

Props priyankkpatel, mukesh27.
Fixes #47424.
Built from https://develop.svn.wordpress.org/trunk@45480


git-svn-id: http://core.svn.wordpress.org/trunk@45291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-30 15:10:52 +00:00
desrosj
012d05f5c0 Docs: Add missing documentation for the locale meta field. 
The user’s locale is passed in the `$meta` parameter for `insert_user_meta`. Added in [38705].

Props tmatsuur.
Fixes #47423.
Built from https://develop.svn.wordpress.org/trunk@45479


git-svn-id: http://core.svn.wordpress.org/trunk@45290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-30 14:37:53 +00:00
Sergey Biryukov
96a533b279 CSS Coding Standards: Use unitless values for line-height in wp-includes/css/media-views.css. 
Props ianbelanger, pbiron, afercia.
Fixes #46529. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45478


git-svn-id: http://core.svn.wordpress.org/trunk@45289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-30 13:18:52 +00:00
Sergey Biryukov
9bab7d6fd6 CSS Coding Standards: Use unitless values for line-height in wp-includes/css/editor.css. 
Props ianbelanger, pbiron, afercia.
Fixes #46528. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45477


git-svn-id: http://core.svn.wordpress.org/trunk@45288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-30 12:45:53 +00:00
Sergey Biryukov
5083e104d4 CSS Coding Standards: Use unitless values for line-height in wp-includes/css/buttons.css. 
Props ianbelanger, pbiron, afercia.
Fixes #46526. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45476


git-svn-id: http://core.svn.wordpress.org/trunk@45287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-30 12:42:52 +00:00
Sergey Biryukov
1d98a92fad CSS Coding Standards: Use unitless values for line-height in wp-includes/css/wp-pointer.css. 
Props ianbelanger, pbiron, afercia.
Fixes #46525. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45475


git-svn-id: http://core.svn.wordpress.org/trunk@45286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-30 12:41:51 +00:00
Sergey Biryukov
90b2092ab6 CSS Coding Standards: Use unitless values for line-height in wp-includes/css/wp-embed-template.css. 
Props ianbelanger, pbiron, afercia.
Fixes #46524. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45474


git-svn-id: http://core.svn.wordpress.org/trunk@45285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-30 12:40:52 +00:00
Sergey Biryukov
05afb2271d CSS Coding Standards: Use unitless values for line-height in wp-includes/functions.php. 
Props ianbelanger, pbiron, afercia.
Fixes #46523. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45473


git-svn-id: http://core.svn.wordpress.org/trunk@45284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-30 12:39:52 +00:00
Sergey Biryukov
820baca1bd CSS Coding Standards: Use unitless values for line-height in wp-includes/css/wp-auth-check.css. 
Props ianbelanger, pbiron, afercia.
Fixes #46522. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45472


git-svn-id: http://core.svn.wordpress.org/trunk@45283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-30 12:37:52 +00:00
Sergey Biryukov
e6b98a469c CSS Coding Standards: Use unitless values for line-height in wp-includes/css/jquery-ui-dialog.css. 
Props ianbelanger, pbiron, afercia.
Fixes #46521. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45471


git-svn-id: http://core.svn.wordpress.org/trunk@45282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-30 12:36:52 +00:00
Sergey Biryukov
8738c23afc CSS Coding Standards: Use unitless values for line-height in wp-includes/css/customize-preview.css. 
Props ianbelanger, pbiron, afercia.
Fixes #46520. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45470


git-svn-id: http://core.svn.wordpress.org/trunk@45281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-30 12:34:52 +00:00
Sergey Biryukov
2a417c2168 CSS Coding Standards: Use unitless values for line-height in wp-includes/css/admin-bar.css. 
Props ianbelanger, pbiron, afercia.
Fixes #46519. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45469


git-svn-id: http://core.svn.wordpress.org/trunk@45280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-30 12:32:51 +00:00
Sergey Biryukov
fdc6b9583b CSS Coding Standards: Use unitless values for line-height in wp-admin/css/revisions.css. 
Props ianbelanger, pbiron, afercia.
Fixes #46517. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45468


git-svn-id: http://core.svn.wordpress.org/trunk@45279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-30 12:16:52 +00:00
Sergey Biryukov
ca6aa01705 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/list-tables.css. 
Props ianbelanger, pbiron, afercia.
Fixes #46515. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45467


git-svn-id: http://core.svn.wordpress.org/trunk@45278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-30 12:15:52 +00:00
Sergey Biryukov
afaeca95cf CSS Coding Standards: Use unitless values for line-height in wp-admin/css/login.css. 
Props ianbelanger, pbiron, afercia.
Fixes #46514. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45466


git-svn-id: http://core.svn.wordpress.org/trunk@45277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-30 12:09:52 +00:00
Sergey Biryukov
1899a99c35 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/install.css. 
Props ianbelanger, pbiron, afercia.
Fixes #46513. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45465


git-svn-id: http://core.svn.wordpress.org/trunk@45276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-30 11:53:53 +00:00
Sergey Biryukov
03814826b2 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/forms.css. 
Props ianbelanger, pbiron, afercia.
Fixes #46512. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45464


git-svn-id: http://core.svn.wordpress.org/trunk@45275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-30 11:49:53 +00:00
Andrea Fercia
41accccad6 Administration: Improve the Site Health tables layout for small screens. 
Props immeet94, jankimoradiya, desrosj, shashank3105, chetan200891, Clorith, hedgefield.	
Fixes #46960.

Built from https://develop.svn.wordpress.org/trunk@45463


git-svn-id: http://core.svn.wordpress.org/trunk@45274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-29 18:22:51 +00:00
Sergey Biryukov
52d478cb0d CSS Coding Standards: Use unitless values for line-height in wp-admin/css/edit.css. 
Props ianbelanger, pbiron, afercia.
Fixes #46511. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45462


git-svn-id: http://core.svn.wordpress.org/trunk@45273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-29 16:05:53 +00:00
Sergey Biryukov
ce25e2f34d CSS Coding Standards: Use unitless values for line-height in wp-admin/css/dashboard.css. 
Props ianbelanger, pbiron, afercia.
Fixes #46510. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45461


git-svn-id: http://core.svn.wordpress.org/trunk@45272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-29 16:03:52 +00:00
Sergey Biryukov
9860a4366d CSS Coding Standards: Use unitless values for line-height in wp-admin/css/customize-widgets.css. 
Props ianbelanger, pbiron, afercia.
Fixes #46509. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45460


git-svn-id: http://core.svn.wordpress.org/trunk@45271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-29 16:01:53 +00:00
desrosj
bb3c264350 Administration: Add missing filter documentation for Site Health auto update tests. 
Props johnbillion, mukesh27.
Fixes #47388.
Built from https://develop.svn.wordpress.org/trunk@45459


git-svn-id: http://core.svn.wordpress.org/trunk@45270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-29 13:59:51 +00:00
Andrew Ozz
d23160d427 Fix unit tests after [45456]. The query string is a bit different but the results are the same. 
See #45346.
Built from https://develop.svn.wordpress.org/trunk@45458


git-svn-id: http://core.svn.wordpress.org/trunk@45269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-28 04:19:53 +00:00
Andrew Ozz
311527b41d Fix previous WPCS errors in script-loader.php triggered by [45456]. 
See #45346.
Built from https://develop.svn.wordpress.org/trunk@45457


git-svn-id: http://core.svn.wordpress.org/trunk@45268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-28 03:32:52 +00:00
Andrew Ozz
6de52463a7 Script loader: prevent sorting of the load array in the query string when passing the script handles to load-scripts.php and load-styles.php. 
Fixes #45346 #26886.
Built from https://develop.svn.wordpress.org/trunk@45456


git-svn-id: http://core.svn.wordpress.org/trunk@45267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-28 02:43:55 +00:00
Andrew Ozz
b8fa71964f Build tools, WPCS: disable line ending check when running phpcs but fix them to \n whit phpcfb. Fixes (erroneous) reports on Windows about improper line endings in all files. They are managed directly by Git or SVN. 
Fixes #47411.
Built from https://develop.svn.wordpress.org/trunk@45455


git-svn-id: http://core.svn.wordpress.org/trunk@45266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-28 00:26:54 +00:00
Sergey Biryukov
51ee349942 Docs: Add a comment about the reinstated wp-admin/options-privacy.php. 
See #43895.
Built from https://develop.svn.wordpress.org/trunk@45454


git-svn-id: http://core.svn.wordpress.org/trunk@45265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-27 03:03:52 +00:00
Sergey Biryukov
96b4570781 Privacy: Remove reinstated wp-admin/options-privacy.php from $_old_files. 
Fix WPCS violations in [45448].

See #43895.
Built from https://develop.svn.wordpress.org/trunk@45453


git-svn-id: http://core.svn.wordpress.org/trunk@45264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-27 02:40:53 +00:00
Andrew Ozz
2f7f0ad901 Fix typo in [45451] and move the redirect to the proper location. 
See #43895.
Built from https://develop.svn.wordpress.org/trunk@45452


git-svn-id: http://core.svn.wordpress.org/trunk@45263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-26 23:21:51 +00:00
Andrew Ozz
cbcccbd5b6 Privacy tools: restore privacy.php to its "proper" use to output the Privacy tab on the About screen, see [42814]. Then add the Privacy tab updates from freedoms.php. 
See #43895.


Built from https://develop.svn.wordpress.org/trunk@45451


git-svn-id: http://core.svn.wordpress.org/trunk@45262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-26 22:57:52 +00:00
John Blackbourn
6aab3f2f05 Docs: Improve documentation for some more variadic functions. 
Fixes #37402

Built from https://develop.svn.wordpress.org/trunk@45450


git-svn-id: http://core.svn.wordpress.org/trunk@45261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-26 22:48:51 +00:00
John Blackbourn
557ef04409 Docs: Improve docs for variadic functions relating to widgets and their controls. 
See #37402

Built from https://develop.svn.wordpress.org/trunk@45449


git-svn-id: http://core.svn.wordpress.org/trunk@45260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-26 22:05:51 +00:00
Andrew Ozz
87acdab81d Privacy tools: Organize privacy functions into logical files and classes. 
Props xkon, birgire, desrosj, garrett-eclipse, azaozz.
See #43895.
Built from https://develop.svn.wordpress.org/trunk@45448


git-svn-id: http://core.svn.wordpress.org/trunk@45259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-26 20:50:53 +00:00
Sergey Biryukov
67f944caa6 I18N: Remove PHP function name from translatable string in WP_Recovery_Mode_Email_Service. 
Props ramiy.
Fixes #47255.
Built from https://develop.svn.wordpress.org/trunk@45447


git-svn-id: http://core.svn.wordpress.org/trunk@45258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-26 20:44:52 +00:00