Commit Graph

14 Commits

Author SHA1 Message Date
omarreiss
bdbaccce37 General: Explicitly assigns all JS globals to the window.
Many variables in the JavaScript were defined in the global scope without being explicitly assigned to the window. When built with Webpack, the code gets encapsulated in anonymous functions and those implicit globals get assigned to the wrong scope. This patch prevents that from happening.

Fixes #44371. See #43731.

Built from https://develop.svn.wordpress.org/trunk@43577


git-svn-id: http://core.svn.wordpress.org/trunk@43406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-19 13:33:24 +00:00
atimmer
bde558be2f Docs: Add file doc @output annotations.
These annotations make it clear to the reader of a JavaScript source
where the build process outputs to. These annotations can later be
integrated in a webpack configuration. This way there is one source of
truth.

The `build` folder is omitted from the paths, because a single JS file
shouldn't not be responsible of knowing where outputs in general will
end up at. A file only knows its output location relative to the
project.

Props adamsilverstein, herregroen, omarreiss, pento.
Fixes #44361.

Built from https://develop.svn.wordpress.org/trunk@43347


git-svn-id: http://core.svn.wordpress.org/trunk@43175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:30:15 +00:00
Sergey Biryukov
ecf0bcc9fc Revert a part of [32673] that caused a fatal error with SCRIPT_DEBUG disabled.
see #19257.
Built from https://develop.svn.wordpress.org/trunk@32676


git-svn-id: http://core.svn.wordpress.org/trunk@32646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-01 04:14:25 +00:00
John Blackbourn
02192cb53f Introduce featured_image, set_featured_image, remove_featured_image, and use_featured_image post type labels when registering a post type in order to override the 'Featured Image' text and its related phrases.
Props johnbillion, mordauk, valendesigns.
Fixes #19257.

Built from https://develop.svn.wordpress.org/trunk@32673


git-svn-id: http://core.svn.wordpress.org/trunk@32643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 16:54:27 +00:00
Andrew Nacin
12acfa4e81 Fix JSHint errors in 3 files.
props atimmer.
fixes #25990, #25993, #26008.

Built from https://develop.svn.wordpress.org/trunk@26199


git-svn-id: http://core.svn.wordpress.org/trunk@26107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 05:12:09 +00:00
Andrew Nacin
2710bcade1 Switch to .min for compressed JS and CSS files.
* This moves our "development" versions from .dev.js to .js (same for css).
 * The compressed version then moves from .js to .min.js (same for css).

By switching to the standard .min convention, it sets expectations for developers,
and works nicely with existing tools such as ack.

fixes #21633.



git-svn-id: http://core.svn.wordpress.org/trunk@21592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-23 00:04:18 +00:00
nacin
6ae5b10973 Squeeze out some bytes via munging.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-27 13:39:44 +00:00
markjaquith
20cb3ed21b Add nonce protection for setting/removing featured post image. fixes #13438
git-svn-id: http://svn.automattic.com/wordpress/trunk@14730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-18 22:08:49 +00:00
markjaquith
805bdb9365 Provide visual feedback for "Use as thumbnail" when clicked immediately after uploading the image. fixes #11140
git-svn-id: http://svn.automattic.com/wordpress/trunk@12355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-12-10 08:03:26 +00:00
markjaquith
ad2f0c7887 Show "Done" feedback after setting post thumbnail image. see #11140 (partial fix)
git-svn-id: http://svn.automattic.com/wordpress/trunk@12353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-12-10 07:34:32 +00:00
markjaquith
085c01ac7a thumbnail JS fixes. props scribu. see #10928
git-svn-id: http://svn.automattic.com/wordpress/trunk@12111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-10-26 18:02:44 +00:00
markjaquith
2fa9ebab8f Remove close TB call that was removed earlier. see #10928
git-svn-id: http://svn.automattic.com/wordpress/trunk@12037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-10-15 13:58:10 +00:00
markjaquith
17039e3294 Do not close media thickbox after thumbnail is selected, in case uploads are in progress. see #10928
git-svn-id: http://svn.automattic.com/wordpress/trunk@12031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-10-14 08:42:32 +00:00
markjaquith
d7a30e235f First pass on canonical post thumbanils. Admin-side GUI only. Theme functions to follow. see #10928
git-svn-id: http://svn.automattic.com/wordpress/trunk@12007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-10-07 22:18:09 +00:00