Commit Graph

44043 Commits

Author SHA1 Message Date
Aaron Jorbin
5d9ca9dc68 Block Editor: Prevent duplicate queries
When passing args to `WP_Query::__construct` method (in this case, but creating a `new WP_Query`, this one internally executes the `WP_Query::get_posts` method and stores the result in the `WP_Query::posts` property. When calling the `WP_Query::get_posts` again, the same SQL query gets executed, and the result is again stored in the `WP_Query::posts` property.

This was introduced in [51003].

Props david.binda, jorbin.
Fixes #53280. See #53176.

Built from https://develop.svn.wordpress.org/trunk@51144


git-svn-id: http://core.svn.wordpress.org/trunk@50753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-14 20:39:57 +00:00
desrosj
b7489425cb Site Health: Display a list of file formats supported by the GD library.
This adds the list of file formats supported by the GD library to the Media Handling section in Site Health.

This will help site owners debug any issues they encounter as support for newer, more modern image formats is added (such as WebP in [50810]).

Follow up to [50817].
Props adamsilverstein, jorbin. 
Fixes #53022.
Built from https://develop.svn.wordpress.org/trunk@51143


git-svn-id: http://core.svn.wordpress.org/trunk@50752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-14 18:59:59 +00:00
Sergey Biryukov
05e98e28f3 Docs: Update documentation for some WP_Customize_Widgets methods per the documentation standards.
* Add missing `@since` tags for the `$id_base` parameter of ::sanitize_widget_instance()` and `::sanitize_widget_js_instance()`.
* Document the usage of `$wp_widget_factory` global in `::sanitize_widget_instance()`.
* Use multi-line comment syntax for a comment in `::enqueue_scripts()`.

Follow-up to [50996], [51141].

See #52628.
Built from https://develop.svn.wordpress.org/trunk@51142


git-svn-id: http://core.svn.wordpress.org/trunk@50751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-14 15:16:58 +00:00
Sergey Biryukov
2e0e705d4c Docs: Document the usage of $wp_widget_factory global in WP_Customize_Widgets::sanitize_widget_instance().
Follow-up to [50996].

Props jontyravi, audrasjb.
Fixes #53394.
Built from https://develop.svn.wordpress.org/trunk@51141


git-svn-id: http://core.svn.wordpress.org/trunk@50750 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-14 11:02:57 +00:00
Sergey Biryukov
9f91305af2 Tests: Fix typo in a retrieve_widgets() test name.
Correct parameter description for `data_wp_widget_get_field_name()`.

Follow-up to [34780], [41555].

See #52625.
Built from https://develop.svn.wordpress.org/trunk@51140


git-svn-id: http://core.svn.wordpress.org/trunk@50749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-13 16:28:58 +00:00
Sergey Biryukov
39e041b877 Tests: Fix typo in a get_bookmarks() test name.
Follow-up to [44546].

See #52625.
Built from https://develop.svn.wordpress.org/trunk@51139


git-svn-id: http://core.svn.wordpress.org/trunk@50748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-12 15:49:02 +00:00
Sergey Biryukov
41e3cb04ad Docs: Correct DocBlock formatting for some revision tests.
Follow-up to [50949], [51124].

See #52628.
Built from https://develop.svn.wordpress.org/trunk@51138


git-svn-id: http://core.svn.wordpress.org/trunk@50747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-11 12:36:00 +00:00
Sergey Biryukov
3c2c27c637 Tests: Use assertSameSets() in some newly introduced tests.
This ensures that not only the array values being compared are equal, but also that their type is the same.

Going forward, stricter type checking by using `assertSameSets()` or `assertSameSetsWithIndex()` should generally be preferred, to make the tests more reliable.

Follow-up to [48939], [49925], [50157], [50959], [50960], [50995], [51079].

See #52625.
Built from https://develop.svn.wordpress.org/trunk@51137


git-svn-id: http://core.svn.wordpress.org/trunk@50746 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-10 19:20:01 +00:00
Peter Wilson
8df65cdbe9 Widgets: Improve unit tests for RSS Widget.
Prevent unit tests from making HTTP requests to wordpress.org. Specify URLs as https rather than http.

Follow up to [51107].

Props hellofromTonya.
Fixes #53278.

Built from https://develop.svn.wordpress.org/trunk@51136


git-svn-id: http://core.svn.wordpress.org/trunk@50745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-09 23:51:56 +00:00
Sergey Biryukov
adf23b3ed5 Tests: Ignore EOL differences in some tests using multiline string assertions.
Unix vs. Windows EOL style mismatches can cause misleading failures in tests using the heredoc syntax (`<<<`) or multiline strings as the expected result.

Follow-up to [48466], [50995], [51079].

See #52625.
Built from https://develop.svn.wordpress.org/trunk@51135


git-svn-id: http://core.svn.wordpress.org/trunk@50744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-09 19:42:58 +00:00
desrosj
8c4cff0708 Upgrade/Install: Built files should not be included in the $_old_files list.
Follow up to [51133].
Unprops desrosj.
See #53367.
Built from https://develop.svn.wordpress.org/trunk@51134


git-svn-id: http://core.svn.wordpress.org/trunk@50743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-09 16:22:03 +00:00
desrosj
f7c74d3994 Upgrade/Install: Update the $_old_files list for 5.8.
Follow up to [50761], [50794], [51021].
Props kapilpaul, desrosj.
See #52991, #52846, #53246.
Fixes #53367.
Built from https://develop.svn.wordpress.org/trunk@51133


git-svn-id: http://core.svn.wordpress.org/trunk@50742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-09 15:54:57 +00:00
desrosj
f9aaec8f73 Post WordPress 5.8 Beta 1 version bump.
Built from https://develop.svn.wordpress.org/trunk@51132


git-svn-id: http://core.svn.wordpress.org/trunk@50741 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-09 02:40:58 +00:00
desrosj
3ee24bd3bf WordPress 5.8 Beta 1.
Built from https://develop.svn.wordpress.org/trunk@51131


git-svn-id: http://core.svn.wordpress.org/trunk@50740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-09 02:02:58 +00:00
desrosj
15ee62321a Build/Test Tools: Silence jQuery Migrate console warnings when running E2E tests.
These warnings will still be visible in the browser console. The majority of the warnings are coming from jQuery UI, which is still waiting for a new update to be released that is jQuery >= 3.0 friendly.

This change makes the E2E test results more readable without having to tread through the large number of warnings.

Props isabel_brison.
Fixes #52860.
Built from https://develop.svn.wordpress.org/trunk@51130


git-svn-id: http://core.svn.wordpress.org/trunk@50739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-09 01:36:57 +00:00
antpb
06cddbd3b3 Privacy: Improve naming of user confimed action email filters.
The filters `user_confirmed_action_email_content`, `user_erasure_complete_email_subject`, and `user_erasure_complete_email_headers` have been deprecated.

They have been replaced with `user_erasure_fulfillment_email_content`, `user_erasure_fulfillment_email_subject`, and `user_erasure_fulfillment_email_headers`.

Props desrosj, garrett-eclipse, birgire, DrewAPicture, lifeforceinst, ocean90, pbiron, pento, coffee2code, TZ-Media, SergeyBiryukov, johnbillion, audrasjb, davidbaumwald, hellofromTonya, helen, xkon, antpb, peterwilsoncc, lukecarbis.
Fixes #44314.


Built from https://develop.svn.wordpress.org/trunk@51129


git-svn-id: http://core.svn.wordpress.org/trunk@50738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-09 01:35:58 +00:00
desrosj
af81b98b92 Tests: Introduce some E2E tests for the Quick Draft dashboard widget.
Props isabel_brison, johnbillion.
Fixes #523905.
Built from https://develop.svn.wordpress.org/trunk@51128


git-svn-id: http://core.svn.wordpress.org/trunk@50737 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-09 00:20:56 +00:00
whyisjake
2e36162a20 Widgets: Don't decode HTML entities ahead of the widget constructor.
This reverts the changes from [51114]. 

See #53138.

Unprops whyisjake. 

Built from https://develop.svn.wordpress.org/trunk@51127


git-svn-id: http://core.svn.wordpress.org/trunk@50736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 23:40:00 +00:00
desrosj
37652569e4 Login and Registration: Improve the unknown username error message
The new message is more clear and makes the next step more clear to the user. 

Props dd32, SergeyBiryukov, audrasjb, desrosj, dlh, marybaum, chanthaboune, jeffpaul.
Fixes #52915.
Built from https://develop.svn.wordpress.org/trunk@51126


git-svn-id: http://core.svn.wordpress.org/trunk@50735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 23:34:58 +00:00
whyisjake
32ecbd061e Permalinks: Revert the changes stemming from pagination limits.
In [51118], an attempt was made to add pagination limits. The added tests need to be updated to ensure that they pass with the new changes.

Reverts [51118].

See #50233.

Built from https://develop.svn.wordpress.org/trunk@51125


git-svn-id: http://core.svn.wordpress.org/trunk@50734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 23:32:56 +00:00
whyisjake
011a598fa1 Revisions: Check and return errors for insertions to revisions.
Fixes #30009.

Props rmccue, adamsilverstein, coreymckrill, whyisjake.

Built from https://develop.svn.wordpress.org/trunk@51124


git-svn-id: http://core.svn.wordpress.org/trunk@50733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 23:24:57 +00:00
antpb
38e4f333c0 Media: Allow multi-uploads in Galleries.
Previously, when more than one media item was uploaded using a gallery, failures occurred on the second upload.

Props glendaviesnz, Mista-Flo, hellofromTonya.
Fixes #53169.


Built from https://develop.svn.wordpress.org/trunk@51123


git-svn-id: http://core.svn.wordpress.org/trunk@50732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 23:14:55 +00:00
whyisjake
cc26b6f068 Media: Add new functions to return the previous/next attachment links.
New functions:

* get_adjacent_image_link()
* get_next_image_link()
* get_previous_image_link()

Fixes #45708.

Props flixos90, DrewAPicture, mor10, antpb, hellofromTonya, whyisjake.



Built from https://develop.svn.wordpress.org/trunk@51122


git-svn-id: http://core.svn.wordpress.org/trunk@50731 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 23:13:57 +00:00
antpb
bb041c2503 Feeds: Avoid notices in get_post_comments_feed_link().
When an feed request is made to a non-existent page, surpress the notice.

Props dd32, SergeyBiryukov, mukesh27, hellofromTonya.
Fixes #52814.


Built from https://develop.svn.wordpress.org/trunk@51121


git-svn-id: http://core.svn.wordpress.org/trunk@50730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 23:00:59 +00:00
desrosj
bdbda4c306 Coding Standards: Use single quotes when there are no variables within the string.
Follow up to [51117].

See #48743.
Built from https://develop.svn.wordpress.org/trunk@51120


git-svn-id: http://core.svn.wordpress.org/trunk@50729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 22:55:58 +00:00
desrosj
892e5dd68e Administration: Adjust Internet Explorer message to be a bit more clear.
This moves “Internet Explorer” to the beginning of the sentence introduced in [51117] to make the reason the user is seeing this message more clear.

Props chanthaboune, jeffpaul, desrosj.
Fixes #48743.
Built from https://develop.svn.wordpress.org/trunk@51119


git-svn-id: http://core.svn.wordpress.org/trunk@50728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 22:54:57 +00:00
whyisjake
b672d77e87 Permalinks: Limit pagination for posts with comments.
Additionally, redirect pages back to the source page if comments don't exist.

Props devrekli, carike, sumanm, mukesh27, chaion07, audrasjb, whyisjake, SergeyBiryukov.

Fixes #50233.

Built from https://develop.svn.wordpress.org/trunk@51118


git-svn-id: http://core.svn.wordpress.org/trunk@50727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 22:51:01 +00:00
antpb
a8321ed2d5 Administration: Introduce dashboard notice to discourage use of out of date browser.
If a browser matches Internet Explorer, the dashboard will display a notice recommending a more modern browser.

Props youknowriad, sabernhardt, afercia, SergeyBiryukov, davidbaumwald, netweb, johnbillion, jeherve.
See #48743.


Built from https://develop.svn.wordpress.org/trunk@51117


git-svn-id: http://core.svn.wordpress.org/trunk@50726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 22:47:58 +00:00
whyisjake
71f37fe636 Editor: Ensure that the block editor can be used on the page post type.
Additionally, add a notice for when you are editing the "latest posts" page.

Fixes #45537.

Props cameronjonesweb, swissspidy, hannahmalcolm, Fantasy1125, ArnaudBan, grantmkin, youknowriad, knutsp, SergeyBiryukov, audrasjb, whyisjake. 

Built from https://develop.svn.wordpress.org/trunk@51116


git-svn-id: http://core.svn.wordpress.org/trunk@50725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 22:38:58 +00:00
whyisjake
1b7df89e93 Administration: Escape the values of data-colname.
Adds a `esc_attr` wrapper to `strip_all_tags`.

See [33016].

Fixes #40401.

Props rellect, SergeyBiryukov, hareesh-pillai, audrasjb.


Built from https://develop.svn.wordpress.org/trunk@51115


git-svn-id: http://core.svn.wordpress.org/trunk@50724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 22:21:57 +00:00
whyisjake
81c4c4138c Widgets: Ensure that HTML entities are converted in widget descriptions.
Fixes #53138.

Props justinahinon, audrasjb.

Built from https://develop.svn.wordpress.org/trunk@51114


git-svn-id: http://core.svn.wordpress.org/trunk@50723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 22:17:57 +00:00
desrosj
b60a512de4 Emoji: Update the Twemoji library to version 13.1.0.
This version introduces support for the latest Emoji added in version Emoji 13.1, which includes “face in clouds”, “face exhaling”, and of course, “face with spiral eyes”.

A new corresponding folder has been pushed to WordPress.org in [dotorg:17419].

Rages deep within, ❤️‍🔥.

Props kraftbj., desrosj.
Fixes #52852.
Built from https://develop.svn.wordpress.org/trunk@51113


git-svn-id: http://core.svn.wordpress.org/trunk@50722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 22:15:12 +00:00
whyisjake
fc410fab37 Build/Test Tools: Ensure that we are using https:// urls.
Fix from automated install.

See [51111], #39589.

Built from https://develop.svn.wordpress.org/trunk@51112


git-svn-id: http://core.svn.wordpress.org/trunk@50721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 22:12:56 +00:00
whyisjake
2d6e474c85 Media: Ensure that post_id variable is initiated ahead of usage.
This prevents warnings when using custom bulk actions in the media library.

Props gitlost, achbed, Boniu91, wpgurudev, hellofromTonya.

Fixes #39589.

Built from https://develop.svn.wordpress.org/trunk@51111


git-svn-id: http://core.svn.wordpress.org/trunk@50720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 22:08:09 +00:00
ryelle
8ace500967 Twenty Thirteen: Add "No Shadow" style to button block.
This creates a new block style without a shadow, and fixes colors on outline buttons.

Props melchoyce, kjellr, scruffian.
Fixes #51223.


Built from https://develop.svn.wordpress.org/trunk@51110


git-svn-id: http://core.svn.wordpress.org/trunk@50719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 20:37:58 +00:00
ryelle
91c19c69c2 Block Editor: Ignore generated CSS files in Page List and Post Template blocks.
Add SVN ignore property to match existing rule in `.gitignore`.

Follow up to [51101], [51105].
See #52991, #53309.


Built from https://develop.svn.wordpress.org/trunk@51109


git-svn-id: http://core.svn.wordpress.org/trunk@50718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 20:09:57 +00:00
ryelle
57fa6fde4e Login and Registration: Wrap long site titles to a new line.
Props sumitsingh, geekpress, sabernhardt.
Fixes #52776.


Built from https://develop.svn.wordpress.org/trunk@51108


git-svn-id: http://core.svn.wordpress.org/trunk@50717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 19:46:58 +00:00
Aaron Jorbin
e2104af75e Widgets: Prevent infinite loop in PHP8+ if the URL for the widget instance is incorrectly defined
This checks to make sure $link isn't empty before attempting to manipulate it.  A simple test to demonstrate this can be seen at https://3v4l.org/PgSZg. Unit tests for both what already works and what is fixed by this change.

Props hellofromTonya, dd32, peterwilsoncc.
Fixes #53278.


Built from https://develop.svn.wordpress.org/trunk@51107


git-svn-id: http://core.svn.wordpress.org/trunk@50716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 19:35:57 +00:00
ryelle
ba5e7a0fb9 Bundled Themes: Introduce block patterns for Twenty Ten.
Props beafialho, kjellr, melchoyce, danieldudzic, onemaggie.
Fixes #51107.


Built from https://develop.svn.wordpress.org/trunk@51106


git-svn-id: http://core.svn.wordpress.org/trunk@50715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 18:53:59 +00:00
youknowriad
f47e79bc7d Block Editor: Include the page list block server-side code.
On a previous package update, this block's server-side code has been missed.
This was causing the block to not render properly.

Props Chouby, desrosj, mcsf.
Fixes #53309.

Built from https://develop.svn.wordpress.org/trunk@51105


git-svn-id: http://core.svn.wordpress.org/trunk@50714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 18:13:01 +00:00
youknowriad
3cd3ac227a Block Editor: Fix typo in the typography block support.
The function wp_typography_get_css_variable_inline_style has been renamed when backported to Core.
But its usage was untouched causing potential php errors on the frontend.

See #52991.

Built from https://develop.svn.wordpress.org/trunk@51104


git-svn-id: http://core.svn.wordpress.org/trunk@50713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 18:06:59 +00:00
ryelle
ecc13d3de2 Bundled Themes: Introduce block patterns for Twenty Eleven.
Props beafialho, kjellr, melchoyce, audrasjb.
Fixes #51106.


Built from https://develop.svn.wordpress.org/trunk@51103


git-svn-id: http://core.svn.wordpress.org/trunk@50712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 18:03:59 +00:00
youknowriad
62be41c079 Block Editor: Allow themes to add inline styles for all blocks when using lazy styles loading.
Props aristath.
Fixes #53358.

Built from https://develop.svn.wordpress.org/trunk@51102


git-svn-id: http://core.svn.wordpress.org/trunk@50711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 17:36:58 +00:00
youknowriad
1a7f28b3cd Block Editor: Package updates for WordPress 5.8 beta 1 (batch2).
This includes the following fixes:

 - Fix inspector opening when clicking outside the widget areas
 - Assume light theme when a transparent background is used
 - Make Post blocks non editable inside Query block
 - Rename QueryLoop to PostTemplate block

Props ntsekouras.
See #52991.

Built from https://develop.svn.wordpress.org/trunk@51101


git-svn-id: http://core.svn.wordpress.org/trunk@50710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 17:33:22 +00:00
desrosj
a44c69354d Twenty Twenty: Regenerate the RTL editor stylesheet.
This applies the change made in [51095] to the RTL stylesheet.

See #50120.
Built from https://develop.svn.wordpress.org/trunk@51100


git-svn-id: http://core.svn.wordpress.org/trunk@50709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 17:28:57 +00:00
desrosj
2f76f3279b Build/Test Tools: Update devDependencies for bundled themes.
This applies several minor updates bring `devDependencies` to their latest versions in Twenty Twenty-One, Twenty Twenty, and Twenty Nineteen.

Several other packages are also having their versions bumped as a result of running `npm audit fix`.

See #52624.
Built from https://develop.svn.wordpress.org/trunk@51099


git-svn-id: http://core.svn.wordpress.org/trunk@50708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 17:25:57 +00:00
ryelle
bb21c738ee Twenty Nineteen: Set a default color for button links in the editor.
Props mikejolley, poena, boniu91.
Fixes #52555.

Built from https://develop.svn.wordpress.org/trunk@51098


git-svn-id: http://core.svn.wordpress.org/trunk@50707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 17:21:59 +00:00
desrosj
7af8858ec7 Build/Test Tools: Update several devDependencies.
This updates `qunit`, `sass`, and `uglify-js` to thei latest versions.

Several other packages are also having their versions bumped as a result of running `npm audit fix`.

See #52624.
Built from https://develop.svn.wordpress.org/trunk@51097


git-svn-id: http://core.svn.wordpress.org/trunk@50706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 17:15:15 +00:00
ryelle
ebb9bdc7ca Twenty Nineteen: Fix pullquote styling in editor when block has alignment.
Props devnel, sabernhardt.
Fixes #53112.


Built from https://develop.svn.wordpress.org/trunk@51096


git-svn-id: http://core.svn.wordpress.org/trunk@50705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 16:50:57 +00:00
ryelle
f512feabe0 Twenty Twenty: Ensure custom primary color is applied to text in the editor.
Update the specificity of the custom CSS to match the editor styles. This overrides the default primary color with the selected custom color, matching the frontend display.

Props sabernhardt, notlaura.
Fixes #50120.


Built from https://develop.svn.wordpress.org/trunk@51095


git-svn-id: http://core.svn.wordpress.org/trunk@50704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-08 15:06:58 +00:00