Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-08-25 23:33:22 +02:00
Code Issues Projects Releases Wiki Activity
30,633 Commits 49 Branches 746 Tags 859 MiB
e6904bc0e8
Commit Graph

17869 Commits

Author SHA1 Message Date
Konstantin Obenland
f051c59433 Twenty Fifteen: Use default strings for comments link. 
Also adds context for screen readers, like in default strings.

Props pavelevap for initial patch.
Fixes #32001.


Built from https://develop.svn.wordpress.org/trunk@33003


git-svn-id: http://core.svn.wordpress.org/trunk@32974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-30 15:39:25 +00:00
Helen Hou-Sandí
e41b7b4f75 Image edit: Consistent whitespace for the side boxes. 
props tyxla.
fixes #31845.

Built from https://develop.svn.wordpress.org/trunk@33002


git-svn-id: http://core.svn.wordpress.org/trunk@32973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-30 15:19:25 +00:00
Konstantin Obenland
38e4211efb Use existing nomenclature pattern for Site Icon class. 
Props kraftbj.
Fixes #32834.


Built from https://develop.svn.wordpress.org/trunk@33001


git-svn-id: http://core.svn.wordpress.org/trunk@32972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-30 14:37:27 +00:00
Andrew Ozz
3a2741ca52 Add assertive capability to wp.a11y.speak(). 
Props afercia. See #32600.
Built from https://develop.svn.wordpress.org/trunk@33000


git-svn-id: http://core.svn.wordpress.org/trunk@32971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-30 04:35:24 +00:00
Andrew Ozz
b092defb17 Press This: 
- Add support for the Text editor.
- Add auto-scrolling when the caret moves out of the viewport while the user is typing (similarly to editor-expand).
- Add auto-resize for the textarea.
See #32706.
Built from https://develop.svn.wordpress.org/trunk@32999


git-svn-id: http://core.svn.wordpress.org/trunk@32970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-30 03:58:27 +00:00
Konstantin Obenland
36b24b073d Provide alt text for uploaded header images. 
The custom header screen will use it rather then the description,
if an alt text is set.

Props francoeurdavid, voldemortensen, valendesigns.
Fixes #27959.


Built from https://develop.svn.wordpress.org/trunk@32998


git-svn-id: http://core.svn.wordpress.org/trunk@32969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-29 21:32:26 +00:00
Boone Gorges
2a5bf835da Fix Tests_Post_GetPostClass::test_taxonomy_classes_hit_cache() after [32994]. 
[32994] results in an additional database query during automated testing, so
the query count being compared in this specific test must be incremented
manually.

See #16434.
Built from https://develop.svn.wordpress.org/trunk@32997


git-svn-id: http://core.svn.wordpress.org/trunk@32968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-29 14:32:24 +00:00
Boone Gorges
a3d9af584c Introduce 'wp_generate_tag_cloud_data' filter. 
This filter allows developers to modify the data that is used to create tag
clouds, without having to manipulate the tag cloud markup directly.

As part of the refactor, this changeset also adds a few unit tests for the way
`wp_generate_tag_cloud()` generates the 'title' attribute, as well as
improvements to output escaping.

Props flixos90, ysalame.
Fixes #24656.
Built from https://develop.svn.wordpress.org/trunk@32996


git-svn-id: http://core.svn.wordpress.org/trunk@32967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-29 14:16:26 +00:00
Boone Gorges
c91c28d501 Add some tests for wp_generate_tag_cloud(). 
Props welcher.
See #24656.
Built from https://develop.svn.wordpress.org/trunk@32995


git-svn-id: http://core.svn.wordpress.org/trunk@32966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-29 13:19:24 +00:00
Konstantin Obenland
c56a8ae0f7 Introducing Site Icon, favicon management for WordPress. 
This v1 marries Jetpack's Site Icon module with the Media Modal, reusing code
from the Custom Header admin. For now, the core-provided icons will be limited
to a favicon, an iOS app icon, and a Windows tile icon, leaving `.ico` support
and additional icons to plugins to add.

Props obenland, tyxla, flixos90, jancbeck, markjaquith, scruffian.
See #16434.


Built from https://develop.svn.wordpress.org/trunk@32994


git-svn-id: http://core.svn.wordpress.org/trunk@32965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-29 12:58:25 +00:00
Dion Hulse
2a35e075d7 XML-RPC: Only escape what we need to in wp.editPage, this allows for passwords with the special characters "' to work in a request. 
Props redsweater for initial Patch.
Fixes #32703

Built from https://develop.svn.wordpress.org/trunk@32993


git-svn-id: http://core.svn.wordpress.org/trunk@32964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-29 02:07:23 +00:00
Andrew Ozz
4605417b1c wpLink: always attempt to correct the URL before getting the URL field value. Fixes an edge case where the URL was not corrected when the user submitted the form by pressing Enter. 
Props andfinally. Fixes #32412.
Built from https://develop.svn.wordpress.org/trunk@32992


git-svn-id: http://core.svn.wordpress.org/trunk@32963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-28 23:07:25 +00:00
Helen Hou-Sandí
83e33a2ca0 List tables: Bring screen reader text for comments column title to media. 
see #32152, [31513].

Built from https://develop.svn.wordpress.org/trunk@32991


git-svn-id: http://core.svn.wordpress.org/trunk@32962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-28 15:44:25 +00:00
Aaron Jorbin
1525010f74 Deprecate php4 style constructors 
PHP7 is deprecating PHP4 style constructors, so we need to modify our code to have _construct methods that fire before the named PHP4 style constructors.  The PHP4 style constructors will call the PHP5 style constructor in case it is being called directly (usually via parent::METHOD).

This modifies external libraries to add PHP5 style constructors, but doesn't add a notice for when they are used.  In WordPress core code, PHP4 style constructors are being given a call to _deprecated_constructor. To the PHP4 style constructor I say "I know that I can't take no more | It ain't no lie | I wanna see you out that door | Baby, bye, bye, bye..."

Upstream: https://wiki.php.net/rfc/remove_php4_constructors

Props jdgrimes, netweb, jorbin
See #31982


Built from https://develop.svn.wordpress.org/trunk@32990


git-svn-id: http://core.svn.wordpress.org/trunk@32961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-28 15:27:24 +00:00
Aaron Jorbin
a6ebaefb92 Add Deprecated Constructor Function 
This function is one that can be called in core to indicate that a PHP4 style constructor is used. PHP4 style constructors are deprecated in PHP7.

Props jorbin, DrewAPicture for docs
See #31982


Built from https://develop.svn.wordpress.org/trunk@32989


git-svn-id: http://core.svn.wordpress.org/trunk@32960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-28 14:56:24 +00:00
Aaron Jorbin
c9307fc95a Update Grunt dev-dependencies 
grunt-browserify : minor version update
grunt-contrib-cssmin : minor version update
grunt-contrib-imagemin : patch version update
grunt-contrib-jshint : patch version update
grunt-contrib-uglify : minor version update (causes some changes to minified JS)
grunt-includes : minor version update
grunt-sass : major version update ( underlying libsass update ).

Props wonderboymusic
See #31700


Built from https://develop.svn.wordpress.org/trunk@32988


git-svn-id: http://core.svn.wordpress.org/trunk@32959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-28 14:51:30 +00:00
Konstantin Obenland
0704de88ea Customizer: Correct position for menu item delete icon in IE8. 
Props valendesigns.
Fixes #32675.


Built from https://develop.svn.wordpress.org/trunk@32987


git-svn-id: http://core.svn.wordpress.org/trunk@32958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-28 11:49:24 +00:00
Aaron Jorbin
4bbf254375 Add missing semicolon 
Introduced in [32983].

see #32757.

Built from https://develop.svn.wordpress.org/trunk@32986


git-svn-id: http://core.svn.wordpress.org/trunk@32957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-28 11:41:24 +00:00
Sergey Biryukov
bff91cfa5b Menus: Add a Manage in Customizer link, like we did for Widgets screen in [30459]. 
props celloexpressions.
fixes #32808.
Built from https://develop.svn.wordpress.org/trunk@32985


git-svn-id: http://core.svn.wordpress.org/trunk@32956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-28 06:08:24 +00:00
Sergey Biryukov
b26accf35a List tables: Select All should not be a column header. 
It sets a redundant relationship with all checkboxes in its column and also conveys wrong information for screen readers.

props afercia, valendesigns.
see #31654.
Built from https://develop.svn.wordpress.org/trunk@32984


git-svn-id: http://core.svn.wordpress.org/trunk@32955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-28 05:46:25 +00:00
Andrew Ozz
275fc220ef Press This: 
- Save a draft before opening the standard editor window.
- While saving a post show Saving... instead of Publish for the main visible part of the split button (same as the Save Draft button before).
See #32757.
Built from https://develop.svn.wordpress.org/trunk@32983


git-svn-id: http://core.svn.wordpress.org/trunk@32954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-28 04:59:24 +00:00
Sergey Biryukov
9665259675 Customizer: Increase color contrast ratio for menu locations text. 
props celloexpressions.
fixes #32727.
Built from https://develop.svn.wordpress.org/trunk@32982


git-svn-id: http://core.svn.wordpress.org/trunk@32953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-28 04:45:25 +00:00
Sergey Biryukov
9e445e3c30 Customizer: Add an aria-label attribute to the Add Items button to improve accessibility. 
props afercia.
fixes #32713.
Built from https://develop.svn.wordpress.org/trunk@32981


git-svn-id: http://core.svn.wordpress.org/trunk@32952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-28 04:28:24 +00:00
Scott Taylor
5b9b3cedea When searching for users using the search arg in get_users()/WP_User_Query, also search the user's email, url, and display name. 
Adds unit tests.

Props mordauk, wonderboymusic.
Fixes #27304.

Built from https://develop.svn.wordpress.org/trunk@32980


git-svn-id: http://core.svn.wordpress.org/trunk@32951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-28 00:36:24 +00:00
Scott Taylor
a59b2ffcae Update getID3 to 1.9.9 
Changelog:
* https://github.com/JamesHeinrich/getID3/blob/master/changelog.txt
* https://github.com/JamesHeinrich/getID3/compare/v1.9.8...v1.9.9

Fixes #32806.

Built from https://develop.svn.wordpress.org/trunk@32979


git-svn-id: http://core.svn.wordpress.org/trunk@32950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-28 00:17:25 +00:00
Scott Taylor
f077b3c511 Update jQuery to 1.11.3: 
http://blog.jquery.com/2015/04/28/jquery-1-11-3-and-2-1-4-released-ios-fail-safe-edition/

Changelog:
* https://github.com/jquery/jquery/issues?q=milestone%3A1.11.3%2F2.1.4
* https://github.com/jquery/jquery/compare/1.11.2...1.11.3

Props peterwilsoncc.
Fixes #32794.

Built from https://develop.svn.wordpress.org/trunk@32978


git-svn-id: http://core.svn.wordpress.org/trunk@32949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-27 23:40:23 +00:00
Scott Taylor
36513e9d7d After [32974], tweak some CSS for focus, etc. 
See #31650.

Built from https://develop.svn.wordpress.org/trunk@32977


git-svn-id: http://core.svn.wordpress.org/trunk@32948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-27 23:13:24 +00:00
Weston Ruter
e162bb8940 Customizer: Improve previewing setting changes for show_on_front, page_on_front, and page_for_posts. 
When changing the `page_on_front` setting (with `show_on_front`), change the previewed URL to be the home URL so that the effect can be seen. When changing `page_for_posts`, change the previewed URL to be the selected page.

Props valendesigns, westonruter.
Fixes #30677.


Built from https://develop.svn.wordpress.org/trunk@32976


git-svn-id: http://core.svn.wordpress.org/trunk@32947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-27 19:59:25 +00:00
Konstantin Obenland
77f385e532 Additional style changes to accomodate <h1> headings. 
See [32974], #31650.


Built from https://develop.svn.wordpress.org/trunk@32975


git-svn-id: http://core.svn.wordpress.org/trunk@32946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-27 15:51:23 +00:00
Konstantin Obenland
7dc1d06e64 Proper heading for admin screens. 
First step towards restoring a good heading structure in wp-admin.
The previous `<h1>` contained the site title and a link to the front page and was removed with the toolbar refactoring in 3.2.

Props joedolson, afercia.
Fixes #31650.


Built from https://develop.svn.wordpress.org/trunk@32974


git-svn-id: http://core.svn.wordpress.org/trunk@32945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-27 15:41:25 +00:00
Sergey Biryukov
aa6a58f155 Fix the dismissable notice button focus style, broken in [32475]. 
props afercia.
fixes #32797.
Built from https://develop.svn.wordpress.org/trunk@32973


git-svn-id: http://core.svn.wordpress.org/trunk@32944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-27 15:07:24 +00:00
Sergey Biryukov
c99db2bc59 Media modal: Use better descriptive text for "Remove" buttons. 
props afercia.
fixes #32792.
Built from https://develop.svn.wordpress.org/trunk@32972


git-svn-id: http://core.svn.wordpress.org/trunk@32943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-27 14:51:26 +00:00
Dominik Schilling
2ecb586214 Customizer: Add an aria-expanded attribute to the Add Menu button to improve accessibility. 
props afercia.
fixes #32791.
Built from https://develop.svn.wordpress.org/trunk@32971


git-svn-id: http://core.svn.wordpress.org/trunk@32942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-27 10:05:24 +00:00
Dominik Schilling
2d9a46b973 Customizer: Remove top margin when dragging menu items. 
The markup was changed in [32889].

props tywayne.
fixes #32745.
Built from https://develop.svn.wordpress.org/trunk@32970


git-svn-id: http://core.svn.wordpress.org/trunk@32941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-27 09:47:23 +00:00
Sergey Biryukov
74c7f59bb2 Revert [32702]. The URL may not have an s parameter as there are filters in place so that a plugin can return a URL with a completely different structure. 
see #32572.
Built from https://develop.svn.wordpress.org/trunk@32969


git-svn-id: http://core.svn.wordpress.org/trunk@32940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-27 08:35:24 +00:00
Andrew Ozz
81d0434421 TinyMCE: prevent undefined error in toolbar.hide(). 
See #32604.
Built from https://develop.svn.wordpress.org/trunk@32968


git-svn-id: http://core.svn.wordpress.org/trunk@32939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-27 02:24:25 +00:00
Andrew Ozz
e311b53cfc TinyMCE, inline link toolbar: tweak styling on small screens to fix wrapping in iOS. 
See #32604.
Built from https://develop.svn.wordpress.org/trunk@32967


git-svn-id: http://core.svn.wordpress.org/trunk@32938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-27 02:21:24 +00:00
Andrew Ozz
7715a50c0b Press This: fix iOS bug that prevents closing of the split button when tapping outside of it. 
See #32757.
Built from https://develop.svn.wordpress.org/trunk@32966


git-svn-id: http://core.svn.wordpress.org/trunk@32937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-27 02:15:24 +00:00
Scott Taylor
8b1286417e ob_get_contents() followed by ob_end_clean() can be replaced by ob_get_clean(). 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32965


git-svn-id: http://core.svn.wordpress.org/trunk@32936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-27 01:12:24 +00:00
Scott Taylor
a0e373ef80 For doc block types, favor bool over the few remaining booleans 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32964


git-svn-id: http://core.svn.wordpress.org/trunk@32935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-27 01:03:25 +00:00
Scott Taylor
642af1f3f4 Some doc blocks should use bool instead of true|false 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32963


git-svn-id: http://core.svn.wordpress.org/trunk@32934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-27 00:45:24 +00:00
Scott Taylor
60b8e86b36 In WP_Filesystem_Base::chdir|chgrp|chmod() (all mock abstract methods), modify @return to include string so that subclass @returns match. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32962


git-svn-id: http://core.svn.wordpress.org/trunk@32933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-27 00:43:24 +00:00
Scott Taylor
40325262ef Declare visibility for WP_Locale methods. 
See #32444.


Built from https://develop.svn.wordpress.org/trunk@32961


git-svn-id: http://core.svn.wordpress.org/trunk@32932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-27 00:32:23 +00:00
Andrew Ozz
b9e796a5c1 TinyMCE: prevent error in the wptextpattern plugin when the first child node in a paragraph is not a text node. 
See #31441;
Built from https://develop.svn.wordpress.org/trunk@32960


git-svn-id: http://core.svn.wordpress.org/trunk@32931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-26 23:19:24 +00:00
Andrew Ozz
4857824377 Update Twemoji to 1.4.1 including up to 3c0c13d3a5 (exclude SVG elements). Remove our hacks and adapt wp-emoji.js to use the new image attributes callback. 
Fixes #32203.
Built from https://develop.svn.wordpress.org/trunk@32959


git-svn-id: http://core.svn.wordpress.org/trunk@32930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-26 22:01:25 +00:00
Andrew Ozz
1f75220e9a TinyMCE, inline link toolbar: fix z-index bug in iOS Safari. 
See #32604.
Built from https://develop.svn.wordpress.org/trunk@32958


git-svn-id: http://core.svn.wordpress.org/trunk@32929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-26 20:29:24 +00:00
Andrew Ozz
7a4c8d8977 TinyMCE: add the editor focusing help the Keyboard Shortcuts modal. 
See #31913.
Built from https://develop.svn.wordpress.org/trunk@32957


git-svn-id: http://core.svn.wordpress.org/trunk@32928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-26 18:49:25 +00:00
Andrew Ozz
5f041b37bf TinyMCE, inline link toolbar: fix styling on small screens so the displayed URL is not needlessly truncated. 
See #32604.
Built from https://develop.svn.wordpress.org/trunk@32956


git-svn-id: http://core.svn.wordpress.org/trunk@32927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-26 17:55:25 +00:00
Dominik Schilling
a6b7a691be Customizer: Prevent dragging menu items above the main heading. 
Improve targeting for the `sortableItems`, resolving an issue where the first `<li>` in the control became a sortable target, allowing the user to drag a single top level menu outside the intended sortable area.

props adamsilverstein.
fixes #32738.
#wceu
Built from https://develop.svn.wordpress.org/trunk@32955


git-svn-id: http://core.svn.wordpress.org/trunk@32926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-26 17:11:24 +00:00
Boone Gorges
d99f9d3a22 Improve error checking in get_edit_term_link(). 
The function should not throw notices when an improper term or taxonomy is
passed.

Props tmatsuur, MikeHansenMe.
Fixes #32786.
Built from https://develop.svn.wordpress.org/trunk@32954


git-svn-id: http://core.svn.wordpress.org/trunk@32925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-26 14:13:24 +00:00
Boone Gorges
40ab4567e7 Introduce WP_UnitTestCase::delete_user(). 
This static method provides a multisite-agnostic way to delete users during
automated testing.

See #32796.
Built from https://develop.svn.wordpress.org/trunk@32953


git-svn-id: http://core.svn.wordpress.org/trunk@32924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-26 12:59:26 +00:00
Scott Taylor
72bf48f0b9 In Media microtemplates after [32467], use <button> instead of <a> for several more non-links. 
Props afercia.
Fixes #26550.

Built from https://develop.svn.wordpress.org/trunk@32952


git-svn-id: http://core.svn.wordpress.org/trunk@32923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-26 05:01:24 +00:00
Andrew Ozz
561ca94998 TinyMCE: update the Keyboard Shortcuts help modal, use the TinyMCE UI API instead of an iframe. 
Props iseulde, azaozz. Fixes #31913.
Built from https://develop.svn.wordpress.org/trunk@32951


git-svn-id: http://core.svn.wordpress.org/trunk@32922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-26 04:40:24 +00:00
Dion Hulse
4df2bd0b2a Remove an undeeded space concatenation from wpmu_validate_user_signup(). 
This was previously used to prevent `strpos()` returning 0, which is not needed after r32942.
See #32444

Built from https://develop.svn.wordpress.org/trunk@32950


git-svn-id: http://core.svn.wordpress.org/trunk@32921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-26 01:39:25 +00:00
Scott Taylor
747b1eb713 After [32866], fix doc blocks. 
Props DrewAPicture.
See #32363.

Built from https://develop.svn.wordpress.org/trunk@32949


git-svn-id: http://core.svn.wordpress.org/trunk@32920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 21:02:25 +00:00
Scott Taylor
7537240d37 List tables: when post navigation links point to the current page, use <span>s and text instead of <a>s. 
Props afercia.
Fixes #32253.

Built from https://develop.svn.wordpress.org/trunk@32948


git-svn-id: http://core.svn.wordpress.org/trunk@32919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 20:32:26 +00:00
Scott Taylor
7a264022e7 After [32896], update ConvertChars.php unit tests and rename to ConvertInvalidEntries.php. 
Props boonebgorges.
Fixes #32335.

Built from https://develop.svn.wordpress.org/trunk@32947


git-svn-id: http://core.svn.wordpress.org/trunk@32918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 19:51:27 +00:00
Scott Taylor
2518b37222 Admin menu: improve accessibility when collapsed. 
Props afercia.
Fixes #32346.

Built from https://develop.svn.wordpress.org/trunk@32946


git-svn-id: http://core.svn.wordpress.org/trunk@32917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 19:33:26 +00:00
Scott Taylor
587c570efa After [32796], improve the accessibility and markup for instances of touch_time(). 
Props rianrietveld, afercia.
Fixes #31714.

Built from https://develop.svn.wordpress.org/trunk@32945


git-svn-id: http://core.svn.wordpress.org/trunk@32916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 19:30:25 +00:00
Andrew Ozz
7142248743 Press This: better screen reader text for the arrow part of the split button. 
Props afercia. See #32757.
Built from https://develop.svn.wordpress.org/trunk@32944


git-svn-id: http://core.svn.wordpress.org/trunk@32915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 19:24:25 +00:00
Scott Taylor
26855e651b In get_site_option() and get_option(), ensure that $notoptions is an array before writing to it. Prevents a flood of Cannot use a scalar value as an array, because $notoptions is otherwise set to the result of wp_cache_get(), which returns mixed. 
Props hauvong.
Fixes #31147.

Built from https://develop.svn.wordpress.org/trunk@32943


git-svn-id: http://core.svn.wordpress.org/trunk@32914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 19:01:26 +00:00
Scott Taylor
aaa99969e4 wpmu_validate_user_signup() should strictly check against false when using strpos(). 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32942


git-svn-id: http://core.svn.wordpress.org/trunk@32913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 16:57:26 +00:00
Scott Taylor
b3ecfda08d WP_Rewrite::add_rule() should strictly check against false when using strpos(). 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32941


git-svn-id: http://core.svn.wordpress.org/trunk@32912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 16:56:25 +00:00
Scott Taylor
b9e8ee95b5 prep_atom_text_construct() and before_last_bar() should strictly check against false when using str(r)?pos(). 
Sidenote: there's a function named `before_last_bar`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32940


git-svn-id: http://core.svn.wordpress.org/trunk@32911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 16:49:25 +00:00
Scott Taylor
7453d12390 Remove unused code from WP_Press_This::html(). 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32939


git-svn-id: http://core.svn.wordpress.org/trunk@32910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 16:38:25 +00:00
Scott Taylor
d9bd43c702 Remove unused code from WP_MS_Sites_List_Table::display_rows(). 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32938


git-svn-id: http://core.svn.wordpress.org/trunk@32909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 16:36:29 +00:00
Andrew Ozz
8005ccff74 TinyMCE, inline link toolbar: 
- Add max-width for all floating toolbars.
- Ensure the inline link toolbar doesn't exceed the width on small screen devices.
- Do not cut/concatenate the URL when it is less than 40 characters long.
- Show more of the URL if the beginning part plus the ending part are less than 40 characters long.
See #32604.
Built from https://develop.svn.wordpress.org/trunk@32937


git-svn-id: http://core.svn.wordpress.org/trunk@32908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 04:42:28 +00:00
Andrew Ozz
d3ee649cb9 Press This: support passing i parameter to add an image src. 
Props stephdau, azaozz. Fixes #32173.
Built from https://develop.svn.wordpress.org/trunk@32936


git-svn-id: http://core.svn.wordpress.org/trunk@32907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 03:06:25 +00:00
Andrew Ozz
eaadfde950 Define SCRIPT_DEBUG early on every load, similarly to WP_DEBUG. Remove defined( 'SCRIPT_DEBUG' ) checks. 
Fixes #32333.
Built from https://develop.svn.wordpress.org/trunk@32935


git-svn-id: http://core.svn.wordpress.org/trunk@32906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 02:29:31 +00:00
Andrew Ozz
d4f3428d5f Press This, split button: wrap the sub-buttons in an unordered list to aid accessibility. 
Props afercia. See #32757.
Built from https://develop.svn.wordpress.org/trunk@32934


git-svn-id: http://core.svn.wordpress.org/trunk@32905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 01:55:30 +00:00
John Blackbourn
b5973e92ec Introduce a no_terms label for taxonomies. This label is used when indicating that there are no terms in the given taxonomy associated with an object. 
Fixes #32150
Props afercia

Built from https://develop.svn.wordpress.org/trunk@32933


git-svn-id: http://core.svn.wordpress.org/trunk@32904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-25 00:16:27 +00:00
Ella Iseulde Van Dorpe
af4f2bd1e8 wplink: update TinyMCE UI after updating the link 
See #32604.

Built from https://develop.svn.wordpress.org/trunk@32932


git-svn-id: http://core.svn.wordpress.org/trunk@32903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-24 23:23:26 +00:00
Ella Iseulde Van Dorpe
d710b768eb TinyMCE: wplink: add inline toolbar 
Now the URL can be viewed as soon as you put the cursor in an anchor tag. Clicking on it will open the page in a new tab. You also have the edit and remove button close at hand.

First run.
See #32604.

Built from https://develop.svn.wordpress.org/trunk@32931


git-svn-id: http://core.svn.wordpress.org/trunk@32902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-24 23:05:26 +00:00
Scott Taylor
d8b13fa32b YouTube oEmbed parsing: support the m subdomain. 
Adds unit tests.

Props Toru, johnbillion.
Fixes #32714.

Built from https://develop.svn.wordpress.org/trunk@32930


git-svn-id: http://core.svn.wordpress.org/trunk@32901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-24 21:06:26 +00:00
Scott Taylor
f23199caaa Remove the whois.arin.net link from wp_notify_postauthor() and wp_notify_moderator(). 
Also, remove from `edit-form-comment.php` and add a new filter: `edit_comment_misc_actions`. 

Props ozh, joedolson, rachelbaker.
Fixes #15281.

Built from https://develop.svn.wordpress.org/trunk@32929


git-svn-id: http://core.svn.wordpress.org/trunk@32900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-24 20:56:27 +00:00
Sergey Biryukov
3f448d7cd5 Add editor_stylesheets filter to get_editor_stylesheets(). 
props danielbachhuber, MikeHansenMe.
fixes #31672.
Built from https://develop.svn.wordpress.org/trunk@32928


git-svn-id: http://core.svn.wordpress.org/trunk@32899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-24 13:32:32 +00:00
Drew Jaynes
e9758d4e48 Fix a typo in the DocBlock for get_plugins(). 
Props onnimonni, swissspidy.
Fixes #32758.

Built from https://develop.svn.wordpress.org/trunk@32927


git-svn-id: http://core.svn.wordpress.org/trunk@32898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-24 12:22:27 +00:00
Drew Jaynes
e872f02bc8 Document default values for optional arguments in edit_term_link(). 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32926


git-svn-id: http://core.svn.wordpress.org/trunk@32897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-24 10:56:27 +00:00
Drew Jaynes
8a6f4cb0ef Add missing documentation for the $echo parameter in the DocBlock for edit_term_link(). 
Props tmatsuur.
Fixes #32776.

Built from https://develop.svn.wordpress.org/trunk@32925


git-svn-id: http://core.svn.wordpress.org/trunk@32896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-24 10:53:28 +00:00
Dion Hulse
42fbb6568e WP Filesystem: Correctly set the @since for WP_Filesystem_Base::getchmod() added in r32923. 
This is 2.5.0 as that's when the function become available in all subclasses.
See #29548

Built from https://develop.svn.wordpress.org/trunk@32924


git-svn-id: http://core.svn.wordpress.org/trunk@32895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-24 04:52:25 +00:00
Dion Hulse
8f47efe7dc WP Filesystem: Correctly parse the permissions field in the directory listings, and actually set it in FTP environments 
Props mnelson4 for initial patch.
Fixes #29548

Built from https://develop.svn.wordpress.org/trunk@32923


git-svn-id: http://core.svn.wordpress.org/trunk@32894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-24 04:49:25 +00:00
Andrew Ozz
dfaa89d853 Press This: fix spinner position relative to the split button. 
See #32757.
Built from https://develop.svn.wordpress.org/trunk@32922


git-svn-id: http://core.svn.wordpress.org/trunk@32893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-24 03:32:25 +00:00
Andrew Ozz
f8cf80e9b1 Press This: ensure proper tab order in the split button. Tweak padding and border color a bit. 
See #32757.
Built from https://develop.svn.wordpress.org/trunk@32921


git-svn-id: http://core.svn.wordpress.org/trunk@32892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-24 03:23:27 +00:00
Andrew Ozz
f4109b0c5d Press This: convert the Preview | Save | Publish buttons to a split button. 
See #32757.
Built from https://develop.svn.wordpress.org/trunk@32920


git-svn-id: http://core.svn.wordpress.org/trunk@32891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-24 02:46:27 +00:00
John Blackbourn
0fdc7bb582 Implement tests for the upload_mimes filter to ensure it prevents the upload of disallowed file types. 
See #32693

Built from https://develop.svn.wordpress.org/trunk@32919


git-svn-id: http://core.svn.wordpress.org/trunk@32890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-24 00:43:26 +00:00
John Blackbourn
f4ec9be456 Implement canonical and url_to_postid() tests for child pages which share a post name with other child pages. 
See #32759

Built from https://develop.svn.wordpress.org/trunk@32918


git-svn-id: http://core.svn.wordpress.org/trunk@32889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-24 00:41:27 +00:00
John Blackbourn
3c7ea03cb0 Correct the title used on the user dashboard. 
Fixes #32754
Props johnjamesjacoby

Built from https://develop.svn.wordpress.org/trunk@32917


git-svn-id: http://core.svn.wordpress.org/trunk@32888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-24 00:37:28 +00:00
Scott Taylor
8854256155 Because programming is fun. After [32915], _.find() will return undefined if an empty array is passed - in that case, the function should return true. 
See #32746.

Built from https://develop.svn.wordpress.org/trunk@32916


git-svn-id: http://core.svn.wordpress.org/trunk@32887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-23 19:43:25 +00:00
Scott Taylor
15bfe75f88 When filtering media by type in wp.media.model.Attachments.filters.type(), account for the library's type being an array of full mime-types. 
Fixes #32746.

Built from https://develop.svn.wordpress.org/trunk@32915


git-svn-id: http://core.svn.wordpress.org/trunk@32886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-23 19:40:26 +00:00
Scott Taylor
3b88c839f9 In wp_prepare_attachment_for_js(), when setting filename, call wp_basename() on the result of get_attached_file(), not WP_Post->guid. guid can be set to the result get_permalink(), which is not a file path. 
Props daxelrod.
Fixes #32531.

Built from https://develop.svn.wordpress.org/trunk@32914


git-svn-id: http://core.svn.wordpress.org/trunk@32885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-23 18:30:26 +00:00
Scott Taylor
f61501f57f The query-attachments AJAX action immediately errors out if the user doesn't have the upload_files cap. As such, the Customizer shouldn't show buttons that launch the media modal when the user doesn't have the proper permissions to query attachments. 
See #32654.

Built from https://develop.svn.wordpress.org/trunk@32913


git-svn-id: http://core.svn.wordpress.org/trunk@32884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-23 18:20:27 +00:00
Boone Gorges
3ffe2a059d Add expectedDeprecated flags to wp_richedit_pre() and wp_htmledit_pre() unit tests. 
These functions were deprecated in [32899].

See #32425.
Built from https://develop.svn.wordpress.org/trunk@32912


git-svn-id: http://core.svn.wordpress.org/trunk@32883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-23 14:42:26 +00:00
Boone Gorges
fdd0917471 In WP_Comment_Query, parse meta_query vars after the pre_get_comments hook. 
[31467] included a change that involved generating meta_query SQL before the
`pre_get_comments` hook, with the result that `pre_get_comments` callbacks were
no longer able to modify comment meta queries. We fix the problem by moving the
SQL generation to after the hook.

This changeset also includes a second call to `meta_query->parse_query_vars()`,
to ensure that modifications to metadata-related query vars (such as `meta_key`
and `meta_value`) performed in `pre_get_comments` callbacks have the expected
effect on the comment query.

Fixes #32762.
Built from https://develop.svn.wordpress.org/trunk@32911


git-svn-id: http://core.svn.wordpress.org/trunk@32882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-23 14:36:27 +00:00
Boone Gorges
03be8647c5 Fix PHP notice in WP_Tax_Query::get_sql_for_clause(). 
Previously, the `$where` variable was not initialized, so that when an invalid
'operator' was passed, PHP would complain that `$where` was undefined.

Props dlh.
Fixes #32756.
Built from https://develop.svn.wordpress.org/trunk@32910


git-svn-id: http://core.svn.wordpress.org/trunk@32881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-23 12:44:27 +00:00
Scott Taylor
b30b08fd92 Refresh attachment links in the media modal are unneeded since bringing the image editor into it in [27445]. 
Props rommelxcastro.
Fixes #32550.

Built from https://develop.svn.wordpress.org/trunk@32909


git-svn-id: http://core.svn.wordpress.org/trunk@32880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-22 21:33:26 +00:00
Scott Taylor
8c7e1b8ac0 In wp.media.view.UploaderStatus.filename(), don't truncate the filename. 
Props helen.
Fixes #31216.

Built from https://develop.svn.wordpress.org/trunk@32908


git-svn-id: http://core.svn.wordpress.org/trunk@32879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-22 21:26:26 +00:00
Scott Taylor
994881d211 Add a label to the content field in the Text Widget for screen readers. 
Props afercia.
Fixes #32736.

Built from https://develop.svn.wordpress.org/trunk@32907


git-svn-id: http://core.svn.wordpress.org/trunk@32878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-22 21:22:26 +00:00
Scott Taylor
744cc75cd1 Sanitize the class passed to wp_list_bookmarks() and allow passing an array. 
Props ryan, obenland.
Fixes #23150.

Built from https://develop.svn.wordpress.org/trunk@32906


git-svn-id: http://core.svn.wordpress.org/trunk@32877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-22 20:55:28 +00:00
Scott Taylor
00de0e6341 In unregister_setting(), search for $option_name in a segment of $new_whitelist_options keyed by $option_group. 
Props nofearinc.
Fixes #26479.

Built from https://develop.svn.wordpress.org/trunk@32905


git-svn-id: http://core.svn.wordpress.org/trunk@32876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-22 20:51:26 +00:00
Scott Taylor
d6c644d8df After [32884], update the default value for comment_shortcuts. 
Props dlh, rachelbaker, DrewAPicture.
Fixes #31588.

Built from https://develop.svn.wordpress.org/trunk@32904


git-svn-id: http://core.svn.wordpress.org/trunk@32875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-22 20:44:26 +00:00
Scott Taylor
b8f49cebee List table views: fix missing current class for "All" when logged in as an author. 
Props afercia.
Fixes #32015.

Built from https://develop.svn.wordpress.org/trunk@32903


git-svn-id: http://core.svn.wordpress.org/trunk@32874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-22 20:39:27 +00:00
Helen Hou-Sandí
5a07e4bba4 Add "Scheduled" to post states. 
props rclations.
fixes #32131.

Built from https://develop.svn.wordpress.org/trunk@32902


git-svn-id: http://core.svn.wordpress.org/trunk@32873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-22 16:07:26 +00:00
Sergey Biryukov
4332d8dfc0 Avoid a PHP notice in WP_Press_This::get_suggested_content() after [32828]. 
props kraftbj.
fixes #32751.
Built from https://develop.svn.wordpress.org/trunk@32901


git-svn-id: http://core.svn.wordpress.org/trunk@32872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-22 15:20:28 +00:00
Andrew Ozz
baa8e833ff Fix typo/white space in the docs. 
See #32425.
Built from https://develop.svn.wordpress.org/trunk@32900


git-svn-id: http://core.svn.wordpress.org/trunk@32871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-21 22:08:28 +00:00
Andrew Ozz
e4758f42e5 Update the TinyMCE initialization: 
- Replace `wp_htmledit_pre()` and `wp_richedit_pre()` with `format_for_editor()`.
- Replace the `'htmledit_pre'` and `'richedit_pre'` filters with `'format_for_editor'`.
- Do not run the post content through `wpautop()` in PHP when the visual editor is default. Run the textarea content through the JS wpautop on initializing TinyMCE.
- Simplify both editors initialization.
- Improve setting of `wpActiveEditor` in Quicktags.
- Improve editor.js, use `tinymce.$` when possible.
See #32425.
Built from https://develop.svn.wordpress.org/trunk@32899


git-svn-id: http://core.svn.wordpress.org/trunk@32870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-21 22:01:28 +00:00
Boone Gorges
a680859400 Pass stylesheet URL as an argument to 'style_loader_tag' filter. 
This change brings the filter's signature in line with 'script_loader_tag'.

Props nicholas_io.
Fixes #32660.
Built from https://develop.svn.wordpress.org/trunk@32898


git-svn-id: http://core.svn.wordpress.org/trunk@32869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-21 19:35:26 +00:00
Dominik Schilling
4423739c65 Use 3-digit x.x.x style for 4.3.0 @since versions. 
see #32335, #32430.
Built from https://develop.svn.wordpress.org/trunk@32897


git-svn-id: http://core.svn.wordpress.org/trunk@32868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-21 11:41:26 +00:00
Andrew Ozz
b9a4fefb08 Update convert_chars(): 
- Stop trying to remove `<title>` and `<category>` meta tags. They have not been used for many many years.
- Replacement of `<br>` with `<br />` and `<hr>` with `<hr />` is not needed for HTML 5.0. Also, these tags are formatted like that by the visual editor.
- Replace invalid HTML entities that might be pasted in the Text editor on save instead of on display.
Fixes #32335.
Built from https://develop.svn.wordpress.org/trunk@32896


git-svn-id: http://core.svn.wordpress.org/trunk@32867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-21 00:59:26 +00:00
Dominik Schilling
095dfe5386 Customizer: Fix live preview for menu item titles. 
Show also a default label for menu items without a label which are assigned to a menu. This is currently only supported in the Customizer, see #24146 for nav menus screen.

see #32576.
Built from https://develop.svn.wordpress.org/trunk@32895


git-svn-id: http://core.svn.wordpress.org/trunk@32866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-20 22:33:26 +00:00
Andrew Ozz
c13cb27c14 Fix error when dropping files for uploading on the editor before the media modal is initialized. 
Props rommelxcastro, sebastiantiede. Fixes #32527.
Built from https://develop.svn.wordpress.org/trunk@32894


git-svn-id: http://core.svn.wordpress.org/trunk@32865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-20 21:08:26 +00:00
Dominik Schilling
759bcdbad1 Customizer: Escape original title of menu items. 
see #32576.
Built from https://develop.svn.wordpress.org/trunk@32893


git-svn-id: http://core.svn.wordpress.org/trunk@32864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-20 19:55:25 +00:00
Dominik Schilling
f127478bde Customizer: Improve handling of posts with no title. 
Use the `#%d (no title)` string as a fallback which is already used on the nav menus screen.
Add a translator comment to all occurrences of the `#%d (no title)` string.

see #32576.
Built from https://develop.svn.wordpress.org/trunk@32892


git-svn-id: http://core.svn.wordpress.org/trunk@32863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-20 19:50:26 +00:00
Dominik Schilling
baeadbb6fb Customizer: Accessibility improvements for menu item searches. 
* Add a description and an `aria-describedby` attribute to inform users this is a "live" search.
* Announce the number of search results via `wp.a11y.speak`.
* Use `aria-busy` attribute to stop screen readers announcing content while the "loading more results" is running.
* Increase the search debounce wait interval to 500ms to be consistent with other live searches.
* If a search fails don't call `wp.a11y.speak` with an undefined variable.

props afercia.
see #32720.
Built from https://develop.svn.wordpress.org/trunk@32891


git-svn-id: http://core.svn.wordpress.org/trunk@32862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-20 19:22:25 +00:00
Dominik Schilling
4a13015c98 Customizer: Don't add a menu item twice when using the keyboard. 
Buttons don't need keyboard events, they natively support keyboard interaction and they just need a click event.

fixes #32665.
Built from https://develop.svn.wordpress.org/trunk@32890


git-svn-id: http://core.svn.wordpress.org/trunk@32861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-20 19:01:25 +00:00
Dominik Schilling
2e8245ba0e Customizer: Use valid markup for menu items. 
Replace `<d(l|t)>` with `<div>` for `.menu-item-bar` and `.menu-item-handle`.

see #32724, #32721, #31817.
Built from https://develop.svn.wordpress.org/trunk@32889


git-svn-id: http://core.svn.wordpress.org/trunk@32860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-20 18:47:27 +00:00
Dominik Schilling
1d953f8258 Customizer: Make labels of the menu item reorder buttons translatable. 
see #32576.
Built from https://develop.svn.wordpress.org/trunk@32888


git-svn-id: http://core.svn.wordpress.org/trunk@32859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-20 18:40:25 +00:00
Dominik Schilling
8fe9d04bf9 Customizer: Replace wrong usage of _x() with translator comments. 
see #32576.
Built from https://develop.svn.wordpress.org/trunk@32887


git-svn-id: http://core.svn.wordpress.org/trunk@32858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-20 18:33:26 +00:00
Dominik Schilling
5c2d8c6b07 Customizer: Rename label for custom links to "Custom Links", see [31748]. 
props paulwilde
fixes #32732.
Built from https://develop.svn.wordpress.org/trunk@32886


git-svn-id: http://core.svn.wordpress.org/trunk@32857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-20 18:29:26 +00:00
Dominik Schilling
4fdc99d2d1 Customizer: Decode HTML entities in the label property of WP_Customize_Media_Control. 
fixes #31631.
Built from https://develop.svn.wordpress.org/trunk@32885


git-svn-id: http://core.svn.wordpress.org/trunk@32856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-20 18:15:26 +00:00
Drew Jaynes
1077b83a20 Update the DocBlock for wp_insert_post() to exclude now-defunct contact method arguments and clarify others. 
Also clarifies information on available hooks and adds a changelog entry for when the contact method arguments were removed.

Props dlh, rachelbaker.
See #31588.

Built from https://develop.svn.wordpress.org/trunk@32884


git-svn-id: http://core.svn.wordpress.org/trunk@32855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-20 02:53:27 +00:00
Andrew Ozz
9828f9056e Editor: add ARIA labels to the Quicktags buttons to improve accessibility. 
Props afercia, azaozz. Fixes #31522.
Built from https://develop.svn.wordpress.org/trunk@32883


git-svn-id: http://core.svn.wordpress.org/trunk@32854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-20 02:16:25 +00:00
Drew Jaynes
e2c7542b68 Add a changelog entry to the DocBlock for language_attributes() noting that it was converted into a wrapper for get_language_attributes() in 4.3. 
See [32868]. See #28180.

Built from https://develop.svn.wordpress.org/trunk@32882


git-svn-id: http://core.svn.wordpress.org/trunk@32853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 23:01:26 +00:00
Scott Taylor
a28f09a32c Correct inline doc for $public in register_post_status(). 
Props ericlewis.
Fixes #32061.

Built from https://develop.svn.wordpress.org/trunk@32881


git-svn-id: http://core.svn.wordpress.org/trunk@32852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 22:35:25 +00:00
Scott Taylor
ada4394034 Use GPL-2.0+ for the value of license in package.json 
Props netweb.
Fixes #32718.

Built from https://develop.svn.wordpress.org/trunk@32880


git-svn-id: http://core.svn.wordpress.org/trunk@32851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 22:32:27 +00:00
Scott Taylor
92d67bf395 Use valid markup in Walker_Nav_Menu_Edit::start_el() - replace <d(l|t)> with <div> for .menu-item-bar and .menu-item-handle. 
Props sagarjadhav.
Fixes #31817.

Built from https://develop.svn.wordpress.org/trunk@32879


git-svn-id: http://core.svn.wordpress.org/trunk@32850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 22:22:26 +00:00
Scott Taylor
88743c7cd7 Add missing access modifiers in class-wp-customize-setting.php. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32878


git-svn-id: http://core.svn.wordpress.org/trunk@32849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 22:08:26 +00:00
Scott Taylor
eb4cd4880b Add missing access modifier to WP_Customize_Sidebar_Section::json(). 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32877


git-svn-id: http://core.svn.wordpress.org/trunk@32848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 22:06:27 +00:00
Scott Taylor
55b2385cf5 Add missing access modifier to WP_Customize_Nav_Menus_Panel::wp_nav_menu_manage_columns(). 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32876


git-svn-id: http://core.svn.wordpress.org/trunk@32847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 22:05:25 +00:00
Scott Taylor
dd2ec86e87 Add missing access modifiers to WP_Customize_Nav_Menus. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32875


git-svn-id: http://core.svn.wordpress.org/trunk@32846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 22:04:28 +00:00
Scott Taylor
5e994cd6a1 Customizer et al, use elseif in PHP, not else if. 
This was corrected via brute force in [31090].

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32874


git-svn-id: http://core.svn.wordpress.org/trunk@32845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 22:01:25 +00:00
Scott Taylor
a75961da89 Add access modifier to WP_Customize_Nav_Menu_Item_Control::json() 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32873


git-svn-id: http://core.svn.wordpress.org/trunk@32844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 21:55:24 +00:00
Scott Taylor
24bae70080 Add access modifier to WP_Customize_Nav_Menu_Control::json() 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32872


git-svn-id: http://core.svn.wordpress.org/trunk@32843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 21:54:25 +00:00
Scott Taylor
032ea5b132 Add access modifier to WP_Upgrader::clear_destination() 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32871


git-svn-id: http://core.svn.wordpress.org/trunk@32842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 21:53:25 +00:00
Scott Taylor
23e02fafce Edit Post screen messages need to run preview URLs through the preview_post_link filter. 
Props pareshradadiya.
Fixes #32191.

Built from https://develop.svn.wordpress.org/trunk@32870


git-svn-id: http://core.svn.wordpress.org/trunk@32841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 21:49:25 +00:00
Scott Taylor
86beb35f6d Use <button> instead of <a> for non-link links in Quick Edit. 
Props afercia.
Fixes #32213.

Built from https://develop.svn.wordpress.org/trunk@32869


git-svn-id: http://core.svn.wordpress.org/trunk@32840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 21:42:27 +00:00
Scott Taylor
38037c8d62 Add get_language_attributes(), which is then used by (...drum roll...) language_attributes(). 
Props johnbillion, posykrat, PeterRKnight.
Fixes #28180.

Built from https://develop.svn.wordpress.org/trunk@32868


git-svn-id: http://core.svn.wordpress.org/trunk@32839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 21:36:28 +00:00
Scott Taylor
0c866cfa79 Check is_callable() in do_shortcode_tag(), not add_shortcode(). 
Add a `_doing_it_wrong()` in `do_shortcode_tag()` when `is_callable()` is `false`.

Props aaroncampbell.
See #32445.

Built from https://develop.svn.wordpress.org/trunk@32867


git-svn-id: http://core.svn.wordpress.org/trunk@32838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 21:33:25 +00:00
Scott Taylor
ec6dfc7f2b Add a filter in wp_get_attachment_image_src() called attachment_image_src. 
Props eclev91, MikeHansenMe.
Fixes #32363.

Built from https://develop.svn.wordpress.org/trunk@32866


git-svn-id: http://core.svn.wordpress.org/trunk@32837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 21:27:25 +00:00
Scott Taylor
cfe78e0e95 Cleanup (ms-)?admin-filters.php 
Props johnjamesjacoby.
Fixes #32529.

Built from https://develop.svn.wordpress.org/trunk@32865


git-svn-id: http://core.svn.wordpress.org/trunk@32836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 21:18:25 +00:00
Scott Taylor
5e1d796cae Ugrade MediaElement to 2.17.0 
Changelog: https://github.com/johndyer/mediaelement/compare/2.16.4...2.17.0

Fixes #32698.

Built from https://develop.svn.wordpress.org/trunk@32864


git-svn-id: http://core.svn.wordpress.org/trunk@32835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 20:42:26 +00:00
Scott Taylor
777d3ba7e2 wptexturize() improvements: 
* Make sure that strings ending with a number and quotation mark get the proper smart quotes
* Introduce `wptexturize_primes()`, a logic tree to determine whether or not "7'." represents seven feet, then converts the special char into either a prime char or a closing quote char.

Adds unit tests.

Props miqrogroove.
Fixes #29256.

Built from https://develop.svn.wordpress.org/trunk@32863


git-svn-id: http://core.svn.wordpress.org/trunk@32834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 20:06:25 +00:00
Scott Taylor
b212ee67e7 Media Library Bulk Select button size should be smaller. 
Props afercia.
Fixes #32325.

Built from https://develop.svn.wordpress.org/trunk@32862


git-svn-id: http://core.svn.wordpress.org/trunk@32833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 18:56:27 +00:00
Scott Taylor
c5e088bf0f Improve focus when previewing an oEmbed from Add Media Panel 
Props afercia.
Fixes #28820.

Built from https://develop.svn.wordpress.org/trunk@32861


git-svn-id: http://core.svn.wordpress.org/trunk@32832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 18:49:27 +00:00
Scott Taylor
32dabc1f90 Don't strip \0 (backslash+zero) from post content for users without "unfiltered_html" 
Adds unit tests.

Props miqrogroove.
Fixes #28699.

Built from https://develop.svn.wordpress.org/trunk@32860


git-svn-id: http://core.svn.wordpress.org/trunk@32831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 18:47:27 +00:00
Dominik Schilling
a28586a6d7 Customizer: Improve accessibility of the toggle button in the available menu items panel. 
Prevents focus lost in Safari because the button was "invisible" until it got focused.

fixes #32709.
Built from https://develop.svn.wordpress.org/trunk@32859


git-svn-id: http://core.svn.wordpress.org/trunk@32830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 17:24:24 +00:00
Konstantin Obenland
898bb2ed34 Remove allowed tags from comment form. 
It can be confusing to users and for most it is not relevant.
Commenters comfortable with HTML will know which tags are likely
to be accepted.

Props krogsgard, rachelbaker.
Fixes #30157.


Built from https://develop.svn.wordpress.org/trunk@32858


git-svn-id: http://core.svn.wordpress.org/trunk@32829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 14:15:26 +00:00
Konstantin Obenland
4e7c057a5a Check that current changes can be lost before editing another comment. 
When replying to or editing a comment, double-clicking another comment will
open it in quick edit and changes to the current comment are lost.

Props pareshradadiya, chriscct7.
Fixes #21845.


Built from https://develop.svn.wordpress.org/trunk@32857


git-svn-id: http://core.svn.wordpress.org/trunk@32828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 13:48:25 +00:00
Ella Iseulde Van Dorpe
fd95002b2a Editor: restructure word count 
* The WordCounter should only do one thing: count words. This makes it also easier to test.
* Add some really basic unit tests.
* Instead of only refreshing the count on enter and delete, refresh the count when the user stops typing. Also look at paste and content changes in TinyMCE.
* Use `match` instead of `replace` when it is appropriate.
* More readable code.

See #30966. Fixes #26620.


Built from https://develop.svn.wordpress.org/trunk@32856


git-svn-id: http://core.svn.wordpress.org/trunk@32827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 10:35:26 +00:00
Konstantin Obenland
50e32a1969 Keep WP_Customize_Nav_Menus_Panel with other panels rather than controls. 
Accidentally merged into the wrong file in [32806].
H/t celloexpressions for noticing.

See https://wordpress.slack.com/archives/core-customize/p1434696254000258.
See #32576.


Built from https://develop.svn.wordpress.org/trunk@32855


git-svn-id: http://core.svn.wordpress.org/trunk@32826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 08:37:27 +00:00
Dion Hulse
8593dc3172 When updating plugins/themes verify that the files to be deleted can be modified before starting the deletion process. 
This will avoid partially deleting an item during update which has inconsistent permissions.
This change only affects those using the direct & ssh transports as FTP's is_writable() currently always returns `true`.
Fixes #30921

Built from https://develop.svn.wordpress.org/trunk@32854


git-svn-id: http://core.svn.wordpress.org/trunk@32825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 03:49:25 +00:00
Dion Hulse
a21f890abb Remove a redundant index drop, it'll be dropped and re-created a few lines further down. 
Fixes a warning during updating from 4.0 or earlier.
Fixes #31388 for trunk

Built from https://develop.svn.wordpress.org/trunk@32852


git-svn-id: http://core.svn.wordpress.org/trunk@32823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 03:18:26 +00:00
Andrew Ozz
503b80be0b Fix using htmlspecialchars() whit the $double_encode parameter. PHP < 5.4 doesn't validate the entities. 
Props miqrogroove. Fixes #17780.
Built from https://develop.svn.wordpress.org/trunk@32851


git-svn-id: http://core.svn.wordpress.org/trunk@32822 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 01:53:26 +00:00
Scott Taylor
d8c93a081d Since PHP 5.2.3, the htmlspecialchars() function has an optional $double_encode parameter, which we can now use. This will save us a few expensive kses/html decoding calls. 
Adds unit tests.

Props miqrogroove.
Fixes #17780.

Built from https://develop.svn.wordpress.org/trunk@32850


git-svn-id: http://core.svn.wordpress.org/trunk@32821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 22:00:26 +00:00
John Blackbourn
f632756f16 Correct the docs for the post_type_labels_{$post_type} filter. 
Fixes #32707
Props dlh

Built from https://develop.svn.wordpress.org/trunk@32849


git-svn-id: http://core.svn.wordpress.org/trunk@32820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 21:33:27 +00:00
Dominik Schilling
f5fa907f77 Customizer: Improve accessibility of Add Menu Items button and its panel. 
props afercia, ocean90.
fixes #32682.
Built from https://develop.svn.wordpress.org/trunk@32848


git-svn-id: http://core.svn.wordpress.org/trunk@32819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 20:52:24 +00:00
Dominik Schilling
f39edce68d Autoprefixer for [32844]. 
Built from https://develop.svn.wordpress.org/trunk@32847


git-svn-id: http://core.svn.wordpress.org/trunk@32818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 20:49:26 +00:00
Aaron Jorbin
4b7ce555d0 Add singular.php to template hierarchy 
Singular is the only template context conditional that lacks a corresponding template. This allows some themes to simplify.

Fixes #22314.
Props chipbennett.


Built from https://develop.svn.wordpress.org/trunk@32846


git-svn-id: http://core.svn.wordpress.org/trunk@32817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 19:01:26 +00:00
Scott Taylor
09c4444150 Make sure that all Gravatars are generated by get_avatar() or at least run through apply_filters( 'get_avatar', $avatar ) for the sake of extensibility. 
Props miqrogroove, GlennM, SergeyBiryukov.
Fixes #22650.

Built from https://develop.svn.wordpress.org/trunk@32845


git-svn-id: http://core.svn.wordpress.org/trunk@32816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 18:36:25 +00:00
Konstantin Obenland
c1a9c4b7b8 Semanticize Help and Screen Options toggle. 
Links used as UI controls that are not real links but act as buttons, should be buttons.

Props afercia.
Fixes #32494.


Built from https://develop.svn.wordpress.org/trunk@32844


git-svn-id: http://core.svn.wordpress.org/trunk@32815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 16:36:25 +00:00
Konstantin Obenland
81df9bffc5 Use https for Google API external libraries. 
Google recommends it and users are more likely to have the https version cached in their browser already.

Props rommelxcastro.
Fixes #32552.


Built from https://develop.svn.wordpress.org/trunk@32843


git-svn-id: http://core.svn.wordpress.org/trunk@32814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 15:51:26 +00:00
Konstantin Obenland
d872f38c31 Show the posts meta box by default in Appearance > Menus. 
Lessens user confusion and the likelyhood of misusing custom links
to add menu items for posts.

Props bcole808.
Fixes #32440.


Built from https://develop.svn.wordpress.org/trunk@32842


git-svn-id: http://core.svn.wordpress.org/trunk@32813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 15:04:26 +00:00
Konstantin Obenland
f7f14ae558 More consistent spacing around the excerpt textarea. 
Props paulwilde.
Fixes #32242.


Built from https://develop.svn.wordpress.org/trunk@32841


git-svn-id: http://core.svn.wordpress.org/trunk@32812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 14:19:25 +00:00
Boone Gorges
dd3b146546 Use assertFalse() rather than assertNull() in Tests_WP_Customize_Setting::test_is_current_blog_previewed(). 
`is_current_blog_previewed()` returns a boolean.

See #31428.
Built from https://develop.svn.wordpress.org/trunk@32840


git-svn-id: http://core.svn.wordpress.org/trunk@32811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 14:08:25 +00:00
Boone Gorges
92123c15bf Make sure $_SERVER['SERVER_NAME'] is set whenever wp_mail() is called in PHPUnit tests. 
This eliminates PHP notices when `wp_mail()` needs to determine its own From header.

See [25381] for a previous fix, which focused only on the mail-specific tests.

Fixes #32702.
Built from https://develop.svn.wordpress.org/trunk@32839


git-svn-id: http://core.svn.wordpress.org/trunk@32810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 13:53:25 +00:00
Boone Gorges
2e5e0bdc78 When updating a user, only send email-change notification if email address is passed. 
The notification, introduced in [32380], was firing incorrectly (and throwing
a PHP notice) when `wp_update_user()` was called without including 'user_email'
in the update data.

Props imath.
Fixes #32684. See #32430.
Built from https://develop.svn.wordpress.org/trunk@32838


git-svn-id: http://core.svn.wordpress.org/trunk@32809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 13:30:26 +00:00
Boone Gorges
6105fca015 Add filters to wp_unique_term_slug(). 
This changeset adds two new filters:
* 'wp_unique_term_slug_is_bad_slug' lets developers control whether a test slug needs to be made unique, before the queries required to build a suffix are performed.
* 'wp_unique_term_slug' filters the output of the function.

These changes introduce parity with the filters in `wp_unique_post_slug()`.

Props coffee2code, bolo1988, boonebgorges.
Fixes #20783.
Built from https://develop.svn.wordpress.org/trunk@32837


git-svn-id: http://core.svn.wordpress.org/trunk@32808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 13:20:26 +00:00
Ella Iseulde Van Dorpe
ecec2b61cf TinyMCE: wptextpattern: escape should undo 
Props azaozz.
See #31441.

Built from https://develop.svn.wordpress.org/trunk@32836


git-svn-id: http://core.svn.wordpress.org/trunk@32807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 12:59:28 +00:00
Konstantin Obenland
437b1c2b6a Revert [32834]. 
It's not ready yet and was a product of misusing vim.

See #30729.


Built from https://develop.svn.wordpress.org/trunk@32835


git-svn-id: http://core.svn.wordpress.org/trunk@32806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 12:27:25 +00:00
Konstantin Obenland
598f4cc4ca Emphasise previewing new themes 
Built from https://develop.svn.wordpress.org/trunk@32834


git-svn-id: http://core.svn.wordpress.org/trunk@32805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 12:24:27 +00:00
Konstantin Obenland
c9e1e2be9b Make posts in the 'Most recent' tab of post type meta boxes filterable. 
Provides parity with the 'View All' tab of post type meta boxes in Appearance > Menus.

Props jpyper, chriscct7.
Fixes #19365.


Built from https://develop.svn.wordpress.org/trunk@32833


git-svn-id: http://core.svn.wordpress.org/trunk@32804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 11:35:28 +00:00
Ella Iseulde Van Dorpe
8b6ff40038 TinyMCE: wptextpattern: fix issue that removes content 
* If the resulting text node is empty, don't remove all the content from the paragraph.
* If there's an empty text node at the start of the paragraph, ignore it and consider the next node to be the start.

See #31441.

Built from https://develop.svn.wordpress.org/trunk@32832


git-svn-id: http://core.svn.wordpress.org/trunk@32803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 11:34:25 +00:00
Ella Iseulde Van Dorpe
1c586b9390 TinyMCE: show inline toolbar after scroll/resize 
Also:

* Reduce the amount of callbacks.
* Move everything under `preinit` (but prepend to the callback). The API shouldn't be availbale earlier, and some UI is not available yet, neither is `editor.dom`.
* Hide the toolbar if the target is out of view.

See #32604.


Built from https://develop.svn.wordpress.org/trunk@32831


git-svn-id: http://core.svn.wordpress.org/trunk@32802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 11:10:25 +00:00
Konstantin Obenland
326c106159 Recommend a user updates keys/salts in maint/repair.php. 
Since they are already going into `wp-config.php`, we should also encourage
them to update their unique phrases for keys and salts, assuming they do not
have a complete set of 8 unique ones already.

Props nacin, chriscct7.
Fixes #20779.


Built from https://develop.svn.wordpress.org/trunk@32830


git-svn-id: http://core.svn.wordpress.org/trunk@32801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 11:07:25 +00:00
John Blackbourn
768d8507e5 Correct a typo in the inline docs for add_action(). 
Props nabil_kadimi, swissspidy
Fixes #32697

Built from https://develop.svn.wordpress.org/trunk@32829


git-svn-id: http://core.svn.wordpress.org/trunk@32800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 08:37:25 +00:00
Andrew Ozz
bc2630e099 Press This: Check the embeds list against all of the oembed providers. 
Props stephdau. Fixes #32069.
Built from https://develop.svn.wordpress.org/trunk@32828


git-svn-id: http://core.svn.wordpress.org/trunk@32799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-18 00:12:26 +00:00
Andrew Ozz
b77a3a33f5 Press This: show error message when the user is attempting to add a category that already exists. 
Fixes #32339.
Built from https://develop.svn.wordpress.org/trunk@32827


git-svn-id: http://core.svn.wordpress.org/trunk@32798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-17 23:13:26 +00:00
John Blackbourn
b14c6bea0b Correct a unit test name. 
See #21212

Built from https://develop.svn.wordpress.org/trunk@32826


git-svn-id: http://core.svn.wordpress.org/trunk@32797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-17 23:10:25 +00:00
Dominik Schilling
6e44f060ee Customizer: Remove an overflow: hidden declaration to prevent cutting off the left and right edge focus style of the "Add a Menu" input field. 
props paulwilde.
fixes #32680.
Built from https://develop.svn.wordpress.org/trunk@32825


git-svn-id: http://core.svn.wordpress.org/trunk@32796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-17 21:43:26 +00:00
Dominik Schilling
5864a7ad44 Customizer: Fix keyboard events for the menu items search field. 
Replace the `change` event with `keyup`, see https://core.trac.wordpress.org/ticket/26600#comment:59 for background.

props tywayne.
fixes #32677.
Built from https://develop.svn.wordpress.org/trunk@32824


git-svn-id: http://core.svn.wordpress.org/trunk@32795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-17 21:37:27 +00:00
Dominik Schilling
504db9233b Customizer: Revert the blue on hover color which was introduced in [32649]. 
Blue is meant to be the primary action which isn't the case in this context. Colors need to be revised in #29158. 

see #31336.
Built from https://develop.svn.wordpress.org/trunk@32823


git-svn-id: http://core.svn.wordpress.org/trunk@32794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-17 21:07:27 +00:00
Dominik Schilling
2d2445516c Customizer: Decode HTML entities of panel/section titles. 
Titles are now passed into Underscore templates but HTML-escaped, see #30737.

fixes #32670.
Built from https://develop.svn.wordpress.org/trunk@32822


git-svn-id: http://core.svn.wordpress.org/trunk@32793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-17 19:48:25 +00:00
Dominik Schilling
a1f7f4fe17 Customizer: Replace usage of calc() with box-sizing: border-box. 
IE8 doesn't support `calc()`.

props afercia.
see #31336.
fixes #32664.
Built from https://develop.svn.wordpress.org/trunk@32821


git-svn-id: http://core.svn.wordpress.org/trunk@32792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-17 19:35:28 +00:00
Mark Jaquith
814865ea9e Send emails when a user's email address or password is changed. 
* In case of email change, email goes to the OLD address
* Prevents against issues where an account is compromised (say via cookie interception) and then the attacker silently takes over ownership via pw/email changes — now there will at least be a record that something is up

fixes #32430
props RMarks, MikeHansenMe, tharsheblows, obenland
Built from https://develop.svn.wordpress.org/trunk@32820


git-svn-id: http://core.svn.wordpress.org/trunk@32791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-17 19:31:27 +00:00
Boone Gorges
f62bf61b2c Bail out of 4.3 term splitting routine when no shared terms are found. 
Props dd32.
See #30261.
Built from https://develop.svn.wordpress.org/trunk@32819


git-svn-id: http://core.svn.wordpress.org/trunk@32790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-17 11:40:24 +00:00
Ella Iseulde Van Dorpe
8fba763f37 TinyMCE: show active inline toolbar after focus 
This makes sure that e.g. the image toolbar shows up again after closing the media library modal.

See #32604.

Built from https://develop.svn.wordpress.org/trunk@32818


git-svn-id: http://core.svn.wordpress.org/trunk@32789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-17 07:08:25 +00:00
Ella Iseulde Van Dorpe
c465640107 TinyMCE: wplink: don't link a URL with a pasted URL 
Fixes #32357.


Built from https://develop.svn.wordpress.org/trunk@32817


git-svn-id: http://core.svn.wordpress.org/trunk@32788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-17 05:05:24 +00:00
Ella Iseulde Van Dorpe
a31d79196d TinyMCE: improve reposition method inline toolbars 
* Make sure the toolbar does not overlap the target, unless it is higher than half the visible editor area's height.
* Allow the toolbar to have the preference to position itself above or below the target.
* Cache DOM lookups.
* Simplify the logic and fix various positioning issues.

See #32604.


Built from https://develop.svn.wordpress.org/trunk@32816


git-svn-id: http://core.svn.wordpress.org/trunk@32787 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-17 04:42:25 +00:00
Ella Iseulde Van Dorpe
1a4c6ad45d JSHint after [32806] 
See #32576.

Built from https://develop.svn.wordpress.org/trunk@32815


git-svn-id: http://core.svn.wordpress.org/trunk@32786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-17 04:15:26 +00:00
Boone Gorges
290044ef15 Split all shared taxonomy terms on upgrade to 4.3. 
Dear Shared Terms, Welcome to Splitsville. Population: You.

See #30261.
Built from https://develop.svn.wordpress.org/trunk@32814


git-svn-id: http://core.svn.wordpress.org/trunk@32785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-17 01:53:26 +00:00
Boone Gorges
cf7e00ed9f Performance enhancements for _split_shared_term(). 
* Introduce a `$record` parameter, which defaults to true. When set to false, `_split_shared_term()` will not keep a record of split term data in wp_options. The judicious use of this flag can greatly improve performance when processing shared terms in batches.
* Allow term/tt objects to be passed to the `$term_id` and `$term_taxonomy_id` parameters. This has the potential to save database queries when the objects are already available.

See #30261.
Built from https://develop.svn.wordpress.org/trunk@32813


git-svn-id: http://core.svn.wordpress.org/trunk@32784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-17 01:48:28 +00:00
John Blackbourn
2b699639bd Comprehensive unit tests for every available capability, and for all roles. 
Fixes #32394.

Built from https://develop.svn.wordpress.org/trunk@32812


git-svn-id: http://core.svn.wordpress.org/trunk@32783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-17 00:05:26 +00:00
John Blackbourn
4ad1dc2a1b Ensure the create_users capability check checks the super admin status of the user in question, rather than the current user. 
Built from https://develop.svn.wordpress.org/trunk@32811


git-svn-id: http://core.svn.wordpress.org/trunk@32782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-17 00:03:27 +00:00
Drew Jaynes
25829e05fa Add line-wrapping to a long return description because readability in documentation is important. 
See [32797]. See #32421.

Built from https://develop.svn.wordpress.org/trunk@32810


git-svn-id: http://core.svn.wordpress.org/trunk@32781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 23:18:25 +00:00
Andrew Ozz
82fcdec660 Editor: do not reuse the preview tab when the user has navigated away. 
See #32588.
Built from https://develop.svn.wordpress.org/trunk@32809


git-svn-id: http://core.svn.wordpress.org/trunk@32780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 23:13:26 +00:00
Dominik Schilling
ac33d71623 Fix a typo in [32806]. 
see #32576.
Built from https://develop.svn.wordpress.org/trunk@32808


git-svn-id: http://core.svn.wordpress.org/trunk@32779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 23:09:25 +00:00
Dominik Schilling
b2b3f1c3ff Twenty Fifteen: Wrap navigation helpers into a function so it can be called on a refresh event of the Customize Preview. 
props westonruter.
see #32576.
Built from https://develop.svn.wordpress.org/trunk@32807


git-svn-id: http://core.svn.wordpress.org/trunk@32778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 22:18:24 +00:00
Dominik Schilling
62e3a0c15c Add menu management to the Customizer. 
This brings in the Menu Customizer plugin: https://wordpress.org/plugins/menu-customizer/.

props celloexpressions, westonruter, valendesigns, voldemortensen, ocean90, adamsilverstein, kucrut, jorbin, designsimply, afercia, davidakennedy, obenland.
see #32576.
Built from https://develop.svn.wordpress.org/trunk@32806


git-svn-id: http://core.svn.wordpress.org/trunk@32777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 22:08:26 +00:00
Helen Hou-Sandí
d159cc2272 Media list table: Avoid PHP notices by using the proper variables. 
Also visually tightens up the row actions.

props tyxla.
fixes #32657. see #29881.

Built from https://develop.svn.wordpress.org/trunk@32805


git-svn-id: http://core.svn.wordpress.org/trunk@32776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 21:33:25 +00:00
Scott Taylor
a1bd091d65 In get_attachment_template(), pass an array of templates to get_query_template( 'attachment', $templates ), instead of bailing on the first found template. 
Props willnorris, jfarthing84, SergeyBiryukov, DrewAPicture, wonderboymusic.
Fixes #15337.

Built from https://develop.svn.wordpress.org/trunk@32804


git-svn-id: http://core.svn.wordpress.org/trunk@32775 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 20:50:26 +00:00
Scott Taylor
0cc29d8bb7 In wp_nav_menu(), ensure that the $menu arg is populated when passed to filters. 
Props greuben, chriscct7.
Fixes #16594.

Built from https://develop.svn.wordpress.org/trunk@32803


git-svn-id: http://core.svn.wordpress.org/trunk@32774 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 20:33:25 +00:00
Scott Taylor
6148f3cd41 Add a class method to wpLink, buildHtml(). This will allows devs to duck-punch the implementation. 
Props martinsachse.
Fixes #32180.

Built from https://develop.svn.wordpress.org/trunk@32802


git-svn-id: http://core.svn.wordpress.org/trunk@32773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 20:20:26 +00:00
Scott Taylor
45d5037a10 Avoid using HTML in translation strings in edit-form-comment.php. 
Fixes #31847.

Built from https://develop.svn.wordpress.org/trunk@32801


git-svn-id: http://core.svn.wordpress.org/trunk@32772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 20:08:24 +00:00
Scott Taylor
5c6b63d3a6 if is a statment, not a function. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32800


git-svn-id: http://core.svn.wordpress.org/trunk@32771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 20:01:25 +00:00
Scott Taylor
5e14470894 Avoid using <code> in a translation string. 
Props ramiy.
Fixes #31848.

Built from https://develop.svn.wordpress.org/trunk@32799


git-svn-id: http://core.svn.wordpress.org/trunk@32770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 19:53:27 +00:00
Helen Hou-Sandí
a49c192f37 Media list table: Restore row actions. 
see #29881, #32657.

Built from https://develop.svn.wordpress.org/trunk@32798


git-svn-id: http://core.svn.wordpress.org/trunk@32769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 19:47:24 +00:00
Scott Taylor
efbb8fa4e5 Document the default list of allowed protocols in the doc block for wp_allowed_protocols() and cross-reference in esc_url() and the kses_allowed_protocols filter. 
Props GunGeekATX.
Fixes #32421.

Built from https://develop.svn.wordpress.org/trunk@32797


git-svn-id: http://core.svn.wordpress.org/trunk@32768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 19:45:26 +00:00
Helen Hou-Sandí
457456ef25 Comments: Better markup for the edit screen. 
Previously there were no labels, and since labels can't contain links and the links were of dubious value, we've removed those.

props afercia, DrewAPicture.
fixes #31326.

Built from https://develop.svn.wordpress.org/trunk@32796


git-svn-id: http://core.svn.wordpress.org/trunk@32767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 18:54:26 +00:00
Ella Iseulde Van Dorpe
dd0bff051a TinyMCE: wptextpattern: Add blockquote and headings 
As discussed in the editor meeting 9 June.
We should re-evaluate these additions towards the end of the release.

See #31441.

Built from https://develop.svn.wordpress.org/trunk@32795


git-svn-id: http://core.svn.wordpress.org/trunk@32766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 13:52:25 +00:00
Boone Gorges
0768626735 Clean up uploaded file after test_media_handle_upload_sets_post_excerpt(). 
Props McGuive7.
Fixes #32534.
Built from https://develop.svn.wordpress.org/trunk@32794


git-svn-id: http://core.svn.wordpress.org/trunk@32765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 12:38:27 +00:00
Dion Hulse
2b2368d68f Add a filter to wp_safe_redirect() for the fallback URL. 
Props anubisthejackle. Fixes #22612

Built from https://develop.svn.wordpress.org/trunk@32793


git-svn-id: http://core.svn.wordpress.org/trunk@32764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 05:26:26 +00:00
Boone Gorges
66c1d75c1c Tag/category conversion link on edit-tags.php should point to specific importer page when cat2tag plugin is active. 
Props solarissmoke, c3mdigital.
Fixes #16369.
Built from https://develop.svn.wordpress.org/trunk@32792


git-svn-id: http://core.svn.wordpress.org/trunk@32763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 04:30:26 +00:00
Scott Taylor
362704ab9a sanitize_option() needs to handle WP_Error. DRY the conditional calls to add_settings_error(). 
Props chriscct7 for an initial patch.
Fixes #32350.

Built from https://develop.svn.wordpress.org/trunk@32791


git-svn-id: http://core.svn.wordpress.org/trunk@32762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 01:29:27 +00:00
Scott Taylor
8df67cb188 Add a note to wptexturize() docs. 
Props miqrogroove.
Fixes #32521.

Built from https://develop.svn.wordpress.org/trunk@32790


git-svn-id: http://core.svn.wordpress.org/trunk@32761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 00:57:24 +00:00
Scott Taylor
2043805da4 Improve the consistency of punctuation matching in wptexturize(). 
Adds unit tests.

Props miqrogroove.
Fixes #31886.

Built from https://develop.svn.wordpress.org/trunk@32789


git-svn-id: http://core.svn.wordpress.org/trunk@32760 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 00:50:25 +00:00
Scott Taylor
7db2c06ab6 Allow 'Cockney' filter to be translated. 
Updates unit test.

Props miqrogroove.
Fixes #31953.

Built from https://develop.svn.wordpress.org/trunk@32788


git-svn-id: http://core.svn.wordpress.org/trunk@32759 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 00:46:24 +00:00
Scott Taylor
b126a0144f In the youtube_embed_url embed handler, make embed a non-capturing group that alternately matches for v - YouTube supports both URL paths. 
Add unit test cases.

Props dmchale for some patch work.
Fixes #32161.

Built from https://develop.svn.wordpress.org/trunk@32787


git-svn-id: http://core.svn.wordpress.org/trunk@32758 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 00:35:25 +00:00
Scott Taylor
d71d2c062e In get_comment_reply_link(), when generating the reply link, add the replytocom query arg to the result of get_permalink() on the current $post, instead of the current global request URI. 
Props nazmul.hossain.nihal.
Fixes #31333.

Built from https://develop.svn.wordpress.org/trunk@32786


git-svn-id: http://core.svn.wordpress.org/trunk@32757 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 00:19:25 +00:00
Scott Taylor
b4f536eabe Set $_SERVER['REQUEST_METHOD'] for unit tests. 
Props johnbillion.
Fixes #32636.

Built from https://develop.svn.wordpress.org/trunk@32785


git-svn-id: http://core.svn.wordpress.org/trunk@32756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 00:04:29 +00:00
Dion Hulse
faf6383ebd Updates: Consistently use the same variable to refer to the plugin, avoids a potential PHP Notice when an external update script adds data without that key. 
Props mordauk. Fixes #31784

Built from https://develop.svn.wordpress.org/trunk@32784


git-svn-id: http://core.svn.wordpress.org/trunk@32755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-15 06:26:25 +00:00
Dion Hulse
c6bb637f89 Updats: Add a filter for the options params for the update being performed. 
Props nofearinc. Fixes #27754

Built from https://develop.svn.wordpress.org/trunk@32783


git-svn-id: http://core.svn.wordpress.org/trunk@32754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-15 05:35:26 +00:00
Dion Hulse
c726f72ea4 Updates: Allow the update row to include the active border styling post-ajax update. 
Props TobiasBg. Fixes #32129

Built from https://develop.svn.wordpress.org/trunk@32782


git-svn-id: http://core.svn.wordpress.org/trunk@32753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-15 05:13:25 +00:00
Dion Hulse
b881a541bb Updates: Remove redundant title tags from update outputs. 
Props afercia. Fixes #32530

Built from https://develop.svn.wordpress.org/trunk@32781


git-svn-id: http://core.svn.wordpress.org/trunk@32752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-15 05:09:25 +00:00
Dion Hulse
629545aaf5 Updates: When an update fails (and it's not during the credential form) allow further updates to continue, with the assumption that the error only affects a single plugin. 
Props magicroundabout. Fixes #32110 for trunk.

Built from https://develop.svn.wordpress.org/trunk@32780


git-svn-id: http://core.svn.wordpress.org/trunk@32751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-15 04:28:25 +00:00
Dion Hulse
6eef8a8ff2 Updates: Display the failure reason in addition to 'Update Failed', allows for debugging by site owners. 
Fixes #32435, #32473

Built from https://develop.svn.wordpress.org/trunk@32779


git-svn-id: http://core.svn.wordpress.org/trunk@32750 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-15 03:48:28 +00:00
Dion Hulse
0eb8bfc464 Updates: When a error occurs during the connection phase, pass the error message back as the ajax failure message. 
See #32435

Built from https://develop.svn.wordpress.org/trunk@32778


git-svn-id: http://core.svn.wordpress.org/trunk@32749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-15 03:32:27 +00:00
Dion Hulse
04325cd834 Updates: Better handling when the credential form is long (such as when SSH is active). This adds scrolling to the dialogue, and hides the SSH-specific fields when not using the SSH handler. 
See #32435

Built from https://develop.svn.wordpress.org/trunk@32777


git-svn-id: http://core.svn.wordpress.org/trunk@32748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-15 03:20:28 +00:00
Dion Hulse
a4b4918377 Updates: When a connection failure occurs, and no credential form is present client side, allow it to fall through to the normal failure handlers. 
See #32435

Built from https://develop.svn.wordpress.org/trunk@32776


git-svn-id: http://core.svn.wordpress.org/trunk@32747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-15 02:48:28 +00:00
Jeremy Felt
947eef9468 Introduce get_main_network_id() 
Expand on the logic previously available as part of `is_main_network()` and provide a way to obtain the ID of the main network. Most useful in multi-network configurations.

Props @johnjamesjacoby for the initial patch.
Fixes #30294.

Built from https://develop.svn.wordpress.org/trunk@32775


git-svn-id: http://core.svn.wordpress.org/trunk@32746 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-14 21:45:25 +00:00
Helen Hou-Sandí
e3ae4f9d7e Multisite: Use an email input for new user email address. 
We also need to set novalidate on the form due to some browsers rejecting valid email addresses containing an IDN. We should holistically investigate whether this is still an issue in any major browsers at some point.

props earnjam.
fixes #32643.

Built from https://develop.svn.wordpress.org/trunk@32774


git-svn-id: http://core.svn.wordpress.org/trunk@32745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-14 20:41:27 +00:00
Andrew Nacin
a0f4e8e086 Media: Support title fields to be removed from attachments. 
props antpb.
fixes #23932.

Built from https://develop.svn.wordpress.org/trunk@32773


git-svn-id: http://core.svn.wordpress.org/trunk@32744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-14 20:33:26 +00:00
Helen Hou-Sandí
ed46512c20 Reduce form spacing on narrower screens. 
props liljimmi.
fixes #32489, #32484.

Built from https://develop.svn.wordpress.org/trunk@32772


git-svn-id: http://core.svn.wordpress.org/trunk@32743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-14 20:12:26 +00:00
Andrew Nacin
748b3763cb Add add_user_role and remove_user_role actions for WP_User::add_role() and remove_role(). 
props shooper.
fixes #32060.

Built from https://develop.svn.wordpress.org/trunk@32771


git-svn-id: http://core.svn.wordpress.org/trunk@32742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-14 19:26:25 +00:00
Aaron Jorbin
38d59c0828 Improve dbDelta unit tests 
Add new tests for more parts of dbDelta.  This was cleaned up and prepared for commit at #wcphilly contributor day.

Props jdgrimes, tryon, jtsternberg, ebinnion, JPry, avnarun, kevkoeh, jorbin, salcode.
Fixes #29020.


Built from https://develop.svn.wordpress.org/trunk@32770


git-svn-id: http://core.svn.wordpress.org/trunk@32741 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-14 19:23:26 +00:00
Andrew Nacin
7080c8e24b Update comment caches in WP_Comment_Query, rather than comments template. 
props dd32.
fixes #31081.

Built from https://develop.svn.wordpress.org/trunk@32769


git-svn-id: http://core.svn.wordpress.org/trunk@32740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-14 19:21:25 +00:00
Andrew Nacin
e7f618d86e Tweak the first post/page content to get with the times. 
props chriscct7.
fixes #22474.

Built from https://develop.svn.wordpress.org/trunk@32768


git-svn-id: http://core.svn.wordpress.org/trunk@32739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-14 18:56:50 +00:00
Aaron Jorbin
36e593a46c Restore [32732] as it wasn't the actual cause of test failures as those failures where fixed separately. 
See #32732


Built from https://develop.svn.wordpress.org/trunk@32767


git-svn-id: http://core.svn.wordpress.org/trunk@32738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-14 18:56:26 +00:00
Aaron Jorbin
3d2f8542ac Revert [32732] since it is causing the tests to break 
See #32732


Built from https://develop.svn.wordpress.org/trunk@32766


git-svn-id: http://core.svn.wordpress.org/trunk@32737 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-14 18:43:25 +00:00
Aaron Jorbin
cbb6f91a29 Improve lastBuildDate timestamp in rss feeds 
RSS feed timestamps should reflect the actual timestamps for those RSS feeds rather than the generic timestamp for all posts and all comments. 

Props stevenkword.
Fixes #4575.



Built from https://develop.svn.wordpress.org/trunk@32765


git-svn-id: http://core.svn.wordpress.org/trunk@32736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-14 18:37:24 +00:00
Dominik Schilling
df11970e18 Nav menus: Introduce a wp_get_nav_menu_object filter in wp_get_nav_menu_object() to filter the retrieved nav_menu term. 
props westonruter.
fixes #32629.
Built from https://develop.svn.wordpress.org/trunk@32764


git-svn-id: http://core.svn.wordpress.org/trunk@32735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-14 17:37:25 +00:00
Dominik Schilling
8dcd236ba3 Nav menus: Reset the fallback_cb default argument in wp_nav_menu in case of a Customizer preview. 
props westonruter.
see #32576.
Built from https://develop.svn.wordpress.org/trunk@32763


git-svn-id: http://core.svn.wordpress.org/trunk@32734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-14 17:14:24 +00:00
Dominik Schilling
55f3b68c75 Nav Menus: Update wp_setup_nav_menu_item() to stop overriding empty properties from supplied $menu_item. 
Update docs for `WP_Post` constructor to indicate that `WP_Post|object` can be the supplied param, as opposed to just `WP_Post`.

props westonruter.
fixes #32632.
Built from https://develop.svn.wordpress.org/trunk@32762


git-svn-id: http://core.svn.wordpress.org/trunk@32733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-14 10:53:25 +00:00
Jeremy Felt
8daec04557 Remove a now unused switch_to_blog() and restore_current_blog() in site-info.php 
Now that we decide when to automatically update `home` and `siteurl`, we no longer need to switch to the site while displaying the form output.

See #32503.

Built from https://develop.svn.wordpress.org/trunk@32761


git-svn-id: http://core.svn.wordpress.org/trunk@32732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-14 08:23:26 +00:00
Jeremy Felt
da35c25fb7 Remove the "Update siteurl and home as well" checkbox when editing a site 
Rather than provide a checkbox to update the `siteurl` and `home` options, we can make an educated decision based on the current state. If the home and/or siteurl domain and path match the existing domain and path of the site, then we update with the new information.

Also, while scheme is not stored in `wp_blogs` along with a site, the scheme of the `home` and `siteurl` options can now be modified via the Site URL setting in `site-info.php` when the `home` and/or `siteurl` options match the existing domain.

Props @hugobaeta, @earnjam, @jeremyfelt.
Fixes #32503, see #22383.

Built from https://develop.svn.wordpress.org/trunk@32760


git-svn-id: http://core.svn.wordpress.org/trunk@32731 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-14 07:52:24 +00:00
Jeremy Felt
186c37a325 Capture domain and path when editing sites on a subdomain network 
When a network is configured as subdomain, allow for the input of arbitrary domain and path combinations when editing a site rather than just the domain.

This takes a step or two toward #32503.

Props @scribu, @ericlewis, @jeremyfelt.
See #22383.

Built from https://develop.svn.wordpress.org/trunk@32759


git-svn-id: http://core.svn.wordpress.org/trunk@32730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-14 07:09:25 +00:00
Jeremy Felt
f996e163b8 Improve code readability in site-info.php 
In advance of some other work here, clean up some braces and spaces.

See #22383.

Built from https://develop.svn.wordpress.org/trunk@32758


git-svn-id: http://core.svn.wordpress.org/trunk@32729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-14 05:01:28 +00:00
Scott Taylor
4348074f3a In WP_MS_Users_List_Table::display_rows(): 
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override - there is a small amount of logic that requires overriding, otherwise it is largely the same as the parent method

See #29881.

Built from https://develop.svn.wordpress.org/trunk@32757


git-svn-id: http://core.svn.wordpress.org/trunk@32728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 17:11:26 +00:00
Scott Taylor
3855cfbffd In WP_MS_Themes_List_Table::display_rows(): 
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override

See #29881.

Built from https://develop.svn.wordpress.org/trunk@32756


git-svn-id: http://core.svn.wordpress.org/trunk@32727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 16:54:26 +00:00
Scott Taylor
2bdcc71bc0 In WP_MS_Sites_List_Table::display_rows(): 
* Move the giant `switch` statement into methods
* Call `->single_row_columns()`, which we now override - it could inherit from `WP_List_Table` if we can find a way to handle the `id` column. When that happens, we can ditch this method.

See #29881.

Built from https://develop.svn.wordpress.org/trunk@32755


git-svn-id: http://core.svn.wordpress.org/trunk@32726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 16:23:25 +00:00
Scott Taylor
ba8cfcab71 In WP_Media_List_Table::display_rows(): 
* Move the giant `switch` statement into methods
* Call `-single_row_columns()`, which it inherits from `WP_List_Table`

See #29881.

Built from https://develop.svn.wordpress.org/trunk@32754


git-svn-id: http://core.svn.wordpress.org/trunk@32725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 15:57:27 +00:00
Scott Taylor
a56576edfe In WP_Links_List_Table::display_rows(): 
* Move the giant `switch` statement into methods
* Call `-single_row_columns()`, which it inherits from `WP_List_Table`

See #29881.

Built from https://develop.svn.wordpress.org/trunk@32753


git-svn-id: http://core.svn.wordpress.org/trunk@32724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 15:33:25 +00:00
Scott Taylor
b8eb353590 In WP_Posts_List_Table, move the <th> markup out of ->column_cb(). 
See #29881, [32740].

Built from https://develop.svn.wordpress.org/trunk@32752


git-svn-id: http://core.svn.wordpress.org/trunk@32723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 15:14:24 +00:00
Scott Taylor
18827ed337 In wp_ajax_hidden_columns(), don't explode() on an empty string. 
In `columns.hidden()`, which lives in `common.js`, don't return items with no `id`.

This was resulting in options like `manageedit-postcolumnshidden` containing a serialized array with random empty items.

Props afercia, wonderboymusic.
Fixes #32466.

Built from https://develop.svn.wordpress.org/trunk@32751


git-svn-id: http://core.svn.wordpress.org/trunk@32722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 15:00:25 +00:00
Dominik Schilling
5ec278f585 Toolbar: Remove a duplicate CSS selector. 
props deconf.
fixes #32634.
Built from https://develop.svn.wordpress.org/trunk@32750


git-svn-id: http://core.svn.wordpress.org/trunk@32721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 14:54:25 +00:00
Scott Taylor
da0400e273 In WP_Posts_List_Table::column_title(), use is_post_type_hierarchical() instead of $this->hierarchical_display in the logic to determine whether the_excerpt() should be called. 
Fixes #32187.

Built from https://develop.svn.wordpress.org/trunk@32749


git-svn-id: http://core.svn.wordpress.org/trunk@32720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 14:42:26 +00:00
Dominik Schilling
792295d077 Nav menus: Apply the wp_get_nav_menu_items filter also on an empty list of menu items. 
props westonruter.
fixes #32631.
Built from https://develop.svn.wordpress.org/trunk@32748


git-svn-id: http://core.svn.wordpress.org/trunk@32719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 14:38:25 +00:00
Scott Taylor
144a28a5c2 Add an abort class method to the Promise instance returned by wp.ajax.send(). 
Props westonruter.
Fixes #32628.

Built from https://develop.svn.wordpress.org/trunk@32747


git-svn-id: http://core.svn.wordpress.org/trunk@32718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 14:30:26 +00:00
Dominik Schilling
33c1c76001 Nav menu: Introduce a has_nav_menu filter in has_nav_menu() to filter whether a nav menu is assigned to a specified location. 
props westonruter.
fixes #32630.
Built from https://develop.svn.wordpress.org/trunk@32746


git-svn-id: http://core.svn.wordpress.org/trunk@32717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 14:15:25 +00:00
Dominik Schilling
fe31ed1e5f Nav menu: Allow the sortable items selector in wpNavMenu to be overridden. 
props adamsilverstein.
fixes #32633.
Built from https://develop.svn.wordpress.org/trunk@32745


git-svn-id: http://core.svn.wordpress.org/trunk@32716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 14:03:25 +00:00
Weston Ruter
489db97ea3 Customizer: Allow sections and panels to be exported to JS. 
Also fix param docs for `customize_dynamic_setting_class` filter, and use `require_once` for `class-wp-customize-manager.php` in bootstrap function `_wp_customize_include()`.

See #30737, #32576.

Built from https://develop.svn.wordpress.org/trunk@32744


git-svn-id: http://core.svn.wordpress.org/trunk@32715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 22:54:25 +00:00
Weston Ruter
40ad21b58b Fix regressions from [32649] wrt Customizer expanded and active state changes for sections. 
The `args.completeCallback` was not always called when `onChangeExpanded()` was called. And when a section became inactive (`active` state goes to `false`) and it was currently `expanded`, the Customizer panel would then becomes blank as the section was hidden; it needed to `collapse()` the section first before hiding the element.

See #31336.


Built from https://develop.svn.wordpress.org/trunk@32743


git-svn-id: http://core.svn.wordpress.org/trunk@32714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 22:28:25 +00:00
Scott Taylor
c11e433858 After [32740], in WP_Posts_List_Table::single_row() - $lock_holder is checked but unused, so the call to get_userdata() is unnecessary. 
See #29881.

Built from https://develop.svn.wordpress.org/trunk@32742


git-svn-id: http://core.svn.wordpress.org/trunk@32713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 20:48:26 +00:00
Scott Taylor
c1c7a7c14c After [32740], correct doc block typo. 
See #29881.

Built from https://develop.svn.wordpress.org/trunk@32741


git-svn-id: http://core.svn.wordpress.org/trunk@32712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 20:29:26 +00:00
Scott Taylor
3f4cadf4aa Override ->single_row_columns() in WP_Posts_List_Table. 
Break apart the giant `switch` statement in `->single_row()` into `column_{$column_name}` methods.
To maintain the `->single_row_columns( $item )` interface, add a property, `$current_level`, to allow access to `$level`.

This list table class is now easier to subclass.

Props joehoyle, wonderboymusic.
See #29881.

Built from https://develop.svn.wordpress.org/trunk@32740


git-svn-id: http://core.svn.wordpress.org/trunk@32711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 20:18:24 +00:00
Scott Taylor
d0aa8e4a6e In WP_Terms_List_Table::display_rows_or_placeholder(): 
* `get_terms()` can return `WP_Error`, so its return value should be checked before traversing.
* The 2nd call to `get_terms()` can be removed, it is redundant #OPTIMIZATION

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32739


git-svn-id: http://core.svn.wordpress.org/trunk@32710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 18:55:25 +00:00
Scott Taylor
da4c3d0fe4 In WP_Posts_List_Table::single_row(): 
* `get_the_terms()` can return `WP_Error`, so its return value should be checked before traversing.
* Correct the `@param` doc blocks

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32738


git-svn-id: http://core.svn.wordpress.org/trunk@32709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 18:50:25 +00:00
Scott Taylor
4835310a18 In WP_Media_List_Table::display_rows(), get_the_terms() can return WP_Error, so its return value should be checked before traversing. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32737


git-svn-id: http://core.svn.wordpress.org/trunk@32708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 18:45:25 +00:00
Scott Taylor
f88b42be94 In WP_Comments_List_Table::column_comment(), $post and $the_comment_status are unused, as is the $comment_status global. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32736


git-svn-id: http://core.svn.wordpress.org/trunk@32707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 18:39:25 +00:00
Scott Taylor
55b3ec92f4 Fix some malformed doc blocks in Custom_Image_Header. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32735


git-svn-id: http://core.svn.wordpress.org/trunk@32706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 18:35:26 +00:00
Scott Taylor
ab66fc95bc Fix some malformed doc blocks in Custom_Background. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32734


git-svn-id: http://core.svn.wordpress.org/trunk@32705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 18:25:25 +00:00
Scott Taylor
f888767c73 $status shouldn't be loosely compared to true in wp_xmlrpc_server::wp_deleteComment(). 
`$initial` shouldn't be loosely compared to `true` in `get_calendar()`.
`current_user_can()` shouldn't be loosely compared to `false` in `kses_init()`
`$get_all` shouldn't be loosely compared to `true` in `get_blog_details()`.
`is_array()` and `in_array()` shouldn't be loosely compared in `wpmu_validate_user_signup()`.
`$result` should by strictly compared in `check_ajax_referer()`.
`wp_verify_nonce()` should by strictly compared in `_show_post_preview()`.
`is_user_logged_in()` should not be loosly compared against `false` in `wp-signup.php`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32733


git-svn-id: http://core.svn.wordpress.org/trunk@32704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 17:48:26 +00:00
Scott Taylor
740b92853d WP_Customize_Setting::is_current_blog_previewed() should only return false, not false or void. The one invocation of the method only loosely checks the return value. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32732


git-svn-id: http://core.svn.wordpress.org/trunk@32703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 17:29:26 +00:00
Scott Taylor
3b1e434c3b Add the proper access modifier to _init_caps() in WP_User. Add __call() for BC. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32731


git-svn-id: http://core.svn.wordpress.org/trunk@32702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 17:26:25 +00:00
Scott Taylor
d2a00338f6 Don't loosely compare functions that return bool against a literal bool. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32730


git-svn-id: http://core.svn.wordpress.org/trunk@32701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 17:19:27 +00:00
Scott Taylor
107d5b088d page_template should be annotated as @property, not @property-read in WP_Post. The property is set on an instance in wp_insert_post() 
Props morganestes.
Fixes #32515.

Built from https://develop.svn.wordpress.org/trunk@32729


git-svn-id: http://core.svn.wordpress.org/trunk@32700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 17:01:24 +00:00
Scott Taylor
05682bdaa8 After [32596] and [32597], ensure that wp_scripts|styles() is called to ensure an instance is created of WP_Scripts|Styles() before calling ->do_items(). 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32728


git-svn-id: http://core.svn.wordpress.org/trunk@32699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 16:54:24 +00:00
Boone Gorges
2459cbd20f Introduce class argument to wp_dropdown_pages(). 
This new argument allows devs to specify the 'class' attribute of the select
element.

Props ramiy, voldemortensen.
Fixes #30082.
Built from https://develop.svn.wordpress.org/trunk@32727


git-svn-id: http://core.svn.wordpress.org/trunk@32698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 13:05:27 +00:00
Dion Hulse
c445d60a00 SSH2 Upgrade transport: Use ssh2_sftp_realpath() instead of shell commands to determine the current directory on the remote server. This should allow it to be used on chrooted SSH sessions. 
See #32345

Built from https://develop.svn.wordpress.org/trunk@32726


git-svn-id: http://core.svn.wordpress.org/trunk@32696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-12 06:31:28 +00:00
Konstantin Obenland
cb39d03501 Improve non-visual feedback for list table items without terms. 
Props karpstrucking, afercia.
Fixes #32150.


Built from https://develop.svn.wordpress.org/trunk@32725


git-svn-id: http://core.svn.wordpress.org/trunk@32695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-11 09:28:31 +00:00
Helen Hou-Sandí
c87224eaf6 List tables: Use a class instead of inline styles for hidden columns. 
fixes #32608.

Built from https://develop.svn.wordpress.org/trunk@32724


git-svn-id: http://core.svn.wordpress.org/trunk@32694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-10 19:47:27 +00:00
Helen Hou-Sandí
06ebd0a2aa List tables: 
Since the primary column is not going to be alterable for plugins and MS themes, we don't need to check in on it.

see #25408.

Built from https://develop.svn.wordpress.org/trunk@32723


git-svn-id: http://core.svn.wordpress.org/trunk@32693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-10 19:31:25 +00:00
Helen Hou-Sandí
51b5ed9fa4 List tables: Better primary column back-compat. 
Why are people manually setting `$_column_headers` other than because somebody else told them to? Maybe time will tell.

props kovshenin.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32722


git-svn-id: http://core.svn.wordpress.org/trunk@32692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-10 14:59:30 +00:00
Helen Hou-Sandí
3562ac028d List tables: Consolidate <td> output for posts. 
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32721


git-svn-id: http://core.svn.wordpress.org/trunk@32691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-10 14:01:28 +00:00
Konstantin Obenland
ce16fd8dca More semantic markup for the post formats metabox. 
Screen readers will now introduce the group of radio buttons.
Also brings the meta box to parity with Press This.

Props joedolson, afercia.
Fixes #26160.


Built from https://develop.svn.wordpress.org/trunk@32720


git-svn-id: http://core.svn.wordpress.org/trunk@32690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-10 09:09:25 +00:00
Jeremy Felt
0e76a2c570 Additional improvement to sites list table display 
* Build `$blogname` identically when creating action link messaging.
* Remove the trailing slash from URLs for a better UI.

See #32434.

Built from https://develop.svn.wordpress.org/trunk@32719


git-svn-id: http://core.svn.wordpress.org/trunk@32689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-10 07:28:26 +00:00
Jeremy Felt
93ff65e677 Improve information displayed in a network's sites list table 
* Better support for arbitrary domain/path combinations by displaying the URL in the primary column rather than Path or Domain.
* Show a cached count of total users per site as a more useful data point rather than the first 5 users.
* Clear that cached count of users for a site when a user is added to the site via `add_user_to_blog()`.

Props @ocean90.
Fixes #32434.

Built from https://develop.svn.wordpress.org/trunk@32718


git-svn-id: http://core.svn.wordpress.org/trunk@32688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-10 06:50:25 +00:00
Helen Hou-Sandí
005d937ce2 List tables: 
* Avoid notices in custom list tables that manually set `$_column_headers`. Any plugins using this for a specific purpose should update.
* Restore a special class name in the users list table.

props georgestephanis, stephdau.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32717


git-svn-id: http://core.svn.wordpress.org/trunk@32687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-10 01:46:27 +00:00
Konstantin Obenland
bafb008be1 When inline editing a post, reset password field to be editable by default. 
The Quick Edit form is cloned and then populated with post-specific data. If the 
previous post was private, the password field would continue to be disabled for
the next post.

Props afercia.
Fixes #32259.


Built from https://develop.svn.wordpress.org/trunk@32716


git-svn-id: http://core.svn.wordpress.org/trunk@32686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-09 22:02:27 +00:00
Aaron Jorbin
82e8acd70b Remove Truthy check from DO_NOT_UPGRADE_GLOBAL_TABLES 
Some, but not all, of the checks for DO_NOT_UPGRADE_GLOBAL_TABLES just check if it is defined, so checking for truthiness could cause the issue to not be fully fixed.

In the words of Colonel Jessep: You can't handle the truth!

Introduced in [32714]

Fixes #32011


Built from https://develop.svn.wordpress.org/trunk@32715


git-svn-id: http://core.svn.wordpress.org/trunk@32685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-09 22:00:28 +00:00
Aaron Jorbin
d1586725d1 Add error if a user attempts to install WordPress with DO_NOT_UPGRADE_GLOBAL_TABLES defined 
The install process runs through migrations to global tables, therefore we cannot install WordPress with this constant defined. This error message prevents a false success screen from being seen.

Fixes #32011.
Props Oxymoron.


Built from https://develop.svn.wordpress.org/trunk@32714


git-svn-id: http://core.svn.wordpress.org/trunk@32684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-09 17:59:24 +00:00
Boone Gorges
5dfd6a02a7 Avoid returning duplicate matches when using a meta query in WP_User_Query. 
A meta_query containing an `OR` relation can result in the same record matching
multiple clauses, leading to duplicate results. The previous prevention against
duplicates [18178] #17582 became unreliable in 4.1 when `WP_Meta_Query`
introduced support for nested clauses. The current changeset adds a new method
`WP_Meta_Query::has_or_relation()` for checking whether an `OR` relation
appears anywhere in the query, and uses the new method in `WP_User_Query` to
enforce distinct results as necessary.

Props maxxsnake.
Fixes #32592.
Built from https://develop.svn.wordpress.org/trunk@32713


git-svn-id: http://core.svn.wordpress.org/trunk@32683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-09 17:42:28 +00:00
Dion Hulse
6657e42c7d WP_HTTP: ensure that the temporary file is created within the temporary directly when stream is specified without a filename parameter. 
Fixes #32549

Built from https://develop.svn.wordpress.org/trunk@32712


git-svn-id: http://core.svn.wordpress.org/trunk@32682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-09 03:55:27 +00:00
Ella Iseulde Van Dorpe
00e4f35300 TinyMCE: wpviews: cache iframe heights 
Cache iframe heights per instance so it can be reused. This will prevent to content from moving in the editor when undoing or redoing changes.

Fixes #32593.

Built from https://develop.svn.wordpress.org/trunk@32711


git-svn-id: http://core.svn.wordpress.org/trunk@32681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-08 21:32:27 +00:00
Ella Iseulde Van Dorpe
e9ac7f5164 TinyMCE: views: fix typo in createInstance 
This prevented instances from being reused.

Fixes #32591.

Built from https://develop.svn.wordpress.org/trunk@32710


git-svn-id: http://core.svn.wordpress.org/trunk@32680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-08 19:54:25 +00:00
Boone Gorges
e8ad0ff400 Filter out empty object_types in register_taxonomy_for_object_type(). 
This prevents weird edge bugs when registering an existing taxonomy with an
object type when the taxonomy was previously associated with no object types.

Fixes #32590.
Built from https://develop.svn.wordpress.org/trunk@32709


git-svn-id: http://core.svn.wordpress.org/trunk@32679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-08 19:45:31 +00:00
Dominik Schilling
0549150843 Parse request: Quote regular expression characters in home path. 
Adds unit tests.

props akirk.
fixes #30438.
Built from https://develop.svn.wordpress.org/trunk@32708


git-svn-id: http://core.svn.wordpress.org/trunk@32678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-08 13:29:26 +00:00
Konstantin Obenland
6d56231da3 Sort screen options for meta boxes according to the meta box's priority. 
Props swissspidy.
Fixes #32582.


Built from https://develop.svn.wordpress.org/trunk@32707


git-svn-id: http://core.svn.wordpress.org/trunk@32677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-08 12:35:26 +00:00
Ella Iseulde Van Dorpe
ab1c4329b6 TinyMCE: wptextpattern: make tests ~2x faster 
* Reuse the same instance for all tests in the module.
* Run without CSS (skin).
* Less typing.

See #31441.

Built from https://develop.svn.wordpress.org/trunk@32706


git-svn-id: http://core.svn.wordpress.org/trunk@32676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-07 22:16:24 +00:00
Ella Iseulde Van Dorpe
c12af009c2 Editor: link modal: use link as fallback for text 
If there is no link text provided, use the link as the text. This is better than silently failing.

Props bcole808.
Fixes #32323.

Built from https://develop.svn.wordpress.org/trunk@32705


git-svn-id: http://core.svn.wordpress.org/trunk@32675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-07 21:11:24 +00:00
Ella Iseulde Van Dorpe
8acda26129 Autoprefixer after autoprefixer-core 5.2 update 
grunt-autoprefixer requires ^5.1.7, so this was automatically updated.

See #31700.

Built from https://develop.svn.wordpress.org/trunk@32704


git-svn-id: http://core.svn.wordpress.org/trunk@32674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-07 20:08:24 +00:00
Ella Iseulde Van Dorpe
d74a115e21 TinyMCE: wptextpattern: add docs 
Props DrewAPicture and iseulde.
See #31441.

Built from https://develop.svn.wordpress.org/trunk@32703


git-svn-id: http://core.svn.wordpress.org/trunk@32673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-07 20:00:28 +00:00
Sergey Biryukov
c9dd28908a In get_avatar(), avoid a second get_avatar_data() call to get the 2x URL. 
props ravinderk.
fixes #32572.
Built from https://develop.svn.wordpress.org/trunk@32702


git-svn-id: http://core.svn.wordpress.org/trunk@32672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-07 14:58:26 +00:00
Ella Iseulde Van Dorpe
cf31f32475 Customizer: hide controls on test page 
Introduced in [30919].
See #32577 and #30701.

Built from https://develop.svn.wordpress.org/trunk@32701


git-svn-id: http://core.svn.wordpress.org/trunk@32671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-07 09:04:32 +00:00
Ella Iseulde Van Dorpe
6926314730 TinyMCE: wptextpattern: disable for IE 8 and lower 
Props azaozz, iseulde.
See #31441.

Built from https://develop.svn.wordpress.org/trunk@32700


git-svn-id: http://core.svn.wordpress.org/trunk@32670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-06 22:38:28 +00:00
Ella Iseulde Van Dorpe
356fd0ff81 TinyMCE: add wptextpattern plugin 
This plugin can automatically format text patterns as you type. It includes two patterns: unordered (`* ` and `- `) and ordered list (`1. ` and `1) `). If the transformation in unwanted, the user can undo the change by pressing backspace, using the undo shortcut, or the undo button in the toolbar.

This is the first TinyMCE plugin that has unit tests and there's some good groundwork for adding tests to existing plugins in the future.

First run. See #31441.

Built from https://develop.svn.wordpress.org/trunk@32699


git-svn-id: http://core.svn.wordpress.org/trunk@32669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-06 20:07:24 +00:00
Ella Iseulde Van Dorpe
ff17bd95fe QUnit: test minified files 
Fixes #32574.

Built from https://develop.svn.wordpress.org/trunk@32698


git-svn-id: http://core.svn.wordpress.org/trunk@32668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-06 19:58:24 +00:00
Ella Iseulde Van Dorpe
521de0130b Browserify after [32677] 
See #30949.

Built from https://develop.svn.wordpress.org/trunk@32697


git-svn-id: http://core.svn.wordpress.org/trunk@32667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-06 19:50:29 +00:00
Sergey Biryukov
50369e1c98 Add @since for check_password_reset_key(), reset_password(), and register_new_user(). 
see #20279.
Built from https://develop.svn.wordpress.org/trunk@32696


git-svn-id: http://core.svn.wordpress.org/trunk@32666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-05 20:39:26 +00:00
Helen Hou-Sandí
93b5a9a7fa Nav menus: Hidden inputs do not need an ID, especially one that's already in use. 
props sagarjadhav.
fixes #31816.

Built from https://develop.svn.wordpress.org/trunk@32695


git-svn-id: http://core.svn.wordpress.org/trunk@32665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-05 15:36:27 +00:00
Konstantin Obenland
c20edc4df5 Remove title attributes in user list tables. 
They don't add valuable information and are redundant.
Reduces annoyance for screen reader users.

Props afercia.
Fixes #32535.


Built from https://develop.svn.wordpress.org/trunk@32694


git-svn-id: http://core.svn.wordpress.org/trunk@32664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-05 08:40:26 +00:00
Konstantin Obenland
5daf12dba4 Text improvements for screen readers in list table paginations. 
Removes title attributes where reasonable and uses accessible hidden text.
Screen readers will now correctly read out all available information.

Props afercia, rianrietveld.
Fixes #32028.


Built from https://develop.svn.wordpress.org/trunk@32693


git-svn-id: http://core.svn.wordpress.org/trunk@32663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-05 05:01:25 +00:00
Boone Gorges
f88996bed7 In wp_notify_moderator(), don't throw notice when comment belongs to a post with no author. 
Props Oxymoron.
Fixes #32566.
Built from https://develop.svn.wordpress.org/trunk@32692


git-svn-id: http://core.svn.wordpress.org/trunk@32662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-04 17:29:25 +00:00
Helen Hou-Sandí
0e77b693ac Nav menus: hide the title attribute field by default for new users and installs. 
It is still available in screen options. This also gives the "Navigation Label", a crucial field, the room it really deserves.

props paulwilde.
fixes #32218.

Built from https://develop.svn.wordpress.org/trunk@32691


git-svn-id: http://core.svn.wordpress.org/trunk@32661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-04 04:38:25 +00:00
Helen Hou-Sandí
9d0ab29bc4 Nav menus: Provide visual feedback when attempting to add an empty custom link. 
props pragunbhutani for the initial patch.
fixes #18517.

Built from https://develop.svn.wordpress.org/trunk@32690


git-svn-id: http://core.svn.wordpress.org/trunk@32660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-04 04:31:26 +00:00
John Blackbourn
acec5066f6 Switch to pointer tolerance for improved drag and drop behaviour when reordering widgets. 
Props jkudish, MikeHansenMe.
Fixes #20791

Built from https://develop.svn.wordpress.org/trunk@32689


git-svn-id: http://core.svn.wordpress.org/trunk@32659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-03 22:59:25 +00:00
Helen Hou-Sandí
6f6788c4af Media list view: ensure thumbnails are appropriately sized and constrained. 
see #29993.

Built from https://develop.svn.wordpress.org/trunk@32688


git-svn-id: http://core.svn.wordpress.org/trunk@32658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-03 15:23:25 +00:00
Helen Hou-Sandí
40fca44c89 Media: move the thumbnail into the title column in list view. 
This gives us more space for the title and row actions, and will make a responsive list table enhancement significantly easier.

props bradt for the initial patch.
fixes #29993 and #32255. see #32509 and #32395.

Built from https://develop.svn.wordpress.org/trunk@32687


git-svn-id: http://core.svn.wordpress.org/trunk@32657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-03 15:13:25 +00:00
Helen Hou-Sandí
2d3a637598 List tables: tighten up primary column handling for plugins and multisite themes. 
These shouldn't be able to have their primary column reassigned by default. Also removes the `has-row-actions` class as these list tables always have row actions visible and the JS for visual toggling conflicts. The `column-primary` class remains.

props stephdau.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32686


git-svn-id: http://core.svn.wordpress.org/trunk@32656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-03 15:08:28 +00:00
Boone Gorges
2c9a2850b4 Add @since entry for 'has_published_post' argument of WP_User_Query. 
Mega-props DrewAPicture.
Fixes #32250.
Built from https://develop.svn.wordpress.org/trunk@32685


git-svn-id: http://core.svn.wordpress.org/trunk@32655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-02 18:21:26 +00:00
Boone Gorges
0471408596 Normalize whitespace in docblock for WP_User_Query::prepare_query(). 
Built from https://develop.svn.wordpress.org/trunk@32684


git-svn-id: http://core.svn.wordpress.org/trunk@32654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-02 13:35:26 +00:00
Boone Gorges
6db02371ec Introduce 'has_published_posts' parameter for WP_User_Query. 
This allows user query results to be limited to those users who have published
posts in at least one of the specified post types.

Props joehoyle, boonebgorges.
Fixes #32250.
Built from https://develop.svn.wordpress.org/trunk@32683


git-svn-id: http://core.svn.wordpress.org/trunk@32653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-02 13:30:26 +00:00
Konstantin Obenland
5e787a900a Use WordPress' default focus styles for links on login screens. 
Props afercia.
Fixes #31712.


Built from https://develop.svn.wordpress.org/trunk@32682


git-svn-id: http://core.svn.wordpress.org/trunk@32652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-02 05:51:27 +00:00
Dominik Schilling
974ca19e36 Customizer: Improve JS templates for Panels and Sections added in [32658]. 
* Always fall back to using the default template if no custom template exists.
* Provide a set of default params when constructing new `Section` and `Panel` objects.

Includes QUnit tests.

Props celloexpressions, westonruter, ocean90.
Fixes #30737.
Built from https://develop.svn.wordpress.org/trunk@32681


git-svn-id: http://core.svn.wordpress.org/trunk@32651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-01 22:47:25 +00:00
Andrew Ozz
02f5020d52 Editor: run autosave when pressing Ctrl or Command + S in the Text editor, same as the Visual editor. 
Fixes #31655.
Built from https://develop.svn.wordpress.org/trunk@32680


git-svn-id: http://core.svn.wordpress.org/trunk@32650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-01 19:02:25 +00:00
Andrew Ozz
1c0419071f Emoji: make sure we parse only strings or DOM nodes that have children. 
Props peterwilsoncc. Fixes #32300.
Built from https://develop.svn.wordpress.org/trunk@32679


git-svn-id: http://core.svn.wordpress.org/trunk@32649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-01 18:25:25 +00:00
Andrew Ozz
4f9682f39e TinyMCE wpView: preserve HTML wrapped in shortcodes. 
Fixes #32078.
Built from https://develop.svn.wordpress.org/trunk@32678


git-svn-id: http://core.svn.wordpress.org/trunk@32648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-01 18:09:26 +00:00
Andrew Ozz
b3d04247b7 Editor: 
- Remove the old DFW.
- Add back-compat stub for wp-fullscreen.js.
- Keep wp_ajax_wp_fullscreen_save_post() for now.
See #30949.
Built from https://develop.svn.wordpress.org/trunk@32677


git-svn-id: http://core.svn.wordpress.org/trunk@32647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-01 17:38:29 +00:00
Sergey Biryukov
ecf0bcc9fc Revert a part of [32673] that caused a fatal error with SCRIPT_DEBUG disabled. 
see #19257.
Built from https://develop.svn.wordpress.org/trunk@32676


git-svn-id: http://core.svn.wordpress.org/trunk@32646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-01 04:14:25 +00:00
Sergey Biryukov
3fc78a1109 Avoid a PHP notice in wp_enqueue_media() if $post is null. 
see #19257.
Built from https://develop.svn.wordpress.org/trunk@32675


git-svn-id: http://core.svn.wordpress.org/trunk@32645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 21:54:25 +00:00
John Blackbourn
ff3f2ac243 Remove an embed handler accidentally introduced in r32673. 
Built from https://develop.svn.wordpress.org/trunk@32674


git-svn-id: http://core.svn.wordpress.org/trunk@32644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 16:56:26 +00:00
John Blackbourn
02192cb53f Introduce featured_image, set_featured_image, remove_featured_image, and use_featured_image post type labels when registering a post type in order to override the 'Featured Image' text and its related phrases. 
Props johnbillion, mordauk, valendesigns.
Fixes #19257.

Built from https://develop.svn.wordpress.org/trunk@32673


git-svn-id: http://core.svn.wordpress.org/trunk@32643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 16:54:27 +00:00
Scott Taylor
42d51a4f89 Add doc blocks to functions that are missing them. 
If the function has no need for `@param` or `@return`, do an archeaological dig to find `@since`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32672


git-svn-id: http://core.svn.wordpress.org/trunk@32642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 03:18:25 +00:00
Drew Jaynes
9cb1017b3c Fix inline documentation formatting in wp-admin/includes/admin-filters.php, introduced in [32653]. 
See #32529.

Built from https://develop.svn.wordpress.org/trunk@32671


git-svn-id: http://core.svn.wordpress.org/trunk@32641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 02:00:26 +00:00
Drew Jaynes
0df0e0bf36 Fix syntax and add a missing return description for inline documentation introduced in [32644] for WP_Users_List_Table. 
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32670


git-svn-id: http://core.svn.wordpress.org/trunk@32640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:45:27 +00:00
Drew Jaynes
65f31bc52e Fix syntax and add missing return descriptions for inline documentation introduced in [32644] for WP_Terms_List_Table. 
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32669


git-svn-id: http://core.svn.wordpress.org/trunk@32639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:44:26 +00:00
Drew Jaynes
a69f867738 Fix syntax and add missing return descriptions for inline documentation introduced in [32644] for WP_Posts_List_Table. 
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32668


git-svn-id: http://core.svn.wordpress.org/trunk@32638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:42:25 +00:00
Drew Jaynes
5e2983a77e Fix formatting and add a missing return description for inline documentation introduced in [32644] for WP_Plugins_List_Table. 
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32667


git-svn-id: http://core.svn.wordpress.org/trunk@32637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:40:29 +00:00
Drew Jaynes
d7428fc35d Fix formatting and add missing return descriptions for inline documentation introduced in [32644] for WP_MS_Users_List_Table. 
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32666


git-svn-id: http://core.svn.wordpress.org/trunk@32636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:38:26 +00:00
Drew Jaynes
5e84c7004d Fix syntax and add a missing return description for inline documentation introduced in [32644] for WP_MS_Themes_List_Table. 
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32665


git-svn-id: http://core.svn.wordpress.org/trunk@32635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:36:27 +00:00
Drew Jaynes
88569734d8 Fix formatting and add missing return descriptions for inline documentation introduced in [32644] for WP_MS_Sites_List_Table. 
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32664


git-svn-id: http://core.svn.wordpress.org/trunk@32634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:34:25 +00:00
Drew Jaynes
42afe1d373 Fix formatting and add a missing return description for inline documentation introduced in [32644] for WP_Media_List_Table. 
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32663


git-svn-id: http://core.svn.wordpress.org/trunk@32633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:32:26 +00:00
Drew Jaynes
8bcf53cc68 Fix formatting and add missing return descriptions for inline documenation introduced in [32644] for WP_List_Table. 
Also fixes an error introduced in [32661] for `WP_Links_List_Table`.

See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32662


git-svn-id: http://core.svn.wordpress.org/trunk@32632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:29:26 +00:00
Drew Jaynes
2a0048b1fb Fix formatting and add a missing return description for inline documentation introduced in [32644] for WP_Links_List_Table. 
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32661


git-svn-id: http://core.svn.wordpress.org/trunk@32631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:23:26 +00:00
Drew Jaynes
5457eb4933 Add missing return descriptions and fix formatting of inline documentation introduced in [32644]. 
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32660


git-svn-id: http://core.svn.wordpress.org/trunk@32630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-31 01:18:26 +00:00
Boone Gorges
4b546044d8 Term unit test factory class should override create_and_get() method. 
The override is necessary because the `get_term()` call, which fetches the
term object, needs the `'taxonomy'` argument passed to the factory method.

Props dlh.
Fixes #32536.
Built from https://develop.svn.wordpress.org/trunk@32659


git-svn-id: http://core.svn.wordpress.org/trunk@32629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-30 13:04:25 +00:00
Weston Ruter
98b03d376e Add JS templates for Customizer Panels and Sections. 
This extends the approach taken for Customizer Controls in #29572.

Props celloexpressions, westonruter, ocean90.
See #30737.

Built from https://develop.svn.wordpress.org/trunk@32658


git-svn-id: http://core.svn.wordpress.org/trunk@32628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-30 00:03:30 +00:00
Scott Taylor
c502a281bb After [32656], add @access annotations to methods that have no doc block in wp-includes/*. 
Makes it easier to search for no doc blocks via `}[\n\t\r ]+(protected|private|public)`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32657


git-svn-id: http://core.svn.wordpress.org/trunk@32627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 21:37:24 +00:00
Scott Taylor
6a08b00632 Add @access annotations to methods that have no doc block in wp-admin/includes/*. 
Makes it easier to search for no doc blocks via `}[\n\t\r ]+(protected|private|public)`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32656


git-svn-id: http://core.svn.wordpress.org/trunk@32626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 21:32:24 +00:00
Scott Taylor
b3e0cfd25d Add (more) missing doc blocks to wp-admin/includes/*. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32655


git-svn-id: http://core.svn.wordpress.org/trunk@32625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 21:17:27 +00:00
Scott Taylor
c6a4512b1b Add missing doc blocks to wp-admin/includes/*. 
Fix some egregious uses of tabbing.
Some functions can simply return `apply_filters(...)` instead of setting a variable that is immediately returned.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32654


git-svn-id: http://core.svn.wordpress.org/trunk@32624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 20:17:26 +00:00
Scott Taylor
a51dfa3971 In the style of #30947 and default-filters.php, add 2 new files to wp-admin/includes: 
`admin-filters.php`
`ms-admin-filters.php`

There are random actions and filters littered among files like `misc.php`. These files contain functions that won't work outside of admin context and are typically only loaded in files that have already loaded the admin bootstrap.

See #32529.

Built from https://develop.svn.wordpress.org/trunk@32653


git-svn-id: http://core.svn.wordpress.org/trunk@32623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 17:04:26 +00:00
Scott Taylor
9a29d8ac7b Add missing annotations to ajax-actions.php` 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32652


git-svn-id: http://core.svn.wordpress.org/trunk@32622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 16:01:27 +00:00
Helen Hou-Sandí
f5646cd9e5 Define a primary column for WP_Post_Comments_List_Table. 
props boonebgorges.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32651


git-svn-id: http://core.svn.wordpress.org/trunk@32621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 15:52:25 +00:00
Scott Taylor
19a3aacc94 Add @static* annotations where they are missing. 
Initialize all static vars that are not, most to `null`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32650


git-svn-id: http://core.svn.wordpress.org/trunk@32620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 15:43:29 +00:00
Dominik Schilling
fccc19b510 Customizer: Replace accordion behavior of sections with a slide-in navigation. 
This allows users to focus on the contents of the active section more easily and separating the navigation from the content/controls in the Customizer.

props valendesigns, celloexpressions.
see #31336.
Built from https://develop.svn.wordpress.org/trunk@32649


git-svn-id: http://core.svn.wordpress.org/trunk@32619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 13:57:26 +00:00
Boone Gorges
ebac76facc When parsing what appears to be a date archive request, check for a post with a clashing permalink before resolving to the archive. 
A URL like `example.com/2015/05/15/` generally resolves to the May 15, 2015 date
archive. But in certain cases, it could also be the permalink of a post with
the slug `'2015'`. When a conflict of this sort is detected, resolve to the post
instead of the archive.

URL conflicts of this sort should no longer occur for new posts; see [32647].

Props valendesigns, boonebgorges, Denis-de-Bernardy.
Fixes #5305.
Built from https://develop.svn.wordpress.org/trunk@32648


git-svn-id: http://core.svn.wordpress.org/trunk@32618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 13:10:24 +00:00
Boone Gorges
9f0c6cbf8c Disallow post slugs that will result in permalinks that conflict with date archive URLs. 
On certain permalink structures, a numeric post slug will result in a post
permalink that conflicts with a date archive URL. For example, with permastruct
`/%year%/%monthnum%/%postname%/`, a post published in May 2015 with slug
`'15'` will result in a URL (`/2015/05/15/`) that conflicts with the archive
for May 15, 2015.

To avoid this problem, `wp_unique_post_slug()` rejects a requested slug when it
would generate a conflict of this type. Thus, in our example, `'15'` would
become `'15-2'`.

Props valendesigns, boonebgorges, Denis-de-Bernardy, loushou.
See #5305.
Built from https://develop.svn.wordpress.org/trunk@32647


git-svn-id: http://core.svn.wordpress.org/trunk@32617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 12:53:24 +00:00
Boone Gorges
66d76318b8 is_email_address_unsafe() tests should only be run on multisite. 
See [32638].
Built from https://develop.svn.wordpress.org/trunk@32646


git-svn-id: http://core.svn.wordpress.org/trunk@32616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 12:38:30 +00:00
Helen Hou-Sandí
fbb83441cb After [32644], sanity for a pile of selectors. 
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32645


git-svn-id: http://core.svn.wordpress.org/trunk@32615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 03:00:26 +00:00
Helen Hou-Sandí
4c0c7fd7ba List tables: introduce the concept of a "primary" column. 
This becomes the column that contains the row actions, and allows for a more flexibility, particularly with custom post types and list tables. To (re)define the primary column, use the `list_table_primary_column` filter, which receives the column name and the screen ID as arguments.

props stephdau, DaveAl, jesin.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32644


git-svn-id: http://core.svn.wordpress.org/trunk@32614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 02:41:25 +00:00
Scott Taylor
282e28ad81 Add @global annotations to (the rest of the?) wp-admin/* files. 
Does not include list table file changes.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32643


git-svn-id: http://core.svn.wordpress.org/trunk@32613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 02:06:31 +00:00
Scott Taylor
b56b9b3e5c Add @global annotations for wp-admin/*. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32642


git-svn-id: http://core.svn.wordpress.org/trunk@32612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-28 21:41:30 +00:00
Scott Taylor
6ab487dde6 Add missing/alter existing doc blocks for wp-db.php. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32641


git-svn-id: http://core.svn.wordpress.org/trunk@32611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-28 20:10:29 +00:00
Scott Taylor
2f3e567f44 Alter visibility of some properties in wpdb: 
`num_queries` is accessed publicly in core.
`num_rows` is accessed publicly in `ms-settings.php`.
`insert_id` is accessed publicly in core.
`prefix` is accessed publicly in `upgrade.php` and `capabilities.php`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32640


git-svn-id: http://core.svn.wordpress.org/trunk@32610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-28 16:34:25 +00:00
Scott Taylor
bece996d45 Add missing doc blocks to widgets.php. 
Cleanup `@return` values.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32639


git-svn-id: http://core.svn.wordpress.org/trunk@32609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-28 16:20:25 +00:00
Boone Gorges
b1c2305aa1 Improve tests for is_email_address_unsafe(). 
* Move to a separate file for better organization and method names.
* Use a `dataProvider` when appropriate, for better readability.
* Add a test for splitting the banned domain list on line breaks.

See #20459, #21730.
Built from https://develop.svn.wordpress.org/trunk@32638


git-svn-id: http://core.svn.wordpress.org/trunk@32608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-28 16:06:27 +00:00
Scott Taylor
d38fed6449 Add missing doc blocks to user.php. 
`username_exists()` should return `false` instead of `null`, just like `email_exists()` does, which is right under it.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32637


git-svn-id: http://core.svn.wordpress.org/trunk@32607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-28 15:51:25 +00:00
Helen Hou-Sandí
abfece527b About: Give bottom navigation links the full width. 
This will prevent longer strings from wrapping needlessly, and is more semantically correct markup.

props tyxla.
fixes #32391.

Built from https://develop.svn.wordpress.org/trunk@32636


git-svn-id: http://core.svn.wordpress.org/trunk@32606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-28 15:39:24 +00:00
Scott Taylor
66a9c83284 Add missing doc blocks to update.php: 
* `wp_version_check()`, `wp_update_plugins()`, and `wp_update_themes()` do not return meaningful responses, and their responses are never handled by core. As such, they shouldn't alternately return `void` or `false`. "Returning" in those functions is just "bailing"
* In the same functions, `version.php` doesn't need to load if `WP_INSTALLING` is defined - the function will immediately bail, the values will never be read, and the globals won't be reset. I have unified the approach in all 3 functions.
* When returning filtered `$locale`, there is no need to set the variable twice.
* In `_maybe_update_core()`, `isset()` can take multiple values to bail before the call to `time()`, if necessary. This is a micro-optimization to prevent PHP from hitting the OS unnecessarily.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32635


git-svn-id: http://core.svn.wordpress.org/trunk@32605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-28 15:29:28 +00:00
Jeremy Felt
f1ff34e547 Use a dataProvider for network option sanitization tests. 
Cleans up tests for sanitization of `illegal_names`, `illegal_email_domains`, and `banned_email_domains` network options.

Fixes #32517.

Built from https://develop.svn.wordpress.org/trunk@32634


git-svn-id: http://core.svn.wordpress.org/trunk@32604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-28 06:38:25 +00:00
Andrew Nacin
6df83c542b Revert change to default-filters.php in [32632]. see #32516. 
Built from https://develop.svn.wordpress.org/trunk@32633


git-svn-id: http://core.svn.wordpress.org/trunk@32603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-28 05:52:25 +00:00
Andrew Nacin
65c382d550 Fix return error in get_theme_mods() from [32629]. 
Split a line with both an assignment and a conditional, not to mention an interpolated variable. Lots going on, easy mistake to make.

props BrianLayman.
fixes #32516.

Built from https://develop.svn.wordpress.org/trunk@32632


git-svn-id: http://core.svn.wordpress.org/trunk@32602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-28 05:51:25 +00:00
Andrew Nacin
e9551d2d43 Add unit test asserting that serializable objects will never pass is_serialized(). see #17375. 
Built from https://develop.svn.wordpress.org/trunk@32631


git-svn-id: http://core.svn.wordpress.org/trunk@32601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-28 05:23:27 +00:00
Jeremy Felt
a5c688e817 Use site objects rather than get_blog_status() in MS list tables. 
Removes several repetitive calls to `get_blog_status()` that are not needed, as the data is already available as part of each site's object.

Fixes #32512.

Built from https://develop.svn.wordpress.org/trunk@32630


git-svn-id: http://core.svn.wordpress.org/trunk@32600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 23:14:29 +00:00
Scott Taylor
b4eccbd5a0 Add missing doc blocks to theme.php. 
Correct some `@return` values.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32629


git-svn-id: http://core.svn.wordpress.org/trunk@32599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 22:21:25 +00:00
Scott Taylor
0c1b765a6f Add missing doc blocks to template.php. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32628


git-svn-id: http://core.svn.wordpress.org/trunk@32598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 22:04:26 +00:00
Scott Taylor
4777433584 Add missing doc blocks to taxonomy.php. 
Correct some `@return` values.
Some functions can `return new WP_Error` without setting it to a variable.
Some functions can return their `apply_filters(...)` call without first setting it to a variable.
`is_object_in_taxonomy()` can return its conditional instead of if/else true/false.
 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32627


git-svn-id: http://core.svn.wordpress.org/trunk@32597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 22:00:25 +00:00
Jeremy Felt
45ad4808d9 Provide all site flag data in objects returned by get_blogs_of_user() 
Previously, `archived`, `spam`, and `deleted` properties were forced to `0` when returned by `get_blogs_of_user()`. This was originally introduced in [21794] as a way to prevent notices when properties were expected.

Instead, we can properly fill these properties with those retrieved from `get_blog_details()`.

Props realloc.
Fixes #32281.

Built from https://develop.svn.wordpress.org/trunk@32626


git-svn-id: http://core.svn.wordpress.org/trunk@32596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 21:23:26 +00:00
Mark Jaquith
0a70901c50 Insert temporary password field hook for feature development in a plugin. 
Built from https://develop.svn.wordpress.org/trunk@32625


git-svn-id: http://core.svn.wordpress.org/trunk@32595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 19:59:25 +00:00
Scott Taylor
2bac335bdc Add missing doc blocks to shortcodes.php. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32624


git-svn-id: http://core.svn.wordpress.org/trunk@32594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 19:39:25 +00:00
Scott Taylor
e4a574fc87 Add missing doc blocks to script-loader.php. 
Use `wp_styles()` and `wp_scripts()` where appropriate. 
 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32623


git-svn-id: http://core.svn.wordpress.org/trunk@32593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 19:34:27 +00:00
Scott Taylor
274daa059a Add missing doc blocks to rewrite.php. 
Clarify `@return` values where necessary.
`add_permastruct()` doesn't need to return.
`->using_index_permalinks()` and `->using_mod_rewrite_permalinks()` can just return their conditions, instead of if/else true/false.
`->mod_rewrite_rules()` and `->iis7_url_rewrite_rules()` don't need to set a variable that is immediately returned.
 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32622


git-svn-id: http://core.svn.wordpress.org/trunk@32592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 19:23:26 +00:00
Scott Taylor
5ee54c05ac Add missing doc blocks to revision.php. 
Clarify `@return` values where necessary.
In `wp_delete_post_revision()`, `wp_delete_post()` doesn't return `WP_Error`, so that check can be removed.
`wp_revisions_to_keep()` always returns an `int`, so `wp_revisions_enabled()` can use strict comparison.
 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32621


git-svn-id: http://core.svn.wordpress.org/trunk@32591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 18:38:24 +00:00
Scott Taylor
1ef11d7789 Add missing doc blocks to query.php. 
Clarify `@return` values where necessary.
Some wrapper functions don't need to return if the function they wrap doesn't return.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32620


git-svn-id: http://core.svn.wordpress.org/trunk@32590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 18:15:25 +00:00
Scott Taylor
2ebce023df Add missing doc blocks to post.php. 
Clarify some existing values for `@param` and `@return`.
Some functions do not need to set a variable before immediately returning it.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32619


git-svn-id: http://core.svn.wordpress.org/trunk@32589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 17:05:26 +00:00
Scott Taylor
2f75a74b3e Add missing doc blocks to post-thumbnail-template.php. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32618


git-svn-id: http://core.svn.wordpress.org/trunk@32588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 16:29:28 +00:00
Scott Taylor
bba3f1785c Add missing doc blocks to post-template.php. 
Correct some types for `@param` and `@return`.
`is_page_template()` can return the conditional instead of if/else true/false.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32617


git-svn-id: http://core.svn.wordpress.org/trunk@32587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 16:26:25 +00:00
Scott Taylor
4c6d8467e2 Add missing doc blocks to post-formats.php. 
Correct some types for `@param` and `@return`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32616


git-svn-id: http://core.svn.wordpress.org/trunk@32586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 16:06:25 +00:00
Scott Taylor
fd04235a04 Add missing doc blocks to plugin.php. 
`has_filter()` can use strict comparison when checking `$has` internally.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32615


git-svn-id: http://core.svn.wordpress.org/trunk@32585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 15:56:26 +00:00
Scott Taylor
26554549c7 Add missing doc blocks for pluggable.php. 
Correct some `@return` values.
`is_user_logged_in()` can simply return the `->exists()` call instead of if/else'ing true/false.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32614


git-svn-id: http://core.svn.wordpress.org/trunk@32584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-27 15:32:26 +00:00
Scott Taylor
ea89aeee0b Fix doc blocks for option.php. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32613


git-svn-id: http://core.svn.wordpress.org/trunk@32583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-26 22:17:25 +00:00
Scott Taylor
cb0b0b109d Fix doc blocks for nav-menu*.php files. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32612


git-svn-id: http://core.svn.wordpress.org/trunk@32582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-26 22:10:25 +00:00
Scott Taylor
4d26d999ce Fix doc blocks for ms-*.php files. 
A few functions can return a conditional instead of an `if`/`else` of `true`/`false`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32611


git-svn-id: http://core.svn.wordpress.org/trunk@32581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-26 21:51:31 +00:00
Scott Taylor
cae2415562 Fix doc blocks for meta.php 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32610


git-svn-id: http://core.svn.wordpress.org/trunk@32580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-26 19:33:25 +00:00
Scott Taylor
4bf8e158ec Fix doc blocks for media*.php 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32609


git-svn-id: http://core.svn.wordpress.org/trunk@32579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-26 19:23:25 +00:00
Scott Taylor
5845a0c372 Add missing doc blocks to locale.php 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32608


git-svn-id: http://core.svn.wordpress.org/trunk@32578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-26 18:59:25 +00:00
Scott Taylor
0ba1025d66 Add missing doc blocks to load.php 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32607


git-svn-id: http://core.svn.wordpress.org/trunk@32577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-26 18:53:27 +00:00
Scott Taylor
bf16064448 Fix doc blocks to link-template.php 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32606


git-svn-id: http://core.svn.wordpress.org/trunk@32576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-26 18:44:25 +00:00
Scott Taylor
2787e0080a Add missing doc blocks to l10n.php 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32605


git-svn-id: http://core.svn.wordpress.org/trunk@32575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-26 18:13:25 +00:00
Boone Gorges
8f9a7c4f83 Improve unit tests for wp_unique_post_slug(). 
See #5305.
Built from https://develop.svn.wordpress.org/trunk@32604


git-svn-id: http://core.svn.wordpress.org/trunk@32574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-26 18:08:24 +00:00
Scott Taylor
4b24007353 Add missing doc blocks to kses.php - also fix some unfortunate whitespace issues in related funcs. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32603


git-svn-id: http://core.svn.wordpress.org/trunk@32573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-26 18:06:24 +00:00
Weston Ruter
7792b5c942 Add support for WP_Widget::get_settings() returning ArrayIterator/ArrayObject instances. 
Plugins can use `pre_option_widget_{$id_base}` filters to return `ArrayIterator`/`ArrayObject` instances instead of primitive arrays. This makes possible for widget instance data to be drawn from somewhere else than `wp_options`, such as a custom post type.

Add unit tests for widgets.

Fixes #32474.


Built from https://develop.svn.wordpress.org/trunk@32602


git-svn-id: http://core.svn.wordpress.org/trunk@32572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-26 16:51:27 +00:00
Weston Ruter
0f5e6d2825 Fix wp_send_json_error() response for update-widget Ajax request, to return error code instead of error message, as the WP_Error objects are instantiated with codes and the messages are empty. 
Fixes #32496.


Built from https://develop.svn.wordpress.org/trunk@32601


git-svn-id: http://core.svn.wordpress.org/trunk@32571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-25 22:09:25 +00:00
Scott Taylor
19b8ef0c92 get_comments() can return int, so a few places need to check if the return value is traversable before passing what is assumed to be an array. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32600


git-svn-id: http://core.svn.wordpress.org/trunk@32570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-25 17:59:25 +00:00
Scott Taylor
053790537f Cleanup doc blocks in http.php. 
In the few functions that used `$objFetchSite` instead of `$http`: use the `$http` naming, which is more civilized.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32599


git-svn-id: http://core.svn.wordpress.org/trunk@32569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-25 17:32:27 +00:00
Scott Taylor
82f5d2e9b5 Cleanup doc blocks in general-template.php. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32598


git-svn-id: http://core.svn.wordpress.org/trunk@32568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-25 17:18:26 +00:00
Scott Taylor
bbe2301960 Cleanup the use of $wp_styles global in functions.wp-styles.php. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32597


git-svn-id: http://core.svn.wordpress.org/trunk@32567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-25 16:35:24 +00:00
Scott Taylor
ebd7fe8a2f Cleanup the use of $wp_scripts global in functions.wp-scripts.php. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32596


git-svn-id: http://core.svn.wordpress.org/trunk@32566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-25 16:24:25 +00:00
Scott Taylor
89a6ace623 Add missing doc blocks to wp-includes/functions.php. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32595


git-svn-id: http://core.svn.wordpress.org/trunk@32565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-25 16:11:25 +00:00
Boone Gorges
51a892f975 Pass the original $user_id variable to the filter in get_the_author_meta(). 
Props dlh, chriscct7.
Fixes #32481.
Built from https://develop.svn.wordpress.org/trunk@32594


git-svn-id: http://core.svn.wordpress.org/trunk@32564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-25 13:06:25 +00:00
Ella Iseulde Van Dorpe
677c3e53bb Link modal: reset search results appropriately 
Reset the search results when the input field is emptied with the
browser's "clear" button inside that field.

Fixes #32174.

Built from https://develop.svn.wordpress.org/trunk@32593


git-svn-id: http://core.svn.wordpress.org/trunk@32563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-25 06:41:25 +00:00
Ella Iseulde Van Dorpe
6e0e924de9 TinyMCE: wpeditimage: trim class 
Don't add extra spaces to classes. It causes some tests in the TinyMCE QUnit test suite to fail.

Fixes #31764.

Built from https://develop.svn.wordpress.org/trunk@32592


git-svn-id: http://core.svn.wordpress.org/trunk@32562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-25 06:35:28 +00:00
Drew Jaynes
4c37f68b79 Fix inline documentation syntax in wp_xmlrpc_server. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32591


git-svn-id: http://core.svn.wordpress.org/trunk@32561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-25 06:25:25 +00:00
Scott Taylor
bd8fafea54 Use void instead of null where appropriate when pipe-delimiting @return types. If a @return only contains void, remove it. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32568


git-svn-id: http://core.svn.wordpress.org/trunk@32538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-24 05:40:25 +00:00
Scott Taylor
876918dc53 Add missing doc blocks to comment-template.php. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32567


git-svn-id: http://core.svn.wordpress.org/trunk@32537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-24 05:19:24 +00:00
Scott Taylor
451914addb Add missing doc blocks to class.wp-(scripts|styles).php. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32566


git-svn-id: http://core.svn.wordpress.org/trunk@32536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-24 05:05:26 +00:00
Drew Jaynes
459ccb0d8b Add missing or incomplete argument and return descriptions for wp_xmlrpc_server->wp_editPost(). 
Also includes many small syntax fixes for inline documentation throughout the file.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@32565


git-svn-id: http://core.svn.wordpress.org/trunk@32535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-23 19:47:25 +00:00
Drew Jaynes
2bebcf4c39 Add missing parameter and return descriptions to the DocBlock for wp_xmlrpc_server->_convert_date_gmt(). 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32564


git-svn-id: http://core.svn.wordpress.org/trunk@32534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-23 19:41:24 +00:00
Drew Jaynes
d94d97eab6 Add missing parameter and return descriptions to the DocBlock for wp_xmlrpc_server->_convert_date(). 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32563


git-svn-id: http://core.svn.wordpress.org/trunk@32533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-23 19:40:24 +00:00
Drew Jaynes
9f73a3351f Fix inline documentation syntax in the DocBlock for wp_xmlrpc_server->_prepare_taxonomy(). 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32562


git-svn-id: http://core.svn.wordpress.org/trunk@32532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-23 19:38:25 +00:00
Drew Jaynes
8aa163e65a Fix some inline documentation syntax in the DocBlock for wp_xmlrpc_server->minimum_args(). 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32561


git-svn-id: http://core.svn.wordpress.org/trunk@32531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-23 19:37:26 +00:00
Drew Jaynes
ebe60d1fc4 Use a valid parameter type of string for the $name parameter in the xmlrpc_call hook docs. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32560


git-svn-id: http://core.svn.wordpress.org/trunk@32530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-23 19:36:26 +00:00
Drew Jaynes
18066945ae Add missing argument descriptions for the $args hash notation in wp_xmlrpc_server->wp_getUsersBlogs(). 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32559


git-svn-id: http://core.svn.wordpress.org/trunk@32529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-23 19:33:27 +00:00
Drew Jaynes
c76493d29b Properly notate the inline link to the xmlrpc_blog_options filter in the description for wp_xmlrpc_server->initialise_blog_option_info(). 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@32558


git-svn-id: http://core.svn.wordpress.org/trunk@32528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-23 19:30:26 +00:00
Drew Jaynes
ed0421e7de Add a proper return description for the wp_xmlrpc_server->addTwoNumbers() method. 
See [30181]. See #30224.

Built from https://develop.svn.wordpress.org/trunk@32557


git-svn-id: http://core.svn.wordpress.org/trunk@32527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-23 19:26:26 +00:00
Drew Jaynes
7a93dda2d2 Add proper descriptions for the $methods, $blog_options, and $error properties in wp_xmlrpc_server. 
See [30181]. See #30224.

Built from https://develop.svn.wordpress.org/trunk@32556


git-svn-id: http://core.svn.wordpress.org/trunk@32526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-23 19:23:25 +00:00
Drew Jaynes
7a7df47087 Add a proper description comment for the WP_Image_Editor_Imagick->$image property. 
See [30180]. See #30224.

Built from https://develop.svn.wordpress.org/trunk@32555


git-svn-id: http://core.svn.wordpress.org/trunk@32525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-23 19:20:24 +00:00
Drew Jaynes
a94c16f334 Add a proper description comment for the WP_Image_Editor_GD->$image property. 
See [30180]. See #30224.

Built from https://develop.svn.wordpress.org/trunk@32554


git-svn-id: http://core.svn.wordpress.org/trunk@32524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-23 19:10:28 +00:00
Boone Gorges
10dd80cc61 Introduced $field argument to get_term_link(). 
This new argument allows developers to specify which term field should be
matched by the value of the `$term` parameter (in particular, 'name' and
'term_taxonomy_id' are now supported).

Props sudar, mordauk.
Fixes #14156.
Built from https://develop.svn.wordpress.org/trunk@32553


git-svn-id: http://core.svn.wordpress.org/trunk@32523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-23 18:29:26 +00:00
Boone Gorges
0fa7bf9cb4 Unit tests for get_term_link(). 
See #14156.
Built from https://develop.svn.wordpress.org/trunk@32552


git-svn-id: http://core.svn.wordpress.org/trunk@32522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-23 18:13:24 +00:00
Scott Taylor
f217f8c5d2 Add missing doc blockss in class-wp.php. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32551


git-svn-id: http://core.svn.wordpress.org/trunk@32521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 20:05:25 +00:00
Scott Taylor
ecf4c668b3 Upgrade the doc blocks in class-wp-xmlrpc-server.php. Rehabilitate some unfortunate use of tabbing. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32550


git-svn-id: http://core.svn.wordpress.org/trunk@32520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 19:37:24 +00:00
Scott Taylor
c8a224c48e Cleanup missing doc blocks for class-wp-walker.php. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32549


git-svn-id: http://core.svn.wordpress.org/trunk@32519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 17:59:25 +00:00
Drew Jaynes
e90a327694 Add a missing @since version to a function introduced in [32541]. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32548


git-svn-id: http://core.svn.wordpress.org/trunk@32518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 17:38:25 +00:00
Scott Taylor
1b960d56b6 Add missing doc blocks to class-wp-theme.php. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32547


git-svn-id: http://core.svn.wordpress.org/trunk@32517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 17:31:27 +00:00
Scott Taylor
bf43be3e9e Add missing doc blocks to wp-image-editor*.php. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32546


git-svn-id: http://core.svn.wordpress.org/trunk@32516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 06:18:25 +00:00
Scott Taylor
af7a017f46 When calling unset(), it is unnecessary to immediately precede it with a call to isset(). 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32545


git-svn-id: http://core.svn.wordpress.org/trunk@32515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 05:47:25 +00:00
Scott Taylor
1fa7958fe8 Clean up doc blocks for class-wp-embed.php. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32544


git-svn-id: http://core.svn.wordpress.org/trunk@32514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 05:15:26 +00:00
Scott Taylor
94f29f27a1 Clean up @global doc blocks/imports for class-wp-editor.php. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32543


git-svn-id: http://core.svn.wordpress.org/trunk@32513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 05:10:24 +00:00
Scott Taylor
082bfab426 Clean up @global doc blocks/imports for class-wp-customizer-*.php and friends. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32542


git-svn-id: http://core.svn.wordpress.org/trunk@32512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 05:06:25 +00:00
Scott Taylor
1b52916239 Create a function, wp_roles(), to DRY the inline instantiation of the $wp_roles global. 
Add missing doc blocks for `capabilities.php`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32541


git-svn-id: http://core.svn.wordpress.org/trunk@32511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 04:47:24 +00:00
Scott Taylor
3d130ba909 Add missing doc blocks for canonical.php. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32540


git-svn-id: http://core.svn.wordpress.org/trunk@32510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 04:26:26 +00:00
Scott Taylor
ebd3201268 Add/standardize missing doc blocks for cache.php. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32539


git-svn-id: http://core.svn.wordpress.org/trunk@32509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 04:24:26 +00:00
Scott Taylor
5c6ffc4dd6 Add missing doc blocks to author-template.php. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32538


git-svn-id: http://core.svn.wordpress.org/trunk@32508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 04:14:24 +00:00
Scott Taylor
83dd461b2f Add missing doc blocks to admin-bar.php. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32537


git-svn-id: http://core.svn.wordpress.org/trunk@32507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 04:00:26 +00:00
Scott Taylor
3a5f584109 Add missing doc blocks to class-wp-editor.php. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32536


git-svn-id: http://core.svn.wordpress.org/trunk@32506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-22 03:52:27 +00:00
Scott Taylor
b2bbbf9759 In class-wp-customize-*, clarify/add some @param/@return blocks. Disambiguate some functions that are trying to return the void response of another function they call internally. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32535


git-svn-id: http://core.svn.wordpress.org/trunk@32505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-21 22:05:24 +00:00
Scott Taylor
f7098c8c2e In class-wp-admin-bar.php, clarify/add some doc blocks. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32534


git-svn-id: http://core.svn.wordpress.org/trunk@32504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-21 21:39:24 +00:00
Scott Taylor
3c24a2b32b In class-oembed.php, clarify/add some return docs. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32533


git-svn-id: http://core.svn.wordpress.org/trunk@32503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-21 21:31:27 +00:00
Scott Taylor
ed4aafa692 In category.php: 
* Clarify some `return` docs.
* In `_make_cat_compat()`, ensure that `WP_Error` is not decorated

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32532


git-svn-id: http://core.svn.wordpress.org/trunk@32502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-21 21:18:24 +00:00
Scott Taylor
27522d1c00 In category-template.php: 
* Clarify/add some `return` docs.
* In `walk_category_tree()` and `walk_category_dropdown_tree()`, make behavior consistent and don't pass `$walker` by-reference - it is no longer necessary to do that with object instances.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32531


git-svn-id: http://core.svn.wordpress.org/trunk@32501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-21 21:05:24 +00:00