Scott Taylor
|
b9afafffe3
|
hackificator complains if you call include 'file.php' without the parens, needs to be include( 'file.php' )
See #27881.
Built from https://develop.svn.wordpress.org/trunk@28479
git-svn-id: http://core.svn.wordpress.org/trunk@28306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-18 20:52:15 +00:00 |
|
Drew Jaynes
|
11dd3443a2
|
Improve inline documentation for default arguments in wp_get_archives() .
See #28298.
Built from https://develop.svn.wordpress.org/trunk@28476
git-svn-id: http://core.svn.wordpress.org/trunk@28303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-18 17:20:15 +00:00 |
|
Scott Taylor
|
87730b879f
|
Eliminate the use of extract() in MO::import_from_reader() .
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28472
git-svn-id: http://core.svn.wordpress.org/trunk@28299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-17 17:21:14 +00:00 |
|
Scott Taylor
|
f4661c6659
|
Eliminate the use of extract() in get_pages() .
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28471
git-svn-id: http://core.svn.wordpress.org/trunk@28298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-17 17:12:15 +00:00 |
|
Scott Taylor
|
1bd4118799
|
Eliminate the use of extract() in wp_insert_attachment() .
`wp_insert_attachment()` and `wp_insert_post()` are incredibly similar, but have branched logic. I have annotated many places where they diverge.
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28470
git-svn-id: http://core.svn.wordpress.org/trunk@28297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-17 16:54:14 +00:00 |
|
Scott Taylor
|
73a9ba7428
|
Eliminate the use of extract() in wp_insert_post() .
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28469
git-svn-id: http://core.svn.wordpress.org/trunk@28296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-17 15:53:15 +00:00 |
|
Scott Taylor
|
eea7052df8
|
Eliminate the use of extract() in wp_delete_term() .
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28466
git-svn-id: http://core.svn.wordpress.org/trunk@28293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-17 14:55:14 +00:00 |
|
Scott Taylor
|
bec9993f38
|
Eliminate the use of extract() in get_terms() .
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28465
git-svn-id: http://core.svn.wordpress.org/trunk@28292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-17 14:47:14 +00:00 |
|
Scott Taylor
|
c1b5670a00
|
Eliminate the use of extract() in wp_insert_term() .
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28464
git-svn-id: http://core.svn.wordpress.org/trunk@28291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-17 14:16:14 +00:00 |
|
Scott Taylor
|
66c3f62a54
|
Eliminate use of extract() in wp_update_term() .
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28461
git-svn-id: http://core.svn.wordpress.org/trunk@28288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-16 21:29:13 +00:00 |
|
Scott Taylor
|
a39aecc9b1
|
The cache key for comments in WP_Comment_Query::query() needs to do wp_array_slice_assoc( $this->query_vars, array_keys( $defaults ) ) instead of compact( array_keys( $defaults ) ) . The latter assumes all of those variables are still floating around.
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28460
git-svn-id: http://core.svn.wordpress.org/trunk@28287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-16 21:09:14 +00:00 |
|
Scott Taylor
|
0aafc8f874
|
(ACTUALLY) Eliminate use of extract() in WP_Comment_Query::query() .
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28459
git-svn-id: http://core.svn.wordpress.org/trunk@28286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-16 20:52:14 +00:00 |
|
Scott Taylor
|
4f57a231c5
|
Eliminate use of extract() in WP_Comment_Query::query() .
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28458
git-svn-id: http://core.svn.wordpress.org/trunk@28285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-16 19:33:14 +00:00 |
|
Scott Taylor
|
14ba67c38d
|
Eliminate use of extract() in wp_insert_comment() .
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28457
git-svn-id: http://core.svn.wordpress.org/trunk@28284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-16 18:52:16 +00:00 |
|
Andrew Ozz
|
f184243aa3
|
DFW: fix closing only the wpLink or media modal when pressing Esc.
Built from https://develop.svn.wordpress.org/trunk@28455
git-svn-id: http://core.svn.wordpress.org/trunk@28282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-16 18:17:14 +00:00 |
|
Scott Taylor
|
877fad9f38
|
Eliminate use of extract() in wp_insert_user() .
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28454
git-svn-id: http://core.svn.wordpress.org/trunk@28281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-16 18:15:15 +00:00 |
|
Scott Taylor
|
a25e03f833
|
In wp_xmlrpc_server::mw_editPost , also set $post_type = $postdata['post_type'] .
See #22400, [28448].
Built from https://develop.svn.wordpress.org/trunk@28453
git-svn-id: http://core.svn.wordpress.org/trunk@28280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-16 18:06:15 +00:00 |
|
Scott Taylor
|
fdaea6b7f2
|
Eliminate use of extract() in wp_widget_rss_form() .
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28449
git-svn-id: http://core.svn.wordpress.org/trunk@28276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-16 15:38:14 +00:00 |
|
Scott Taylor
|
463b7c4620
|
Eliminate use of extract() in wp_xmlrpc_server::mw_editPost() (MetaWeblog API, y'all).
A lot of the extracted variables are overwritten by being explicitly set later.
Only set variables that would otherwise not be present with `compact()` is called.
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28448
git-svn-id: http://core.svn.wordpress.org/trunk@28275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-16 15:19:14 +00:00 |
|
Sergey Biryukov
|
5c2d25aa77
|
Filter out empty and duplicate values in Comment Moderation and Comment Blacklist settings.
props GaVrA.
fixes #23800.
Built from https://develop.svn.wordpress.org/trunk@28444
git-svn-id: http://core.svn.wordpress.org/trunk@28271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-16 11:10:14 +00:00 |
|
Sergey Biryukov
|
abc830ca9d
|
DFW: Properly handle Esc key when the content is focused or when switching browser tabs.
props avryl.
fixes #28279.
Built from https://develop.svn.wordpress.org/trunk@28443
git-svn-id: http://core.svn.wordpress.org/trunk@28270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-16 10:43:14 +00:00 |
|
Sergey Biryukov
|
d970ac80c6
|
Don't include caption tags in gallery template when there is no caption.
props avryl.
fixes #28089.
Built from https://develop.svn.wordpress.org/trunk@28442
git-svn-id: http://core.svn.wordpress.org/trunk@28269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-15 21:03:15 +00:00 |
|
Scott Taylor
|
5a5c86139f
|
Eliminate use of extract() in wp_get_object_terms() .
There are 3 properties, just set them to variables. They are used too often to warrant a refactor.
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28441
git-svn-id: http://core.svn.wordpress.org/trunk@28268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-15 19:58:15 +00:00 |
|
Scott Taylor
|
6e8e30bb1e
|
Eliminate use of extract() in wp_widget_rss_output() .
Add `'items' => 0` to `$default_args`. When `0`, the value is set to `10` (the fallback).
Every other default arg has a default value of `0`.
`items` is expected to always be passed to this function.
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28440
git-svn-id: http://core.svn.wordpress.org/trunk@28267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-15 19:42:13 +00:00 |
|
Scott Taylor
|
157f811a5e
|
Eliminate use of extract() in WP_Widget_RSS::widget() .
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28439
git-svn-id: http://core.svn.wordpress.org/trunk@28266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-15 19:36:15 +00:00 |
|
Scott Taylor
|
72fd658cde
|
In Walker_Category::start_el() , $title might not be set when $args are passed multiple levels into walk_category_tree() .
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28438
git-svn-id: http://core.svn.wordpress.org/trunk@28265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-15 19:14:14 +00:00 |
|
Scott Taylor
|
2a3548fe70
|
Eliminate use of extract() in wp_allow_comment() .
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28437
git-svn-id: http://core.svn.wordpress.org/trunk@28264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-15 18:10:15 +00:00 |
|
Scott Taylor
|
2b125a881b
|
Eliminate use of extract() in Walker_Category::start_el() .
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28436
git-svn-id: http://core.svn.wordpress.org/trunk@28263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-15 17:58:13 +00:00 |
|
Scott Taylor
|
9b210df2b9
|
Eliminate use of extract() in wp_generate_tag_cloud() .
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28435
git-svn-id: http://core.svn.wordpress.org/trunk@28262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-15 17:48:15 +00:00 |
|
Scott Taylor
|
9c8becc1f7
|
Eliminate use of extract() in wp_list_categories() .
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28434
git-svn-id: http://core.svn.wordpress.org/trunk@28261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-15 17:28:14 +00:00 |
|
Scott Taylor
|
67c51361d6
|
Eliminate use of extract() in default-widgets.php .
Props rzen, wonderboymusic.
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28433
git-svn-id: http://core.svn.wordpress.org/trunk@28260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-15 16:33:15 +00:00 |
|
Scott Taylor
|
b788832722
|
Eliminate use of extract() in wp_dropdown_categories() .
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28432
git-svn-id: http://core.svn.wordpress.org/trunk@28259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-15 15:48:14 +00:00 |
|
Scott Taylor
|
78b6f2761d
|
Eliminate use of extract() in get_comment_reply_link() .
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28431
git-svn-id: http://core.svn.wordpress.org/trunk@28258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-15 15:35:15 +00:00 |
|
Scott Taylor
|
11aa170e30
|
Eliminate use of extract() in WP_Ajax_Response::add() . Just set most of the properties to variables to avoid interpolation churn.
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28430
git-svn-id: http://core.svn.wordpress.org/trunk@28257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-15 15:25:14 +00:00 |
|
Scott Taylor
|
7943f4715a
|
Eliminate the use of extract() in get_post_reply_link() .
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28429
git-svn-id: http://core.svn.wordpress.org/trunk@28256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-15 06:49:14 +00:00 |
|
Scott Taylor
|
0e2909ce89
|
Eliminate the use of extract() in wp_list_comments() . All unit tests pass.
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28428
git-svn-id: http://core.svn.wordpress.org/trunk@28255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-15 06:43:15 +00:00 |
|
Scott Taylor
|
a15d498d1a
|
Eliminate the use of extract() in wp_update_comment() . All unit tests pass.
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28427
git-svn-id: http://core.svn.wordpress.org/trunk@28254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-15 06:37:15 +00:00 |
|
Scott Taylor
|
bbcc03a750
|
Eliminate the use of extract() in wp_check_filetype_and_ext() .
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28426
git-svn-id: http://core.svn.wordpress.org/trunk@28253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-15 06:22:14 +00:00 |
|
Scott Taylor
|
8e98541d5f
|
Eliminate the use of extract() in wp_mail() . Check the filtered array for each value before re-setting variables.
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28425
git-svn-id: http://core.svn.wordpress.org/trunk@28252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-15 06:17:15 +00:00 |
|
Scott Taylor
|
f5bd0de275
|
Eliminate the use of extract() in wp_validate_auth_cookie() .
Don't do anything fancy here, just set the 4 returned properties to variables. This function is semi-important.
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28424
git-svn-id: http://core.svn.wordpress.org/trunk@28251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-15 06:11:13 +00:00 |
|
Scott Taylor
|
eb2bbf9c97
|
Eliminate the use of extract() in get_objects_in_term() . Only one property (order ) was extracted.
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28423
git-svn-id: http://core.svn.wordpress.org/trunk@28250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-15 05:43:16 +00:00 |
|
Scott Taylor
|
80a37d2fcd
|
Eliminate the use of extract() in WP_Tax_Query::get_sql() . All unit tests still pass.
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28422
git-svn-id: http://core.svn.wordpress.org/trunk@28249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-15 05:41:14 +00:00 |
|
Scott Taylor
|
e6fad96f5e
|
Eliminate the use of extract() in the_taxonomies() . Adds unit test.
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28421
git-svn-id: http://core.svn.wordpress.org/trunk@28248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-15 05:25:14 +00:00 |
|
Scott Taylor
|
ee90a8c17c
|
Eliminate the use of extract() in wp_dropdown_users() .
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28420
git-svn-id: http://core.svn.wordpress.org/trunk@28247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-15 05:18:15 +00:00 |
|
Scott Taylor
|
ae61a48489
|
Set @param back to $output , not $html , in the inline filter docs. This was a copy/paste mistake.
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28419
git-svn-id: http://core.svn.wordpress.org/trunk@28246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-15 05:08:14 +00:00 |
|
Scott Taylor
|
c0b0b00e6d
|
Eliminate use of extract() in get_the_taxonomies() . Adds unit test.
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28415
git-svn-id: http://core.svn.wordpress.org/trunk@28242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-15 03:51:13 +00:00 |
|
Scott Taylor
|
dcc6cbc04f
|
Eliminate use of extract() in gallery_shortcode() .
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28414
git-svn-id: http://core.svn.wordpress.org/trunk@28241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-15 03:41:15 +00:00 |
|
Scott Taylor
|
947aa04900
|
Update the inline docs for add_shortcode() to eliminate suggestion to use extract() .
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28413
git-svn-id: http://core.svn.wordpress.org/trunk@28240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-15 03:28:15 +00:00 |
|
Scott Taylor
|
4b94efd93b
|
Eliminate use of extract() in wp_xmlrpc_server::blogger_editPost() .
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28412
git-svn-id: http://core.svn.wordpress.org/trunk@28239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-15 03:25:15 +00:00 |
|
Scott Taylor
|
54321f4c6e
|
Eliminate use of extract() in get_media_item() .
To test, fire open the old media in the console: `tb_show('Old Media is Weird', 'media-upload.php?type=image&TB_iframe=true&post_id=0');`
See #22400.
Built from https://develop.svn.wordpress.org/trunk@28407
git-svn-id: http://core.svn.wordpress.org/trunk@28234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
2014-05-15 02:45:15 +00:00 |
|