Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-12-27 19:47:42 +01:00
Code Issues Projects Releases Wiki Activity
42,978 Commits 50 Branches 749 Tags 806 MiB
ec900ebb43
Commit Graph

16678 Commits

Author SHA1 Message Date
Sergey Biryukov
87fbad7286 Bundled Themes: Introduce block patterns for Twenty Seventeen. 
Props melchoyce, kjellr, onemaggie, ryelle, beafialho, bridgetwillard, poena.
Fixes #51100.
Built from https://develop.svn.wordpress.org/trunk@49584


git-svn-id: http://core.svn.wordpress.org/trunk@49322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 21:22:12 +00:00
Sergey Biryukov
b6f30e3009 Bundled Themes: Introduce block patterns for Twenty Sixteen. 
Props melchoyce, kjellr, onemaggie, ryelle, beafialho, bridgetwillard, poena, jffng.
Fixes #51101.
Built from https://develop.svn.wordpress.org/trunk@49583


git-svn-id: http://core.svn.wordpress.org/trunk@49321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 21:14:12 +00:00
Sergey Biryukov
f2364f163b Administration: Make sure auto-update counts properly update when bulk deleting plugins or themes. 
Props pbiron, noisysocks, desrosj, audrasjb, hellofromTonya.
Fixes #50870.
Built from https://develop.svn.wordpress.org/trunk@49582


git-svn-id: http://core.svn.wordpress.org/trunk@49320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 20:42:10 +00:00
Helen Hou-Sandí
d5fd3bd452 Upgrade/Install: Enable all core autoupdates for new installs. 
Likely needs more work for multisite installs.

Reference: https://make.wordpress.org/core/2020/11/10/wp5-6-auto-update-implementation-change/

Props audrasjb, azaozz.
See #51743.

Built from https://develop.svn.wordpress.org/trunk@49581


git-svn-id: http://core.svn.wordpress.org/trunk@49319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 20:22:09 +00:00
John Blackbourn
9115246f72 General: Convert wp_array_get() to a "private" function and add tests. 
This function may be promoted in the future if it's deemed useful enough.

Props dd32, jorgefilipecosta, Hareesh Pillai

Fixes #51720

Built from https://develop.svn.wordpress.org/trunk@49580


git-svn-id: http://core.svn.wordpress.org/trunk@49318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 20:20:12 +00:00
Sergey Biryukov
1d738052b1 Editor: Update packages. 
The following package versions were changed:

@wordpress/block-directory: 1.17.2 -> 1.17.3
@wordpress/block-editor: 5.1.2 -> 5.1.3
@wordpress/block-library: 2.26.2 -> 2.26.3
@wordpress/edit-post: 3.25.2 -> 3.25.3
@wordpress/editor: 9.24.2 -> 9.24.3
@wordpress/format-library: 1.25.2 -> 1.25.3
@wordpress/reusable-blocks: 1.0.2 -> 1.0.3

See https://github.com/WordPress/gutenberg/pull/26874 for the list of fixed bugs.

Props isabel_brison.
Fixes #51696.
Built from https://develop.svn.wordpress.org/trunk@49579


git-svn-id: http://core.svn.wordpress.org/trunk@49317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 19:36:36 +00:00
desrosj
6703f8efee Twenty Twenty-One: Use consistent casing in strings. 
This converts strings using Title Case to sentence case, which is currently preferred for consistency (see discussions on #40244).

Also included is the replacement of an escaped apostrophe with `’`, which is also preferred per the Internationalization guidelines.

See #51526.
Built from https://develop.svn.wordpress.org/trunk@49578


git-svn-id: http://core.svn.wordpress.org/trunk@49316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 19:30:11 +00:00
desrosj
5de5b186f3 Twenty Twenty-One: Ignore the node_modules folder in SVN. 
[49576] mistakenly partially reverted [49250].

See #51526.
Built from https://develop.svn.wordpress.org/trunk@49577


git-svn-id: http://core.svn.wordpress.org/trunk@49315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 19:07:10 +00:00
desrosj
d23292b3c0 Twenty Twenty-One: Ignore .css.map files. 
These are generated when Sass is compiled, but should never be committed.

See #51526.
Built from https://develop.svn.wordpress.org/trunk@49576


git-svn-id: http://core.svn.wordpress.org/trunk@49314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 19:00:10 +00:00
desrosj
ee888ad547 Twenty Twenty-One: Convert inline ESLint comments to JSHint. 
WordPress Core currently uses JSHint instead of ESlint.

See #51526.
Built from https://develop.svn.wordpress.org/trunk@49575


git-svn-id: http://core.svn.wordpress.org/trunk@49313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 18:48:08 +00:00
desrosj
967d29d83d Twenty Twenty-One: Merge the latest changes changes from GitHub for Beta 4. 
In addition to syncing the latest changes, this change also merges the theme’s `.scss` files and other related build tool configurations required to compile the theme’s CSS.

This will allow development of the theme to continue on Trac after 5.6 is released and the GitHub repository is archived.

For a full list of changes since [], see e7d5991...aa284fd.

Props poena, luminuu kjellr, aristath, justinahinon.
See #51526.
Built from https://develop.svn.wordpress.org/trunk@49574


git-svn-id: http://core.svn.wordpress.org/trunk@49312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 18:36:15 +00:00
TimothyBlynJacobs
5ee48d6915 App Passwords: MOAR accessibility improvements. 
Corrects the "Application Name" field's aria-describedby attribute and makes the description visible.

Props alexstine, SergeyBiryukov.
Fixes #51580.

Built from https://develop.svn.wordpress.org/trunk@49573


git-svn-id: http://core.svn.wordpress.org/trunk@49311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 18:14:08 +00:00
Sergey Biryukov
d772517fcc Database: Clean up the post_category column removed from DB schema for new installations in WordPress 2.8. 
Its presence may conflict with `WP_Post::__get()`, which should generally fill the non-existent `post_category` property, but is not triggered if the column exists in the database.

Follow-up to [10895].

Props leogermani, davidbaumwald, hellofromTonya.
Fixes #51288.
Built from https://develop.svn.wordpress.org/trunk@49572


git-svn-id: http://core.svn.wordpress.org/trunk@49310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 17:55:11 +00:00
Sergey Biryukov
250d0660b2 Build/Test Tools: Only enforce PHP extension requirements when running core tests. 
This allows other users of the WordPress unit test suite framework to run their own unit tests without needing the GD extension, which should only be a requirement if running core tests.

Follow-up to [49535].

Props jamescollins.
Fixes #50640.
Built from https://develop.svn.wordpress.org/trunk@49571


git-svn-id: http://core.svn.wordpress.org/trunk@49309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 17:25:13 +00:00
Sergey Biryukov
8e58e38ef9 Build/Tests Tools: Restore [49491], accidentally reverted in [49566]. 
See #39210.
Built from https://develop.svn.wordpress.org/trunk@49570


git-svn-id: http://core.svn.wordpress.org/trunk@49308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 17:15:08 +00:00
Sergey Biryukov
6ac50d705c Build/Tests Tools: Restore [49535], accidentally reverted in [49566]. 
See #39210.
Built from https://develop.svn.wordpress.org/trunk@49569


git-svn-id: http://core.svn.wordpress.org/trunk@49307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 17:08:11 +00:00
antpb
522a7a5d40 Media: Allow users to switch from media grid to list mode in media library. 
Fixes issue where media modal would open when switching from grid to list mode.

Props mista-flo, mukesh27.

Fixes #51396.

Built from https://develop.svn.wordpress.org/trunk@49568


git-svn-id: http://core.svn.wordpress.org/trunk@49306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 15:46:07 +00:00
antpb
8efbef867c Media: Improve count in Media Library pagination. 
Deleting all visible items on the last page of the media library previously left a blank page with no media items available. Using `wp_count_attachements` instead of `found_posts` solves the problem.

Props donsony, karmatosed, desrosj, mista-flo, justinahinon.

Fixes #39968.

Built from https://develop.svn.wordpress.org/trunk@49567


git-svn-id: http://core.svn.wordpress.org/trunk@49305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 15:40:09 +00:00
Dominik Schilling
abc9d961d5 I18N: Revert [49236] for now to investigate alternative implementations. 
See #39210, #51678, #26511.
Built from https://develop.svn.wordpress.org/trunk@49566


git-svn-id: http://core.svn.wordpress.org/trunk@49304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 14:43:09 +00:00
Sergey Biryukov
4446e597a7 Feeds: Register transient feed cache handler using the recommended method for SimplePie 1.3 or later. 
This fixes a "Non-static method cannot be called statically" fatal error when calling `fetch_feed()` on PHP 8.

Follow-up to [21644], [21652], [22366], [22599].

Props dd32, afragen, Senning, markoheijnen, ComputerGuru, useStrict, Ipstenu, nacin, l3rady, HoaSi, NathanAtmoz, fabifott, jfoulquier, thefarlilacfield, subscriptiongroup, rogerlos, Mte90, mopsyd, dossy, stulab, MadtownLems, roikles, justlevine, joostdevalk, OptimizingMatters, hellofromTonya, bph, ayeshrajans, SergeyBiryukov.
Fixes #29204.
Built from https://develop.svn.wordpress.org/trunk@49565


git-svn-id: http://core.svn.wordpress.org/trunk@49303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 14:36:10 +00:00
Sergey Biryukov
9c6f41419c Coding Standards: Pass an empty string instead of null as the $replacement parameter to _deprecated_file(). 
Follow-up to [48327].

See #50767.
Built from https://develop.svn.wordpress.org/trunk@49564


git-svn-id: http://core.svn.wordpress.org/trunk@49302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 11:17:07 +00:00
Peter Wilson
5da8c0fceb Canonical: Prevent ID enumeration of private post slugs. 
Add check to `redirect_canonical()` to ensure the destination post is not using a private post status.

Props dd32, Denis-de-Bernardy, donmhico, helen, nacin, peterwilsoncc, pishmishy, TimothyBlynJacobs, tzafrir, Viper007Bond, whyisjake.
Fixes #5272.


Built from https://develop.svn.wordpress.org/trunk@49563


git-svn-id: http://core.svn.wordpress.org/trunk@49301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-12 04:16:08 +00:00
Sergey Biryukov
3a1265e188 I18N: Add trailing punctuation to some translator comments. 
Follow-up to [49549].

See #51580.
Built from https://develop.svn.wordpress.org/trunk@49562


git-svn-id: http://core.svn.wordpress.org/trunk@49300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-11 10:41:07 +00:00
Sergey Biryukov
9db9343826 Docs: Clarify sprintf() usage for the before_widget argument of register_sidebar(). 
Follow-up to [49203], [49560].

See #19709.
Built from https://develop.svn.wordpress.org/trunk@49561


git-svn-id: http://core.svn.wordpress.org/trunk@49299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-11 10:39:09 +00:00
Helen Hou-Sandí
19b035f04b Widgets: Do not use wrapping container in the admin. 
This is due to the new `before|after_sidebar` args, which are empty by default, but can introduce markup that causes admin JS to stop working.

Also adds documentation for the `sprintf()` on `before_sidebar`.

Props audrasjb, lpointet.
See #19709.

Built from https://develop.svn.wordpress.org/trunk@49560


git-svn-id: http://core.svn.wordpress.org/trunk@49298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-10 20:40:09 +00:00
Helen Hou-Sandí
135c75c396 Editor: Display short description from block directory in results. 
Props dd32, ryelle.
Fixes #51212.

Built from https://develop.svn.wordpress.org/trunk@49559


git-svn-id: http://core.svn.wordpress.org/trunk@49297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-10 20:26:08 +00:00
Sergey Biryukov
1f984603a2 Help/About: Add Site Health Status dashboard widget to the Help → Content tab. 
Reorder the items in the help tab to align with their default position on the Dashboard screen.

Follow-up to [47063], [47300].

Props nlpro.
Fixes #51745.
Built from https://develop.svn.wordpress.org/trunk@49558


git-svn-id: http://core.svn.wordpress.org/trunk@49296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-10 19:05:10 +00:00
Sergey Biryukov
e503ee45d6 TinyMCE: Update to 4.9.11. 
Changelog:
https://www.tiny.cloud/docs-4x/changelog/#version4911july132020
https://github.com/tinymce/tinymce/blob/4.x/changelog.txt

A full list of changes in this update can be found on GitHub:
https://github.com/tinymce/tinymce/compare/4.9.10...4.9.11

See #51051.
Built from https://develop.svn.wordpress.org/trunk@49557


git-svn-id: http://core.svn.wordpress.org/trunk@49295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-10 10:44:08 +00:00
Andrew Ozz
16458d8fd2 Tests QUnit: Remove restriction on running the TinyMCE Textpattern WP plugin tests in PhantomJS. 
Props @desrosj.
Fixes #42009.
Built from https://develop.svn.wordpress.org/trunk@49556


git-svn-id: http://core.svn.wordpress.org/trunk@49294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-10 09:18:10 +00:00
antpb
64beb3ee49 Media: Removes duplicate alignment fix for browser uploader. 
See #41648

Built from https://develop.svn.wordpress.org/trunk@49555


git-svn-id: http://core.svn.wordpress.org/trunk@49293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 23:43:07 +00:00
desrosj
964c353504 Tests: Remove duplicate fields key in WP_Query test. 
Introduced in [46188].

See #51344.
Built from https://develop.svn.wordpress.org/trunk@49554


git-svn-id: http://core.svn.wordpress.org/trunk@49292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 23:41:06 +00:00
antpb
4f2e88a574 Media: Adjusts alignment of file name text in browser uploader. 
Sets a defined size for text alongside the media browser uploader button fixing alignment on popular browsers.

Props krupajnanda, mikeschroder, aaroncampbell, lucagrandicelli, andraganescu, samful, sabernhardt, andystitt829, kburgoine.
Fixes #41648

Built from https://develop.svn.wordpress.org/trunk@49553


git-svn-id: http://core.svn.wordpress.org/trunk@49291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 23:34:09 +00:00
Helen Hou-Sandí
c57ce00691 Feeds: Don't treat media URLs with fragments as unique for enclosures. 
Props archduck, dshanske.
Fixes #47421.

Built from https://develop.svn.wordpress.org/trunk@49552


git-svn-id: http://core.svn.wordpress.org/trunk@49290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 20:28:07 +00:00
desrosj
8562263fd6 Build/Test Tools: Remove PHP >= 5.3 check. 
WordPress no longer supports PHP < 5.6.20. This check is no longer necessary.

Fixes #51737.
Built from https://develop.svn.wordpress.org/trunk@49551


git-svn-id: http://core.svn.wordpress.org/trunk@49289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 19:42:06 +00:00
antpb
9901c9a48d Media: Adjust box-sizing for audio players. 
Fix cropped container around playhead time in audio player.

Props ravipatel, sabernhardt, audrasjb, SergeyBiryukov, 
Fixes #51685

Built from https://develop.svn.wordpress.org/trunk@49550


git-svn-id: http://core.svn.wordpress.org/trunk@49288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 19:34:08 +00:00
TimothyBlynJacobs
74969e7fbe App Passwords: Further accessibility improvements. 
- Add a label to the readonly password input.
- Handle focus loss after revoking app passwords.
- Handle focus loss after dismissing notices.
- Mark app name as `aria-required`.
- Use `aria-label` for detailed revoke button text instead of `title`.
- Use `-1` for `tabindex` instead of `0`.

Props alexstine, afercia, sabernhardt, audrasjb, joedolson, TimothyBlynJacobs.
Fixes #51580.

Built from https://develop.svn.wordpress.org/trunk@49549


git-svn-id: http://core.svn.wordpress.org/trunk@49287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 18:05:08 +00:00
desrosj
4040866754 Build/Test Tools: Clean up the new contributor welcome message. 
Props ocean90, jeffpaul.
See #50401.
Built from https://develop.svn.wordpress.org/trunk@49548


git-svn-id: http://core.svn.wordpress.org/trunk@49286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 17:31:08 +00:00
Sergey Biryukov
8114076a50 Tests: Use assertSame() in some newly introduced tests. 
This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable.

Follow-up to [48937], [48939], [48940], [48944].

See #38266.
Built from https://develop.svn.wordpress.org/trunk@49547


git-svn-id: http://core.svn.wordpress.org/trunk@49285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 15:45:08 +00:00
Sergey Biryukov
5b62b44c15 Coding Standards: Use consistent formatting for error messages in WP_Image_Editor_Imagick::write_image() and ::strip_meta(). 
See #50767.
Built from https://develop.svn.wordpress.org/trunk@49546


git-svn-id: http://core.svn.wordpress.org/trunk@49284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 15:35:05 +00:00
Sergey Biryukov
3e3328a269 General: Set svn:eol-style for some new files in phpunit/includes. 
Follow-up to [48845], [49037], [49226], [49230].

See #51113.
Built from https://develop.svn.wordpress.org/trunk@49545


git-svn-id: http://core.svn.wordpress.org/trunk@49283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 15:25:08 +00:00
John Blackbourn
34765ddb64 Docs: Docblock corrections relating to WP_Post objects. 
See #51373, #50768

Built from https://develop.svn.wordpress.org/trunk@49544


git-svn-id: http://core.svn.wordpress.org/trunk@49282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 15:15:08 +00:00
Sergey Biryukov
847a2e22a0 Tests: Remove empty export directory. 
Follow-up to [30518], [31253], [34328].

See #51344.
Built from https://develop.svn.wordpress.org/trunk@49543


git-svn-id: http://core.svn.wordpress.org/trunk@49281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 15:11:08 +00:00
John Blackbourn
3688a9394e Media: Restore the ability of WP_Image_Editor_Imagick->save() to create a missing directory when needed. 
Props eemitch, mikeschroder, hellofromTonya, p00ya, johnbillion

Fixes #51665

Built from https://develop.svn.wordpress.org/trunk@49542


git-svn-id: http://core.svn.wordpress.org/trunk@49280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 13:18:04 +00:00
Sergey Biryukov
2d8633bf22 I18N: Merge duplicate "Column" strings, remove unnecessary context. 
Props ramiy, justinahinon, garrett-eclipse, audrasjb.
Fixes #47259.
Built from https://develop.svn.wordpress.org/trunk@49541


git-svn-id: http://core.svn.wordpress.org/trunk@49279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 11:17:07 +00:00
Sergey Biryukov
2c5607307f Coding Standards: Adjust formatting in WP_Block::render() for better readability. 
Follow-up to [49310], [49539].

See #51606.
Built from https://develop.svn.wordpress.org/trunk@49540


git-svn-id: http://core.svn.wordpress.org/trunk@49278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 11:01:05 +00:00
Sergey Biryukov
a2d42351c5 Text Changes: Unify various "Back to..." vs. "Return to..." vs. "Go to..." strings. 
Standardize on "Go to..." as a more appropriate option for most cases.

Props garrett-eclipse, kharisblank, audrasjb, ramiy, valentinbora.
Fixes #47235.
Built from https://develop.svn.wordpress.org/trunk@49539


git-svn-id: http://core.svn.wordpress.org/trunk@49277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-09 10:53:10 +00:00
Sergey Biryukov
4a18c93f42 Networks and Sites: Assign the array of site or network data returned from filters to the respective class property: 
* The array of network data returned from the `networks_pre_query` filter is assigned to the `networks` property of the current `WP_Network_Query` instance.
* The array of site data returned from the `sites_pre_query` filter is assigned to the `sites` property of the current `WP_Site_Query` instance.

This avoids the performance overhead of calling `WP_Network_Query::get_networks()` or `WP_Site_Query::get_sites()` twice: first when creating the object instance, then to retrieve the filtered results.

This also makes the filters a bit more consistent with other similar filters, e.g. `posts_pre_query`, `terms_pre_query`, `comments_pre_query`, or `users_pre_query`.

Follow-up to [46086], [48990].

Props yakimun, spacedmonkey.
Fixes #51333.
Built from https://develop.svn.wordpress.org/trunk@49538


git-svn-id: http://core.svn.wordpress.org/trunk@49276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-08 11:47:06 +00:00
Sergey Biryukov
5683c46277 Site Health: Validate the test result data format in JS before using it. 
This will discard any invalid responses instead of causing fatal errors.

It also makes badges optional, on the same basis as actions are optional. They are expected, but there may be situations where they are not present.

Props Clorith, dogwithblog, kraftbj, whyisjake, SergeyBiryukov.
Fixes #50145.
Built from https://develop.svn.wordpress.org/trunk@49537


git-svn-id: http://core.svn.wordpress.org/trunk@49275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-08 09:52:10 +00:00
Sergey Biryukov
c66edd0439 REST API: Use _n() in some error messages for proper plural forms support. 
Follow-up to [47923], [49053].

Props audrasjb, tobifjellner, TimothyBlynJacobs, SergeyBiryukov.
Fixes #51727.
Built from https://develop.svn.wordpress.org/trunk@49536


git-svn-id: http://core.svn.wordpress.org/trunk@49274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-07 21:59:11 +00:00
Sergey Biryukov
ec9b010cea Build/Test Tools: Check if all the required PHP extensions are loaded before running the test suite. 
Add the GD extension as a hard requirement.

This improves the reliability of the test suite and ensures that if the test infrastructure changes in the future and a platform requirement such as GD accidentally gets removed, the tests fail with an appropriate error message.

Follow-up to [48592].

Props ayeshrajans, jrf, johnbillion.
Fixes #50640.
Built from https://develop.svn.wordpress.org/trunk@49535


git-svn-id: http://core.svn.wordpress.org/trunk@49273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-07 13:20:07 +00:00
TimothyBlynJacobs
2559fb2a8d App Passwords: Bump database version to flush rewrite rules. 
Application Passwords introduced a new Rewrite Rule to handle the Authorization header on certain systems. This bumps the database version so the change is applied to sites upon upgrading to 5.6.

Fixes #51723.

Built from https://develop.svn.wordpress.org/trunk@49534


git-svn-id: http://core.svn.wordpress.org/trunk@49272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-06 22:15:09 +00:00
Sergey Biryukov
af95efdd34 Docs: Add a @see reference to esc_url() from esc_url_raw(). 
Follow-up to [49512].

See #50585.
Built from https://develop.svn.wordpress.org/trunk@49513


git-svn-id: http://core.svn.wordpress.org/trunk@49268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-06 14:16:07 +00:00
Sergey Biryukov
6dd28116a1 Docs: Improve return value description for esc_url(). 
Add a reference to `esc_url()` from `esc_url_raw()` return value description.

Props stevenlinx, audrasjb, helen.
Fixes #50585.
Built from https://develop.svn.wordpress.org/trunk@49512


git-svn-id: http://core.svn.wordpress.org/trunk@49267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-06 14:03:06 +00:00
Sergey Biryukov
3f7d705cfe Bundled Themes: Correct list block alignment in editor styles. 
Additionally:
* Indent nested lists in list and category blocks.
* Match ordered and unordered indentation for the classic block's lists.

This applies to:
* Twenty Ten
* Twenty Eleven
* Twenty Thirteen
* Twenty Fourteen
* Twenty Fifteen
* Twenty Sixteen
* Twenty Seventeen

Props sabernhardt, amolv, kjellr, audrasjb, francina.
Fixes #51157.
Built from https://develop.svn.wordpress.org/trunk@49511


git-svn-id: http://core.svn.wordpress.org/trunk@49266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-06 11:53:05 +00:00
Sergey Biryukov
a3faece50b Twenty Twenty: Correctly indent nested unordered lists in RTL editor styles. 
Props sabernhardt.
Fixes #51574.
Built from https://develop.svn.wordpress.org/trunk@49510


git-svn-id: http://core.svn.wordpress.org/trunk@49265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-06 11:38:09 +00:00
Sergey Biryukov
42b6ece059 Docs: Fix typo in a comment in Walker::display_element(). 
Props david.binda, sabernhardt.
Fixes #51713.
Built from https://develop.svn.wordpress.org/trunk@49509


git-svn-id: http://core.svn.wordpress.org/trunk@49264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-05 18:46:10 +00:00
Sergey Biryukov
3426581eaa Twenty Thirteen: Correct alignment of blocks inside a full-width or wide-width group block. 
Props sabernhardt.
Fixes #51440.
Built from https://develop.svn.wordpress.org/trunk@49508


git-svn-id: http://core.svn.wordpress.org/trunk@49263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-05 15:05:07 +00:00
Sergey Biryukov
eb6b93f327 Twenty Twenty: Correct heading blocks alignment in editor styles. 
This explicitly sets top and bottom margins instead of defining all four sides in shorthand notation.

Props sabernhardt, Lumne.
Fixes #51148.
Built from https://develop.svn.wordpress.org/trunk@49507


git-svn-id: http://core.svn.wordpress.org/trunk@49262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-05 15:02:10 +00:00
Sergey Biryukov
ee7ff18b54 Docs: Improve documentation for WP_Query::is_archive() per the documentation standards. 
Follow-up to [49504].

See #50545.
Built from https://develop.svn.wordpress.org/trunk@49506


git-svn-id: http://core.svn.wordpress.org/trunk@49261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-05 09:44:05 +00:00
Sergey Biryukov
f22633f20b Docs: Consistently place @see tags after @since in WP_Query methods, per the documentation standards. 
See #50768.
Built from https://develop.svn.wordpress.org/trunk@49505


git-svn-id: http://core.svn.wordpress.org/trunk@49260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-05 09:42:10 +00:00
Helen Hou-Sandí
1a2bdd7491 Improve documentation for is_archive(). 
Props stevenlinx.
Fixes #50545.

Built from https://develop.svn.wordpress.org/trunk@49504


git-svn-id: http://core.svn.wordpress.org/trunk@49259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-04 17:03:09 +00:00
Sergey Biryukov
87cdca8cd6 Docs: Change the @since entry for template and template_lock post type arguments to 5.0.0. 
These arguments were introduced with the initial block editor, but not documented previously.

Follow-up to [49495].

Props TimothyBlynJacobs.
See #46261.
Built from https://develop.svn.wordpress.org/trunk@49496


git-svn-id: http://core.svn.wordpress.org/trunk@49255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-04 02:47:05 +00:00
Sergey Biryukov
096323d8a5 Docs: Add documentation for the template_lock argument to register_post_type(). 
Add a `@since` entry for `template` and `template_lock` arguments.

Follow-up to [49041], [49492], [49494].

See #46261.
Built from https://develop.svn.wordpress.org/trunk@49495


git-svn-id: http://core.svn.wordpress.org/trunk@49254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-04 02:32:08 +00:00
Sergey Biryukov
ec60115f2a Docs: Adjust documentation for some WP_Post_Type properties: 
* Split the summary for `$template` per the documentation standards. The summary should be a single sentence.
* Change the type for `$template_lock` to `string|false`, to clarify that `true` is not supported.
* Fix typo in `$delete_with_user` description, adjust for better readability.

Follow-up to [49041], [49492].

See #46261.
Built from https://develop.svn.wordpress.org/trunk@49494


git-svn-id: http://core.svn.wordpress.org/trunk@49253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-04 02:30:09 +00:00
Sergey Biryukov
618fb979c6 Docs: Add a reference to wp_insert_post() for information on the arguments accepted by wp_update_post(). 
See #50768.
Built from https://develop.svn.wordpress.org/trunk@49493


git-svn-id: http://core.svn.wordpress.org/trunk@49252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-04 01:39:06 +00:00
noisysocks
4be65decb7 Editor: Add explicit template and template_lock attributes 
Add and document the template and template_lock attributes on WP_Post_Type that
are used by the block editor.

Props metalandcoffee.
See #46261.

Built from https://develop.svn.wordpress.org/trunk@49492


git-svn-id: http://core.svn.wordpress.org/trunk@49251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-04 01:05:10 +00:00
desrosj
107f669f15 Build/Test Tools: Disable update attempts while running unit tests. 
This fixes an issue introduced in [49369] that causes l10n related tests to fail when the PHPUnit test suite is run multiple times without hints of the site being under version control.

[49369] removed the `.git` folder from the ZIP artifact created during the initial setup job. This ZIP file is used by the later jobs in the workflow that run the test suite. The absence of the `.git` folder in these later jobs caused the language packs initially loaded from `phpunit/data/languages` folder to be updated asynchronously, resulting in unexpected values when running the tests a second time.

This change disables all Core auto-update and asynchronous language pack update attempts when running PHPUnit tests.

Props ocean90, SergeyBiryukov.
See #50401.
Fixes #51670.
Built from https://develop.svn.wordpress.org/trunk@49491


git-svn-id: http://core.svn.wordpress.org/trunk@49250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-03 21:09:08 +00:00
desrosj
5392af9208 Upgrade/Install: Change the notice displayed after saving auto-update settings to .notice-success. 
This better conveys the message of the notice and brings consistency with other success notices throughout Core.

Props audrasjb.
Fixes #51701.
Built from https://develop.svn.wordpress.org/trunk@49490


git-svn-id: http://core.svn.wordpress.org/trunk@49249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-03 17:55:06 +00:00
John Blackbourn
3cee52b362 Docs: Add more information about how to use filters that run before WordPress initialises. 
Fixes #50134

Built from https://develop.svn.wordpress.org/trunk@49489


git-svn-id: http://core.svn.wordpress.org/trunk@49248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-03 17:36:09 +00:00
John Blackbourn
238e69d9a6 Tests: Remove some useless assertions from the image editor tests. 
In each of these instances the variable being tested is a directly instantiated object and can never be a `WP_Error`, unlike when `wp_get_image_editor()` is used.

See #51344

Built from https://develop.svn.wordpress.org/trunk@49488


git-svn-id: http://core.svn.wordpress.org/trunk@49247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-03 15:52:11 +00:00
Sergey Biryukov
a940c08357 Docs: Document the $linkdata parameter of wp_insert_link() using hash notation. 
Props stevenlinx, peterwilsoncc.
Fixes #50853.
Built from https://develop.svn.wordpress.org/trunk@49487


git-svn-id: http://core.svn.wordpress.org/trunk@49246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-03 03:52:10 +00:00
Helen Hou-Sandí
3b64a19eeb Post-WordPress 5.6 Beta 3 version bump. 
Built from https://develop.svn.wordpress.org/trunk@49486


git-svn-id: http://core.svn.wordpress.org/trunk@49245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-02 21:22:04 +00:00
Helen Hou-Sandí
2f6286db83 WordPress 5.6 Beta 3. 
Built from https://develop.svn.wordpress.org/trunk@49485


git-svn-id: http://core.svn.wordpress.org/trunk@49244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-02 20:59:07 +00:00
Sergey Biryukov
1543954adc Docs: Update description for the $context parameter of sanitize_title() and sanitize_title_with_dashes(). 
This brings some consistency between the two DocBlocks and adjusts the latter one per the documentation standards.

Follow-up to [49482].

See #50569.
Built from https://develop.svn.wordpress.org/trunk@49484


git-svn-id: http://core.svn.wordpress.org/trunk@49243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-02 20:20:07 +00:00
Helen Hou-Sandí
a3581edd84 Upgrade/Install: Update help tab text to include major WordPress updates. 
Props audrasjb.
Fixes #51653.

Built from https://develop.svn.wordpress.org/trunk@49483


git-svn-id: http://core.svn.wordpress.org/trunk@49242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-02 20:16:06 +00:00
Helen Hou-Sandí
f2875b6f7c Formatting: Update docs for $context in sanitize_title_with_dashes(). 
Props stevenlinx, audrasjb.
Fixes #50569.

Built from https://develop.svn.wordpress.org/trunk@49482


git-svn-id: http://core.svn.wordpress.org/trunk@49241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-02 20:12:06 +00:00
desrosj
6a39c891b2 Customize: Ensure menu items expand horizontally on large screens. 
Props clorith, garrett-eclipse.
Fixes #51647.
Built from https://develop.svn.wordpress.org/trunk@49481


git-svn-id: http://core.svn.wordpress.org/trunk@49240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-02 20:07:05 +00:00
Helen Hou-Sandí
da4b76c6b3 Site Health: Site errors are for *this* site, not necessarily *your* site. 
Props techboyg5, Clorith, audrasjb.
Fixes #51524.

Built from https://develop.svn.wordpress.org/trunk@49480


git-svn-id: http://core.svn.wordpress.org/trunk@49239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-02 19:55:07 +00:00
Helen Hou-Sandí
be95ec2c27 About: Optimize freedoms sprite and add 2 column layout. 
Props garrett-eclipse, ryelle.
Fixes #46363.

Built from https://develop.svn.wordpress.org/trunk@49479


git-svn-id: http://core.svn.wordpress.org/trunk@49238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-02 19:46:14 +00:00
desrosj
e0669ddaae Bundled Themes: Sync Twenty Twenty-One with the latest changes from GitHub. 
For a full list of changes since [49330], see 5759e96...e7d5991.

Props poena, luminuu, ryelle, kjellr, aristath, justinahinon, felipeelia, joostdevalk.
See #51526.
Built from https://develop.svn.wordpress.org/trunk@49478


git-svn-id: http://core.svn.wordpress.org/trunk@49237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-02 19:45:07 +00:00
desrosj
e3a467a55a Upgrade/Install: Prevent removal of additional data from plugin update info. 
This switches to using `wp_parse_args()` instead of a combination of `array_merge()` and `array_intersect_key()` when ensuring that all expected default keys are present in the update information for a plugin.

This prevents non-default data returned by 3rd-party plugins from being unintentionally stripped out.

Props peterwilsoncc, chriscct7.
Fixes #51609.
Built from https://develop.svn.wordpress.org/trunk@49477


git-svn-id: http://core.svn.wordpress.org/trunk@49236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-02 19:13:07 +00:00
Helen Hou-Sandí
409bd27659 Remove accidentally duplicated code introduced in [49475]. 
See #46536.

Built from https://develop.svn.wordpress.org/trunk@49476


git-svn-id: http://core.svn.wordpress.org/trunk@49235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-02 19:09:09 +00:00
Helen Hou-Sandí
340c834fa3 Privacy: More precise checking of user request action names. 
Props garrett-eclipse.
Fixes #46536.

Built from https://develop.svn.wordpress.org/trunk@49475


git-svn-id: http://core.svn.wordpress.org/trunk@49234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-02 18:42:04 +00:00
Helen Hou-Sandí
cc74786052 General: Make some inline comments more descriptive. 
Props jorbin.
Fixes #51683.

Built from https://develop.svn.wordpress.org/trunk@49474


git-svn-id: http://core.svn.wordpress.org/trunk@49233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-02 18:04:07 +00:00
noisysocks
cfa1fb8c83 Editor: Update packages 
@wordpress/block-directory@1.17.2
@wordpress/block-editor@5.1.2
@wordpress/block-library@2.26.2
@wordpress/edit-post@3.25.2
@wordpress/editor@9.24.2
@wordpress/format-library@1.25.2
@wordpress/reusable-blocks@1.0.2

Props isabel_brison.
See #51696.

Built from https://develop.svn.wordpress.org/trunk@49473


git-svn-id: http://core.svn.wordpress.org/trunk@49232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-02 04:56:37 +00:00
Sergey Biryukov
f39fc10544 Docs: Use a consistent plural form of "status". 
Props Collizo4sky, Presskopp, davidbaumwald.
Fixes #51690.
Built from https://develop.svn.wordpress.org/trunk@49472


git-svn-id: http://core.svn.wordpress.org/trunk@49231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-02 01:38:07 +00:00
Sergey Biryukov
89ce61835d Upgrade/Install: Switch "Check again" link on WordPress Updates screen to sentence case. 
This brings some consistency with other text links on the screen, e.g. "View version details" for plugins or themes.

Follow-up to [49150].

Props afercia.
See #51523.
Built from https://develop.svn.wordpress.org/trunk@49471


git-svn-id: http://core.svn.wordpress.org/trunk@49230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-11-02 01:17:09 +00:00
Sergey Biryukov
7941c32ad3 Twenty Sixteen: Ensure the <nav> elements in widgets do not affect bottom margin. 
Follow-up to [49208].

Props sabernhardt.
Fixes #51445.
Built from https://develop.svn.wordpress.org/trunk@49470


git-svn-id: http://core.svn.wordpress.org/trunk@49229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-31 02:56:05 +00:00
Sergey Biryukov
4091f41a07 Twenty Fifteen: Ensure the <nav> elements in widgets do not affect bottom margin. 
Follow-up to [49208].

Props sabernhardt.
See #51445.
Built from https://develop.svn.wordpress.org/trunk@49469


git-svn-id: http://core.svn.wordpress.org/trunk@49228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-31 02:54:11 +00:00
whyisjake
4b91d4e523 Upgrade/Install: During the install process, add additional checking for exising tables. 
If reinstalling WordPress, there is a condition where tables would exist in the database. Ensures that when that is the case, the install process can carry along without issue.

Fixes #51676.

Props xknown, garubi, mukesh27, desrosj, johnbillion, metalandcoffee, davidbaumwald, whyisjake.


Built from https://develop.svn.wordpress.org/trunk@49452


git-svn-id: http://core.svn.wordpress.org/trunk@49211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-30 17:52:07 +00:00
Peter Wilson
c8d5bc3c50 Taxonomy: Revert Light-weight/partial term counts. 
Partial revert of [49141], [49171], [49316].

All functional changes are removed, appropriate term counting unit tests are retained.

See #40351.

Built from https://develop.svn.wordpress.org/trunk@49451


git-svn-id: http://core.svn.wordpress.org/trunk@49210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-30 04:59:08 +00:00
Sergey Biryukov
812826a231 Tests: Remove the GLOB_BRACE flag for glob() function from unit tests. 
The flag was previously used in PDF preview tests when cleaning up temporary files.

As noted in the PHP documentation, the flag is not available on some non-GNU systems, like Solaris or Alpine Linux.

Follow-up to [40130].

Props amykamala, sawanoboly.
Fixes #51661.
Built from https://develop.svn.wordpress.org/trunk@49450


git-svn-id: http://core.svn.wordpress.org/trunk@49209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-30 02:03:07 +00:00
Adam Silverstein
25918dd10b Users: Password generation - restore "Cancel" aria label after r49248. 
Restore the "Cancel" button aria label to "Cancel password change" after it was inadvertently changed in r49248.

Props SergeyBiryukov.
Fixes #42852.


Built from https://develop.svn.wordpress.org/trunk@49392


git-svn-id: http://core.svn.wordpress.org/trunk@49151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-29 18:43:06 +00:00
Adam Silverstein
b8d1d01cc5 REST API: JS Client - improve collection route construction for empty parents. 
Fix an issue where the constructed path for hierarchical collections could contain a double slash ("//") when items contained empty parents, causing an error.

Props nicomollet.
Fixes #44745.

Built from https://develop.svn.wordpress.org/trunk@49390


git-svn-id: http://core.svn.wordpress.org/trunk@49149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-29 18:32:05 +00:00
desrosj
9c5173ffa6 Themes: Ensure that only privileged users can set a background image when a theme is using the deprecated custom background page. 
Props xknown, zieladam, peterwilsoncc, whyisjake.
Merges [49379] to trunk.
Built from https://develop.svn.wordpress.org/trunk@49388


git-svn-id: http://core.svn.wordpress.org/trunk@49147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-29 18:09:13 +00:00
desrosj
84a7bde414 Meta: Sanitize meta key before checking protection status. 
Props zieladam, peterwilsoncc, xknown, whyisjake.
Merges [49377,49381] to trunk.
Built from https://develop.svn.wordpress.org/trunk@49387


git-svn-id: http://core.svn.wordpress.org/trunk@49146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-29 18:08:06 +00:00
desrosj
a8e86c768c Upgrade/install: Improve logic check when determining installation status. 
Improve handling of ambiguous return values to determine if a blog is installed.

Props zieladam, xknown.
Merges [49377] to trunk.
Built from https://develop.svn.wordpress.org/trunk@49386


git-svn-id: http://core.svn.wordpress.org/trunk@49145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-29 18:06:13 +00:00
desrosj
d3ec258f91 XML-RPC: Return error message if attachment ID is incorrect. 
Throw an error for incorrect attachment IDs when requesting a media object to ensure return signature is correct and doesn't include incorrectly typed values within the object.

Props zieladam, peterwilsoncc, whyisjake.
Merges [49376] to trunk.
See #49905.
Built from https://develop.svn.wordpress.org/trunk@49385


git-svn-id: http://core.svn.wordpress.org/trunk@49144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-29 18:05:06 +00:00
desrosj
1050613168 Coding standards: Modify escaping functions to avoid potential false positives. 
Props xknown, zieladam, peterwilsoncc.
Merges [49375] to trunk.
Built from https://develop.svn.wordpress.org/trunk@49384


git-svn-id: http://core.svn.wordpress.org/trunk@49143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-29 18:03:11 +00:00
desrosj
025f5a62a2 Embeds: Disable embeds on deactivated Multisite sites. 
Props xknown, whyisjake, zieladam, peterwilsoncc.
Merges [49374] to trunk.
Built from https://develop.svn.wordpress.org/trunk@49383


git-svn-id: http://core.svn.wordpress.org/trunk@49142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-29 18:02:05 +00:00
desrosj
cad4a1a3d7 External Libraries: Disable deserialization in Requests_Utility_FilteredIterator 
Props xknown, peterwilsoncc, desrosj, dd32, whyisjake.
Merges [49373] to trunk.
Built from https://develop.svn.wordpress.org/trunk@49382


git-svn-id: http://core.svn.wordpress.org/trunk@49141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-29 18:00:08 +00:00
desrosj
fcc970a1cf XML-RPC: Improve error messages for unprivileged users. 
Add specific permission checks to avoid ambiguous failure messages.

Props zieladam, peterwilsoncc, xknown, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@49380


git-svn-id: http://core.svn.wordpress.org/trunk@49139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-29 17:44:07 +00:00
desrosj
019d838b6c Build/Test Tools: Avoid logging the same debug info twice in the PHPUnit workflow. 
Also includes some inline documentation fixes for workflow files.

See #50401.
Built from https://develop.svn.wordpress.org/trunk@49371


git-svn-id: http://core.svn.wordpress.org/trunk@49130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-29 01:48:04 +00:00
Sergey Biryukov
a9a1146a71 REST API: Remove accidentally duplicated key in test fixtures. 
Follow-up to [49334], [49368].

See #51638.
Built from https://develop.svn.wordpress.org/trunk@49370


git-svn-id: http://core.svn.wordpress.org/trunk@49129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-29 01:34:05 +00:00
desrosj
813fb756ae Build/Test Tools: Use install-changed to install NPM dependencies in GitHub Action workflows. 
The `install-changed` package records a hash of the `package.json` file locally in a text file and only runs `npm install` when there are changes to account for. 

This builds on [47497], which only hashes the `package.json` file after a Grunt task is called. By using `npx install-changed` within the workflow files, the package is hashed before the first Grunt task is run.

Props ocean90.
See #50401, #49594.
Built from https://develop.svn.wordpress.org/trunk@49369


git-svn-id: http://core.svn.wordpress.org/trunk@49128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-29 01:22:04 +00:00
Sergey Biryukov
36dcf727f4 REST API: Regenerate test fixtures after [49334]. 
Props garrett-eclipse.
Fixes #51638.
Built from https://develop.svn.wordpress.org/trunk@49368


git-svn-id: http://core.svn.wordpress.org/trunk@49127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-29 01:02:06 +00:00
Sergey Biryukov
bb0b36a905 Themes: Clarify the _doing_it_wrong() message for post formats in add_theme_support(). 
Follow-up to [49344], [49354], [49365].

See #51390.
Built from https://develop.svn.wordpress.org/trunk@49367


git-svn-id: http://core.svn.wordpress.org/trunk@49126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-29 00:08:06 +00:00
Sergey Biryukov
99e83a11d0 Tests: Correct post formats registration in WP_REST_Search_Controller tests. 
When declaring theme support for the `post-formats` feature, an array of supported post formats needs to be specified.

Follow-up to [49344], [49354].

Props garrett-eclipse.
Fixes #51390.
Built from https://develop.svn.wordpress.org/trunk@49365


git-svn-id: http://core.svn.wordpress.org/trunk@49125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-29 00:03:05 +00:00
desrosj
9b8fe28242 Build/Test Tools: Allow the desired version of PHPUnit to be passed to the local Docker environment. 
This reintroduces [49358] with a modification to the `.travis.yml` file to avoid an issue with `dotenv-expand` being unable to expand variables into `process.env` only on Travis.

The `LOCAL_PHPUNIT` environment variabl allows the desired version of PHPUnit to be specified when running the PHP tests within the local Docker environment.

Because support for newer versions of PHPUnit is not backported, some versions of PHP need the ability to run multiple versions of PHPUnit for different branches. This adds the flexibility needed to use the Docker environment within those older branches to run the PHP tests.

Props johnbillion, SergeyBiryukov.
See #50042.
Built from https://develop.svn.wordpress.org/trunk@49362


git-svn-id: http://core.svn.wordpress.org/trunk@49122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-28 23:17:23 +00:00
desrosj
76f6f20d41 Build/Test Tools: Revert [49358] to investigate failures. 
Unprops desrosj.
See #50042.
Built from https://develop.svn.wordpress.org/trunk@49360


git-svn-id: http://core.svn.wordpress.org/trunk@49120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-28 19:44:21 +00:00
whyisjake
dbae445997 Embeds: Remove Facebook and Instagram as an oEmbed Source 
Facebook has depracated all non-authenticated endpoints for Facebook and Instagram. 

See: https://developers.facebook.com/docs/plugins/oembed-legacy
See also: https://make.wordpress.org/core/2020/09/22/facebook-and-instagram-embeds-to-be-deprecated-october-24th/

With this change, endpoints are being removed. If a site is dependent on this feature, they need to pass either an app or client token. There are a few plugins that add this functionality.

Fixes #50861.
Props johnbillion, joyously, mkaz, dimadin, ayeshrajans, davisshaver, paaljoachim, Clorith, bridgetwillard, jb510, sippis, Clorith, TimothyBlynJacobs, desrosj, smub, audrasjb, whyisjake.

Built from https://develop.svn.wordpress.org/trunk@49359


git-svn-id: http://core.svn.wordpress.org/trunk@49119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-28 19:11:06 +00:00
desrosj
41d5f153c5 Build/Test Tools: Allow the desired version of PHPUnit to be passed to the local Docker environment. 
This change introduces the `LOCAL_PHPUNIT` environment variable that allows the desired version of PHPUnit to be specified when running the PHP tests within the local Docker environment.

Because support for newer versions of PHPUnit is not backported, some versions of PHP need the ability to run multiple versions of PHPUnit for different branches. This adds the flexibility needed to use the Docker environment within those older branches to run the PHP tests.

Props johnbillion.
Fixes #50042.
Built from https://develop.svn.wordpress.org/trunk@49358


git-svn-id: http://core.svn.wordpress.org/trunk@49118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-28 19:03:25 +00:00
John Blackbourn
1aafbf6c6f Cron API: Improve the inline documentation for the args passed to the cron event scheduling functions. 
Props chadreitsma, peterwilsoncc

Fixes #51605

Built from https://develop.svn.wordpress.org/trunk@49357


git-svn-id: http://core.svn.wordpress.org/trunk@49117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-28 18:37:07 +00:00
Sergey Biryukov
e569358678 General: Ensure that filtered arguments in get_search_form() contain all required default values. 
Props kellybleck, davidbaumwald, whyisjake, SergeyBiryukov.
Fixes #51645.
Built from https://develop.svn.wordpress.org/trunk@49355


git-svn-id: http://core.svn.wordpress.org/trunk@49115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-28 16:57:08 +00:00
Sergey Biryukov
d0268b2b69 Themes: Move the test for post-formats theme support to a more appropriate place. 
Follow-up to [49344].

See #51390.
Built from https://develop.svn.wordpress.org/trunk@49354


git-svn-id: http://core.svn.wordpress.org/trunk@49114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-28 15:14:10 +00:00
Sergey Biryukov
e37d1acc1c Customize: Update parameter name in api.Class.extend(). 
This makes the name consistent with the documentation and the `inherits()` function signature.

Props ribaricplusplus, davidbaumwald.
Fixes #51652.
Built from https://develop.svn.wordpress.org/trunk@49353


git-svn-id: http://core.svn.wordpress.org/trunk@49113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-28 00:45:06 +00:00
Helen Hou-Sandí
a33d6305d1 Twenty Twenty: Correct some textdomains in block patterns. 
Props justinahinon.
Fixes #51648. See #51098.

Built from https://develop.svn.wordpress.org/trunk@49352


git-svn-id: http://core.svn.wordpress.org/trunk@49112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-27 22:14:05 +00:00
Helen Hou-Sandí
4ca6722c41 Post WordPress 5.6 beta 2 version bump. 
Built from https://develop.svn.wordpress.org/trunk@49351


git-svn-id: http://core.svn.wordpress.org/trunk@49111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-27 22:02:08 +00:00
Helen Hou-Sandí
21f3cc781e WordPress 5.6 Beta 2. 
Built from https://develop.svn.wordpress.org/trunk@49350


git-svn-id: http://core.svn.wordpress.org/trunk@49110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-27 21:42:07 +00:00
Helen Hou-Sandí
14558efa83 PHPCS fixes after [49347]. 
See #51098.

Built from https://develop.svn.wordpress.org/trunk@49349


git-svn-id: http://core.svn.wordpress.org/trunk@49109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-27 21:23:07 +00:00
Helen Hou-Sandí
bf02276a17 Bundled Themes: Introduce block patterns for Twenty Nineteen. 
Including some props I missed on the commit for Twenty Twenty, I am sorry.

Props: kjellr, beafialho, melchoyce, ryelle, jffng, bridgetwillard.
Fixes #51099.

Built from https://develop.svn.wordpress.org/trunk@49348


git-svn-id: http://core.svn.wordpress.org/trunk@49108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-27 21:15:12 +00:00
Helen Hou-Sandí
6d3300b437 Bundled Themes: Introduce block patterns for Twenty Twenty. 
Props melchoyce, Anlino, kjellr, ryelle.
Fixes #51098.

Built from https://develop.svn.wordpress.org/trunk@49347


git-svn-id: http://core.svn.wordpress.org/trunk@49107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-27 21:01:07 +00:00
Helen Hou-Sandí
9241624e6c Menus: Better responsive display for accordion items. 
This only applies to the standalone menu screen; fixes for the customizer will be handled separately.

Props audrasjb, garrett-eclipse.
See #49375.

Built from https://develop.svn.wordpress.org/trunk@49346


git-svn-id: http://core.svn.wordpress.org/trunk@49106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-27 20:18:06 +00:00
Sergey Biryukov
a6db16fad0 Upgrade/Install: Adjust a string in core_auto_updates_settings() for consistency. 
Props audrasjb, desrosj.
See #50907.
Built from https://develop.svn.wordpress.org/trunk@49345


git-svn-id: http://core.svn.wordpress.org/trunk@49105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-27 20:12:06 +00:00
Helen Hou-Sandí
3fc623c202 Post Formats: You have to pass an array of supported post formats. 
This shows a `_doing_it_wrong()` message and also returns false instead of true if no array of formats is passed in `add_theme_support()`, avoiding a PHP error.

Post formats maintainership comes full circle. 🙃

Props Mista-Flo, sproutchris, garrett-eclipse.
Fixes #51390.

Built from https://develop.svn.wordpress.org/trunk@49344


git-svn-id: http://core.svn.wordpress.org/trunk@49104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-27 20:00:06 +00:00
Helen Hou-Sandí
7636806a52 Media: Fix styling for MediaElement player in media modal. 
Fixes #43640.

Built from https://develop.svn.wordpress.org/trunk@49343


git-svn-id: http://core.svn.wordpress.org/trunk@49103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-27 19:40:04 +00:00
Helen Hou-Sandí
cbc1404589 External Libraries: Update jQuery Migrate to 3.3.2-pre. 
This is a prerelease version to avoid some errors in 5.6 beta 2. We need to be sure that we ship with a released version by 5.6 RC.

Props mweichert.
Fixes #51621. See #50564.

Built from https://develop.svn.wordpress.org/trunk@49338


git-svn-id: http://core.svn.wordpress.org/trunk@49099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-27 18:59:08 +00:00
Helen Hou-Sandí
85e954aa37 Login: Avoid AJAX error on login screen. 
This has to do with the password generator, which does not need to generate and cache passwords in JS as that's already done in PHP.

Props adamsilverstein, sarahricker.
Fixes #51613.

Built from https://develop.svn.wordpress.org/trunk@49337


git-svn-id: http://core.svn.wordpress.org/trunk@49098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-27 18:43:07 +00:00
Sergey Biryukov
769b29f962 Build/Test Tools: Add Authorization headers support to local-env. 
This ensures that basic authorization is passed from nginx to PHP.

Props Clorith.
Fixes #51646.
Built from https://develop.svn.wordpress.org/trunk@49336


git-svn-id: http://core.svn.wordpress.org/trunk@49097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-27 18:35:12 +00:00
desrosj
1dcdd946c6 Build/Test Tools: Specify a type when using wp config set. 
This prevents an error if constants are not predefined when running the Docker install script while using older combinations of WordPress/PHP/WP-CLI.

See #48301.
Built from https://develop.svn.wordpress.org/trunk@49335


git-svn-id: http://core.svn.wordpress.org/trunk@49096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-27 18:34:06 +00:00
TimothyBlynJacobs
2df94804d4 Site Health, App Passwords: Test if the Authorization header is populated correctly. 
App Passwords rely on the Authorization header to transport the Basic Auth credentials. For Apache web servers, WordPress automatically includes a RewriteRule to populate the value for servers running in CGI or FastCGI that wouldn't ordinarily populate the value. 

This tests if the header is being filled with the expected values. For Apache users, we direct the user to visit the Permalinks settings to flush their permalinks. For all other users, we direct them to a help document on developer.wordpress.org.

Props Clorith, marybaum, TimothyBlynJacobs.
Fixes #51638.

Built from https://develop.svn.wordpress.org/trunk@49334


git-svn-id: http://core.svn.wordpress.org/trunk@49095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-27 18:32:07 +00:00
Helen Hou-Sandí
219079f7a3 Privacy: Show failures before successes for all bulk actions. 
Props garrett-eclipse.
See #44081, [49331].

Built from https://develop.svn.wordpress.org/trunk@49333


git-svn-id: http://core.svn.wordpress.org/trunk@49094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-27 18:19:06 +00:00
Helen Hou-Sandí
f4f72498c0 Privacy: Show notices for both failed and successful bulk actions. 
Props javorszky, garrett-eclipse, hellofromTonya.
Fixes #44081.

Built from https://develop.svn.wordpress.org/trunk@49331


git-svn-id: http://core.svn.wordpress.org/trunk@49092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-27 17:47:08 +00:00
desrosj
24f6f56a71 Twenty Twenty-One: Import the latest changes. 
For a full list of changes since [49320], see 461dcf9cd...5759e96.

Props poena, melchoyce, aristath, justinahinon, ryelle.
See #51526.
Built from https://develop.svn.wordpress.org/trunk@49330


git-svn-id: http://core.svn.wordpress.org/trunk@49091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-27 17:07:05 +00:00
TimothyBlynJacobs
5df8bf60aa REST API: Support a broader range of JSON media types. 
Previously, we only supported `application/json` which prevented using subtypes like `application/activity+json`. This allows for the REST API to `json_decode` the body of requests using a JSON subtype `Content-Type`. Additionally, `wp_die()` now properly sends the error as JSON when a JSON subtype is specified in the `Accept` header.

Props pfefferle.
Fixes #49404.

Built from https://develop.svn.wordpress.org/trunk@49329


git-svn-id: http://core.svn.wordpress.org/trunk@49090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-27 16:44:06 +00:00
Sergey Biryukov
72cff29cb6 Posts, Post Types: Check if taxonomy is set for the tax_input parameter of wp_insert_post(). 
This avoids a PHP notice when creating a post with multiple taxonomies both having a default term.

Props yakimun, szaqal21, hareesh-pillai, audrasjb.
Fixes #51320.
Built from https://develop.svn.wordpress.org/trunk@49328


git-svn-id: http://core.svn.wordpress.org/trunk@49089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-27 16:42:05 +00:00
Sergey Biryukov
0a4f041f2a Tests: Rename some files and classes in phpunit/tests/post/ per the naming conventions. 
https://make.wordpress.org/core/handbook/testing/automated-testing/writing-phpunit-tests/#naming-and-organization

Follow-up to [47780].

See #51344.
Built from https://develop.svn.wordpress.org/trunk@49327


git-svn-id: http://core.svn.wordpress.org/trunk@49088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-27 16:09:07 +00:00
Sergey Biryukov
919f1cf461 Docs: Fix typo in {$old_status}_to_{$new_status} hook description. 
See #50768.
Built from https://develop.svn.wordpress.org/trunk@49326


git-svn-id: http://core.svn.wordpress.org/trunk@49087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-27 15:42:09 +00:00
Andrew Ozz
7c32cbf990 Revert the improvenents to arranging of postboxes/metaboxes, [49179]. The current patch fixes about half a dozen problems, but seems more general improvements are needed to how Screen Options work. 
See #50699.
Built from https://develop.svn.wordpress.org/trunk@49325


git-svn-id: http://core.svn.wordpress.org/trunk@49086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-27 10:47:12 +00:00
youknowriad
3c554f366d Block Editor: Update the WordPress packages for 5.6 beta 2 
It contains:

- Fix drop zone indicators for non blocks.
- Fix archives block render function.
- Code block: preserve indentation on paste.
- Turn off autocomplete for token input. 
- Fix parent post selector: ensure initial value available, search performed, all results shown. 
- Fix gallery block undo issue.

Props isabel_brison.
Fixes #51640.

Built from https://develop.svn.wordpress.org/trunk@49324


git-svn-id: http://core.svn.wordpress.org/trunk@49085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-27 09:34:46 +00:00
Sergey Biryukov
18ee84c5c2 Customize: Ensure the New Menu section is properly rendered. 
Follow-up to [30102], [49101].

Props david.binda, boldgrid, dlh, azaozz, Clorith, westonruter, hellofromTonya.
Fixes #51592.
Built from https://develop.svn.wordpress.org/trunk@49323


git-svn-id: http://core.svn.wordpress.org/trunk@49084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-27 02:48:06 +00:00
Sergey Biryukov
6275885400 Bundled Themes: Update latest version for Tested up to: in readme.txt files. 
Props mukesh27.
Fixes #51501.
Built from https://develop.svn.wordpress.org/trunk@49322


git-svn-id: http://core.svn.wordpress.org/trunk@49083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-27 02:18:05 +00:00
Sergey Biryukov
0fb5ccd4d0 Docs: Add a @global tag for $user_id in WP_Application_Passwords_List_Table::prepare_items(). 
Props mukesh27.
Fixes #51633.
Built from https://develop.svn.wordpress.org/trunk@49321


git-svn-id: http://core.svn.wordpress.org/trunk@49082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-27 02:12:06 +00:00
desrosj
87b6c253b5 Twenty Twenty-One: Import the latest changes for 5.6 beta 2. 
For a full list of changes since beta 1, see 9e34dca...e580895.

Props poena, melchoyce, luminuu, aristath, justinahinon, jffng, ryelle, kishanjasani, rolfsiebers.
See #51526.
Built from https://develop.svn.wordpress.org/trunk@49320


git-svn-id: http://core.svn.wordpress.org/trunk@49081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-27 02:00:07 +00:00
Helen Hou-Sandí
8b3071bc1a Administration: Accommodate long translations for "Posts" in list table headers. 
This stems from longer translations on the User table, but this will apply to any posts column in a list table. Hyphenation should typically just apply to the column header, as the cell contents are just a count.

This does appear to have some browser inconsistencies, so may need further adjustment in the future.

Props audrasjb, justinahinon.
Fixes #50838.

Built from https://develop.svn.wordpress.org/trunk@49317


git-svn-id: http://core.svn.wordpress.org/trunk@49079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-26 23:16:05 +00:00
Peter Wilson
6c92704e10 Taxonomy: Fix values passed to actions in wp_modify_term_count_by_now(). 
Replace the `WP_Taxonomy` object with the taxonomy slug in the values passed to the actions `edit_term_taxonomy` and `edited_term_taxonomy` within `wp_modify_term_count_by_now()`.

Follow up to [49141], [49171].
Props Chouby, lcyh78.
Fixes #40351.


Built from https://develop.svn.wordpress.org/trunk@49316


git-svn-id: http://core.svn.wordpress.org/trunk@49078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-26 23:07:06 +00:00
Sergey Biryukov
1ce2f12eaf Docs: Correct description for wp_pre_insert_user_data filter. 
Props audrasjb.
Fixes #51637.
Built from https://develop.svn.wordpress.org/trunk@49314


git-svn-id: http://core.svn.wordpress.org/trunk@49076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-26 22:53:06 +00:00
Sergey Biryukov
cc7ba27c37 Docs: Correct DocBlock formatting for render_block(). 
Follow-up to [49310].

See #51606.
Built from https://develop.svn.wordpress.org/trunk@49312


git-svn-id: http://core.svn.wordpress.org/trunk@49074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-26 21:55:10 +00:00
Sergey Biryukov
483b75e682 Docs: Add missing @since tags for properties in some block editor classes: 
* `WP_Block_Pattern_Categories_Registry`
* `WP_Block_Patterns_Registry`
* `WP_Block_Supports`

Follow-up to [48156], [49226].

See #50768.
Built from https://develop.svn.wordpress.org/trunk@49311


git-svn-id: http://core.svn.wordpress.org/trunk@49073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-26 21:51:08 +00:00
youknowriad
bf5917edf3 Block Editor: Fix WP_Block_Supports class compatibility with Gutenberg-provided class. 
When using WordPress trunk with Gutenberg master, there's an incompatibility causing 
the dynamic block generated classes to be omitted.
This commit refactors the block supports to fix that problem.

Props nosolosw.
Fixes #51606.

Built from https://develop.svn.wordpress.org/trunk@49310


git-svn-id: http://core.svn.wordpress.org/trunk@49072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-26 08:31:11 +00:00
Sergey Biryukov
4bb4107f50 General: Use correct value for the speak property in various CSS files. 
Follow-up to [49263].

Props hareesh-pillai.
Fixes #51622.
Built from https://develop.svn.wordpress.org/trunk@49309


git-svn-id: http://core.svn.wordpress.org/trunk@49071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-26 02:25:09 +00:00
TimothyBlynJacobs
367c97df67 REST API: Prevent PHP warning when metadata schema is missing properties. 
This switches to the new `rest_default_additional_properties_to_false()` function which doesn't have this issue and deprecates the `WP_REST_Meta_Fields::default_additional_properties_to_false()` method.

Props austin880625.
Fixes #51389.

Built from https://develop.svn.wordpress.org/trunk@49308


git-svn-id: http://core.svn.wordpress.org/trunk@49070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-25 20:30:08 +00:00
TimothyBlynJacobs
5f5457dff2 Build Tools: Fix running installing composer dependencies using composer 2.0. 
This updates the `dealerdirect/phpcodesniffer-composer-installer` package to allow installing version `0.7.0` which supports composer 2.0.

Props itowhid06, jrf.
Fixes #51624.

Built from https://develop.svn.wordpress.org/trunk@49306


git-svn-id: http://core.svn.wordpress.org/trunk@49068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-25 01:14:07 +00:00
Sergey Biryukov
7b2c3a006e Tests: Correct newly introduced @covers tags. 
When global functions are covered, they need to be prefixed with `::` (double colon) to distinguish them from class name.

See https://phpunit.readthedocs.io/en/7.0/annotations.html#covers for more details.

Follow-up to [49000], [49171].

Props jrf.
See #39265.
Built from https://develop.svn.wordpress.org/trunk@49305


git-svn-id: http://core.svn.wordpress.org/trunk@49067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-25 00:33:04 +00:00
Sergey Biryukov
5770b676b0 Docs: Correct an example in wp_kses_normalize_entities() description. 
Props ediamin.
Fixes #51620.
Built from https://develop.svn.wordpress.org/trunk@49304


git-svn-id: http://core.svn.wordpress.org/trunk@49066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-25 00:14:05 +00:00
TimothyBlynJacobs
19c72d58e7 REST API, XML-RPC: Synchronise empty comment content checks. 
The REST API and XML-RPC now uses the same detection methodology for empty comment content as `wp_handle_comment_submission()`. Specifically, comments now have their content trimmed and '0' is allowed.

Props jaswrks, rmccue, dd32, rachelbaker, Cawa-93, aduth, TimothyBlynJacobs.
Fixes #43177.

Built from https://develop.svn.wordpress.org/trunk@49303


git-svn-id: http://core.svn.wordpress.org/trunk@49065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-24 22:46:09 +00:00
TimothyBlynJacobs
36c4c943ba REST API: Don't validate status if it hasn't changed. 
In particular, this allows for sending `status=inherit` to an attachment if it's current status is `inherit`. This status would be rejected because it is an "internal" post status which isn't exposed.

As a general rule, a developer should always be able to PUT back a GET response without error.

Props dfenton, pputzer, TimothyBlynJacobs.
Fixes #40399.


Built from https://develop.svn.wordpress.org/trunk@49302


git-svn-id: http://core.svn.wordpress.org/trunk@49064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-24 16:04:05 +00:00
TimothyBlynJacobs
abbc108d19 REST API: Make template handling resilient against plugins setting the global post. 
Plugins shouldn't be setting the global post object during a REST API request, but if they did this could cause unexpected errors when creating a post with a template.

Props Kipperlenny, TimothyBlynJacobs.
Fixes #49695.

Built from https://develop.svn.wordpress.org/trunk@49301


git-svn-id: http://core.svn.wordpress.org/trunk@49063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-24 14:12:05 +00:00
TimothyBlynJacobs
3a01517c90 REST API: Reuse namespace property instead of the undeclared rest_namespace. 
Props itowhid06.
Fixes #48297.

Built from https://develop.svn.wordpress.org/trunk@49300


git-svn-id: http://core.svn.wordpress.org/trunk@49062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-24 13:54:06 +00:00
TimothyBlynJacobs
9baba12f00 REST API: Support generating comment up links to custom posts controllers. 
The comments controller now uses the `rest_get_route_for_post` function introduced in WordPress 5.5 to generate the link. This function is filterable to allow for custom controllers to properly define their REST API route.

Props dsifford, TimothyBlynJacobs.
Fixes #44152.

Built from https://develop.svn.wordpress.org/trunk@49299


git-svn-id: http://core.svn.wordpress.org/trunk@49061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-24 13:20:07 +00:00
Sergey Biryukov
4d695ba6b3 Coding Standards: Remove unused $current_role variable from Add New User form. 
Follow-up to [9614], [28296].

Props ravipatel.
Fixes #51619.
Built from https://develop.svn.wordpress.org/trunk@49298


git-svn-id: http://core.svn.wordpress.org/trunk@49060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-24 12:49:05 +00:00
Sergey Biryukov
10091823f1 Coding Standards: Use consistent formatting for <div class="wrap"> sections in wp-admin/update-core.php. 
Follow-up to [28500], [28530].

Props ravipatel.
Fixes #51618.
Built from https://develop.svn.wordpress.org/trunk@49297


git-svn-id: http://core.svn.wordpress.org/trunk@49059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-24 12:33:07 +00:00
TimothyBlynJacobs
4aca25b296 REST API: Regenerate wp-api-generated.js after [49276]. 
See #51583.

Built from https://develop.svn.wordpress.org/trunk@49296


git-svn-id: http://core.svn.wordpress.org/trunk@49058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-24 04:29:10 +00:00
TimothyBlynJacobs
2d5d7a2aaa REST API: Deprecate WP_REST_Meta_Fields::register_field(). 
This method never worked properly and cannot be fixed due to incompatible method signatures.

Props flixos90, kadamwhite, jnylen0, TimothyBlynJacobs.
Fixes #39959.

Built from https://develop.svn.wordpress.org/trunk@49295


git-svn-id: http://core.svn.wordpress.org/trunk@49057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-24 04:27:09 +00:00
TimothyBlynJacobs
f6d39d1c51 App Passwords: Improve accessibility. 
- Make form inputs stacked instead of inline.
- Provide a visible label for the app name.
- Add screen reader text to dismiss button.
- Make "Revoke" button label more descriptive.
- Use aria-disabled instead of disabled to avoid focus loss.
- Display password in a readonly input to assist copy and paste.
- Remove large sections of italic text.
- Use `.form-wrap` and `.form-field` to give consistent form styling.
- Improve labeling and placeholder text.

Props alexstine, georgestephanis, afercia, TimothyBlynJacobs.
Fixes #51580.

Built from https://develop.svn.wordpress.org/trunk@49294


git-svn-id: http://core.svn.wordpress.org/trunk@49056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-24 03:34:06 +00:00
Sergey Biryukov
d195b0dfbb Docs: Add missing duplicate hook references for allow_(dev|minor|major)_auto_core_updates filters. 
Follow-up to [49254].

See #50907.
Built from https://develop.svn.wordpress.org/trunk@49293


git-svn-id: http://core.svn.wordpress.org/trunk@49055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-24 00:31:05 +00:00
Sergey Biryukov
bb63c1cbd9 Upgrade/Install: Account for new WP_AUTO_UPDATE_CORE values in auto-updates settings form. 
This updates `core_auto_updates_settings()` to account for the new `beta` and `rc` values for the `WP_AUTO_UPDATE_CORE` constant.

Additionally, recognize these new values as acceptable in Site Health tests.

Follow-up to [48804], [49245], [49254].

Fixes #51319. See #50907.
Built from https://develop.svn.wordpress.org/trunk@49292


git-svn-id: http://core.svn.wordpress.org/trunk@49054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-24 00:26:05 +00:00
TimothyBlynJacobs
e992757e5b App Passwords: Include site_url in the success redirect payload. 
Props georgestephanis.
Fixes #51602.

Built from https://develop.svn.wordpress.org/trunk@49291


git-svn-id: http://core.svn.wordpress.org/trunk@49053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-24 00:07:08 +00:00
Sergey Biryukov
ce4b1cc8ba Toolbar: Keep IE 11 scrollbar on the side instead of overlapping the toolbar. 
Props sabernhardt, shital-patel, y_kolev.
Fixes #48545.
Built from https://develop.svn.wordpress.org/trunk@49290


git-svn-id: http://core.svn.wordpress.org/trunk@49052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-23 19:49:08 +00:00
Sergey Biryukov
ee3dac88f0 Privacy: Use more appropriate verbiage when downloading personal data export file from a row action. 
Props garrett-eclipse, bridgetwillard.
Fixes #49319.
Built from https://develop.svn.wordpress.org/trunk@49289


git-svn-id: http://core.svn.wordpress.org/trunk@49051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-23 19:33:07 +00:00
Sergey Biryukov
d9838eed62 Posts, Post Types: Set better default title for custom post types without title support. 
The default title is now set to "(no title supported)" instead of "Auto Draft".

Props garrett-eclipse, rajanit2000, bridgetwillard, donmhico, nrqsnchz.
Fixes #45516.
Built from https://develop.svn.wordpress.org/trunk@49288


git-svn-id: http://core.svn.wordpress.org/trunk@49050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-23 19:09:10 +00:00
Sergey Biryukov
36d58abc8e Help/About: Clarify that discouraging search engines does not prevent them from crawling the site. 
Props carike, garrett-eclipse, hellofromTonya.
Fixes #51274.
Built from https://develop.svn.wordpress.org/trunk@49287


git-svn-id: http://core.svn.wordpress.org/trunk@49049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-23 18:07:13 +00:00
Sergey Biryukov
f83aa63730 Coding Standards: Split long printf() calls for search results for better readability. 
Follow-up to [49284].

See #37353.
Built from https://develop.svn.wordpress.org/trunk@49286


git-svn-id: http://core.svn.wordpress.org/trunk@49048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-23 17:19:14 +00:00
Aaron Campbell
608ba462dd Upgrade/Install: Improve copy for opt-in to automatic major version updates. 
Props marybaum, kebbet.
See #50907.

Built from https://develop.svn.wordpress.org/trunk@49285


git-svn-id: http://core.svn.wordpress.org/trunk@49047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-23 16:36:14 +00:00
Helen Hou-Sandí
e0c12cc818 Administration: Unify search results message on list tables. 
This wraps the search string in a `<strong>` tag, which makes easier to parse visually especially when your search string also contains double quotes.

Props Mista-Flo, mapk, sergeybiryukov.
Fixes #37353.

Built from https://develop.svn.wordpress.org/trunk@49284


git-svn-id: http://core.svn.wordpress.org/trunk@49046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-23 16:01:15 +00:00
Helen Hou-Sandí
4847fb4263 Administration: Better targeting for required form field highlighting. 
Previously, any `input` or `select` inside of a `.form-invalid` wrapper would get the red border highlighting, including submit buttons which was not visually correct. This now only applies to form elements with a class of `.form-required` inside of the `.form-invalid` wrapper. It also continues to apply the border to elements with both classes (`.form-invalid.form-required`) as that is how some of the admin markup is structured.

Plugin authors may need to do the same sort of class application seen in this commit, i.e. add `.form-required` to certain form elements.

Props sabernhardt, dilipbheda, helen.
Fixes #50686.

Built from https://develop.svn.wordpress.org/trunk@49283


git-svn-id: http://core.svn.wordpress.org/trunk@49045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-23 15:05:09 +00:00
Sergey Biryukov
298cd04a63 Coding Standards: Update some alignment in wp-admin/authorize-application.php for consistency. 
Save blogs count to a variable for reusing.

Follow-up to [49270].

See #51489.
Built from https://develop.svn.wordpress.org/trunk@49282


git-svn-id: http://core.svn.wordpress.org/trunk@49042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-23 01:19:06 +00:00
Sergey Biryukov
0a70f9b004 Docs: Document the return value of wp_prepare_attachment_for_js() using hash notation. 
Props stevenlinx, Mista-Flo, johnbillion.
Fixes #50835.
Built from https://develop.svn.wordpress.org/trunk@49281


git-svn-id: http://core.svn.wordpress.org/trunk@49041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-23 00:43:07 +00:00
desrosj
57ae91be78 Build/Test Tools: Remove debug text included in [49267]. 
See #50401.
Built from https://develop.svn.wordpress.org/trunk@49280


git-svn-id: http://core.svn.wordpress.org/trunk@49040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-22 18:12:01 +00:00
TimothyBlynJacobs
ce34d0ab00 App Passwords: Support an app_id to uniquely identify instances of an app. 
Apps may now optionally include an `app_id` parameter when directing the user to the Authorize Application screen. This allows for instances of an application to be identified and potentially revoked or blocked.

Props TimothyBlynJacobs, georgestephanis.
Fixes #51583.

Built from https://develop.svn.wordpress.org/trunk@49276


git-svn-id: http://core.svn.wordpress.org/trunk@49038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-22 15:06:09 +00:00
Sergey Biryukov
83c900e8b3 Upgrade/Install: Add missing </form> tag in auto-updates settings form. 
Props imath, ahortin, dd32, afragen.
Fixes #51598. See #50907.
Built from https://develop.svn.wordpress.org/trunk@49274


git-svn-id: http://core.svn.wordpress.org/trunk@49036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-22 03:38:10 +00:00
TimothyBlynJacobs
fe8bb3ea58 App Passwords: Fix success=false not being appended to fallback reject url. 
Props TimothyBlynJacobs, georgestephanis.
Fixes #51581.

Built from https://develop.svn.wordpress.org/trunk@49272


git-svn-id: http://core.svn.wordpress.org/trunk@49034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-22 02:44:05 +00:00
Peter Wilson
9dc6d6147a XML-RPC: Fix length validation of anonymous commenter's email address. 
Fix the first step of validating an anonymous commenters in which the length is checked prior to running regular expressions.

Follow up to [47808].
Fixes #51595.


Built from https://develop.svn.wordpress.org/trunk@49271


git-svn-id: http://core.svn.wordpress.org/trunk@49033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-22 02:42:06 +00:00
TimothyBlynJacobs
85c49351af App Passwords: Explain that apps can access to all sites in a network. 
Props georgestephanis, spacedmonkey, johnjamesjacoby, SergeyBiryukov, marybaum.
Fixes #51489.

Built from https://develop.svn.wordpress.org/trunk@49270


git-svn-id: http://core.svn.wordpress.org/trunk@49032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-22 02:36:11 +00:00
Sergey Biryukov
cd04c0d68b Build/Test Tools: Only define WP_PLUGIN_DIR in when running core tests. 
This takes into account non-core plugins that rely on `WP_PLUGIN_DIR` being set to the expected plugin's directory in `WP_CONTENT_DIR`, or already have the constant defined.

Follow-up to [49236].

Props pierlo.
Fixes #51594.
Built from https://develop.svn.wordpress.org/trunk@49269


git-svn-id: http://core.svn.wordpress.org/trunk@49031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-22 00:44:05 +00:00
Peter Wilson
f8e9df7a95 Tests: Use shared fixtures in XML-RPC new comment unit tests. 
See #51344.


Built from https://develop.svn.wordpress.org/trunk@49268


git-svn-id: http://core.svn.wordpress.org/trunk@49030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-22 00:19:08 +00:00
desrosj
a8abe177a4 Build/Test Tools: Pass GitHub Action related environment variables to the Docker container. 
This ensures that `WP_UnitTestCase::skipOnAutomatedBranches()` has access to these variables so that time sensitive tests can be skipped when appropriate.

This also updates that logic to be more clear.

Follow up to [49264].

Props ocean90, johnbillion.
See #50401, #49050, #47767.
Built from https://develop.svn.wordpress.org/trunk@49267


git-svn-id: http://core.svn.wordpress.org/trunk@49029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-21 19:57:10 +00:00
Sergey Biryukov
ecf8e59918 Docs: Add a @since note about async_direct_test key to the site_status_tests filter. 
Follow-up to [49232].

See #51547.
Built from https://develop.svn.wordpress.org/trunk@49266


git-svn-id: http://core.svn.wordpress.org/trunk@49028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-21 14:55:09 +00:00
Sergey Biryukov
bbfc20ee44 Coding Standards: Rename a variable in wp-login.php for consistency with other instances. 
See #50767.
Built from https://develop.svn.wordpress.org/trunk@49265


git-svn-id: http://core.svn.wordpress.org/trunk@49027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-21 14:46:05 +00:00
desrosj
f9902dc742 Build/Test Tools: Skip some tests when not in the primary branch. 
This skips time sensitive tests when GitHub Actions workflows are not being run on `master` branch.

See #50401, #39486.
Built from https://develop.svn.wordpress.org/trunk@49264


git-svn-id: http://core.svn.wordpress.org/trunk@49026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-21 14:07:09 +00:00
desrosj
a7d6e929c9 Administration: Fix an invalid property in the Dashicons CSS file. 
Props komagain.
Fixes #51587.
Built from https://develop.svn.wordpress.org/trunk@49263


git-svn-id: http://core.svn.wordpress.org/trunk@49025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-21 13:16:07 +00:00
Helen Hou-Sandí
990875a7ae Post-post WordPress 5.6 beta 1 version bump. 
Built from https://develop.svn.wordpress.org/trunk@49262


git-svn-id: http://core.svn.wordpress.org/trunk@49024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-20 22:23:05 +00:00
Helen Hou-Sandí
a0f350b597 Post-WordPress 5.6 Beta 1 version bump. 
Built from https://develop.svn.wordpress.org/trunk@49261


git-svn-id: http://core.svn.wordpress.org/trunk@49023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-20 22:19:06 +00:00
Helen Hou-Sandí
7e29e531bd WordPress 5.6 Beta 1. 
Built from https://develop.svn.wordpress.org/trunk@49260


git-svn-id: http://core.svn.wordpress.org/trunk@49022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-20 21:47:06 +00:00
Sergey Biryukov
fcc04a6a37 Coding Standards: Fix WPCS issues in [49258]. 
See #46619.
Built from https://develop.svn.wordpress.org/trunk@49259


git-svn-id: http://core.svn.wordpress.org/trunk@49021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-20 21:20:07 +00:00
Helen Hou-Sandí
e1e6e949ff Privacy: Add "Mark as completed" action. 
Props garrett-eclipse, ocean90, joostdevalk, mista-flo, helen.
Fixes #46619.

Built from https://develop.svn.wordpress.org/trunk@49258


git-svn-id: http://core.svn.wordpress.org/trunk@49020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-20 21:07:07 +00:00
TimothyBlynJacobs
7fe78e2f18 REST API: Make sure all supported JSON Schema keywords are output in the index. 
Previously, only a small subset of keywords were exposed which limited the utility of `OPTIONS` requests.

Props raubvogel, TimothyBlynJacobs.
Fixes #51020.

Built from https://develop.svn.wordpress.org/trunk@49257


git-svn-id: http://core.svn.wordpress.org/trunk@49019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-20 20:19:09 +00:00
Sergey Biryukov
fbd8078d4e Comments: Add a filter for top level comments query arguments in comments_template(). 
Props hellofromTonya, Howdy_McGee, garrett-eclipse, davidbaumwald, thomaslhotta.
Fixes #38074.
Built from https://develop.svn.wordpress.org/trunk@49256


git-svn-id: http://core.svn.wordpress.org/trunk@49018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-20 20:11:06 +00:00
Helen Hou-Sandí
5b4d643d60 Privacy: Add requester IP to password reset emails. 
Props garrett-eclipse, bridgetwillard, isharis, ocean90.
Fixes #43856.

Built from https://develop.svn.wordpress.org/trunk@49255


git-svn-id: http://core.svn.wordpress.org/trunk@49017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-20 20:03:08 +00:00
Helen Hou-Sandí
9ab2f1ae3e Upgrade/Install: Add UI for opting in to core auto-updates for major versions. 
Props audrasjb, karmatosed, aaroncampbell, paaljoachim, davidbaumwald.
Fixes #50907.

Built from https://develop.svn.wordpress.org/trunk@49254


git-svn-id: http://core.svn.wordpress.org/trunk@49016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2020-10-20 19:35:06 +00:00