Scott Taylor
fc23dc3551
The About page has a <div>
that doesn't close. Also, <hr>
s should self-close. hackificator
complains about these things.
...
See #27881 .
Built from https://develop.svn.wordpress.org/trunk@28477
git-svn-id: http://core.svn.wordpress.org/trunk@28304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-18 20:33:15 +00:00
Sergey Biryukov
8dacdb77be
Fix wp_insert_link(), broken in [28406]/[28408].
...
see #22400 .
Built from https://develop.svn.wordpress.org/trunk@28475
git-svn-id: http://core.svn.wordpress.org/trunk@28302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-18 09:56:15 +00:00
Drew Jaynes
d75ca7aaaf
Add inline documentation for default arguments in wp_insert_category()
.
...
See #28298 .
Built from https://develop.svn.wordpress.org/trunk@28474
git-svn-id: http://core.svn.wordpress.org/trunk@28301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-18 07:28:14 +00:00
Sergey Biryukov
c453340a49
Update help text on Add Themes screen.
...
props thomasvanderbeek.
fixes #28132 .
Built from https://develop.svn.wordpress.org/trunk@28473
git-svn-id: http://core.svn.wordpress.org/trunk@28300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-17 23:44:15 +00:00
Scott Taylor
4ce9706db1
Add inline comment after fix in [28467].
...
Props jesin.
Fixes #28292 .
Built from https://develop.svn.wordpress.org/trunk@28468
git-svn-id: http://core.svn.wordpress.org/trunk@28295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-17 15:42:14 +00:00
Scott Taylor
bdd1ae2fc7
Restore $soucrce
in WP_Upgrader::install_package()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28467
git-svn-id: http://core.svn.wordpress.org/trunk@28294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-17 15:40:15 +00:00
Scott Taylor
8eb9f2ffe4
Eliminate use of extract()
in request_filesystem_credentials()
.
...
The only property that doesn't need to be set to a variable is `$password`.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28456
git-svn-id: http://core.svn.wordpress.org/trunk@28283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 18:26:15 +00:00
Andrew Ozz
f184243aa3
DFW: fix closing only the wpLink or media modal when pressing Esc.
...
Built from https://develop.svn.wordpress.org/trunk@28455
git-svn-id: http://core.svn.wordpress.org/trunk@28282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 18:17:14 +00:00
Scott Taylor
39de969bf2
Update inline docs for wp_handle_upload|sideload
to reflect their non-use of extract()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28452
git-svn-id: http://core.svn.wordpress.org/trunk@28279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 17:41:16 +00:00
Scott Taylor
632eb5b17e
Eliminate use of extract()
in wp_handle_sideload()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28451
git-svn-id: http://core.svn.wordpress.org/trunk@28278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 16:15:14 +00:00
Scott Taylor
4caf3e79f3
Eliminate use of extract()
in wp_handle_upload()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28450
git-svn-id: http://core.svn.wordpress.org/trunk@28277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 16:10:38 +00:00
Sergey Biryukov
abc830ca9d
DFW: Properly handle Esc key when the content is focused or when switching browser tabs.
...
props avryl.
fixes #28279 .
Built from https://develop.svn.wordpress.org/trunk@28443
git-svn-id: http://core.svn.wordpress.org/trunk@28270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 10:43:14 +00:00
Scott Taylor
b2d1e73fd5
Eliminate the use of extract()
in WP_Upgrader
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28418
git-svn-id: http://core.svn.wordpress.org/trunk@28245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 05:02:14 +00:00
Scott Taylor
d74272ecf5
Eliminate one of the uses of extract()
in wp_handle_upload()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28417
git-svn-id: http://core.svn.wordpress.org/trunk@28244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 04:31:14 +00:00
Scott Taylor
fc59804352
Eliminate one of the uses of extract()
in wp_handle_sideload()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28416
git-svn-id: http://core.svn.wordpress.org/trunk@28243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 04:29:15 +00:00
Scott Taylor
a7a6cb5bef
Eliminate use of extract()
in Walker_Category_Checklist::start_el()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28411
git-svn-id: http://core.svn.wordpress.org/trunk@28238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 03:14:14 +00:00
Scott Taylor
7ebab48f4c
Eliminate use of extract()
in wp_terms_checklist()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28410
git-svn-id: http://core.svn.wordpress.org/trunk@28237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 03:09:15 +00:00
Scott Taylor
a75f8137bc
Eliminate use of extract()
in wp_star_rating()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28409
git-svn-id: http://core.svn.wordpress.org/trunk@28236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 02:57:14 +00:00
Scott Taylor
ff665b2f38
(REALLY) Eliminate use of extract()
in wp_insert_link()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28408
git-svn-id: http://core.svn.wordpress.org/trunk@28235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 02:55:16 +00:00
Scott Taylor
54321f4c6e
Eliminate use of extract()
in get_media_item()
.
...
To test, fire open the old media in the console: `tb_show('Old Media is Weird', 'media-upload.php?type=image&TB_iframe=true&post_id=0');`
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28407
git-svn-id: http://core.svn.wordpress.org/trunk@28234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 02:45:15 +00:00
Scott Taylor
5f06d0f50a
Eliminate use of extract()
in wp_insert_link()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28406
git-svn-id: http://core.svn.wordpress.org/trunk@28233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 02:28:14 +00:00
Scott Taylor
1121efb54c
Eliminate use of extract()
in display_setup_form()
. Only needs to read password
and password_message
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28396
git-svn-id: http://core.svn.wordpress.org/trunk@28224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-14 16:43:15 +00:00
Drew Jaynes
a23cc5634f
Properly split and document the admin_post*
actions into the following four hooks:
...
* `admin_post_nopriv` – for logged-out requests lacking a supplied action
* `admin_post_nopriv_$action – for logged-out requests with a supplied action
* `admin_post` – for logged-in requests lacking a supplied action
* `admin_post_$action` – for logged-in requests with a supplied action
See [28349], [28350], [28351].
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28394
git-svn-id: http://core.svn.wordpress.org/trunk@28222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 07:24:15 +00:00
Drew Jaynes
40a738c21c
Clarify inline documentation for back-compat load-*
action hooks.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28393
git-svn-id: http://core.svn.wordpress.org/trunk@28221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 06:28:15 +00:00
Scott Taylor
fd9abeb0f9
Eliminate use of extract()
in post_tags_meta_box()
and post_categories_meta_box()
.
...
Both functions only need to read `taxonomy`, yet they extract every available variable from `$box['args']`. Even if those variables were useful, there is no attempt to pass them to anything, and scope in PHP does not allow them to be scooped up by inner functions without being passed directly.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28391
git-svn-id: http://core.svn.wordpress.org/trunk@28219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 05:48:17 +00:00
Scott Taylor
9476cd33a3
Eliminate use of extract()
in WP_Terms_List_Table::display_rows_or_placeholder()
:
...
* Set variables for `$page` and `$number`
* `list(...) = $this->get_column_info()` can be removed, as none of the variables returned are used.
* `orderby` and `search` can be checked from `$args`, leaving no reason to extract
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28390
git-svn-id: http://core.svn.wordpress.org/trunk@28218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 05:37:14 +00:00
Scott Taylor
aef35fe6a2
Eliminate use of extract()
in WP_List_Table::pagination()
:
...
* Set variables instead of extracting `$this->_pagination_args`
* Weird: `$infinite_scroll` is only presently set in subclasses of `WP_List_Table` and never initialized otherwise.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28389
git-svn-id: http://core.svn.wordpress.org/trunk@28217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 05:27:14 +00:00
Scott Taylor
530a107ec9
Eliminate use of extract()
in WP_Plugin_Install_List_Table::get_table_classes()
. It only needs to read plural
, no need to extract.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28388
git-svn-id: http://core.svn.wordpress.org/trunk@28216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 05:17:14 +00:00
Scott Taylor
192e235672
Eliminate use of extract()
in WP_List_Table::ajax_response()
:
...
* Extracting `$this->_args` is unnecessary since none of the variables produced are present in the method.
* `total_items` and `total_pages` can be read directly from `$this->_pagination_args`
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28387
git-svn-id: http://core.svn.wordpress.org/trunk@28215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 05:14:14 +00:00
Scott Taylor
08d73b9e23
Eliminate use of extract()
in WP_List_Table::display()
. The method only needs to read singular
from $this->_args
. Extraction is unnecessary.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28386
git-svn-id: http://core.svn.wordpress.org/trunk@28214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 05:08:13 +00:00
Scott Taylor
f617b8669a
Eliminate use of extract()
in WP_Post_Comments_List_Table::display()
. The method only needs to read singular
from $this->_args
. Extraction is unnecessary.
...
Eliminate use of `extract()` in `WP_Comments_List_Table::display()`. The method uses no variables. Extraction can be completely removed.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28385
git-svn-id: http://core.svn.wordpress.org/trunk@28213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 05:04:14 +00:00
Scott Taylor
4c60b2e207
Eliminate use of extract()
in Custom_Image_Header::step_2()
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28384
git-svn-id: http://core.svn.wordpress.org/trunk@28212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 04:54:14 +00:00
Drew Jaynes
ec88da1ee3
Clarify documentation for *what* gets "automatically fired" when the do_mu_upgrade
filter evaluates to true in Multisite.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28376
git-svn-id: http://core.svn.wordpress.org/trunk@28204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 04:18:14 +00:00
Drew Jaynes
b4ca72583a
Fix incomplete inline documentation for the wp_header_image_attachment_metadata
filter.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28375
git-svn-id: http://core.svn.wordpress.org/trunk@28203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 04:13:15 +00:00
Scott Taylor
6bbc5b570c
Eliminate use of extract()
in wp_insert_category()
. Adds unit tests. All unit tests pass.
...
Props MikeHansenMe.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28374
git-svn-id: http://core.svn.wordpress.org/trunk@28202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 03:27:13 +00:00
Scott Taylor
2bea9fcc0b
In media_upload_gallery_form()
's inline JavaScript, remove unnecessary comment tags.
...
Fixes #25637 .
Built from https://develop.svn.wordpress.org/trunk@28368
git-svn-id: http://core.svn.wordpress.org/trunk@28196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 06:12:15 +00:00
Scott Taylor
88b96dc036
In wp_read_image_metadata()
, the values from exif_read_data()
should only override values from iptcparse()
that are empty.
...
Props SergeyBiryukov.
Fixes #23706 .
Built from https://develop.svn.wordpress.org/trunk@28367
git-svn-id: http://core.svn.wordpress.org/trunk@28195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 05:54:15 +00:00
Scott Taylor
e9f87b2688
Avoid a notice in wp_save_image()
by checking $meta['sizes']['thumbnail']
for ! empty()
before setting a variable to it.
...
Props MikeHansenMe.
Fixes #17736 .
Built from https://develop.svn.wordpress.org/trunk@28366
git-svn-id: http://core.svn.wordpress.org/trunk@28194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 03:42:14 +00:00
Scott Taylor
0b6729c3f9
In WP_Terms_List_Table::single_row()
, call sanitize_term()
on the passed term ($tag
).
...
Props oso96_2000, c3mdigital, scribu.
It takes a village.
Fixes #16864 .
Built from https://develop.svn.wordpress.org/trunk@28360
git-svn-id: http://core.svn.wordpress.org/trunk@28188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 00:05:15 +00:00
Scott Taylor
f22beb987c
First pass at wpview
logic for the [embed]
shortcode. URLs on a their own line are parsed as well. The toolbar will appear with the "remove" button when the view is clicked. Edit has not been implemented yet.
...
Props avryl, wonderboymusic.
See #28195 .
Built from https://develop.svn.wordpress.org/trunk@28358
git-svn-id: http://core.svn.wordpress.org/trunk@28186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-10 23:36:18 +00:00
Drew Jaynes
81cfb9427a
Fix mid-file section header style in wp-admin/includes/ajax-actions.php.
...
See #28200 .
Built from https://develop.svn.wordpress.org/trunk@28356
git-svn-id: http://core.svn.wordpress.org/trunk@28184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-10 05:02:13 +00:00
Drew Jaynes
0ef7244ce7
Add baseline doc blocks for all ajax handlers in ajax-actions.php.
...
Fixes #28200 .
Built from https://develop.svn.wordpress.org/trunk@28355
git-svn-id: http://core.svn.wordpress.org/trunk@28183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-10 05:00:19 +00:00
Drew Jaynes
f609524261
Minor phpDoc fixes for the got_rewrite
, got_url_rewrite
, and documentation_ignore_functions
hooks.
...
Props GaryJ.
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28352
git-svn-id: http://core.svn.wordpress.org/trunk@28180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-08 11:13:14 +00:00
Drew Jaynes
c02696f43f
Rename the $action
hook in wp-admin/admin-post.php to admin_post{$action}
.
...
Also, clarify documentation of priv vs nopriv prefixing of the hook name.
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28351
git-svn-id: http://core.svn.wordpress.org/trunk@28179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-08 11:00:15 +00:00
Drew Jaynes
f427187fa8
Revert [28349] in favor of retaining the single dynamic admin_post*
hook.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28350
git-svn-id: http://core.svn.wordpress.org/trunk@28178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-08 10:47:15 +00:00
Drew Jaynes
a6755201d8
Convert and rename the $action
hook in wp-admin/admin-post to two dynamic hook sets.
...
* `admin_post_nopriv{$request_action}` is fired for logged-out users
* `admin_post{$request_action}` is fired for logged-in users
Props Otto42, DrewAPicture.
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28349
git-svn-id: http://core.svn.wordpress.org/trunk@28177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-08 10:27:14 +00:00
Drew Jaynes
32e674f44e
Use interpolation instead of concatenation for the manage_{$screen->id}_columns
hook name.
...
Props Otto42.
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28348
git-svn-id: http://core.svn.wordpress.org/trunk@28176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-08 09:58:14 +00:00
Drew Jaynes
8906f83802
Use an interpolated hook name for edit_{$post_type}_per_page
instead of $per_page
and adjust docs accordingly.
...
Also references the correct variable for the `$posts_per_page` parameter in the `edit_posts_per_page` hook doc.
Props Otto42 for the initial patch.
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28347
git-svn-id: http://core.svn.wordpress.org/trunk@28175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-08 08:16:15 +00:00
Scott Taylor
1daa7d6723
Leverage size_format()
when displaying max_upload_size
:
...
* In `media_upload_form()`
* The `uploader-inline` Underscore template in the media modal.
Replaces 2 buggy inline implementations that could display size units off by one, or size values off by one.
Fixes #25643 .
Built from https://develop.svn.wordpress.org/trunk@28343
git-svn-id: http://core.svn.wordpress.org/trunk@28171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 18:25:14 +00:00
Scott Taylor
5f27d149a3
In wp-admin/users.php
, break
is unreachabled after exit
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28315
git-svn-id: http://core.svn.wordpress.org/trunk@28143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:19:14 +00:00
Scott Taylor
402d8b80fb
In core_upgrade_preamble()
, $alternate
is set then never used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28314
git-svn-id: http://core.svn.wordpress.org/trunk@28142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:17:18 +00:00
Scott Taylor
e9bb9c0f12
In wp-admin/theme-editor.php
, break
is unreachabled after exit
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28313
git-svn-id: http://core.svn.wordpress.org/trunk@28141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:16:26 +00:00
Scott Taylor
517dbfaa21
In wp-admin/post.php
, break
is unreachabled after exit
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28312
git-svn-id: http://core.svn.wordpress.org/trunk@28140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:15:15 +00:00
Scott Taylor
327b38f298
In wp-admin/plugins.php
, break
is unreachabled after exit
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28311
git-svn-id: http://core.svn.wordpress.org/trunk@28139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:13:14 +00:00
Scott Taylor
ac63c66c5a
In wp-admin/plugin-editor.php
, break
is unreachabled after exit
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28310
git-svn-id: http://core.svn.wordpress.org/trunk@28138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:12:14 +00:00
Scott Taylor
0f8fb8a148
In wp-admin/network/users.php
, break
is unreachabled after exit
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28309
git-svn-id: http://core.svn.wordpress.org/trunk@28137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:11:14 +00:00
Scott Taylor
64418c0192
In wp-admin/network/themes.php
, break
is unreachabled after exit
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28308
git-svn-id: http://core.svn.wordpress.org/trunk@28136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:08:14 +00:00
Scott Taylor
f5d23b82bd
In wp-admin/link.php
, break
is unreachabled after exit
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28307
git-svn-id: http://core.svn.wordpress.org/trunk@28135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:06:14 +00:00
Scott Taylor
213a7de0b7
In display_setup_form()
, $admin_password
is set and (fortunately) not used or displayed.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28306
git-svn-id: http://core.svn.wordpress.org/trunk@28134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:04:15 +00:00
Scott Taylor
c2d44c5736
In wp-admin/includes/upgrade.php
, remove dead code:
...
* In `maybe_create_table()` and `maybe_add_column()`, the response of `$wpdb->query()` is set to a variable that is never used.
* In `make_db_current_silent()`, which is a wrapper for `dbDelta`, a variable is set that is not used. This function appears to be a copy-paste of `make_db_current()`'s `dbDelta()` call but is meant to return nothing, and still does not.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28305
git-svn-id: http://core.svn.wordpress.org/trunk@28133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 17:27:15 +00:00
Scott Taylor
aaa3eb07ad
In wp-admin/includes/update.php
, remove dead code:
...
* In `get_core_checksums()`, `$return` is set and never used.
* In `core_update_footer()`, `break` is unnecessary and unreachable after `return`.
* In `get_theme_updates()`, `$themes` is set and never used.
* In `wp_theme_update_row()`, `$theme_name` is the only user of `$themes_allowedtags`... neither are used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28304
git-svn-id: http://core.svn.wordpress.org/trunk@28132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 17:21:14 +00:00
Scott Taylor
b80cda5d17
In WP_Screen::render_screen_options()
, remove dead code:
...
* `$wp_list_table` does not need to be imported.
* `$post` is set and never used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28303
git-svn-id: http://core.svn.wordpress.org/trunk@28131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 17:14:15 +00:00
Scott Taylor
2e417f0ca4
In get_sample_permalink_html()
, $view_link
is set and never used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28302
git-svn-id: http://core.svn.wordpress.org/trunk@28130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 17:11:14 +00:00
Scott Taylor
44e2d48a3c
In install_plugin_information()
, $title
is set in a foreach
loop and never used. This appears to be due to copy-pasting a previous foreach
loop and not discarding these bits.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28301
git-svn-id: http://core.svn.wordpress.org/trunk@28129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 17:00:18 +00:00
Scott Taylor
e57fa7300d
In wp-admin/includes/nav-menu.php
, remove dead code:
...
* In `_wp_ajax_menu_quick_search()`, in an `else` block, `$post_obj` was set and not used. Another block sets it again and does use it.
* In `wp_nav_menu_item_post_type_meta_box()`, `$post_type_object` was set and, sadly, never used. `$error` was set and not used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28300
git-svn-id: http://core.svn.wordpress.org/trunk@28128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 16:55:14 +00:00
Scott Taylor
85bdc64173
In update_option_new_admin_email()
, $email
is set and never used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28299
git-svn-id: http://core.svn.wordpress.org/trunk@28127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 16:48:14 +00:00
Scott Taylor
6066f85853
In attachment_submit_meta_box()
, remove dead code:
...
* `$action` doesn't need to be imported.
* `$can_publish` is set and never used, which means it doesn't need...
* `$post_type_object` or `$post_type`, which only served `$can_publish`.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28298
git-svn-id: http://core.svn.wordpress.org/trunk@28126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 16:45:14 +00:00
Scott Taylor
71ac0f21c2
In get_media_item()
, $tags
and $_tags
are set and never used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28297
git-svn-id: http://core.svn.wordpress.org/trunk@28125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 16:41:17 +00:00
Scott Taylor
3054b924a3
In WP_Users_List_Table::get_views()
, $current_role
is set and never used.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28296
git-svn-id: http://core.svn.wordpress.org/trunk@28124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 15:33:15 +00:00
Scott Taylor
209f008d77
In WP_MS_Users_List_Table::get_views()
, remove dead code:
...
* `$wp_roles` doesn't need to be imported.
* `$current_role` is set and never used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28295
git-svn-id: http://core.svn.wordpress.org/trunk@28123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 15:30:14 +00:00
Dominik Schilling
f7539feb4d
Custom Header: Fix logic when a theme doesn't set default-text-color
.
...
fixes #28042 .
Built from https://develop.svn.wordpress.org/trunk@28294
git-svn-id: http://core.svn.wordpress.org/trunk@28122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 15:27:54 +00:00
Scott Taylor
970477d25e
In WP_Media_List_Table
, remove dead code:
...
* In `->prepare_items()`, importing `$wpdb` is unnecessary.
* In `->get_columns()`, `$taxonomies` is set twice before it is used.
* In `->display_rows()`, `$taxonomy_object` is set and never used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28293
git-svn-id: http://core.svn.wordpress.org/trunk@28121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 15:27:33 +00:00
Scott Taylor
28d98a89f3
In ajax-actions.php
, remove dead code:
...
* In `wp_ajax_add_tag()`, `$post_type` is set and never used.
* In `wp_ajax_hidden_columns()`, `$hidden` is set twice, but only checks for the existence of `$_POST['hidden']` the first time. The two lines can be combined and work together.
* In `wp_ajax_inline_save()`, `$mode` is set and never used.
* In `wp_ajax_find_posts()`, `$searchand = $search = '';` is leftover cruft, neither variable is used. `$wpdb` does not need to be imported, it is never used.
* In `wp_ajax_wp_fullscreen_save_post()`, `$post_type` is set and never used.
* In `wp_ajax_save_attachment_order()`, `$post` is set and never used.
* In `wp_ajax_send_attachment_to_editor()`, `$title` is set and never used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28292
git-svn-id: http://core.svn.wordpress.org/trunk@28120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 15:19:14 +00:00
Scott Taylor
d433f8f1ed
Remove unreachable break
statements in wp-admin/edit-tags.php
. break
is unnecessary after die
, exit
, and wp_die
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28291
git-svn-id: http://core.svn.wordpress.org/trunk@28119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 14:52:16 +00:00
Scott Taylor
d3dd9916d8
In wp-admin/custom-header.php
, $default_color
is set twice before it is used. The first is unnecessary.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28290
git-svn-id: http://core.svn.wordpress.org/trunk@28118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 14:51:19 +00:00
Scott Taylor
97e6942e4a
Remove unreachable break
statements in wp-admin/comments.php
. break
is unnecessary after die
, exit
, and wp_die
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28289
git-svn-id: http://core.svn.wordpress.org/trunk@28117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 14:46:16 +00:00
Sergey Biryukov
10ab8b1055
Translate a string added in 3.7 but never translated previously.
...
props andrezrv.
fixes #28025 .
Built from https://develop.svn.wordpress.org/trunk@28288
git-svn-id: http://core.svn.wordpress.org/trunk@28116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 12:49:15 +00:00
Sergey Biryukov
527a1ea6e3
Use a consistent context to remove duplicate strings.
...
props pavelevap.
fixes #28123 .
Built from https://develop.svn.wordpress.org/trunk@28287
git-svn-id: http://core.svn.wordpress.org/trunk@28115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 12:34:14 +00:00
Sergey Biryukov
28cafbb868
Add context for 'Previous' and 'Next' theme strings.
...
see #28120 , for trunk.
Built from https://develop.svn.wordpress.org/trunk@28286
git-svn-id: http://core.svn.wordpress.org/trunk@28114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 12:20:14 +00:00
Dominik Schilling
8b72aebdaa
Add missing Dashicons classes to User Admin menu.
...
props imath.
see #28144 , #26630 .
Built from https://develop.svn.wordpress.org/trunk@28284
git-svn-id: http://core.svn.wordpress.org/trunk@28112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 07:58:15 +00:00
Scott Taylor
ded4871368
In WP_List_Table::display_rows_or_placeholder()
, the call to get_column_info()
in unnecessary and unused. The call to get_column_count()
immediately after makes the same call internally.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28279
git-svn-id: http://core.svn.wordpress.org/trunk@28107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 05:32:15 +00:00
Andrew Nacin
7509795517
Custom header: Avoid warnings in the process_default_headers() method.
...
props obenland.
fixes #27850 .
Built from https://develop.svn.wordpress.org/trunk@28275
git-svn-id: http://core.svn.wordpress.org/trunk@28103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 05:07:13 +00:00
Scott Taylor
dd73ad4299
In edit_form_image_editor()
, $filename
and $title
are set and then unused. They shall be removed.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28271
git-svn-id: http://core.svn.wordpress.org/trunk@28099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 04:45:16 +00:00
Andrew Nacin
962e8113ab
Customizer: Only tie header button action events to the header controls.
...
props danielbachhuber.
fixes #28046 . see #27848 .
Built from https://develop.svn.wordpress.org/trunk@28269
git-svn-id: http://core.svn.wordpress.org/trunk@28097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 04:30:23 +00:00
Scott Taylor
644024dfc4
Dead code in wp-admin/includes/file.php
:
...
* In `wp_handle_upload()` and `wp_handle_sideload()`, `$ext` gets conditionally reset... and then is never used.
* In `request_filesystem_credentials()`, `$password` is initialized as an empty string. The variable is never used.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28268
git-svn-id: http://core.svn.wordpress.org/trunk@28096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 04:22:14 +00:00
Scott Taylor
3d7a4e6798
Remove unused variable setting for $revisions
in wp_prepare_revisions_for_js()
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28264
git-svn-id: http://core.svn.wordpress.org/trunk@28092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 03:45:14 +00:00
Scott Taylor
21379dcde0
Remove a dead variable, $start
, from wp_dashboard_recent_comments()
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28263
git-svn-id: http://core.svn.wordpress.org/trunk@28091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 03:35:14 +00:00
Andrew Nacin
f44e4226fa
Move 'home' option to the top of populate_options().
...
fixes #28141 .
Built from https://develop.svn.wordpress.org/trunk@28260
git-svn-id: http://core.svn.wordpress.org/trunk@28088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-05 21:57:14 +00:00
Sergey Biryukov
751e624ff7
Deprecate unused argument of delete_plugins(). Clarify @return value.
...
props jdgrimes for initial patch.
fixes #28111 .
Built from https://develop.svn.wordpress.org/trunk@28256
git-svn-id: http://core.svn.wordpress.org/trunk@28084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-05 10:24:15 +00:00
Sergey Biryukov
13cbcc92cf
Fix closing tag in image editor.
...
props t4k1s.
fixes #28130 .
Built from https://develop.svn.wordpress.org/trunk@28255
git-svn-id: http://core.svn.wordpress.org/trunk@28083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-05 10:17:19 +00:00
Sergey Biryukov
db4423c5cd
Avoid displaying a negative number of plugin updates in admin menu.
...
fixes #28073 .
Built from https://develop.svn.wordpress.org/trunk@28254
git-svn-id: http://core.svn.wordpress.org/trunk@28082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-05 09:39:17 +00:00
Sergey Biryukov
997cbaa03c
Use a time constant in get_theme_feature_list() and File_Upload_Upgrader.
...
props GaVrA.
fixes #28124 .
Built from https://develop.svn.wordpress.org/trunk@28253
git-svn-id: http://core.svn.wordpress.org/trunk@28081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-05 08:26:24 +00:00
Dominik Schilling
e6644720f9
Color Picker: Close color picker when clicking outside of them and when opening another one.
...
props mattwiebe.
fixes #25539 .
Built from https://develop.svn.wordpress.org/trunk@28239
git-svn-id: http://core.svn.wordpress.org/trunk@28067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-02 11:18:15 +00:00
Dominik Schilling
8e7e53b22e
Widgets: Toggle widget arrow when widget is open/closed.
...
props MikeHansenMe.
fixes #26748 .
Built from https://develop.svn.wordpress.org/trunk@28235
git-svn-id: http://core.svn.wordpress.org/trunk@28063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-01 14:09:16 +00:00
Dominik Schilling
a0086bd102
Quick Draft: Use text cursor for description label.
...
fixes #27766 .
Built from https://develop.svn.wordpress.org/trunk@28234
git-svn-id: http://core.svn.wordpress.org/trunk@28062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-01 13:12:16 +00:00
Drew Jaynes
058ff61dec
Mark the $hook
and $page_hook
hooks as @internal
to skip parsing.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28216
git-svn-id: http://core.svn.wordpress.org/trunk@28046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 07:54:21 +00:00
Drew Jaynes
d77e78d685
Clean up duplicate hook notations and adjacency for calls to the wp_signup_location
filter.
...
Also adds braces missed in [25535].
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28215
git-svn-id: http://core.svn.wordpress.org/trunk@28045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 07:12:14 +00:00
Drew Jaynes
029dd247be
Ensure the wp_edit_nav_menu_walker
filter is only documented once.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28213
git-svn-id: http://core.svn.wordpress.org/trunk@28043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 06:50:15 +00:00
Drew Jaynes
ef643d9136
Ensure all duplicate calls of the wp_create_file_in_uploads
filter are labeled as such.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28212
git-svn-id: http://core.svn.wordpress.org/trunk@28042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 06:46:19 +00:00
Drew Jaynes
a866838b31
Ensure adjacency of a duplicate hook comment for a the_category
filter call.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28211
git-svn-id: http://core.svn.wordpress.org/trunk@28041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 06:43:16 +00:00