Commit Graph

11607 Commits

Author SHA1 Message Date
Andrew Nacin
eeaad19a26 Use FS_CHMOD_FILE rather than an explicit 0644 in copy_dir() and _copy_dir().
This occurs when we can't copy a file. We chmod it and try again.

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25793


git-svn-id: http://core.svn.wordpress.org/trunk@25705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 19:14:10 +00:00
Dion Hulse
592123951b Fix a misspelling of the filter we're checking for, s/fs_method/filesystem_method/.
My bad. See #22704, [25781].

Built from https://develop.svn.wordpress.org/trunk@25787


git-svn-id: http://core.svn.wordpress.org/trunk@25699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 14:55:09 +00:00
Andrew Nacin
7b0088c938 Hide language-specific warnings/labels on update-core.php when we are dealing with a point release partial build.
see #22704, #18200.

Built from https://develop.svn.wordpress.org/trunk@25784


git-svn-id: http://core.svn.wordpress.org/trunk@25697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 05:08:09 +00:00
Andrew Nacin
e503d0e2ec Hide auto updates from update-core.php directly in get_core_updates(). see #22704.
Built from https://develop.svn.wordpress.org/trunk@25783


git-svn-id: http://core.svn.wordpress.org/trunk@25696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 05:07:10 +00:00
Andrew Nacin
957df34182 Automatic updates: An error code containing 'do_rollback' can be used to trigger a rollback.
This could enable the triggering of a rollback in update_core() in wp-admin/includes/update-core.php.

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25782


git-svn-id: http://core.svn.wordpress.org/trunk@25695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 02:59:10 +00:00
Andrew Nacin
cdede88a23 Automatic updates: Include error data in the follow-up API request.
props dd32.
see #22704.

Built from https://develop.svn.wordpress.org/trunk@25781


git-svn-id: http://core.svn.wordpress.org/trunk@25694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 23:33:10 +00:00
Andrew Nacin
9b56d4d11f Parse absolute paths out of error data. see #22704.
Built from https://develop.svn.wordpress.org/trunk@25780


git-svn-id: http://core.svn.wordpress.org/trunk@25693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 22:25:08 +00:00
Dion Hulse
4dcca90887 Remove PHP4 compat code from the ZipArchive unzip handler, and pass the failure reason into the WP_Error return.
See #22704

Built from https://develop.svn.wordpress.org/trunk@25779


git-svn-id: http://core.svn.wordpress.org/trunk@25692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 21:55:09 +00:00
Andrew Nacin
4fa3687e6a Account for the possible failure of disk_free_space() in update_core().
see #22704, #25576.

Built from https://develop.svn.wordpress.org/trunk@25778


git-svn-id: http://core.svn.wordpress.org/trunk@25691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 21:15:10 +00:00
Andrew Nacin
3e3c085db3 Auto updates: Only attempt a roll back when we've hit a critical error code.
Specifically, this means when we've failed in copying files.

see #22704.

Built from https://develop.svn.wordpress.org/trunk@25777


git-svn-id: http://core.svn.wordpress.org/trunk@25690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 21:03:09 +00:00
Andrew Nacin
145dbde82f Account for possible failures by disk_free_space(), as well as the potential need to copy the unzipped files.
see #25576.

Built from https://develop.svn.wordpress.org/trunk@25776


git-svn-id: http://core.svn.wordpress.org/trunk@25689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 20:58:09 +00:00
Andrew Nacin
1516b990f1 In the upgrader, only print additional error data if it is a string.
As in [25576], we sometimes want to return additional data that is not necessarily meant for UI consumption.

see #25576.

Built from https://develop.svn.wordpress.org/trunk@25775


git-svn-id: http://core.svn.wordpress.org/trunk@25688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 20:20:10 +00:00
Andrew Nacin
d68a80217f In unzip_file(), confirm we have enough available disk space before extracting.
"enough" is calculated by adding up the uncompressed size of the files in the archive, then adding a 20% buffer.

props dd32.
fixes #25576.

Built from https://develop.svn.wordpress.org/trunk@25774


git-svn-id: http://core.svn.wordpress.org/trunk@25687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 20:15:09 +00:00
Andrew Nacin
2d898df04f More specific error codes in the core upgrader when copying language, plugin, and theme files. see #22704.
Built from https://develop.svn.wordpress.org/trunk@25772


git-svn-id: http://core.svn.wordpress.org/trunk@25685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 19:38:10 +00:00
Dominik Schilling
f3faba9b95 Fix typo in wp-admin.css. props wycks. fixes #25589.
Built from https://develop.svn.wordpress.org/trunk@25771


git-svn-id: http://core.svn.wordpress.org/trunk@25684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-14 16:14:13 +00:00
Andrew Nacin
4c90c3cb31 Add explicit link to the installation being updated in debugging emails. see #22704.
Built from https://develop.svn.wordpress.org/trunk@25770


git-svn-id: http://core.svn.wordpress.org/trunk@25683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-12 20:18:10 +00:00
Andrew Nacin
de1d3c8261 Silence possible warnings from is_dir(). fixes #25572.
Built from https://develop.svn.wordpress.org/trunk@25764


git-svn-id: http://core.svn.wordpress.org/trunk@25677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-11 17:11:10 +00:00
Andrew Nacin
29f5f5b5fd Refine error codes throughout the upgrader so we can better detect at what stage updates fail.
see #22704.

Built from https://develop.svn.wordpress.org/trunk@25763


git-svn-id: http://core.svn.wordpress.org/trunk@25676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-11 16:06:11 +00:00
Andrew Ozz
debbfea3bf Upgrade TinyMCE to 3.5.9. Fix the css for the original 'fullscreen' plugin (not enabled by default).
Fixes #25561, fixes #25281.

Built from https://develop.svn.wordpress.org/trunk@25761


git-svn-id: http://core.svn.wordpress.org/trunk@25674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-10 21:50:09 +00:00
Andrew Nacin
2a8dcbae1f Auto updates: For follow-up API call when an update fails, send back the version attempted. see #22704.
Built from https://develop.svn.wordpress.org/trunk@25755


git-svn-id: http://core.svn.wordpress.org/trunk@25668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-10 14:46:11 +00:00
Dion Hulse
186a5379e8 After a upgrade fails, and we successfully rollback to a previous version, Don't send the version we rolled back to to the API, just that it was successful. See [25750]. See #22704
Built from https://develop.svn.wordpress.org/trunk@25752


git-svn-id: http://core.svn.wordpress.org/trunk@25665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-10 01:57:08 +00:00
Dion Hulse
0b9f198994 In the event that an Automatic Upgrade fails, send a failure status on the next API request to indicate that it failed, and if the rollback was successful.
See #22704

Built from https://develop.svn.wordpress.org/trunk@25750


git-svn-id: http://core.svn.wordpress.org/trunk@25663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-10 01:32:09 +00:00
Andrew Nacin
34da946343 Hook documentation for wp-admin/admin.php.
props DrewAPicture for initial patch.
fixes #25442.

Built from https://develop.svn.wordpress.org/trunk@25747


git-svn-id: http://core.svn.wordpress.org/trunk@25660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-09 21:01:09 +00:00
Andrew Nacin
f0eb99952c Make sure when resizing an image according to ratio we do not end up with a zero-pixel width or height.
props plocha.
fixes #25038.

Built from https://develop.svn.wordpress.org/trunk@25744


git-svn-id: http://core.svn.wordpress.org/trunk@25657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-09 19:07:17 +00:00
Helen Hou-Sandí
75eb364ced Show a label for the "Home" page nav menu item checkbox. props SergeyBiryukov. props ericlewis for the initial patch. fixes #25410.
Built from https://develop.svn.wordpress.org/trunk@25741


git-svn-id: http://core.svn.wordpress.org/trunk@25654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-09 18:47:09 +00:00
Dion Hulse
543d84a379 Upgrader: Create Directories with a minimum of 0755 and files with a minimum of 0644 when upgrading, which matches pre-3.7 behaviour. Fixes #20069
Built from https://develop.svn.wordpress.org/trunk@25739


git-svn-id: http://core.svn.wordpress.org/trunk@25652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-09 16:47:09 +00:00
Drew Jaynes
c100d28a25 Inline documentation for hooks in wp-admin/widgets.php.
Props r3df, kpdesign.
Fixes #25501.

Built from https://develop.svn.wordpress.org/trunk@25734


git-svn-id: http://core.svn.wordpress.org/trunk@25647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-08 20:27:08 +00:00
Scott Taylor
7a7b9c89ec Use parens to ensure that RegEx OR matches the front when determining that mime-type matches audio|video in attachment_submitbox_metadata().
Props kovshenin.
See #23926.


Built from https://develop.svn.wordpress.org/trunk@25727


git-svn-id: http://core.svn.wordpress.org/trunk@25640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-08 15:32:10 +00:00
Drew Jaynes
9482d8f08a Inline documentation for hooks in wp-admin/maint/repair.php.
Props ben.moody, kpdesign.
Fixes #25500.

Built from https://develop.svn.wordpress.org/trunk@25725


git-svn-id: http://core.svn.wordpress.org/trunk@25638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-08 00:30:09 +00:00
Drew Jaynes
b5a5df8a40 Inline documentation for hooks in wp-admin/network.php.
Props johnafish.
Fixes #25502.

Built from https://develop.svn.wordpress.org/trunk@25722


git-svn-id: http://core.svn.wordpress.org/trunk@25635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-07 23:43:10 +00:00
Andrew Nacin
a00df382a3 Move the revisions upgrade handler to POST, to avoid esoteric metadata stomping.
props SergeyBiryukov.
see #25023.
for trunk.

Built from https://develop.svn.wordpress.org/trunk@25719


git-svn-id: http://core.svn.wordpress.org/trunk@25632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-07 18:35:09 +00:00
Drew Jaynes
e77f69483e Inline documentation for wp-admin/options-reading.php.
Props siobhyb for the initial patch.
Fixes #25430.

Built from https://develop.svn.wordpress.org/trunk@25717


git-svn-id: http://core.svn.wordpress.org/trunk@25630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-07 17:18:09 +00:00
Andrew Nacin
d2f06ecf48 Optimize the accessibility JS on the Menus screen to avoid browser crashes with very large menus.
props atimmer.
fixes #25112.

Built from https://develop.svn.wordpress.org/trunk@25708


git-svn-id: http://core.svn.wordpress.org/trunk@25622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-07 13:37:08 +00:00
Drew Jaynes
ec96affcad Inline documentation for hooks in wp-admin/includes/bookmark.php.
Props johnafish, kpdesign.
Fixes #25494.

Built from https://develop.svn.wordpress.org/trunk@25706


git-svn-id: http://core.svn.wordpress.org/trunk@25620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-07 02:19:09 +00:00
Andrew Nacin
a8ea7828e9 Be as sure as possible that WordPress is not under version control when deciding if we should do automatic updates.
see #22704.

Built from https://develop.svn.wordpress.org/trunk@25700


git-svn-id: http://core.svn.wordpress.org/trunk@25615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-06 15:46:09 +00:00
Andrew Nacin
f29acee299 Don't modify post_author during a quick edit when the post type doesn't support authors.
props ocean90.
fixes #16645.

Built from https://develop.svn.wordpress.org/trunk@25698


git-svn-id: http://core.svn.wordpress.org/trunk@25613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-06 13:15:09 +00:00
Andrew Nacin
e8e5f48905 Run _fix_attachment_links() when post_status is future or private in addition to publish.
Fixes regression caused by [20308].

props jond3r.
fixes #25268.

Built from https://develop.svn.wordpress.org/trunk@25697


git-svn-id: http://core.svn.wordpress.org/trunk@25612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-06 12:56:09 +00:00
Andrew Nacin
d93d8b850d Reverse the order of roles in wp_dropdown_roles(). Reset to 'subscriber' when the default role is removed and when a save is invalid.
props garyc40, wonderboymusic.
fixes #14578.

Built from https://develop.svn.wordpress.org/trunk@25695


git-svn-id: http://core.svn.wordpress.org/trunk@25610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-06 10:56:09 +00:00
Andrew Nacin
e4dc691e75 Hide the "If you take over" string from the post locked dialog when the override_post_lock filter is used to prevent an override.
props azaozz.
fixes #24930.

Built from https://develop.svn.wordpress.org/trunk@25694


git-svn-id: http://core.svn.wordpress.org/trunk@25609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-06 10:46:09 +00:00
Andrew Nacin
8392f942a4 Send current SSL status to the plugin information API endpoint so we can render screenshots over SSL if appropriate. fixes #11009.
Built from https://develop.svn.wordpress.org/trunk@25691


git-svn-id: http://core.svn.wordpress.org/trunk@25607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-05 10:59:12 +00:00
Dominik Schilling
26e6703de7 Post UI: Increase the trigger width for switching from two columns to one.
props melchoyce, vinod dalvi.
fixes #23904.
Built from https://develop.svn.wordpress.org/trunk@25688


git-svn-id: http://core.svn.wordpress.org/trunk@25604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-03 09:37:09 +00:00
Dominik Schilling
328c4e9a67 Revert [25622]. fixes #25445. see #25122.
Built from https://develop.svn.wordpress.org/trunk@25687


git-svn-id: http://core.svn.wordpress.org/trunk@25603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-03 09:12:08 +00:00
Andrew Nacin
aef18d93cb When determining a frontend, local URL in the theme customizer, match the home URL without a trailing slash.
props SergeyBiryukov.
fixes #25315.

Built from https://develop.svn.wordpress.org/trunk@25681


git-svn-id: http://core.svn.wordpress.org/trunk@25597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-03 01:50:09 +00:00
Andrew Nacin
70a406560e Ensure we globally replace [ and ] in customizer control IDs, to match the PHP.
props westonruter.
fixes #25238.

Built from https://develop.svn.wordpress.org/trunk@25680


git-svn-id: http://core.svn.wordpress.org/trunk@25596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-03 01:46:10 +00:00
Andrew Nacin
6a675a8c9b Don't let the query string pile up on successive themes.php searches.
props SergeyBiryukov.
fixes #25270.

Built from https://develop.svn.wordpress.org/trunk@25679


git-svn-id: http://core.svn.wordpress.org/trunk@25595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-03 01:26:09 +00:00
Andrew Nacin
4c63d45139 Avoid counting auto-drafts in sticky.
props nofearinc.
fixes #25127.

Built from https://develop.svn.wordpress.org/trunk@25678


git-svn-id: http://core.svn.wordpress.org/trunk@25594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-03 01:16:10 +00:00
Andrew Nacin
b6d680174d List tables: When executing a search, reset the Bulk Actions dropdown to avoid the search from failing.
props c3mdigital, vinod-dalvi.
fixes #25034.

Built from https://develop.svn.wordpress.org/trunk@25677


git-svn-id: http://core.svn.wordpress.org/trunk@25593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-03 01:09:10 +00:00
Andrew Nacin
49af5f34d7 Post lists table: When counting a user's posts, use get_post_stati() instead of hardcoded internal statuses.
props creativeinfusion.
fixes #24818.

Built from https://develop.svn.wordpress.org/trunk@25676


git-svn-id: http://core.svn.wordpress.org/trunk@25592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-03 01:00:09 +00:00
Andrew Nacin
be366723d2 Don't use a double negative.
props TobiasBg.
fixes #18201.

Built from https://develop.svn.wordpress.org/trunk@25674


git-svn-id: http://core.svn.wordpress.org/trunk@25590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-02 21:50:09 +00:00
Andrew Nacin
524b62c5f6 Links manager: Restrict field length based on DB schema.
props solarissmoke, vinod-dalvi.
fixes #17296, #12264.

Built from https://develop.svn.wordpress.org/trunk@25670


git-svn-id: http://core.svn.wordpress.org/trunk@25586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-02 21:11:10 +00:00