John Blackbourn
eeba1c1244
HTTP API: Ensure the http_api_debug
hook is fired for all responses.
...
This means that logging and debugging functionality can access the error code and error message for erroneous responses under all conditions. The hook is not fired when a request is short-circuited with the `pre_http_request` filter, because this filter itself can be used in that situation.
Fixes #25747
Built from https://develop.svn.wordpress.org/trunk@45504
git-svn-id: http://core.svn.wordpress.org/trunk@45315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 17:10:52 +00:00
Andrea Fercia
935c35fe34
Accessibility: Improve the Screen Options and Help buttons order.
...
- makes the buttons visual order match the DOM order
- also, restores the focus style on the "hero" primary button after [34948]
Props vrimill, mukesh27 for reporting and testing.
Fixes #45094 .
Built from https://develop.svn.wordpress.org/trunk@45503
git-svn-id: http://core.svn.wordpress.org/trunk@45314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 16:31:53 +00:00
Andrea Fercia
be14c6e5c6
Administration: Improve the Screen Options and Help buttons focus style after [45501].
...
Amends [45501].
See #46749 .
Built from https://develop.svn.wordpress.org/trunk@45502
git-svn-id: http://core.svn.wordpress.org/trunk@45313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 16:07:52 +00:00
Andrea Fercia
17034e2a4e
Administration: Remove extra border from the Screen Options and Help buttons.
...
The extra border was visible in the responsive view for smaller screens after [32844].
Props jitendrabanjara1991.
Fixes #46749 .
Built from https://develop.svn.wordpress.org/trunk@45501
git-svn-id: http://core.svn.wordpress.org/trunk@45312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 14:50:52 +00:00
Andrew Ozz
7cee029897
Privacy tools: remove some left-over code and fix inline comment.
...
See #43895 .
Built from https://develop.svn.wordpress.org/trunk@45500
git-svn-id: http://core.svn.wordpress.org/trunk@45311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 00:30:51 +00:00
Andrea Fercia
6a9bcaeaa9
Accessibility: Improve accessibility of all the media views form controls.
...
- changes the media views form controls to have explicitly associated labels with for/id attributes
- adds a few missing labels / aria-labels
- improves a few existing labels / aria-labels
- improves semantics in a few places, by adding visually hidden headings, fieldset + legend elements, aria-describedby attributes
- improves the image custom size input fields and their labelling
- adds `role="status"` to the "saved" indicator so that status messages are announced to assistive technologies
- swaps the columns source order in the image details template, to make visual and DOM order match
- swaps the "Replace" and "Back" buttons source order in the Replace Image view, to make visual and DOM order match
- gallery settings: move checkbox label to the right: checkboxes are supposed to have labels on the right
- merge similar strings, unified to "Drop files to upload" (removed "Drop files here", and "Drop files anywhere to upload")
- makes the "upload-ui" consistent across the media views
- hides the IE 11 "X" `::-ms-clear` button in the Insert from URL field, as it conflicts with the uploading spinner
- adds comments to all the media templates to clarify their usage
- slightly increases vertical spacing between form fields in the media sidebar
- removes some CSS selectors introduced as backwards compatibility for WordPress pre-4.4
- removes some CSS still targeting Internet Explorer 7 and 8
Fixes #47141 .
Fixes #47122 .
Built from https://develop.svn.wordpress.org/trunk@45499
git-svn-id: http://core.svn.wordpress.org/trunk@45310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-07 20:45:02 +00:00
Andrea Fercia
314bfab180
Regenerate the REST API fixtures after [45443].
...
See #38517 .
Built from https://develop.svn.wordpress.org/trunk@45498
git-svn-id: http://core.svn.wordpress.org/trunk@45309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-07 20:24:52 +00:00
Andrea Fercia
d5333b9593
Fix the media player controls bar width in the media views.
...
Props vaishalipanchal, chetan200891.
Fixes #47457 .
Built from https://develop.svn.wordpress.org/trunk@45497
git-svn-id: http://core.svn.wordpress.org/trunk@45308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-07 13:29:52 +00:00
Sergey Biryukov
056b9c47a2
Docs: Fix typo in comment_class()
DocBlock.
...
Props mbabker.
Fixes #47499 .
Built from https://develop.svn.wordpress.org/trunk@45496
git-svn-id: http://core.svn.wordpress.org/trunk@45307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-06 23:52:51 +00:00
Sergey Biryukov
baa2cd69b8
Media: Restore correct arrow direction in RTL in Attachment Details modal.
...
Reverts [29264]. As we now have a build task to replace dashicons for RTL, the CSS rules no longer worked as expected and had the opposite effect.
Props ramiy, SergeyBiryukov.
Fixes #46289 .
Built from https://develop.svn.wordpress.org/trunk@45495
git-svn-id: http://core.svn.wordpress.org/trunk@45306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-06 01:25:52 +00:00
Sergey Biryukov
53719315b4
I18N: Merge duplicate "Original" strings used in the same context (referring to image size).
...
Props mukesh27.
Fixes #47486 .
Built from https://develop.svn.wordpress.org/trunk@45494
git-svn-id: http://core.svn.wordpress.org/trunk@45305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-05 15:23:52 +00:00
Sergey Biryukov
3f9bf72d69
I18N: Correct encoding for wp-includes/widgets/class-wp-widget-calendar.php
, accidentally saved in ANSI instead of UTF-8.
...
See #47485 .
Built from https://develop.svn.wordpress.org/trunk@45493
git-svn-id: http://core.svn.wordpress.org/trunk@45304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-05 15:09:53 +00:00
Sergey Biryukov
16dfde180c
I18N: Merge duplicate "A calendar of your site’s posts" strings used in the Calendar widget and the Calendar block in the editor.
...
Props jorgefilipecosta, ramiy.
Fixes #47485 .
Built from https://develop.svn.wordpress.org/trunk@45492
git-svn-id: http://core.svn.wordpress.org/trunk@45303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-05 15:03:53 +00:00
Sergey Biryukov
8c449d3312
Posts, Post Types: Switch the order of arguments for implode()
in the_meta()
to match the function notation.
...
Props loyaltymanufaktur.
Fixes #47481 .
Built from https://develop.svn.wordpress.org/trunk@45491
git-svn-id: http://core.svn.wordpress.org/trunk@45302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-05 00:16:54 +00:00
desrosj
4c0620bdf8
Privacy: Remove inline CSS within personal data request list tables.
...
The `.hidden` class can be used to show and hide UI elements instead.
Props birgire, pratikthink, garrett-eclipse.
Fixes #44839 .
Built from https://develop.svn.wordpress.org/trunk@45490
git-svn-id: http://core.svn.wordpress.org/trunk@45301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-04 23:40:55 +00:00
Sergey Biryukov
aa59cb8359
Docs: Correct parameter name for wp_new_user_notification_email_admin
filter.
...
Props needle.
Fixes #47476 .
Built from https://develop.svn.wordpress.org/trunk@45489
git-svn-id: http://core.svn.wordpress.org/trunk@45300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-04 12:48:55 +00:00
Sergey Biryukov
32d761ce7d
I18N: Merge duplicate "Status" and "Info" strings on Site Health screens.
...
Props ramiy.
Fixes #47227 .
Built from https://develop.svn.wordpress.org/trunk@45488
git-svn-id: http://core.svn.wordpress.org/trunk@45299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-01 22:10:52 +00:00
Sergey Biryukov
13da094c39
Upgrade/Install: Correct operator precedence for an error code in WP_Ajax_Upgrader_Skin::error()
.
...
Props jrf.
Fixes #47441 .
Built from https://develop.svn.wordpress.org/trunk@45487
git-svn-id: http://core.svn.wordpress.org/trunk@45298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-31 14:14:52 +00:00
Sergey Biryukov
410eb3501b
Build/Test Tools: Add $current_screen
to the list of globals to unset in WP_UnitTestCase_Base::go_to()
.
...
Props mauteri.
Fixes #47439 .
Built from https://develop.svn.wordpress.org/trunk@45486
git-svn-id: http://core.svn.wordpress.org/trunk@45297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-31 14:07:51 +00:00
Felix Arntz
3c40573f77
Bundled Theme: Load Google fonts with display=fallback
parameter for better UX in case the font cannot be loaded.
...
Providing this query parameter ensures the stylesheet contains the `font-display: fallback` rule. This changeset also updates the Open Sans font used by core accordingly.
Props westonruter.
Fixes #47282 .
Built from https://develop.svn.wordpress.org/trunk@45485
git-svn-id: http://core.svn.wordpress.org/trunk@45296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-31 10:10:54 +00:00
Sergey Biryukov
0d40c54f9b
CSS Coding Standards: Use unitless values for line-height
in wp-admin/css/media.css
.
...
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46530 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45484
git-svn-id: http://core.svn.wordpress.org/trunk@45295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 16:45:50 +00:00
Sergey Biryukov
412ffd0aaf
Media: Move tag cloud styles that accidentally ended up in Media section after the reorganization in [16136] to a more appropriate place.
...
Remove styles for `wp-admin/update-core.php` accidentally duplicated in Media section as part of the same reorganization.
See #46530 .
Built from https://develop.svn.wordpress.org/trunk@45483
git-svn-id: http://core.svn.wordpress.org/trunk@45294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 16:40:52 +00:00
youknowriad
ebb0b92081
Block Editor: Update packages to the ones slated for WP5.2.2
...
- Fix the template validation notice
- Fix for focus jumps when typing in meta attributes
Packages updated:
- @wordpress/block-editor@2.0.3
- @wordpress/block-library@2.4.6
- @wordpress/e2e-tests@1.1.6
- @wordpress/edit-post@3.3.6
- @wordpress/editor@9.2.6
- @wordpress/format-library@1.4.6
Props aduth, desrosj.
Fixes #47429 .
Built from https://develop.svn.wordpress.org/trunk@45481
git-svn-id: http://core.svn.wordpress.org/trunk@45292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 15:41:57 +00:00
desrosj
349d95f27a
Docs: Add missing function documentation for list_plugin_updates()
.
...
Introduced in [9543].
Props priyankkpatel, mukesh27.
Fixes #47424 .
Built from https://develop.svn.wordpress.org/trunk@45480
git-svn-id: http://core.svn.wordpress.org/trunk@45291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 15:10:52 +00:00
desrosj
012d05f5c0
Docs: Add missing documentation for the locale meta field.
...
The user’s locale is passed in the `$meta` parameter for `insert_user_meta`. Added in [38705].
Props tmatsuur.
Fixes #47423 .
Built from https://develop.svn.wordpress.org/trunk@45479
git-svn-id: http://core.svn.wordpress.org/trunk@45290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 14:37:53 +00:00
Sergey Biryukov
96a533b279
CSS Coding Standards: Use unitless values for line-height
in wp-includes/css/media-views.css
.
...
Props ianbelanger, pbiron, afercia.
Fixes #46529 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45478
git-svn-id: http://core.svn.wordpress.org/trunk@45289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 13:18:52 +00:00
Sergey Biryukov
9bab7d6fd6
CSS Coding Standards: Use unitless values for line-height
in wp-includes/css/editor.css
.
...
Props ianbelanger, pbiron, afercia.
Fixes #46528 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45477
git-svn-id: http://core.svn.wordpress.org/trunk@45288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:45:53 +00:00
Sergey Biryukov
5083e104d4
CSS Coding Standards: Use unitless values for line-height
in wp-includes/css/buttons.css
.
...
Props ianbelanger, pbiron, afercia.
Fixes #46526 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45476
git-svn-id: http://core.svn.wordpress.org/trunk@45287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:42:52 +00:00
Sergey Biryukov
1d98a92fad
CSS Coding Standards: Use unitless values for line-height
in wp-includes/css/wp-pointer.css
.
...
Props ianbelanger, pbiron, afercia.
Fixes #46525 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45475
git-svn-id: http://core.svn.wordpress.org/trunk@45286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:41:51 +00:00
Sergey Biryukov
90b2092ab6
CSS Coding Standards: Use unitless values for line-height
in wp-includes/css/wp-embed-template.css
.
...
Props ianbelanger, pbiron, afercia.
Fixes #46524 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45474
git-svn-id: http://core.svn.wordpress.org/trunk@45285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:40:52 +00:00
Sergey Biryukov
05afb2271d
CSS Coding Standards: Use unitless values for line-height
in wp-includes/functions.php
.
...
Props ianbelanger, pbiron, afercia.
Fixes #46523 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45473
git-svn-id: http://core.svn.wordpress.org/trunk@45284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:39:52 +00:00
Sergey Biryukov
820baca1bd
CSS Coding Standards: Use unitless values for line-height
in wp-includes/css/wp-auth-check.css
.
...
Props ianbelanger, pbiron, afercia.
Fixes #46522 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45472
git-svn-id: http://core.svn.wordpress.org/trunk@45283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:37:52 +00:00
Sergey Biryukov
e6b98a469c
CSS Coding Standards: Use unitless values for line-height
in wp-includes/css/jquery-ui-dialog.css
.
...
Props ianbelanger, pbiron, afercia.
Fixes #46521 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45471
git-svn-id: http://core.svn.wordpress.org/trunk@45282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:36:52 +00:00
Sergey Biryukov
8738c23afc
CSS Coding Standards: Use unitless values for line-height
in wp-includes/css/customize-preview.css
.
...
Props ianbelanger, pbiron, afercia.
Fixes #46520 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45470
git-svn-id: http://core.svn.wordpress.org/trunk@45281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:34:52 +00:00
Sergey Biryukov
2a417c2168
CSS Coding Standards: Use unitless values for line-height
in wp-includes/css/admin-bar.css
.
...
Props ianbelanger, pbiron, afercia.
Fixes #46519 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45469
git-svn-id: http://core.svn.wordpress.org/trunk@45280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:32:51 +00:00
Sergey Biryukov
fdc6b9583b
CSS Coding Standards: Use unitless values for line-height
in wp-admin/css/revisions.css
.
...
Props ianbelanger, pbiron, afercia.
Fixes #46517 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45468
git-svn-id: http://core.svn.wordpress.org/trunk@45279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:16:52 +00:00
Sergey Biryukov
ca6aa01705
CSS Coding Standards: Use unitless values for line-height
in wp-admin/css/list-tables.css
.
...
Props ianbelanger, pbiron, afercia.
Fixes #46515 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45467
git-svn-id: http://core.svn.wordpress.org/trunk@45278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:15:52 +00:00
Sergey Biryukov
afaeca95cf
CSS Coding Standards: Use unitless values for line-height
in wp-admin/css/login.css
.
...
Props ianbelanger, pbiron, afercia.
Fixes #46514 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45466
git-svn-id: http://core.svn.wordpress.org/trunk@45277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:09:52 +00:00
Sergey Biryukov
1899a99c35
CSS Coding Standards: Use unitless values for line-height
in wp-admin/css/install.css
.
...
Props ianbelanger, pbiron, afercia.
Fixes #46513 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45465
git-svn-id: http://core.svn.wordpress.org/trunk@45276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 11:53:53 +00:00
Sergey Biryukov
03814826b2
CSS Coding Standards: Use unitless values for line-height
in wp-admin/css/forms.css
.
...
Props ianbelanger, pbiron, afercia.
Fixes #46512 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45464
git-svn-id: http://core.svn.wordpress.org/trunk@45275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 11:49:53 +00:00
Andrea Fercia
41accccad6
Administration: Improve the Site Health tables layout for small screens.
...
Props immeet94, jankimoradiya, desrosj, shashank3105, chetan200891, Clorith, hedgefield.
Fixes #46960 .
Built from https://develop.svn.wordpress.org/trunk@45463
git-svn-id: http://core.svn.wordpress.org/trunk@45274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-29 18:22:51 +00:00
Sergey Biryukov
52d478cb0d
CSS Coding Standards: Use unitless values for line-height
in wp-admin/css/edit.css
.
...
Props ianbelanger, pbiron, afercia.
Fixes #46511 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45462
git-svn-id: http://core.svn.wordpress.org/trunk@45273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-29 16:05:53 +00:00
Sergey Biryukov
ce25e2f34d
CSS Coding Standards: Use unitless values for line-height
in wp-admin/css/dashboard.css
.
...
Props ianbelanger, pbiron, afercia.
Fixes #46510 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45461
git-svn-id: http://core.svn.wordpress.org/trunk@45272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-29 16:03:52 +00:00
Sergey Biryukov
9860a4366d
CSS Coding Standards: Use unitless values for line-height
in wp-admin/css/customize-widgets.css
.
...
Props ianbelanger, pbiron, afercia.
Fixes #46509 . See #44643 .
Built from https://develop.svn.wordpress.org/trunk@45460
git-svn-id: http://core.svn.wordpress.org/trunk@45271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-29 16:01:53 +00:00
desrosj
bb3c264350
Administration: Add missing filter documentation for Site Health auto update tests.
...
Props johnbillion, mukesh27.
Fixes #47388 .
Built from https://develop.svn.wordpress.org/trunk@45459
git-svn-id: http://core.svn.wordpress.org/trunk@45270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-29 13:59:51 +00:00
Andrew Ozz
d23160d427
Fix unit tests after [45456]. The query string is a bit different but the results are the same.
...
See #45346 .
Built from https://develop.svn.wordpress.org/trunk@45458
git-svn-id: http://core.svn.wordpress.org/trunk@45269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-28 04:19:53 +00:00
Andrew Ozz
311527b41d
Fix previous WPCS errors in script-loader.php
triggered by [45456].
...
See #45346 .
Built from https://develop.svn.wordpress.org/trunk@45457
git-svn-id: http://core.svn.wordpress.org/trunk@45268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-28 03:32:52 +00:00
Andrew Ozz
6de52463a7
Script loader: prevent sorting of the load
array in the query string when passing the script handles to load-scripts.php and load-styles.php.
...
Fixes #45346 #26886 .
Built from https://develop.svn.wordpress.org/trunk@45456
git-svn-id: http://core.svn.wordpress.org/trunk@45267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-28 02:43:55 +00:00
Andrew Ozz
b8fa71964f
Build tools, WPCS: disable line ending check when running phpcs
but fix them to \n
whit phpcfb
. Fixes (erroneous) reports on Windows about improper line endings in all files. They are managed directly by Git or SVN.
...
Fixes #47411 .
Built from https://develop.svn.wordpress.org/trunk@45455
git-svn-id: http://core.svn.wordpress.org/trunk@45266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-28 00:26:54 +00:00
Sergey Biryukov
51ee349942
Docs: Add a comment about the reinstated wp-admin/options-privacy.php
.
...
See #43895 .
Built from https://develop.svn.wordpress.org/trunk@45454
git-svn-id: http://core.svn.wordpress.org/trunk@45265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-27 03:03:52 +00:00