Commit Graph

30496 Commits

Author SHA1 Message Date
Sergey Biryukov
eebc1705a8 Tests: Add missing @covers tags for files in phpunit/tests/error-protection/.
Props patopaiar, jrf.
See #39265.
Built from https://develop.svn.wordpress.org/trunk@50289


git-svn-id: http://core.svn.wordpress.org/trunk@49934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-11 20:56:05 +00:00
Sergey Biryukov
9d739f6be3 Tests: Add missing @covers tags for files in phpunit/tests/editor/.
Props patopaiar, jrf.
See #39265.
Built from https://develop.svn.wordpress.org/trunk@50288


git-svn-id: http://core.svn.wordpress.org/trunk@49933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-11 20:54:16 +00:00
Sergey Biryukov
7034111a38 Tests: Add missing @covers tags for files in phpunit/tests/dependencies/.
Props patopaiar, jrf.
See #39265.
Built from https://develop.svn.wordpress.org/trunk@50287


git-svn-id: http://core.svn.wordpress.org/trunk@49932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-11 15:17:07 +00:00
Sergey Biryukov
262234df8d Tests: Add missing @covers tags for files in phpunit/tests/db/.
Props patopaiar, jrf.
See #39265.
Built from https://develop.svn.wordpress.org/trunk@50286


git-svn-id: http://core.svn.wordpress.org/trunk@49931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-11 14:04:09 +00:00
desrosj
1cfa0a1370 Build/Test Tools: Install WordPress Importer plugin when installing the Docker-based local environment.
The WordPress Importer plugin is now downloaded to the `tests/phpunit/data/plugins` directory when running `npm run env:install`.

This ensures that the PHPUnit test suite will not fail when the plugin is missing.

This also introduces a new `WP_IMPORTER_REVISION` variable to the `.env` file, to control the SVN revision that is checked out.

Props johnbillion.
Fixes #49720.
Built from https://develop.svn.wordpress.org/trunk@50285


git-svn-id: http://core.svn.wordpress.org/trunk@49930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-10 16:54:07 +00:00
Sergey Biryukov
fc8e180035 Tests: Use assertSame() in some newly introduced tests.
This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable.

Follow-up to [49904], [49925], [49992], [50012], [50013], [50065], [50075], [50131], [50150], [50157].

See #38266, #52482.
Built from https://develop.svn.wordpress.org/trunk@50284


git-svn-id: http://core.svn.wordpress.org/trunk@49929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-10 13:27:02 +00:00
Sergey Biryukov
24dbafaba5 Tests: Replace most instances of assertEquals() in phpunit/includes/ with assertSame().
Follow-up to [48937], [48939], [48940], [48944].

Props johnbillion, jrf, SergeyBiryukov.
See #38266, #52482.
Built from https://develop.svn.wordpress.org/trunk@50283


git-svn-id: http://core.svn.wordpress.org/trunk@49928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-10 13:25:09 +00:00
Peter Wilson
0f251cdd90 Canonical: Rename wp_force_plain_ugly_permalink() to match UI terminology.
Rename `wp_force_plain_ugly_permalink()` to `wp_force_plain_post_permalink()` to match terminology used in the WordPress dashboard.

Follow up to [50132].
Props SergeyBiryukov.
Fixes #5272.


Built from https://develop.svn.wordpress.org/trunk@50282


git-svn-id: http://core.svn.wordpress.org/trunk@49927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-10 05:40:07 +00:00
desrosj
30da2b425d Post WordPress 5.7 Beta 2 version bump.
Built from https://develop.svn.wordpress.org/trunk@50281


git-svn-id: http://core.svn.wordpress.org/trunk@49926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 20:40:04 +00:00
desrosj
bcbad3aef8 WordPress 5.7 Beta 2.
Built from https://develop.svn.wordpress.org/trunk@50280


git-svn-id: http://core.svn.wordpress.org/trunk@49925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 20:26:05 +00:00
Sergey Biryukov
38696a7290 Tests: Add missing @covers tags for files in phpunit/tests/date/.
Props patopaiar, jrf.
See #39265.
Built from https://develop.svn.wordpress.org/trunk@50279


git-svn-id: http://core.svn.wordpress.org/trunk@49924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 19:57:02 +00:00
ryelle
10d1280ff3 Administration: Update color contrast on UI elements.
The color palette changes in #49999 introduced some contrast issues on buttons, input elements, and links. This change ensures that all interactive elements have an appropriate contrast ratio.

Follow-up to [50025].
Props audrasjb, joedolson.
Fixes #52402.


Built from https://develop.svn.wordpress.org/trunk@50278


git-svn-id: http://core.svn.wordpress.org/trunk@49923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 19:47:03 +00:00
desrosj
ac126c1062 Build/Test Tools: Synchronize svn:ignore with .gitignore.
Some files ignored within the `.gitignore` file were not included in the `svn:ignore` property.

This also removed `wp-config.php` and `wp-tests-config.php` from the `svn:ignore` property. It’s already specified in `svn:global-ignores`.

Props johnbillion.
Fixes #49784.
Built from https://develop.svn.wordpress.org/trunk@50277


git-svn-id: http://core.svn.wordpress.org/trunk@49922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 18:42:05 +00:00
Sergey Biryukov
7cae8b1c02 Tests: Correct the test for NOT BETWEEN comparison operator in WP_Date_Query.
Follow-up to [29793].

Props patopaiar, jrf.
See #39265, #51802.
Built from https://develop.svn.wordpress.org/trunk@50276


git-svn-id: http://core.svn.wordpress.org/trunk@49921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 18:10:04 +00:00
Sergey Biryukov
8212925c11 Twenty Twenty: Make ordered list styling in classic editor match the front-end style.
Props sabernhardt, sebastienserre, hareesh-pillai.
Fixes #50454.
Built from https://develop.svn.wordpress.org/trunk@50275


git-svn-id: http://core.svn.wordpress.org/trunk@49920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 17:54:04 +00:00
antpb
0c5a3fa2ed Media: Make adjacent_image_link() include alt text when returning an image.
When using the `adjacent_image_link()` function there is a condition that will return a linked image. Previously, the returned image was sent without alt attributes.

Now, `adjacent_image_link()` will include alt attributes of the image's title when an image is returned.

Props joedolson, Mista-Flo, sabernhardt.
Fixes #52387.

Built from https://develop.svn.wordpress.org/trunk@50274


git-svn-id: http://core.svn.wordpress.org/trunk@49919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 17:27:05 +00:00
Sergey Biryukov
8bd0709dba Twenty Twenty-One: Use correct value for the global line-height CSS variable.
Props acerempel, mukesh27, dd32, poena.
Fixes #52477.
Built from https://develop.svn.wordpress.org/trunk@50273


git-svn-id: http://core.svn.wordpress.org/trunk@49918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 17:10:05 +00:00
Sergey Biryukov
2fdd20da49 Site Health: Link to the support article on troubleshooting in "There has been a critical error" message.
This page is more geared towards users than the one on debugging, which is more developer-oriented.

Props audrasjb, Clorith, Ipstenu.
Fixes #52392.
Built from https://develop.svn.wordpress.org/trunk@50272


git-svn-id: http://core.svn.wordpress.org/trunk@49917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 16:59:04 +00:00
John Blackbourn
3e801fdb5d Comments: Extend the duration of the window within which unapproved comments are visible by their author.
This extension is necessary because the comment approval notification opt-in form introduced in [47887] uses the same mechanism, and the previous limit of one minute meant that users on a slow connection, using assistive technology, with limited motor skills, or who are generally indecisive may not complete the opt-in action within one minute, and therefore not see the confirmation message.

Props joedolson, imath, hellofromTonya, peterwilsoncc, alexstine, davidbaumwald 

Fixes #52406

Built from https://develop.svn.wordpress.org/trunk@50271


git-svn-id: http://core.svn.wordpress.org/trunk@49916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 16:57:04 +00:00
Sergey Biryukov
4fd440cd5c External Libraries: Further fix jQuery deprecations in WordPress core.
This addresses `JQMIGRATE` warnings in the `image-edit.js` library and the `imgAreaSelect` jQuery plugin

Follow-up to [50001].

Props Clorith, poena, dariak, jeroenrotty.
See #51812.
Built from https://develop.svn.wordpress.org/trunk@50270


git-svn-id: http://core.svn.wordpress.org/trunk@49915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 16:45:06 +00:00
desrosj
34987fe903 Twenty Twenty-One: Prevent Dark Mode related JavaScript error.
This prevents an `Uncaught TypeError` in the block editor when scrolling caused by the absence of a `#dark-mode-toggler` element.

Props ocean90, mukesh27, justinahinon.
Fixes #52473.
Built from https://develop.svn.wordpress.org/trunk@50269


git-svn-id: http://core.svn.wordpress.org/trunk@49914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 14:56:04 +00:00
desrosj
d0c1e2b97b Build/Test Tools: Correct some inline documentation within GitHub Action files.
This corrects several inaccuracies within the GitHub Action workflow files.

See #50401.
Built from https://develop.svn.wordpress.org/trunk@50268


git-svn-id: http://core.svn.wordpress.org/trunk@49913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 14:18:03 +00:00
desrosj
5972493ca5 Build/Test Tools: Update NPM dependencies.
This updates two `devDependencies`:

- `uglify-js` from `3.12.6` to `3.12.7`.
- `check-node-version` from `4.0.3` to `4.1.0`.

See #51801.
Built from https://develop.svn.wordpress.org/trunk@50267


git-svn-id: http://core.svn.wordpress.org/trunk@49912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 14:16:19 +00:00
John Blackbourn
ea252a7cba Posts, Post Types: Clarify the documentation about the return value of get_post() when a falsey value is passed.
Props Rahe, juliobox, peterwilsoncc, hellofromTonya, audrasjb

Fixes #33068

Built from https://develop.svn.wordpress.org/trunk@50266


git-svn-id: http://core.svn.wordpress.org/trunk@49911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 13:44:04 +00:00
John Blackbourn
18c0b1c561 Build/Test Tools: Various docblock improvements within test utilities.
See #51802

Built from https://develop.svn.wordpress.org/trunk@50265


git-svn-id: http://core.svn.wordpress.org/trunk@49910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 13:24:04 +00:00
Sergey Biryukov
19ce835654 Docs: Update some recently added inline comments per the documentation standards.
Follow-up to [50256], [50258], [50259].

See #51800.
Built from https://develop.svn.wordpress.org/trunk@50264


git-svn-id: http://core.svn.wordpress.org/trunk@49909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 12:34:06 +00:00
Sergey Biryukov
ea2ff553e9 Site Health: Clarify the recommendation in file uploads test when post_max_size is defined as 0.
This adds a more descriptive text in scenarios where `post_max_size` and `upload_max_filesize` differ, and `post_max_size` is set to a value of `0`.

In some scenarios, PHP may read `0` as a literal zero size, and not as unlimited, which it also means in other scenarios.

See https://www.php.net/manual/en/ini.core.php#ini.post-max-size for details, as PHP 5.3.4 introduced this behavior for literal zero interpretation when the content type of a request is `application/x-www-form-urlencoded` or is not registered with PHP.

Props Clorith, pixolin, helen, ratneshk.
Fixes #51466.
Built from https://develop.svn.wordpress.org/trunk@50263


git-svn-id: http://core.svn.wordpress.org/trunk@49908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 12:05:07 +00:00
Peter Wilson
98b855ed94 Twenty Twenty-One: Update editor styles of search block.
Update editor styles to more closely match the front-end following upstream changes.

Props poena, paaljoachim, hellofromTonya.
Fixes #52433.


Built from https://develop.svn.wordpress.org/trunk@50262


git-svn-id: http://core.svn.wordpress.org/trunk@49907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 03:55:05 +00:00
Peter Wilson
2ffff78f51 Twenty Twenty-One: Adapt vertical buttons to text length.
Display vertically aligned buttons as inline elements.

Props poena, paaljoachim, hellofromTonya, jeroenrotty, rolfsiebers.
Fixes #52432.


Built from https://develop.svn.wordpress.org/trunk@50261


git-svn-id: http://core.svn.wordpress.org/trunk@49906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 03:44:06 +00:00
Peter Wilson
165413db2b Twenty Twenty-One: Support font size option for code block.
Props poena, paaljoachim, hellofromTonya.
See #52431.


Built from https://develop.svn.wordpress.org/trunk@50260


git-svn-id: http://core.svn.wordpress.org/trunk@49905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 03:24:05 +00:00
noisysocks
c6ec6cdc88 Fix wp.i18n.isRTL()
Fixes a bug causing wp.i18n.isRTL() to return false in RTL langauges by manually
loading the translated 'ltr' string for the i18n dependency. This ports over an
identical fix that was made in Gutenberg.

Fixes #52441.
Props @jonsurrell @youknowriad.

Built from https://develop.svn.wordpress.org/trunk@50259


git-svn-id: http://core.svn.wordpress.org/trunk@49904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-08 23:51:10 +00:00
antpb
19dbb952f3 Media: Allow post_date to be respected in media_handle_sideload().
Previously, date information was unable to be changed when using `media_handle_sideload()`. 

Now you can override the date for a media item using `$post_data['post_date']` before using the function.

Props jamesgol, mukesh27, SergeyBiryukov, hellofromTonya, Mista-Flo.
Fixes #50972.

Built from https://develop.svn.wordpress.org/trunk@50258


git-svn-id: http://core.svn.wordpress.org/trunk@49903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-08 23:22:04 +00:00
Peter Wilson
71b277da38 Posts/Post Types: Improve documentation of get_posts().
Add references to `WP_Query` to the documentation of `get_posts()`. As the developer documentation for `WP_Query` includes an expanded explanation a full link to developer.wordpress.org is included rather than a standard `@see`.

Props dam6pl, peterwilsoncc.
See #51852, #51800.


Built from https://develop.svn.wordpress.org/trunk@50257


git-svn-id: http://core.svn.wordpress.org/trunk@49902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-08 22:52:02 +00:00
antpb
b981f48184 Media: Pause any playing media when closing the the media modal.
Previously, any video or audio playing in the media modal failed to stop playing when the modal was closed. Now we pause the player when the modal is closed.

Props adamsilverstein, hellofromTonya, paaljoachim, Mista-Flo, Clorith, justinahinon, afercia, amolv.
Fixes #48562.

Built from https://develop.svn.wordpress.org/trunk@50256


git-svn-id: http://core.svn.wordpress.org/trunk@49901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-08 21:44:09 +00:00
Dominik Schilling
219d92f75b Block Editor: Use a unique name for the nonce of the custom fields toggle form.
Avoids a browser warning for having two elements with a non-unique id `#_wpnonce` on the post edit screen.

See #23165.
Fixes #51483.
Props vandestouwe, Mista-Flo.
Built from https://develop.svn.wordpress.org/trunk@50255


git-svn-id: http://core.svn.wordpress.org/trunk@49900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-08 21:39:16 +00:00
ryelle
591845b4c9 Privacy: Update colors to match new color palette.
Follow-up to [50161].
Props xkon.
Fixes #52436.


Built from https://develop.svn.wordpress.org/trunk@50238


git-svn-id: http://core.svn.wordpress.org/trunk@49899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-08 19:15:06 +00:00
ryelle
d4e4828d0a Administration: Fix background color of plugin update row on small screens.
When the color change was done, the background of plugins with updates had to be manually changed. This section was missed, which caused a visual bug. This fix also removes some redundant CSS for the same element.

Follow-up to [50025].
Props afragen.
Fixes #52452.


Built from https://develop.svn.wordpress.org/trunk@50237


git-svn-id: http://core.svn.wordpress.org/trunk@49898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-08 16:13:07 +00:00
Sergey Biryukov
8bc5c10684 Docs: Clarify the @return value for wp_get_attachment_image_url() and get_the_post_thumbnail_url().
Props GeekPress, audrasjb, naveen17797.
Fixes #52183.
Built from https://develop.svn.wordpress.org/trunk@50236


git-svn-id: http://core.svn.wordpress.org/trunk@49897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-08 14:14:08 +00:00
noisysocks
d5fd2d8ea7 Editor: Update @wordpress npm packages
Update @wordpress npm packages to the latest published versions. This includes
block editor bug fixes for WordPress 5.7 beta 2.

Fixes #52467.

Built from https://develop.svn.wordpress.org/trunk@50235


git-svn-id: http://core.svn.wordpress.org/trunk@49896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-08 03:37:09 +00:00
Sergey Biryukov
b88325dbc6 I18N: Use the actual placeholder instead of a number in translator comments if the corresponding string does not use numbered placeholders.
Adjust some newly introduced strings to remove unnecessary numbered placeholders for consistency.

Follow-up to [42827].

See #51800.
Built from https://develop.svn.wordpress.org/trunk@50234


git-svn-id: http://core.svn.wordpress.org/trunk@49895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-07 12:44:04 +00:00
Sergey Biryukov
48469c6a8f Twenty Twenty-One: Capitalize translator comments consistently.
Follow-up to [45932].

See #51800.
Built from https://develop.svn.wordpress.org/trunk@50233


git-svn-id: http://core.svn.wordpress.org/trunk@49894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-07 12:28:08 +00:00
Sergey Biryukov
1aca7e8b25 Editor: Correct the check for unsaved content in wp.autosave.server.postChanged().
This fixes improper triggering of the "Are you sure?" prompt when navigating away from the old, "classic" Edit Post screen and there are no changes.

The previous check did not account for Pages or any custom post types that don't have a Title, Content, or Excerpt field.

Follow-up to [50031].

Props hwk-fr, mukesh27, audrasjb, archon810, Clorith, ibiza69, tonysandwich, roger995, bartosz777, viablethought, dbtedg, worldedu, hmabpera, magnuswebdesign.
Fixes #52440.
Built from https://develop.svn.wordpress.org/trunk@50232


git-svn-id: http://core.svn.wordpress.org/trunk@49893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-06 14:16:07 +00:00
Sergey Biryukov
a8d455a78f Docs: Use typed array notation in the update_post_term_count_statuses filter DocBlock.
Follow-up to [50169].

See #38843.
Built from https://develop.svn.wordpress.org/trunk@50231


git-svn-id: http://core.svn.wordpress.org/trunk@49892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-05 19:13:09 +00:00
Sergey Biryukov
a80f705d97 Privacy: Rename the $send_confirmation_email parameter of wp_create_user_request() to $status, for clarity.
Follow-up to [50159], [50165].

Props xkon, TimothyBlynJacobs.
Fixes #52430. See #43890.
Built from https://develop.svn.wordpress.org/trunk@50230


git-svn-id: http://core.svn.wordpress.org/trunk@49891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-05 15:50:05 +00:00
John Blackbourn
9cd08881ba Users: Coding standards fixes after [50228].
See #52238

Built from https://develop.svn.wordpress.org/trunk@50229


git-svn-id: http://core.svn.wordpress.org/trunk@49890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-05 14:43:03 +00:00
John Blackbourn
523e292d8c Users: Allow the role of users to be bulk changed to no role from the Users listing screen.
This option is already available when editing an individual user, but it was previously missing from the bulk actions.

Props bonniebeeman, sabernhardt, ovidiul, jeroenrotty

Fixes #52238

Built from https://develop.svn.wordpress.org/trunk@50228


git-svn-id: http://core.svn.wordpress.org/trunk@49889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-05 14:40:08 +00:00
desrosj
d28712518c Build/Test Tools: Fix tests after [50185].
This removes a test assertion defending against version ranges in the `node` value in `package.json` files. This is now supported.

Props peterwilsoncc.
See #52341.
Built from https://develop.svn.wordpress.org/trunk@50192


git-svn-id: http://core.svn.wordpress.org/trunk@49870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-05 03:38:05 +00:00
desrosj
a752adb3e6 Build/Test Tools: Specify a version range within engines for node and npm.
This makes it more clear what versions of `node` and `npm` will successfully build WordPress.

Props dd32, mkaz.
Fixes #52455. See #51749.
Built from https://develop.svn.wordpress.org/trunk@50185


git-svn-id: http://core.svn.wordpress.org/trunk@49863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-05 02:46:08 +00:00
Sergey Biryukov
c8759b4a14 Privacy: Remove gray left border on the inline notices in Privacy Policy Guide.
Follow-up to [50161].

Props xkon.
See #52430.
Built from https://develop.svn.wordpress.org/trunk@50182


git-svn-id: http://core.svn.wordpress.org/trunk@49861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-04 12:48:05 +00:00
Sergey Biryukov
1e7305ed4b Privacy: Update URLs to the Privacy Policy Guide in help tabs.
Follow-up to [50147], [50161].

Props xkon.
See #52430.
Built from https://develop.svn.wordpress.org/trunk@50181


git-svn-id: http://core.svn.wordpress.org/trunk@49860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-04 12:06:07 +00:00