Commit Graph

244 Commits

Author SHA1 Message Date
nacin
64b9b4f940 Do not specify background-image: none when a user removes a custom background
on a theme that has a default background image.

The onus is on the theme to omit the default background-image from style.css,
to allow the user to remove the default background image. Or, the theme can
specify a background-image for the body selector, as long as they then zero
it out for body.custom-background, like so:

{{{
body {
	background-image: url( ... );
}
body.custom-background {
	background-image: none;
}
}}}

This allows the theme to be compatible with the custom background feature
but also gracefully degrade if the background feature is disabled.

This is the same behavior as 3.3; setting a default image has simply been
made more prominent in 3.4. Reverts [21013], also parts of [21001].
see #20448 for change and discussion history.

see #20132, which will now be marked as invalid.

Also, per previous changes in #20448, the custom-background class should not
be shown when only a default color is in use.

fixes #20448.



git-svn-id: http://core.svn.wordpress.org/trunk@21054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-11 21:25:05 +00:00
ryan
64e6663569 Fix removing the default background image for themes that hard-code the default in css. Honor the default background image for themes that do not provide a fallback in css.
* <style> will appear if there is a default image registered. This is the same as 3.3.
* If only a default color is registered, it still assumes it is in the stylesheet, and no <style> will appear. This is a change from 3.3.
* <style> will continue to appear as before if there is a custom background color or image. This is the same as 3.3.
* This then allows for a default background image with background-image: none, overriding style.css. This is new.

Props nacin
see #20448


git-svn-id: http://core.svn.wordpress.org/trunk@21001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-05 18:35:31 +00:00
ryan
0f1f59b092 Custom background fixes:
* Specify default background colors for the bundled themes.
* Change the default custom background callback to only operate on saved values, rather than default values.
* Prevent an unsaved default value from overriding a manually modified style.css file.

Props nacin, kobenland
fixes #20448


git-svn-id: http://core.svn.wordpress.org/trunk@20973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-01 20:31:50 +00:00
ryan
0d99cf31a6 Don't escape anchor text as an attributein wp_get_attachment_link(). Props SergeyBiryukov. fixes #19282
git-svn-id: http://svn.automattic.com/wordpress/trunk@20654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-30 21:22:58 +00:00
ryan
54a1ee90b9 Always show search-results or search-no-results for searches, even archive searches. Props johnbillion. fixes #20435
git-svn-id: http://svn.automattic.com/wordpress/trunk@20595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-25 20:38:40 +00:00
nacin
ae8af5d0dd Introduce get_page_template_slug( $id = null ) to return a page's template (like "showcase.php"). Returns false if post ID is not a page, and an empty string for the default page template. Use the function across core. props billerickson for initial patch. fixes #18750.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-02 18:56:54 +00:00
ryan
0dfe24e69b Set post password cookies via an action in wp-login.php. Retire wp-pass.php (one less root file). Obey login ssl preferences for post password form submission. Props SergeyBiryukov. fixes #19798
git-svn-id: http://svn.automattic.com/wordpress/trunk@19925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-14 18:29:22 +00:00
nacin
1098f33984 Don't create a variable we only use once. props niallkennedy, fixes #19941.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-01 22:33:43 +00:00
ryan
ed8c96636c Hash post password in cookies. fixes #19797
git-svn-id: http://svn.automattic.com/wordpress/trunk@19728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-11 16:42:42 +00:00
ryan
616c35e71c One newline is enough.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-05 20:10:39 +00:00
ryan
fd1393ab7a Clear strict notices for the walkers. fixes #19249
git-svn-id: http://svn.automattic.com/wordpress/trunk@19679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-04 23:03:46 +00:00
ryan
5b9144b12d Use site_url() to link to wp-pass.php. Props dd32. fixes #14748
git-svn-id: http://svn.automattic.com/wordpress/trunk@19677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-04 20:05:39 +00:00
ryan
07ff8b216b Use one space, not two, after trailing punctuation. fixes #19537
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-13 23:45:31 +00:00
nacin
f88cdc0668 Pass remaining start_el() arguments to page_css_class. props TheDeadMedic, fixes #17727.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-10 18:35:25 +00:00
nacin
eea7874845 Simplify logic in wp_get_attachment_link(). see #18491.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-08 14:22:42 +00:00
ryan
75e238360a Avoid warning when non-existent ID pass to wp_get_attachment_link(). Tidy formatting of wp_get_attachment_link(). Props SergeyBiryukov, Jayjdk. fixes #18491
git-svn-id: http://svn.automattic.com/wordpress/trunk@19210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-08 14:08:25 +00:00
nacin
91a448be74 Use esc_attr() consistently in wp_dropdown_pages().
git-svn-id: http://svn.automattic.com/wordpress/trunk@19081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-28 22:40:09 +00:00
duck_
abd0c8c231 Correctly document $stripteaser as a boolean flag. Props GaryJ, fixes #18886.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-26 10:15:29 +00:00
markjaquith
37aae9f46f Give custom background CSS more specificity. props GaryJ. fixes #18698
git-svn-id: http://svn.automattic.com/wordpress/trunk@18886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-05 17:20:43 +00:00
nacin
3440dbb182 Add filter for the args into wp_dropdown_pages() in the page attributes box. Give the list_pages filter the context of the post object. fixes #8592 for 3.3.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-29 21:21:15 +00:00
ryan
69a52799a5 Do not output title attributes in the page walker since they match the anchor and are thus superfluous. Props logiclord. fixes #16783
git-svn-id: http://svn.automattic.com/wordpress/trunk@18739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-21 20:04:14 +00:00
dd32
bd5cf872c6 Allow Apostrophes in Post Passwords. $_POST and $_COOKIE are always slashed. Fixes #17145
git-svn-id: http://svn.automattic.com/wordpress/trunk@18712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-19 04:17:26 +00:00
duck_
c8a4ab1b4c Only add the post format body classes when the post type supports post formats. props ocean90. fixes #18228.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-07 20:10:42 +00:00
ryan
4ad0954961 Introduce register_meta(), get_metadata_by_mid(), and *_post_meta capabilities. fixes #17850
git-svn-id: http://svn.automattic.com/wordpress/trunk@18445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-07-20 22:04:35 +00:00
nacin
6590faa5ba Shears.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-07-11 05:34:15 +00:00
nacin
6a073f6d47 Restore page-template-default body class. props peterwilsoncc, fixes #18018 for trunk.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-07-11 05:31:57 +00:00
westi
bb74249c0d Ensure that we always coerce the class list passed to get_body_class to an array even when it is empty. Fixes #17717
git-svn-id: http://svn.automattic.com/wordpress/trunk@18176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-07 08:55:25 +00:00
ryan
47ff74214f Return false from is_page_template() if the template is default. Props johnbillion. fixes #17458
git-svn-id: http://svn.automattic.com/wordpress/trunk@18062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-27 15:24:33 +00:00
nacin
8a0d83bebe Apply esc_html properly in Walker_PageDropdown. fixes #17217.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-22 18:24:57 +00:00
nacin
66befd1f7e Initialize a variable. props boonebgorges, fixes #16977.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-03-27 19:46:18 +00:00
nacin
ce0ebf0c95 Only add the post format post classes when the post type supports post formats. posts posts posts posts. props iandstewart, fixes #16224.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-13 23:02:24 +00:00
nacin
5c88aa5e8e _get_post_ancestors() in Walker_Page. props layotte, fixes #14329.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-09 12:38:23 +00:00
markjaquith
9edf7af6b4 Another s/default/standard/. see #15582
git-svn-id: http://svn.automattic.com/wordpress/trunk@16693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-02 21:24:41 +00:00
nacin
9134684d84 escape URL in wp_link_pages. fixes #14271.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-22 23:54:30 +00:00
nacin
b8ce0261df More param fixes, props duck_. see #14783.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-18 19:12:48 +00:00
nacin
8ff32f52df Add list_pages filter. props johnjamesjacoby, fixes #13668.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-18 02:23:05 +00:00
ryan
847499e531 Pinking shears
git-svn-id: http://svn.automattic.com/wordpress/trunk@16438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-17 18:47:34 +00:00
markjaquith
78e63786d0 Add admin-bar class to body_class() if the admin bar is showing. fixes #15455
git-svn-id: http://svn.automattic.com/wordpress/trunk@16432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-17 17:21:45 +00:00
nacin
81a8f2d3ce Use square brackets instead of braces for string access. props hakre, fixes #13900.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-13 09:53:55 +00:00
westi
435c4c2dbf Revert most of [16332] - renaming and deprecating a commonly used function is silly. Improving it is good. Fixes #15407.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-12 21:53:15 +00:00
scribu
98cda5bd65 Replace get_the_category() with get_the_categories(). Props filosofo. Fixes #15407
git-svn-id: http://svn.automattic.com/wordpress/trunk@16332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-12 20:05:37 +00:00
scribu
18116f12c6 Don't use deprecated category properties. Props filosofo. Fixes #15408
git-svn-id: http://svn.automattic.com/wordpress/trunk@16331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-12 18:40:51 +00:00
markjaquith
75d045de8e Add checks for WP_Error. props ptahdunbar. see #14746
git-svn-id: http://svn.automattic.com/wordpress/trunk@16315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-12 04:10:56 +00:00
nacin
5f4a583fb1 Remove more create_function calls. props huichen, see #14424.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-11 22:50:36 +00:00
westi
9e30ccd803 Add support for ID style classes in get_body_class(). Fixes #12397 props filosofo
git-svn-id: http://svn.automattic.com/wordpress/trunk@16283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-10 22:07:07 +00:00
scribu
e7318d2068 Skip category/tag queries if post type doesn't support them. Props mfields. Fixes #15322
git-svn-id: http://svn.automattic.com/wordpress/trunk@16204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-05 12:47:19 +00:00
markjaquith
c6a5d1192c Post Formats generate output in post_class() (format-foo), and body_class() (for single... single-format-foo). Now themers can support Post Formats with one line of PHP and by adding CSS! see #14746
git-svn-id: http://svn.automattic.com/wordpress/trunk@16200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-05 06:48:56 +00:00
westi
85a7330154 Add the post status as a class so that a theme can easily style private posts differently. Fixes #15279.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-01 18:07:31 +00:00
westi
e52d8a51bb Add a post class if a password is required for the post to be displayed. See #13860 props zeo.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-01 18:05:33 +00:00
nacin
588523f119 Move Walker_Page* to post-template, Walker_Category* to category-template, and rm classes.php. see #10287.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-30 14:06:08 +00:00