Commit Graph

30431 Commits

Author SHA1 Message Date
Sergey Biryukov
9b44c28f78 Themes: Add missing <p> tags to error message in WP_Theme_Install_List_Table::prepare_items().
Follow-up to [45909], [49953].

See #52254.
Built from https://develop.svn.wordpress.org/trunk@49954


git-svn-id: http://core.svn.wordpress.org/trunk@49653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-10 19:37:06 +00:00
Sergey Biryukov
75d686563f Bootstrap/Load: Add missing <p> tags to error message in wp-load.php.
Follow-up to [45909].

Props mukesh27, TimothyBlynJacobs, audrasjb.
Fixes #52254.
Built from https://develop.svn.wordpress.org/trunk@49953


git-svn-id: http://core.svn.wordpress.org/trunk@49652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-10 19:28:08 +00:00
TimothyBlynJacobs
b1f8ffa77d REST API: Fix fatal error on multisite when calling the single item plugin routes.
The `is_network_only_plugin` and `is_plugin_active` functions are not available in a front-end context and must be specifically loaded.

Props oakesjosh.
Fixes #52205.

Built from https://develop.svn.wordpress.org/trunk@49952


git-svn-id: http://core.svn.wordpress.org/trunk@49651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-09 20:22:11 +00:00
Sergey Biryukov
ef956a1309 Tests: Set up the plugin download in multisite plugin tests to come locally.
This brings consistency between single site and multisite in REST API plugin installation tests.

Previously, multisite tests were unnecessarily downloading the plugin from WordPress.org on each test run, causing external HTTP requests and leading to failures in case of a timeout.

Follow-up to [48242], [49491], [49913].

See #51669.
Built from https://develop.svn.wordpress.org/trunk@49951


git-svn-id: http://core.svn.wordpress.org/trunk@49650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-09 05:58:07 +00:00
John Blackbourn
b364ff86e5 Posts, Post Types: Introduce the wp_list_table_show_post_checkbox filter which allows the visibility of the bulk edit checkbox on the post list table to be controlled separately from the edit_post capability of the current user.
Props coreyw, alexstine

Fixes #51291

Built from https://develop.svn.wordpress.org/trunk@49950


git-svn-id: http://core.svn.wordpress.org/trunk@49649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-08 17:18:07 +00:00
Sergey Biryukov
47c146ac27 Accessibility: Customize: Add an empty alt attribute to the <img> tag used as a hidden placeholder in the Customizer preview when no logo is chosen.
Per accessibility best practices, it is recommended that all HTML `<img>` elements have an `alt` attribute. Any decorative images should have an empty `alt` attribute (`alt=""`).

Props laxman-prajapati, sabernhardt, audrasjb.
Fixes #51846.
Built from https://develop.svn.wordpress.org/trunk@49949


git-svn-id: http://core.svn.wordpress.org/trunk@49648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-08 16:55:07 +00:00
gziolo
a756900974 Editor: Support filtering arguments in block type registration from metadata
Adds 2 new hooks in `register_block_type_from_metadata`:

- Named `block_type_metadata` to filter the content of metadata read from `block.json`
- Named `block_type_metadata_settings` to filter the settings object determined from the metadata that is passed to `register_block_type` call

Props swissspidy.
Fixes #52138.


Built from https://develop.svn.wordpress.org/trunk@49948


git-svn-id: http://core.svn.wordpress.org/trunk@49647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-08 16:45:07 +00:00
John Blackbourn
2be70e8aa4 Taxonomy: Correct and clarify documentation for the return types of term query functions.
See #51800, #38266

Built from https://develop.svn.wordpress.org/trunk@49947


git-svn-id: http://core.svn.wordpress.org/trunk@49646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-08 15:24:07 +00:00
John Blackbourn
6f3a940e64 Plugins: Replace usage of $this in action and filter parameter docblocks with more appropriate variable names.
See #51800, #52217

Fixes #52243

Built from https://develop.svn.wordpress.org/trunk@49946


git-svn-id: http://core.svn.wordpress.org/trunk@49645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-08 14:30:14 +00:00
John Blackbourn
4fb7dc8429 Login and Registration: Introduce the lostpassword_user_data filter which allows for the user data object during a password reset request to be filtered.
Props marcelo2605

Fixes #51924

Built from https://develop.svn.wordpress.org/trunk@49945


git-svn-id: http://core.svn.wordpress.org/trunk@49644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-07 17:26:09 +00:00
John Blackbourn
bc5b34672c Quick/Bulk Edit: By the power vested in me, I hereby declare the top bulk actions and the bottom bulk actions joined forever in MatrimonyScript.
This joyous marriage means that users will no longer find a selected top bulk action on a list table unexpectedly being applied instead of their selected bottom bulk action. The top and bottom controls for changing user roles are equally wedded forever too.

Props clayray, subrataemfluence, garrett-eclipse, pbiron, hareesh-pillai

Fixes #46872

Built from https://develop.svn.wordpress.org/trunk@49944


git-svn-id: http://core.svn.wordpress.org/trunk@49643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-07 16:23:07 +00:00
Sergey Biryukov
7e4a39ba6e Accessibility: Help/About: Use more descriptive link text for the Privacy Policy link on the Privacy screen.
Props audrasjb, carike, mukesh27.
Fixes #52233.
Built from https://develop.svn.wordpress.org/trunk@49943


git-svn-id: http://core.svn.wordpress.org/trunk@49642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-07 16:09:08 +00:00
John Blackbourn
f0078d043e Docs: Miscellaneous docblock corrections and improvements.
See #51800.
Built from https://develop.svn.wordpress.org/trunk@49942


git-svn-id: http://core.svn.wordpress.org/trunk@49641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-07 14:17:11 +00:00
Sergey Biryukov
c38bdce55b Docs: Correct description for wp_parse_list().
The function simply converts a comma- or space-separated list of scalar values to an array and does not perform any sanitization on its own.

Follow-up to [44546].

Props johnjamesjacoby.
See #51800.
Built from https://develop.svn.wordpress.org/trunk@49941


git-svn-id: http://core.svn.wordpress.org/trunk@49640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-06 17:25:07 +00:00
desrosj
05f174acf6 Build/Test Tools: Update UglifyJS to the latest version.
This updates the `uglify-js` package from version `3.6.0` to `3.12.4`.

See #51801.
Built from https://develop.svn.wordpress.org/trunk@49940


git-svn-id: http://core.svn.wordpress.org/trunk@49639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-06 15:29:24 +00:00
desrosj
60a2f144ac Build/Test Tools: Update several NPM packages.
This updates the following packages to the latest versions. 

Updated packages:
- `copy-webpack-plugin` from `5.1.1` to `5.1.2`.
- `grunt` from `1.1.0` to `1.3.0`.
- `grunt-contrib-jshint` from `2.1.0` to `3.0.0`.
- `grunt-contrib-qunit` from `3.1.0` to `4.0.0`.
- `grunt-rtlcss` from `2.0.1` to `2.0.2`.
- `qunit` from `2.9.0` to `2.13.0`.
- `sinon` from `9.0.0` to `9.2.2`.
- `source-map-loader` from `0.2.4` to `1.1.3`.
- `uuid` from `8.2.0` to `8.3.2`.
- `webpack-dev-server` from `3.11.0` to `3.11.1`.

See #51801.
Built from https://develop.svn.wordpress.org/trunk@49939


git-svn-id: http://core.svn.wordpress.org/trunk@49638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-06 14:53:40 +00:00
desrosj
4df3473b3b Build/Test Tools: Simplify Composer package caching.
This simplifies the caching of Composer dependencies in the coding standards and PHP compatibility workflows by using a published action. This combines 3 steps into 1 within these workflows.

Because the Composer implementation within the PHPUnit test workflow is a bit specialized (`composer install` is run within the Docker container), caching has been left as is in that workflow. However, the cache key has been changed to include the version of PHP being tested. This will prevent incorrect versions of dependencies being present when they are required on jobs other than PHP 8.

Props jrf.
See #50401.
Built from https://develop.svn.wordpress.org/trunk@49938


git-svn-id: http://core.svn.wordpress.org/trunk@49637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-05 19:23:02 +00:00
desrosj
ed087258e3 Build/Test Tools: Update some NPM packages.
This updates the following packages to the latest versions. 

Updated packages:
- `check-node-version` from `4.0.1` to `4.0.3`.
- `node-sass` from `4.14.1` to `5.0.0`.
- `wait-on` from `3.3.0` to `5.2.1`.

See #51801.
Built from https://develop.svn.wordpress.org/trunk@49937


git-svn-id: http://core.svn.wordpress.org/trunk@49636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-05 19:13:35 +00:00
John Blackbourn
b59c0f307b Docs: Corrections and improvements to types used in various docblocks.
See #51800, #52217

Built from https://develop.svn.wordpress.org/trunk@49936


git-svn-id: http://core.svn.wordpress.org/trunk@49635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-05 17:16:11 +00:00
Sergey Biryukov
7ced0efbf4 Docs: Use more consistent descriptions for void|false return values.
See #51800.
Built from https://develop.svn.wordpress.org/trunk@49935


git-svn-id: http://core.svn.wordpress.org/trunk@49634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-05 16:48:07 +00:00
Sergey Biryukov
43bc55f38d Docs: Fix typo in wp_set_comment_status filter DocBlock.
Follow-up to [49926].

See #51800.
Built from https://develop.svn.wordpress.org/trunk@49934


git-svn-id: http://core.svn.wordpress.org/trunk@49633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-05 16:46:10 +00:00
desrosj
0147765a7c Build/Test Tools: Update several NPM packages.
This updates the following packages to the latest versions. 

Updated packages:
- `grunt-contrib-uglify` from `4.0.1` to `5.0.0`.
- `grunt-jsdoc` from `2.4.0` to `2.4.1`.
- `grunt-legacy-util` from `1.1.1` to `2.0.0`.
- `grunt-webpack` from `3.1.3` to `4.0.2`.

See #51801.
Built from https://develop.svn.wordpress.org/trunk@49933


git-svn-id: http://core.svn.wordpress.org/trunk@49632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-05 15:34:26 +00:00
Peter Wilson
972c42288a Tests: Increase use of shared fixtures in capability checks.
See #51802.

Built from https://develop.svn.wordpress.org/trunk@49932


git-svn-id: http://core.svn.wordpress.org/trunk@49631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-04 23:34:12 +00:00
desrosj
79dc525f28 Build/Test Tools: Change the frequency of code coverage reporting.
Before the coverage reports were submitted to Codecov.io, HTML coverage reports were compressed into ZIP files and uploaded to the workflow run as an artifact. A weekly schedule was chosen to run this workflow because generating a coverage report is more time consuming, and the resulting reports are quite large (~150-200MB each).

This changes the schedule for the code coverage workflow from weekly to daily and eliminates the ZIP artifacts that were previously generated. This will ensure the code coverage data found at https://codecov.io/gh/WordPress/wordpress-develop is relatively accurate on any given day of the week without needlessly consuming artifact storage.

Props jorbin.
See #50401, #52141.
Built from https://develop.svn.wordpress.org/trunk@49931


git-svn-id: http://core.svn.wordpress.org/trunk@49630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-04 19:48:05 +00:00
Sergey Biryukov
de0ff7d845 Twenty Twenty-One: Make sure filtering attachment image attributes only affects front end and not the admin area.
Props denisco.
Fixes #52212.
Built from https://develop.svn.wordpress.org/trunk@49930


git-svn-id: http://core.svn.wordpress.org/trunk@49629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-04 17:45:06 +00:00
Sergey Biryukov
37662df05e Docs: In various @return tags, list the expected type first, instead of false or WP_Error.
Follow-up to [46696], [47060], [49926], [49927].

See #51800.
Built from https://develop.svn.wordpress.org/trunk@49929


git-svn-id: http://core.svn.wordpress.org/trunk@49628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-04 17:18:04 +00:00
Sergey Biryukov
f4d610310c Docs: Synchronize and correct documentation for has_filter() and WP_Hook::has_filter().
`WP_Hook::has_filter()` returns true if `$function_to_check` is omitted and the hook being checked has one or more registered callbacks.

Follow-up to [49927].

See #51800.
Built from https://develop.svn.wordpress.org/trunk@49928


git-svn-id: http://core.svn.wordpress.org/trunk@49627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-04 16:58:08 +00:00
John Blackbourn
dfe1f9b322 Docs: Promote many bool types to true or false where only that value is used.
See #51800

Built from https://develop.svn.wordpress.org/trunk@49927


git-svn-id: http://core.svn.wordpress.org/trunk@49626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-03 22:04:04 +00:00
John Blackbourn
53da9208dd Docs: Various docblock corrections particularly relating to boolean types.
See #51800

Built from https://develop.svn.wordpress.org/trunk@49926


git-svn-id: http://core.svn.wordpress.org/trunk@49625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-03 21:57:09 +00:00
TimothyBlynJacobs
bf51961e7e REST API: Expose all themes in the themes controller.
Previously, only the active theme was made available. This commit allows for all themes to be queried if the user has the `switch_themes` or `manage_network_themes` capabilities.

This commit also no longer exposes the `page`, `per_page`, `search` and `context` query parameters since they are not supported by this controller.

Props spacedmonkey, lpawlik, TimothyBlynJacobs.
Fixes #50152.

Built from https://develop.svn.wordpress.org/trunk@49925


git-svn-id: http://core.svn.wordpress.org/trunk@49624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-03 21:47:05 +00:00
Sergey Biryukov
d495eb4548 Canonical: Check if the post type exists when attempting a canonical redirect.
This avoids a PHP notice if the post type is no longer registered.

Follow-up to [14595], [35480].

Props bobbingwide, hareesh-pillai.
Fixes #40309.
Built from https://develop.svn.wordpress.org/trunk@49924


git-svn-id: http://core.svn.wordpress.org/trunk@49623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-03 17:56:06 +00:00
TimothyBlynJacobs
7d4a40f4ee REST API: Move the WP_Query args filter after the tax_query is setup.
This ensures that the entire list of `WP_Query` args are filterable in the posts controller.

Props Krstarica, TimothyBlynJacobs.
Fixes #42762.

Built from https://develop.svn.wordpress.org/trunk@49923


git-svn-id: http://core.svn.wordpress.org/trunk@49622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-03 02:39:11 +00:00
TimothyBlynJacobs
4e3c568fb1 REST API: Only include the controller's own taxonomy in it's schema.
Previously, all taxonomies were incorrectly exposed as possible values.

Props johnbillion.
Fixes #51940.

Built from https://develop.svn.wordpress.org/trunk@49922


git-svn-id: http://core.svn.wordpress.org/trunk@49621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-02 23:49:05 +00:00
TimothyBlynJacobs
5363474e5d App Passwords: Ensure the Add New button isn't hidden on mobile.
Also removes an unnecessary `!important` rule introduced in [49772] when fixing a similar issue.

Props vladytimy, mukesh27.
Fixes #51980.
See [49772].

Built from https://develop.svn.wordpress.org/trunk@49921


git-svn-id: http://core.svn.wordpress.org/trunk@49620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-02 22:36:05 +00:00
TimothyBlynJacobs
6d3109dd2a App Passwords: Correct authorize app action names and signatures.
When App Passwords was introduced, the `wp_authorize_application_password_form` and `wp_application_passwords_approve_app_request_success` hook were mistakenly duplicated and incorrectly documented. This commit corrects the hook names and ensures the correct parameters are passed.

Props johnbillion, engahmeds3ed.
Fixes #52013.

Built from https://develop.svn.wordpress.org/trunk@49920


git-svn-id: http://core.svn.wordpress.org/trunk@49619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-02 22:21:04 +00:00
TimothyBlynJacobs
fa88bbfc79 App Passwords: Only attempt auth if the username and password are set.
Previously, only the username was checked which caused a PHP warning in some server setups, for instance Shibboleth SSO, where the server only populates the `PHP_AUTH_USER` field.

Props MadtownLems, johnbillion, richard.tape, engahmeds3ed.
Fixes #52003.

Built from https://develop.svn.wordpress.org/trunk@49919


git-svn-id: http://core.svn.wordpress.org/trunk@49618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-02 21:35:04 +00:00
TimothyBlynJacobs
c56eb69d7d REST API: Properly display JSON encoding errors.
Previously `null` was returned because the server was accessing the incorrect variable.

Props atimmer, technosailor.
Fixes #52106.

Built from https://develop.svn.wordpress.org/trunk@49918


git-svn-id: http://core.svn.wordpress.org/trunk@49617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-02 20:36:06 +00:00
TimothyBlynJacobs
33cb202f07 Site Health: Use a front-end URL for loopback tests.
In [49154] the async Site Health tests were changed to use the REST API instead of admin-ajax. An unintended side effect of this change was that the loopback tests which tried to ping the site's `admin_url()` were no longer authenticated because admin-cookies aren't provided to the REST API.

This commit adjusts the loopback test to use the front-end `site_url` which checks that cron will function properly. A follow-up ticket will focus on tests that will cover the file editor checks.

Props Clorith.
Fixes #52097.
See #48105.

Built from https://develop.svn.wordpress.org/trunk@49917


git-svn-id: http://core.svn.wordpress.org/trunk@49616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-02 20:09:08 +00:00
Sergey Biryukov
e596f54ecc Build/Test Tools: Check if Travis/GitHub Actions environment variables are defined.
This adjusts the logic for determining whether to skip some tests when not in the primary branch, and allows for running these tests locally.

Follow-up to [47000], [47001], [49264], [49267], [49280].

See #50401.
Built from https://develop.svn.wordpress.org/trunk@49916


git-svn-id: http://core.svn.wordpress.org/trunk@49615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-02 12:21:06 +00:00
Sergey Biryukov
8c8af01d86 Happy New Year!
Update copyright year to 2021 in `license.txt` and bundled themes.
Built from https://develop.svn.wordpress.org/trunk@49915


git-svn-id: http://core.svn.wordpress.org/trunk@49614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-01-01 00:19:07 +00:00
Sergey Biryukov
2818d14fa8 Twenty Twenty-One: Remove extra brackets from :last-child CSS pseudo-class.
Props munyagu, mukesh27, activecoder.
Fixes #52176.
Built from https://develop.svn.wordpress.org/trunk@49914


git-svn-id: http://core.svn.wordpress.org/trunk@49613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-31 07:38:06 +00:00
Sergey Biryukov
25441f33f8 Tests: Disable update checks while running REST API plugin installation tests.
This prevents external HTTP requests that are not required for the tests in question and may interfere with the results in case of a timeout.

Follow-up to [48242], [49491].

See #51669.
Built from https://develop.svn.wordpress.org/trunk@49913


git-svn-id: http://core.svn.wordpress.org/trunk@49612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-30 19:04:10 +00:00
Sergey Biryukov
ee7c953731 Docs: Second pass at replacing Codex URLs with a corresponding HelpHub or DevHub article.
Follow-up to [45674-45677].

Props marcio-zebedeu, zodiac1978, netweb.
See #48987.
Built from https://develop.svn.wordpress.org/trunk@49912


git-svn-id: http://core.svn.wordpress.org/trunk@49611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-29 20:14:11 +00:00
Andrew Ozz
0f0b303d5a Editor: Trigger the tinymce-editor-init custom jQuery event on DOM ready. Otherwise TinyMCE may initialize earlier and handlers attached on DOM ready may not get triggered. Fixes making the editor menu "sticky" and setting/resetting some screen options on the old Edit Post screen.
Fixes 52046, 51995.
Built from https://develop.svn.wordpress.org/trunk@49911


git-svn-id: http://core.svn.wordpress.org/trunk@49610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-29 13:21:07 +00:00
Sergey Biryukov
fa83e92c76 Export: Add post_modified and post_modified_gmt fields to the generated WXR export file.
This allows for more flexibility when determining which version of a post is the latest one, and makes it possible to implement import logic involving updating and adding revisions to existing posts or pages.

Props jmdodd.
Fixes #52180.
Built from https://develop.svn.wordpress.org/trunk@49910


git-svn-id: http://core.svn.wordpress.org/trunk@49609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-28 15:26:08 +00:00
Gary Pendergast
4dc59b954a Site Health: Check that WordPress is installed before scheduling the HTTPS cron.
Trying to schedule cron jobs before WordPress is installed results in DB errors, which is suboptimal.

See #47577.


Built from https://develop.svn.wordpress.org/trunk@49909


git-svn-id: http://core.svn.wordpress.org/trunk@49608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-28 01:45:06 +00:00
Sergey Biryukov
1fd05dee6e Site Health: Add WP_MEMORY_LIMIT constant to debug info.
This complements the `WP_MAX_MEMORY_LIMIT` constant previously displayed there.

Props sanketchodavadiya, nre, talldanwp, noisysocks.
Fixes #51680.
Built from https://develop.svn.wordpress.org/trunk@49908


git-svn-id: http://core.svn.wordpress.org/trunk@49607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-27 19:27:06 +00:00
Sergey Biryukov
3f05756219 Accessibility: Upgrade/Install: Add more contrast to input borders during installation.
This brings the accessibility improvements previously made for other areas of the admin in WordPress 5.3 to the installation screens too.

Follow-up to [46241-46244], [46247], [46248], [46293], [46425].

Props Maigret, audrasjb.
Fixes #51854.
Built from https://develop.svn.wordpress.org/trunk@49907


git-svn-id: http://core.svn.wordpress.org/trunk@49606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-26 19:54:07 +00:00
Sergey Biryukov
c3b89441f7 Docs: Correct the type of the $user parameter in WP_REST_Users_Controller::prepare_links().
Props iviweb, mukesh27.
Fixes #52175.
Built from https://develop.svn.wordpress.org/trunk@49906


git-svn-id: http://core.svn.wordpress.org/trunk@49605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-25 14:54:07 +00:00
Sergey Biryukov
5a7fa8b7f3 Posts, Post Types: Correct the check for term IDs to be queued for lazy-loading term meta.
This ensures that the `$term_ids` array in `wp_queue_posts_for_term_meta_lazyload()` (an indexed array not keyed by ID) does not contain duplicate values.

Props denishua, akabarikalpesh.
Fixes #52144.
Built from https://develop.svn.wordpress.org/trunk@49905


git-svn-id: http://core.svn.wordpress.org/trunk@49604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-24 11:21:04 +00:00
Felix Arntz
c81db1f6e6 Security, Site Health: Detect HTTPS support and encourage switching.
This changeset modifies the Site Health panel for HTTPS to provide more accurate recommendations based on whether the environment is already set up for HTTPS.

* Introduces `wp_is_using_https()` to check whether the site is configured to use HTTPS (via its Site Address and WordPress Address).
* Introduces `wp_is_https_supported()` to check whether the environment supports HTTPS. This relies on a cron job which periodically checks support using a loopback request.

Props Clorith, flixos90, miinasikk, westonruter.
Fixes #47577.

Built from https://develop.svn.wordpress.org/trunk@49904


git-svn-id: http://core.svn.wordpress.org/trunk@49603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-23 19:13:04 +00:00
Aaron Jorbin
9f4be0f698 Build/Test: Send Code Coverage reports to Codecov.
Help visualize and explore code coverage reports to avoid blunders.

Props desrosj, swissspidy.
Fixes #52141.


Built from https://develop.svn.wordpress.org/trunk@49903


git-svn-id: http://core.svn.wordpress.org/trunk@49602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-23 18:19:05 +00:00
Sergey Biryukov
4a91698129 Tests: Correct @ticket references in tests/query/invalidQueries.php.
This ensures that running `phpunit --group 48556` works as expected.

Follow-up to [49900].

See #48556.
Built from https://develop.svn.wordpress.org/trunk@49902


git-svn-id: http://core.svn.wordpress.org/trunk@49601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-23 15:07:03 +00:00
Sergey Biryukov
c18ec08dbb Twenty Nineteen: Correct @since version for twentynineteen_excerpt_more().
Follow-up to [49831].

See #46177.
Built from https://develop.svn.wordpress.org/trunk@49901


git-svn-id: http://core.svn.wordpress.org/trunk@49600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-23 15:05:08 +00:00
Peter Wilson
c50ff2ac10 Query: Add bad path tests with invalid WP_Query parameters.
See #48556.

Built from https://develop.svn.wordpress.org/trunk@49900


git-svn-id: http://core.svn.wordpress.org/trunk@49599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-23 03:05:06 +00:00
Peter Wilson
aaf7710529 Query: Revert post-type specific capability changes.
The modified checks of the `read_private_posts` capability could result in unexpected SQL queries when calling `WP_Query` with invalid parameters.

Reverts [49830], [49832] and [49833].
See #48556.

Built from https://develop.svn.wordpress.org/trunk@49899


git-svn-id: http://core.svn.wordpress.org/trunk@49598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-23 03:02:06 +00:00
desrosj
7c8d9b2e6a Build/Test Tools: Remove the TravisCI configuration file.
In [49162], GitHub Action workflow configuration files were introduced to run all of Core’s automated testing with the intent to fully transition after some time was allowed for testing.

After two full months of testing, the time to finish this transition has come.

We thank TravisCI for testing the codebase through nearly 20 major and many more minor releases.

Fixes #52161. See #50401.
Built from https://develop.svn.wordpress.org/trunk@49876


git-svn-id: http://core.svn.wordpress.org/trunk@49595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-22 21:01:10 +00:00
desrosj
51ca44d9c7 Bundled Themes: Bump the versions of Twenty Twenty-One and Twenty Nineteen.
New versions:

- Twenty Twenty-One: 1.1.
- Twenty Nineteen: 1.9.

Props poena.
Fixes #52160.
Built from https://develop.svn.wordpress.org/trunk@49873


git-svn-id: http://core.svn.wordpress.org/trunk@49592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-22 18:19:05 +00:00
desrosj
0111002414 Twenty Nineteen: Add the block-patterns tag to the appropriate SASS file.
This prevents the tag from being removed from `styles.css` when rebuilding the CSS.

Props danfarrow
Fixes #52159.
Built from https://develop.svn.wordpress.org/trunk@49872


git-svn-id: http://core.svn.wordpress.org/trunk@49591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-22 18:15:09 +00:00
ryelle
f8e65a20b6 Twenty Twenty-One: Set a maximum width on inputs.
Text inputs with a size attribute can end up longer than the screen width on small screens. A max-width of 100% keeps the inputs from breaking out of the container.

Props basscan, kjellr, poena, sabernhardt
Fixes #52083.


Built from https://develop.svn.wordpress.org/trunk@49870


git-svn-id: http://core.svn.wordpress.org/trunk@49589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-22 16:53:06 +00:00
desrosj
de18e6c5a2 Twenty Twenty-One: Improve strings found in post navigations for easier translating.
This change adjusts strings found within post navigations to ensure translators are provided the full context needed to properly translate.

Props poena, SergeyBiryukov, aristath.
Fixes #52047.
Built from https://develop.svn.wordpress.org/trunk@49866


git-svn-id: http://core.svn.wordpress.org/trunk@49585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-22 16:15:06 +00:00
desrosj
b0fe9f059c Twenty Twenty-One: Only load IE specific polyfills when actually using Internet Exploreer.
The `twenty-twenty-one-ie11-polyfills` script now has a `null` source, and the new `twenty-twenty-one-ie11-polyfills-asset` (which points to the actual `polyfills.js` source) will be loaded only if IE is detected by through the use of `wp_get_script_polyfill()`.

Because the original script name remains the same, this change is backwards compatible with any code registering `twenty-twenty-one-id11-polyfills` as a script dependency.

Props poena, ismail.elkorchi, peterwilsoncc
Fixes #52098.
Built from https://develop.svn.wordpress.org/trunk@49865


git-svn-id: http://core.svn.wordpress.org/trunk@49584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-22 15:44:08 +00:00
desrosj
c58be3c57e Twenty Twenty-One: Improve striped table styling in Dark Mode.
This change improves the display of table blocks with the “Stripes” style selected.

Previously, the text was not visible in striped rows when using Dark Mode.

Props ryelle, poena, melchoyce, celendesign, audrasjb.
Fixes #52129.
Built from https://develop.svn.wordpress.org/trunk@49864


git-svn-id: http://core.svn.wordpress.org/trunk@49583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-22 15:02:05 +00:00
Sergey Biryukov
aedf6c6443 Tests: Use shared post fixture in comment template tests.
This reinstates [49848], previously reverted in [49849], with the addition of `static` keyword for the `wpSetUpBeforeClass()` method, allowing the tests to pass on PHP 8.

Props peterwilsoncc.
See #51802.
Built from https://develop.svn.wordpress.org/trunk@49863


git-svn-id: http://core.svn.wordpress.org/trunk@49582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-22 07:44:06 +00:00
John Blackbourn
ec80a9fd63 XML-RPC: Emit an appropriate HTTP status code when an error is returned in response to an XML-RPC request.
This most notably affects the response when XML-RPC is disabled or when the supplied username and password is incorrect.

Props ericmann

Fixes #48213

Built from https://develop.svn.wordpress.org/trunk@49862


git-svn-id: http://core.svn.wordpress.org/trunk@49581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-21 20:23:02 +00:00
desrosj
b8e5751dd1 Twenty Twenty-One: Do not specify loading=“eager” for single post thumbnails.
While `loading=“eager”` is a supported alternative to omitting the attribute entirely, browsers follow the value of this attribute explicitly when specified.

Specifying `eager` would prevent the user from receiving any additional potential benefits implemented at the browser level, such as further mechanisms to automatically decide which elements to lazy-load.

Props flixos90, ryelle, poena.
Fixes #52139.
Built from https://develop.svn.wordpress.org/trunk@49860


git-svn-id: http://core.svn.wordpress.org/trunk@49579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-21 18:39:03 +00:00
Sergey Biryukov
1d3fd41977 Docs: Move locale filter documentation to the canonical place.
See #51800.
Built from https://develop.svn.wordpress.org/trunk@49859


git-svn-id: http://core.svn.wordpress.org/trunk@49578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-21 18:27:04 +00:00
Sergey Biryukov
5550b5fd6a Docs: Move sanitize_file_name filter documentation to the canonical place.
See #51800.
Built from https://develop.svn.wordpress.org/trunk@49858


git-svn-id: http://core.svn.wordpress.org/trunk@49577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-21 18:25:05 +00:00
John Blackbourn
f508fe5112 Build/Test Tools: Don't mark the Tests_Cache::test_flush() test as risky when running the test suite with an object cache in place.
See #51802

Built from https://develop.svn.wordpress.org/trunk@49857


git-svn-id: http://core.svn.wordpress.org/trunk@49576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-21 17:51:07 +00:00
John Blackbourn
cc2dd60fe1 XML-RPC: Fix a type error when requesting the menu field of a taxonomy.
Fixes #51493

Built from https://develop.svn.wordpress.org/trunk@49856


git-svn-id: http://core.svn.wordpress.org/trunk@49575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-21 17:11:05 +00:00
desrosj
55209a7309 Twenty Twenty-One: Allow local anchor links to be used in primary navigation.
This adds some JavaScript to detect when an anchor link is clicked within the primary navigation on mobile devices and closes the menu before scrolling to the location on the page.

Props poena, macmanx, t-p.
Fixes #52006.
Built from https://develop.svn.wordpress.org/trunk@49854


git-svn-id: http://core.svn.wordpress.org/trunk@49573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-21 15:05:08 +00:00
gziolo
671d5da0e4 Blocks: Align with Gutenberg the name of generated asset handle for core blocks
Related Gutenberg PR: https://github.com/WordPress/gutenberg/pull/25220.

It aligns with the latest changes added by aristath to the Gutenberg project. As part of styles splitting for core blocks, there was a special pattern introduced for how style handles are named. Ideally, we would apply it to all blocks but there might be some backward compatibility considerations so I left the handling for non-core blocks unchanged.

Props aristath.
See #50328.


Built from https://develop.svn.wordpress.org/trunk@49850


git-svn-id: http://core.svn.wordpress.org/trunk@49569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-21 11:39:08 +00:00
Peter Wilson
65351d3908 Tests: Revert use of shared post fixture in comment template tests.
Removes code throwing a fatal in PHP 8.

Reverts [49848] from trunk.
See #51802.

Built from https://develop.svn.wordpress.org/trunk@49849


git-svn-id: http://core.svn.wordpress.org/trunk@49568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-21 03:35:04 +00:00
Peter Wilson
c56ec035ce Tests: Use shared post fixture in comment template tests.
See #51802.

Built from https://develop.svn.wordpress.org/trunk@49848


git-svn-id: http://core.svn.wordpress.org/trunk@49567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-21 03:17:01 +00:00
Peter Wilson
7a3d769b0f Query: Correct some coding standards after [49843].
See #44183

Built from https://develop.svn.wordpress.org/trunk@49847


git-svn-id: http://core.svn.wordpress.org/trunk@49566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-21 02:56:05 +00:00
John Blackbourn
8bc6a4ae6d Query: Correct some coding standards after [49843].
See #44183
Built from https://develop.svn.wordpress.org/trunk@49846


git-svn-id: http://core.svn.wordpress.org/trunk@49565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-21 00:33:08 +00:00
John Blackbourn
e7cc15b321 Upload: Introduce the {$action}_overrides filter that allows the overrides parameter for file uploads and file sideloads to be filtered.
The dynamic portion of the hook name, `$action`, refers to the post action.

Props iandunn, jakub.tyrcha, nacin, wonderboymusic, Mte90, johnbillion

Fixes #16849

Built from https://develop.svn.wordpress.org/trunk@49845


git-svn-id: http://core.svn.wordpress.org/trunk@49564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-20 16:15:03 +00:00
John Blackbourn
f0d44a3402 Mail: Introduce a pre_wp_mail filter to allow short-circuiting the wp_mail() function without having to override the pluggable function.
Props DvanKooten, swissspidy, SergeyBiryukov, jtsternberg, ericlewis, Mte90, birgire, ayeshrajans

Fixes #35069

Built from https://develop.svn.wordpress.org/trunk@49844


git-svn-id: http://core.svn.wordpress.org/trunk@49563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-20 15:09:06 +00:00
John Blackbourn
5007f1ce13 Query: Ensure the author archive title always shows the name of the queried author, regardless of whether there are results.
This brings the behaviour inline with the `<title>` element of the page which always shows the author name.

Props Tkama, subrataemfluence

Fixes #44183

Built from https://develop.svn.wordpress.org/trunk@49843


git-svn-id: http://core.svn.wordpress.org/trunk@49562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-20 14:37:04 +00:00
Sergey Biryukov
0fe844c9c9 Docs: Use a canonical form of "knowledgeable" in readme.html.
Props shahinsid07, audrasjb.
Fixes #52125.
Built from https://develop.svn.wordpress.org/trunk@49842


git-svn-id: http://core.svn.wordpress.org/trunk@49561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-20 12:58:02 +00:00
Sergey Biryukov
0e700c40ea Docs: Fix typo in getCursorMarkerSpan() DocBlock in js/_enqueues/wp/editor/base.js.
Props voboghure, mukesh27, audrasjb.
Fixes #52128.
Built from https://develop.svn.wordpress.org/trunk@49841


git-svn-id: http://core.svn.wordpress.org/trunk@49560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-20 12:32:11 +00:00
Sergey Biryukov
e4dfced545 Twenty Ten: Correct $post_title variable name in loop-attachment.php.
Follow-up to [45609] / #47632.

Props sabernhardt.
Fixes #52121.
Built from https://develop.svn.wordpress.org/trunk@49840


git-svn-id: http://core.svn.wordpress.org/trunk@49559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-19 20:45:05 +00:00
Sergey Biryukov
08e11dc1e6 Twenty Twenty-One: Clarify a sentence in readme.txt.
Props gkibria69.
Fixes #52120.
Built from https://develop.svn.wordpress.org/trunk@49838


git-svn-id: http://core.svn.wordpress.org/trunk@49557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-19 20:36:06 +00:00
Sergey Biryukov
41c9686313 Docs: Update the reference to Appearance → Theme Editor admin menu item in the inline documentation.
Follow-up to [42685].

See #51800.
Built from https://develop.svn.wordpress.org/trunk@49837


git-svn-id: http://core.svn.wordpress.org/trunk@49556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-18 15:46:04 +00:00
desrosj
24d77a5793 Build/Test Tools: Support the use of MariaDB in the local Docker environment.
In addition to MySQL, WordPress also supports MariaDB for databases. This makes changes to the local Docker environment to allow MariaDB to be used instead, if desired.

The `LOCAL_DB_TYPE` environment variable will now be used to determine which type of database container to use. This will default to `mysql`, but will also accept `mariadb`.

The `LOCAL_MYSQL` environment variable (which previously held the version of MySQL to use) has been replaced with the new, more generic `LOCAL_DB_VERSION` environment variable.

This change will make it possible to perform automated testing on a wider array of supported database types and versions.

Props davidbaumwald.
Fixes #51744. See #30462.
Built from https://develop.svn.wordpress.org/trunk@49836


git-svn-id: http://core.svn.wordpress.org/trunk@49555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-18 15:29:03 +00:00
desrosj
fcb36e86bb Build/Test Tools: Run the Ajax test group for multisite.
This will help catch issues with Ajax related functionality on multisite.

A few tests have also been marked as `skipWithMultisite()` as they require network admin level capabilities when performing the same operations on a multisite install.

Props garrett-eclipse, netweb.
Fixes #46567.
Built from https://develop.svn.wordpress.org/trunk@49835


git-svn-id: http://core.svn.wordpress.org/trunk@49554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-18 14:40:10 +00:00
desrosj
670500c739 Build/Test Tools: Generate a code coverage report using GitHub Actions.
This introduces a new GitHub Action workflow to generate a code coverage report when running the PHPUnit test suite as both a single and multisite install.

The workflow will run once per week on Sunday at 00:00 UTC.

For now, the reports are not submitted anywhere, but they will be uploaded to the workflow run as ZIP file artifacts where they will persist for 90 days.

Making code coverage reports more readily available will hopefully better highlight areas of Core with poor coverage, and encourage more contributors to help increase test coverage of those areas.

Props ocean90, johnbillion.
Fixes #52034.
Built from https://develop.svn.wordpress.org/trunk@49834


git-svn-id: http://core.svn.wordpress.org/trunk@49553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-18 00:30:06 +00:00
Peter Wilson
343b375097 Coding Standards: Minor fixes following [49830].
Fixes the fixes missed in [49832]. They are fixed now.

See #13509, #48968, #48556.

Built from https://develop.svn.wordpress.org/trunk@49833


git-svn-id: http://core.svn.wordpress.org/trunk@49552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-18 00:28:03 +00:00
Peter Wilson
08acf6606a Coding Standards: Minor fixes following [49830].
See #13509, #48968, #48556.

Built from https://develop.svn.wordpress.org/trunk@49832


git-svn-id: http://core.svn.wordpress.org/trunk@49551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-18 00:19:05 +00:00
Sergey Biryukov
fa7e570e2a Twenty Nineteen: Add "Continue reading" link for post excerpts.
This ensures that archive pages have a meaningful link text after the excerpts.

Props metalandcoffee, alex27, sabernhardt, mdrockwell, laurelfulford.
Fixes #46177.
Built from https://develop.svn.wordpress.org/trunk@49831


git-svn-id: http://core.svn.wordpress.org/trunk@49550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-17 18:21:05 +00:00
Boone Gorges
f124a2e529 Query: Respect post-type specific capabilities when querying for multiple post types.
After this change, the relevant `read_private_posts` capability is checked for
each queried post type. This ensures that private posts appear in search and
archive queries for users who have the ability to view those posts.

Props leogermani.

Fixes #13509, #48968, #48556.
Built from https://develop.svn.wordpress.org/trunk@49830


git-svn-id: http://core.svn.wordpress.org/trunk@49549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-17 16:17:07 +00:00
desrosj
6daeadb85e Twenty Twenty-One: Correct @since inline documentation tags.
Previously, `1.0.0` was used for the version. This is inconsistent with the versioning used in the other default themes, which use use X.X and not X.X.X.

This change corrects all `1.0.0` occurrences to `1.0`, and adds the additional context of `Twenty Twenty-One` to avoid confusion with `WordPress 1.0`.

Props SergeyBiryukov, poena.
Fixes #51958.
Built from https://develop.svn.wordpress.org/trunk@49826


git-svn-id: http://core.svn.wordpress.org/trunk@49545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-17 14:57:07 +00:00
desrosj
66d46430a7 Twenty Twenty-One: Make text within code blocks readable in Dark Mode.
This change ensures that the primary text color specific to Dark Mode is used instead of the one specified for normal mode. The latter is not legible in Dark Mode.

Props slaFFik, poena, mukesh27, justinahinon.
Fixes #51985.
Built from https://develop.svn.wordpress.org/trunk@49825


git-svn-id: http://core.svn.wordpress.org/trunk@49544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-17 14:22:05 +00:00
desrosj
b7a899e8aa Twenty Twenty-One: Prevent <iframe> embeds from being too narrow.
This fixes an issue where `<iframe>` embeds were being pushed to the side of the screen and compressed to the point of being unusable.

Props helen, mukesh27, poena, thorlentz.
Fixes #52004.
Built from https://develop.svn.wordpress.org/trunk@49823


git-svn-id: http://core.svn.wordpress.org/trunk@49542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-17 14:05:05 +00:00
desrosj
3dce40e526 Build/Test Tools: Save changes resulting from npm install.
See #51801.
Built from https://develop.svn.wordpress.org/trunk@49822


git-svn-id: http://core.svn.wordpress.org/trunk@49541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-17 13:59:08 +00:00
Felix Arntz
bb234abee7 Media: Enable lazy-loading of iframes by adding the loading="lazy" attribute to iframe tags on the front-end.
* Expands the capabilities of `wp_filter_content_tags()` to add the attribute to iframe tags if enabled.
* Modifies the default behavior of `wp_lazy_loading_enabled()` so that it returns `true` for `iframe` tags.
* Introduces a `wp_iframe_tag_add_loading_attr()` function.
* Introduces a `wp_iframe_tag_add_loading_attr` filter.

Like for images, the attribute is only added to iframes which have both `width` and `height` specified (see related #50367).

Props azaozz, flixos90, westonruter.
Fixes #50756.

Built from https://develop.svn.wordpress.org/trunk@49808


git-svn-id: http://core.svn.wordpress.org/trunk@49531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-16 21:19:07 +00:00
Andrew Ozz
71ae342050 Editor: Fix improper triggering of the "Are you sure" prompt when navigating away from the old, "classic" Edit Post screen and there are no changes. Was triggered when there is an instance of TinyMCE in the Excerpt postbox.
Props rodrigosprimo, jonathanstegall, kevin940726, azaozz.
Fixes #52038.
Built from https://develop.svn.wordpress.org/trunk@49807


git-svn-id: http://core.svn.wordpress.org/trunk@49530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-16 15:25:09 +00:00
iandunn
2ebc78cbf4 Feed: Replace join() with implode() for safety.
Canonical functions should be used instead of aliases, because aliases can be deprecated or removed withough much notice. See r49193.

Props SergeyBiryukov.
See #51056.

Built from https://develop.svn.wordpress.org/trunk@49805


git-svn-id: http://core.svn.wordpress.org/trunk@49528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-16 14:05:07 +00:00
Andrew Ozz
734f9bd9e2 Media: Fix the template for the "Align" and "Link To" fields in the media modal when inserting an image from URL.
Props noisysocks, mukesh27.
Fixes #52065.
Built from https://develop.svn.wordpress.org/trunk@49804


git-svn-id: http://core.svn.wordpress.org/trunk@49527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-16 12:45:11 +00:00
iandunn
d544fc7cb4 Feed: Merge multiple header values to avoid fatal error.
When SimplePie parses HTTP headers, it combines multiple values for the same header into a comma-separated string. `WP_SimplePie_File` overrides the parsing, but was leaving them as an array instead.

That lead to a fatal error in PHP 8, because other parts of the codebase ended up passing an array to a function that expected a string.

Props david.binda, litemotiv, inc2734, NicolasKulka, hellofromTonya, mbabker, skithund, SergeyBiryukov, desrosj, timothyblynjacobs.
Fixes #51056. See #51956.


Built from https://develop.svn.wordpress.org/trunk@49803


git-svn-id: http://core.svn.wordpress.org/trunk@49526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-16 00:51:05 +00:00
John Blackbourn
ec900ebb43 Docs: Correct the documentation for the map_meta_cap() function and its filter.
See #51800

Built from https://develop.svn.wordpress.org/trunk@49802


git-svn-id: http://core.svn.wordpress.org/trunk@49525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-15 22:18:07 +00:00
Sergey Biryukov
b8f6d41a2c Twenty Twenty-One: Fix typos in some inline comments.
Props manzurahammed, mukesh27.
Fixes #52071.
Built from https://develop.svn.wordpress.org/trunk@49801


git-svn-id: http://core.svn.wordpress.org/trunk@49524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-15 13:28:06 +00:00
ryelle
da72be5227 Twenty Twenty-One: Bring back PostCSS config.
Twenty Twenty-One uses PostCSS to convert the custom properties for Internet Explorer. Without a config file, the postcss command does nothing, causing issues in IE. This brings back the config from GitHub, which replaces all custom properties with the default values.

Props t-p, poena.
Fixes #52040.


Built from https://develop.svn.wordpress.org/trunk@49800


git-svn-id: http://core.svn.wordpress.org/trunk@49523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-14 16:49:03 +00:00
Sergey Biryukov
71bbd2b166 Twenty Twenty-One: Correct the DocBlock for map-deep-set() Sass function.
Props mukesh27.
Fixes #52064.
Built from https://develop.svn.wordpress.org/trunk@49799


git-svn-id: http://core.svn.wordpress.org/trunk@49522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-14 15:22:09 +00:00
Sergey Biryukov
9494c5fbee Twenty Twenty-One: Use a more specific link for Dark Mode instructions.
Make both instances of the link translatable, for consistency.

Props engahmeds3ed, justinahinon.
Fixes #52010.
Built from https://develop.svn.wordpress.org/trunk@49798


git-svn-id: http://core.svn.wordpress.org/trunk@49521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-13 18:40:06 +00:00
desrosj
3ed22735d3 Build/Test Tools: Allow code coverage reports to be generated when running tests as a multisite.
This adds the information needed to generate a code coverage report to the multisite ruleset.

Fixes #52034.
Built from https://develop.svn.wordpress.org/trunk@49797


git-svn-id: http://core.svn.wordpress.org/trunk@49520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-12 20:09:08 +00:00
desrosj
4d4ec9484c Build/Test Tools: Remove PHPUnit 3.6.x specific settings from the multisite configuration.
In PHPUnit 3.6.x, `exclude` and `file` paths were required to be relative to the checkout root. This changed in PHPUnit 4 when the path requirements were changed require them to be relative to the configuration file.

Since PHPUnit 3.6.x is only used to test on PHP 5.2 in older branches and is no longer supported, these can be safely removed from the configuration file.

See #51802.
Built from https://develop.svn.wordpress.org/trunk@49796


git-svn-id: http://core.svn.wordpress.org/trunk@49519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-12 18:08:02 +00:00
Sergey Biryukov
994167b76f Twenty Twenty-One: Fix typos in some inline comments.
Props tanvirul, mukesh27.
Fixes #52042.
Built from https://develop.svn.wordpress.org/trunk@49795


git-svn-id: http://core.svn.wordpress.org/trunk@49518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-12 15:03:06 +00:00
Sergey Biryukov
4ca3db8c90 Twenty Twenty-One: Correct version in file-header.scss.
Fixes #52044.
Built from https://develop.svn.wordpress.org/trunk@49794


git-svn-id: http://core.svn.wordpress.org/trunk@49517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-12 14:57:07 +00:00
ryelle
bba3a9d529 Twenty Nineteen: Add images for use in block patterns.
The block patterns were added in #51099, but the images were not included in the commit. This adds the images to the expected folder.

Props transl8or, mukesh27.
Fixes #51996.


Built from https://develop.svn.wordpress.org/trunk@49793


git-svn-id: http://core.svn.wordpress.org/trunk@49516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-11 16:55:03 +00:00
Sergey Biryukov
43bbbf1176 Docs: Document the usage of $wpdb global in WP_Query::get_posts() and ::set_found_posts().
Props jontyravi.
Fixes #52027.
Built from https://develop.svn.wordpress.org/trunk@49792


git-svn-id: http://core.svn.wordpress.org/trunk@49515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-11 16:53:10 +00:00
desrosj
e4066a9af8 Build/Test Tools: Update several NPM packages.
These were updated using `npm audit fix`.

See #51801.
Built from https://develop.svn.wordpress.org/trunk@49791


git-svn-id: http://core.svn.wordpress.org/trunk@49514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-11 14:05:07 +00:00
John Blackbourn
bf83c368fd Docs: Various docblock improvements.
See #51800

Built from https://develop.svn.wordpress.org/trunk@49790


git-svn-id: http://core.svn.wordpress.org/trunk@49513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-10 23:59:03 +00:00
John Blackbourn
42fcfa5b3d Docs: Various docblock corrections.
See #51800

Built from https://develop.svn.wordpress.org/trunk@49789


git-svn-id: http://core.svn.wordpress.org/trunk@49512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-10 23:53:07 +00:00
John Blackbourn
7e9060a0e4 Upgrade/Install: Remove a duplicate description for the upgrader_overwrote_package action.
See #51800, #9757

Built from https://develop.svn.wordpress.org/trunk@49788


git-svn-id: http://core.svn.wordpress.org/trunk@49511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-10 23:38:04 +00:00
John Blackbourn
1ead0719b7 Docs: Fix some docblock issues introduced in 5.6.
See #51800

Built from https://develop.svn.wordpress.org/trunk@49787


git-svn-id: http://core.svn.wordpress.org/trunk@49510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-10 23:27:06 +00:00
desrosj
2808e92c43 Build/Test Tools: Reestablish the codebase as a Git repo before reporting test results.
The test reporter uses the hidden `.svn` or `.git` directories to determine which changeset to send to WordPress.org along with the test report.

Because the GitHub Action workflow builds and prepares WordPress in a preceding job to share with each test job, the `.git` directory is missing (it is purposefully not included to limit artifact size).

This re-establishes the directory as a checkout of the `wordpress-develop` repository so that test results can be reported correctly.

See #50401.
Built from https://develop.svn.wordpress.org/trunk@49786


git-svn-id: http://core.svn.wordpress.org/trunk@49509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-10 19:19:06 +00:00
Sergey Biryukov
4a69dfa63a Docs: Fix typo in some DocBlocks.
See #51800.
Built from https://develop.svn.wordpress.org/trunk@49785


git-svn-id: http://core.svn.wordpress.org/trunk@49508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-10 18:12:03 +00:00
desrosj
c0806cf29c Build/Test Tools: Inline documentation updates for the PHPUnit workflow.
See #50401.
Built from https://develop.svn.wordpress.org/trunk@49784


git-svn-id: http://core.svn.wordpress.org/trunk@49507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-10 15:30:04 +00:00
desrosj
66b75f9ad7 Build/Test Tools: Enable reporting of results to WordPress.org.
This configures reporting of the test results to the WordPress.org Host Test Results in the new GitHub Actions workflow for PHPUnit testing.

See https://make.wordpress.org/hosting/test-results/

Props mikeschroder, dd32.
See #50401.
Built from https://develop.svn.wordpress.org/trunk@49783


git-svn-id: http://core.svn.wordpress.org/trunk@49506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-10 14:20:08 +00:00
desrosj
fb4450a86f Build/Test Tools: Use NodeJS 14 in GitHub Action workflows.
14.x is the current LTS release, and is what `trunk` currently runs.

See #50401.
Built from https://develop.svn.wordpress.org/trunk@49782


git-svn-id: http://core.svn.wordpress.org/trunk@49505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-09 20:57:04 +00:00
desrosj
030b4bd1da Build/Test Tools: Disable GitHub Action workflow runs triggered on push for forks and mirrors.
In the current state, the workflows run regardless of the repository context. This results many needless workflow runs that waste resources.

Workflow runs for private repositories are not free (accounts have a finite allotment of minutes for private repositories). This becomes problematic in private repositories that also mirror the WordPress develop repository, as any workflow runs will draw from a user’s or organization’s allotted action minutes.

Without blanket disabling the workflow manually for all event triggers, or modifying the workflow files in the forked/mirrored repository, there is no way to tune when the workflows run.

This change introduces a conditional statement into all GitHub Action workflows that prevents them from running on forked/mirrored repositories that are not `wordpress-develop`, except when a pull request is being submitted to that repository.

The exception to this is the Welcome workflow that posts a helpful message to first time contributors to `wordpress-develop`. This message is specific to this repository, so should only run when a PR is submitted to that repository.

See #50401.
Built from https://develop.svn.wordpress.org/trunk@49781


git-svn-id: http://core.svn.wordpress.org/trunk@49504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-09 20:06:04 +00:00
desrosj
e9feb6fca3 Build/Test Tools: Update package-lock.json file with several package updates.
These updates result from running `npm install`.

Also, update the version of `grunt-patch-wordpress` in the lock file from `3.0.0` to `3.0.1`.

See #51801.
Built from https://develop.svn.wordpress.org/trunk@49780


git-svn-id: http://core.svn.wordpress.org/trunk@49503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-09 19:33:06 +00:00
desrosj
2e90ec8789 Build/Test Tools: Remove the Appveyor configuration file.
Appveyor was added to Core in [44594] to ensure that NPM and the WordPress build tools continue to work correctly on Windows systems as changes are made. Using an additional service for this was required at the time, TravisCI did not support testing on Windows.

[49162] introduced a GitHub Action workflow that performed the same testing. Since all automated testing is moving to GitHub Actions, using Appveyor is no longer necessary, and it’s preferable to have all automated testing in one location as much as possible.

Props ayeshrajans.
Fixes #51968.
Built from https://develop.svn.wordpress.org/trunk@49779


git-svn-id: http://core.svn.wordpress.org/trunk@49502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-09 13:35:05 +00:00
Helen Hou-Sandí
e516134d10 Update $_old_files for 5.6.
See #39943.

Built from https://develop.svn.wordpress.org/trunk@49774


git-svn-id: http://core.svn.wordpress.org/trunk@49497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-08 21:50:07 +00:00
TimothyBlynJacobs
a9244a2912 App Passwords: Ensure redirection description is shown on mobile devices.
Props #core.
Fixes #51970.

Built from https://develop.svn.wordpress.org/trunk@49772


git-svn-id: http://core.svn.wordpress.org/trunk@49495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-08 20:28:04 +00:00
ryelle
aaf90076c5 Help/About: Use CDN URLs for About page images.
See #51415.


Built from https://develop.svn.wordpress.org/trunk@49770


git-svn-id: http://core.svn.wordpress.org/trunk@49493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-08 17:02:06 +00:00
Sergey Biryukov
52d2b07600 Docs: Fix typo in references to WP_Error in some DocBlocks.
See #51800.
Built from https://develop.svn.wordpress.org/trunk@49769


git-svn-id: http://core.svn.wordpress.org/trunk@49492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-08 11:51:05 +00:00
TimothyBlynJacobs
efdba220e6 App Passwords: Store the "in use" option in the main network options.
Whether App Passwords are being used is a global featurel, not a per-network feature. This fixes issues on Multi Network installs if App Passwords are used on a different network from where they were created.

Props spacedmonkey.
Fixes #51939.
See [49752].

Built from https://develop.svn.wordpress.org/trunk@49764


git-svn-id: http://core.svn.wordpress.org/trunk@49487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-07 15:59:04 +00:00
Sergey Biryukov
29e882c177 Bundled Themes: Bump theme versions ahead of WordPress 5.6.
The following theme versions will be released in coordination with WordPress 5.6:

* Twenty Ten: 3.2
* Twenty Eleven: 3.6
* Twenty Twelve: 3.3
* Twenty Thirteen: 3.2
* Twenty Fourteen: 3.0
* Twenty Fifteen: 2.8
* Twenty Sixteen: 2.3
* Twenty Seventeen: 2.5
* Twenty Nineteen: 1.8
* Twenty Twenty: 1.6
* Twenty Twenty-One: 1.0

Props peterwilsoncc, hareesh-pillai, dkarfa, sabernhardt, poena, aristath, SergeyBiryukov.
Fixes #51919.
Built from https://develop.svn.wordpress.org/trunk@49763


git-svn-id: http://core.svn.wordpress.org/trunk@49486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-07 15:55:05 +00:00
Sergey Biryukov
12ce5683ab Twenty Twenty-One: Use esc_url() for the WordPress.org link in footer.php.
Props mukesh27, poena.
Fixes #51954.
Built from https://develop.svn.wordpress.org/trunk@49762


git-svn-id: http://core.svn.wordpress.org/trunk@49485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-07 14:17:04 +00:00
Sergey Biryukov
2095631176 Twenty Twenty-One: Use consistent HTML comments after closing HTML tags.
Follow-up to [45209] for other bundled themes.

Props arcangelini, audrasjb.
Fixes #51950.
Built from https://develop.svn.wordpress.org/trunk@49761


git-svn-id: http://core.svn.wordpress.org/trunk@49484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-07 14:07:06 +00:00
Sergey Biryukov
a4730c14ba Twenty Twenty-One: Fix the nesting of the main element.
The `main` element must not appear as a descendant of the `section` element. Correct markup is the first requirement to make user agents and assistive technologies work properly.

Changes the `<section>` element that was wrapping the `<main>` element to a `<div>`.

Follow-up to [45942] for Twenty Nineteen.

Props albertomake, poena.
Fixes #51944.
}}}
Built from https://develop.svn.wordpress.org/trunk@49759


git-svn-id: http://core.svn.wordpress.org/trunk@49482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-06 16:22:06 +00:00
Peter Wilson
675620a844 Docs, Tests: Correctly capitalize JavaScript.
Correct Javascript to JavaScript within Wordpress core ;)

See #51800, #51802.


Built from https://develop.svn.wordpress.org/trunk@49758


git-svn-id: http://core.svn.wordpress.org/trunk@49481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-06 02:21:07 +00:00
Sergey Biryukov
90510b8762 Tests: Correct @ticket references in some test files.
See #51802.
Built from https://develop.svn.wordpress.org/trunk@49757


git-svn-id: http://core.svn.wordpress.org/trunk@49480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-05 15:51:10 +00:00
TimothyBlynJacobs
aac98aae97 App Passwords: Prevent conflicts when Basic Auth is already used by the site.
Application Passwords uses Basic Authentication to transfer authentication details. If the site is already using Basic Auth, for instance to implement a private staging environment, then the REST API will treat this as an authentication attempt and would end up generating an error for any REST API request.

Now, Application Password authentication will only be attempted if Application Passwords is in use by a site. This is flagged by setting an option whenever an Application Password is created. An upgrade routine is added to set this option if any App Passwords already exist.

Lastly, creating an Application Password will be prevented if the site appears to already be using Basic Authentication.

Props chexwarrior, georgestephanis, adamsilverstein, helen, Clorith, marybaum, TimothyBlynJacobs.
Fixes #51939.


Built from https://develop.svn.wordpress.org/trunk@49752


git-svn-id: http://core.svn.wordpress.org/trunk@49475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-04 21:44:07 +00:00
iandunn
77236320d3 Media: Return WP_Error when cropping with bad input to avoid fatal.
This avoids an error on PHP 8 caused by calling `wp_imagecreatetruecolor()` with inputs that aren't numeric, or are less than 0.

Props hellofromtonya, Boniu91, metalandcoffee, SergeyBiryukov.
Fixes #51937.

Built from https://develop.svn.wordpress.org/trunk@49751


git-svn-id: http://core.svn.wordpress.org/trunk@49474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-04 21:41:06 +00:00
Sergey Biryukov
e7b601f7c5 Database: Check the correct value for displaying the "Successfully repaired table" or "Failed to repair" messages on Database Repair screen.
Additionally, rename the variables holding the results of `ANALYZE TABLE` and `OPTIMIZE TABLE` requests, for clarity.

Props mehrshaddarzi.
Fixes #51932.
Built from https://develop.svn.wordpress.org/trunk@49750


git-svn-id: http://core.svn.wordpress.org/trunk@49473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-04 15:50:12 +00:00
TimothyBlynJacobs
692c6498e9 App Passwords: Ensure the Created At and Last Used dates are properly translated.
The `date_i18n` function is now used when formatting the dates in PHP instead of `gmdate` which doesn't handle localization properly.

Additionally, we now use a translation to get the date format to use instead of pulling from the `date_format` option which is only supposed to affect the front-end.

Lastly, when passing the date format to the Backbone JS template, we now use `wp_json_encode()` to format the value for JavaScript. This ensures that backslashes are properly preserved which are used by some locales to escape date formatting control characters.

Props pedromendonca, TimothyBlynJacobs, ocean90, hellofromtonya, SergeyBiryukov, antpb.
Fixes #51918.
See [35811].

Built from https://develop.svn.wordpress.org/trunk@49746


git-svn-id: http://core.svn.wordpress.org/trunk@49469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-03 21:06:08 +00:00
iandunn
4de6175227 Multisite: Cache absolute dirsize paths to avoid PHP 8 fatal.
r49212 greatly improved the performance of `get_dirsize()`, but also changed the structure of the data stored in the `dirsize_cache` transient. It stored relative paths instead of absolute ones, and also removed the unnecessary `size` array.

That difference in data structures led to a fatal error in the following environment:

* PHP 8
* Multisite
* A custom `WP_CONTENT_DIR` which is not a child of WP's `ABSPATH` folder (e.g., [https://roots.io/bedrock/ Bedrock])
* The `upload_space_check_disabled` option set to `0`

After upgrading to WP 5.6, the `dirsize_cache` transient still had data in the old format. When `wp-admin.php/index.php` was visited, `get_space_used()` received an `array` instead of an `int`, and tried to divide it by another `int`. PHP 7 would silently cast the arguments to match data types, but [https://wiki.php.net/rfc/arithmetic_operator_type_checks PHP 8 throws a fatal error]: 

`Uncaught TypeError: Unsupported operand types: array / int`

`recurse_dirsize()` was using `ABSPATH` to convert the absolute paths to relative ones, but some upload locations are not located under `ABSPATH`. In those cases, `$directory` and `$cache_path` were identical, and that triggered the early return of the old `array`, instead of the expected `int`. 

In order to avoid that, this commit restores the absolute paths, but without the `size` array. It also adds a type check when returning cached values. Using absolute paths without `size` has the result of overwriting the old data, so that it matches the new format. The type check and upgrade routine are additional safety measures.

Props peterwilsoncc, janthiel, helen, hellofromtonya, francina, pbiron.
Fixes #51913. See #19879.


Built from https://develop.svn.wordpress.org/trunk@49744


git-svn-id: http://core.svn.wordpress.org/trunk@49467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-03 20:39:02 +00:00
Sergey Biryukov
203b48f281 Upgrade/Install: Update sodium_compat to v1.14.0.
This includes improved PHP 8 support and more inclusive language.

A full list of changes in this update can be found on GitHub:
https://github.com/paragonie/sodium_compat/compare/v1.13.0...v1.14.0

Follow-up to [48121], [49056], [49057].

Props jrf.
Fixes #51925.
Built from https://develop.svn.wordpress.org/trunk@49741


git-svn-id: http://core.svn.wordpress.org/trunk@49464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-03 17:41:07 +00:00
TimothyBlynJacobs
4dd08e20b8 App Passwords: Return true when rate limiting a password's last used time.
Previously we returned a `WP_Error` instance saying that the password was not found which is inaccurate.

Props dlh.
Fixes #51922.

Built from https://develop.svn.wordpress.org/trunk@49739


git-svn-id: http://core.svn.wordpress.org/trunk@49462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-03 16:30:06 +00:00
Sergey Biryukov
fc3a155f6a Editor: Update components package for WordPress 5.6 RC3.
@wordpress/components: 11.1.2 -> 11.1.3

This fixes an accessibility regression with VoiceOver not announcing the input label or an existing selection in the parent page dropdown under "Page Attributes" in the sidebar.

See https://github.com/WordPress/gutenberg/pull/27431 for more details.

Props isabel_brison, sarahricker, alexstine, kevin940726, talldanwp.
Fixes #51923.
Built from https://develop.svn.wordpress.org/trunk@49737


git-svn-id: http://core.svn.wordpress.org/trunk@49460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-03 14:43:31 +00:00
Sergey Biryukov
be2891ef1a Upgrade/Install: Check $wp_version global for displaying "You are using a development version" message in the admin footer.
This brings some consistency with the same check in `core_upgrade_preamble()` and avoids a PHP warning if `$cur->version` is not set.

Additionally, remove the check for `$cur->url` property, unused since [8595].

Follow-up to [49708], [49709].

Props pbiron, afragen, audrasjb.
Fixes #51892.
Built from https://develop.svn.wordpress.org/trunk@49736


git-svn-id: http://core.svn.wordpress.org/trunk@49459 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-03 14:06:04 +00:00
Sergey Biryukov
0a20850f57 Docs: Clarify the $format parameter description in comment_time().
See #51800.
Built from https://develop.svn.wordpress.org/trunk@49735


git-svn-id: http://core.svn.wordpress.org/trunk@49458 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-02 16:55:06 +00:00
John Blackbourn
00680f2e89 REST API: Pass the previous state of the post as a parameter to the wp_after_insert_post hook.
This enables, for example, the previous post status to be used by this hook without the need to first capture it on an earlier hook.

This also fixes the value of the `$fire_after_hooks` parameter in `get_default_post_to_edit()` so the `wp_after_insert_post` action correctly fires just once on the new post screen.

Props Collizo4sky, peterwilsoncc, hellofromTonya, TimothyBlynJacobs, SergeyBiryukov

Fixes #45114

Built from https://develop.svn.wordpress.org/trunk@49731


git-svn-id: http://core.svn.wordpress.org/trunk@49454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-01 20:47:06 +00:00
desrosj
5bd111eb76 Twenty Twenty-One: Sync the latest changes for 5.6 RC2.
This will be the final sync from GitHub before placing that repository into read-only mode. All further changes should now flow entirely through Trac.

For a full list of changes since [49633], see 1d5a895...53acd9b.

Props poena, luminuu, kjellr, ryelle, allancole, melchoyce, felipeelia, aljullu, kebbet, chaton666, Clorith, mkaz, ingereck, paaljoachim.
See #51526.
Built from https://develop.svn.wordpress.org/trunk@49726


git-svn-id: http://core.svn.wordpress.org/trunk@49449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-01 19:09:05 +00:00
Sergey Biryukov
2c1bfb5baf Administration: Make sure row actions for recent comments in Activity dashboard widget stay visible when a single row gets focus.
Follow-up to [49142].

Props sabernhardt, kebbet, hareesh-pillai, pbiron.
Fixes #51886. See #51516, #49715.
Built from https://develop.svn.wordpress.org/trunk@49725


git-svn-id: http://core.svn.wordpress.org/trunk@49448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-01 18:16:07 +00:00
Sergey Biryukov
8e70bc7720 Editor: Don't unnecessarily split a translatable string in block templates.
As a best practice, strings available for translation should contain entire sentences whenever possible.

Splitting a sentence in two parts and putting them back together after translation should be avoided, as the word order in other languages can be different from English.

Props tobifjellner, kebbet, audrasjb, mukesh27, hellofromTonya, azaozz, SergeyBiryukov.
Fixes #51893.
Built from https://develop.svn.wordpress.org/trunk@49722


git-svn-id: http://core.svn.wordpress.org/trunk@49445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-01 17:03:04 +00:00
Sergey Biryukov
785cb6cc7d Media: Revert [49567].
This addresses a regression with the pagination section in Media Library no longer taking additional query filtering into account.

Props iCaleb, trepmal, peterwilsoncc.
See #39968.
Built from https://develop.svn.wordpress.org/trunk@49720


git-svn-id: http://core.svn.wordpress.org/trunk@49443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-01 16:33:05 +00:00
Sergey Biryukov
a9490c4639 Editor: Update packages for WordPress 5.6 RC2.
The following package versions were changed:

@wordpress/block-directory: 1.17.4 -> 1.17.5
@wordpress/block-editor: 5.1.3 -> 5.1.4
@wordpress/block-library: 2.26.4 -> 2.26.5
@wordpress/blocks: 6.24.1 -> 6.24.2
@wordpress/components: 11.1.1 -> 11.1.2
@wordpress/core-data: 2.24.1 -> 2.24.2
@wordpress/edit-post: 3.25.4 -> 3.25.5
@wordpress/editor: 9.24.3 -> 9.24.4
@wordpress/format-library: 1.25.3 -> 1.25.4
@wordpress/list-reusable-blocks: 1.24.1 -> 1.24.2
@wordpress/nux: 3.23.1 -> 3.23.2
@wordpress/reusable-blocks: 1.0.3 -> 1.0.4
@wordpress/server-side-render: 1.19.1 -> 1.19.2

See https://github.com/WordPress/gutenberg/pull/27366 for the list of fixed bugs.

Props isabel_brison.
Fixes #51902.
Built from https://develop.svn.wordpress.org/trunk@49718


git-svn-id: http://core.svn.wordpress.org/trunk@49441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-01 12:19:43 +00:00
TimothyBlynJacobs
c3b40f7f80 Site Health, App Passwords: Ensure REST API responses are properly translated.
The REST API requests in Site Health and App Passwords now include `_locale=user` in the request URL to ensure the user's locale is used instead of the site locale. Additionally, the `apiRequest` library now sends a JSON `Accept` header which is required by `determine_locale()` to respect the `_locale` query parameter.

The Site Health REST API controllers now manually load the default admin textdomain if not `is_admin()`. This allows for the Site Health tests to be translated even though the translations are part of the administration project and the REST API is not.

Props oglekler, kebbet, Clorith, TimothyBlynJacobs, ocean90, SergeyBiryukov, adamsilverstein.
Fixes #51871.

Built from https://develop.svn.wordpress.org/trunk@49716


git-svn-id: http://core.svn.wordpress.org/trunk@49439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-12-01 03:44:05 +00:00
Sergey Biryukov
b3a952972e External Libraries: Upgrade PHPMailer to version 6.2.0.
For a full list of changes in this update, see the PHPMailer GitHub:
https://github.com/PHPMailer/PHPMailer/compare/v6.1.8...v6.2.0

Props ayeshrajans, jrf.
Fixes #51874.
Built from https://develop.svn.wordpress.org/trunk@49713


git-svn-id: http://core.svn.wordpress.org/trunk@49436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-30 17:10:05 +00:00
Andrew Ozz
190b9a0b32 Quick/Bulk Edit: Follow up to [49703]. Improve the logic a bit and always return this (the jQuery object) in wpTagsSuggest.
Fixes #51872.
Built from https://develop.svn.wordpress.org/trunk@49710


git-svn-id: http://core.svn.wordpress.org/trunk@49433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-30 14:31:04 +00:00
Sergey Biryukov
ce3334571d Upgrade/Install: Display "You are using a development version" message on WordPress Updates screen for Beta or RC versions.
This ensures that the message is displayed when the `WP_AUTO_UPDATE_CORE` constant is set to `beta` or `rc` and the user is on a development version.

Follow-up to [49245], [49254], [49292], [49638], [49708].

Props afragen, audrasjb, azaozz, SergeyBiryukov.
Fixes #51822.
Built from https://develop.svn.wordpress.org/trunk@49709


git-svn-id: http://core.svn.wordpress.org/trunk@49432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-30 13:42:07 +00:00
Sergey Biryukov
95f28a3fd2 Upgrade/Install: Display "You are using a development version" message in the admin footer for Beta or RC versions.
This ensures that the message is displayed when the `WP_AUTO_UPDATE_CORE` constant is set to `beta` or `rc` and the user is on a development version.

Props afragen.
Fixes #51892.
Built from https://develop.svn.wordpress.org/trunk@49708


git-svn-id: http://core.svn.wordpress.org/trunk@49431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-29 16:13:06 +00:00
Sergey Biryukov
2797594835 Comments: Correct ending tag placement in the "Search results for: ..." subtitle.
Follow-up to [49284], [49286].

Props Clorith, kebbet, johnbillion, audrasjb, azaozz.
Fixes #51889. See #37353.
Built from https://develop.svn.wordpress.org/trunk@49705


git-svn-id: http://core.svn.wordpress.org/trunk@49428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-28 17:28:05 +00:00
Andrew Ozz
94e8230864 External Libraries: Fix hiding of the text in the jQuery UI dialog close button.
Props marijnkoopman, SergeyBiryukov, Clorith, azaozz.
Fixes #51863.
Built from https://develop.svn.wordpress.org/trunk@49704


git-svn-id: http://core.svn.wordpress.org/trunk@49427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-28 13:50:03 +00:00
Andrew Ozz
bac1ada04d Quick/Bulk Edit: Fix undefined error when initializing UI Autocomplete 1.12.1 on non-existing element and then attempting to use the autocomplete instance.
Example: `jQuery( '#nonexisting' ).autocomplete().autocomplete( 'instance' ).something`.

Props _luigi, sabernhardt, donmhico, azaozz.
Fixes #51872.
Built from https://develop.svn.wordpress.org/trunk@49703


git-svn-id: http://core.svn.wordpress.org/trunk@49426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-28 12:46:05 +00:00
ryelle
33749fcc74 Help/About: Update URLs in About page
Replace the placeholder links now that the posts have been published. This also updates the jQuery plugin links to to local-site links, if the user can install plugins.

Follow-up to [49640].
Props mukesh27, ocean90.
See #51415.


Built from https://develop.svn.wordpress.org/trunk@49702


git-svn-id: http://core.svn.wordpress.org/trunk@49425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-27 17:10:07 +00:00
Sergey Biryukov
25d67c30b0 Tests: Test that sanitize_title_with_dashes() strips HTML tags.
`sanitize_title()` already has the same test in its own file.

Props pbearne.
Fixes #51881.
Built from https://develop.svn.wordpress.org/trunk@49701


git-svn-id: http://core.svn.wordpress.org/trunk@49424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-27 12:52:06 +00:00
John Blackbourn
40b738335b Docs: Corrections and improvements to docs for properties of the WP_Query class.
This also adds additional type hinting inside some methods to help IDEs.

See #51800

Built from https://develop.svn.wordpress.org/trunk@49700


git-svn-id: http://core.svn.wordpress.org/trunk@49423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-26 17:04:06 +00:00
Sergey Biryukov
f0b5757e35 Options, Meta APIs: Pass $meta_type to the get_{$meta_type}_metadata filter in metadata_exists().
This matches the main instance of the filter in `get_metadata_raw()`.

Follow-up to [48505].

Props pbiron, jsmoriss, TimothyBlynJacobs.
Fixes #51866.
Built from https://develop.svn.wordpress.org/trunk@49699


git-svn-id: http://core.svn.wordpress.org/trunk@49422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-26 12:34:06 +00:00
Sergey Biryukov
82d074fb0a Docs: Use typed array notation for the $size parameter of embed_defaults filter.
Previously committed in [42876], accidentally reverted in [44154].

See #51800.
Built from https://develop.svn.wordpress.org/trunk@49698


git-svn-id: http://core.svn.wordpress.org/trunk@49421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-25 12:14:05 +00:00
Peter Wilson
e89f669274 Build/Test Tools: Use dataProviders for some kses tests.
Refactor several kses tests to use dataProviers rather than looping through assertions.

See #51802.

Built from https://develop.svn.wordpress.org/trunk@49697


git-svn-id: http://core.svn.wordpress.org/trunk@49420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-25 04:51:03 +00:00
Peter Wilson
5a9a4865ad Build/Test Tools: Remove unused posts from AJAX test setUp().
Removes the creation of five posts from the AJAX test suite `setUp()` function, replacing it with a shared fixture only where required.

See #51802.

Built from https://develop.svn.wordpress.org/trunk@49696


git-svn-id: http://core.svn.wordpress.org/trunk@49419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-25 04:11:05 +00:00
noisysocks
7aa60ecce9 Editor: Remove render_block hooks from WP_Block
Reverts the move of pre_render_block, render_block_data, and
render_block_context to WP_Block.

This change has more implications than first thought so will be revisted later
in 5.7.

Reverts [49609,49608].
See #51612.

Built from https://develop.svn.wordpress.org/trunk@49695


git-svn-id: http://core.svn.wordpress.org/trunk@49418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-25 01:20:09 +00:00
John Blackbourn
f4cda1b62f Docs: Upgrade more parameters in docblocks to used typed array notation.
See #51800, #41756

Built from https://develop.svn.wordpress.org/trunk@49693


git-svn-id: http://core.svn.wordpress.org/trunk@49416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-24 21:27:05 +00:00
John Blackbourn
780cdb5eb5 Docs: Various docblock corrections relating to parameter types.
See #51800

Built from https://develop.svn.wordpress.org/trunk@49692


git-svn-id: http://core.svn.wordpress.org/trunk@49415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-24 21:22:04 +00:00
Sergey Biryukov
d26f6daa23 Tests: Ignore EOL differences in WP_List_Table::get_bulk_items() test for optgroups.
This avoids a misleading failure due to Unix vs. Windows EOL style mismatches and allows the test to pass on Windows.

Follow-up to [46612], [49190].

See #19278.
Built from https://develop.svn.wordpress.org/trunk@49691


git-svn-id: http://core.svn.wordpress.org/trunk@49414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-24 20:43:08 +00:00
Sergey Biryukov
0f9170b82d Docs: Clarify that the $class argument of wp_list_bookmarks() can accept an array.
Follow-up to [32906].

See #51855, #51800.
Built from https://develop.svn.wordpress.org/trunk@49688


git-svn-id: http://core.svn.wordpress.org/trunk@49411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-24 12:29:07 +00:00
Sergey Biryukov
771b1048be Help/About: Move trailing punctuation in the jQuery Migrate Helper plugin link outside of the HTML tag.
Props psmits1567, audrasjb, tobifjellner, fierevere, markscottrobson.
Fixes #51813.
Built from https://develop.svn.wordpress.org/trunk@49685


git-svn-id: http://core.svn.wordpress.org/trunk@49408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-23 19:35:03 +00:00
Sergey Biryukov
5f9cf0141e Plugins: Check if _error_nonce is set before attempting to verify it.
This avoids a PHP notice on the Plugins screen when `error` query string is added to the URL.

Props wponlinesupport.
Fixes #43876.
Built from https://develop.svn.wordpress.org/trunk@49683


git-svn-id: http://core.svn.wordpress.org/trunk@49406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-23 13:36:07 +00:00
Sergey Biryukov
8312762816 Docs: Update syntax for multi-line comment in core_auto_updates_settings() per the documentation standards.
Follow-up to [49677].

See #51827.
Built from https://develop.svn.wordpress.org/trunk@49681


git-svn-id: http://core.svn.wordpress.org/trunk@49404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-22 15:59:05 +00:00
Sergey Biryukov
3af1bfdbfa Docs: Add documentation for the $type and $mime_type properties in WP_Customize_Image_Control.
Follow-up to [20319], [30309], [31698], [32023], [49679].

Props subrataemfluence.
Fixes #44411.
Built from https://develop.svn.wordpress.org/trunk@49680


git-svn-id: http://core.svn.wordpress.org/trunk@49403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-22 15:53:03 +00:00
Sergey Biryukov
f31f929a5b Docs: Add documentation for the $type, $mime_type, and $button_labels properties in WP_Customize_Upload_Control.
Follow-up to [20319], [30309], [31698], [32023].

Props subrataemfluence.
See #44411.
Built from https://develop.svn.wordpress.org/trunk@49679


git-svn-id: http://core.svn.wordpress.org/trunk@49402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-22 15:51:03 +00:00
Sergey Biryukov
dda5dcd028 Docs: Correct @since tag for the class-wp-widget-area-customize-control.php file.
Per the documentation standards, the file header `@since` tag is supposed to specify when the file was introduced.

Follow-up to [35389].

See #51800.
Built from https://develop.svn.wordpress.org/trunk@49678


git-svn-id: http://core.svn.wordpress.org/trunk@49401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-22 15:12:03 +00:00
Andrew Ozz
991114fb57 Upgrade/Install: Replace the conditionals that check the AUTOMATIC_UPDATER_DISABLED constant and the automatic_updater_disabled filter in update-core.php with a call to WP_Automatic_Updater::is_disabled(). This prevents a PHP warning, fixes the logic, and considers wp_is_file_mod_allowed( 'automatic_updater' ) when determining the UI state.
Props jamesros161, pbiron, audrasjb, azaozz.
Fixes #51827.
Built from https://develop.svn.wordpress.org/trunk@49677


git-svn-id: http://core.svn.wordpress.org/trunk@49400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-22 13:03:06 +00:00
Sergey Biryukov
9150652fed Site Health: Check if $core_updates is an array before iterating on it.
This avoids a PHP warning if `get_core_updates()` returns `false`.

Props paulschreiber.
Fixes #51818.
Built from https://develop.svn.wordpress.org/trunk@49676


git-svn-id: http://core.svn.wordpress.org/trunk@49399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-21 14:39:03 +00:00
Sergey Biryukov
5ab5b3e73b Docs: Add missing @since tags for WP_Upgrader_Skin methods.
See #51800.
Built from https://develop.svn.wordpress.org/trunk@49675


git-svn-id: http://core.svn.wordpress.org/trunk@49398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-21 12:08:05 +00:00
ryelle
7ded4af960 Help/About: Clarify accessibility features.
* Captions are uploaded in the block editor, and not created in the editor.
* Avoid making an invalid claim of WCAG 2.1 conformance or trivialize the efforts still required to build an accessible and compliant site.

Follow-up to [49640].
Props joedolson.
See #51415.


Built from https://develop.svn.wordpress.org/trunk@49674


git-svn-id: http://core.svn.wordpress.org/trunk@49397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-21 00:13:07 +00:00
Sergey Biryukov
d86f6bde55 Docs: Correct $fire_after_hooks parameter name in @since tags.
Follow-up to [49172], [49173].

See #45114.
Built from https://develop.svn.wordpress.org/trunk@49673


git-svn-id: http://core.svn.wordpress.org/trunk@49396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-20 11:58:06 +00:00
John Blackbourn
35f6c356c1 Docs: Document parameters that accept an array of integers using typed array notation.
While many of these parameters also technically accept an array of numerical strings, they are all ultimately cast to an array of integers. Documenting them as such assists developers in understanding the expected types.

See #51800, #41756

Built from https://develop.svn.wordpress.org/trunk@49672


git-svn-id: http://core.svn.wordpress.org/trunk@49395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-19 18:24:09 +00:00
John Blackbourn
6e472178d1 Docs: Add missing @since tags.
See #51800

Built from https://develop.svn.wordpress.org/trunk@49671


git-svn-id: http://core.svn.wordpress.org/trunk@49394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-19 17:54:05 +00:00
John Blackbourn
792c53ac8c Docs: Clarify and standardise on terminology used for rewrite rule endpoint masks.
See #51800

Built from https://develop.svn.wordpress.org/trunk@49670


git-svn-id: http://core.svn.wordpress.org/trunk@49393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-19 16:15:08 +00:00
Sergey Biryukov
aab7112b09 Docs: Use more specific type in parameter descriptions for in_category() and is_object_in_term().
This better aligns with `is_category()` and other conditional tags and their `WP_Query` counterpart methods.

Follow-up to [47402].

Props princeahmed.
Fixes #51825.
Built from https://develop.svn.wordpress.org/trunk@49669


git-svn-id: http://core.svn.wordpress.org/trunk@49392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-19 15:20:05 +00:00
Sergey Biryukov
da6ab833d5 Coding Standards: Remove redundant isset() check in core_upgrade_preamble().
`isset()` can be safely used to check properties and subproperties of objects directly.

Follow-up to [49638].

See #51799.
Built from https://develop.svn.wordpress.org/trunk@49668


git-svn-id: http://core.svn.wordpress.org/trunk@49391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-19 12:05:06 +00:00
Sergey Biryukov
6cde96263b Help/About: Correct placeholder for the accessibility statement feature plugin link.
Add missing translator comment.

Props audrasjb.
See #51415.
Built from https://develop.svn.wordpress.org/trunk@49651


git-svn-id: http://core.svn.wordpress.org/trunk@49388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-18 15:51:04 +00:00
Sergey Biryukov
05125ed8bf Site Health: Add missing i18n for the App Passwords documentation link.
Follow-up to [49334].

Props tai.
Fixes #51815.
Built from https://develop.svn.wordpress.org/trunk@49650


git-svn-id: http://core.svn.wordpress.org/trunk@49387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-18 15:04:05 +00:00
Andrew Ozz
e261cf0d1e External Libraries: Update jQuery Migrate to 3.3.2.
Props mgol, azaozz.
Fixes #50564.
Built from https://develop.svn.wordpress.org/trunk@49649


git-svn-id: http://core.svn.wordpress.org/trunk@49386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-18 09:06:06 +00:00
Helen Hou-Sandí
7c5a072f38 Trunk is now really 5.7-alpha.
Built from https://develop.svn.wordpress.org/trunk@49645


git-svn-id: http://core.svn.wordpress.org/trunk@49383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 22:57:03 +00:00
Helen Hou-Sandí
a434baf9e8 Trunk is now 5.7-alpha.
Built from https://develop.svn.wordpress.org/trunk@49644


git-svn-id: http://core.svn.wordpress.org/trunk@49382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 22:52:03 +00:00
Helen Hou-Sandí
5ac21f5fbc Post WordPress 5.6 RC 1 version bump.
Built from https://develop.svn.wordpress.org/trunk@49642


git-svn-id: http://core.svn.wordpress.org/trunk@49380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 22:39:05 +00:00
Helen Hou-Sandí
c267ad2fde WordPress 5.6 RC 1.
Built from https://develop.svn.wordpress.org/trunk@49641


git-svn-id: http://core.svn.wordpress.org/trunk@49379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 22:01:02 +00:00
ryelle
6214f61cb1 Help/About: WordPress 5.6 About Page.
This change introduces the new About page for WordPress 5.6.

Props elmastudio, ryelle, melchoyce, karmatosed, webcommsat, marybaum, meher, OGlekler, lmurillom, vimes1984, sabrinazeidan, nalininonstopnewsuk, afshanadiya, michelleames, bmcdede, yvettesonneveld, sarahricker, isabel_brison, helen, hellofromtonya, poena, chanthaboune, cbringmann, joedolson, sabernhardt, garrett-eclipse, audrasjb, marks99.
See #51415.


Built from https://develop.svn.wordpress.org/trunk@49640


git-svn-id: http://core.svn.wordpress.org/trunk@49378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 21:34:04 +00:00
Sergey Biryukov
700c9455ab I18N: Avoid PHP notices for relative URLs in load_script_textdomain().
Props hellofromTonya, SeBsZ, archon810, nourma, justinahinon, SergeyBiryukov.
Fixes #49145.
Built from https://develop.svn.wordpress.org/trunk@49639


git-svn-id: http://core.svn.wordpress.org/trunk@49377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 20:52:09 +00:00
Helen Hou-Sandí
b456e9c9c8 Upgrade/Install: Consistent layout and accurate messages on the update screen.
* Clarifies that if you are on maintenance/security auto-updates that you are only on those and therefore there are more options available.
* Adds a message if a version control system has been detected, as automatic updates are disabled in that case.
* Ensures only one heading between `update available`, `you are on a dev version`, and `you are on latest` appears at any given time, falling back to `you are on latest` if something strange happens with the returned update data.
* Removes some older strings related to auto-updates, which greatly simplifies the above.
* Strips the `core-major-auto-updates-saved` query arg from the URL, as it is related to a dismissible notice.

Props audrasjb, pbiron, helen.
Fixes #51742.

Built from https://develop.svn.wordpress.org/trunk@49638


git-svn-id: http://core.svn.wordpress.org/trunk@49376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 20:28:04 +00:00
Sergey Biryukov
cce65c9baf Users: Use do_action_ref_array() for pre_get_users and pre_get_terms actions.
This brings some consistency with the other similar actions:

* `pre_get_comments`
* `pre_get_networks`
* `pre_get_posts`
* `pre_get_sites`
* `pre_user_query`

Follow-up to [29363] and [37572].

Props andy, adamsilverstein, hellofromTonya, desrosj, SergeyBiryukov.
Fixes #50961.
Built from https://develop.svn.wordpress.org/trunk@49637


git-svn-id: http://core.svn.wordpress.org/trunk@49375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 20:09:05 +00:00
desrosj
bcb9027236 Build/Test Tools: Update the package.json engines to point to the new LTS versions of Node/NPM.
Props mkaz, jorbin.
Fixes #51749.
Built from https://develop.svn.wordpress.org/trunk@49636


git-svn-id: http://core.svn.wordpress.org/trunk@49374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 19:52:00 +00:00
Sergey Biryukov
dfc3eeff10 General: Rename the wp_error_checked action to is_wp_error_instance for clarity.
Follow-up to [49022], [49023].

Props johnbillion, helen, johnjamesjacoby, Mte90, alexstandiford, hellofromTonya, jnylen0, SergeyBiryukov.
Fixes #40568.
Built from https://develop.svn.wordpress.org/trunk@49635


git-svn-id: http://core.svn.wordpress.org/trunk@49373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-17 19:21:05 +00:00