Commit Graph

26 Commits

Author SHA1 Message Date
desrosj
89ddd19884 General: Fix various issues flagged by the PHPCompatibilityWP PHPCS ruleset.
As part of the continued effort to improve PHP compatibility, the following improvments are being made:

- Removing deprecated PHP `safe_mode` checks not found in bundled external libraries.
- Change the remaining `while` loops using `each()` to `foreach` loops.
- Prevent false positives from being flagged for the `sodium_compat` library being caused by loading this in a non-standard way.
- Add inline comments to not flag deprecated PHP directives in the getID3 library.

Props desrosj, earnjam, dryanpress.
See #49922.
Built from https://develop.svn.wordpress.org/trunk@47735


git-svn-id: http://core.svn.wordpress.org/trunk@47511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-01 19:07:09 +00:00
Sergey Biryukov
139387b7e5 Docs: Use 3-digit, x.x.x-style semantic versioning for _doing_it_wrong(), _deprecated_function(), _deprecated_argument(), and _deprecated_file() throughout core.
Props metodiew.
Fixes #36495.
Built from https://develop.svn.wordpress.org/trunk@37985


git-svn-id: http://core.svn.wordpress.org/trunk@37926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-06 12:40:29 +00:00
Nikolay Bachiyski
b15e4d2775 Snoopy: use escapeshellarg instead of escapeshellcmd
We are escaping arguments, not commands, so we'd better use the semantically correct function, even though they are similar.

Built from https://develop.svn.wordpress.org/trunk@37094


git-svn-id: http://core.svn.wordpress.org/trunk@37061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-30 13:58:28 +00:00
Scott Taylor
84da11d918 Pass false as the 2nd argument to class_exists() to disable autoloading and to not cause problems for those who define __autoload().
Fixes #20523.

Built from https://develop.svn.wordpress.org/trunk@34348


git-svn-id: http://core.svn.wordpress.org/trunk@34312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 03:52:25 +00:00
Scott Taylor
c1bb5b5ce3 After [33843], update the location of some files in This filter is documented in docs
Props dimadin.
See #33413.

Built from https://develop.svn.wordpress.org/trunk@33954


git-svn-id: http://core.svn.wordpress.org/trunk@33923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-08 22:17:26 +00:00
Andrew Nacin
cbd3566a2b Use correct variable in the deprecated and abandoned Snoopy HTTP client. see #24210.
See also:
 * http://sourceforge.net/p/snoopy/bugs/60/
 * http://sourceforge.net/p/snoopy/bugs/62/
 * http://sourceforge.net/p/snoopy/bugs/73/
 * http://sourceforge.net/p/snoopy/bugs/77/
 * and probably more. This project is abandoned.

If any plugins are using this (instead of the WordPress HTTP API), this at least ensures that temp files are cleaned up.



git-svn-id: http://core.svn.wordpress.org/trunk@24591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-08 17:17:46 +00:00
Sergey Biryukov
709dd51ae6 Fix typos in phpdoc. props bradparbs. fixes #23481.
git-svn-id: http://core.svn.wordpress.org/trunk@23604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-04 04:23:00 +00:00
nacin
9f9f5205b0 Fix some encoding issues. props hakre, fixes #14735.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-27 09:54:17 +00:00
nacin
71d7acc71d Mark Snoopy as deprecated. see #12882
git-svn-id: http://svn.automattic.com/wordpress/trunk@14052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-10 11:32:02 +00:00
azaozz
bfb5ac0d25 Safely include class-json.php, class-simplepie.php and class-snoopy.php, props alexkingorg, fixes #11827
git-svn-id: http://svn.automattic.com/wordpress/trunk@12705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-12 13:22:43 +00:00
ryan
b3749dad16 Revert snoopy change that breaks with canonical feeds.
git-svn-id: http://svn.automattic.com/wordpress/trunk@9308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-23 22:41:51 +00:00
ryan
b7ca9bd521 Add conditional load back to snoopy and strip trailing whites
git-svn-id: http://svn.automattic.com/wordpress/trunk@9307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-23 22:19:21 +00:00
ryan
965d8d1507 Snoopy 1.2.4
git-svn-id: http://svn.automattic.com/wordpress/trunk@9303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-23 21:08:09 +00:00
westi
f8a32e8d47 Updated phpdoc for external libs. See #7038 props jacobsantos.
git-svn-id: http://svn.automattic.com/wordpress/trunk@8082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-06-14 16:36:13 +00:00
westi
33fffea3f3 Add file level phpdoc to external libraries we use. Fixes #5443 props darkdragon.
git-svn-id: http://svn.automattic.com/wordpress/trunk@6440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-12-20 22:28:54 +00:00
ryan
321c310717 Remove trailing whitespace
git-svn-id: http://svn.automattic.com/wordpress/trunk@6026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-09-03 23:32:58 +00:00
rob1n
ece3623070 Don't add port if port == 80 (default port). fixes #3993
git-svn-id: http://svn.automattic.com/wordpress/trunk@5424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-05-10 01:26:56 +00:00
ryan
a9ca0da268 Don't forget to concat. Props cschneid. fixes #2988
git-svn-id: http://svn.automattic.com/wordpress/trunk@4075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-08-05 04:18:09 +00:00
ryan
1fe8d71aa1 Damn editor.
git-svn-id: http://svn.automattic.com/wordpress/trunk@4037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-07-23 21:20:30 +00:00
ryan
055eefb19f Snoopy fread fixes. Props JeremyVisser. fixes #2733
git-svn-id: http://svn.automattic.com/wordpress/trunk@4030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-07-23 18:23:43 +00:00
ryan
dd202ce1f9 Death to trailing tabs. Props Mark J. fixes #2405
git-svn-id: http://svn.automattic.com/wordpress/trunk@3517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2006-02-12 07:53:23 +00:00
ryan
489c6c4257 escapeshell SA17779
git-svn-id: http://svn.automattic.com/wordpress/trunk@3235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-11-29 14:07:30 +00:00
ryan
a9d801767f Upgrade to Snoopy 1.2.3
git-svn-id: http://svn.automattic.com/wordpress/trunk@3191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-11-22 01:14:26 +00:00
saxmatt
fb2ccdee42 Bad link in snoopy class.
git-svn-id: http://svn.automattic.com/wordpress/trunk@2053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-01-06 09:53:40 +00:00
saxmatt
e5d942f411 Added check if Snoopy exists, and two fairly major bugs in the dashboard. update_option was not serializing objects and $cache->get() wasn't checking for the correct option name.
git-svn-id: http://svn.automattic.com/wordpress/trunk@2027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2005-01-01 22:09:08 +00:00
saxmatt
90c90b336f New aggregation code (hat tip: Chris Davis/Jesuit), tweaked style, fixed login updater, new dashboard.
git-svn-id: http://svn.automattic.com/wordpress/trunk@1979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2004-12-19 02:30:40 +00:00