Andrea Fercia
f83c787887
Accessibility: Correctly associate the search input label in the new Themes favorites tab introduced in [35527].
...
Fixes #35122 .
Built from https://develop.svn.wordpress.org/trunk@35977
git-svn-id: http://core.svn.wordpress.org/trunk@35942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 22:30:27 +00:00
Pascal Birchler
fa9b71e423
Docs: Document the default value for the $validate
parameter in the validate_current_theme
hook docs.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35976
git-svn-id: http://core.svn.wordpress.org/trunk@35941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 20:10:25 +00:00
Pascal Birchler
b6c660c38f
Docs: Clarify the return value for wp_create_categories()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35975
git-svn-id: http://core.svn.wordpress.org/trunk@35940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 19:59:27 +00:00
Pascal Birchler
1b86ccd006
Docs: Correct a parameter name for the press_this_redirect_in_parent
filter.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35974
git-svn-id: http://core.svn.wordpress.org/trunk@35939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 19:43:26 +00:00
Pascal Birchler
624cb1445d
Docs: Correct a parameter name for the force_filtered_html_on_import
filter.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35973
git-svn-id: http://core.svn.wordpress.org/trunk@35938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 19:40:26 +00:00
Pascal Birchler
4e6e728703
Docs: Correct a parameter name for the validate_current_theme
filter.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35972
git-svn-id: http://core.svn.wordpress.org/trunk@35937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 19:36:28 +00:00
Pascal Birchler
4a6d77c8e5
Docs: Correct a parameter name for the allow_subdirectory_install
filter.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35971
git-svn-id: http://core.svn.wordpress.org/trunk@35936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 19:32:26 +00:00
Pascal Birchler
2e35e20010
Docs: Correct a parameter name for the do_mu_upgrade
filter.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35970
git-svn-id: http://core.svn.wordpress.org/trunk@35935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 19:30:28 +00:00
John Blackbourn
26dfc6159f
Correct a parameter name for the allow_password_reset
filter so its entry on developer.wordpress.org displays correctly.
...
See #32246
Built from https://develop.svn.wordpress.org/trunk@35969
git-svn-id: http://core.svn.wordpress.org/trunk@35934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 19:20:26 +00:00
Drew Jaynes
3cba9d7f61
Docs: Add missing parameter descriptions to the DocBlock for WP_Query::set_found_posts()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35968
git-svn-id: http://core.svn.wordpress.org/trunk@35933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 18:11:26 +00:00
Drew Jaynes
ee0335e930
Docs: Add a missing summary to the DocBlock for WP_Locale::rtl_src_admin_notice()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35967
git-svn-id: http://core.svn.wordpress.org/trunk@35932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 18:08:26 +00:00
Drew Jaynes
c9a11ae9f2
Docs: Mark the upgrade_XX()
functions to be ignored from parsing for the Code Reference.
...
There is no great value in generating reference pages for these funcitons as they explicitly serve a core-only purpose.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35966
git-svn-id: http://core.svn.wordpress.org/trunk@35931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 17:59:27 +00:00
Drew Jaynes
36367e7f6e
Docs: Add missing DocBlocks, including summaries and @since
versions, to the __construct()
and init()
methods in WP_Scripts
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35965
git-svn-id: http://core.svn.wordpress.org/trunk@35930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 17:48:27 +00:00
Drew Jaynes
25eca6974e
Docs: Add a missing summary, @since
version, and parameter descriptions to the DocBlock for wp_xmlrpc_server::pingback_error()
.
...
Introduced in [23329]. Also corrects return descriptions for two deprecated methods.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35964
git-svn-id: http://core.svn.wordpress.org/trunk@35929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 17:38:27 +00:00
Drew Jaynes
7614bd71d3
Docs: Add a missing summary, @since
version, and parameter descriptions to the DocBlock for wp_xmlrpc_server::add_enclosure_if_new()
.
...
Introduced in [10383].
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35963
git-svn-id: http://core.svn.wordpress.org/trunk@35928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 17:32:28 +00:00
Drew Jaynes
92dd7b7447
Docs: Add missing notations for the unused $args
parameter in the blogger_getTemplate()
and blogger_setTemplate()
methods in wp_xmlrpc_server
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35962
git-svn-id: http://core.svn.wordpress.org/trunk@35927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 17:26:28 +00:00
Drew Jaynes
d057c51893
Docs: Add missing property and method summaries in DocBlocks for Walker_PageDropdown
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35961
git-svn-id: http://core.svn.wordpress.org/trunk@35926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 16:36:28 +00:00
Sergey Biryukov
ae37057114
KSES: Allow the reversed
attribute for <ol>
.
...
Props lancewillett.
Fixes #35079 .
Built from https://develop.svn.wordpress.org/trunk@35960
git-svn-id: http://core.svn.wordpress.org/trunk@35924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 09:54:26 +00:00
Sergey Biryukov
6ffc7914f1
I18N: Add a unit test for before_last_bar()
.
...
Props realloc.
Fixes #35073 .
Built from https://develop.svn.wordpress.org/trunk@35959
git-svn-id: http://core.svn.wordpress.org/trunk@35923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 08:04:26 +00:00
Sergey Biryukov
f9f77d86d8
Accessibility: Add missing label for the theme upload input.
...
See [11152] for plugins.
Props mercime.
Fixes #35113 .
Built from https://develop.svn.wordpress.org/trunk@35958
git-svn-id: http://core.svn.wordpress.org/trunk@35922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 07:56:29 +00:00
Drew Jaynes
fcd35518d9
Docs: Add a missing notation for the $args
parameter in the DocBlock for wp_xmlrpc_server::_multisite_getUsersBlogs()
.
...
Also adds a missing `@since` version. The method was introduced in [12852].
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35957
git-svn-id: http://core.svn.wordpress.org/trunk@35921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 05:49:26 +00:00
Drew Jaynes
489023e001
Docs: Add a missing summary and @since
version to the DocBlock for wp_xmlrpc_server::serve_request()
.
...
Introduced in [11789].
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35956
git-svn-id: http://core.svn.wordpress.org/trunk@35920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 05:43:26 +00:00
Drew Jaynes
4ced4fce3a
Docs: Add missing summaries and @since
versions to DocBlocks for the _get_display_callback()
, _get_update_callback()
, and _get_form_callback()
methods in WP_Widget
.
...
Introduced in [10764].
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35955
git-svn-id: http://core.svn.wordpress.org/trunk@35919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 05:39:25 +00:00
Drew Jaynes
2dda796547
Docs: Add variadic markers to the optional $object_id
parameter notation for WP_User::has_cap()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35954
git-svn-id: http://core.svn.wordpress.org/trunk@35918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-16 05:32:28 +00:00
Andrea Fercia
c69481a410
Accessibility: Remove title attributes from the Plugin Cards on the Plugin install screen.
...
Fixes #35050 .
Built from https://develop.svn.wordpress.org/trunk@35953
git-svn-id: http://core.svn.wordpress.org/trunk@35917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 22:33:28 +00:00
Andrea Fercia
6dac60da98
Accessibility: add missing labels for Plugins and Themes checkboxes in the Updates screen.
...
Also, adds translator comments and improves readability.
Props SergeyBiryukov, afercia, oaron for the initial patch.
Fixes #34774 .
Built from https://develop.svn.wordpress.org/trunk@35952
git-svn-id: http://core.svn.wordpress.org/trunk@35916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 22:18:30 +00:00
Sergey Biryukov
c2fcab7d82
I18N: After [35884], remove html_entity_decode()
for the thousands separator in WP_Locale::init()
, use the
entity directly.
...
We can't `get_option( 'blog_charset' )` here, because the database may not be available.
Fixes #10373 .
Built from https://develop.svn.wordpress.org/trunk@35951
git-svn-id: http://core.svn.wordpress.org/trunk@35915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 21:35:29 +00:00
Dominik Schilling
bc6b11d0de
Revert [35949].
...
Passing an object to `wp_list_pluck()` throws also a fatal error, see https://3v4l.org/9YsaD .
See #35087 .
Built from https://develop.svn.wordpress.org/trunk@35950
git-svn-id: http://core.svn.wordpress.org/trunk@35914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 19:50:29 +00:00
Pascal Birchler
ac940d0587
Ensure wp_list_pluck()
throws a warning when not being passed an array.
...
We should not paper over the code and hide warnings from developers by casting values to an array.
See #35087 .
Built from https://develop.svn.wordpress.org/trunk@35949
git-svn-id: http://core.svn.wordpress.org/trunk@35913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 18:29:29 +00:00
Rachel Baker
719239ca1e
Comments: Use an integer as the default value for comment_post_ID
in wp_insert_comment
to match database column.
...
Props MikeHansenMe, juanfra, rabmalin.
Fixes #34956
Built from https://develop.svn.wordpress.org/trunk@35948
git-svn-id: http://core.svn.wordpress.org/trunk@35912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 15:13:27 +00:00
Andrea Fercia
282e7c36eb
Accessibility: Add an ARIA role button
to links that behave like buttons when JavaScript is on.
...
Introduces a simple way to give a proper semantics of `button` to links that behave
like UI controls when JavaScript is on and behave like actual links when JavaScript
is off. First implementation on the Terms list table.
Patch prepared during WordCamp US 2015 Contributor Day.
Props mcapybara, garusky, takayukister.
See #26504 .
Fixes #34867 .
Built from https://develop.svn.wordpress.org/trunk@35947
git-svn-id: http://core.svn.wordpress.org/trunk@35911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 13:25:28 +00:00
Dion Hulse
8db5455eea
Filesystem: Avoid PHP warnings when using the FTP Sockets class.
...
See #35026
Built from https://develop.svn.wordpress.org/trunk@35946
git-svn-id: http://core.svn.wordpress.org/trunk@35910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 03:12:26 +00:00
Dion Hulse
bda1b2ace9
Filesystem: Revert [33648] and [34733] unfortunately these have caused issues for some servers, while fixing it for others.
...
See #28013
Fixes #34976 for trunk
Fixes #34976 for trunk
Built from https://develop.svn.wordpress.org/trunk@35944
git-svn-id: http://core.svn.wordpress.org/trunk@35908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 02:36:28 +00:00
Weston Ruter
3fdb8bafc4
Customize: Ensure that "Change" button appears when there are only 2 themes.
...
Fixes defect introduced in [35535].
Props igmoweb.
See #34549 .
Fixes #35081 .
Built from https://develop.svn.wordpress.org/trunk@35943
git-svn-id: http://core.svn.wordpress.org/trunk@35907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 01:21:26 +00:00
Dion Hulse
060476a1f2
Filesystem API: Cast the port to an int in the FTPSockets class. PemFTP requires that the port be specified as an integer, not a numeric string.
...
Fixes #35088
Built from https://develop.svn.wordpress.org/trunk@35942
git-svn-id: http://core.svn.wordpress.org/trunk@35906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-15 00:29:26 +00:00
Drew Jaynes
10367a4692
Docs: Add missing parameter and return descriptions to the DocBlock for WP_Rewrite::iis7_url_rewrite_rules()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35941
git-svn-id: http://core.svn.wordpress.org/trunk@35905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 23:58:27 +00:00
Drew Jaynes
af5f4a0d9c
Docs: Add missing parameter documentation for the $args
parameter in the DocBlock for WP_Http_Streams::test()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35940
git-svn-id: http://core.svn.wordpress.org/trunk@35904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 23:54:26 +00:00
Drew Jaynes
338b618fc0
Docs: Remove an extra 'arguments' introduced in [35938].
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35939
git-svn-id: http://core.svn.wordpress.org/trunk@35903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 23:52:25 +00:00
Drew Jaynes
edb1dc0f36
Docs: Add missing parameter documentation for the $args
parameter in the DocBlock for WP_Http_Curl::test()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35938
git-svn-id: http://core.svn.wordpress.org/trunk@35902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 23:43:26 +00:00
Drew Jaynes
64ea48f76a
Docs: Add missing parameter and return descriptions to the DocBlock for WP_Http_Curl::stream_body()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35937
git-svn-id: http://core.svn.wordpress.org/trunk@35901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 23:41:26 +00:00
Drew Jaynes
8d884c25a3
Docs: Clarify documentation for WP_Role::has_cap()
to more clearing indicate that the method checks for capabilities against the role rather than the user.
...
Also updates syntax in the DocBlock summary and description.
Props GunGeekATX for the initial patch.
Fixes #35080 .
Built from https://develop.svn.wordpress.org/trunk@35935
git-svn-id: http://core.svn.wordpress.org/trunk@35899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 20:05:27 +00:00
Boone Gorges
3bc0e35684
Omit cpage
query var in comment link if comment pagination is disabled.
...
WP 4.4 changed the way comment pagination is calculated. See #8071 . In the
context of `get_comment_link()`, these changes introduced a regression that
causes `cpage` (or its pretty-permalink correlate `comment-page-x`) to appear
in comment links when comment pagination is disabled. The current changeset
fixes the regression.
Fixes #34946 .
Built from https://develop.svn.wordpress.org/trunk@35933
git-svn-id: http://core.svn.wordpress.org/trunk@35897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 19:46:46 +00:00
Boone Gorges
b6dbe1cea9
Don't use array_merge()
when building comment children arrays.
...
`array_merge()` is much slower than building the combined array using a
`foreach` loop. The performance difference was causing a speed regression with
the `get_children()` functionality introduced in 4.4.
Props rogerhub.
Fixes #35025 .
Built from https://develop.svn.wordpress.org/trunk@35931
git-svn-id: http://core.svn.wordpress.org/trunk@35895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 19:37:43 +00:00
Drew Jaynes
0c59fd02bb
Docs: Add missing parameter and return descriptions to the DocBlock for WP_Http_Curl::stream_headers()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35930
git-svn-id: http://core.svn.wordpress.org/trunk@35894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 19:21:35 +00:00
Drew Jaynes
f32fba3dab
Docs: Add more complete property and method documentation for Walker_Page
.
...
* Adds missing DocBlock summaries
* Adds missing `@param` descriptions
* Marks some optional parameters as such
* Reorders some DocBlock tags
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35929
git-svn-id: http://core.svn.wordpress.org/trunk@35893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 18:06:31 +00:00
Drew Jaynes
fc9fa08592
Docs: Add a missing description for the $id
parameter in the DocBlock for Walker_PageDropdown::start_el()
, which is implemented by Walker
but unused by the subclass method.
...
Also marks the other optional parameters as such.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35928
git-svn-id: http://core.svn.wordpress.org/trunk@35892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 17:54:27 +00:00
Drew Jaynes
0fbe903434
Docs: Document the $id
parameter for Walker_Comment::start_el()
, which is implemented by Walker
but unused in the subclass method.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35927
git-svn-id: http://core.svn.wordpress.org/trunk@35891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 17:50:26 +00:00
Drew Jaynes
5817eea3c9
Docs: Document the $id
parameter for Walker_CategoryDropdown::start_el()
, which is implemented by Walker
but unused in the subclass method.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35926
git-svn-id: http://core.svn.wordpress.org/trunk@35890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 17:47:30 +00:00
Andrea Fercia
b5f5dff136
Authentication modal dialog: the spinner should disappear when loading is done.
...
Also, when using spinners as background images, the re-painted area should be the
smallest possible one. See similar performance issue in #33311 .
Fixes #34951 .
Built from https://develop.svn.wordpress.org/trunk@35925
git-svn-id: http://core.svn.wordpress.org/trunk@35889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 16:40:27 +00:00
Andrea Fercia
0faf2dd57b
Accessibility: Remove title attributes from the Network Themes list table.
...
Title attributes in the "Themes" screen and in the "Edit Site" screen Themes tab
are now replaced with `aria-label` attributes. Also, replaces string
concatenation with `add_query_arg()` and `sprintf()` to allow translator
comments to be properly parsed and for better code readability.
Props SergeyBiryukov, afercia.
Fixes #35051 .
Built from https://develop.svn.wordpress.org/trunk@35924
git-svn-id: http://core.svn.wordpress.org/trunk@35888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 16:07:39 +00:00