Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-12-27 03:27:46 +01:00
Code Issues Projects Releases Wiki Activity
40,749 Commits 50 Branches 749 Tags 806 MiB
f8964463c1
Commit Graph

14453 Commits

Author SHA1 Message Date
John Blackbourn
f243cd573c Docs: Correct invalid hook docblock placement. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46604


git-svn-id: http://core.svn.wordpress.org/trunk@46401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-27 19:35:01 +00:00
John Blackbourn
c8f91f77ac Docs: Correct invalid hook docblocks. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46603


git-svn-id: http://core.svn.wordpress.org/trunk@46400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-27 19:11:02 +00:00
Sergey Biryukov
c283f8b1ed Docs: Remove "private" designation from _doing_it_wrong() and related functions: 
* `_deprecated_function()`
* `_deprecated_argument()`
* `_deprecated_constructor()`
* `_deprecated_file()`

Plugins and themes should be allowed to use these functions to throw appropriate error notices.

This brings them in line with newer `do_action_deprecated()` and `apply_filters_deprecated()` functions, which are not marked as private.

Props jrf.
Fixes #48251.
Built from https://develop.svn.wordpress.org/trunk@46602


git-svn-id: http://core.svn.wordpress.org/trunk@46399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-27 14:21:03 +00:00
Sergey Biryukov
e015fbd8bb Editor: Fix typo in an error message in WP_Block_Styles_Registry::register(). 
Props man4toman, alishankhan, shaampk1.
Fixes #48437.
Built from https://develop.svn.wordpress.org/trunk@46601


git-svn-id: http://core.svn.wordpress.org/trunk@46398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-27 14:09:02 +00:00
Sergey Biryukov
bb57520713 Docs: Improve DocBlock formatting in WP_Block_Styles_Registry per the documentation standards. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@46600


git-svn-id: http://core.svn.wordpress.org/trunk@46397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-27 14:07:02 +00:00
John Blackbourn
d599314349 Docs: Correct and improve inline docs for the file type functions. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46599


git-svn-id: http://core.svn.wordpress.org/trunk@46396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 23:49:03 +00:00
John Blackbourn
ac6bf7666c Docs: Add missing docs for the auth_cookie_bad_session_token action. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46598


git-svn-id: http://core.svn.wordpress.org/trunk@46395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 23:46:00 +00:00
John Blackbourn
9e2b6902b3 Docs: Update the docs for the error parameter that gets passed around during filesystem credential collection. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46597


git-svn-id: http://core.svn.wordpress.org/trunk@46394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 23:16:04 +00:00
John Blackbourn
3caaa40fc6 Docs: Switch more docs over to typed array notation, plus some fixes. 
See #48303, #41756

Built from https://develop.svn.wordpress.org/trunk@46596


git-svn-id: http://core.svn.wordpress.org/trunk@46393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 21:09:04 +00:00
John Blackbourn
9890e68661 Docs: Switch to typed array notation for the docs for asset dependency functions. 
Props marekdedic

See #48303

Built from https://develop.svn.wordpress.org/trunk@46595


git-svn-id: http://core.svn.wordpress.org/trunk@46392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 21:02:02 +00:00
John Blackbourn
7c2b9f2a2e Docs: Miscellaneous docblock fixes and improvements. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46594


git-svn-id: http://core.svn.wordpress.org/trunk@46391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 20:43:04 +00:00
Sergey Biryukov
552852d887 Docs: Improve documentation for esc_attr_e(), esc_html_e(), esc_attr_x(), esc_html_x(). 
Props atachibana.
Fixes #48383.
Built from https://develop.svn.wordpress.org/trunk@46593


git-svn-id: http://core.svn.wordpress.org/trunk@46390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 17:30:03 +00:00
Sergey Biryukov
ac3ff7eb1a Docs: Improve documentation for wptexturize(). 
Props atachibana.
Fixes #48397.
Built from https://develop.svn.wordpress.org/trunk@46592


git-svn-id: http://core.svn.wordpress.org/trunk@46389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 00:58:04 +00:00
Sergey Biryukov
67ce1885db Docs: Improve formatting of various WP_Screen DocBlocks. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@46591


git-svn-id: http://core.svn.wordpress.org/trunk@46388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 00:36:05 +00:00
Sergey Biryukov
67c73ea3ea Docs: Improve documentation for WP_Screen::add_help_tab(). 
Props atachibana.
Fixes #48395.
Built from https://develop.svn.wordpress.org/trunk@46590


git-svn-id: http://core.svn.wordpress.org/trunk@46387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 00:34:07 +00:00
Sergey Biryukov
49007e52bc Build/Test Tools: Add banner to RTL CSS and minified JS files. 
Patches occasionally come in on generated files. We should be kind to new contributors and give them a hint that these files are auto-generated.

This is a follow-up to [41271], which added the banner to minified CSS files.

Fixes #48424. See #30666.
Built from https://develop.svn.wordpress.org/trunk@46589


git-svn-id: http://core.svn.wordpress.org/trunk@46386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 00:17:07 +00:00
desrosj
b51327d391 Ensure svn:mime-type is consistently set for appropriate files. 
Continuation of [46586], [46587]

See #42594.
Built from https://develop.svn.wordpress.org/trunk@46588


git-svn-id: http://core.svn.wordpress.org/trunk@46385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 19:33:04 +00:00
desrosj
09d8704f0f Ensure svn:eol-style is consistently set for all files (part 2). 
Continuation of [46586]

See #42594.
Built from https://develop.svn.wordpress.org/trunk@46587


git-svn-id: http://core.svn.wordpress.org/trunk@46384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 19:29:04 +00:00
desrosj
eca853c79e Ensure svn:eol-style is consistently set for all files. 
See #42594.
Built from https://develop.svn.wordpress.org/trunk@46586


git-svn-id: http://core.svn.wordpress.org/trunk@46383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 16:38:07 +00:00
desrosj
43c6bc6805 Remove the svn:executable property from files that don't need it. 
See #42594.
Built from https://develop.svn.wordpress.org/trunk@46585


git-svn-id: http://core.svn.wordpress.org/trunk@46382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 15:36:05 +00:00
Sergey Biryukov
9ebaa9d522 Date/Time: Remove incomplete and redundant test for get_post_time() added in [46580]. 
There is no functional difference between `gmt_offset` and `timezone_string` timezone modes for the issue.

See #48384.
Built from https://develop.svn.wordpress.org/trunk@46583


git-svn-id: http://core.svn.wordpress.org/trunk@46380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 15:11:04 +00:00
desrosj
a922509f96 Trunk is now 5.4 alpha. 
Built from https://develop.svn.wordpress.org/trunk@46582


git-svn-id: http://core.svn.wordpress.org/trunk@46379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 14:24:04 +00:00
Sergey Biryukov
75c183c248 Date/Time: Make sure get_post_time() keeps UTC time on timezone change. 
Add `$source` parameter to `get_post_datetime()` to instantiate from local or UTC time in database.

Props Rarst, david.binda.
Reviewed by azaozz, SergeyBiryukov.
Fixes #48384.
Built from https://develop.svn.wordpress.org/trunk@46580


git-svn-id: http://core.svn.wordpress.org/trunk@46377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 13:08:05 +00:00
Sergey Biryukov
7e11e9d732 Posts, Post Types: Remove unintended change from [46578]. 
See #48384.
Built from https://develop.svn.wordpress.org/trunk@46579


git-svn-id: http://core.svn.wordpress.org/trunk@46376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 12:54:03 +00:00
Sergey Biryukov
0b83bffd45 Date/Time: Correct the logic in WP_Posts_List_Table::column_date() and WP_Media_List_Table::column_date() to check for a valid post timestamp. 
Props Rarst.
Reviewed by azaozz, SergeyBiryukov.
See #48384.
Built from https://develop.svn.wordpress.org/trunk@46578


git-svn-id: http://core.svn.wordpress.org/trunk@46375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 12:51:03 +00:00
Sergey Biryukov
8410526528 Date/Time: Make sure date_i18n() correctly handles zero timestamp after [45901]. 
Props soulseekah, gravityview, Rarst.
Reviewed by azaozz, SergeyBiryukov.
Fixes #28636.
Built from https://develop.svn.wordpress.org/trunk@46577


git-svn-id: http://core.svn.wordpress.org/trunk@46374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 11:05:07 +00:00
desrosj
5e18c8320b Build/Test Tools: Update the https-proxy-agent dependency. 
Fixes #48428.
Built from https://develop.svn.wordpress.org/trunk@46576


git-svn-id: http://core.svn.wordpress.org/trunk@46373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 00:24:05 +00:00
Andrea Fercia
5b85aa1936 Accessibility: Restore the primary buttons original background color for alternate color schemes after [46241]. 
Props david.binda, audrasjb, azaozz.
See #34904.
Fixes #48396.

Built from https://develop.svn.wordpress.org/trunk@46575


git-svn-id: http://core.svn.wordpress.org/trunk@46372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-23 20:57:05 +00:00
desrosj
cc73b9a1be Post WordPress 5.3 RC2 version bump. 
Built from https://develop.svn.wordpress.org/trunk@46574


git-svn-id: http://core.svn.wordpress.org/trunk@46371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-22 20:11:05 +00:00
desrosj
ca5925d6dc WordPress 5.3 RC2. 
Built from https://develop.svn.wordpress.org/trunk@46573


git-svn-id: http://core.svn.wordpress.org/trunk@46370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-22 19:44:06 +00:00
desrosj
27994975f9 Help/About: Update the 5.3 About page for RC2. 
This includes numerous improvements:

- Removes the jazzer name.
- Ensures `WordPress` is translatable for consistency with other occurrences in Core.
- Changes all instances of `Block Editor` to `block editor` to match the spelling best practices.
- Updates the PHP 7.4 compatibility section with more suitable text.
- Introduction in `credits.php`, `freedoms.php`, and `privacy.php` have been updated to be consistent with the About page.
- Fixes the `aria-current` attribute in tab navigation.

Reviewed by SergeyBiryukov, desrosj.
Props SergeyBiryukov, audrasjb, desrosj, ryelle, afercia.
See #47708.
Built from https://develop.svn.wordpress.org/trunk@46572


git-svn-id: http://core.svn.wordpress.org/trunk@46369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-22 19:19:07 +00:00
desrosj
16e5753b48 Bundled Themes: Update Twenty Twenty. 
This brings `trunk`’s version of Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46551], see bc89c51...4549fd9.

Reviewed by SergeyBiryukov, desrosj, ianbelanger.
Props anlino, ianbelanger, poena, williampatton, nielslange, acosmin, intimez, itowhid06, decrecementofeliz, aristath, westonruter, mukesh27, jorgefilipecosta, karmatosed.
Fixes #48386.
Built from https://develop.svn.wordpress.org/trunk@46571


git-svn-id: http://core.svn.wordpress.org/trunk@46368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-22 18:27:08 +00:00
Sergey Biryukov
0609e04266 Administration: Relax the default value check for the $position argument added to add_submenu_page() and related functions in [46197]. 
Due to a confusion with `add_menu_page()`, which takes the `$icon_url` parameter, while `add_submenu_page()` does not, some plugins were passing in a string instead of integer as `$position`, causing backward compatibility issues.

A `_doing_it_wrong()` message is now added to alert developers of the wrong parameter type.

Props david.binda, desrosj, 123host, dennis_f, MattyRob.
Reviewed by desrosj.
Fixes #48249.
Built from https://develop.svn.wordpress.org/trunk@46570


git-svn-id: http://core.svn.wordpress.org/trunk@46367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-22 17:52:04 +00:00
Sergey Biryukov
4e06f0ad40 Date/Time: Make sure wp_date() does not unnecessarily escape localized numbers, but keeps localized slashes. 
Props Rarst, tmatsuur, remcotolsma, peterwilsoncc.
Reviewed by peterwilsoncc.
Fixes #48319.
Built from https://develop.svn.wordpress.org/trunk@46569


git-svn-id: http://core.svn.wordpress.org/trunk@46366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-22 17:31:08 +00:00
Sergey Biryukov
ff65cfcacf Plugins: Restore backward compatibility for PHP4-style passing of array( &$this ) as action argument to do_action(). 
This is a follow-up to [46149] to avoid unnecessary breakage in case of using the old notation.

Props david.binda, jrf.
Reviewed by azaozz.
Fixes #48312.
Built from https://develop.svn.wordpress.org/trunk@46568


git-svn-id: http://core.svn.wordpress.org/trunk@46365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-22 00:11:03 +00:00
Andrew Ozz
b37a2b5c3b Media: After [46237] add the same fix to the .button-group on the "Insert form URL" screen in the media modal. 
Props afercia, sabernhardt.
FIxes #48087.
Built from https://develop.svn.wordpress.org/trunk@46567


git-svn-id: http://core.svn.wordpress.org/trunk@46364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-21 23:23:04 +00:00
Andrew Ozz
5013b45775 Upload: Expand error codes to include all 5xx HTTP errors when retrying to create image sub-sizes. Some servers may be configured to set HTTP 508 or 504, or possibly other 5 errors. 
Porps mikeschroder, azaozz.
Fixes #48379.
Built from https://develop.svn.wordpress.org/trunk@46566


git-svn-id: http://core.svn.wordpress.org/trunk@46363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-21 22:44:03 +00:00
Andrew Ozz
e1560cd1e0 Media/Upload: When the users upload big images and WordPress creates a scaled image to use as the largest size, append scaled- to the file names of the scaled images to make them easier to recognize. 
Props kraftbj, azaozz.
Fixes #48304.
Built from https://develop.svn.wordpress.org/trunk@46565


git-svn-id: http://core.svn.wordpress.org/trunk@46362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-21 21:43:04 +00:00
Sergey Biryukov
654c413990 Comments: Add rel="nofollow ugc" attribute when converting plain URLs to <a> tags in comments via make_clickable(). 
Introduce `make_clickable_rel` filter for the `rel` value that is added to URL matches converted to links.

This is a follow-up to [46349], which added the `rel="nofollow ugc"` attribute to existing `<a>` tags in comments via `wp_rel_ugc()`.

UGC stands for User Generated Content, and the `ugc` attribute value is recommended for links within user generated content, such as comments and forum posts.

See https://webmasters.googleblog.com/2019/09/evolving-nofollow-new-ways-to-identify.html.

Props blogginglife, SergeyBiryukov.
Reviewed by desrosj, audrasjb.
Fixes #48022.
Built from https://develop.svn.wordpress.org/trunk@46564


git-svn-id: http://core.svn.wordpress.org/trunk@46361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-21 20:41:04 +00:00
K. Adam White
cfec48cc31 REST API: Cast empty meta values to correct scalar types in REST response. 
Introducing complex meta value handling in [45807] unintentionally removed value casting for empty scalar meta values.

Props TimothyBlynJacobs, chrisvanpatten, rmccue, kadamwhite.
Fixes #48363.


Built from https://develop.svn.wordpress.org/trunk@46563


git-svn-id: http://core.svn.wordpress.org/trunk@46360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-21 19:10:06 +00:00
youknowriad
21bf3bf8dd Block Editor: Update Packages that include WP 5.3 RC2 fixes. 
Updated packages:
 - @wordpress/api-fetch@3.6.3
 - @wordpress/block-directory@1.0.3
 - @wordpress/block-editor@3.2.3
 - @wordpress/block-library@2.9.3
 - @wordpress/core-data@2.7.3
 - @wordpress/data-controls@1.3.3
 - @wordpress/e2e-test-utils@2.4.3
 - @wordpress/e2e-tests@1.7.3
 - @wordpress/edit-post@3.8.3
 - @wordpress/editor@9.7.3
 - @wordpress/format-library@1.9.3
 - @wordpress/list-reusable-blocks@1.8.3
 - @wordpress/media-utils@1.2.3
 - @wordpress/server-side-render@1.3.3
 - @wordpress/url@2.8.2

Props gziolo.
Fixes #48381.

Built from https://develop.svn.wordpress.org/trunk@46562


git-svn-id: http://core.svn.wordpress.org/trunk@46359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-21 14:02:07 +00:00
John Blackbourn
67104bb3f4 Administration: Revert changes to the admin menu styles for long line lengths. 
This reverts [46555], [46453], and [46332].

See #42201

Built from https://develop.svn.wordpress.org/trunk@46561


git-svn-id: http://core.svn.wordpress.org/trunk@46358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-17 18:38:03 +00:00
desrosj
1d6bd71ce4 Upgrade/Install: Use a unique error code when an update fails due to the PHP JSON extension missing. 
This allows update failures caused when the native PHP JSON extension is missing to be distinguished from updates that fail because the site does not meet the minimum PHP requirements.

Follow up of [46455].

Reviewed by desrosj, jorbin, johnbillion.
Fixes #47699.
Built from https://develop.svn.wordpress.org/trunk@46560


git-svn-id: http://core.svn.wordpress.org/trunk@46357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-16 21:03:02 +00:00
Andrea Fercia
44de60e8da Script Loader: Partially revert [46550] as it brought in unrelated CSS changes. 
[46550] was meant to revert [46440] but it also merged some unrelated CSS changes.

See #47069.

Built from https://develop.svn.wordpress.org/trunk@46559


git-svn-id: http://core.svn.wordpress.org/trunk@46356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-16 17:49:03 +00:00
Sergey Biryukov
76fe29b746 Post WordPress 5.3 RC1 version bump 
Built from https://develop.svn.wordpress.org/trunk@46558


git-svn-id: http://core.svn.wordpress.org/trunk@46355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 21:14:01 +00:00
Sergey Biryukov
05cbe81439 WordPress 5.3 RC1 
Built from https://develop.svn.wordpress.org/trunk@46557


git-svn-id: http://core.svn.wordpress.org/trunk@46354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 20:50:05 +00:00
John Blackbourn
2ab1e4dcd8 Help/About: Let's tell the world about 5.3. 
Props karmatosed, melchoyce, pierlo, ryelle, afercia, audrasjb, davidbaumwald

Thanks to everyone who provided feedback for this page for 5.3.

See #47708

Built from https://develop.svn.wordpress.org/trunk@46556


git-svn-id: http://core.svn.wordpress.org/trunk@46353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 20:42:03 +00:00
John Blackbourn
7cdb93a374 Administration: Fix the appearance of update bubbles in submenus and when the admin menu is collapsed. 
Props afercia, amolv, sabernhardt

Fixes #42201, #48294

Built from https://develop.svn.wordpress.org/trunk@46555


git-svn-id: http://core.svn.wordpress.org/trunk@46352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 19:39:01 +00:00
Sergey Biryukov
b052bca67e Shortcodes: Revert [46369] for now to allow more time to investigate and prepare for backward compatibility changes. 
Also reverts follow-up changes in [46370] and [46465].

See #47863.
Built from https://develop.svn.wordpress.org/trunk@46554


git-svn-id: http://core.svn.wordpress.org/trunk@46351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 19:36:02 +00:00
Andrew Ozz
f7968ccb92 Media: Similarly to wp_get_original_image_path() add wp_get_original_image_url() to always retrieve the URL to the original uploaded image. 
Props kraftbj.
Fixes #48302.
Built from https://develop.svn.wordpress.org/trunk@46553


git-svn-id: http://core.svn.wordpress.org/trunk@46350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 19:12:02 +00:00
Sergey Biryukov
93e28555ae Build/Test Tools: Move PHP 7.4 to the top of the list for consistency. 
See #48232.
Built from https://develop.svn.wordpress.org/trunk@46552


git-svn-id: http://core.svn.wordpress.org/trunk@46349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 18:53:02 +00:00
desrosj
908961974e Bundled Themes: Update Twenty Twenty. 
This brings `trunk`’s version of Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46445], see 7246fd6...bc89c51.

Props anlino, ianbelanger, poena, williampatton, nielslange, acosmin, netweb, joyously, mahesh901122, josephscott, byalextran, amolv, Clorith.
See #48110.
Built from https://develop.svn.wordpress.org/trunk@46551


git-svn-id: http://core.svn.wordpress.org/trunk@46348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 18:47:02 +00:00
Andrea Fercia
02810533c4 Accessibility: Script Loader: Remove jQuery as dependency of admin-bar after [46440]. 
A better approach needs to be explored, as there are valid concerns for potential conflicts between different jQuery versions added by themes or plugins.

See #47069.

Built from https://develop.svn.wordpress.org/trunk@46550


git-svn-id: http://core.svn.wordpress.org/trunk@46347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 17:23:04 +00:00
Andrea Fercia
d5bfc553b9 Accessibility: Media: Improve the Media Modal spinner position after [46418]. 
Fixes #47138.

Built from https://develop.svn.wordpress.org/trunk@46549


git-svn-id: http://core.svn.wordpress.org/trunk@46346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 16:47:02 +00:00
Sergey Biryukov
71e8fedf6c Customize: Ensure that WP_Customize_Manager::import_theme_starter_content() properly handles starter content with (nested) arrays as values. 
Previously, searching for symbol references to replace with post or attachment IDs in array values resulted in a PHP warning.

Props timph, JarretC, SergeyBiryukov.
Fixes #45484.
Built from https://develop.svn.wordpress.org/trunk@46548


git-svn-id: http://core.svn.wordpress.org/trunk@46345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 16:43:01 +00:00
Aaron Jorbin
52dee3c19b Build/Test: Remove PHP 7.4 from allowed failures 
PHP7.4 is supported in WordPress 5.3. 🐘 🎉

Fixes: #48232.


Built from https://develop.svn.wordpress.org/trunk@46547


git-svn-id: http://core.svn.wordpress.org/trunk@46344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 16:38:03 +00:00
jorgefilipecosta
16571b1bfb Block Editor: Update the WordPress Packages to the ones used in the Gutenberg 6.8 release. 
Updated packages:
@wordpress/a11y@2.5.1
@wordpress/annotations@1.7.2
@wordpress/api-fetch@3.6.2
@wordpress/autop@2.5.1
@wordpress/babel-preset-default@4.6.2
@wordpress/blob@2.5.1
@wordpress/block-directory@1.0.2
@wordpress/block-editor@3.2.2
@wordpress/block-library@2.9.2
@wordpress/block-serialization-default-parser@3.4.1
@wordpress/block-serialization-spec-parser@3.3.1
@wordpress/blocks@6.7.2
@wordpress/components@8.3.2
@wordpress/compose@3.7.2
@wordpress/core-data@2.7.2
@wordpress/data-controls@1.3.2
@wordpress/data@4.9.2
@wordpress/deprecated@2.6.1
@wordpress/dom-ready@2.5.1
@wordpress/dom@2.5.2
@wordpress/e2e-test-utils@2.4.2
@wordpress/e2e-tests@1.7.2
@wordpress/edit-post@3.8.2
@wordpress/editor@9.7.2
@wordpress/element@2.8.2
@wordpress/escape-html@1.5.1
@wordpress/format-library@1.9.2
@wordpress/is-shallow-equal@1.6.1
@wordpress/keycodes@2.6.2
@wordpress/list-reusable-blocks@1.8.2
@wordpress/media-utils@1.2.2
@wordpress/notices@1.8.2
@wordpress/nux@3.7.2
@wordpress/plugins@2.7.2
@wordpress/priority-queue@1.3.1
@wordpress/redux-routine@3.6.2
@wordpress/rich-text@3.7.2
@wordpress/scripts@5.1.0
@wordpress/server-side-render@1.3.2
@wordpress/url@2.8.1
@wordpress/viewport@2.8.2
@wordpress/wordcount@2.6.2

Props gziolo, youknowriad.
Fixes: #48310
Built from https://develop.svn.wordpress.org/trunk@46546


git-svn-id: http://core.svn.wordpress.org/trunk@46343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 16:17:12 +00:00
whyisjake
6c3a387d77 REST API: Allow for multiple Vary: Origin headers in GET responses. 
Simple fix, we pass `false` as the second parameter to the header function.

This is something that we added downstream of the 5.2.4 release, but we missed in 5.2/trunk.

Fixes #48309.
Props xknown, whyisjake.

Built from https://develop.svn.wordpress.org/trunk@46544


git-svn-id: http://core.svn.wordpress.org/trunk@46341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 15:47:03 +00:00
gziolo
aca0d9968f Block Editor: Remove experimental Social Links blocks 
We decided to mark Social Links block as an experimental feature in Gutenberg. In effect, we are moving all related code from WordPress 5.3 release.

Props youknowriad.

Fixes #48263.


Built from https://develop.svn.wordpress.org/trunk@46543


git-svn-id: http://core.svn.wordpress.org/trunk@46340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 15:37:08 +00:00
Aaron Jorbin
1740246d2b Build/Test tools use Trunk revision 2170172 of importer 
Update Travis configuration to temporarily use trunk for the importer in order for PHP 7.4 tests to pass. When the new version is released, this will be updated to point to that tag.

See: #48231


Built from https://develop.svn.wordpress.org/trunk@46542


git-svn-id: http://core.svn.wordpress.org/trunk@46339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 14:42:04 +00:00
Andrew Ozz
1940cf7d54 Media: Do not store error messages in the image meta. The initial idea was to (be able to) display these errors in the UI but it wasn't implemented as these errors are mostly helpful for low-level bedugging. 
Fixes #40439.
Built from https://develop.svn.wordpress.org/trunk@46507


git-svn-id: http://core.svn.wordpress.org/trunk@46304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-14 20:05:01 +00:00
Andrew Ozz
49686be2ab Uploads: Retry to post-process images after HTTP 500 and HTTP 502 errors. 
Props mikeschroder, azaozz.
Fixes #47872.
Built from https://develop.svn.wordpress.org/trunk@46506


git-svn-id: http://core.svn.wordpress.org/trunk@46303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-14 19:56:06 +00:00
Andrea Fercia
135bebc55b Accessibility: Media: Improve the text of the Media Modal actions toggle button displayed in the responsive view. 
See #47149.

Built from https://develop.svn.wordpress.org/trunk@46489


git-svn-id: http://core.svn.wordpress.org/trunk@46287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-14 18:03:04 +00:00
Andrea Fercia
c1d4bf2080 Accessibility: Media: Improve the new Media Modal headings text. 
See #47610.

Built from https://develop.svn.wordpress.org/trunk@46488


git-svn-id: http://core.svn.wordpress.org/trunk@46286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-14 17:58:04 +00:00
whyisjake
72130f11d0 Administration: Ensure that admin referer nonce is valid. 
Fix for a testing regression.

Props desrosj.

Built from https://develop.svn.wordpress.org/trunk@46485


git-svn-id: http://core.svn.wordpress.org/trunk@46283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-14 17:15:06 +00:00
whyisjake
89468bfb89 REST API: Ensure that we don't generate warnings from sending extra headers after headers have been sent. 
Fixes issues stemming from [46478].


Built from https://develop.svn.wordpress.org/trunk@46483


git-svn-id: http://core.svn.wordpress.org/trunk@46281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-14 16:25:04 +00:00
whyisjake
b224c251ad REST API: Send a Vary: Origin header on GET requests. 
Add this header on all GET requests to prevent cached requests.

Props darthhexx, davidbinda, nickdaugherty, whyisjake.

Built from https://develop.svn.wordpress.org/trunk@46478


git-svn-id: http://core.svn.wordpress.org/trunk@46276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-14 15:43:04 +00:00
whyisjake
b183fd1cca Administration: Ensure that admin referer nonce is valid. 
Coding standards, ensure that nonce is valid with identical, rather then equal operator.

Props vortfu, xknown, whyisjake.

Built from https://develop.svn.wordpress.org/trunk@46477


git-svn-id: http://core.svn.wordpress.org/trunk@46275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-14 15:40:04 +00:00
whyisjake
2524ba3aec Filesystem API: Prevent directory travelersals when creating new folders. 
Reject file paths that contain sub-directory paths.

Props iandunn, xknown, sstoqnov, whyisjake.

Built from https://develop.svn.wordpress.org/trunk@46476


git-svn-id: http://core.svn.wordpress.org/trunk@46274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-14 15:31:04 +00:00
whyisjake
608d39faed HTTP API: Protect against hex interpretation. 
Return earlier from wp_http_validate_url().

Props: iandunn, xknown, voldemortensen, whyisjake.

Built from https://develop.svn.wordpress.org/trunk@46475


git-svn-id: http://core.svn.wordpress.org/trunk@46273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-14 15:27:04 +00:00
whyisjake
946ec8492f Query: Remove the static query property. 
Prevent unauthenticated views of publicly queryables content types.

Props aaroncampbell, whyisjake, nickdaugherty, xknown.

Built from https://develop.svn.wordpress.org/trunk@46474


git-svn-id: http://core.svn.wordpress.org/trunk@46272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-14 15:20:03 +00:00
Sergey Biryukov
9db44754b9 Formatting: In wp_validate_redirect(), normalize the path when validating the location for relative URLs, to account for Windows paths. 
Props peterwilsoncc, rconde, jmmathc, mat-lipe, Sixes, justinahinon, cmagrin, daxelrod, SergeyBiryukov.
Fixes #47980.
Built from https://develop.svn.wordpress.org/trunk@46472


git-svn-id: http://core.svn.wordpress.org/trunk@46270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-14 10:52:04 +00:00
Sergey Biryukov
e8fcc3fbe7 Docs: Fix typo in a comment in WP_REST_Settings_Controller::prepare_value(). 
Convert the comment to a multi-line format per the documentation standards.

Props itowhid06.
See #48296.
Built from https://develop.svn.wordpress.org/trunk@46471


git-svn-id: http://core.svn.wordpress.org/trunk@46269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-13 10:02:04 +00:00
Peter Wilson
5d6cd13597 Docs: Correct documentation typo in print_emoji_detection_script(). 
Props itowhid06.
Fixes #48298. See #47110.

Built from https://develop.svn.wordpress.org/trunk@46470


git-svn-id: http://core.svn.wordpress.org/trunk@46268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-13 02:48:01 +00:00
Peter Wilson
8730eb34e3 Docs: Correct comment typo in WP_REST_Terms_Controller::update_item(). 
Props manikmist09.
Fixes #48295. See #47110.

Built from https://develop.svn.wordpress.org/trunk@46469


git-svn-id: http://core.svn.wordpress.org/trunk@46267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-13 02:42:01 +00:00
John Blackbourn
41d6b80d03 Docs: Fix and improve inline documentation for the HTTP API. 
See #47110

Built from https://develop.svn.wordpress.org/trunk@46468


git-svn-id: http://core.svn.wordpress.org/trunk@46266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-12 18:05:04 +00:00
Sergey Biryukov
634242343c Users: Make sure wp_logout() clears current user, so that a subsequent call to is_user_logged_in() works as expected. 
Props sebastian.pisula, donmhico, roytanck, juliobox.
Fixes #35488.
Built from https://develop.svn.wordpress.org/trunk@46467


git-svn-id: http://core.svn.wordpress.org/trunk@46265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-12 03:10:03 +00:00
Sergey Biryukov
4ca89cecbd Tests: Rename tests methods in tests/pluggable.php per the handbook's naming convention. 
See #47632.
Built from https://develop.svn.wordpress.org/trunk@46466


git-svn-id: http://core.svn.wordpress.org/trunk@46264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-12 03:02:03 +00:00
Sergey Biryukov
cf1c5e1b54 Docs: Adjust @since note in shortcode_parse_atts() for consistency with similar notes. 
See #47863.
Built from https://develop.svn.wordpress.org/trunk@46465


git-svn-id: http://core.svn.wordpress.org/trunk@46263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-12 02:50:03 +00:00
Sergey Biryukov
b0e0f69b2e I18N: Don't capitalize "Extension" in update_core(), for consistency with other strings. 
Follow-up to [46455].

See #47699.
Built from https://develop.svn.wordpress.org/trunk@46464


git-svn-id: http://core.svn.wordpress.org/trunk@46262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-12 02:42:01 +00:00
Sergey Biryukov
e19329bad0 Docs: Add requires_php to the list of fields returned by plugins_api(). 
Props ediamin.
Fixes #48291.
Built from https://develop.svn.wordpress.org/trunk@46463


git-svn-id: http://core.svn.wordpress.org/trunk@46261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-12 02:35:04 +00:00
Sergey Biryukov
b78a40aa4c Formatting: Make sure wp_sanitize_redirect() encodes spaces in URLs instead of stripping them out. 
Props donmhico, hlashbrooke, dd32, azaozz.
Fixes #36998.
Built from https://develop.svn.wordpress.org/trunk@46462


git-svn-id: http://core.svn.wordpress.org/trunk@46260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-11 23:54:03 +00:00
antpb
97356bbd75 Media: Adds Edit Image controller to Media Library select frame. 
This adds the necessary state for `EditImage` views in the `select` frame and listeners for setting that view.

Props fblaser, w3rkjana, afercia, antpb.
See #48028.

Built from https://develop.svn.wordpress.org/trunk@46461


git-svn-id: http://core.svn.wordpress.org/trunk@46259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-11 20:43:03 +00:00
antpb
ebd52ce048 Administration: Prevents horizontal scroll jumping around while admin menu is open. 
This sets the `#adminmenuback` `position` CSS property to `fixed`.

Props promz, man4toman.
Fixes #47010.

Built from https://develop.svn.wordpress.org/trunk@46460


git-svn-id: http://core.svn.wordpress.org/trunk@46258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-11 19:22:02 +00:00
Mike Schroder
66c8085fc4 Media: Update fallback previews to support _wp_make_subsizes() 
Allows fallback previews (PDF by default, in core) to save image meta
after each size is generated to allow for resuming, and make sizes
immediately available.

Props azaozz, antpb, progremzion, mikeschroder.
See #48111.
Built from https://develop.svn.wordpress.org/trunk@46459


git-svn-id: http://core.svn.wordpress.org/trunk@46257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-11 07:54:03 +00:00
Aaron Jorbin
742537ac3d Cron: Prevent sending headers when using ALTERNATE_WP_CRON 
ALTERNATE_WP_CRON echos things which causes a "Headers already sent" warning. This adds a check to ensure headers haven't already been sent.

Previously: [45560]

See: #45560. Fixes #48283.
Props dlh.


Built from https://develop.svn.wordpress.org/trunk@46458


git-svn-id: http://core.svn.wordpress.org/trunk@46256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-10 22:52:03 +00:00
Dominik Schilling
c621d4fb3f Themes: Convert core-provided starter content to block content. 
Props Clorith.
Fixes #48130.
Built from https://develop.svn.wordpress.org/trunk@46457


git-svn-id: http://core.svn.wordpress.org/trunk@46255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-10 19:07:05 +00:00
K. Adam White
1a8aba96e7 REST API: Fix error in _fields filtering logic where only one of several requested sibling properties would be included. 
Props kadamwhite, TimothyBlynJacobs.
Fixes #48266.

Built from https://develop.svn.wordpress.org/trunk@46456


git-svn-id: http://core.svn.wordpress.org/trunk@46254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-10 17:18:03 +00:00
desrosj
c6d3987b08 Upgrade/Install: Detect the presence of the native PHP JSON extension before updating. 
The PHP native JSON extension has been bundled and compiled with PHP by default since version 5.2.0. Because the minimum version of PHP required by WordPress is now 5.6.20 (see #46594 and [45058]), the related polyfills and workarounds have been removed (see [46205-46206,46208]).

However, even though the JSON extension is now included in PHP by default, it is still possible to disable the extension in a custom configuration. This change will prevent sites from upgrading if the JSON extension is disabled to prevent compatibility issues.

Props jrf, jorbin, dd32, desrosj.
Fixes #47699.
Built from https://develop.svn.wordpress.org/trunk@46455


git-svn-id: http://core.svn.wordpress.org/trunk@46253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-09 22:22:04 +00:00
K. Adam White
55560a708f REST API: Do not addslash when receiving meta arrays of non-string values. 
Slashing non-string data caused PUT requests containing unmodified meta arrays of integers to fail the check against the existing stored meta value, causing a 500 when posting an unmodified response body back to the server.

Props TimothyBlynJacobs, augustuswm.
Fixes #48264.

Built from https://develop.svn.wordpress.org/trunk@46454


git-svn-id: http://core.svn.wordpress.org/trunk@46252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-09 17:36:01 +00:00
whyisjake
ec02d199f4 Administration: Ensure visual consistency with large titles in the sidebar. 
Custom posts, and other menu titles that are long aren't wrapping correctly.

Props jagirbaheshwp, munyagu, harshbarach, hareesh-pillai, pratikkry, naveenkharwar, mukesh27, dushanthi, worldweb, audrasjb, afercia, amolv, iqbalbary, davidbaumwald.
Fixes #42201

Built from https://develop.svn.wordpress.org/trunk@46453


git-svn-id: http://core.svn.wordpress.org/trunk@46251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-09 04:58:02 +00:00
Sergey Biryukov
13eecfc861 Docs: Tweak the @since note in Walker::walk() and ::paged_walk() for better readability and consistency with other notes. 
See #47678.
Built from https://develop.svn.wordpress.org/trunk@46452


git-svn-id: http://core.svn.wordpress.org/trunk@46250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-09 04:35:01 +00:00
Sergey Biryukov
8d1e51e9c7 Docs: Add a @since note about new parameters with the spread operator added to function signatures. 
Props jrf.
See #47678.
Built from https://develop.svn.wordpress.org/trunk@46451


git-svn-id: http://core.svn.wordpress.org/trunk@46249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-09 04:28:02 +00:00
desrosj
6a38614ffe Bundled Themes: Update/audit NPM dependencies for Twenty Nineteen. 
Also, ignore the `node_modules` folder for Twenty Nineteen.

Fixes #48262.
Built from https://develop.svn.wordpress.org/trunk@46450


git-svn-id: http://core.svn.wordpress.org/trunk@46248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-08 22:19:02 +00:00
Adam Silverstein
376c13f07c Post WordPress 5.3 Beta 3 version bump. 
Built from https://develop.svn.wordpress.org/trunk@46449


git-svn-id: http://core.svn.wordpress.org/trunk@46247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-08 20:47:02 +00:00
Adam Silverstein
0820f95896 WordPress 5.3 Beta 3. 
Built from https://develop.svn.wordpress.org/trunk@46448


git-svn-id: http://core.svn.wordpress.org/trunk@46246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-08 19:59:03 +00:00
Dominik Schilling
0b67a91c1c Bundled Themes: Fix JSHint error in [46445] 
Props ianbelanger.
See #48110.
Built from https://develop.svn.wordpress.org/trunk@46447


git-svn-id: http://core.svn.wordpress.org/trunk@46245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-08 19:52:03 +00:00
desrosj
faaf3be0b1 Bundled Themes: Change the eol-style property to native for Twenty Twenty files. 
Props aazaozz, desrosj.
See #48110.
Built from https://develop.svn.wordpress.org/trunk@46446


git-svn-id: http://core.svn.wordpress.org/trunk@46244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-08 19:21:02 +00:00
desrosj
a734d8eea1 Bundled Themes: Update Twenty Twenty. 
This brings `trunk`'s version of Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46357], see 7157870...7246fd6.

Props anlino, ianbelanger, poena, williampatton, nielslange, acosmin, netweb, joyusly, luminuu, itowhid06, cbravobernal, intimez, glauberglauber, ocean90, amolv, briceduclos, aristath, mukesh27, garrett-eclipse, audrasjb, afercia, dianeco, utsav72640, mahesh901122, tobifjellner.
See #48110.
Built from https://develop.svn.wordpress.org/trunk@46445


git-svn-id: http://core.svn.wordpress.org/trunk@46243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-08 19:08:07 +00:00
Sergey Biryukov
843c39b9bc Themes: Properly align Close/Previous/Next icons in theme preview overlay. 
Props chetan200891.
Fixes #48248.
Built from https://develop.svn.wordpress.org/trunk@46444


git-svn-id: http://core.svn.wordpress.org/trunk@46242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-08 19:07:04 +00:00
Sergey Biryukov
93279742c1 Themes: Adjust CSS media query for theme overlay to match the breakpoint for a folded admin menu. 
Props chetan200891.
Fixes #48250.
Built from https://develop.svn.wordpress.org/trunk@46443


git-svn-id: http://core.svn.wordpress.org/trunk@46241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-08 18:49:03 +00:00
Sergey Biryukov
38a8513cf2 Code Modernisation: Introduce the spread operator in Walker::walk() and ::paged_walk(). 
Rather than relying on `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

This re-applies [45624] and reverts [45640], with a dev note upcoming for plugin authors to maintain backward compatibility with old versions of WordPress.

Props jrf.
See #47678.
Built from https://develop.svn.wordpress.org/trunk@46442


git-svn-id: http://core.svn.wordpress.org/trunk@46240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-08 17:56:02 +00:00
johnjamesjacoby
477f0ffd71 Network Admin: Improve Site States in List Table rows. 
This commit switches a comparison to a Yoda condition, performs a more strict `intval()` check on the value of the Site Status column, and prevents a specific Site State from appearing in List Table rows when filtering by that same Site State already (to match the behavior of other List Table State implementations.)

Fixes #37684. Props pbiron.
Built from https://develop.svn.wordpress.org/trunk@46441


git-svn-id: http://core.svn.wordpress.org/trunk@46239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-08 17:46:02 +00:00
Andrea Fercia
a0a037db4d Accessibility: Script Loader: Add jQuery as dependency of admin-bar. 
On the front end, themes that don't use jQuery make the admin bar fallback to the non-jQuery implementation. Some important features miss from the non-jQuery `admin-bar.js` part, for example `hoverintent` and, most importantly, the touch events for the mobile menu don't work at all.

Enqueueing jQuery is the simplest option for now. For the future, a complete rewriting of `admin-bar.js` in plain JavaScript is highly recommended.

See #47069.

Built from https://develop.svn.wordpress.org/trunk@46440


git-svn-id: http://core.svn.wordpress.org/trunk@46238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-08 17:21:13 +00:00
Sergey Biryukov
760a55b310 Docs: Add missing @deprecated tags in the file docblock of some deprecated files. 
Props jrf.
Fixes #48254.
Built from https://develop.svn.wordpress.org/trunk@46439


git-svn-id: http://core.svn.wordpress.org/trunk@46237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-08 17:19:04 +00:00
Andrea Fercia
932df464e6 Accessibility: Media: Improve the logic to render the ARIA tabs markup after [46363]. 
Additionally checks for the "menu" and "router" state attributes to better determine when the ARIA tabs pattern markup is appropriate.

See #47149.

Built from https://develop.svn.wordpress.org/trunk@46438


git-svn-id: http://core.svn.wordpress.org/trunk@46236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-08 17:07:02 +00:00
Sergey Biryukov
fefc2f56ed I18N: Add context for the Archives string introduced in [45651] as a file type heading, to disambiguate from other types of archives. 
Props alexclassroom.
Fixes #48259.
Built from https://develop.svn.wordpress.org/trunk@46437


git-svn-id: http://core.svn.wordpress.org/trunk@46235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-08 17:04:03 +00:00
Adam Silverstein
9fb51e962a External Libraries: upgrade mediaelement to version 4.2.13. 
Upgrade `mediaelement` to the latest version. Includes a variety of bug fixes made since the 4.2.6 release; see https://github.com/mediaelement/mediaelement/releases.

Props danieliser, Hareesh Pillai.
Fixes #46681.


Built from https://develop.svn.wordpress.org/trunk@46436


git-svn-id: http://core.svn.wordpress.org/trunk@46234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-08 16:06:02 +00:00
K. Adam White
ed11103f39 REST API: Ensure rest_controller instantiates the post type's declared REST controller class. 
Ensures that the ::get_rest_controller() method will always return an instanceof the expected controller class, or null.
Removes unused private static property $post_type_controllers.

Props dlh, TimothyBlynJacobs.
Fixes #45677.


Built from https://develop.svn.wordpress.org/trunk@46435


git-svn-id: http://core.svn.wordpress.org/trunk@46233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-08 13:43:02 +00:00
K. Adam White
5815551dfe REST API: Permit embedding of the 'self' link relation in the /search endpoint. 
Removes a special-case prohibition against embedding 'self' which prevented ?_embed from being used with the /wp/v2/search endpoint.

Props TimothyBlynJacobs, chrisvanpatten, kadamwhite.
Fixes #47684.


Built from https://develop.svn.wordpress.org/trunk@46434


git-svn-id: http://core.svn.wordpress.org/trunk@46232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-08 04:45:02 +00:00
K. Adam White
de6d164870 REST API: Ensure users with "moderate_comments" capability may edit comments. 
Props meloniq.
Fixes #47024.


Built from https://develop.svn.wordpress.org/trunk@46433


git-svn-id: http://core.svn.wordpress.org/trunk@46231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-08 04:02:02 +00:00
Sergey Biryukov
bcd399918f Coding Standards: Correct the number of accepted arguments in add_action() calls in wp-includes/default-filters.php for functions that don't accept any arguments. 
Props itowhid06, johnbillion, jrf.
Fixes #48123.
Built from https://develop.svn.wordpress.org/trunk@46432


git-svn-id: http://core.svn.wordpress.org/trunk@46230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-08 03:20:02 +00:00
Sergey Biryukov
ddcf1fb843 CSS Coding Standards: Use unitless values for line-height in wp-includes/css/media-views.css. 
Follow-up to [45478].

Props ianbelanger, afercia.
Fixes #46529. See #44643.
Built from https://develop.svn.wordpress.org/trunk@46431


git-svn-id: http://core.svn.wordpress.org/trunk@46229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-08 02:57:03 +00:00
Sergey Biryukov
bcd53396f1 Twenty Fourteen: Replace overly broad float-clearing selectors with more specific ones, to avoid unintentionally targeting elements generated by plugins. 
Props ianbelanger, iandunn, karmatosed.
Fixes #35779.
Built from https://develop.svn.wordpress.org/trunk@46430


git-svn-id: http://core.svn.wordpress.org/trunk@46228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-08 02:02:03 +00:00
Sergey Biryukov
d294597e6e Twenty Fourteen: Ensure the content after the Read More tag is visible and has the appropriate padding. 
Props ianbelanger, sabernhardt, slobodanmanic, Quantumstate, Gwendydd, andraganescu, francina.
Fixes #28967.
Built from https://develop.svn.wordpress.org/trunk@46429


git-svn-id: http://core.svn.wordpress.org/trunk@46227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-08 01:54:01 +00:00
John Blackbourn
0dd3e7e33e Pings/Trackbacks: Remove a failing test that won't pass as long as WP_IMPORTING gets set during tests. 
The `_publish_post_hook()` function checks for `WP_IMPORTING` before setting meta fields fir enclosures and pings, which means this test is doomed to fail.

The test can be re-implemented if the `WP_IMPORTING` constant gets moved to a function similar to how `wp_installing()` works for the `WP_INSTALLING` constant.

See #48014

Built from https://develop.svn.wordpress.org/trunk@46428


git-svn-id: http://core.svn.wordpress.org/trunk@46226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-07 22:19:03 +00:00
John Blackbourn
883bb53d06 Pings/Trackbacks: Fix processing of posts with pending enclosures. 
Introduced in [46175].

Fixes #36824

Built from https://develop.svn.wordpress.org/trunk@46427


git-svn-id: http://core.svn.wordpress.org/trunk@46225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-07 21:37:03 +00:00
John Blackbourn
235373d4d7 Pings/Trackbacks: Avoid adding multiple _pingme and _encloseme meta entries to a post when it gets updated prior to pings being done. 
Props rebasaurus, whyisjake

Fixes #48014

Built from https://develop.svn.wordpress.org/trunk@46426


git-svn-id: http://core.svn.wordpress.org/trunk@46224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-07 20:29:04 +00:00
Andrea Fercia
92f09c0496 Accessibility: Improve and modernize user interface controls: Revert the new links focus style. 
Thew new dotted outline for the links focus style introduced in [46241] doesn't appear to be ready to guarantee a good indication of focus.
It was agreed to restore the previous links focus style and postpone exploration for a new style to the next release cycle.
Partially reverts [46241] and [46293].

See #34904, #47153.

Built from https://develop.svn.wordpress.org/trunk@46425


git-svn-id: http://core.svn.wordpress.org/trunk@46223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-07 19:57:02 +00:00
John Blackbourn
2f46afbc53 Docs: Miscellaneous inline docs corrections and improvements. 
See #47110 

Built from https://develop.svn.wordpress.org/trunk@46424


git-svn-id: http://core.svn.wordpress.org/trunk@46222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-07 19:08:06 +00:00
Andrea Fercia
3a27f92158 Accessibility: Improve and modernize user interface controls: Improve the buttons active CSS class. 
- improves the buttons `.active` CSS class for buttons that need to be styled as "pressed"
- update the alternate color schemes `.active` CSS class accordingly
- improves a few icons colors in the alternate color schemes

See #34904.

Built from https://develop.svn.wordpress.org/trunk@46423


git-svn-id: http://core.svn.wordpress.org/trunk@46221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-07 18:47:05 +00:00
Andrew Ozz
67b2ff7bc3 REST API: Add support for continuing the post-processing of images after upload. Flow: 
1. `POST /wp/v2/media`.
2. If the upload failed (HTTP 500 error), look for a response header with `X-WP-Upload-Attachment-ID` header that contains the newly created attachment ID.
3. `POST /wp/v2/media/{id}/post-process` with `{ "action": "create-image-subsizes" }`. This request may still fail, but it will save its progress.
4. On continued failure, `DELETE /wp/v2/media/{id}` to give up on the upload and instruct the user to resize their image before uploading.

Props TimothyBlynJacobs.
Fixes #47987.
Built from https://develop.svn.wordpress.org/trunk@46422


git-svn-id: http://core.svn.wordpress.org/trunk@46220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-07 17:06:03 +00:00
Andrew Ozz
f793398e4f Upload: Set custom header with the attachment ID for all uploads from media_handle_upload(). Let the REST API endpoint set it separately. 
Props timothyblynjacobs.
Fixes #48200.
Built from https://develop.svn.wordpress.org/trunk@46421


git-svn-id: http://core.svn.wordpress.org/trunk@46219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-07 15:30:02 +00:00
Sergey Biryukov
cce502be78 Coding Standards: Fix WPCS issues in wp-includes/ms-deprecated.php. 
Props itowhid06.
Fixes #48237.
Built from https://develop.svn.wordpress.org/trunk@46420


git-svn-id: http://core.svn.wordpress.org/trunk@46218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-07 15:18:03 +00:00
Andrea Fercia
e9065659f4 Accessibility: Improve and modernize user interface controls for better contrast: Further improvements to input heights and alignments. 
- improves input fields height in the customizer
- improves input fields height for Internet Explorer 11
- improves input fields height in the Image Editor
- improves alignment of selects and buttons in the privacy policy pages
- makes the search themes fields font-size consistent

Props garrett-eclipse, afercia.
See #47477.

Built from https://develop.svn.wordpress.org/trunk@46419


git-svn-id: http://core.svn.wordpress.org/trunk@46217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-07 13:20:03 +00:00
Andrea Fercia
1f3d583825 Accessibility: Media: Improve the search media field labelling. 
Visible `<label>` elements benefit all users. The `placeholder` attribute should not be used as a replacement for visible labels.
Instead, it's supposed to be used only for a short hint to aid users with data entry e.g. a sample value or a brief description of the expected format.

Screen readers may not announce a `placeholder` attribute at all. Other users may suffer from the lack of a visible label and a placeholder used as replacement, for example:

- users with cognitive disabilities may have trouble remembering what the filled field does
- speech recognition users cannot see the name they can speak to set focus on the field
- low-vision users with high text-size may not be able to see the whole placeholder even when it's visible, if its value is clipped by the edge of the input

Props anevins, audrasjb, karmatosed, azaozz, SergeyBiryukov, afercia.
See #40331.
Fixes #47138.

Built from https://develop.svn.wordpress.org/trunk@46418


git-svn-id: http://core.svn.wordpress.org/trunk@46216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-07 12:43:03 +00:00
Andrea Fercia
51814d68af Accessibility: Login and Registration: Improve the invalid username and invalid email messages. 
- explicitly informs users they can use their email to log in as an alternative to their username and vice-versa
- shows the `Lost your password?` link only when an wrong password has been entered
- uses a more appropriate copy by changing "invalid" to "unknown"
- removes the all caps `ERROR`

Props subrataemfluence, zalak151291, ryokuhi, SergeyBiryukov, audrasjb, joedolson, marybaum, ramiy, markjaquith, chanthaboune, afercia.
Fixes #43037.

Built from https://develop.svn.wordpress.org/trunk@46417


git-svn-id: http://core.svn.wordpress.org/trunk@46215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-07 11:54:05 +00:00
Aaron Jorbin
0ea646a185 External Libraries: Fix PHP 7.4 compatibility issue in the Requests library. 
Moves https://github.com/rmccue/Requests/pull/370 into WordPress.

Previous [46258].

See #47746.

Built from https://develop.svn.wordpress.org/trunk@46416


git-svn-id: http://core.svn.wordpress.org/trunk@46214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-06 17:14:02 +00:00
Sergey Biryukov
406dc81ebc Coding Standards: Fix WPCS issues in WP_Widget_Links and WP_Widget_Pages. 
Props itowhid06.
Fixes #48228.
Built from https://develop.svn.wordpress.org/trunk@46415


git-svn-id: http://core.svn.wordpress.org/trunk@46213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-06 15:28:03 +00:00
Sergey Biryukov
d54df2ffb3 Tests: Use a consistent group for nav menu tests. 
Fixes #48230.
Built from https://develop.svn.wordpress.org/trunk@46414


git-svn-id: http://core.svn.wordpress.org/trunk@46212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-06 15:14:03 +00:00
Sergey Biryukov
8252125175 Menus: In Walker_Nav_Menu, Walker_Category, and Walker_Page, properly output link attributes having a legitimate "empty" value, for example an HTML data attribute with a value of zero (0). 
Props nevma, AkSDvP, greenshady, SergeyBiryukov.
Fixes #47720.
Built from https://develop.svn.wordpress.org/trunk@46413


git-svn-id: http://core.svn.wordpress.org/trunk@46211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-06 15:06:03 +00:00
whyisjake
ea5d76fbb2 Privacy: Ensure that sending email, and remove data follow the same user experience. 
Both personal data request processes should follow the same convention.

Fixes: #43974.
Props: garrett-eclipse, kjellr, Kerfred, birgire, marybaum, SergeyBiryukov.



Built from https://develop.svn.wordpress.org/trunk@46412


git-svn-id: http://core.svn.wordpress.org/trunk@46210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-06 06:56:02 +00:00
whyisjake
4269998771 Administration: Add a max-width to the Privacy Policy Page dropdown. 
If there's a page with an extra long title, the Privacy Policy page dropdown in Privacy Settings overflows the page width.

Fixes #47366
Props garrett-eclipse, SergeyBiryukov, mukesh27, desrosj, adhitya03, jalpa1984, nrqsnchz, paresh07.

Built from https://develop.svn.wordpress.org/trunk@46411


git-svn-id: http://core.svn.wordpress.org/trunk@46209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-06 06:42:02 +00:00
Sergey Biryukov
554b60da76 Docs: Format comments in wp-admin/includes/plugin.php as per the documentation standards. 
Props dkarfa.
Fixes #48191.
Built from https://develop.svn.wordpress.org/trunk@46410


git-svn-id: http://core.svn.wordpress.org/trunk@46208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-06 02:23:03 +00:00
Aaron Jorbin
ebd841790b Build/Test: Update Grunt Uglify options 
Follow up to [46408]

Sometimes you need to take documentation literally. And sometimes you need to take it seriously. Deprecations and replacements in uglify are a case where I took them literally and should have taken them seriously.

See #48203.


Built from https://develop.svn.wordpress.org/trunk@46409


git-svn-id: http://core.svn.wordpress.org/trunk@46207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-05 22:01:04 +00:00
Aaron Jorbin
0e21d32900 Build/Test: Bump devDependencies for WordPress 5.3 
This upgrades a number of devDependencies.  Some of these include changes to how the tasks are configured.

Uglify: There are deprecated options from 2.x to 4.x, see: https://github.com/gruntjs/grunt-contrib-uglify#options

Autoprefixer: Browserslist now warns when passing in the browser list, so that is put into package.json

As with most changes to uglify, this changes every minified JS file.

Fixes #48203.



Built from https://develop.svn.wordpress.org/trunk@46408


git-svn-id: http://core.svn.wordpress.org/trunk@46206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-05 19:49:10 +00:00
Sergey Biryukov
3520f5234b Taxonomy: Prevent Parent Category dropdown and field descriptions on Categories and Edit Category screens from extending beyond the other fields. 
Props garrett-eclipse, dkarfa.
Fixes #48188.
Built from https://develop.svn.wordpress.org/trunk@46405


git-svn-id: http://core.svn.wordpress.org/trunk@46204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-05 15:41:57 +00:00
Aaron Jorbin
a92b23ee61 Build/Test tools: Update grunt-contrib-imagemin and run it 
Smaller images are good, so is not having npm vulnerabilities.

See #48203.
Fixes #48206.
Props whyisjake, netweb.


Built from https://develop.svn.wordpress.org/trunk@46404


git-svn-id: http://core.svn.wordpress.org/trunk@46203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-05 14:20:59 +00:00
Aaron Jorbin
9bc996b193 Build/Test Tools: Fork and Update grunt-replace 
The version of grunt replace that is bundled in core is using an outdated version of lodash that is bringing 2 low, 3 high, and 1 critical issue. This package is currently abandoned. There is a community forked version, but that is also harboring some similar security issues.

This switches to a fork by @whyisjake and causes no change to the build.

See #48203.
Fixes #48217.
Props whyisjake, netweb for testing.


Built from https://develop.svn.wordpress.org/trunk@46403


git-svn-id: http://core.svn.wordpress.org/trunk@46202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-05 13:49:00 +00:00
Sergey Biryukov
f1b5f2aa94 Site Health: Improve the wording for UTF8MB4 test description. 
Props garrett-eclipse, chetan200891, johnjamesjacoby, ayeshrajans.
Fixes #48044.
Built from https://develop.svn.wordpress.org/trunk@46402


git-svn-id: http://core.svn.wordpress.org/trunk@46201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-05 02:39:58 +00:00
Sergey Biryukov
2237306c2b Customize: Remove duplicate attr_title assignment in api.Menus.MenuItemControl.renderContent(). 
See #47838.
Built from https://develop.svn.wordpress.org/trunk@46401


git-svn-id: http://core.svn.wordpress.org/trunk@46200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-05 02:32:58 +00:00
Sergey Biryukov
f19ecd19de Filesystem API: Use strict type check in the in_array() call for the $skip_list parameter in copy_dir() and _copy_dir(). 
This ensures that parent folders with a numeric name are not accidentally skipped when only a subfolder is intended to be skipped.

Props codex-m.
Fixes #46581.
Built from https://develop.svn.wordpress.org/trunk@46400


git-svn-id: http://core.svn.wordpress.org/trunk@46199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-05 02:16:56 +00:00
Sergey Biryukov
30913bc9a2 Docs: Correct formatting of the @return value description in _wp_handle_upload(). 
See #47110.
Built from https://develop.svn.wordpress.org/trunk@46399


git-svn-id: http://core.svn.wordpress.org/trunk@46198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-05 02:09:57 +00:00
Sergey Biryukov
60617d471b Docs: Add missing documentation for the first parameter of the big_image_size_threshold filter. 
Props dkarfa, desrosj, earnjam.
Fixes #48214.
Built from https://develop.svn.wordpress.org/trunk@46398


git-svn-id: http://core.svn.wordpress.org/trunk@46197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-05 01:30:58 +00:00
Sergey Biryukov
c656e778bf Emoji: Revert [46393] pending test failure investigation. 
See #46537.
Built from https://develop.svn.wordpress.org/trunk@46397


git-svn-id: http://core.svn.wordpress.org/trunk@46196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-05 01:01:00 +00:00
Sergey Biryukov
f1e54593f0 Comments: Remove a one-time variable in wp_rel_nofollow() and wp_rel_ugc(). 
See #48022.
Built from https://develop.svn.wordpress.org/trunk@46396


git-svn-id: http://core.svn.wordpress.org/trunk@46195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-05 00:56:57 +00:00
Sergey Biryukov
83edc24762 Themes: In get_theme_mod(), only run the sprintf() replacement on the default value if there's a string format pattern found in the value. 
This prevents standalone percent symbols from being stripped out, e.g. in a default value like `100%`.

Props aristath, kuus, moonomo, westonruter, davetgreen, daviedR, katielgc, noisysocks, SergeyBiryukov.
Fixes #34290.
Built from https://develop.svn.wordpress.org/trunk@46395


git-svn-id: http://core.svn.wordpress.org/trunk@46194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-05 00:54:58 +00:00
Sergey Biryukov
5fd25a6944 Docs: Improve documentation for get_theme_mod() and set_theme_mod(). 
See #47110.
Built from https://develop.svn.wordpress.org/trunk@46394


git-svn-id: http://core.svn.wordpress.org/trunk@46193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-05 00:40:58 +00:00
Sergey Biryukov
538e0d4fb3 Emoji: Stop emoji replacement from happening inside CodeMirror instances, and clean up some logic in the MutationObserver. 
Props pento, hirofumi2012, davidbaumwald.
Fixes #46537.
Built from https://develop.svn.wordpress.org/trunk@46393


git-svn-id: http://core.svn.wordpress.org/trunk@46192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-04 23:29:59 +00:00
Sergey Biryukov
5241f4c2dd Themes: Bring default values for get_theme_root(), get_theme_root_uri(), wp_get_theme(), and wp_customize_url() in line with the documentation. 
Reverts [46327].

Fixes #44397.
Built from https://develop.svn.wordpress.org/trunk@46392


git-svn-id: http://core.svn.wordpress.org/trunk@46191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-04 23:20:58 +00:00
Sergey Biryukov
d2a48496d2 Docs: Add missing description for $comment global. 
Props immeet94, mukesh27.
Fixes #46928. See #47110.
Built from https://develop.svn.wordpress.org/trunk@46391


git-svn-id: http://core.svn.wordpress.org/trunk@46190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-04 22:19:57 +00:00
Sergey Biryukov
f34db2aa7e I18N: Add missing comma in a translator comment. 
See #47515.
Built from https://develop.svn.wordpress.org/trunk@46390


git-svn-id: http://core.svn.wordpress.org/trunk@46189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-04 22:09:57 +00:00
Dominik Schilling
eaf4dba2f4 Customize: Prevent breaking the customizer when site title contains templating syntax. 
When the site title is inside an underscore template, syntax defined in `wp.template` like `{{ }}` is treated as special characters and will make Underscore treat it as data to be compiled/rendered.

Props pierlo, donmhico.
Fixes #46863.
Built from https://develop.svn.wordpress.org/trunk@46389


git-svn-id: http://core.svn.wordpress.org/trunk@46188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-04 21:59:57 +00:00
Dominik Schilling
b64e8b33fc QUnit: Include script dependencies for wp-a11y script to fix a TypeError. 
Also, add missing message argument to Customizer notifications to ensure tests are passing.

Fixes #45066.
Built from https://develop.svn.wordpress.org/trunk@46388


git-svn-id: http://core.svn.wordpress.org/trunk@46187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-04 21:20:58 +00:00
Dominik Schilling
d38d1c2c35 I18N: Fix translator comment for a themes list table string with numbered placeholders. 
Props garrett-eclipse.
Fixes #47515.
Built from https://develop.svn.wordpress.org/trunk@46387


git-svn-id: http://core.svn.wordpress.org/trunk@46186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-04 20:20:58 +00:00
Dominik Schilling
6f38c7fb81 Docs: Convert 'Block Editor' to lowercase. 
Props garrett-eclipse.
Fixes #45634.
Built from https://develop.svn.wordpress.org/trunk@46386


git-svn-id: http://core.svn.wordpress.org/trunk@46185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-04 20:12:58 +00:00
Dominik Schilling
cd6110782e Networks and Sites: Improve newly added strings for i18n. 
* Remove unnecessary numbered placeholders.
* Add context to "All" and "Spam" status.
* Add translator comments.

Props pedromendonca.
Fixes #48210.
Built from https://develop.svn.wordpress.org/trunk@46385


git-svn-id: http://core.svn.wordpress.org/trunk@46184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-04 19:58:55 +00:00
desrosj
143b5fd080 Networks and Sites: Fix issues processing additional fields displayed for the Sites list table. 
This prevents a `The link you followed has expired.` error when using a filter and now uses `$_POST` instead of `$_GET` to capture all form values.

Props pbiron.
Fixes #45954.
Built from https://develop.svn.wordpress.org/trunk@46384


git-svn-id: http://core.svn.wordpress.org/trunk@46183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-04 14:32:56 +00:00
Sergey Biryukov
c0bb073ca2 Docs: Clarify default value for the $link parameter in edit_tag_link(), edit_term_link(), and edit_bookmark_link(). 
Props atachibana.
Fixes #48109.
Built from https://develop.svn.wordpress.org/trunk@46383


git-svn-id: http://core.svn.wordpress.org/trunk@46182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-03 23:12:57 +00:00
Andrew Ozz
ff225c8bfc Upload: Fix the method used to create image sub-sizes when uploading fails with a PHP fatal error. Use a custom header to send the new attachment post ID even in HTTP 500 responses instead of an upload reference sent by the client. Also add another cap check and remove the action when deleting an attachment post during a failed upload cleanup. 
Props timothyblynjacobs, clorith, azaozz.
Fixes #48200.
Built from https://develop.svn.wordpress.org/trunk@46382


git-svn-id: http://core.svn.wordpress.org/trunk@46181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-03 21:02:00 +00:00
desrosj
efa9da7446 Docs: Fix code example for removing internal pointers. 
Props daleharrison, swissspidy, garrett-eclipse, luciano-croce, jrf, desrosj.
Fixes #45529.
Built from https://develop.svn.wordpress.org/trunk@46381


git-svn-id: http://core.svn.wordpress.org/trunk@46180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-03 20:39:58 +00:00
desrosj
6a0f3ddae3 Menus: Fix typo in the class attribute for the hidden title field in Walker_Nav_Menu_Checklist. 
Each item that `Walker_Nav_Menu_Checklist` displays is accompanied by several hidden `<input/>` fields that specify default values for each item when added to a menu. These values are passed in JavaScript to the AJAX call triggered when an item is added to a menu.

The hidden field for the title attribute field incorrectly had an underscore instead of a hyphen. Because of this, it was impossible to supply a default value for the Title Attribute field of a nav menu item.

Props yanngarcia, davidbaumwald.
See #47838.
Built from https://develop.svn.wordpress.org/trunk@46380


git-svn-id: http://core.svn.wordpress.org/trunk@46179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-03 20:03:56 +00:00
Joe McGill
d89be1ff55 Media: Ensure medialement scripts are loaded in the footer. 
This fixes a regression in [41877] which caused `mediaelement` scripts to load in the header.

Props Themezly.
Fixes #44484.

Built from https://develop.svn.wordpress.org/trunk@46379


git-svn-id: http://core.svn.wordpress.org/trunk@46178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-03 16:06:59 +00:00
desrosj
b763447019 General: Patch PHMailer for PHP 7.4 compatibility. 
This patches the PHPMailer library in Core to be PHP 7.4 compatible by adding a version check before calling `get_magic_quotes_runtime()`.

Props ayeshrajans, jrf.
See #47783.
Built from https://develop.svn.wordpress.org/trunk@46378


git-svn-id: http://core.svn.wordpress.org/trunk@46177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-03 15:45:59 +00:00
desrosj
6fa7f757d4 Docs: Add missing @deprecated tags. 
Follow up to [46205-46206,46208].

Props jrf.
See #47699.
Built from https://develop.svn.wordpress.org/trunk@46377


git-svn-id: http://core.svn.wordpress.org/trunk@46176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-03 14:48:55 +00:00
Joe McGill
ecf00fc844 Media: Improve documentation for add_image_size() 
This improves the description of the `$crop` parameter to clarify behavior.

Props nikolastoqnow, ketuchetan, audrasjb, killua99, pierlo.
Fixes #42463.


Built from https://develop.svn.wordpress.org/trunk@46376


git-svn-id: http://core.svn.wordpress.org/trunk@46175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-03 14:47:59 +00:00
Andrea Fercia
b1cd71c2d2 Accessibility: Media: Add more headings in the Media Modal. 
Headings are the predominant mechanism for screen reader users to find information in a page. They also help all users to better identify the main sections of user interfaces.

- adds three new headings within the media modal 
- improves plural form translation for "item selected" by using `wp.i18n`
- horizontally centers the media modal menu in the responsive view

Props kjellr, karmatosed, melchoyce, afercia.
See #47149.
Fixes #47610.

Built from https://develop.svn.wordpress.org/trunk@46375


git-svn-id: http://core.svn.wordpress.org/trunk@46174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-03 12:10:57 +00:00
Sergey Biryukov
3e40f12574 Privacy: Remove unused $wpdb global in WP_Privacy_Requests_Table::prepare_items(). 
Props david.binda.
Fixes #48178.
Built from https://develop.svn.wordpress.org/trunk@46374


git-svn-id: http://core.svn.wordpress.org/trunk@46173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-02 23:22:58 +00:00
Andrea Fercia
91ab0b3989 Accessibility: Media: Allow users to set a proper language for Video subtitles. 
For a number of years, subtitles track added to videos were always set to "English" regardless of the actual subtitles language.

By making the track `srclang`, `label`, and `kind` attributes editable, content authors are now able to set a language that matches the actual track content.

Props BjornW, audrasjb, birgire, karmatosed, sabernhardt, afercia.
Fixes #47559.

Built from https://develop.svn.wordpress.org/trunk@46373


git-svn-id: http://core.svn.wordpress.org/trunk@46172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-01 22:05:58 +00:00
Andrea Fercia
4b939d5a93 Login and Registration: Hide the Edge browser "Reveal password" native button. 
Props Clorith.
Fixes #42888.

Built from https://develop.svn.wordpress.org/trunk@46372


git-svn-id: http://core.svn.wordpress.org/trunk@46171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-01 18:01:01 +00:00
Andrea Fercia
da00051294 Accessibility: Improve and modernize user interface controls for better contrast: Login screen improvements. 
- allows the login input fields to better scale with text 
- improves the input fields layout on Internet Explorer 11
- uses the new focus style on the "Show password" button 
- adjusts the CSS for the interim login

See #47153.
See #42888.

Built from https://develop.svn.wordpress.org/trunk@46371


git-svn-id: http://core.svn.wordpress.org/trunk@46170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-01 15:55:57 +00:00
whyisjake
095eed363a Shortcodes: Improve handling from shortcode_parse_attts(). 
Added missing @ticket for #47863 on `data_shortcode_parse_atts()`

Also cleans up some linter fixes that were missed.

Props garrett-eclipse, whyisjake.
ixes #47863.

Built from https://develop.svn.wordpress.org/trunk@46370


git-svn-id: http://core.svn.wordpress.org/trunk@46169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-01 04:13:57 +00:00
whyisjake
d30053446b Shortcodes: Improve handling from shortcode_parse_attts(). 
Ensure consistency between `shortcode_parse_attts()` when being used directly.

Props mauteri, birgire, SergeyBiryukov, kadamwhite, whyisjake.
Fixes #47863.


Built from https://develop.svn.wordpress.org/trunk@46369


git-svn-id: http://core.svn.wordpress.org/trunk@46168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-01 03:42:58 +00:00
Sergey Biryukov
44c3cefb24 Docs: Fix typo in wp_get_missing_image_subsizes() DocBlock. 
Props david.binda.
Fixes #48179.
Built from https://develop.svn.wordpress.org/trunk@46368


git-svn-id: http://core.svn.wordpress.org/trunk@46167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-01 01:19:57 +00:00
Sergey Biryukov
129366a5a5 Docs: Remove obsolete comment in wpmu_signup_blog_notification() and wpmu_signup_user_notification(). 
Props david.binda.
Fixes #48185.
Built from https://develop.svn.wordpress.org/trunk@46367


git-svn-id: http://core.svn.wordpress.org/trunk@46166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-01 00:46:57 +00:00
desrosj
7de61a6de5 Post WordPress 5.3 Beta 2 version bump. 
Built from https://develop.svn.wordpress.org/trunk@46366


git-svn-id: http://core.svn.wordpress.org/trunk@46165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-30 21:08:59 +00:00
desrosj
2edb6fc243 WordPress 5.3 Beta 2. 
Built from https://develop.svn.wordpress.org/trunk@46365


git-svn-id: http://core.svn.wordpress.org/trunk@46164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-30 20:51:58 +00:00
desrosj
30d8319aa9 Block Editor: Update WordPress packages to include the latest bug fixes. 
Updated packages:

@wordpress/annotations@1.7.1
@wordpress/api-fetch@3.6.1
@wordpress/babel-plugin-makepot@3.2.1
@wordpress/babel-preset-default@4.6.1
@wordpress/block-directory@1.0.1
@wordpress/block-editor@3.2.1
@wordpress/block-library@2.9.1
@wordpress/blocks@6.7.1
@wordpress/components@8.3.1
@wordpress/compose@3.7.1
@wordpress/core-data@2.7.1
@wordpress/data-controls@1.3.1
@wordpress/data@4.9.1
@wordpress/docgen@1.4.1
@wordpress/dom@2.5.1
@wordpress/e2e-test-utils@2.4.1
@wordpress/e2e-tests@1.7.1
@wordpress/edit-post@3.8.1
@wordpress/editor@9.7.1
@wordpress/element@2.8.1
@wordpress/format-library@1.9.1
@wordpress/i18n@3.6.1
@wordpress/jest-console@3.3.1
@wordpress/jest-preset-default@5.1.1
@wordpress/keycodes@2.6.1
@wordpress/library-export-default-webpack-plugin@1.4.1
@wordpress/list-reusable-blocks@1.8.1
@wordpress/media-utils@1.2.1
@wordpress/notices@1.8.1
@wordpress/nux@3.7.1
@wordpress/plugins@2.7.1
@wordpress/redux-routine@3.6.1
@wordpress/rich-text@3.7.1
@wordpress/scripts@5.0.1
@wordpress/server-side-render@1.3.1
@wordpress/shortcode@2.4.1
@wordpress/token-list@1.6.1
@wordpress/viewport@2.8.1
@wordpress/wordcount@2.6.1 

Props epiqueras, youknowriad, donmhico, jorgefilipecosta, soean, mcsf, noisysocks, andraganescu, gziolo, talldanwp, iseulde, nrqsnchz, mapk, karmatosed, joen, afercia, kjellr, desrosj.
Fixes #48186.
Built from https://develop.svn.wordpress.org/trunk@46364


git-svn-id: http://core.svn.wordpress.org/trunk@46163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-30 20:07:06 +00:00
Andrea Fercia
63e199abc7 Accessibility: Media: Use the ARIA tabs pattern for the media modal menus. 
The ARIA tabs pattern improves interaction for keyboard and assistive technologies users.
It gives the menu items proper roles, and `aria-selected` allows users of assistive technologies to know which tab is currently selected.

Props audrasjb, afercia, joedolson, karmatosed, melchoyce.
See #47149.

Built from https://develop.svn.wordpress.org/trunk@46363


git-svn-id: http://core.svn.wordpress.org/trunk@46162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-30 19:37:58 +00:00
Andrea Fercia
e534fdf5aa Media: Fix the media modal "Insert from URL" field height after [46356]. 
See #47477.

Built from https://develop.svn.wordpress.org/trunk@46362


git-svn-id: http://core.svn.wordpress.org/trunk@46161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-30 19:20:58 +00:00
desrosj
82b673d043 Site Health: Revert [46323-46325] for further discussion of how the admin email verification should be filtered. 
See #48153.
Built from https://develop.svn.wordpress.org/trunk@46361


git-svn-id: http://core.svn.wordpress.org/trunk@46160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-30 18:53:00 +00:00
Andrea Fercia
f86d225d26 Accessibility: Improve and modernize user interface controls: Improve new styles for the color picker. 
Props audrasjb, garrett-eclipse.
Fixes #48131.

Built from https://develop.svn.wordpress.org/trunk@46360


git-svn-id: http://core.svn.wordpress.org/trunk@46159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-30 18:05:59 +00:00
antpb
6531c237e7 Media: Prevents clipping of text when scaling image edit screen. 
This reapplies [46354] clean as the previous commit had remnants of an unrelated patch.

Props sabernhardt, audrasjb, afercia.
See #47115.

Built from https://develop.svn.wordpress.org/trunk@46359


git-svn-id: http://core.svn.wordpress.org/trunk@46158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-30 17:56:57 +00:00
desrosj
ae29987a17 Site Health: Improve the message displayed to sites not utilizing HTTPS. 
The new message better illustrates that there are many potential benefits of using HTTPS, not just a few.

Props garrett-eclipse, dkarfa, ocean90, afragen, desrosj.
Fixes #48118.
Built from https://develop.svn.wordpress.org/trunk@46358


git-svn-id: http://core.svn.wordpress.org/trunk@46157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-30 17:54:58 +00:00
desrosj
2abcce6dfc Bundled Themes: Update Twenty Twenty. 
This brings `trunk`’s version of Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46271], see 932b16248...dd7032f

Props anlino, ianbelanger, nielslange, acosmin, netweb, williampatton, adhitya03, phpdocs, acalfieri, itowhid06, littlebigthing, aristath, karmatosed, poena.
See #48110.
Built from https://develop.svn.wordpress.org/trunk@46357


git-svn-id: http://core.svn.wordpress.org/trunk@46156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-30 17:41:57 +00:00
Andrea Fercia
6566808e8a Accessibility: Improve and modernize user interface controls: Improve the new form controls styles and heights. 
Improves cross-browsers rendering and addresses most of the reported edge cases.

See #47477.

Built from https://develop.svn.wordpress.org/trunk@46356


git-svn-id: http://core.svn.wordpress.org/trunk@46155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-30 17:24:59 +00:00
antpb
247e7eb7d5 Media: Revert [46354] preventing bad clipping of text in image details page. 
See #47115.

Built from https://develop.svn.wordpress.org/trunk@46355


git-svn-id: http://core.svn.wordpress.org/trunk@46154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-30 17:12:59 +00:00
antpb
7c8028febf Media: Prevents clipping of text when scaling image edit screen. 
Props sabernhardt, audrasjb, afercia.
See #47115.

Built from https://develop.svn.wordpress.org/trunk@46354


git-svn-id: http://core.svn.wordpress.org/trunk@46153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-30 16:34:58 +00:00
Andrew Ozz
38e6958698 Media: Move wp_get_original_image_path() to wp-content/post.php to make it easier to access from plugins. 
Props pbiron.
See #47873.
Built from https://develop.svn.wordpress.org/trunk@46353


git-svn-id: http://core.svn.wordpress.org/trunk@46152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-30 16:28:59 +00:00
desrosj
7d667995b4 Built/Test Tools: Ignore the node_modules folder in Twenty Twenty. 
Ignore the `node_modules` folder in Twenty Twenty in SVN, and when running `grunt build` or `grunt jshint:themes`.

See #48110.
Built from https://develop.svn.wordpress.org/trunk@46352


git-svn-id: http://core.svn.wordpress.org/trunk@46151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-30 15:59:00 +00:00
desrosj
abff73f0e0 Docs: Correct WP_Styles_Registry documentation. 
This change updates the file’s docblock to correctly indicate `WordPress`/`Blocks` as the `@package`/`@subpackage`, updates the `_doing_it_wrong()` versions to `5.3.0` instead of the Gutenberg plugin versions, and removes some stray `gutenberg` text domains.

Props david.binda.
Fixes #48181.
Built from https://develop.svn.wordpress.org/trunk@46351


git-svn-id: http://core.svn.wordpress.org/trunk@46150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-30 15:44:59 +00:00
Andrea Fercia
20e781f44d Accessibility: Improve and modernize user interface controls: Remove the CSS transform 1 pixel shift from the buttons active state. 
Props Joen.
See #34904.

Built from https://develop.svn.wordpress.org/trunk@46350


git-svn-id: http://core.svn.wordpress.org/trunk@46149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-30 10:53:57 +00:00
Sergey Biryukov
2afdc64723 Comments: Add rel="nofollow ugc" attribute to links in comments. 
UGC stands for User Generated Content, and the `ugc` attribute value is recommended for links within user generated content, such as comments and forum posts.

See https://webmasters.googleblog.com/2019/09/evolving-nofollow-new-ways-to-identify.html.

Props audrasjb, joostdevalk, dkarfa, SergeyBiryukov.
Fixes #48022.
Built from https://develop.svn.wordpress.org/trunk@46349


git-svn-id: http://core.svn.wordpress.org/trunk@46148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-30 01:30:58 +00:00
desrosj
8cb7c5c764 Upgrade/Install: Fix the Install Now button in the plugin overlay when running WordPress on a specific port. 
Props garrett-eclipse, pierlo, afragen.
Fixes #48077.
Built from https://develop.svn.wordpress.org/trunk@46348


git-svn-id: http://core.svn.wordpress.org/trunk@46147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-30 00:05:57 +00:00
Sergey Biryukov
6e25a991a6 Twenty Nineteen: Remove trailing comma after selector in sass/site/primary/_posts-and-pages.scss. 
Props itowhid06.
Fixes #48171.
Built from https://develop.svn.wordpress.org/trunk@46347


git-svn-id: http://core.svn.wordpress.org/trunk@46146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-29 22:40:57 +00:00
Sergey Biryukov
736403a26e REST API: Combine array and object cases in WP_REST_Meta_Fields::get_default_for_type() to remove duplicated line. 
Add missing description for `$type` parameter.

Props itowhid06, dkarfa.
Fixes #48169.
Built from https://develop.svn.wordpress.org/trunk@46346


git-svn-id: http://core.svn.wordpress.org/trunk@46145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-29 22:34:57 +00:00
Andrea Fercia
dfcdb40c8f Accessibility: Improve and modernize user interface controls: Improve the radio buttons blue dot alignment. 
Props desrosj, garrett-eclipse, afercia.
See #47498.

Built from https://develop.svn.wordpress.org/trunk@46345


git-svn-id: http://core.svn.wordpress.org/trunk@46144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-29 21:56:56 +00:00
Andrea Fercia
8ef586a897 Accessibility: Improve and modernize user interface controls: Make the secondary buttons border blue. 
Props drw158, youknowriad, kjellr, melchoyce, talldanwp, audrasjb.
See #34904.

Built from https://develop.svn.wordpress.org/trunk@46344


git-svn-id: http://core.svn.wordpress.org/trunk@46143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-29 21:53:57 +00:00
Sergey Biryukov
7da7edbc57 Coding Standards: Remove inline assignments and extra whitespace in tests/multisite/network.php. 
Props garrett-eclipse, jrf.
See #48142.
Built from https://develop.svn.wordpress.org/trunk@46343


git-svn-id: http://core.svn.wordpress.org/trunk@46142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-29 12:22:57 +00:00
Sergey Biryukov
7a91c1ee74 Docs: Improve comments in tests/multisite/network.php per the documentation standards. 
Props garrett-eclipse, jrf.
See #48142.
Built from https://develop.svn.wordpress.org/trunk@46342


git-svn-id: http://core.svn.wordpress.org/trunk@46141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-29 12:19:57 +00:00
Sergey Biryukov
5f2c7142a1 Docs: Improve documentation for ::display() methods in various list tables. 
Props itowhid06.
Fixes #47947.
Built from https://develop.svn.wordpress.org/trunk@46341


git-svn-id: http://core.svn.wordpress.org/trunk@46140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-29 11:04:58 +00:00
Andrea Fercia
55b1dc642e Accessibility: After [46337]: make the select elements background white also on hover, active, and focus states. 
See #47477.
See #48128.

Built from https://develop.svn.wordpress.org/trunk@46340


git-svn-id: http://core.svn.wordpress.org/trunk@46139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-28 16:45:57 +00:00
Andrea Fercia
7d769a9234 Accessibility: Improve and modernize user interface controls. Style the select elements disabled state. 
Props adhitya03, MarcosAlexandre, kjellr.
See #47477.
Fixes #48129.

Built from https://develop.svn.wordpress.org/trunk@46339


git-svn-id: http://core.svn.wordpress.org/trunk@46138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-28 16:35:59 +00:00
Andrew Ozz
dd44ab5a58 Fix the context (right-click) menu when clicking the placeholder for the post title field on the classic Edit Post screen. 
Props masummdar, audrasjb, afercia.
Fixes #47318.
Built from https://develop.svn.wordpress.org/trunk@46338


git-svn-id: http://core.svn.wordpress.org/trunk@46137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-28 16:20:57 +00:00
Andrea Fercia
becc682bcf Accessibility: Improve and modernize user interface controls. Make the select elements background white. 
Props adhitya03.
See #47477.
Fixes #48128.

Built from https://develop.svn.wordpress.org/trunk@46337


git-svn-id: http://core.svn.wordpress.org/trunk@46136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-28 16:15:59 +00:00
Sergey Biryukov
07a753cb35 Docs: Add documentation for WP_Comments_List_Table::display(). 
Props itowhid06, dinhtungdu.
Fixes #47929.
Built from https://develop.svn.wordpress.org/trunk@46336


git-svn-id: http://core.svn.wordpress.org/trunk@46135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-27 23:03:58 +00:00
whyisjake
d4c6ebeb89 Comments: Avoid PHP notice in get_comment_reply_link() for null comment. 
If there is no global comment, or the input comment is null, return early to prevent warnings.

Fixes #41846
Props birgire, earnjam


Built from https://develop.svn.wordpress.org/trunk@46335


git-svn-id: http://core.svn.wordpress.org/trunk@46134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-27 14:46:57 +00:00
Andrea Fercia
188416bd55 Login and Registration: Revert divs and restore paragraphs after [46256]. 
Fixes #42888.

Built from https://develop.svn.wordpress.org/trunk@46334


git-svn-id: http://core.svn.wordpress.org/trunk@46133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 22:20:56 +00:00
whyisjake
304c19dbac Options: register_uninstall_hook() causes large amounts of unnecessary option updates. 
Prevent extra database read/writes from the the hook.

Props jeichorn, MikeHansenMe, DrewAPicture, Rahe, tha_sun, mikeschroder.
Fixes #31792.


Built from https://develop.svn.wordpress.org/trunk@46333


git-svn-id: http://core.svn.wordpress.org/trunk@46132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 22:08:57 +00:00
whyisjake
b6f7c0cbc4 Administration: Ensure visual consistency with large titles in the sidebar. 
Custom posts, and other menu titles that are long aren't wrapping correctly.

Props jagirbaheshwp, munyagu, harshbarach, hareesh-pillai, pratikkry, naveenkharwar, mukesh27, dushanthi, worldweb, audrasjb
Fixes #42201

Built from https://develop.svn.wordpress.org/trunk@46332


git-svn-id: http://core.svn.wordpress.org/trunk@46131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 21:51:57 +00:00
Andrea Fercia
66dd6814e7 Media: Restore the original Image Editor columns layout after [46326]. 
Fixes #47116.

Built from https://develop.svn.wordpress.org/trunk@46331


git-svn-id: http://core.svn.wordpress.org/trunk@46130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 20:37:57 +00:00
whyisjake
c034f5b4c3 Menus: Replace http with https in placeholders. 
Encourage the use of https with the placeholder text in menus.

Fixes #46312
Props aksl95, audrasjb, celloexpressions, SergeyBiryukov, jorbin.

Built from https://develop.svn.wordpress.org/trunk@46330


git-svn-id: http://core.svn.wordpress.org/trunk@46129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 20:32:55 +00:00
Sergey Biryukov
1d334b273e Tests: Correct ::assertArrayHasKey() capitalization in [46252]. 
Props dkarfa, david.binda.
Fixes #48155.
Built from https://develop.svn.wordpress.org/trunk@46329


git-svn-id: http://core.svn.wordpress.org/trunk@46128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 20:31:58 +00:00
John Blackbourn
f73a22a98a Themes: Add a test to ensure get_template_part() does not return a value. 
This function must not be modified to return anything due to existing themes which output the return value, for example via `echo get_template_part( ... )`.

See #40969

Built from https://develop.svn.wordpress.org/trunk@46328


git-svn-id: http://core.svn.wordpress.org/trunk@46127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 20:26:59 +00:00
whyisjake
3c0f10e397 Themes: Docblock cleanup for get_theme_root_uri() 
In the function docblock of `get_theme_root_uri()`, the argument types of `$stylesheet_or_template` and `$theme_root` do not match. Default values of arguments are boolean but in function doc they are stated as strings.

Props subrataemfluence, williampatton, garrett-eclipse.
Fixes #44397.

Built from https://develop.svn.wordpress.org/trunk@46327


git-svn-id: http://core.svn.wordpress.org/trunk@46126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 20:21:58 +00:00
Andrea Fercia
93dd6d907a Accessibility: Media: Make the Image Editor buttons text visible. 
User interface controls that use only icons aren't ideal for many users. 

Universal icons are rare. Icons must communicate meaning but their actual meaning varies depending on many factors including the users cultural background.
Moreover, users with cognitive impairments and speech recognition users need interface controls with visible text to be able to operate them.

- shortens some of the buttons text to: Rotate left, Rotate right, Flip vertical, Flip horizontal
- moves the Undo and Redo buttons underneath the main buttons group

Props nrqsnchz, melchoyce, karmatosed, sabernhardt, mikeschroder.
Fixes #47116.

Built from https://develop.svn.wordpress.org/trunk@46326


git-svn-id: http://core.svn.wordpress.org/trunk@46125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 17:16:57 +00:00
desrosj
8affbd6404 Docs: Correct typos introduced in [46324] 
Props TimothyBlynJacobs.
See #48153.
Built from https://develop.svn.wordpress.org/trunk@46325


git-svn-id: http://core.svn.wordpress.org/trunk@46124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 16:32:58 +00:00
desrosj
1e8ed99eca Site Health: Consolidate documentation for the admin_email_check_interval filter. 
See #48153.
Built from https://develop.svn.wordpress.org/trunk@46324


git-svn-id: http://core.svn.wordpress.org/trunk@46123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 15:45:58 +00:00
desrosj
0f99e345fa Site Health: Allow the capability required for the site admin email verification screen to be filtered. 
Props desrosj, Clorith.
Fixes #48153.
Built from https://develop.svn.wordpress.org/trunk@46323


git-svn-id: http://core.svn.wordpress.org/trunk@46122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 15:41:57 +00:00
Sergey Biryukov
8bb8e77ace Code Modernisation: Introduce the spread operator in do_action(). 
Rather than relying on `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.

Props jrf.
See #47678.
Built from https://develop.svn.wordpress.org/trunk@46322


git-svn-id: http://core.svn.wordpress.org/trunk@46121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 13:53:58 +00:00
Andrea Fercia
abb00ee8a4 Media: Fix JavaScript TypeError after [45376]. 
Props desrosj, afercia.
Fixes #48021.

Built from https://develop.svn.wordpress.org/trunk@46321


git-svn-id: http://core.svn.wordpress.org/trunk@46120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 13:06:56 +00:00
Gary Pendergast
2a8854ca9d Build Tools: Pass the current uid/gid to Docker containers. 
This prepares for an upcoming change to the Docker images, which improves file permission handling.

See #47767.


Built from https://develop.svn.wordpress.org/trunk@46320


git-svn-id: http://core.svn.wordpress.org/trunk@46119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 04:58:58 +00:00
Sergey Biryukov
0a5cd17f98 Login and Registration: Standardize on 6 * MONTH_IN_SECONDS over 180 * DAY_IN_SECONDS for admin_email_check_interval filter. 
[45788] changed the first instance, but not the second.

Props tmatsuur.
Fixes #48144.
Built from https://develop.svn.wordpress.org/trunk@46319


git-svn-id: http://core.svn.wordpress.org/trunk@46118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 02:29:58 +00:00
Sergey Biryukov
8ef4150dc6 REST API: Use delta comparison for floating date test added in [46279] to avoid race conditions. 
See #48113.
Built from https://develop.svn.wordpress.org/trunk@46318


git-svn-id: http://core.svn.wordpress.org/trunk@46117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 01:40:58 +00:00
Sergey Biryukov
da8ebc6fc9 Coding Standards: Remove inline assignment in test_wp_delete_term_should_invalidate_cache(). 
See #48142.
Built from https://develop.svn.wordpress.org/trunk@46317


git-svn-id: http://core.svn.wordpress.org/trunk@46116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 01:34:58 +00:00
Sergey Biryukov
6e8f550770 General: Correct strict comparison in WP_Links_List_Table::column_categories() introduced in [46313]. 
`$cat_id` is a string, `$category` is an integer.

See #48142.
Built from https://develop.svn.wordpress.org/trunk@46316


git-svn-id: http://core.svn.wordpress.org/trunk@46115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 01:24:56 +00:00
Sergey Biryukov
148322a970 Docs: Improve documentation for _post_states() and get_post_states(). 
Add documentation for `_media_states()`.

See #47110.
Built from https://develop.svn.wordpress.org/trunk@46315


git-svn-id: http://core.svn.wordpress.org/trunk@46114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 00:57:58 +00:00
whyisjake
a351243928 General: Further phpcs cleanup. 
In [46312] and [46313] we attempted to do some phpcs cleanup. This commit cleans up three issues that were introduced in [46309].

Fixes #48142.

Props: whyisjake, garrett-eclipse, desrosj

Built from https://develop.svn.wordpress.org/trunk@46314


git-svn-id: http://core.svn.wordpress.org/trunk@46113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-26 00:37:58 +00:00
whyisjake
d53b773a47 General: Further phpcs cleanup. 
In [46312] we attempted to do some `phpcs` cleanup. This commit cleans up three issues that were introduced in [46309].

Fixes #48142.
Props whyisjake, garrett-eclipse.

Built from https://develop.svn.wordpress.org/trunk@46313


git-svn-id: http://core.svn.wordpress.org/trunk@46112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 23:38:57 +00:00
whyisjake
38dc032e66 General: Linter cleanup 
`phpcbf` was able to clean up a few files. Tests were breaking as a result of code formatting.

Fixes #48142
Props whyisjake

Built from https://develop.svn.wordpress.org/trunk@46312


git-svn-id: http://core.svn.wordpress.org/trunk@46111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 22:53:58 +00:00
Peter Wilson
22cba90dea Docs: Fix typo in wp_print_scripts()' reference to WP_Scripts::do_item(). 
Fixes #48141.

Built from https://develop.svn.wordpress.org/trunk@46311


git-svn-id: http://core.svn.wordpress.org/trunk@46110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 22:23:55 +00:00
whyisjake
2822281c57 Themes: Fix javascript regression that linter found. 
Tests were failing from line length optimizations and double quotes. 

Fixes #37536

Built from https://develop.svn.wordpress.org/trunk@46310


git-svn-id: http://core.svn.wordpress.org/trunk@46109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 22:12:57 +00:00
whyisjake
b4ab6b7e14 Menus: Duplicate Page Entry in View All Pages when generating a Menu 
Simplifies the interface in menu creation.

Fixes [37782]
Props garrett-eclipse, mdgl, birgire, xkon, audrasjb, pento, girlieworks


Built from https://develop.svn.wordpress.org/trunk@46309


git-svn-id: http://core.svn.wordpress.org/trunk@46108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 21:51:58 +00:00
whyisjake
0acc444279 Themes: Improve Twenty Fifteen sticky sidebar logic 
The current logic in TwentyFifteen (#30366) for making the sidebar sticky while still allowing to scroll through it when the sidebar height is larger than the viewport height is flawed and massively overcomplicated.
This can be mitigated by removing the admin bar specific logic and leaving most of the heavy lifting up to the browser.

Fixes #37536

Props DvanKooten, lukecavanagh, karmatosed, ianbelanger, davidbaumwald


Built from https://develop.svn.wordpress.org/trunk@46308


git-svn-id: http://core.svn.wordpress.org/trunk@46107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 21:38:58 +00:00
desrosj
285ae90032 Build/Test Tools: Remove stray + introduced in [45979]. 
Props david.binda.
Fixes #48127.
Built from https://develop.svn.wordpress.org/trunk@46294


git-svn-id: http://core.svn.wordpress.org/trunk@46106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 19:55:58 +00:00
Andrea Fercia
f8a25a89c9 Accessibility: Implement the new focus styles on the login screen after [46247]. 
Props @kjellr.
See #47153.

Built from https://develop.svn.wordpress.org/trunk@46293


git-svn-id: http://core.svn.wordpress.org/trunk@46105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 16:40:00 +00:00
Sergey Biryukov
547be72c3b Pings/Trackbacks: Use correct variable in a foreach() loop in do_all_pings(). 
Props itowhid06.
Fixes #48094. See #36824.
Built from https://develop.svn.wordpress.org/trunk@46292


git-svn-id: http://core.svn.wordpress.org/trunk@46104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 15:50:58 +00:00
desrosj
6ff7ff50cd Build/Test Tools: Move Composer script command line directives to the PHPCS ruleset. 
Also, move all arguments up to the top of the custom ruleset to make it easier to understand the conditions the ruleset is run under.

Props desrosj, jrf.
See #46152.
Built from https://develop.svn.wordpress.org/trunk@46291


git-svn-id: http://core.svn.wordpress.org/trunk@46103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 14:02:57 +00:00
desrosj
894e133d0c Build/Test Tools: Introduce automated PHP compatibility checking. 
This change introduces a new Composer script, `compat` that will scan the codebase for (detectable) potential PHP compatibility issues using the `PHP_CodeSniffer` and a custom ruleset based off of the `PHPCompayibilityWP` ruleset (`phpcompat.xml.dist`).

The command will be run as a separate job within each Travis build. While many compatibility issues and false positives have already been corrected in this commit and other Trac tickets, there are still some remaining. For that reason, the job is allowed to fail while the remainder of the potential compatibility issues are investigated and addressed. After those are resolved, the job should be set as required to pass to help prevent new compatibility issues from being introduced.

Props desrosj, jrf, all PHPCompatibilityWP and PHPCompatibility contributors.
Fixes #46152.
Built from https://develop.svn.wordpress.org/trunk@46290


git-svn-id: http://core.svn.wordpress.org/trunk@46102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 13:47:58 +00:00
gziolo
bd344c19ea Block Editor: Align the version of React with the one used in Gutenberg plugin 
Gutenberg 6.5 works with react and react-dom set to v16.9.0. This change aligns both.

Props youknowriad.
Fixes #48121.



Built from https://develop.svn.wordpress.org/trunk@46289


git-svn-id: http://core.svn.wordpress.org/trunk@46101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-25 08:20:57 +00:00
Sergey Biryukov
c7f4cbc62c Docs: Improve consistency in @since tags for parameters that were made optional. 
See #47110.
Built from https://develop.svn.wordpress.org/trunk@46288


git-svn-id: http://core.svn.wordpress.org/trunk@46100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-24 12:54:57 +00:00
Sergey Biryukov
b35c5b9746 Script Loader: Add function_exists() checks for is_admin() and current_theme_supports(), to accomodate for using WP_Dependencies as a standalone class. 
Remove `<![CDATA[` when outputting HTML5 script tags. 

Props azaozz.
Fixes #42804.
Built from https://develop.svn.wordpress.org/trunk@46287


git-svn-id: http://core.svn.wordpress.org/trunk@46099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-24 02:56:57 +00:00
desrosj
c00074e6aa Post WordPress 5.3 Beta 1 version bump. 
Built from https://develop.svn.wordpress.org/trunk@46286


git-svn-id: http://core.svn.wordpress.org/trunk@46098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-24 00:17:56 +00:00
desrosj
3bd737c1b7 WordPress 5.3 Beta 1. 
Built from https://develop.svn.wordpress.org/trunk@46285


git-svn-id: http://core.svn.wordpress.org/trunk@46097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-23 23:54:56 +00:00
Sergey Biryukov
a943fd64bc Coding Standards: Fix WPCS issue in [46283]. 
See #48110.
Built from https://develop.svn.wordpress.org/trunk@46284


git-svn-id: http://core.svn.wordpress.org/trunk@46096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-23 23:24:57 +00:00
Sergey Biryukov
75ca249558 Twenty Twenty: Rename widget areas to sidebar-1 and sidebar-2. 
This ensures that widgets are mapped correctly and is consistent with the previous default themes.

See https://github.com/WordPress/twentytwenty/issues/481.

Reverts [46282].

Props ocean90, garrett-eclipse, desrosj, SergeyBiryukov.
See #48110.
Built from https://develop.svn.wordpress.org/trunk@46283


git-svn-id: http://core.svn.wordpress.org/trunk@46095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-23 23:17:58 +00:00
Sergey Biryukov
aaa3db74d8 Tests: Correct sidebar names for Twenty Twenty. 
See #48110.
Built from https://develop.svn.wordpress.org/trunk@46282


git-svn-id: http://core.svn.wordpress.org/trunk@46094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-23 22:04:59 +00:00
Sergey Biryukov
b95b6f2c73 Site Health: Move "The folder ... was detected as being under version control" message from failure to warning. 
Props afragen, davidbaumwald.
Fixes #47982.
Built from https://develop.svn.wordpress.org/trunk@46281


git-svn-id: http://core.svn.wordpress.org/trunk@46093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-23 21:24:56 +00:00
Sergey Biryukov
3c6ce558f9 REST API: Use delta comparison for floating date tests added in [46252] to avoid race conditions. 
See #39953.
Built from https://develop.svn.wordpress.org/trunk@46280


git-svn-id: http://core.svn.wordpress.org/trunk@46092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-23 21:18:58 +00:00
K. Adam White
81ed396972 Posts, Post Types: Build list of "date floating" post stati dynamically when inserting post. 
Completes work begun in #39953 to expose "date floating" status information to frontend clients via the REST API.

Props TimothyBlynJacobs.
Fixes #48113.

Built from https://develop.svn.wordpress.org/trunk@46279


git-svn-id: http://core.svn.wordpress.org/trunk@46091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-09-23 21:02:56 +00:00