John Blackbourn
3caaa40fc6
Docs: Switch more docs over to typed array notation, plus some fixes.
...
See #48303 , #41756
Built from https://develop.svn.wordpress.org/trunk@46596
git-svn-id: http://core.svn.wordpress.org/trunk@46393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-26 21:09:04 +00:00
Sergey Biryukov
96b4570781
Privacy: Remove reinstated wp-admin/options-privacy.php
from $_old_files
.
...
Fix WPCS violations in [45448].
See #43895 .
Built from https://develop.svn.wordpress.org/trunk@45453
git-svn-id: http://core.svn.wordpress.org/trunk@45264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-27 02:40:53 +00:00
Andrew Ozz
87acdab81d
Privacy tools: Organize privacy functions into logical files and classes.
...
Props xkon, birgire, desrosj, garrett-eclipse, azaozz.
See #43895 .
Built from https://develop.svn.wordpress.org/trunk@45448
git-svn-id: http://core.svn.wordpress.org/trunk@45259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-26 20:50:53 +00:00
John Blackbourn
8b34c79cec
Docs: Update and correct various inline documentation.
...
See #42505 , #41756
Built from https://develop.svn.wordpress.org/trunk@43177
git-svn-id: http://core.svn.wordpress.org/trunk@43006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-07 17:20:22 +00:00
Gary Pendergast
aaf99e6913
Code is Poetry.
...
WordPress' code just... wasn't.
This is now dealt with.
Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057 .
Built from https://develop.svn.wordpress.org/trunk@42343
git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Scott Taylor
a3ffebce30
Bootstrap: do not go gentle into that good night r38411, r38412, and parts of r38389.
...
See #36335 .
Built from https://develop.svn.wordpress.org/trunk@38470
git-svn-id: http://core.svn.wordpress.org/trunk@38411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-31 16:31:29 +00:00
Scott Taylor
5d94d97b29
List Tables: AJAX actions for List Tables do not need to declare global $wp_list_table
. List tables on admin screens are in global scope, and they contain hooks that don't pass the the list table as context, hence using globals there so that functions can import them. That problem does not exist in the AJAX actions, which are virtually impossible to hook into as is.
...
See #37699 .
Built from https://develop.svn.wordpress.org/trunk@38455
git-svn-id: http://core.svn.wordpress.org/trunk@38396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-30 20:07:29 +00:00
Scott Taylor
390ceba6c7
Bootstrap: after r38409 and r38410, revert r38402 which reverted r38399.
...
This fixes the paths in `wp-vendor/` that were including `src`. I want to drop this in so we can find out what else will break.
See #36335 .
Built from https://develop.svn.wordpress.org/trunk@38411
git-svn-id: http://core.svn.wordpress.org/trunk@38352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-27 22:32:37 +00:00
Dion Hulse
0e31a46161
Bootstrap: Revert [38399] as it's broken /build/
and subsequently core.svn.wordpress.org.
...
The generated classmaps reference `/src/` files and operates in the assumption that the base directory is one level above `wp-settings.php`, which it isn't after our build processes are run.
See #36335
Built from https://develop.svn.wordpress.org/trunk@38402
git-svn-id: http://core.svn.wordpress.org/trunk@38343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-27 14:37:32 +00:00
Scott Taylor
6a529648cf
Bootstrap: Autoload classes using a Composer-generated PHP 5.2-compatible Autoloader.
...
* `wp-admin` and `wp-includes` are scanned for classes to autoload
* Several 3rd-party and Ryan McCue-shaped libraries are excluded when the classmap is generated, see `composer.json`: `autoload.exclude-from-classmap`
* `wp-vendor/autoload_52.php` is included at the top of `wp-settings.php` - no changes need to be made to unit tests to include the autoloader
* An avalanche of `require()` and `require_once()` calls that loaded class files have been removed from the codebase.
The following files have been added to `svn:ignore` - they are not 5.2-compatible and fail during pre-commit:
* src/wp-vendor/autoload.php
* src/wp-vendor/composer/autoload_real.php
* src/wp-vendor/composer/autoload_static.php
* src/wp-vendor/composer/ClassLoader.php
We favor these files instead:
* src/wp-vendor/autoload_52.php
* src/wp-vendor/composer/autoload_real_52.php
* src/wp-vendor/composer/ClassLoader52.php
When new PHP classes are added to the codebase, simply run `composer install` or `composer update` from the project root to update the autoloader.
The future is now.
See #36335 .
Built from https://develop.svn.wordpress.org/trunk@38399
git-svn-id: http://core.svn.wordpress.org/trunk@38340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-27 09:15:29 +00:00
Scott Taylor
06aa510d56
List Tables: move _WP_List_Table_Compat
into its own file.
...
See #37827 .
Built from https://develop.svn.wordpress.org/trunk@38392
git-svn-id: http://core.svn.wordpress.org/trunk@38333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-26 22:23:29 +00:00
John Blackbourn
a5d44337b2
Docs: @param
fixes for a variety of docblocks.
...
See #32246
Built from https://develop.svn.wordpress.org/trunk@36232
git-svn-id: http://core.svn.wordpress.org/trunk@36199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 01:45:26 +00:00
Scott Taylor
a1ead3c7e3
List Tables: in _WP_List_Table_Compat::get_column_info()
, also return $primary
, which is expected since [33016].
...
Props tyxla.
Fixes #34148 .
Built from https://develop.svn.wordpress.org/trunk@34897
git-svn-id: http://core.svn.wordpress.org/trunk@34862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-07 03:12:24 +00:00
Sergey Biryukov
4c019c6aee
Comments: Fix a fatal error in Comments meta box after [34223].
...
Props tyxla.
Fixes #33893 . See #33413 .
Built from https://develop.svn.wordpress.org/trunk@34231
git-svn-id: http://core.svn.wordpress.org/trunk@34195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 11:37:25 +00:00
Scott Taylor
5920e8eb13
Move WP_Post_Comments_List_Table
to its own file.
...
See #33413 .
Built from https://develop.svn.wordpress.org/trunk@34223
git-svn-id: http://core.svn.wordpress.org/trunk@34187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 06:53:24 +00:00
Scott Taylor
6a08b00632
Add @access
annotations to methods that have no doc block in wp-admin/includes/*
.
...
Makes it easier to search for no doc blocks via `}[\n\t\r ]+(protected|private|public)`.
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32656
git-svn-id: http://core.svn.wordpress.org/trunk@32626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 21:32:24 +00:00
Scott Taylor
b56b9b3e5c
Add @global
annotations for wp-admin/*
.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32642
git-svn-id: http://core.svn.wordpress.org/trunk@32612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 21:41:30 +00:00
Scott Taylor
176b9b2301
Fix mismatches in access modifiers for WP_List_Table
+ subclasses.
...
Fixes #28843 , #28879 .
Built from https://develop.svn.wordpress.org/trunk@29137
git-svn-id: http://core.svn.wordpress.org/trunk@28921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-13 22:09:16 +00:00
Scott Taylor
7de0b2b2c8
Upgrade _WP_List_Table_Compat
to PHP5-style constructor.
...
Add `public` to methods/members of `WP_Role`.
Add `public` to methods/members of `WP_User` where appropriate. Don't set `private` where indicated until more study has occurred and tests have been written for compatibiliy with existing magic methods.
See #27881 , #22234 .
Built from https://develop.svn.wordpress.org/trunk@28531
git-svn-id: http://core.svn.wordpress.org/trunk@28357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 17:20:17 +00:00
Scott Taylor
2f513d3320
Fix some hackificator
odds and ends in wp-admin
:
...
* `wp-activate.php` and `wp-admin/themes.php` don't need the closing PHP tag
* Switch single quotes for HTML attribute values to double in a few places
* Convert `include_once file.php` syntax to `include_once( 'file.php' )`
* Add access modifiers to methods/members in: `_WP_List_Table_Compat`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`, `WP_Screen`, `Walker_Category_Checklist`
* `edit_user()` doesn't need to import the `$wpdb` global
* `wp_list_widgets()` doesn't need to import the `$sidebars_widgets` global
* switch/endswitch syntax is not supported in Hack
* A `<ul>` in `wp-admin/users.php` is unclosed
See #27881 .
Built from https://develop.svn.wordpress.org/trunk@28500
git-svn-id: http://core.svn.wordpress.org/trunk@28326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 05:04:16 +00:00
Scott Taylor
31f26dc3ce
Remove lingering instances of call time pass-by-reference, limited to instances of callable
- use $this
instead of &$this
.
...
Props jdgrimes.
See #25160 .
Built from https://develop.svn.wordpress.org/trunk@25254
git-svn-id: http://core.svn.wordpress.org/trunk@25222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-05 16:34:09 +00:00
Andrew Nacin
262ee531cb
Only pass the current screen to the list table constructor when we have a screen to work with. This is not the case for admin-ajax requests. fixes #22570 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-26 03:39:29 +00:00
Ryan Boren
a3cfe28527
Reduce reliance on global variables in the list tables. Allow passing a screen ID to the list tables so that ajax handlers can set the needed screen.
...
Props nacin
fixes #21871
git-svn-id: http://core.svn.wordpress.org/trunk@21914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-19 12:43:31 +00:00
nacin
05313daa77
Output themes and theme-install infinite scrolling args in JS, rather than parsing query strings. props DH-Shredder, helenyhou. Make WP_Theme_Install_List_Table extend WP_Themes_List_Table. Doesn't help much yet, but we should be able to dry things up further. see #19815 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-02 22:09:26 +00:00
ryan
e3b46b25d3
Lose EOF ?>. Clean up EOF newlines. fixes #12307
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
nacin
37075f7f71
Remove AJAX from list tables. first pass. see #16262 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-16 21:47:24 +00:00
westi
93465db918
The old methods are good enough in alot of cases where plugins want to extend simply. So un deprecate for now.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-13 23:19:51 +00:00
nacin
041c9a445e
Don't double-slash list table include. props wpmuguru, fixes #15904 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-20 09:14:15 +00:00
ryan
847499e531
Pinking shears
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-17 18:47:34 +00:00
westi
5e90c5d1c3
Revert [16171] and [16172] - The class names were fine as they were and the MultiSite classes stand out more with the original naming.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-04 08:07:03 +00:00
scribu
836ec33dca
List-table Class Names: Consistency's Revenge. See #14579
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-03 21:09:27 +00:00
westi
8b62d686ca
Group the Network admin List Tables class mapping seperately so they are easier to pick out. See #14435 , #14579
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-01 09:24:32 +00:00
westi
ad92d629d6
The big renaming of the list-table class files.
...
See #14579
git-svn-id: http://svn.automattic.com/wordpress/trunk@16128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-01 09:19:50 +00:00
westi
c66629c140
Split out the list table functions into a seperate file from the base class.
...
See #14579 .
git-svn-id: http://svn.automattic.com/wordpress/trunk@16127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-01 08:56:27 +00:00
nacin
f448471380
Shuffle list-table files. First pass. see #14579 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-25 00:12:41 +00:00
scribu
10ec70d244
Use row_actions() in WP_Plugins_Table. See #14579
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-23 11:22:00 +00:00
nacin
14ccdbec33
Pruning shears.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-21 19:55:28 +00:00
scribu
26f95f26d7
Fix notices in WP_List_Table::ajax_response(). Props Utkarsh. Fixes #15185
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-21 15:30:35 +00:00
scribu
db6cb9d47f
Use isset() instead of '@'. Props Utkarsh. See #14579
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-21 15:15:50 +00:00
nacin
5e1184aa57
Pinking shears.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-19 07:48:22 +00:00
scribu
c3a31b6576
Add WP_List_Table columns before all others. Fixes #15075
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-09 09:39:16 +00:00
nacin
b7bacd1bf2
s/Wether/Whether/
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-08 02:35:06 +00:00
scribu
11642d9baa
Remove misplaced code introduced in [15653]. See #14579
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-24 19:38:21 +00:00
scribu
248b086540
Column headers revamp:
...
* undeprecate get_column_headers()
* undeprecate get_hidden_columns()
* in WP_List_Table, rename get_column_headers() to get_column_info()
* remove $taxonomy argument from single_row()
* merge manage_columns_prefs() into screen_meta()
Fixes #14952 . Fixes #14776 .
git-svn-id: http://svn.automattic.com/wordpress/trunk@15653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-24 13:35:06 +00:00
scribu
e975e650cf
Introduce WP_List_Table::current_action() and use throughout admin list screens. See #14579
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-22 00:10:39 +00:00
scribu
a927a1665c
Extra single_row_columns() out of single_row() for increased flexibility. See #14579
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-18 17:21:32 +00:00
scribu
93d4b0c223
Add default display_rows() and single_row() methods to WP_List_Table. See #14579
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-16 20:07:39 +00:00
scribu
9a9e872597
introduce WP_List_Table::views(). See #14579
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-05 21:26:27 +00:00
scribu
f24da67b4b
Introduce WP_List_Table::row_actions(). See #14579
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-05 16:53:59 +00:00
scribu
c02669236e
Introduce WP_List_Table::get_items_per_page(). See #14579
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-05 15:15:46 +00:00