Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-07-02 09:44:58 +02:00
Code Issues Projects Releases Wiki Activity
37,611 Commits 49 Branches 744 Tags 928 MiB
fbee634ac7
Commit Graph

50 Commits

Author SHA1 Message Date
Andrea Fercia
a4ae97437b Administration: Thickbox: Fix conflicts with the Plugin details and native Thickbox modals. 
The Plugin details modal custom implementation in the Plugins page conflicts with
other Thickbox instances added by plugins. Thickbox shows its age and has been
modified over time to suit core needs. However, WordPress should do its best to
not create conflicts with the native Thickbox styles and functionalities. Plugin
authors should be able to use `add_thickbox()` in any admin page as documented, 
without having to worry about potential errors.

- fixes a JavaScript error when closing a native Thickbox modal in the Plugins page
- avoids to override the native Thickbox modal styles
- uses a CSS class to target the Plugin details modal and remove a pile of overqualified CSS selectors

Fixes #41417.

Built from https://develop.svn.wordpress.org/trunk@41356


git-svn-id: http://core.svn.wordpress.org/trunk@41189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-09-09 14:14:43 +00:00
Andrea Fercia
15ce1ec939 Accessibility: the Thickbox "Close" control should always be a button. 
Fix the last case where the "Close" control was still a link. All the other ones
were already changed in buttons.

Fixes #36267.
Built from https://develop.svn.wordpress.org/trunk@37531


git-svn-id: http://core.svn.wordpress.org/trunk@37499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 10:30:29 +00:00
Andrea Fercia
fd1f45a7cf Accessibility: Improve accessibility for the Plugin details modal. 
The plugin details modal can be invoked from several screens. There's now a new
`.open-plugin-details-modal` CSS class to be used in combination with the
`.thickbox` CSS class that adds everything needed for accessibility.

- Adds an ARIA role `dialog` and an `aria-label` attribute to the modal
- Adds a `title` attribute to the iframe inside the modal
- Constrains tabbing within the modal
- Restores focus back in a proper place when closing the modal

Also, improves a bit the native Thickbox implementation: it should probably be
replaced with some more modern tool but at least keyboard focus should be moved
inside the modal.

Fixes #33305.
Built from https://develop.svn.wordpress.org/trunk@36964


git-svn-id: http://core.svn.wordpress.org/trunk@36932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-10 22:37:26 +00:00
Andrea Fercia
a71f14b8d9 Accessibility: Reduce the WordPress shades of grey, Episode 3. 
Also, removes some no more used CSS.

See #35783.
Built from https://develop.svn.wordpress.org/trunk@36904


git-svn-id: http://core.svn.wordpress.org/trunk@36872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-09 19:51:26 +00:00
Scott Taylor
f507751a40 Thickbox: spinner should disappear when loading is done. 
Props niklasbr, afercia.
Fixes #33311.

Built from https://develop.svn.wordpress.org/trunk@35418


git-svn-id: http://core.svn.wordpress.org/trunk@35382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-28 18:19:26 +00:00
Scott Taylor
d22fbc7545 Grunt RTL CSS: swap-dashicons-left-right-arrows in rtlcss:properties expects double-quoted content strings in CSS. It doesn't swap single-quoted values. 
Props Ankit K Gupta, yoavf, netweb.
Fixes #33786.

Built from https://develop.svn.wordpress.org/trunk@34011


git-svn-id: http://core.svn.wordpress.org/trunk@33980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 20:22:25 +00:00
Scott Taylor
f5c754bfed Dashicons CSS: one-word font families don't need quotes. Font families with a space in the name should use double-quotes (doesn't apply here). 
Props afercia.
Fixes #32866.

Built from https://develop.svn.wordpress.org/trunk@33912


git-svn-id: http://core.svn.wordpress.org/trunk@33881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 19:57:25 +00:00
Scott Taylor
1c0fa5f73a In tb_show() in thickbox, when loading content into #TB_ajaxContent, make sure a URL with no ? doesn't break when &random= is appended to it. 
Thickbox hasn't been updated since 2007, just FYI.

Fixes #31726.

Built from https://develop.svn.wordpress.org/trunk@32503


git-svn-id: http://core.svn.wordpress.org/trunk@32473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-13 21:42:24 +00:00
Helen Hou-Sandí
bfda508c18 Update more instances of default admin blues and grays. 
props hugobaeta.
fixes #31234.

Built from https://develop.svn.wordpress.org/trunk@32051


git-svn-id: http://core.svn.wordpress.org/trunk@32030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-05 21:20:27 +00:00
John Blackbourn
cca329174f Improve Thickbox's close button so it can be announced by screen readers. 
Fixes #29455
Props SergeyBiryukov

Built from https://develop.svn.wordpress.org/trunk@30376


git-svn-id: http://core.svn.wordpress.org/trunk@30373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-18 03:55:23 +00:00
Drew Jaynes
d33c807723 Fix some documentation typos in various core files. 
Props vlajos.
Fixes #29199.

Built from https://develop.svn.wordpress.org/trunk@29479


git-svn-id: http://core.svn.wordpress.org/trunk@29257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-13 03:56:17 +00:00
Dominik Schilling
fb9084eed3 Disable background page scrolling when modals are open. 
props celloexpressions.
fixes #29074.
Built from https://develop.svn.wordpress.org/trunk@29346


git-svn-id: http://core.svn.wordpress.org/trunk@29124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-01 20:15:15 +00:00
Andrew Ozz
513b6992e5 Restyle the plugin install details modal to match the rest of the admin. Props avryl and paulwilde for initial mockup, see #26952 
Built from https://develop.svn.wordpress.org/trunk@27559


git-svn-id: http://core.svn.wordpress.org/trunk@27402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-16 18:28:17 +00:00
Andrew Ozz
93ec80e732 Modals: darken all overlays, update all box-shadows and headings, correct thickbox styling, make the link modal narrower and bring back the animation (css transition). Props avryl, see #26952 
Built from https://develop.svn.wordpress.org/trunk@27532


git-svn-id: http://core.svn.wordpress.org/trunk@27375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-14 05:55:16 +00:00
Andrew Ozz
2f6d9d37cc Consolidate "close on Escape" in the media modal, DFW, wpLink and Thickbox. Props kovshenin, fixes #26854. 
Built from https://develop.svn.wordpress.org/trunk@27080


git-svn-id: http://core.svn.wordpress.org/trunk@26953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-03 05:31:14 +00:00
Andrew Nacin
1154c059ef RTL font-family overrides. (Tahoma generally, and Arial for Hebrew.) 
props yoavf.
fixes #24977.

Built from https://develop.svn.wordpress.org/trunk@26816


git-svn-id: http://core.svn.wordpress.org/trunk@26703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-09 01:31:11 +00:00
Andrew Nacin
1a34e361ac Fix z-indexes as it relates to thickbox, the theme modal, and admin menu. 
props ryelle, shaunandrews.
fixes #26442.

Built from https://develop.svn.wordpress.org/trunk@26701


git-svn-id: http://core.svn.wordpress.org/trunk@26591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-05 23:10:11 +00:00
Matt Thomas
97319603e3 Move thickbox styles from wp-admin.css to thickbox.css. Remove old png close icons. Fixes #26178. 
Built from https://develop.svn.wordpress.org/trunk@26395


git-svn-id: http://core.svn.wordpress.org/trunk@26295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-26 05:32:09 +00:00
Andrew Nacin
2301074821 Stop using deprecated jQuery API (.browser and .live). Do manual UA sniffing where still necessary. Improve selector performance by using delegated events. props ocean90. see #22975. 
git-svn-id: http://core.svn.wordpress.org/trunk@23518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-28 18:05:28 +00:00
Andrew Nacin
7183a9cce9 Introduce a new, cross-browser HiDPI CSS @media rule to be used everywhere. 
{{{
@media print,
  (-o-min-device-pixel-ratio: 5/4),
  (-webkit-min-device-pixel-ratio: 1.25),
  (min-resolution: 120dpi) {
}}}

Serve HiDPI graphics for printing, regardless of screen resolution.

Specify Opera's vendor-prefixed device pixel ratio property, for Opera desktop.

Specify a minimum Webkit device pixel ratio of 1.25 instead of 1.5, to serve
2x images to Android devices that are between 1 and 1.5x (like the Nexus 7).
Firefox and Opera will respond to 1.5x on these devices, but Chrome will not.

Specify min-resolution, which covers Firefox 19. Opera on Android also supports
min-resolution, but Opera Mini does not support dppx, so the dpi unit is used.

props iammattthomas for the exhaustive research.
props lessbloat for patching.

fixes #22238.



git-svn-id: http://core.svn.wordpress.org/trunk@22629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-17 06:50:08 +00:00
Mark Jaquith
2ec9c4acc2 Use ImageOptim to losslessly smush our images. About half a MB in savings! fixes #22381. props waldojaquith 
git-svn-id: http://core.svn.wordpress.org/trunk@22425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-07 18:49:10 +00:00
Andrew Nacin
32ad332432 Update Thickbox images for HiDPI. props lessbloat. see #21019. 
git-svn-id: http://core.svn.wordpress.org/trunk@22378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-05 21:00:15 +00:00
Andrew Nacin
2f7bb69ffa Switch to sans-serif for the font stack in Thickbox as we have done elsewhere. props wet, fixes #20268. 
git-svn-id: http://core.svn.wordpress.org/trunk@21834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-13 17:08:01 +00:00
azaozz
2d97f8794a Rename the problematic "unload" event in Thickbox to "tb_unload", making it a true custom event, fixes #19189 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-26 17:49:50 +00:00
azaozz
b41176ce79 Revert [19264] to keep back-compat. Any improperly fired window.unload will have to be dealt with on a case by case basis. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-25 17:33:31 +00:00
azaozz
ac807f00fb Thickbox: do .triggerHandler() instead of .trigger(), props duck_, fixes #19189 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-12 06:48:04 +00:00
azaozz
bb3196ea8e Fix thickbox (again!), props SergeyBiryukov, fixes #18796 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-09-30 22:24:34 +00:00
azaozz
91a8720fff Pluploader take 1, props jacobwg, see #18206 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-07-29 08:59:35 +00:00
azaozz
2d2f8d4c6f s/Colse/Close/, props nacin, fixes #17399 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-05-29 05:07:32 +00:00
azaozz
9739cfea3c Don't close DFW when closing modal dialogs with Escape key, fixes #17399 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-05-29 02:04:52 +00:00
dd32
ba0153096a Revert [17608] adding back [17596] and actually include the dummy function this time. See #17057 Fixes #17050 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-04-06 00:42:07 +00:00
nacin
b4a2ecf0c4 Revert [17596] for now. props kawauso, see #17057, see #17050. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-04-05 23:17:10 +00:00
dd32
0ec5e89f63 Pass image URL's to thickbox via L10n in script-loader.php. Allows thickbox to be used on any page in the install without defining the image URL variables. Fixes #17050 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-04-05 03:58:25 +00:00
markjaquith
46a353ece7 TB_iframe fixes for stuff that broke in r14015. props scribu. fixes #12878. see #12792 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-07 13:52:12 +00:00
markjaquith
07a523894a Make thumbnail work for custom post types even if the editor is not being displayed. props scribu. fixes #12792 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-06 11:20:47 +00:00
dd32
a2a1a3c9f0 JQuery.noConflict() fix for thickbox.js. Props Michael. Fixes #12382 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-03-28 04:48:20 +00:00
azaozz
1fd65dfefb Show error message in TB when iframes support is turned off in the browser, props nacin, fixes #10939 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-01-09 01:17:45 +00:00
azaozz
474642271d l10n for thickbox.js, props nbachiyski, fixes #10278 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-11-25 11:08:39 +00:00
azaozz
c131504b28 Let plugins predefine thickbox image vars, props aaroncampbell, fixes #6453 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-11-18 00:19:55 +00:00
azaozz
038b556b23 Fix Thickbox positioning for browsers pretending to be IE6, props Denis-de-Bernardy, fixes #8933 for trunk 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-01-24 11:58:21 +00:00
azaozz
bc871c819e jQuery 1.3b2 and related changes (jquery.js is not minified to aid testing) 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-01-07 05:02:40 +00:00
azaozz
a750885c8e Minify all js and add the non-minified files as .dev.js 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-01-02 15:08:58 +00:00
azaozz
a0d49f5ee3 Visual design fixes from iammattthomas, fixes #8313 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-11-22 08:03:25 +00:00
ryan
696050f9ad Add macFFBgHack.png. fixes #6573 for trunk 
git-svn-id: http://svn.automattic.com/wordpress/trunk@8457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-07-25 22:42:31 +00:00
ryan
f8012b15fb Image popup improvements from azaozz. Added translation strings, RTL support, several layout improvements, image border, hspace and vspace can be used as shortcuts to add css styles, the preview is visible on both tabs, etc. see #6811 
git-svn-id: http://svn.automattic.com/wordpress/trunk@8083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-06-14 16:38:08 +00:00
ryan
bc07ef1efe Theme preview and thickbox CSS cleanup. Props azaozz. see #5486 
git-svn-id: http://svn.automattic.com/wordpress/trunk@7961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-05-20 17:19:33 +00:00
ryan
020eb02ef0 thickbox and media upload fixes from azaozz. fixes #6843 
git-svn-id: http://svn.automattic.com/wordpress/trunk@7862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-04-30 20:21:09 +00:00
westi
e65d6369f2 Switch from addLoadEvent to jQuery(document).ready. Fixes #6241 props azaozz. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@7325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-03-15 22:57:47 +00:00
matt
23770cb94e Have the bottom boxes be closed by default. Remove the global padding kill from thickbox CSS. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-01-14 00:20:52 +00:00
ryan
3388050bf9 New image uploader from tellyworth. see #5609 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-01-09 08:14:29 +00:00