Commit Graph

25986 Commits

Author SHA1 Message Date
Drew Jaynes
ec88da1ee3 Clarify documentation for *what* gets "automatically fired" when the do_mu_upgrade filter evaluates to true in Multisite.
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28376


git-svn-id: http://core.svn.wordpress.org/trunk@28204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 04:18:14 +00:00
Drew Jaynes
b4ca72583a Fix incomplete inline documentation for the wp_header_image_attachment_metadata filter.
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28375


git-svn-id: http://core.svn.wordpress.org/trunk@28203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 04:13:15 +00:00
Scott Taylor
6bbc5b570c Eliminate use of extract() in wp_insert_category(). Adds unit tests. All unit tests pass.
Props MikeHansenMe.
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28374


git-svn-id: http://core.svn.wordpress.org/trunk@28202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 03:27:13 +00:00
Scott Taylor
8af6a4230e Eliminate use of extract() in wp-activate.php.
Props jeremyfelt, MikeHansenMe.
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28373


git-svn-id: http://core.svn.wordpress.org/trunk@28201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 03:14:16 +00:00
Scott Taylor
f32dbfe62c Add xps and oxps extensions to list of supported document types.
More: http://en.wikipedia.org/wiki/Open_XML_Paper_Specification

Fixes #15697.


Built from https://develop.svn.wordpress.org/trunk@28372


git-svn-id: http://core.svn.wordpress.org/trunk@28200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 07:19:13 +00:00
Scott Taylor
5682d30b6e In wp.media.view.Settings::update(), when handling checkboxes, check for a value of 'false' in addition to casting value to boolean. !! 'false' evaluates to true.
Props adamsilverstein.
Fixes #23954.


Built from https://develop.svn.wordpress.org/trunk@28371


git-svn-id: http://core.svn.wordpress.org/trunk@28199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 07:03:15 +00:00
Scott Taylor
aeadf0c7cf Allow users to set overrides for MediaElement instances by always passing _wpmejsSettings instead of just _wpmejsSettings.pluginPath.
Props Otto42 for the initial patch.
Fixes #25243.


Built from https://develop.svn.wordpress.org/trunk@28370


git-svn-id: http://core.svn.wordpress.org/trunk@28198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 06:25:15 +00:00
Scott Taylor
558cf6f86d In the Attachment Details section of the media modal, only add box-shadow to images. Other mime-type icons look strange with an arbitrary border.
Props avryl.
Fixes #27949.


Built from https://develop.svn.wordpress.org/trunk@28369


git-svn-id: http://core.svn.wordpress.org/trunk@28197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 06:19:14 +00:00
Scott Taylor
2bea9fcc0b In media_upload_gallery_form()'s inline JavaScript, remove unnecessary comment tags.
Fixes #25637.


Built from https://develop.svn.wordpress.org/trunk@28368


git-svn-id: http://core.svn.wordpress.org/trunk@28196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 06:12:15 +00:00
Scott Taylor
88b96dc036 In wp_read_image_metadata(), the values from exif_read_data() should only override values from iptcparse() that are empty.
Props SergeyBiryukov.
Fixes #23706.

Built from https://develop.svn.wordpress.org/trunk@28367


git-svn-id: http://core.svn.wordpress.org/trunk@28195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 05:54:15 +00:00
Scott Taylor
e9f87b2688 Avoid a notice in wp_save_image() by checking $meta['sizes']['thumbnail'] for ! empty() before setting a variable to it.
Props MikeHansenMe.
Fixes #17736.


Built from https://develop.svn.wordpress.org/trunk@28366


git-svn-id: http://core.svn.wordpress.org/trunk@28194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 03:42:14 +00:00
Scott Taylor
60f395e4c2 Update the default (WP-defined) styles for MediaElement players to be more in-line with our flat aesthetic. Use the new official colors.
Props celloexpressions.
Fixes #27516.


Built from https://develop.svn.wordpress.org/trunk@28365


git-svn-id: http://core.svn.wordpress.org/trunk@28193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 02:23:14 +00:00
Scott Taylor
37b7f39e95 When pausing "all" players attached to MCE views, don't reach into global scope and pause "every" player. Only pause the players bound to MCE views.
Fixes #27971.


Built from https://develop.svn.wordpress.org/trunk@28364


git-svn-id: http://core.svn.wordpress.org/trunk@28192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 02:07:14 +00:00
Scott Taylor
fb1aab6520 Support loop for [audio] and [video] shortcodes that specify files that are played using MediaElement's Flash plugin bridge.
Fixes #27368.


Built from https://develop.svn.wordpress.org/trunk@28363


git-svn-id: http://core.svn.wordpress.org/trunk@28191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 01:28:15 +00:00
Scott Taylor
5df38694e9 In get_the_author_posts(), if there is no current $post, return 0 and bail.
Props krogsgard, aaroncampbell.
Fixes #27998.


Built from https://develop.svn.wordpress.org/trunk@28362


git-svn-id: http://core.svn.wordpress.org/trunk@28190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 00:26:14 +00:00
Scott Taylor
d06c353995 MediaElement players need clear: both to play nice with adjacent floated elements.
Fixes #27385.


Built from https://develop.svn.wordpress.org/trunk@28361


git-svn-id: http://core.svn.wordpress.org/trunk@28189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 00:14:14 +00:00
Scott Taylor
0b6729c3f9 In WP_Terms_List_Table::single_row(), call sanitize_term() on the passed term ($tag).
Props oso96_2000, c3mdigital, scribu. 
It takes a village.
Fixes #16864.

Built from https://develop.svn.wordpress.org/trunk@28360


git-svn-id: http://core.svn.wordpress.org/trunk@28188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 00:05:15 +00:00
Scott Taylor
9daf458ff0 Remove the title attribute from markup generated in wp-includes/category-template.php:
* `get_category_parents()`
* `get_the_category_list()`
* `wp_generate_tag_cloud()`
* `Walker_Category::start_el()`	

Props joedolson.
Fixes #26557.	


Built from https://develop.svn.wordpress.org/trunk@28359


git-svn-id: http://core.svn.wordpress.org/trunk@28187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-10 23:57:16 +00:00
Scott Taylor
f22beb987c First pass at wpview logic for the [embed] shortcode. URLs on a their own line are parsed as well. The toolbar will appear with the "remove" button when the view is clicked. Edit has not been implemented yet.
Props avryl, wonderboymusic.
See #28195.


Built from https://develop.svn.wordpress.org/trunk@28358


git-svn-id: http://core.svn.wordpress.org/trunk@28186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-10 23:36:18 +00:00
Drew Jaynes
9098b45e53 Add inline documentation of the default arguments for wp_list_pages().
Props garza for the initial patches.
Fixes #11338.

Built from https://develop.svn.wordpress.org/trunk@28357


git-svn-id: http://core.svn.wordpress.org/trunk@28185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-10 08:02:14 +00:00
Drew Jaynes
81cfb9427a Fix mid-file section header style in wp-admin/includes/ajax-actions.php.
See #28200.

Built from https://develop.svn.wordpress.org/trunk@28356


git-svn-id: http://core.svn.wordpress.org/trunk@28184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-10 05:02:13 +00:00
Drew Jaynes
0ef7244ce7 Add baseline doc blocks for all ajax handlers in ajax-actions.php.
Fixes #28200.

Built from https://develop.svn.wordpress.org/trunk@28355


git-svn-id: http://core.svn.wordpress.org/trunk@28183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-10 05:00:19 +00:00
Drew Jaynes
f609524261 Minor phpDoc fixes for the got_rewrite, got_url_rewrite, and documentation_ignore_functions hooks.
Props GaryJ.
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28352


git-svn-id: http://core.svn.wordpress.org/trunk@28180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-08 11:13:14 +00:00
Drew Jaynes
c02696f43f Rename the $action hook in wp-admin/admin-post.php to admin_post{$action}.
Also, clarify documentation of priv vs nopriv prefixing of the hook name.

See #26869.

Built from https://develop.svn.wordpress.org/trunk@28351


git-svn-id: http://core.svn.wordpress.org/trunk@28179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-08 11:00:15 +00:00
Drew Jaynes
f427187fa8 Revert [28349] in favor of retaining the single dynamic admin_post* hook.
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28350


git-svn-id: http://core.svn.wordpress.org/trunk@28178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-08 10:47:15 +00:00
Drew Jaynes
a6755201d8 Convert and rename the $action hook in wp-admin/admin-post to two dynamic hook sets.
* `admin_post_nopriv{$request_action}` is fired for logged-out users
* `admin_post{$request_action}` is fired for logged-in users

Props Otto42, DrewAPicture.
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28349


git-svn-id: http://core.svn.wordpress.org/trunk@28177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-08 10:27:14 +00:00
Drew Jaynes
32e674f44e Use interpolation instead of concatenation for the manage_{$screen->id}_columns hook name.
Props Otto42.
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28348


git-svn-id: http://core.svn.wordpress.org/trunk@28176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-08 09:58:14 +00:00
Drew Jaynes
8906f83802 Use an interpolated hook name for edit_{$post_type}_per_page instead of $per_page and adjust docs accordingly.
Also references the correct variable for the `$posts_per_page` parameter in the `edit_posts_per_page` hook doc.

Props Otto42 for the initial patch.
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28347


git-svn-id: http://core.svn.wordpress.org/trunk@28175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-08 08:16:15 +00:00
Scott Taylor
1daa7d6723 Leverage size_format() when displaying max_upload_size:
* In `media_upload_form()` 
* The `uploader-inline` Underscore template in the media modal. 

Replaces 2 buggy inline implementations that could display size units off by one, or size values off by one.

Fixes #25643.


Built from https://develop.svn.wordpress.org/trunk@28343


git-svn-id: http://core.svn.wordpress.org/trunk@28171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 18:25:14 +00:00
Scott Taylor
3bbed6ceac audio, video, and playlist shortcodes:
* Convert all instances of variable variables to array properties
* Eradicate use of `extract()`
* Rename `$atts` to `$html_atts` where collision with new `$atts` (shortcode atts holder) var might occur

See #22400, #27881.


Built from https://develop.svn.wordpress.org/trunk@28342


git-svn-id: http://core.svn.wordpress.org/trunk@28170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 17:36:18 +00:00
Lance Willett
42d2f4fc21 Bundled themes: use correct logic in IE conditional comments in header template. Props mikemanger, fixes #28151.
Built from https://develop.svn.wordpress.org/trunk@28341


git-svn-id: http://core.svn.wordpress.org/trunk@28169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 04:27:15 +00:00
Scott Taylor
aa83aea519 In wp-login.php, break is unreachable after exit
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28340


git-svn-id: http://core.svn.wordpress.org/trunk@28168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 03:58:15 +00:00
Scott Taylor
361e3e1ee6 In wpdb, remove dead code:
* In `->tables()`, `break` is unreachable after `return`
* In `->query()`, `$return` is always set, so doesn't need an initial value of `0`
* In `->delete()`, `$bits` is unused

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28339


git-svn-id: http://core.svn.wordpress.org/trunk@28167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 03:56:14 +00:00
Scott Taylor
06373a6f32 In WP_Widget::update_callback(), $sidebars_widgets is unused.
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28338


git-svn-id: http://core.svn.wordpress.org/trunk@28166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 03:52:15 +00:00
Scott Taylor
49251efc74 In wp-includes/theme.php, break is unreachable after return.
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28337


git-svn-id: http://core.svn.wordpress.org/trunk@28165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 03:50:14 +00:00
Scott Taylor
cca9ff329b In print_admin_styles(), $zip is never used after being set. $compress_css does not need to be imported.
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28336


git-svn-id: http://core.svn.wordpress.org/trunk@28164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 03:47:14 +00:00
Scott Taylor
1ef3438961 In wp_default_scripts(), $max_upload_size and its entangled children $max_up and $max_post create quite the ternary operator... that is never used.
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28335


git-svn-id: http://core.svn.wordpress.org/trunk@28163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 03:45:14 +00:00
Scott Taylor
5b6b17fc80 In wp-includes/revision.php - remove dead code:
* In `wp_get_post_autosave()`, `break` is unreachable after `return`
* In `_wp_put_post_revision()`, `$post_id` is set then never used.

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28334


git-svn-id: http://core.svn.wordpress.org/trunk@28162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 03:38:16 +00:00
Scott Taylor
5bc59586da In WP_Query, remove duplicate variable setting:
* In `->parse_search_order()`, a value is always set for `$search_orderby`, no need for empty initialization
* In `->get_posts()`, `$fields` is always set, no need for empty initialization

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28333


git-svn-id: http://core.svn.wordpress.org/trunk@28161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:43:20 +00:00
Scott Taylor
1aed1f1108 In get_pages(), $cache does not need to be reset to an empty array. update_post_cache( $pages ) takes care of priming.
In `set_post_thumbnail()`, (accidental) assignment is unnecessary for `$thumbnail_html` as it is not used. 

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28332


git-svn-id: http://core.svn.wordpress.org/trunk@28160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:39:14 +00:00
Scott Taylor
ef34785160 In wp_get_attachment_link(), $post_title is set and then not used.
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28331


git-svn-id: http://core.svn.wordpress.org/trunk@28159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:35:16 +00:00
Scott Taylor
9a1dcd1a7c In Walker_Nav_Menu::start_el(), $class_names is set twice before it is used.
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28330


git-svn-id: http://core.svn.wordpress.org/trunk@28158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:33:14 +00:00
Scott Taylor
c96d7fff01 In get_network_by_path(), $exact_domains is unused.
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28329


git-svn-id: http://core.svn.wordpress.org/trunk@28157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:32:16 +00:00
Scott Taylor
b2b25f7326 In update_metadata_by_mid(), $original_value is unused.
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28328


git-svn-id: http://core.svn.wordpress.org/trunk@28156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:29:26 +00:00
Scott Taylor
0910376bfe In edit_post_link(), $post_type_obj is unused.
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28327


git-svn-id: http://core.svn.wordpress.org/trunk@28155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:27:15 +00:00
Scott Taylor
3d0eed82f8 In paginate_links(), break is unreachable after return.
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28326


git-svn-id: http://core.svn.wordpress.org/trunk@28154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:25:15 +00:00
Scott Taylor
de4eaacd89 In wp-includes/functions.php, remove dead code:
* In `current_time()`, `break` is unreachable after `return`.
* In `add_query_arg()`, `$ret` is set twice before being used.
* In `wp_mkdir_p()`, `$dir_perms` is set twice before being used.

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28325


git-svn-id: http://core.svn.wordpress.org/trunk@28153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:23:14 +00:00
Scott Taylor
7eeafa3537 In wp_set_comment_status(), the default case returns, so no default value for $status is needed.
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28324


git-svn-id: http://core.svn.wordpress.org/trunk@28152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:17:15 +00:00
Scott Taylor
de262f553c In wp-includes/comment-template.php, remove dead code:
* In `get_comment_reply_link()`, `$link` is set twice before it is used.
* In `Walker_Comment::start_lvl()`, `case 'ul':` is unreachable unless placed before `default:`. 
* In `Walker_Comment::end_lvl()`, `case 'ul':` is unreachable unless placed before `default:`.
* In `comment_form()`, `$id` is conditionally set and never used. 

See #27882.


Built from https://develop.svn.wordpress.org/trunk@28323


git-svn-id: http://core.svn.wordpress.org/trunk@28151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:15:17 +00:00
Scott Taylor
6b80da9d96 In Walker::walk() and Walker::paged_walk(), $id_field is set and never used.
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28322


git-svn-id: http://core.svn.wordpress.org/trunk@28150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:09:19 +00:00