Drew Jaynes
8544d69d35
Docs: Normalize spacing in the wp_get_attachment_link
hook doc following [35065].
...
See #34257 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35066
git-svn-id: http://core.svn.wordpress.org/trunk@35031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 16:44:24 +00:00
Drew Jaynes
ad628c7165
Docs: Adjust documentation for the $size
parameter in the wp_get_attachment_link
hook doc to clarify the required order of width and height values when an array is passed.
...
Also adds the `array` type to the parameter documentation (already supported).
See #34257 .
Built from https://develop.svn.wordpress.org/trunk@35065
git-svn-id: http://core.svn.wordpress.org/trunk@35030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 16:42:23 +00:00
Drew Jaynes
61115eac58
Docs: Improve documentation for get_site_icon_url()
, introduced in [32994].
...
Adds a missing `@since` version, fixes optional parameter syntax, adds default values, and fixes the return description.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35064
git-svn-id: http://core.svn.wordpress.org/trunk@35029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 16:38:24 +00:00
Drew Jaynes
b1b3fc5deb
Docs: Re-clarify the $sizes[ $size ]
section of the hash notations for WP_Image_Editor_GD::multi_resize()
and WP_Image_Editor_Imagick::multi_resize()
as not fully-optional.
...
The `$width` value is optional if `$height` is specified, and vice versa. The `$crop` value is always optional and defaults to false.
Props dh-shredder.
See #32246 . See [35061] and [35062].
Built from https://develop.svn.wordpress.org/trunk@35063
git-svn-id: http://core.svn.wordpress.org/trunk@35028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 16:34:23 +00:00
Drew Jaynes
041e3dd285
Docs: Fix hash notation syntax for the $sizes[ $size ]
section in the DocBlock for WP_Image_Editor_Imagick::multi_resize()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35062
git-svn-id: http://core.svn.wordpress.org/trunk@35027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 16:27:24 +00:00
Drew Jaynes
243f66836f
Docs: Fix hash notation syntax for the $sizes[ $size ]
section in the DocBlock for WP_Image_Editor_GD::multi_resize()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35061
git-svn-id: http://core.svn.wordpress.org/trunk@35026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 16:26:24 +00:00
Drew Jaynes
ee544e44d5
Docs: Adjust documentation for the $size
parameter in the admin_post_thumbnail_size
hook doc to clarify the required order of width and height values when an array is passed.
...
See #34257 . See #28512 .
Built from https://develop.svn.wordpress.org/trunk@35060
git-svn-id: http://core.svn.wordpress.org/trunk@35025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 16:22:25 +00:00
Drew Jaynes
9f5d887934
Docs: Normalize spacing in the image_send_to_editor
hook doc following [35058].
...
See #34257 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35059
git-svn-id: http://core.svn.wordpress.org/trunk@35024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 16:19:23 +00:00
Drew Jaynes
c12f0caefd
Docs: Adjust documentation for the $size
parameter in the image_send_to_editor
hook doc to clarify the required order of width and height values when an array is passed.
...
Also adds the `array` type to the parameter documentation (already supported).
See #34257 .
Built from https://develop.svn.wordpress.org/trunk@35058
git-svn-id: http://core.svn.wordpress.org/trunk@35023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 16:17:24 +00:00
Drew Jaynes
4534f13149
Docs: Fix the syntax for marking parameters optional and add defaults in the DocBlock for wp_get_attachment_link()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35057
git-svn-id: http://core.svn.wordpress.org/trunk@35022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 16:15:24 +00:00
Drew Jaynes
4aea111b29
Docs: Fix syntax and properly mark optional parameters as such in the DocBlock for get_image_send_to_editor()
.
...
Also fixes the return description, and adds the `$size` default value, missed in [35055].
See #34257 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35056
git-svn-id: http://core.svn.wordpress.org/trunk@35021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 16:11:24 +00:00
Drew Jaynes
16738bf325
Docs: Adjust documentation for the $size
parameter in get_image_send_to_editor()
to clarify the required order of width and height values when passing an array.
...
Also adds the `array` type to the parameter documentation (already supported).
See #34257 .
Built from https://develop.svn.wordpress.org/trunk@35055
git-svn-id: http://core.svn.wordpress.org/trunk@35020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 16:08:25 +00:00
Drew Jaynes
d4fe129e1a
Docs: Adjust the order of 'width' and 'height' (for consistency) for the $crop
parameter documentation in image_make_intermediate_size()
.
...
Props jaspermdegroot.
See #34257 .
Built from https://develop.svn.wordpress.org/trunk@35054
git-svn-id: http://core.svn.wordpress.org/trunk@35019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 16:06:24 +00:00
Drew Jaynes
8b26e5debc
Docs: Adjust the order of 'width' and 'height' (for consistency) for the $crop
parameter documentation in image_resize_dimensions()
.
...
Also similarly adjusts the `$crop` parameter description in the corresponding `image_resize_dimensions` hook doc.
Props jaspermdegroot.
See #34257 .
Built from https://develop.svn.wordpress.org/trunk@35053
git-svn-id: http://core.svn.wordpress.org/trunk@35018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 16:02:24 +00:00
Drew Jaynes
e0529ebdb5
Docs: Adjust the order of 'width' and 'height' (for consistency) for the $crop
parameter documentation in set_post_thumbnail_size()
.
...
Props jaspermdegroot.
See #34257 .
Built from https://develop.svn.wordpress.org/trunk@35052
git-svn-id: http://core.svn.wordpress.org/trunk@35017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 16:00:26 +00:00
Drew Jaynes
771248a1f3
Docs: Adjust the order of 'width' and 'height' (for consistency) for the $crop
parameter documentation in add_image_size()
.
...
Props jaspermdegroot.
See #34257 .
Built from https://develop.svn.wordpress.org/trunk@35051
git-svn-id: http://core.svn.wordpress.org/trunk@35016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 15:59:25 +00:00
Drew Jaynes
69a3c2d8d7
Docs: Adjust documentation for the $size
parameter in wp_get_attachment_link()
to clarify the required order of width and height values when passing an array.
...
Also adds the `array` type to the parameter documentation (already supported).
Props jaspermdegroot.
See #34257 .
Built from https://develop.svn.wordpress.org/trunk@35050
git-svn-id: http://core.svn.wordpress.org/trunk@35015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 15:56:24 +00:00
Drew Jaynes
d0a392a34c
Docs: Adjust documentation for the $size
parameter in adjacent_image_link()
to clarify the required order of width and height values when passing an array.
...
See #34257 .
Built from https://develop.svn.wordpress.org/trunk@35049
git-svn-id: http://core.svn.wordpress.org/trunk@35014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 15:53:25 +00:00
Drew Jaynes
81f67bae13
Docs: Adjust documentation for the $size
parameter in next_image_link()
to clarify the required order of width and height values when passing an array.
...
See #34257 .
Built from https://develop.svn.wordpress.org/trunk@35048
git-svn-id: http://core.svn.wordpress.org/trunk@35013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 15:50:24 +00:00
Drew Jaynes
141b096f6d
Docs: Adjust documentation for the $size
parameter in previous_image_link()
to clarify the required order of width and height values when passing an array.
...
See #34257 .
Built from https://develop.svn.wordpress.org/trunk@35047
git-svn-id: http://core.svn.wordpress.org/trunk@35012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 15:48:25 +00:00
Drew Jaynes
1571907571
Docs: Normalize spacing in the $attr
hash notation for gallery_shortcode()
following [35045].
...
See #34257 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35046
git-svn-id: http://core.svn.wordpress.org/trunk@35011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 15:46:24 +00:00
Drew Jaynes
e4f9e334ea
Docs: Adjust documentation for the $size
argument in gallery_shortcode
to clarify the required order of width and height values when passing an array.
...
Also adds the `array` type to the argument documentation.
Props jaspermdegroot.
See #34257 .
Built from https://develop.svn.wordpress.org/trunk@35045
git-svn-id: http://core.svn.wordpress.org/trunk@35010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 15:43:25 +00:00
Drew Jaynes
9d5d27c26d
Docs: Adjust documentation for the $size
parameter in wp_get_attachment_image_url()
to clarify the required order of width and height values when passing an array.
...
See #34257 .
Built from https://develop.svn.wordpress.org/trunk@35044
git-svn-id: http://core.svn.wordpress.org/trunk@35009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 15:39:25 +00:00
Drew Jaynes
987fe676a9
Docs: Adjust documentation for the $size
parameter in the wp_get_attachment_image_attributes
hook doc to clarify the required order of width and height values when an array is passed.
...
See #34257 .
Built from https://develop.svn.wordpress.org/trunk@35043
git-svn-id: http://core.svn.wordpress.org/trunk@35008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 15:38:24 +00:00
Drew Jaynes
5631df0151
Docs: Adjust documentation for the $size
parameter in wp_get_attachment_image()
to clarify the required order of width and height values when passing an array.
...
See #34257 .
Built from https://develop.svn.wordpress.org/trunk@35042
git-svn-id: http://core.svn.wordpress.org/trunk@35007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 15:36:24 +00:00
Drew Jaynes
c02b132fcc
Docs: Adjust documentation for the $size
parameter in the wp_get_attachment_image_src
hook doc to clarify the required order of width and height values when an array is passed.
...
See #34257 .
Built from https://develop.svn.wordpress.org/trunk@35041
git-svn-id: http://core.svn.wordpress.org/trunk@35006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 15:34:24 +00:00
Drew Jaynes
8f3f5dba35
Docs: Adjust documentation for the $size
parameter in wp_get_attachment_image_src()
to clarify the required order of width and height values when passing an array.
...
See #34257 .
Built from https://develop.svn.wordpress.org/trunk@35040
git-svn-id: http://core.svn.wordpress.org/trunk@35005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 15:31:24 +00:00
Drew Jaynes
50fd2488f4
Docs: Adjust documentation for the $size
parameter in image_get_intermediate_size()
to clarify the required order of width and height values when passing an array.
...
See #34257 .
Built from https://develop.svn.wordpress.org/trunk@35039
git-svn-id: http://core.svn.wordpress.org/trunk@35004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 15:29:24 +00:00
Drew Jaynes
5a0eaa17de
Docs: Adjust documentation for the $size
parameter in the get_image_tag
hook doc to clarify the required order of width and height values when an array is passed.
...
See #34257 .
Built from https://develop.svn.wordpress.org/trunk@35038
git-svn-id: http://core.svn.wordpress.org/trunk@35003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 15:27:25 +00:00
Drew Jaynes
698b5f6880
Docs: Adjust documentation for the $size
parameter in the get_image_tag_class
hook doc to clarify the required order of width and height values when an array is passed.
...
See #34257 .
Built from https://develop.svn.wordpress.org/trunk@35037
git-svn-id: http://core.svn.wordpress.org/trunk@35002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 15:26:25 +00:00
Drew Jaynes
71932de1f5
Docs: Adjust documentation for the $size
parameter in get_image_tag()
to clarify the required order of width and height values when passing an array.
...
See #34257 .
Built from https://develop.svn.wordpress.org/trunk@35036
git-svn-id: http://core.svn.wordpress.org/trunk@35001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 15:21:25 +00:00
Drew Jaynes
3f8aaf753a
Docs: Adjust documentation for the $size
parameter in the image_downside
hook doc to clarify the required order of width and height values when an array is passed.
...
See #34257 .
Built from https://develop.svn.wordpress.org/trunk@35035
git-svn-id: http://core.svn.wordpress.org/trunk@35000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 15:20:23 +00:00
Drew Jaynes
45174a8996
Docs: Adjust documentation for the $size
parameter in image_downsize()
to clarify the required order of width and height values when passing an array.
...
See #34257 .
Built from https://develop.svn.wordpress.org/trunk@35034
git-svn-id: http://core.svn.wordpress.org/trunk@34999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 15:18:24 +00:00
Drew Jaynes
7c25ad0613
Docs: Adjust documentation for the $size
parameter in image_constrain_size_for_editor()
to clarify the required order of width and height values when passing an array.
...
See #34257 .
Built from https://develop.svn.wordpress.org/trunk@35033
git-svn-id: http://core.svn.wordpress.org/trunk@34998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 15:16:24 +00:00
Boone Gorges
499d1b74ba
Don't cache WP_Term
objects in wp_get_object_cache()
.
...
The data stored in the cache should be raw database query results, not
`WP_Term` objects (which may be modified by plugins, and may contain additional
properties that shouldn't be cached).
If term relationships caches were handled in `wp_get_object_terms()` - where
a database query takes place - it would be straightforward to cache raw data.
See #34239 . Since, in fact, `get_the_terms()` caches the value it gets from
`wp_get_object_terms()`, we need a technique that allows us to get raw data
from a `WP_Term` object. Mirroring `WP_User`, we introduce a `data` property
on term objects, which `get_the_terms()` uses to fetch cacheable term info.
Fixes #34262 .
Built from https://develop.svn.wordpress.org/trunk@35032
git-svn-id: http://core.svn.wordpress.org/trunk@34997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 15:13:48 +00:00
Boone Gorges
6912d6fe64
Be stricter about sanitizing values coming out of WP_Term
.
...
Data passed into `get_instance()` should be run through `sanitize_term()`
before being used.
See #34262 .
Built from https://develop.svn.wordpress.org/trunk@35031
git-svn-id: http://core.svn.wordpress.org/trunk@34996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 15:13:24 +00:00
Boone Gorges
2e4877d80c
Fix incorrect setup in 'tag' query var test.
...
The test, introduced in [33724], was intended to demonstrate the behavior of
`example.com?tag=foo` routing. But an error in the test setup meant that a
URL-encoded tag object was being set as the value of 'tag'. Due to a quirk in
the way that `parse_request()` parses query vars, an object value for 'tag'
would inadvertently produce correct results in certain cases. But it's not a
usage we actively support, and it's not what was meant to be tested.
See #33532 , #34262 .
Built from https://develop.svn.wordpress.org/trunk@35030
git-svn-id: http://core.svn.wordpress.org/trunk@34995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 15:04:26 +00:00
Boone Gorges
58aee33cd9
After [35028], normalize get_term_field()
doc formatting.
...
Fixes #34245 .
Built from https://develop.svn.wordpress.org/trunk@35029
git-svn-id: http://core.svn.wordpress.org/trunk@34994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 04:14:48 +00:00
Boone Gorges
1a87ade436
Don't require a $taxonomy
to be specified in get_term_field()
.
...
After [34997], the `$taxonomy` parameter of `get_term()` is optional. This
changeset brings `get_term_field()` in line with the new usage.
Adds unit tests for `get_term_field()`.
Props DrewAPicture.
See #34245 .
Built from https://develop.svn.wordpress.org/trunk@35028
git-svn-id: http://core.svn.wordpress.org/trunk@34993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 04:14:24 +00:00
Drew Jaynes
f60bd8d827
Docs: Wrap a couple of hook name references in inline @see
tags in the hook docs for custom_menu_order
and menu_order
.
...
Inline `@see` tags in the context of hooks are parsed as links to hook pages in the Code Reference.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35027
git-svn-id: http://core.svn.wordpress.org/trunk@34992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 03:39:26 +00:00
Jeremy Felt
270d3f422c
MS: Reflect falsy values for upload_space_check_disabled
in UI.
...
If the network option for `upload_space_check_disabled` is missing or an empty string, we should reflect how it will be treated elsewhere in the UI.
Props stephenharris.
Fixes #33986 .
Built from https://develop.svn.wordpress.org/trunk@35026
git-svn-id: http://core.svn.wordpress.org/trunk@34991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 00:01:24 +00:00
Jeremy Felt
364e63b83b
MS: Reject truthy, non-numeric network ids in _network_option()
.
...
A valid `$network_id` or `null`/`false` is expected as the first parameter for `_network_option()`. If something other than that is passed, we immediately return `false` rather than attempting to guess what network was intended.
See #28290 .
Built from https://develop.svn.wordpress.org/trunk@35025
git-svn-id: http://core.svn.wordpress.org/trunk@34990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-11 23:30:24 +00:00
Jeremy Felt
092478579a
MS: Adjust _network_option()
parameter order, $network_id
is first.
...
This better aligns with expectations and matches the structure used by `_blog_option()`. The `_site_option()` functions remain as an appropriate method for working with the current network.
See #28290 .
Built from https://develop.svn.wordpress.org/trunk@35024
git-svn-id: http://core.svn.wordpress.org/trunk@34989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-11 22:44:27 +00:00
Drew Jaynes
2c6e416159
Media: Remove logic for unnecessarily overloading the $content_width
global when passing default dimensions used to display the post thumbnail image in the 'Featured Image' meta box.
...
Updates documentation for the `$size` parameter in `admin_post_thumbnail_size` filter doc.
See #28512 .
Built from https://develop.svn.wordpress.org/trunk@35023
git-svn-id: http://core.svn.wordpress.org/trunk@34988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-11 17:10:25 +00:00
Drew Jaynes
889a89c2a2
Media: Introduce the admin_post_thumbnail_size
filter, which enables manipulation of the image size used to display the post thumbnail in the 'Featured Image' meta box.
...
This filter has no effect on the image size used to display post thumbnails on the front-end.
Props dboulet, DrewAPicture.
Fixes #28512 .
Built from https://develop.svn.wordpress.org/trunk@35022
git-svn-id: http://core.svn.wordpress.org/trunk@34987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-11 16:54:26 +00:00
Drew Jaynes
fb2a4bf9fb
Docs: Fix some syntactical issues in property DocBlocks for WP_List_Table
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35021
git-svn-id: http://core.svn.wordpress.org/trunk@34986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-11 03:34:26 +00:00
Andrew Ozz
85285d1701
Fix inconsistency in src/wp-includes/js/media/views/uploader/editor.js.
...
See #34251 .
Built from https://develop.svn.wordpress.org/trunk@35020
git-svn-id: http://core.svn.wordpress.org/trunk@34985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-11 00:09:24 +00:00
Andrew Ozz
8dd2a31c38
Plupload: update to 2.1.8. Changelog: https://github.com/moxiecode/plupload/releases .
...
Hide the editor uploader overlay on all drop events in the window, not only when dropping on the editor uploader element.
Fixes #34251 , #22403 .
Built from https://develop.svn.wordpress.org/trunk@35019
git-svn-id: http://core.svn.wordpress.org/trunk@34984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 23:50:25 +00:00
Sergey Biryukov
11def634f6
Customizer: WP_Customize_Cropped_Image_Control
should extend WP_Customize_Image_Control
, since Site Icon can only an image.
...
Props paulwilde.
Fixes #34250 .
Built from https://develop.svn.wordpress.org/trunk@35018
git-svn-id: http://core.svn.wordpress.org/trunk@34983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 23:25:24 +00:00
Jeremy Felt
3b42b801f8
MS: Handle the possibility of 0 when checking a user's upload quota.
...
Upload space of 0 is now more possible via r35016 and should be respected rather than modified to a default of 10MB.
Fixes #34037 .
Built from https://develop.svn.wordpress.org/trunk@35017
git-svn-id: http://core.svn.wordpress.org/trunk@34982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 23:17:25 +00:00
Jeremy Felt
49ce208880
MS: Allow for a blog_upload_space
setting of 0 to restrict uploads.
...
Previously, an value matching `empty()` would have been bypassed in favor of the default setting for 100MB.
Related #19538 , r19639, r19652, where we saw the bug, fixed the bug, and then unfixed the bug so that it was not a surprise in a point release.
See #34037 .
Built from https://develop.svn.wordpress.org/trunk@35016
git-svn-id: http://core.svn.wordpress.org/trunk@34981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 23:15:26 +00:00
Andrea Fercia
6b449abadc
Accessibility: bump headings one level up on the Appearance > Widgets screen for a better headings hierarchy.
...
Props mrahmadawais, afercia.
Fixes #33659 .
Built from https://develop.svn.wordpress.org/trunk@35015
git-svn-id: http://core.svn.wordpress.org/trunk@34980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 16:34:25 +00:00
Scott Taylor
5fdf928bcf
Admin JS: after [34977], avoid variable names conflicts with e
.
...
Props afercia.
Fixes #18590 .
Built from https://develop.svn.wordpress.org/trunk@35014
git-svn-id: http://core.svn.wordpress.org/trunk@34979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 15:50:24 +00:00
Scott Taylor
00ade45fd1
Docs: some @global object
vernaculars should be converted to the actual object type.
...
See #33491 .
Built from https://develop.svn.wordpress.org/trunk@35013
git-svn-id: http://core.svn.wordpress.org/trunk@34978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 15:45:25 +00:00
Scott Taylor
57c2ef2655
Users List Table: after [35011], just use wp_roles()
, no global import. #winning
...
See #22959 .
Built from https://develop.svn.wordpress.org/trunk@35012
git-svn-id: http://core.svn.wordpress.org/trunk@34977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 15:36:26 +00:00
Scott Taylor
ab2905da84
Users List Table: after [34963], remove unused code/add doc for global import.
...
See #22959 .
Built from https://develop.svn.wordpress.org/trunk@35011
git-svn-id: http://core.svn.wordpress.org/trunk@34976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 15:26:24 +00:00
Scott Taylor
d021cb8bc0
WP Screen: after [34991], avoid unnecessary nesting levels and remove unused global import.
...
See #33646 .
Built from https://develop.svn.wordpress.org/trunk@35010
git-svn-id: http://core.svn.wordpress.org/trunk@34975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 15:20:24 +00:00
Andrea Fercia
6ec8174ca1
Accessibility: bump headings one level up on the Add Plugins screen for a better headings hierarchy.
...
Fixes #33818 .
Built from https://develop.svn.wordpress.org/trunk@35009
git-svn-id: http://core.svn.wordpress.org/trunk@34974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 15:17:26 +00:00
Sergey Biryukov
a5c1f545c4
Users: Remove redundant error message when password is only entered once.
...
"Please enter the same password in both password fields" should cover all the scenarios.
Props MikeHansenMe, jmayhak, desrosj, gounder.
Fixes #33101 .
Built from https://develop.svn.wordpress.org/trunk@35008
git-svn-id: http://core.svn.wordpress.org/trunk@34973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 13:22:26 +00:00
Weston Ruter
1fe64b1c65
Customizer: Fix scalability performance problem for previewing multidimensional settings.
...
As the number of multidimensional settings (serialized options and theme mods) increase for a given ID base (e.g. a widget of a certain type), the number of calls to the `multidimensional` methods on `WP_Customize_Setting` increase exponentially, and the time for the preview to refresh grows in time exponentially as well.
To improve performance, this change reduces the number of filters needed to preview the settings off of a multidimensional root from N to 1. This improves performance from `O(n^2)` to `O(n)`, but the linear increase is so low that the performance is essentially `O(1)` in comparison. This is achieved by introducing the concept of an "aggregated multidimensional" setting, where the root value of the multidimensional serialized setting value gets cached in a static array variable shared across all settings.
Also improves performance by only adding preview filters if there is actually a need to do so: there is no need to add a filter if there is an initial value and if there is no posted value for a given setting (if it is not dirty).
Fixes #32103 .
Built from https://develop.svn.wordpress.org/trunk@35007
git-svn-id: http://core.svn.wordpress.org/trunk@34972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 09:06:25 +00:00
Sergey Biryukov
ac9a85a45e
Use wp_star_rating()
on Add Themes screen:
...
* It works correctly for RTL
* Requires less CSS styling
* Is visually consistent with plugin ratings
* Is more accessible
Fixes #34080 .
Built from https://develop.svn.wordpress.org/trunk@35006
git-svn-id: http://core.svn.wordpress.org/trunk@34971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 06:51:24 +00:00
Sergey Biryukov
24219160f1
Add echo
parameter for wp_star_rating()
.
...
See #34080 .
Built from https://develop.svn.wordpress.org/trunk@35005
git-svn-id: http://core.svn.wordpress.org/trunk@34970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 06:43:24 +00:00
Drew Jaynes
c6bffb6264
Docs: Fix some minor formatting in the $query_args
parameter description for the `` filter doc.
...
See #8243 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35004
git-svn-id: http://core.svn.wordpress.org/trunk@34969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 06:39:24 +00:00
Drew Jaynes
504ff07656
Dashboard: Introduce the dashboard_recent_drafts_query_args
filter, making it possible to manipulate the post query arguments used in the 'Recent Drafts' dashboard widget.
...
Props iamfriendly.
Fixes #8243 .
Built from https://develop.svn.wordpress.org/trunk@35003
git-svn-id: http://core.svn.wordpress.org/trunk@34968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 06:33:25 +00:00
Drew Jaynes
69c828b77b
Template: Pass the $post
parameter to the the_permalink
filter.
...
Props chriscct7.
Fixes #34234 . See #23882 .
Built from https://develop.svn.wordpress.org/trunk@35002
git-svn-id: http://core.svn.wordpress.org/trunk@34967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 05:46:24 +00:00
Drew Jaynes
c2b5aeebb0
Template: Rename the $id
parameters in the_permalink()
, get_the_permalink()
, and get_permalink()
to $post
.
...
In all three cases, the functions can accept a post ID, a `WP_Post` object, or a falsey value, which defaults to the value of the global `$post`. Switching to `$post` in this context allows the parameters to better self-document and removes ambiguity in the code they are subsequently used in.
Props chriscct7 for the initial patch.
See #34234 .
Built from https://develop.svn.wordpress.org/trunk@35001
git-svn-id: http://core.svn.wordpress.org/trunk@34966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 05:41:29 +00:00
Sergey Biryukov
5399881b18
Merge two database update strings for consistency.
...
Props pavelevap.
Fixes #33514 .
Built from https://develop.svn.wordpress.org/trunk@35000
git-svn-id: http://core.svn.wordpress.org/trunk@34965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 05:14:23 +00:00
Boone Gorges
636464857e
Return WP_Post
objects from wp_get_object_terms()
.
...
A side effect of this change is that terms stored in the cache no longer have
an `object_id` associated with them. Previously, `object_id` had always been
cached when the term cache was populated via `wp_get_object_terms()`, a
strategy that was mostly harmless but still incorrect.
See #14162 .
Built from https://develop.svn.wordpress.org/trunk@34999
git-svn-id: http://core.svn.wordpress.org/trunk@34964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 03:39:26 +00:00
Boone Gorges
71429da5b4
Return WP_Term
objects from get_terms()
.
...
Props boonebgorges, flixos90, DrewAPicture.
See #14162 .
Built from https://develop.svn.wordpress.org/trunk@34998
git-svn-id: http://core.svn.wordpress.org/trunk@34963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 02:13:28 +00:00
Boone Gorges
623e467712
Introduce WP_Term
.
...
`get_term()` now returns a `WP_Term` object, instead of a `stdClass` object.
Cache support and sanitization filters for individual terms are now more
centralized. For example, `get_term_by()` is able to cast results of its query
to a `WP_Term` object by passing it through `get_term()`.
The `$taxonomy` parameter for `get_term()` is now optional, as terms ought to
be unique to a taxonomy (ie, shared terms no longer exist). In cases where
`get_term()` detects that the term matching the specified term_id is from the
wrong taxonomy, it checks to see if you've requested a shared term, and if so,
it splits the term. This is used only for fallback purposes.
The elimination of shared terms allows the caching strategy for terms to be
simplified. Individual terms are now cached in a single 'terms' bucket.
Props flixos90, boonebgorges, scribu, dipesh.kakadiya.
See #14162 .
Built from https://develop.svn.wordpress.org/trunk@34997
git-svn-id: http://core.svn.wordpress.org/trunk@34962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 01:59:29 +00:00
Jeremy Felt
f8a05879e8
MS: Show an error if a new site slug conflicts with an existing username.
...
Props utkarshpatel, dipesh.kakadiya.
Fixes #33804 .
Built from https://develop.svn.wordpress.org/trunk@34996
git-svn-id: http://core.svn.wordpress.org/trunk@34961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 01:42:26 +00:00
Drew Jaynes
1b1e18027d
Template: Make it possible to both ''add'' and ''remove'' items from the page templates list using the theme_page_templates
filter.
...
The `theme_page_templates` hook was originally added in [27297] as `page_templates`, and later renamed in [27470]. Previously, it was only possible to remove or rename page templates via this hook.
Fixes #13265 . Fixes #25879 .
Built from https://develop.svn.wordpress.org/trunk@34995
git-svn-id: http://core.svn.wordpress.org/trunk@34960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 21:51:25 +00:00
Sergey Biryukov
662ad721ec
Remove stray closing tag in wp-admin/themes.php
.
...
Props tfrommen.
Fixes #34237 .
Built from https://develop.svn.wordpress.org/trunk@34994
git-svn-id: http://core.svn.wordpress.org/trunk@34959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 21:17:25 +00:00
Drew Jaynes
e89737ccfb
Docs: Fix wrapping and syntax for a multi-comment in Walker_Comment::display_element()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34993
git-svn-id: http://core.svn.wordpress.org/trunk@34958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 21:03:25 +00:00
Drew Jaynes
e38a6edc61
Docs: Indent an example comment tree in the DocBlock for Walker_Comment::display_element()
so it can be properly parsed in Markdown for the Code Reference.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34992
git-svn-id: http://core.svn.wordpress.org/trunk@34957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 21:00:27 +00:00
Andrea Fercia
42b33e1645
Administration: Convert H5 usage in Screen Options to use fieldsets and legends.
...
These H5 (heading level 5) don't allow for a good headings hierarchy and shouldn't be headings in the first place. Each group of options has now its own fieldset and legend.
In `render_screen_options()`, introduce two new "render" methods: `render_meta_boxes_preferences()` and `render_list_table_columns_preferences()` for consistency with already existing render methods and cleaner code.
Props joedolson, afercia.
Fixes #33646 .
Built from https://develop.svn.wordpress.org/trunk@34991
git-svn-id: http://core.svn.wordpress.org/trunk@34956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 18:05:24 +00:00
Helen Hou-Sandí
681573e80a
Notices: Update one more instance of white-on-white.
...
Because the media modal can be used on the front-end, the CSS needs to be added here rather than using the notice classes.
props paulwilde.
fixes #32244 .
Built from https://develop.svn.wordpress.org/trunk@34990
git-svn-id: http://core.svn.wordpress.org/trunk@34955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 17:47:25 +00:00
Boone Gorges
a19d63b7a5
Ensure that WP_Date_Query
accepts a value of 0
for 'hour'.
...
Props jim912.
Fixes #34228 .
Built from https://develop.svn.wordpress.org/trunk@34989
git-svn-id: http://core.svn.wordpress.org/trunk@34954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 16:33:25 +00:00
Sergey Biryukov
b40e362711
Fix typo in get_avatar()
and get_avatar_data()
docs.
...
Props johnjamesjacoby.
Fixes #34232 .
Built from https://develop.svn.wordpress.org/trunk@34988
git-svn-id: http://core.svn.wordpress.org/trunk@34953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 15:52:24 +00:00
Drew Jaynes
7e26ee2e3c
Install: Match existing tonal style in setup-config.php by converting strings containing 'do not' and 'does not' to instead use contractions.
...
The 'do not' is converted to "don't" because "you" is third-person plural, and 'does not' is converted to "doesn't" because `localhost` is third-person singular. While both are "negative" contractions, we often write this way in WordPress to provide a friendlier tone. That's your English grammar lesson for the day.
Props ankit-k-gupta, iamfriendly.
Fixes #30317 .
Built from https://develop.svn.wordpress.org/trunk@34987
git-svn-id: http://core.svn.wordpress.org/trunk@34952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 15:43:27 +00:00
Sergey Biryukov
072cdf116a
Fix typo in wp_rand()
docs.
...
See #28633 .
Built from https://develop.svn.wordpress.org/trunk@34986
git-svn-id: http://core.svn.wordpress.org/trunk@34951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 05:20:23 +00:00
Sergey Biryukov
0d7c5569f5
In do_robots()
, allow crawling for admin-ajax.php
, since it's often used on front-end.
...
Props dmchale, joostdevalk.
Fixes #33156 .
Built from https://develop.svn.wordpress.org/trunk@34985
git-svn-id: http://core.svn.wordpress.org/trunk@34950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 05:16:23 +00:00
Sergey Biryukov
95da3826b9
Media: Return early from media_sideload_image()
if $file
didn't match the pattern for images.
...
Props MikeHansenMe, serpent7776.
Fixes #32755 .
Built from https://develop.svn.wordpress.org/trunk@34984
git-svn-id: http://core.svn.wordpress.org/trunk@34949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 04:46:24 +00:00
Drew Jaynes
d8811d591b
Tests: Add basic DocBlocks for four helper methods in general/template.php used to assist testing the Site Icon feature.
...
All four helpers were introduced in the feature merge for 4.3.
See #33968 .
Built from https://develop.svn.wordpress.org/trunk@34983
git-svn-id: http://core.svn.wordpress.org/trunk@34948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 04:35:24 +00:00
Sergey Biryukov
3012b862af
Add $id
parameter to the_permalink()
, for consistency with get_permalink()
.
...
Props johnjamesjacoby, chriscct7.
Fixes #23882 .
Built from https://develop.svn.wordpress.org/trunk@34982
git-svn-id: http://core.svn.wordpress.org/trunk@34947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 04:34:24 +00:00
Dion Hulse
4852cbf14b
Use PHP7's random_int()
CSPRNG functionality in wp_rand()
with a fallback to the random_compat
library for PHP 5.x.
...
`random_compat` offers a set of compatible functions for older versions of PHP, filling in the gap by using other PHP extensions when available.
We still include our existing `wp_rand()` functionality as a fallback for when no proper CSPRNG exists on the system.
Take Two, this was previously committed in [34922] but had an issue on PHP 5.2 which sarciszewski has now resolved.
Props sarciszewski
See #28633
Built from https://develop.svn.wordpress.org/trunk@34981
git-svn-id: http://core.svn.wordpress.org/trunk@34946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 04:28:24 +00:00
Sergey Biryukov
dfc4654172
Dashboard: Display year in Activity widget if the post date year is not the same as the current one.
...
Props GaryJ, chriscct7.
Fixes #26502 .
Built from https://develop.svn.wordpress.org/trunk@34980
git-svn-id: http://core.svn.wordpress.org/trunk@34945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 04:26:24 +00:00
Sergey Biryukov
6595b1b080
My Sites: Make "Create a New Site" link consistent with other "Add New" links.
...
Props JeffMatson.
Fixes #34179 .
Built from https://develop.svn.wordpress.org/trunk@34979
git-svn-id: http://core.svn.wordpress.org/trunk@34944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 03:50:24 +00:00
Sergey Biryukov
3c7b7f7133
After [34529], if a compatible termmeta
table is found on database upgrade, convert it to utf8mb4
collation.
...
Props dboulet.
Fixes #34224 .
Built from https://develop.svn.wordpress.org/trunk@34978
git-svn-id: http://core.svn.wordpress.org/trunk@34943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 02:07:25 +00:00
Andrew Ozz
a6cf0b41a6
JS: in event callbacks replace the very outdated return false
with preventDefault()
.
...
Props adamsilverstein.
Fixes #18590 .
Built from https://develop.svn.wordpress.org/trunk@34977
git-svn-id: http://core.svn.wordpress.org/trunk@34942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 01:27:27 +00:00
Helen Hou-Sandí
b23005d7c1
Revisions: Update slider handle styling.
...
This brings them in line with updated buttons as done in [34948] for #31459 . It also gives it secondary action styling as opposed to primary, as restoring is considered the primary action.
props hugobaeta.
fixes #34220 .
Built from https://develop.svn.wordpress.org/trunk@34976
git-svn-id: http://core.svn.wordpress.org/trunk@34941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 00:25:25 +00:00
Drew Jaynes
c67853a6da
Docs: Add a missing @since
version to the hook doc for the the_excerpt_embed
filter, introduced in [34903].
...
See #34227 .
Built from https://develop.svn.wordpress.org/trunk@34975
git-svn-id: http://core.svn.wordpress.org/trunk@34940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-08 23:25:24 +00:00
Drew Jaynes
9cbb68a4af
Embeds: Rename the $return
parameter in wp_filter_oembed_result()
to $result
to provide better context on what is being filtered.
...
See #32522 .
Built from https://develop.svn.wordpress.org/trunk@34974
git-svn-id: http://core.svn.wordpress.org/trunk@34939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-08 23:22:24 +00:00
John Blackbourn
44da78be26
Remove HTML escaping for the plugin name and author fields that are displayed when deleting a plugin.
...
While it might seem counter-intuitive to remove HTML escaping, these fields are already safe (they originate in `_get_plugin_data_markup_translate()` which handles sanitization and escaping), and the AuthorName field actually allows some HTML. This change prevents escaped HTML from appearing here.
Fixes #25422
Built from https://develop.svn.wordpress.org/trunk@34973
git-svn-id: http://core.svn.wordpress.org/trunk@34938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-08 23:13:24 +00:00
Drew Jaynes
2f700ddbf2
Embeds: Combine the oembed_minwidth
and oembed_maxwidth
filters into one, similar to how the existing oembed_defaults
works for width and height.
...
See #32522 . See #34227 .
Built from https://develop.svn.wordpress.org/trunk@34972
git-svn-id: http://core.svn.wordpress.org/trunk@34937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-08 23:09:23 +00:00
Drew Jaynes
60f86d2865
Docs: Add missing @since
versions for the oembed_minwidth
and oembed_maxwidth
filters, introduced in [34903].
...
See #34227 .
Built from https://develop.svn.wordpress.org/trunk@34971
git-svn-id: http://core.svn.wordpress.org/trunk@34936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-08 22:55:25 +00:00
Drew Jaynes
8c35f77cdb
Docs: Adjust third-person singular verbs in DocBlock summaries for oEmbed functions introduced in [34903].
...
See #34227 .
Built from https://develop.svn.wordpress.org/trunk@34970
git-svn-id: http://core.svn.wordpress.org/trunk@34935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-08 22:50:25 +00:00
Drew Jaynes
fa3b23dc0d
Embeds: Fix syntax on instantiating a new WP_oEmbed_Controller
instance and cross-reference in the DocBlock for wp_oembed_parse_query()
.
...
See #34227 .
Built from https://develop.svn.wordpress.org/trunk@34969
git-svn-id: http://core.svn.wordpress.org/trunk@34934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-08 22:40:24 +00:00
Drew Jaynes
f21439cc64
Docs: Adjust the summary for the oembed_discovery_links
hook doc to mention that the filter is for HTML output.
...
See #34227 .
Built from https://develop.svn.wordpress.org/trunk@34968
git-svn-id: http://core.svn.wordpress.org/trunk@34933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-08 22:39:24 +00:00
Drew Jaynes
e4164932dd
Docs: Clarify the file header summary for wp-includes/embed-functions.php, and add missing parameter information for wp_oembed_parse_query()
, introduced in [34903].
...
See #34227 .
Built from https://develop.svn.wordpress.org/trunk@34967
git-svn-id: http://core.svn.wordpress.org/trunk@34932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-08 22:38:25 +00:00