Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-13 22:26:06 +01:00
Code Issues Projects Releases Wiki Activity
49,084 Commits 50 Branches 748 Tags 792 MiB
fc91a29646
Commit Graph

602 Commits

Author SHA1 Message Date
Sergey Biryukov
c8adae8ec7 Normalize 'user_id' and 'user_ID' values in wp_new_comment() before passing the comment data to 'preprocess_comment' filter. 
props dkotter.
fixes #23231.
Built from https://develop.svn.wordpress.org/trunk@28915


git-svn-id: http://core.svn.wordpress.org/trunk@28714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-30 00:41:16 +00:00
John Blackbourn
60ff3a61f9 Conditionally set the the secure flag on the test cookie, post password cookie, settings cookies, and comment author cookies depending on whether the front end and/or admin area are served over https. Fixes #28427 
Built from https://develop.svn.wordpress.org/trunk@28895


git-svn-id: http://core.svn.wordpress.org/trunk@28694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 13:25:16 +00:00
Scott Taylor
e5e8a83cf4 Don't use variable variables in WP_Comment_Query::query(). 
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28738


git-svn-id: http://core.svn.wordpress.org/trunk@28552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-11 17:58:14 +00:00
Scott Taylor
5219bbbbc9 In WP_Comment_Query::get_search_sql(), don't double-like-escape. 
Props miqrogroove.
See #10041.

Built from https://develop.svn.wordpress.org/trunk@28720


git-svn-id: http://core.svn.wordpress.org/trunk@28534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 02:20:16 +00:00
Scott Taylor
05eeb16e30 Replace all uses of like_escape() with $wpdb->esc_like(). 
Props miqrogroove.
See #10041.

Built from https://develop.svn.wordpress.org/trunk@28712


git-svn-id: http://core.svn.wordpress.org/trunk@28528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 00:44:15 +00:00
Sergey Biryukov
02657dcd66 wp_insert_comment() and wp_new_comment() should check if the comment was successfully inserted into the database. 
props pento.
fixes #28254.
Built from https://develop.svn.wordpress.org/trunk@28672


git-svn-id: http://core.svn.wordpress.org/trunk@28490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-05 04:38:14 +00:00
Drew Jaynes
3724252959 Ensure $post_id is documented as optional where applicable. 
See #28388.

Built from https://develop.svn.wordpress.org/trunk@28654


git-svn-id: http://core.svn.wordpress.org/trunk@28472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-03 04:44:16 +00:00
Scott Taylor
40fab485aa Add missing access modifiers to methods in WP_Comment_Query. Add a magic __call() method for BC. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28519


git-svn-id: http://core.svn.wordpress.org/trunk@28345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 06:19:14 +00:00
Scott Taylor
a39aecc9b1 The cache key for comments in WP_Comment_Query::query() needs to do wp_array_slice_assoc( $this->query_vars, array_keys( $defaults ) ) instead of compact( array_keys( $defaults ) ). The latter assumes all of those variables are still floating around. 
See #22400.


Built from https://develop.svn.wordpress.org/trunk@28460


git-svn-id: http://core.svn.wordpress.org/trunk@28287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 21:09:14 +00:00
Scott Taylor
0aafc8f874 (ACTUALLY) Eliminate use of extract() in WP_Comment_Query::query(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28459


git-svn-id: http://core.svn.wordpress.org/trunk@28286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 20:52:14 +00:00
Scott Taylor
4f57a231c5 Eliminate use of extract() in WP_Comment_Query::query(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28458


git-svn-id: http://core.svn.wordpress.org/trunk@28285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 19:33:14 +00:00
Scott Taylor
14ba67c38d Eliminate use of extract() in wp_insert_comment(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28457


git-svn-id: http://core.svn.wordpress.org/trunk@28284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-16 18:52:16 +00:00
Scott Taylor
2a3548fe70 Eliminate use of extract() in wp_allow_comment(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28437


git-svn-id: http://core.svn.wordpress.org/trunk@28264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 18:10:15 +00:00
Scott Taylor
a15d498d1a Eliminate the use of extract() in wp_update_comment(). All unit tests pass. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28427


git-svn-id: http://core.svn.wordpress.org/trunk@28254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 06:37:15 +00:00
Scott Taylor
7eeafa3537 In wp_set_comment_status(), the default case returns, so no default value for $status is needed. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28324


git-svn-id: http://core.svn.wordpress.org/trunk@28152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 21:17:15 +00:00
Drew Jaynes
8161668689 Ensure the wp_set_comment_status action hook is only documented once. 
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28214


git-svn-id: http://core.svn.wordpress.org/trunk@28044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-25 06:55:14 +00:00
Andrew Nacin
d24a109288 Revert [27115] and let cache backends handle the stripping of spaces in cache keys as necessary. 
microtime() returns greater precision than microtime(true).

see #27000, #23448, #26903, #14485.

Built from https://develop.svn.wordpress.org/trunk@27300


git-svn-id: http://core.svn.wordpress.org/trunk@27153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-26 22:05:13 +00:00
Drew Jaynes
cb8951b0b3 Remove all @package and @subpackage PHPDoc tags not at the file- or class-levels in core. 
See #27200.

Built from https://develop.svn.wordpress.org/trunk@27262


git-svn-id: http://core.svn.wordpress.org/trunk@27119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-25 17:14:14 +00:00
Andrew Nacin
7387504854 Allow user_id to be an array of IDs in WP_Comment_Query. 
props mordauk.
fixes #27064.

Built from https://develop.svn.wordpress.org/trunk@27258


git-svn-id: http://core.svn.wordpress.org/trunk@27115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-25 16:35:13 +00:00
Sergey Biryukov
ab8847316c Correct return values for update_metadata() and related functions. 
fixes #21864.
Built from https://develop.svn.wordpress.org/trunk@27191


git-svn-id: http://core.svn.wordpress.org/trunk@27050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-18 21:36:14 +00:00
Andrew Nacin
084a7b50cd Use a float for last_changed microtime cache values. 
microtime() by default returns a string with a space, which isn't allowed for keys in some cache backends.

props _jameslee, drozdz.
fixes #27000. see #23448.

Built from https://develop.svn.wordpress.org/trunk@27115


git-svn-id: http://core.svn.wordpress.org/trunk@26982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-07 08:14:12 +00:00
Scott Taylor
a6b3bced06 get_comment(), wp_get_post_revision(), and get_term() all used to return by reference. Because of this, $null was set to null so the return value would be a variable where applicable. This has not been necessary since [21792], so the $nulls have been removed. 
Props toszcze.
Fixes #24768.


Built from https://develop.svn.wordpress.org/trunk@27057


git-svn-id: http://core.svn.wordpress.org/trunk@26930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-01-29 06:46:12 +00:00
Scott Taylor
ad211ca06a Add Unit Tests for get_comment_pages_count(). Fix a notice caused when $wp_query->comments is not set in that function. 
Props mdbitz, markjaquith.
Fixes #20633.


Built from https://develop.svn.wordpress.org/trunk@27055


git-svn-id: http://core.svn.wordpress.org/trunk@26928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-01-29 05:17:12 +00:00
Drew Jaynes
1f5f0fcd33 Remove some @uses references to apply_filters and do_action rendered redundant by hook documentation. 
Built from https://develop.svn.wordpress.org/trunk@26867


git-svn-id: http://core.svn.wordpress.org/trunk@26753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-24 16:43:14 +00:00
Sergey Biryukov
16373e224d Correct @since values. see #25522. 
Built from https://develop.svn.wordpress.org/trunk@26492


git-svn-id: http://core.svn.wordpress.org/trunk@26386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-01 01:25:10 +00:00
Drew Jaynes
e6d92061a1 Inline documentation for hooks in wp-includes/comment.php. 
comment.php, a.k.a. "lots 'o hooks".

Props swissspidy for the initial patch. Props danieldudzic, kpdesign, and DrewAPicture.
Fixes #25522.

Built from https://develop.svn.wordpress.org/trunk@26491


git-svn-id: http://core.svn.wordpress.org/trunk@26385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-01 01:12:11 +00:00
Drew Jaynes
223a2c7138 Inline documentation for the following filter hooks in wp-includes/pluggable.php: 
* `comment_notification_recipients`
* `comment_notification_notify_author`

Also removes some generic `@uses` tags from various related doc blocks.

Props markjaquith.
Fixes #25699.

Built from https://develop.svn.wordpress.org/trunk@26388


git-svn-id: http://core.svn.wordpress.org/trunk@26288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-26 04:10:09 +00:00
Mark Jaquith
c2cdbf9648 Fix comment_notification_recipients filter behavior so that it is still respected even on comments left by the post author 
The code was bailing on this-is-a-comment-on-your-own-post detection, ignoring additional recipients. Now:

* Logic check is done within `wp_notify_postauthor()`
* Logic check is overridable via `comment_notification_notify_author` filter (default still false)
* The code doesn't bail on comment-on-own-post detection, but just removes the author from the array
* The code instead now bails if the recipients list is empty, so `comment_notification_recipients` works properly

props ethitter.
fixes #25699

Built from https://develop.svn.wordpress.org/trunk@26367


git-svn-id: http://core.svn.wordpress.org/trunk@26268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-25 01:47:10 +00:00
Peter Westwood
bca9252522 Deprecate the second argument for wp_notify_postauthor because it is unecessary. Fixes #17862 props scribu and wonderboymusic. 
Built from https://develop.svn.wordpress.org/trunk@26358


git-svn-id: http://core.svn.wordpress.org/trunk@26259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-24 16:26:10 +00:00
Sergey Biryukov
8d659b278c Fix docblock formatting. fixes #25893. 
Built from https://develop.svn.wordpress.org/trunk@26081


git-svn-id: http://core.svn.wordpress.org/trunk@26001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-11 13:32:10 +00:00
Andrew Nacin
5361a8abca Spell out duplicate hook locations. 
props DrewAPicture.
fixes #25658.

Built from https://develop.svn.wordpress.org/trunk@25868


git-svn-id: http://core.svn.wordpress.org/trunk@25868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-24 22:59:20 +00:00
Andrew Nacin
8ae8e01b67 Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone. 
see #27704.

Built from https://develop.svn.wordpress.org/trunk@25825


git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-24 22:53:14 +00:00
Andrew Nacin
74488bdcb0 Spell out duplicate hook locations. 
props DrewAPicture.
fixes #25658.

Built from https://develop.svn.wordpress.org/trunk@25868


git-svn-id: http://core.svn.wordpress.org/trunk@25780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-22 17:22:11 +00:00
Scott Taylor
daa4b531e8 Fix several esoteric errors related to AJAX unit tests for comments: 
* `wp_ajax_get_comments()` relies on the `$post_id` global - even though `$_POST['p']` is passed to every action in the test methods. If `$post_id` is still lingering in between tests and doesn't match `p` in the request, the cap check might pass while the queries for comments will blow up. I added `unset( $GLOBALS['post_id'] )` to `Tests_Ajax_GetComments::setUp()`.
* If the global `$post_id` is empty, but `$_REQUEST['p']` is not, `$post_id` is now set to `absint( $_REQUEST['p'] )` and sanity-checked in `wp_ajax_get_comments()`.
* `map_meta_cap()` always assumes that `get_comment()` succeeds when checking for the `edit_comment` cap. It doesn't. I added sanity checks in a few places where it will break early if `get_post()` or `get_comment()` are empty.
* `wp_update_comment()` always assumes `get_comment()` succeeds. It doesn't. I added a check for empty.

All AJAX unit tests run and pass in debug mode. All general unit tests pass against these changes.

Fixes #25282.


Built from https://develop.svn.wordpress.org/trunk@25438


git-svn-id: http://core.svn.wordpress.org/trunk@25360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-14 18:36:09 +00:00
Scott Taylor
a563a5b2fa Replace the ancient phpfreaks.com RegEx to extract urls to ping with a more robust matcher. URLs with commas and things like & were not being pinged. The new matcher even works for most IDN URLs. Adds unit tests. 
Fixes #9064.


Built from https://develop.svn.wordpress.org/trunk@25313


git-svn-id: http://core.svn.wordpress.org/trunk@25275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-10 03:18:08 +00:00
Andrew Nacin
41f1cd687b WP_Date_Query. 
props Viper007Bond.
see #18694.

Built from https://develop.svn.wordpress.org/trunk@25139


git-svn-id: http://core.svn.wordpress.org/trunk@25119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-08-27 16:39:09 +00:00
Andrew Nacin
4493b8c97a Return 1 from get_comment_pages_count() when pagination is disabled. 
props obenland.
fixes #17778.

Built from https://develop.svn.wordpress.org/trunk@25126


git-svn-id: http://core.svn.wordpress.org/trunk@25106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-08-26 18:52:08 +00:00
Andrew Nacin
6bb179d880 Remove redundant sentence in the docblock of get_comment(). props jdgrimes, fixes #24904. 
git-svn-id: http://core.svn.wordpress.org/trunk@24984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-08-05 22:08:17 +00:00
Andrew Nacin
21a1fe8d4b Use wp_safe_remote_request() and friends instead of reject_unsafe_urls = true. 
fixes #24646.



git-svn-id: http://core.svn.wordpress.org/trunk@24917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-07-31 06:52:13 +00:00
Andrew Nacin
8d65dc2469 Use wp_slash() in places where we improperly used the DB API instead. see #21767. 
git-svn-id: http://core.svn.wordpress.org/trunk@24713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-07-16 14:19:03 +00:00
Sergey Biryukov
58c364947f PHPDoc fixes and additions. fixes #24616. 
git-svn-id: http://core.svn.wordpress.org/trunk@24490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-06-21 12:45:11 +00:00
Andrew Nacin
96ee267343 Better validation of the URL used in core HTTP requests. 
git-svn-id: http://core.svn.wordpress.org/trunk@24480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-06-21 06:07:47 +00:00
Ryan Boren
a2b4bc456f * Introduce wp_parse_post_content() and use it in setup_postdata(), get_the_content(), and get_the_remaining_content(). 
* Add a post ID argument to the_content(), get_the_content(), the_remaining_content(), and get_the_remaining_content().
* Pass the post ID to the the_content filter.
* Remove the format_pages global.
* Declare format_content and split_content as vars in WP_Post.
* phpdoc for the the_content filter that documents the new ID argument and denotes it as not-so-portable.

Props gcorne, DrewAPicture, duck_, aaroncampbell
see #24330


git-svn-id: http://core.svn.wordpress.org/trunk@24301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-05-20 11:05:50 +00:00
Ryan Boren
7a1bc5769e Check for empty user agent to avoid notice. 
Props sergej.mueller
fixes #22979


git-svn-id: http://core.svn.wordpress.org/trunk@24275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-05-16 12:06:36 +00:00
Sergey Biryukov
415a5c60da * Pass ellipsis as a parameter to wp_html_excerpt() instead of appending it manually. 
* Consolidate the logic to avoid appending ellipsis if the entire string is shown.
* Show ellipsis after truncated filenames and post titles.

props solarissmoke, bpetty, SergeyBiryukov. fixes #11446.

git-svn-id: http://core.svn.wordpress.org/trunk@24214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-05-09 00:22:02 +00:00
Sergey Biryukov
57c10eadbb Use ellipsis instead of three dots. props tjsingleton, jordie23, wojtek.szkutnik, DrewAPicture, SergeyBiryukov. see #8714. 
git-svn-id: http://core.svn.wordpress.org/trunk@24207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-05-08 21:27:31 +00:00
Ryan Boren
375cb66409 Use prepare() for the duplicate comment query in wp_allow_comment(). 
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-04-12 13:25:16 +00:00
Ryan Boren
15a06a35ab Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes(). 
see #WP21767


git-svn-id: http://core.svn.wordpress.org/trunk@23591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-03 16:30:38 +00:00
Sergey Biryukov
4847fe6efc Make sure the pings are only sent once per URL for a given post. props dllh. fixes #23217. 
git-svn-id: http://core.svn.wordpress.org/trunk@23571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-01 17:39:52 +00:00
Ryan Boren
43a7e695e9 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767 
git-svn-id: http://core.svn.wordpress.org/trunk@23554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-01 16:28:40 +00:00
Ryan Boren
cc5ed3a485 Change all core API to expect unslashed rather than slashed arguments. 
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-14 22:51:06 +00:00
Ryan Boren
353ef064ea Use microtime() instead of incrementors for last_changed to to avoid race conditions with cache evictions. 
Props westi
fixes #23448


git-svn-id: http://core.svn.wordpress.org/trunk@23401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-11 18:08:14 +00:00
Andrew Nacin
411acbdf43 Use correct cache bucket. Fixes copy-paste error in r23320. props kurtpayne. see #23167. 
git-svn-id: http://core.svn.wordpress.org/trunk@23341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-01-24 17:21:55 +00:00
Andrew Nacin
82e9c40482 Validate pingback source URIs. Less verbose errors. 
git-svn-id: http://core.svn.wordpress.org/trunk@23329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-01-22 22:30:08 +00:00
Andrew Nacin
abd37fe4a7 Comment Query: Use $this->query_vars instead of the nonexistent shorthand $q. see #23208. 
git-svn-id: http://core.svn.wordpress.org/trunk@23325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-01-22 16:54:38 +00:00
Ryan Boren
1b2b394a91 Avoid the appearance of a magic number. 
Props nacin
see #23167


git-svn-id: http://core.svn.wordpress.org/trunk@23320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-01-22 15:52:13 +00:00
Ryan Boren
48058dfb99 Explicitly set last_changed to 1 instead of the result of wp_cache_set(). Avoids ambiguity and works with cache backends that return void instead of boolean. 
see #23167


git-svn-id: http://core.svn.wordpress.org/trunk@23319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-01-22 15:46:16 +00:00
Peter Westwood
f683fc7677 Tighten our braces. Fixes #23118 props evansolomon. 
git-svn-id: http://core.svn.wordpress.org/trunk@23265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-01-04 10:13:51 +00:00
Helen Hou-Sandí
b1f1579604 its <=> it's in documentation, along with a rogue the, The, and looses. props trepmal. fixes #22665. 
git-svn-id: http://core.svn.wordpress.org/trunk@23191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-20 15:55:32 +00:00
Andrew Nacin
8762f64494 Duplicate comments should be allowed under a different comment parent. props andy. fixes #21609. 
git-svn-id: http://core.svn.wordpress.org/trunk@22229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-10-14 17:06:37 +00:00
Ryan Boren
a9e25d964e If wp_cache_incr() is not available fallback to get()/set(). fixes #22024 
git-svn-id: http://core.svn.wordpress.org/trunk@22110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-10-04 13:25:58 +00:00
Ryan Boren
f1385f2979 Restore the behavior of the 'all' status for comment queries. Props SergeyBiryukov. see #21101 
git-svn-id: http://core.svn.wordpress.org/trunk@22090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-10-01 15:31:40 +00:00
Ryan Boren
b1834eae16 Revert stowaway in [22087] 
git-svn-id: http://core.svn.wordpress.org/trunk@22088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-10-01 14:26:45 +00:00
Ryan Boren
75e64cface Reinit roles and the current user after switching the cache to the new blog in switch_to_blog() and restore_current_blog(). Props joostdekeijzer. fixes #21459 
git-svn-id: http://core.svn.wordpress.org/trunk@22087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-10-01 14:25:31 +00:00
Ryan Boren
65c83c659a Invalidate the WP_Comment_Query:query() cache when comments are added. Switch last_changed to a counter incremented via wp_cache_incr(). 
fixes #22024


git-svn-id: http://core.svn.wordpress.org/trunk@22080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-28 12:47:31 +00:00
Ryan Boren
996268ff7a Remove debug cruft. Props duck_. fixes #21003 
git-svn-id: http://core.svn.wordpress.org/trunk@22079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-28 12:31:39 +00:00
Ryan Boren
75558ab270 Support meta queries in WP_Comment_Query. 
Props nikolov.tmw
fixes #21003


git-svn-id: http://core.svn.wordpress.org/trunk@22074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-27 21:53:14 +00:00
Ryan Boren
9f32de9496 Allow get_comments() to query for explicit value of comment_approved. 
Props dd32, nbachiyski
fixes #21101


git-svn-id: http://core.svn.wordpress.org/trunk@22068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-27 18:08:02 +00:00
Andrew Nacin
557d9313a7 Introduce constants to allow for easier expression of time periods in seconds. Adds MINUTE_IN_SECONDS, HOUR_IN_SECONDS, DAY_IN_SECONDS, WEEK_IN_SECONDS, YEAR_IN_SECONDS. props nbachiyski, SergeyBiryukov. fixes #20987. 
git-svn-id: http://core.svn.wordpress.org/trunk@21996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-25 05:26:19 +00:00
Ryan Boren
6b0b49c65b Update comment_parent in wp_update_comment(). Props JustinSainton. fixes #21706 
git-svn-id: http://core.svn.wordpress.org/trunk@21938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-21 12:57:26 +00:00
Ryan Boren
f483a85676 Remove unnecessary return by refs. Props wonderboymusic. fixes #21839 
git-svn-id: http://core.svn.wordpress.org/trunk@21792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-10 17:00:11 +00:00
Ryan Boren
bd94583aaf Use get_post() instead of bare SQL in do_trackbacks(). see #21309 
git-svn-id: http://core.svn.wordpress.org/trunk@21599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-08-23 20:43:47 +00:00
Ryan Boren
f56d8278bb Remove return ref from all calls to get_post() 
Return WP_Post from get_default_post_to_edit()
Replace all calls to get_page() with get_post()
see #21309


git-svn-id: http://core.svn.wordpress.org/trunk@21597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-08-23 20:01:10 +00:00
Peter Westwood
a8ce9af6d8 Comments: Allow the caller of get_comments() to request comments with a specific comment_approved value. 
This allows for a custom comment status to be queried directly overriding the status argument.

See #21101 props nbachiyski.


git-svn-id: http://core.svn.wordpress.org/trunk@21570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-08-21 09:56:16 +00:00
Ryan Boren
dc58551658 Add isset() check to avoid notice. Props c3mdigital. fixes #21512 
git-svn-id: http://core.svn.wordpress.org/trunk@21506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-08-14 19:07:56 +00:00
nacin
7127ed1197 Move most instances of new WP_User to get_userdata(). see #21120. 
git-svn-id: http://core.svn.wordpress.org/trunk@21413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-08-03 01:06:05 +00:00
nacin
9dca2c6876 Remove old code unsetting a few variables in wp-settings.php. fixes #21115. 
git-svn-id: http://core.svn.wordpress.org/trunk@21186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-06-29 20:57:09 +00:00
duck_
1e76fdfb4b Accept a post object in clean_post_cache(). Fixes #20486. 
The post_type can then be accessed to properly clean the taxonomy relationships cache.
The full object is useful in situations when an ID might reference a post that has been
removed from the database (e.g. wp_delete_post()).


git-svn-id: http://svn.automattic.com/wordpress/trunk@20569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-04-23 22:04:35 +00:00
nacin
c7cf0927fc Use the metadata API rather than raw queries and direct do_action calls. see #20417. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-04-11 20:02:39 +00:00
ryan
baf681233f Pass post_type to clean_post_cache() instead of attempting to fetch a post object since the post may have been deleted. 
Props leewillis77
see #19690


git-svn-id: http://svn.automattic.com/wordpress/trunk@20423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-04-10 16:09:44 +00:00
ryan
de41bc288b Introduce WP_User::exists(). see #20372 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-04-06 19:18:45 +00:00
nacin
0730535015 Introduce $wpdb->delete(). props justindgivens, scribu. fixes #18948. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-03-24 15:24:31 +00:00
nacin
8199ae99aa Add $post_ID context to the pre_ping filter. props alexkingorg, devesine. fixes #18506. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-03-06 22:44:44 +00:00
ryan
d910c26182 Pinking shears 6-20000 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-02-27 19:46:52 +00:00
nacin
51cdc1719d Docs, see ##19882. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-02-10 22:49:56 +00:00
nacin
40ff0dafbe Allow get_comment_meta() to be called with only a comment ID, something get_metadata() allows. Same functionality as get_user_meta() and get_post_meta(). see #19882. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-02-10 22:44:30 +00:00
westi
c54927be82 Update the documentation of wp_set_comment_status to match current functionality props solarissmoke. 
The 'delete' status was removed in [11749] when the concept of a trash status was introduced for #4529.

git-svn-id: http://svn.automattic.com/wordpress/trunk@19751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-25 10:41:52 +00:00
ryan
e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-08 17:01:11 +00:00
ryan
83b131f8e3 User lowercase true, false, null instead of uppercase. Props c3mdigital, mfields. fixes #16302 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-05 20:50:54 +00:00
ryan
616c35e71c One newline is enough. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-05 20:10:39 +00:00
westi
c39397033a Make it possible for commenter cookies to be disabled if someone wants to by setting them on an action instead of always. Fixes #17976 props SergeyBiryukov and pishmishy . 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-21 10:57:42 +00:00
ryan
07ff8b216b Use one space, not two, after trailing punctuation. fixes #19537 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-13 23:45:31 +00:00
markjaquith
9e80bec002 Always pass the post ID as the second argument to the the_title filter. props GaryJ. fixes #16688 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-10-06 21:09:37 +00:00
duck_
a7a8d9e3e3 Use metadata API in do_all_pings() to delete post meta (cleaner, plays better with cache). Remove redundant query to retrieve meta_id. See #18196. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-10-01 08:38:33 +00:00
ryan
96b3575b72 Pass the query object to _close_comments_for_old_posts() so that is_singular is checked for the proper query. Props kawauso. fixes #18109 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-09-30 15:35:50 +00:00
westi
2ad5ccbe7b Only close comments on old posts by default. Fixes #16090 props nacin and johnjamesjacoby. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-01 14:24:02 +00:00
nacin
da2732c7de Use wp_remote_retrieve_* helper functions instead of the raw HTTP response array. props aaroncampbell, fixes #17416. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-05-14 19:45:07 +00:00
ryan
bdc8924ea4 Fix notice thrown in wp_count_comments(). Props tfnab, batmoo. fixes #15215 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-05-04 18:46:03 +00:00
ryan
430bb76d4b Allow retrieving comments by post type, status, author, author, name, or parent. Fetch only published posts for recent comments widget. Props filosofo. fixes #16506 #12904 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-04-20 18:02:41 +00:00
ryan
e3895262ef Deprecate wp_clone(). Call clone directly. Props hakre. fixes #16813 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-04-06 17:44:29 +00:00
dd32
3d87397272 Revert debug cruft from r17052. See #15885 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-19 04:58:09 +00:00
dd32
e442dd64f0 Fix Pings/Trackback comment table filter. Props greuben. Fixes #15885 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-19 04:55:46 +00:00
ryan
7e25e3b363 Add like_escape() to some queries. fixes #15764 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-16 14:22:41 +00:00
markjaquith
a0bc51f8d8 Use prepare() instead of addslashes(). props wpmuguru. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-01 01:51:32 +00:00
markjaquith
b246fdf17f Drop pingback/trackback blogroll whitelisting feature. Too many ways to abuse it. props avereha. props vladimir_kolesnikov. fixes #13887 for trunk 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-30 22:46:35 +00:00
ryan
e1bb824b25 Prepare properly. Props Vladimir Kolesnikov. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-30 20:04:11 +00:00
ryan
847499e531 Pinking shears 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-17 18:47:34 +00:00
scribu
03dd41a0d2 Improve hook readability via curly brackets. Props jjj for initial patch. Fixes #15422 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-14 15:50:02 +00:00
scribu
9c4ab78301 Always apply comment_text filter in check_comment(). Props hakre. Fixes #14680 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-13 22:30:36 +00:00
scribu
40b2c5b6c5 Kill WP_Object_Query. See #15032 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-13 18:32:43 +00:00
scribu
6267650ddd Split get_search_sql(). See #15170. See #15032 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-13 18:18:45 +00:00
westi
2bc7106135 Rename new classes to match our coding standards. Fixes #15280. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-02 08:29:07 +00:00
westi
4ef6fab485 Don't pass deprecated argument to discover_pingback_server_uri! 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-29 07:06:48 +00:00
westi
c83e1d1ef3 Switch to using WP_HTTP_IXR_Client in core. See #10588. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-28 22:15:54 +00:00
scribu
8333876a68 Make comment clauses more similar to post clauses. See #15019 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-27 19:05:39 +00:00
scribu
1ce593e3de Add filters to WP_Comment_Query. Props sc0ttkclark. Fixes #15019 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-27 18:49:45 +00:00
scribu
9bb5485853 Move get() and set() methods from WP_Query to WP_Object_Query. See #15032 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-27 18:16:52 +00:00
nacin
5e1184aa57 Pinking shears. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-19 07:48:22 +00:00
scribu
31797f691a Move _wp_search_sql() into WP_Object_Query. Introduce WP_Comment_Search. See #15032 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-04 21:05:31 +00:00
scribu
d66d93ccab Apply filter to wp_get_current_commenter(). Fixes #14878 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-09-16 20:48:18 +00:00
nacin
aa0f906c84 Pass some context to the pre_comment_approved hook. props coffee2code, fixes #14802. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-09-07 14:36:35 +00:00
nacin
5a20c05d27 Phpdoc argument/@param cleanups. props duck_, see #14783. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-09-07 11:21:11 +00:00
nacin
b97858641c Add a note about REMOTE_ADDR behind proxies. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-09-03 10:18:32 +00:00
ryan
925124db11 Update last_changed when cleaning comment cache. fixes #14713 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-08-30 19:59:16 +00:00
scribu
020ce73746 Ajaxify list-type screens in the admin. See #14579 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-08-11 21:54:51 +00:00
nacin
791192d961 Add $force_delete to wp_delete_comment(). see #12766, see #11470. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-04 12:20:19 +00:00
nacin
fc7dbbcc3e Fix notice in wp_new_comment(). fixes #10854. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-02 05:01:13 +00:00
nacin
3918b75cbe Change @since 2.9 to @since 2.9.0. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-03-26 19:23:39 +00:00
nacin
308c876d27 Fix notice without breaking comment notifications. See r13150, see #11830 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-03-22 16:06:55 +00:00
nacin
2a3564c8ad Provide filter to allow including comment author's URL in comment moderation link count. see #11684 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-28 20:02:14 +00:00
nacin
da2634030a Add comment_duplicate_trigger hook that is fired when a duplicate comment is detected. Fixes #12188 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-26 19:06:09 +00:00
nacin
8bcc5969dc Spelling and grammar fun. Fixes #11875 props cnorris23 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-24 20:13:23 +00:00
nacin
5a1013b8ba Don't use private wpdb vars. See #11644 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-24 00:18:18 +00:00
dd32
679250491d Variable Cleanup, Unused variables, Typo'd variables, unused code blocks. Fixes #12299 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-20 02:01:46 +00:00
nacin
775bebfade Adjust regex for counting links in a comment when checking if it needs to be held for moderation. Also fix notice in wp_new_comment(). see #11830 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-14 10:59:37 +00:00
ryan
6da55f7792 Trailing whitespace cleanup 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-01-15 22:11:12 +00:00
westi
bf4a5241e1 Add missing version numbers to _deprecated_argument() calls. 
Remove deprecated argument from xfn_check() calls.
Pass version number to deprecated_file_included, deprecated_function_run and deprecated_argument_run actions.
Fixes #11386 props nacin.

git-svn-id: http://svn.automattic.com/wordpress/trunk@12680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-01-09 10:03:55 +00:00
ryan
ec8e347792 Introduce home_url(). Props Denis-de-Bernardy, hakre. see #9008 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-01-04 17:23:29 +00:00
westi
ff7831207c Updates and improvements to _depreceated_argument. See #11386 props nacin. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-30 16:23:39 +00:00
westi
47a7b1b003 Fix typo in _deprecated_argument() and start using _deprecated_argument() in wp-includes files. See #11386 props nacin. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-24 11:12:04 +00:00
ryan
adb37768c6 Add more orderby and select options to get_comments. Props filosofo. fixes #10668 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-23 16:16:13 +00:00
westi
95b7e055ce Check that there is a comment_agent to filter and otherwise filter an empty string. Fixes a notice during import from old WXR files. See #11484. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-21 15:35:00 +00:00
ryan
6daee9e140 Delete all comment meta when deleting a comment. Props nacin. fixes #11463 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-17 17:54:23 +00:00
ryan
cdfda5dd2c Delete all comment meta when deleting a comment. Props nacin. fixes #11463 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-17 17:10:40 +00:00
westi
9111a5405f Fix phpDoc for Comment Meta functions to refer to comments not posts. See #11462 props sirzooro. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-16 22:13:53 +00:00
westi
60dfe693d4 Restore the check for trueness on $user_id so we don't run the queries or create the objects. Fixes #11419 props Denis-de-Bernardy. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-13 17:32:14 +00:00
westi
a43c737a0d Check that $user_id is set. For non-logged in users it is not set so we get a notice. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-13 11:43:19 +00:00
markjaquith
a8686bb67c Optimize Whoa Cowboy query. Only look back one hour. props mdawaffe. fixes #4366 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-11 23:29:19 +00:00
westi
92a8421c69 Allow plugins to filter the UserAgent used for PingBack requests. Fixes #11317 props mtdewvirus. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-06 14:28:35 +00:00
ryan
96c363a384 Accept either user_id or user_ID. Remove user_id global. see #11271 #11222 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-01 02:06:02 +00:00
ryan
6aeb3bd273 comment status transition was broken due to sneaky reference return in &get_comment. Props skeltoac 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-11-29 20:05:39 +00:00
azaozz
f296da8169 "Trash" fixes, props caesarsgrunt, see #4529 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-11-28 03:56:20 +00:00
azaozz
fe29434e05 Undo for setting a comment as spam, props caesarsgrunt, fixes #11260, see #4529 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-11-27 10:34:09 +00:00
azaozz
c3f7df6b24 Fix notices and phpdoc, props hakre, fixes #10758 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-11-26 11:29:54 +00:00
ryan
cfc8317abe Standardize on user_id instead of user_ID when passing comment data. fixes #11222 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-11-23 21:04:11 +00:00
azaozz
986cc7d505 Ignore trashed comments for duplicate comment check, props scribu, fixes #10944 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-11-21 11:31:21 +00:00
ryan
c8ead9801c Return if no comment queried 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-11-19 17:58:11 +00:00
azaozz
dc7d0f1dff Always show "Configure" links on dashboard widgets in IE6, fix "Right Now" comments counts, fixes #11129 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-11-13 05:39:17 +00:00
ryan
87208b9a48 Remove ints from switch. see #11073 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-11-05 22:53:31 +00:00
ryan
33a8043b97 Trash comments when trashing a post. see #11073 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-11-05 21:03:09 +00:00
azaozz
b86f746d21 Fix possible bad query, props aaroncampbell, see #4529 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-10-28 03:10:59 +00:00
ryan
0dd4b4ab9e Remove slow left join pending better solution. see #4529 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-10-27 15:51:58 +00:00
ryan
bf96c01551 Associate subdirector of whitespace trims trailing whites with pinking shears. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-10-15 20:26:21 +00:00
azaozz
d20c23e98d Add Undo when moving comments to the trash, remove unneeded nonces, see #4529 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-10-08 08:24:59 +00:00
azaozz
ba6b275c7a Add conditional to handle get_comment_meta() return value, make #comment_id required arg for wp_trash_comment() and wp_untrash_comment(), see #4529 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-10-05 01:49:19 +00:00
westi
606b6197b5 Delete the trash metadata when untrashing a comment. See #4529 props caesarsgrunt. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-10-01 19:59:35 +00:00
markjaquith
4ead128521 esc_sql() for wp-includes 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-09-27 05:33:56 +00:00
ryan
57f26bb58e Remove trailing whitespace 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-09-24 17:19:13 +00:00
ryan
ead46cf470 Actions for postmeta updates. Props Demitrious Kelly. see #10750 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-09-24 17:10:28 +00:00
westi
ef11608c43 Move the storage of the metadata for trashed comments into the comment meta table rather than storing it in an option. See #4529. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-09-17 20:51:12 +00:00
westi
c67e70dd91 First pass commentmeta implementation. See #2659 props scribu. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-09-17 20:17:33 +00:00
ryan
8e3808bce2 Remove trailing whitespace 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-09-14 14:03:32 +00:00
ryan
0e3f9e6b8d Pass correct old status when transitioning comment status. Props hakre. fixes #8863 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-08-21 01:27:01 +00:00
ryan
9eef5564d5 Kill entity check in wp_blacklist_check(). Props tellyworth. fixes #9965 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-08-17 01:38:01 +00:00
azaozz
39e4f05a15 Trash status updates for posts, pages, comments and attachments, props caesarsgrunt, see #4529 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-07-30 13:39:34 +00:00
azaozz
2040971211 "Trash" status for comments updates, props caesarsgrunt, see #4529 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11741 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-07-24 07:23:11 +00:00
ryan
f7e02a7c22 Pings to the people. Return to pinging for updates to published posts. see #6698 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-07-21 23:09:47 +00:00
ryan
98e73f0c98 Process waiting pings a half hour after the last ping to avoid spamming ping sites. Don't make a ping wait if the last ping was more than half an hour ago. Props VoxPelli. fixes #6698 for trunk 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-07-21 19:44:21 +00:00
azaozz
d2fec31c0e "Trash" status for comments, first run, props caesarsgrunt, see #4529 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11731 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-07-21 03:11:12 +00:00
azaozz
9f6cd3b709 Truncate comment agent when longer than 255 chars, props Denis-de-Bernardy, fixes #10389 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-07-14 08:20:24 +00:00
ryan
2df887bd07 Trim tailing whitespace 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-24 23:47:49 +00:00
ryan
05d4c954ac Throttle generic pings to no more than once per hour. Props Denis-de-Bernardy. fixes #6698 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-20 17:03:19 +00:00
ryan
1354d0660a Don't localize dates where not appropriate. Props Denis-de-Bernardy, hakre. fixes #9730 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-14 02:00:32 +00:00
markjaquith
6c2ffddf31 _a(), _ea(), _xa(), attr() are now esc_attr__(), esc_attr_e(), esc_attr_x(), esc_attr() -- still short, but less cryptic. see #9650 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-05 19:43:53 +00:00
azaozz
83f674bf9a Banishing ASCII quotes and apostrophes, props demetris, fixes #9655 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-05 04:28:05 +00:00
westi
96eb01c3ac Enhance get_comments() phpdoc. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-04 09:22:44 +00:00
ryan
1d2a1111a0 Fix status transitions from edit comment form. Props josephscott. fixes #8863 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-04-29 17:22:08 +00:00
ryan
2d489767bb s/attribute_escape/attr/. see #9650 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-04-28 05:58:45 +00:00
ryan
e8b6fe7347 Trim trailing whitespace 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-03-18 02:43:45 +00:00
ryan
d10b538652 gettext contexts. Props nbachiyski. see #9112 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-03-10 23:02:29 +00:00
ryan
45e76b1b55 Reparent children when deleting a comment. Props vladimir_kolesnikov. fixes #9003 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-03-10 19:02:27 +00:00
ryan
c1886783d1 Use wpdb::insert() and update(). see #6836 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10731 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-03-06 05:06:15 +00:00
ryan
d43bd8177c Use wpdb::insert() and update(). Props DD32. see #6836 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-03-06 04:27:51 +00:00
ryan
3e3cb817f1 Add some error feedback to ajax comment moderation. see #9261 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-03-02 21:48:37 +00:00
ryan
b5a65633d0 discover_pingback_server_uri optimizations. Props DD32. fixes #8816 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-02-15 20:56:54 +00:00
ryan
e18f062b92 Disambiguate 'Approved' translation. Props nbachiyski. fixes #8638 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-02-12 20:42:04 +00:00
azaozz
fdcf39c107 Make comment_karma accessible from normal comment API functions, props beaulebens, fixes #9085 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-02-10 19:16:00 +00:00
ryan
94ac6098e2 wp_insert_comment action 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-01-29 22:22:20 +00:00
ryan
9bdf38f5c2 Don't count emoticons toward link total. Props tott. fixes #8627 #7821 for trunk 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-01-28 21:12:57 +00:00
ryan
b2b22f66d2 Include only approved comments when determining page of comment. Props GregMulhauser. fixes #8973 for trunk 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-01-28 18:43:08 +00:00
ryan
a3becc9f3a Close comments for old posts, pages, and attachments, not just posts. Props mrmist. fixes #8740 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-12-30 20:09:40 +00:00
ryan
e89192b1a8 Strip trailing whitespace 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-12-09 18:03:31 +00:00
markjaquith
85d594a716 Only count specific comment approval types for the types we know about, to avoid a potential notice. fixes #8503 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-12-09 08:07:52 +00:00
ryan
9f56c8eba4 Add paging links above comments list. Props Viper007Bond. fixes #8219 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-12-07 04:49:22 +00:00
ryan
b3745318f4 Allow plugins to hook in a custom comment counter 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-12-05 23:40:09 +00:00
westi
cfbc31027e Fix Notice on comment posting. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-12-04 20:26:05 +00:00
markjaquith
30c3602b92 Improvements for get_comment_link() from Viper007Bond. fixes #8287 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-11-20 06:41:55 +00:00
markjaquith
ef4c17e167 Count links in comments after performing automatic linking. props tott. fixes #7821 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-11-19 07:08:37 +00:00
ryan
8f19010b2d Use pings_open() to check ping status 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-11-14 22:33:13 +00:00
ryan
2bab4e2ec0 Differentiate between plural noun, verb and adjective Spam translations. Props nbachiyski. fixes #8154 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-11-11 19:54:54 +00:00
markjaquith
8d544355df Use prepare() in get_comments() 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-11-10 22:16:50 +00:00
ryan
545da15950 Notice fixes from DD32. see #7509 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-11-10 18:54:18 +00:00
ryan
3b043a8308 notice fixes 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-11-06 02:05:59 +00:00
markjaquith
88bfbbd948 Massive get_comment_link() performance improvements for posts with a lot of comments. props Viper007Bond. fixes #7956 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-11-05 07:09:20 +00:00
ryan
feab9ff5f1 Add caching to get_comments(). see #8057 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-11-04 16:44:55 +00:00
ryan
c31fcfdab3 Warning fixes 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-11-03 06:44:48 +00:00
ryan
08998169ad get_page_of_comment() fixes from Viper007Bond. see #7956 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-10-28 07:29:04 +00:00
ryan
8d76dc5af1 get_page_of_comment() fixes from Viper007Bond. see #7956 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-10-28 07:17:29 +00:00
azaozz
f7ea3c572b Fix redirecting of old slugs when Close Old Comments is enabled, props DD32, fixes #7976 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-10-28 01:20:38 +00:00
ryan
53220e2a0e Make get_comment_link() paging aware. Props Viper007Bond. see #7956 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-10-27 16:31:26 +00:00
ryan
e3517a9be4 Send 403 instead of 500 for comment flood protection. Allow specifying response code for wp_die(). Props DD32. fixes #7246 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-10-24 21:00:40 +00:00
ryan
91841f2e3c Comment paging and sorting from Viper007Bond. see #7927 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-10-23 16:08:47 +00:00
ryan
729539ef94 Don't double encode ping/trackbacks. Props reinkim. fixes #7844 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-10-22 22:48:14 +00:00
ryan
3be95653d0 comment_status transition hooks from Viper007Bond. fixes #7894 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-10-16 04:18:45 +00:00
ryan
33bcf4ec87 Error checking for HTTP requests. Props jacobsantos. see #7793 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-10-02 00:32:21 +00:00
ryan
d0ae9b2196 If comment type is empty set it to 'comment'. see #7635 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-09-30 19:49:26 +00:00
ryan
a21c2c2890 Make pings_open() and comments_open() aware of old post settings. see #7741 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-09-28 03:31:26 +00:00
westi
7aa23c8b4f Move the pingbacks and trackbacks to the new HTTP api. See #7793 props jacobsantos. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-09-27 21:40:09 +00:00
azaozz
df5ff389e9 phpDoc corrections for comment.php, props jacobsantos, fixes #7550 
git-svn-id: http://svn.automattic.com/wordpress/trunk@8956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-09-22 20:21:10 +00:00
azaozz
533f1ab81b Complete comment.php inline documentation, props jacobsantos, fixes #5578 
git-svn-id: http://svn.automattic.com/wordpress/trunk@8949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-09-22 03:39:41 +00:00
ryan
3aad45d7e4 Add type argument to wp_list_comments(). Make comments arg optional. Introduce separate_comments(). see #7635 
git-svn-id: http://svn.automattic.com/wordpress/trunk@8897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-09-16 00:23:38 +00:00
ryan
ef80502b9a Close comments for old posts. see #7741 
git-svn-id: http://svn.automattic.com/wordpress/trunk@8892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-09-15 16:26:37 +00:00
azaozz
7e721f6b92 Ignore comment_max_links option when zero, props tellyworth, fixes #7699 
git-svn-id: http://svn.automattic.com/wordpress/trunk@8833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-09-06 05:59:56 +00:00
ryan
2192b1f450 Lose USE INDEX on comment_date_gmt. It didn't help performance very much and some people are missing the comment_date_gmt index. see #7664 
git-svn-id: http://svn.automattic.com/wordpress/trunk@8813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-09-05 15:43:26 +00:00
azaozz
95fa29a208 Reply to comments from admin, first run, see #7435 
git-svn-id: http://svn.automattic.com/wordpress/trunk@8720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-08-24 06:56:22 +00:00
ryan
e68d5f07b4 comment_approved can be zero, so check with isset instead of empty. fixes #7446 
git-svn-id: http://svn.automattic.com/wordpress/trunk@8622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-08-12 16:23:47 +00:00
markjaquith
74c46749cb Cast to array when using foreach(). Props santosj (and thanks for your perseverance!). fixes #2784 
git-svn-id: http://svn.automattic.com/wordpress/trunk@8572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-08-06 20:31:54 +00:00
ryan
1b0bfced2e XML-RPC comments API. see #7446 
git-svn-id: http://svn.automattic.com/wordpress/trunk@8543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-08-04 22:29:37 +00:00
westi
bf35dedced PHPDoc updates for comment.php. See #5578 props jacobsantos. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@8091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-06-15 09:34:00 +00:00
ryan
f7f3005004 close the socket in discover_pingback_server_uri 
git-svn-id: http://svn.automattic.com/wordpress/trunk@8052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-06-04 23:36:55 +00:00
ryan
f57354bf63 Fix duplicate comment notifications. Props MtDewVirus. fixes #6892 for trunk 
git-svn-id: http://svn.automattic.com/wordpress/trunk@8004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-05-28 15:37:59 +00:00
ryan
359601b720 Resurrect comment approval notification. Props chmac. fixes #6892 for trunk 
git-svn-id: http://svn.automattic.com/wordpress/trunk@7917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-05-12 16:14:15 +00:00
markjaquith
25b49b2ceb Remove last remaining user level checks in favor of capabilities checks. props filosofo. fixes #6940 
git-svn-id: http://svn.automattic.com/wordpress/trunk@7912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-05-09 00:45:17 +00:00
ryan
63d12e0b39 Use 'counts' cache group. see #6884 
git-svn-id: http://svn.automattic.com/wordpress/trunk@7878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-05-02 19:42:44 +00:00
ryan
8c59e943d4 Add per post counting to wp_count_comments(). Props josephscott. fixes #6884 
git-svn-id: http://svn.automattic.com/wordpress/trunk@7868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-05-01 16:52:48 +00:00
ryan
e399f6ad54 Cache comment count and use count API in menu.php 
git-svn-id: http://svn.automattic.com/wordpress/trunk@7714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-04-16 23:45:39 +00:00
ryan
ce1fed1a02 Strip slashes before preparing comment insert to avoid double-slashing. Props filosofo. fixes #6738 
git-svn-id: http://svn.automattic.com/wordpress/trunk@7690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-04-15 18:05:08 +00:00
ryan
56f15cb1bf Add missing comma. see #6644 
git-svn-id: http://svn.automattic.com/wordpress/trunk@7657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-04-14 16:45:12 +00:00
ryan
248a0c06e2 Prepare DB queries in more places. Props filosofo. see #6644 
git-svn-id: http://svn.automattic.com/wordpress/trunk@7645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-04-14 16:13:25 +00:00
markjaquith
fda19a41bf don't time-throttle comments from Administrators 
git-svn-id: http://svn.automattic.com/wordpress/trunk@7425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-03-20 20:32:18 +00:00
ryan
6e181bb941 Multi-byte character safe excerpting from nbachiyski. fixes #6077 
git-svn-id: http://svn.automattic.com/wordpress/trunk@7140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-03-03 21:05:23 +00:00
ryan
93f0c00cb7 Manage comments rework. WIP 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-02-23 08:33:44 +00:00
ryan
1857fc1627 generic_ping() improvements from fitztrev. fixes #5855 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-02-14 21:50:43 +00:00
ryan
8fecb97b09 Order by and index on comment_date_gmt instead of comment_date to insulate order from offset changes. fixes #5773 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-02-05 23:29:59 +00:00
ryan
b67bbb9e4e Add key on comment_approved,comment_date to speed up last comment modified queries. fixes #5773 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-02-05 18:04:17 +00:00
ryan
d88983793b Trailing whitespace cleanup 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-02-05 06:47:27 +00:00
westi
2ac5c0204f Remove the duplicate code for sanitising IP Addresses we only need to do it once. Fixes #4579. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-01-26 10:18:33 +00:00
westi
f9ba9a3802 Allow IPv6 addresses as well. Fixes #4579 props pishmishy. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-01-25 18:50:52 +00:00
ryan
6726698979 get_col() instead of get_results(). Props fitzrev. fixes #5699 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-01-22 05:50:22 +00:00
ryan
74cad1dac8 Eliminate comment_date_gmt <= now from get_lastcommentmodified() queries. fixes #5650 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-01-14 05:59:39 +00:00
westi
e0856a070f Simplify to_ping query. Fixes #5649 props misterbisson. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-01-12 17:31:17 +00:00
ryan
502a542d64 phpdoc for comment.php from darkdragon. fixes #5578 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-01-04 20:03:42 +00:00
ryan
1ae1811dd0 Unused var cleanup. Props DD32. see #5418 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-01-04 19:36:34 +00:00
ryan
99b6eff02c wp.getCommentCount from josephscott. fixes #5463 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-01-01 18:40:39 +00:00
ryan
8b64f70945 Defer comment counting. Props tellyworth. fixes #5557 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-01-01 17:03:52 +00:00
ryan
028a159440 Remove unused vars. Props DD32. see #5418 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-12-06 19:49:33 +00:00
ryan
5c07742cd3 Remove old comment_count_cache variable. It's dead. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-11-29 05:03:25 +00:00
markjaquith
47955b3fae prepare() for wp-includes/ bookmark.php, canonical.php, comment.php, comment-template.php. see #4553 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-09-27 07:34:15 +00:00
ryan
0f6dfb8b1f Remove hardcoded clean_url on comment_author_url since it is handled on the pre_comment_author_url filter. Props wnorris. fixes #4120 
git-svn-id: http://svn.automattic.com/wordpress/trunk@5975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-08-29 19:04:14 +00:00
matt
d9793c3e8d Make the entire comment flood check pluggable as it can cause load problems on large sites. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@5947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-08-27 06:34:18 +00:00
ryan
948284b296 Don't update comments feed last-modified header for unapproved comments. Props James Ballantine and Nazgul. fixes #4618 for 2.3 
git-svn-id: http://svn.automattic.com/wordpress/trunk@5885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-08-16 19:26:01 +00:00
ryan
ddc05f60ea wp_update_comment_count hook from mdawaffe. fixes #4740 
git-svn-id: http://svn.automattic.com/wordpress/trunk@5869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-08-14 03:08:44 +00:00
markjaquith
a2f7332558 Mark pingback as already pinged when the target site says it already got the pingback. props mdawaffe. fixes #4289 
git-svn-id: http://svn.automattic.com/wordpress/trunk@5772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-06-27 23:28:36 +00:00
ryan
9d3d20f063 Use EXTR_SKIP when extracting. see #4468 
git-svn-id: http://svn.automattic.com/wordpress/trunk@5708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-06-14 22:45:40 +00:00
ryan
f2f6101e1c Comment caching. Reduce queries on edit-comments.php page. Add non-persistent cache groups. Hat tip to hovenko. fixes #4387 
git-svn-id: http://svn.automattic.com/wordpress/trunk@5666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-06-08 00:20:22 +00:00
ryan
8aaa48e041 Use the right field name ya idjit. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@5329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-04-27 04:34:44 +00:00
ryan
d44752d2ca Consult global comment in get_comment(). Don't show empty edit links. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@5328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-04-27 03:51:36 +00:00
rob1n
56add54053 Housekeeping -- clean out debug calls. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@5307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-04-24 23:58:51 +00:00
ryan
4de9ca69c2 More clean_url and int casts for trunk. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@5119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-03-27 23:45:41 +00:00
matt
3d21925922 Ryan slays the dragon. (Some of these return WP_Error objects.) 
git-svn-id: http://svn.automattic.com/wordpress/trunk@5089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-03-23 02:05:29 +00:00
matt
7602d17899 (int)er the dragon. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@5087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-03-23 00:59:21 +00:00
markjaquith
611b037efa use clean_url() instead of attribute_escape() when dealing with src/href to protect against XSS. props xknown. fixes #3986 for trunk. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@5056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-03-17 08:46:59 +00:00
ryan
7ba967ebd2 Update comment date gmt when updating comment date. Props mm6. fixes #3503 
git-svn-id: http://svn.automattic.com/wordpress/trunk@4705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-01-09 08:22:28 +00:00
markjaquith
5a76c03203 new function for escaping within attributes: attribute_escape() 
git-svn-id: http://svn.automattic.com/wordpress/trunk@4656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-12-21 10:10:04 +00:00
ryan
203f6c5ab4 Some caching cleanups. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@4631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-12-08 07:35:45 +00:00
markjaquith
0aa19529f9 Bunch of whitespace and coding standardization. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@4626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-12-07 03:57:23 +00:00
ryan
9f534ebae6 Remove trailing spaces and convert spaces to tabs. Props Nazgul. fixes #986 
git-svn-id: http://svn.automattic.com/wordpress/trunk@4495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-11-19 07:56:05 +00:00
markjaquith
1b1b5bfe03 comment link counting improvements from Nazgul. fixes: #938 
git-svn-id: http://svn.automattic.com/wordpress/trunk@4299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-10-04 04:43:25 +00:00
markjaquith
2c775dede6 remove comment_user_domain cruft. Props Nazgul. fixes #3197 
git-svn-id: http://svn.automattic.com/wordpress/trunk@4293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-10-04 03:58:43 +00:00
ryan
8a4b655453 Pluggable comment throttling from Mark Jaquith. fixes #3175 
git-svn-id: http://svn.automattic.com/wordpress/trunk@4265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-10-02 18:19:44 +00:00
matt
67d5a6d3c7 Options cleanup and some styling changes. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@4196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-09-19 06:11:42 +00:00
ryan
ad1924f837 do_action_ref_array(). fixes #3125 
git-svn-id: http://svn.automattic.com/wordpress/trunk@4186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-09-12 17:45:23 +00:00
ryan
849a0d29d7 Use get_option instead of get_settings. Just 'cause. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@4144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-08-30 21:46:31 +00:00
ryan
efcb63ad21 s/URI/URL/. Props Nazgul. fixes #2666 
git-svn-id: http://svn.automattic.com/wordpress/trunk@4133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-08-30 16:40:17 +00:00
matt
7c65645c62 Clean up how we address IP addresses throughout the code 
git-svn-id: http://svn.automattic.com/wordpress/trunk@3990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-07-06 00:04:24 +00:00
ryan
42557940a1 Use wp_die(). Props filosofo. fixes #2914 
git-svn-id: http://svn.automattic.com/wordpress/trunk@3985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-07-05 22:00:03 +00:00
ryan
1034767a9a wp_get_current_commenter() 
git-svn-id: http://svn.automattic.com/wordpress/trunk@3902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-06-22 20:52:12 +00:00
ryan
e673d82afb Move ping and trackback functions to comment.php (maybe to ping.php later?) #2525 
git-svn-id: http://svn.automattic.com/wordpress/trunk@3900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-06-22 19:44:36 +00:00
ryan
8ae8b35c10 wp_update_comment_count() from MarkJaquith. fixes #2836 
git-svn-id: http://svn.automattic.com/wordpress/trunk@3887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-06-19 17:17:52 +00:00
ryan
3c8ed766e1 Reworg post/page/attachment functions. #2525 
git-svn-id: http://svn.automattic.com/wordpress/trunk@3851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-06-07 23:17:59 +00:00
ryan
8da6c47ae3 Add some prophylactic int casts and quoting. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@3740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-04-22 00:02:00 +00:00
ryan
6027cfa946 Reorg comment functions. #2525 
git-svn-id: http://svn.automattic.com/wordpress/trunk@3714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2006-04-19 02:32:12 +00:00