Commit Graph

26368 Commits

Author SHA1 Message Date
Scott Taylor
b2f6e1f674 In wptexturize() + tests:
* Allow well-formed HTML inside of shortcode attributes
* Restrict recursion. HTML is allowed but ignored.
* Do not allow exotic HTML comments in shortcode attributes.
* Continue to ignore the [ and ] chars if they appear in any HTML attribute.
* Update related regex patterns.
* Update unit tests.

Props miqrogroove.
Fixes #28564.

Built from https://develop.svn.wordpress.org/trunk@28773


git-svn-id: http://core.svn.wordpress.org/trunk@28586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-18 19:49:15 +00:00
Sergey Biryukov
5bd180bcbd Revert [28766].
see #28555.
Built from https://develop.svn.wordpress.org/trunk@28772


git-svn-id: http://core.svn.wordpress.org/trunk@28585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-18 02:23:13 +00:00
Sergey Biryukov
d2a43e7cb2 Don't add # to URL when clicking 'OK' without changing the permalink.
props avryl.
fixes #27594.
Built from https://develop.svn.wordpress.org/trunk@28771


git-svn-id: http://core.svn.wordpress.org/trunk@28584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-18 00:29:15 +00:00
Sergey Biryukov
585213b0b6 Don't generate adjacent links in wp_head() for attachments.
props kovshenin.
fixes #21658.
Built from https://develop.svn.wordpress.org/trunk@28770


git-svn-id: http://core.svn.wordpress.org/trunk@28583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-18 00:05:16 +00:00
Sergey Biryukov
8b4b3697e0 Pass WP_Customize_Setting instance to 'customize_save_*' action.
props danielbachhuber.
fixes #27979.
Built from https://develop.svn.wordpress.org/trunk@28769


git-svn-id: http://core.svn.wordpress.org/trunk@28582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-17 23:58:16 +00:00
Andrew Ozz
46f17ee039 TinyMCE: update to 4.0.28+. Includes all changes until 09-06-2014: 32cb108d41. Changelog: 32cb108d41/changelog.txt.
See #28391.
Built from https://develop.svn.wordpress.org/trunk@28768


git-svn-id: http://core.svn.wordpress.org/trunk@28581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-17 23:49:15 +00:00
Sergey Biryukov
f0a3d5cfa8 Pass WP_Customize_Setting instance to 'customize_preview_*' and 'customize_update_*' actions.
props dustyn, DrewAPicture.
fixes #27979.
Built from https://develop.svn.wordpress.org/trunk@28767


git-svn-id: http://core.svn.wordpress.org/trunk@28580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-17 23:35:15 +00:00
Sergey Biryukov
cd7618399e Prevent bulk actions from being performed when Filter button is clicked.
props layotte.
fixes #28555.
Built from https://develop.svn.wordpress.org/trunk@28766


git-svn-id: http://core.svn.wordpress.org/trunk@28579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-17 22:17:14 +00:00
Scott Taylor
f1a15dd4fe Fix abbreviations mixed with quotes, example: '99% of people'.
Add/alter unit tests.

Props miqrogroove.
Fixes #26850.

Built from https://develop.svn.wordpress.org/trunk@28765


git-svn-id: http://core.svn.wordpress.org/trunk@28578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-17 20:19:14 +00:00
Scott Taylor
2bac3b660f In wptexturize(), adjust for the treatment of abbreviated years at the end of quotations.
Silence some unit tests that have never passed and may no longer be applicable.

Props miqrogroove.
Fixes #18549.

Built from https://develop.svn.wordpress.org/trunk@28764


git-svn-id: http://core.svn.wordpress.org/trunk@28577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-17 20:14:15 +00:00
Scott Taylor
3b3fb72ce3 Add unit tests to confirm that --- is properly converted to — by wptexturize() where appropriate.
Props miqrogroove.
Fixes #28483.

Built from https://develop.svn.wordpress.org/trunk@28763


git-svn-id: http://core.svn.wordpress.org/trunk@28576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-17 18:07:14 +00:00
Scott Taylor
f7ac0eed90 Add Unit Tests for i18n and wptexturize(). Don't confuse closing single quotes and apostrophes.
See #27426.

Built from https://develop.svn.wordpress.org/trunk@28762


git-svn-id: http://core.svn.wordpress.org/trunk@28575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-17 17:57:14 +00:00
Scott Taylor
337e5f7ae4 wptexturize() adjustments:
* Only place an apostrophe before a number when it has exactly two digits.
* Never match '99' with the single prime pattern.
* Always assume '99' is an abbreviated year at the end of a quotation.
* Add unit tests.
* Resolves the unit test broken in [28721] for #8775.

See #26850.

Built from https://develop.svn.wordpress.org/trunk@28761


git-svn-id: http://core.svn.wordpress.org/trunk@28574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-17 17:41:15 +00:00
Sergey Biryukov
e85c3deba5 Prevent get_post_class() and get_body_class() from returning duplicate classes.
props Compute.
fixes #28541.
Built from https://develop.svn.wordpress.org/trunk@28760


git-svn-id: http://core.svn.wordpress.org/trunk@28573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-17 15:18:16 +00:00
Sergey Biryukov
c171f2ef77 Fix labels on installation screen.
props avryl.
fixes #28548.
Built from https://develop.svn.wordpress.org/trunk@28759


git-svn-id: http://core.svn.wordpress.org/trunk@28572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-17 14:37:16 +00:00
Lance Willett
005d30e820 Twenty Fourteen: fix masthead behavior in IE when a custom header image is present. Props Kau-Boy, lancewillett. Fixes #27220.
Built from https://develop.svn.wordpress.org/trunk@28758


git-svn-id: http://core.svn.wordpress.org/trunk@28571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-16 18:22:14 +00:00
Dominik Schilling
aa162f365e Twenty Fourteen: Adjust spacing for menu toggle button to avoid overflowing accented characters.
Broken in [28698].

props schoenwaldnils.
fixes #27456.
Built from https://develop.svn.wordpress.org/trunk@28756


git-svn-id: http://core.svn.wordpress.org/trunk@28570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-16 14:01:15 +00:00
Andrew Ozz
5b4943bc6a TinyMCE wpView: fix selecting all of view's "text" in Safari, props avryl, fixes #28088
Built from https://develop.svn.wordpress.org/trunk@28755


git-svn-id: http://core.svn.wordpress.org/trunk@28569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-16 00:12:15 +00:00
Andrew Ozz
84f3e30f7b wpView: improve handling of embed errors/error messages, see #28195
Built from https://develop.svn.wordpress.org/trunk@28754


git-svn-id: http://core.svn.wordpress.org/trunk@28568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-15 22:53:16 +00:00
Sergey Biryukov
16595af731 Correct @return value for term_exists().
props simonwheatley.
fixes #28538.
Built from https://develop.svn.wordpress.org/trunk@28753


git-svn-id: http://core.svn.wordpress.org/trunk@28567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-14 14:57:16 +00:00
Scott Taylor
46a4208f6b Add "edit" mode for [embed] and URL media previews.
See #28532.

Built from https://develop.svn.wordpress.org/trunk@28752


git-svn-id: http://core.svn.wordpress.org/trunk@28566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-13 21:42:15 +00:00
Sergey Biryukov
8c90ebaec7 wpLink: use simpler expressions to detect email address or URL. We are not validating user input here, just suggesting.
see #19992.
Built from https://develop.svn.wordpress.org/trunk@28751


git-svn-id: http://core.svn.wordpress.org/trunk@28565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-13 21:26:15 +00:00
Andrew Ozz
15c902ea3a wpLink: use the proper instance of the editor when looking at the selection. Move the email and URL regexp to variables. See #19992
Built from https://develop.svn.wordpress.org/trunk@28750


git-svn-id: http://core.svn.wordpress.org/trunk@28564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-13 21:14:16 +00:00
Andrew Nacin
aeac3e1654 Add a new 'Beta Testing' tab on the plugin installer, for features as plugins such as Press This.
fixes #28513.

Built from https://develop.svn.wordpress.org/trunk@28749


git-svn-id: http://core.svn.wordpress.org/trunk@28563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-12 18:09:13 +00:00
Andrew Ozz
f88149c370 wpView:
- Don't wrap single-line URLs in [embed]. Use them directly in generating a view.
- If the embedding HTML contains a script, "sandbox" it in an iframe to prevent it from changing the editor DOM.
- Automatically add toolbar and overlay when needed.
- Try to embed single-line URLs only if they are pasted in an empty paragraph.
Props avryl, see #28195
Built from https://develop.svn.wordpress.org/trunk@28748


git-svn-id: http://core.svn.wordpress.org/trunk@28562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-12 02:49:16 +00:00
Scott Taylor
27523183bf Don't use variable variables in touch_time().
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28747


git-svn-id: http://core.svn.wordpress.org/trunk@28561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-11 21:05:16 +00:00
Scott Taylor
69fbe27f48 Don't use variable variables in wp_reset_vars(). Test by searching in list tables, etc.
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28746


git-svn-id: http://core.svn.wordpress.org/trunk@28560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-11 20:00:15 +00:00
Scott Taylor
9a286d75fd Don't use variable variables in user-new.php. Test by causing errors when creating a new user.
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28745


git-svn-id: http://core.svn.wordpress.org/trunk@28559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-11 19:54:13 +00:00
Scott Taylor
fd838ccb2b Don't use variable variables in setup-config.php (Step 2).
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28744


git-svn-id: http://core.svn.wordpress.org/trunk@28558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-11 19:41:14 +00:00
Scott Taylor
f014067f06 OPML:
* Learn how OPML works, cry.
* Remove unused globals in `startElement()`
* Stop using variable variables in `startElement()`

Tested with the OPML importer plugin

See #27881.

Built from https://develop.svn.wordpress.org/trunk@28743


git-svn-id: http://core.svn.wordpress.org/trunk@28557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-11 19:31:15 +00:00
Scott Taylor
812ea43343 Don't use variable variables in wp_dashboard_plugins_output(). Variable variables aren't the worst thing about this function.
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28742


git-svn-id: http://core.svn.wordpress.org/trunk@28556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-11 18:55:14 +00:00
Scott Taylor
43bf7f271f Don't use variable variables in wp_salt().
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28741


git-svn-id: http://core.svn.wordpress.org/trunk@28555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-11 18:36:15 +00:00
Scott Taylor
994ca59abd Don't use variable variables in wp_insert_user().
Add a local array, `$meta`, to provide substantial disambiguation among variables. 

See #27881.

Built from https://develop.svn.wordpress.org/trunk@28740


git-svn-id: http://core.svn.wordpress.org/trunk@28554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-11 18:21:14 +00:00
Scott Taylor
07d4069444 Don't use variable variables in plugins_url().
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28739


git-svn-id: http://core.svn.wordpress.org/trunk@28553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-11 18:18:14 +00:00
Scott Taylor
e5e8a83cf4 Don't use variable variables in WP_Comment_Query::query().
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28738


git-svn-id: http://core.svn.wordpress.org/trunk@28552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-11 17:58:14 +00:00
Scott Taylor
c1e7c2d1de Don't use variable variables in WP_Query::get_posts().
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28737


git-svn-id: http://core.svn.wordpress.org/trunk@28551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-11 17:50:16 +00:00
Scott Taylor
17b17d1c78 Don't use variable variables in get_terms().
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28736


git-svn-id: http://core.svn.wordpress.org/trunk@28550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-11 17:41:14 +00:00
Drew Jaynes
66bcd85529 Improve inline documention for set_transient() and set_site_transient() to specify the 45- and 40-character limits for their respective transient name values.
Props edwin-at-studiojoyo.com for the original patch.
See #15058, #13310. Fixes #28467.

Built from https://develop.svn.wordpress.org/trunk@28735


git-svn-id: http://core.svn.wordpress.org/trunk@28549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-11 16:33:15 +00:00
Scott Taylor
ecf0e4702f Don't use a variable variable in wp_widget_rss_form(). Sidenote: the logic to show hidden fields is bizarre - would result in duplicate fields.
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28734


git-svn-id: http://core.svn.wordpress.org/trunk@28548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-11 16:18:17 +00:00
Scott Taylor
980744f882 In wp_insert_term(), when no slug is provided, check for an existing term by name. If it exists, use that slug instead of calling sanitize_title( $name ).
Prevents creating an endless number of terms like `A+` or `$$$$` in any given taxonomy.

Props wonderboymusic, SergeyBiryukov, aaroncampbell.
Fixes #17689.

Built from https://develop.svn.wordpress.org/trunk@28733


git-svn-id: http://core.svn.wordpress.org/trunk@28547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-11 02:28:14 +00:00
Andrew Ozz
620e6ebe37 Fix the layout of the Image Details modal, props gcorne, see #24716 [28682]
Built from https://develop.svn.wordpress.org/trunk@28732


git-svn-id: http://core.svn.wordpress.org/trunk@28546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-11 00:23:14 +00:00
John Blackbourn
eb62aecbc3 Only include relevant post authors in WXR exports. Fixes #20206. Props jeremyfelt.
Built from https://develop.svn.wordpress.org/trunk@28731


git-svn-id: http://core.svn.wordpress.org/trunk@28545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-10 19:15:13 +00:00
John Blackbourn
03131233e2 Add screen reader labels to the date inputs on the post editing screen. Fixes #25461. Props frank-klein.
Built from https://develop.svn.wordpress.org/trunk@28730


git-svn-id: http://core.svn.wordpress.org/trunk@28544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-10 18:50:14 +00:00
Scott Taylor
0da44fad8e edit.php?post_type=attachment should redirect to upload.php. Without the redirect, the user is presented with an empty list table. There are probably other issues to address overall, but this accomplishes what the ticket wants.
Props knutsp.
Fixes #27951.

Built from https://develop.svn.wordpress.org/trunk@28729


git-svn-id: http://core.svn.wordpress.org/trunk@28543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-10 18:48:15 +00:00
John Blackbourn
2d23c8fea7 A little more abstraction in the WP_oEmbed class. Fixes #24381.
Built from https://develop.svn.wordpress.org/trunk@28728


git-svn-id: http://core.svn.wordpress.org/trunk@28542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-10 18:14:15 +00:00
Scott Taylor
658170b179 In wptexturize(), ensure that texturization does not corrupt contents of HTML elements, HTML comments, and smartcode attributes.
Adds a variety of unit tests/assertions.

Props miqrogroove.
Fixes #12690, #8912, #27602.

Built from https://develop.svn.wordpress.org/trunk@28727


git-svn-id: http://core.svn.wordpress.org/trunk@28541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-10 14:34:13 +00:00
Scott Taylor
4c067bd327 In wptexturize(), allow dashes before and after curly quotes. Example: This is what she said---"Wow that is cool."
Adds unit tests.

Props adamsilverstein, miqrogroove.
Fixes #20342.

Built from https://develop.svn.wordpress.org/trunk@28726


git-svn-id: http://core.svn.wordpress.org/trunk@28540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-10 14:22:15 +00:00
Scott Taylor
3d3c166f11 wptexturize() should handle apostrophes before primes.
Props nacin, miqrogroove.
Fixes #22823.

Built from https://develop.svn.wordpress.org/trunk@28725


git-svn-id: http://core.svn.wordpress.org/trunk@28539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-10 14:14:17 +00:00
Drew Jaynes
5755eaf372 Improve inline documentation for the wp_spaces_regexp filter.
Fixes #27588.

Built from https://develop.svn.wordpress.org/trunk@28724


git-svn-id: http://core.svn.wordpress.org/trunk@28538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-10 06:46:15 +00:00
Drew Jaynes
0290f79eac Add inline documentation for the run_wptexturize filter.
Props miqrogroove for the original patch.
Fixes #19550.

Built from https://develop.svn.wordpress.org/trunk@28723


git-svn-id: http://core.svn.wordpress.org/trunk@28537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-10 06:29:14 +00:00