WordPress/wp-includes
Andrea Fercia 00704114e0 Accessibility: Make the Media modal an ARIA modal dialog.
For a number of years, the Media modal missed an explicit ARIA role and the required attributes for modal dialogs.

This was confusing for assistive technology users, since they may not realize they're inside a dialog, and that consequently the keyboard interactions may be different from the rest of the page. Lack of an explicit label for the dialog was confusing as well, since assistive technology users didn't have an immediate sense of what the dialog is for.

This change makes the Media modal meet the ARIA Authoring Practices recommendations, helping users better understand the purpose and interactions with the modal. Also, it makes sure to hide the rest of the page content from assistive technologies, until support for `aria-modal="true"` improves.

Additionally:
- moves the modal H1 heading to the beginning of the modal content 
- changes the modal left menu position to make visual and DOM order match 
- improves the `wp.media.view.FocusManager` documentation

Fixes #47145.

Built from https://develop.svn.wordpress.org/trunk@45572


git-svn-id: http://core.svn.wordpress.org/trunk@45383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-27 12:33:56 +00:00
..
blocks Accessibility: Remove post format filter links from format icons in the Posts list table. 2019-03-21 15:32:01 +00:00
certificates
css Accessibility: Make the Media modal an ARIA modal dialog. 2019-06-27 12:33:56 +00:00
customize Customize: Remove “Update” link for themes on multisite installs. 2019-06-13 15:31:52 +00:00
fonts Administration: Fix Dashicon backwards compatibility issues. 2019-03-27 19:59:52 +00:00
ID3
images Build: Update images following [43684]. 2018-12-19 03:36:27 +00:00
IXR Date/Time: Replace all instances of date() with gmdate(). 2019-05-26 00:12:54 +00:00
js Accessibility: Make the Media modal an ARIA modal dialog. 2019-06-27 12:33:56 +00:00
pomo Docs: Correct the docs for POMO_Reader::setEndian(). 2019-01-16 05:36:48 +00:00
random_compat
Requests
rest-api REST API: Call WP_REST_Server::get_compact_response_links() and ::get_raw_data() static methods the right way. 2019-06-26 18:07:54 +00:00
SimplePie
sodium_compat Upgrade/Install: Update sodium_compat to v1.10.0. 2019-05-17 10:58:51 +00:00
Text
theme-compat
widgets I18N: Correct encoding for wp-includes/widgets/class-wp-widget-calendar.php, accidentally saved in ANSI instead of UTF-8. 2019-06-05 15:09:53 +00:00
admin-bar.php Accessibility: Remove redundant title attribute from the "Exit Recovery Mode" link. 2019-04-25 16:04:53 +00:00
atomlib.php
author-template.php Users: In wp_list_authors(), check for author's post count before getting author's metadata. 2019-04-17 14:50:50 +00:00
blocks.php Docs: Remove unused @global reference in do_blocks() DocBlock. 2019-05-24 01:05:52 +00:00
bookmark-template.php Date/Time: Replace all instances of date() with gmdate(). 2019-05-26 00:12:54 +00:00
bookmark.php General: Fix problematic string to array parsing. 2019-01-10 21:06:49 +00:00
cache.php Docs: Correct type for WP_Object_Cache::$blog_prefix. 2019-04-11 20:10:53 +00:00
canonical.php Canonical: Ensure redirect query keys are URL encoded. 2019-04-08 01:10:55 +00:00
capabilities.php Site health: Introduce view_site_health_checks capability. 2019-06-10 07:42:52 +00:00
category-template.php Coding Standards: Remove an unnecessary line whitelisting. 2019-01-12 04:53:51 +00:00
category.php
class-feed.php
class-http.php HTTP API: Ensure the http_api_debug hook is fired for all responses. 2019-06-08 17:10:52 +00:00
class-IXR.php
class-json.php Docs: Fix typos in Services_JSON DocBlocks. 2019-06-13 19:19:52 +00:00
class-oembed.php Embeds: Remove the "Supports HTTPS" column from the whitelisted oEmbed provider list now that all supported providers use HTTPS. 2019-05-23 21:23:53 +00:00
class-phpass.php
class-phpmailer.php
class-pop3.php
class-requests.php
class-simplepie.php
class-smtp.php Docs: Correct various spelling mistakes. 2019-03-13 19:32:53 +00:00
class-snoopy.php
class-walker-category-dropdown.php
class-walker-category.php Accessibility: Introduce category_list_link_attributes filter in Walker_Category::start_el() for the HTML attributes applied to a category list item's anchor element. 2019-03-21 10:37:57 +00:00
class-walker-comment.php Comments: Update the message shown when a comment is awaiting moderation. 2019-01-21 22:46:49 +00:00
class-walker-nav-menu.php Menus: Set better default for $args parameter in Walker_Nav_Menu methods, to match the documented parameter type. 2019-06-14 11:26:52 +00:00
class-walker-page-dropdown.php Docs: Correctly specify the $page parameter of list_pages filter as a WP_Post. 2018-12-20 20:04:50 +00:00
class-walker-page.php Menus: Use esc_url() for the href value of page link attributes in Walker_Page::start_el(), for consistency with Walker_Nav_Menu and Walker_Category. 2019-03-21 10:45:51 +00:00
class-wp-admin-bar.php Bootstrap/Load: Introduce a recovery mode for fixing fatal errors. 2019-03-21 21:53:51 +00:00
class-wp-ajax-response.php
class-wp-block-parser.php Block Editor: Update WordPress Packages to solve PHP 5.2.2 parser incompatibility. 2019-02-07 09:02:49 +00:00
class-wp-block-type-registry.php Blocks: Introduce WP_Block_Type and WP_Block_Type_Registry classes. 2018-12-13 09:44:23 +00:00
class-wp-block-type.php REST API: Preserve unknown, respect null in server-side block rendering. 2018-12-17 18:00:52 +00:00
class-wp-comment-query.php Coding Standards: Fix and whitelist variable names. 2019-01-12 06:06:48 +00:00
class-wp-comment.php
class-wp-customize-control.php
class-wp-customize-manager.php I18N: Merge duplicate "Original" strings used in the same context (referring to image size). 2019-06-05 15:23:52 +00:00
class-wp-customize-nav-menus.php I18N: Merge duplicate "Status is forbidden" strings. 2019-05-26 18:47:53 +00:00
class-wp-customize-panel.php
class-wp-customize-section.php
class-wp-customize-setting.php Docs: Correct spelling in various comments and DocBlocks, per the conventions in Core Contributor Handbook. 2019-04-17 13:26:51 +00:00
class-wp-customize-widgets.php Docs: Correct @type annotation for WP_Customize_Widgets properties. 2019-05-26 02:16:52 +00:00
class-wp-dependency.php Docs: Add missing documentation for _WP_Dependency::set_translations(). 2019-01-15 22:48:51 +00:00
class-wp-editor.php TinyMCE: Fix keyboard navigation when the dfw button is present but hidden. Ensure that button is added last in the DOM to match where it appears visually. 2019-04-12 18:08:53 +00:00
class-wp-embed.php
class-wp-error.php Docs: Update since annotations WP_Error::has_errors() 2019-01-09 22:42:51 +00:00
class-wp-fatal-error-handler.php Bootstrap/Load: Prevent PHP errors when a drop-in triggers fatal error protection. 2019-05-15 18:19:51 +00:00
class-wp-feed-cache-transient.php
class-wp-feed-cache.php
class-wp-hook.php Docs: Improve and correct documentation for hook-related variadic functions. 2019-05-25 22:52:54 +00:00
class-wp-http-cookie.php HTTP: Add support for the host-only flag to Wp_Http_Cookie. 2019-04-08 05:32:51 +00:00
class-wp-http-curl.php
class-wp-http-encoding.php
class-wp-http-ixr-client.php
class-wp-http-proxy.php
class-wp-http-requests-hooks.php
class-wp-http-requests-response.php HTTP: Add support for the host-only flag to Wp_Http_Cookie. 2019-04-08 05:32:51 +00:00
class-wp-http-response.php
class-wp-http-streams.php Docs: Update since annotation for new $url parameter for several HTTP related filters. 2019-01-04 21:58:51 +00:00
class-wp-image-editor-gd.php Save progress of intermediate image creation after upload. First run. 2019-06-15 01:02:52 +00:00
class-wp-image-editor-imagick.php Save progress of intermediate image creation after upload. First run. 2019-06-15 01:02:52 +00:00
class-wp-image-editor.php
class-wp-list-util.php
class-wp-locale-switcher.php REST API: Render response in user locale with ?_locale=user. 2018-12-14 01:32:39 +00:00
class-wp-locale.php Bootstrap/Load: Restore $wp_version global check in WP_Locale::init(), previously replaced with get_bloginfo( 'version' ) in [38459]. 2019-03-27 13:27:52 +00:00
class-wp-matchesmapregex.php
class-wp-meta-query.php Docs: Update since annotations for adding LIKE comparisons with meta keys. 2019-01-09 14:55:49 +00:00
class-wp-metadata-lazyloader.php
class-wp-network-query.php Multisite: add new sites_pre_query and networks_pre_query filters to short circuit WP_Site_Query and WP_Network_Query queries. 2019-03-22 17:26:51 +00:00
class-wp-network.php
class-wp-oembed-controller.php Embeds: Filter HTML response in oEmbed proxy controller. 2018-12-14 03:20:37 +00:00
class-wp-paused-extensions-storage.php Bootstrap/Load: Introduce a recovery mode for fixing fatal errors. 2019-03-21 21:53:51 +00:00
class-wp-post-type.php
class-wp-post.php Coding Standards: Use strict comparison in WP_Post where possible. 2019-03-15 21:55:50 +00:00
class-wp-query.php Docs: Improve documentation for the_date() and the_weekday_date(). 2019-05-22 21:48:52 +00:00
class-wp-recovery-mode-cookie-service.php Bootstrap/Load: Set expiration of the recovery mode cookie to the same amount of time for which the token in it is valid: a week by default. 2019-06-17 19:17:54 +00:00
class-wp-recovery-mode-email-service.php I18N: Remove PHP function name from translatable string in WP_Recovery_Mode_Email_Service. 2019-05-26 20:44:52 +00:00
class-wp-recovery-mode-key-service.php Bootstrap/Load: Allow more than one recovery link to be valid at a time. 2019-04-16 05:09:51 +00:00
class-wp-recovery-mode-link-service.php Bootstrap/Load: Allow more than one recovery link to be valid at a time. 2019-04-16 05:09:51 +00:00
class-wp-recovery-mode.php Bootstrap/Load: Return a 403 error code when the recovery mode cookie is invalid or expired, or the exit recovery mode nonce check failed. 2019-06-17 18:37:55 +00:00
class-wp-rewrite.php
class-wp-role.php Docs: Document more parameters and properties using typed array notation. 2018-03-25 19:33:31 +00:00
class-wp-roles.php
class-wp-session-tokens.php Docs: Correct and improve docblocks for user session management functionality. 2018-09-14 13:45:26 +00:00
class-wp-simplepie-file.php
class-wp-simplepie-sanitize-kses.php
class-wp-site-query.php Multisite: add new sites_pre_query and networks_pre_query filters to short circuit WP_Site_Query and WP_Network_Query queries. 2019-03-22 17:26:51 +00:00
class-wp-site.php Docs: Correct spelling in various comments and DocBlocks, per the conventions in Core Contributor Handbook. 2019-04-17 13:26:51 +00:00
class-wp-tax-query.php
class-wp-taxonomy.php Taxonomy: Update @since annotations for meta_box_sanitize_cb arg. 2019-01-09 15:11:48 +00:00
class-wp-term-query.php
class-wp-term.php
class-wp-text-diff-renderer-inline.php
class-wp-text-diff-renderer-table.php Coding Standards: Fix the Squiz.ControlStructures.ControlSignature.SpaceAfterCloseBrace violations. 2019-01-11 06:40:50 +00:00
class-wp-theme.php Themes: Link to an updated documentation on child themes on developer.wordpress.org, instead of Codex. 2019-04-01 11:55:52 +00:00
class-wp-user-meta-session-tokens.php Docs: Add @see WP_Session_Tokens to the WP_User_Meta_Session_Tokens docblock. 2019-01-09 05:04:50 +00:00
class-wp-user-query.php Docs: Correct @since tag for users_pre_query filter added in [44373]. 2019-01-07 07:56:50 +00:00
class-wp-user-request.php Privacy tools: 2019-06-10 23:54:53 +00:00
class-wp-user.php Docs: Standardise documentation for capability-related variadic functions. 2019-05-25 22:27:51 +00:00
class-wp-walker.php
class-wp-widget-factory.php
class-wp-widget.php
class-wp-xmlrpc-server.php XML-RPC: Merge similar translation strings. 2019-06-20 12:53:52 +00:00
class-wp.php Date/Time: Replace all instances of date() with gmdate(). 2019-05-26 00:12:54 +00:00
class.wp-dependencies.php Docs: Document that the $src parameter of WP_Dependencies::add() can be boolean. 2018-09-28 21:51:24 +00:00
class.wp-scripts.php I18N/Script Loader: Support text domains other than "messages". 2019-01-06 16:23:49 +00:00
class.wp-styles.php
comment-template.php I18N: Allow the length of automatically generated excerpts to be localized. 2019-06-08 18:42:52 +00:00
comment.php Date/Time: Replace all instances of date() with gmdate(). 2019-05-26 00:12:54 +00:00
compat.php General: Add sodium_compat library for crypto APIs in PHP < 7.2 2019-03-21 04:56:52 +00:00
cron.php Cron: Ensure identical single events aren't scheduled less than 10min apart. 2019-03-16 06:42:50 +00:00
date.php Date/Time: Replace all instances of date() with gmdate(). 2019-05-26 00:12:54 +00:00
default-constants.php Docs: Adjust comments in wp_initial_constants() to conform to WPCS. 2019-04-15 22:10:52 +00:00
default-filters.php Site health: Introduce view_site_health_checks capability. 2019-06-10 07:42:52 +00:00
default-widgets.php
deprecated.php Date/Time: Replace all instances of date() with gmdate(). 2019-05-26 00:12:54 +00:00
embed-template.php
embed.php CSS Coding Standards: Use unitless values for line-height in wp-includes/css/wp-embed-template.css. 2019-05-30 12:40:52 +00:00
error-protection.php Bootstrap/Load: Introduce a recovery mode for fixing fatal errors. 2019-03-21 21:53:51 +00:00
feed-atom-comments.php Feeds: improve structure and naming of feed build date helper function. 2019-04-18 17:08:52 +00:00
feed-atom.php Feeds: improve structure and naming of feed build date helper function. 2019-04-18 17:08:52 +00:00
feed-rdf.php Feeds: improve structure and naming of feed build date helper function. 2019-04-18 17:08:52 +00:00
feed-rss2-comments.php Feeds: improve structure and naming of feed build date helper function. 2019-04-18 17:08:52 +00:00
feed-rss2.php Feeds: improve structure and naming of feed build date helper function. 2019-04-18 17:08:52 +00:00
feed-rss.php Feeds: improve structure and naming of feed build date helper function. 2019-04-18 17:08:52 +00:00
feed.php Feeds: Ensure a feed’s <lastBuildDate> has the correct date. 2019-05-20 14:43:02 +00:00
formatting.php Formatting: Don't convert smilies in ignored tags that have attributes. 2019-06-27 02:05:52 +00:00
functions.php Date/Time: Add more supported formats to wp_maybe_decline_date(). 2019-06-20 13:47:52 +00:00
functions.wp-scripts.php Docs: Fix incorrect @see notation in wp_localize_script() DocBlock. 2019-05-24 01:02:51 +00:00
functions.wp-styles.php Docs: Fix typo in wp_add_inline_script() and wp_add_inline_style() description. 2018-12-20 02:42:48 +00:00
general-template.php Date/Time: Replace all instances of date() with gmdate(). 2019-05-26 00:12:54 +00:00
http.php
kses.php KSES: Add flex and related long form properties to safe CSS. 2019-05-18 04:34:52 +00:00
l10n.php Docs: Correct @param type for $deprecated and $plugin_rel_path arguments of load_plugin_textdomain(). 2019-04-19 14:21:53 +00:00
link-template.php Date/Time: Replace all instances of date() with gmdate(). 2019-05-26 00:12:54 +00:00
load.php Bootstrap/Load: In wp_get_server_protocol(), check if $_SERVER['SERVER_PROTOCOL'] is defined, to avoid a notice in CLI context. 2019-05-24 01:47:51 +00:00
locale.php
media-template.php Accessibility: Make the Media modal an ARIA modal dialog. 2019-06-27 12:33:56 +00:00
media.php Media: fix support for arrays for the crop setting for registered image sub-sizes in wp_get_registered_image_subsizes(). 2019-06-15 17:17:52 +00:00
meta.php Options, Meta APIs: Ensure the $object_id parameter passed to the delete_{$meta_type}_meta and deleted_{$meta_type}_meta filters is always an integer. 2019-03-28 21:59:52 +00:00
ms-blogs.php Multisite: Do not prime site meta caches unless necessary. 2019-03-18 15:56:51 +00:00
ms-default-constants.php
ms-default-filters.php Multisite: Move site-specific metadata integrations from the wrapper functions to the low-level Meta API functions. 2019-01-08 08:48:48 +00:00
ms-deprecated.php Multisite: Update @since tags for site management APIs. 2019-01-08 08:58:49 +00:00
ms-files.php
ms-functions.php I18N: Improvements to and additions of translator comments for various email subject strings. 2019-04-15 22:39:50 +00:00
ms-load.php Networks and Sites: Use numbered placeholder in a mailto: link in ms_site_check(). 2019-04-11 20:15:52 +00:00
ms-network.php Multisite: Introduce ms-site.php and ms-network.php files. 2019-01-08 09:15:49 +00:00
ms-settings.php
ms-site.php Docs: Add arguments passed by wp_insert_site() to wp_initialize_site(). 2019-04-17 20:57:52 +00:00
nav-menu-template.php Privacy: Introduce Privacy Policy page helpers: 2019-03-21 19:48:50 +00:00
nav-menu.php Nav Menus: Fix a PHP 7.3 error when switching themes. 2018-12-14 05:16:52 +00:00
option.php Administration: Replace one more reference to "articles" with "posts" for greater consistency of terminology. 2019-05-26 18:51:52 +00:00
pluggable-deprecated.php
pluggable.php Users: Pass $length, $special_chars, and $extra_special_chars parameters to the random_password filter in wp_generate_password(). 2019-06-27 00:48:53 +00:00
plugin.php Docs: Correct a function name in the do_action() documentation. 2019-05-25 22:53:51 +00:00
post-formats.php
post-template.php Posts, Post Types: Switch the order of arguments for implode() in the_meta() to match the function notation. 2019-06-05 00:16:54 +00:00
post-thumbnail-template.php Media: Introduce the has_post_thumbnail filter. 2019-01-10 15:28:50 +00:00
post.php Date/Time: Replace all instances of date() with gmdate(). 2019-05-26 00:12:54 +00:00
query.php Privacy: Introduce Privacy Policy page helpers: 2019-03-21 19:48:50 +00:00
registration-functions.php
registration.php
rest-api.php REST API: Call WP_REST_Server::get_compact_response_links() and ::get_raw_data() static methods the right way. 2019-06-26 18:07:54 +00:00
revision.php Posts: Set a HTTP 403 error when an incorrect post preview nonce is sent. 2019-01-16 03:54:50 +00:00
rewrite.php Permalinks: Avoid a PHP notice in wp_resolve_numeric_slug_conflicts() when visiting a day archive with the /%postname%/ permalink structure. 2019-04-16 15:34:52 +00:00
rss-functions.php
rss.php
script-loader.php Bundled Theme: Load Google fonts with display=fallback parameter for better UX in case the font cannot be loaded. 2019-05-31 10:10:54 +00:00
session.php
shortcodes.php
spl-autoload-compat.php
taxonomy.php Taxonomy: In wp_insert_term(), handle an error if writing to the term_taxonomy table fails. 2019-05-17 22:28:51 +00:00
template-loader.php Privacy: Introduce Privacy Policy page helpers: 2019-03-21 19:48:50 +00:00
template.php Docs: Correct @return description for get_privacy_policy_template(). 2019-04-19 13:46:51 +00:00
theme.php Docs: Correct a theme feature name. 2019-05-25 23:46:52 +00:00
update.php General: Update support forum links. 2019-05-25 14:24:50 +00:00
user.php Privacy tools: 2019-06-10 23:54:53 +00:00
vars.php
version.php Accessibility: Make the Media modal an ARIA modal dialog. 2019-06-27 12:33:56 +00:00
widgets.php Docs: Improve docs for variadic functions relating to widgets and their controls. 2019-05-26 22:05:51 +00:00
wlwmanifest.xml
wp-db.php Docs: Correct @type annotation for wpdb::$last_query. 2019-05-26 02:30:51 +00:00
wp-diff.php