mirror of
https://github.com/WordPress/WordPress.git
synced 2025-02-25 08:51:56 +01:00
9546303342
When a customizer construct (panel, section, control) is not added in PHP, the JS has interpreted this to mean that a given construct should be deactivated (because it is gone). This is problematic for dynamically-created constructs in JS, as it has meant that the construct would also have to be created in PHP to ensure the `active` callback is called, or else a hack would be required to add a `construct.active.validate = function() { return true };` to forcibly prevent the construct from getting deactivated.
These workarounds can be eliminated by treating constructs differently when they are created dynamically in JS (after page load) as opposed to being created statically in PHP (on the server). Namely, if a construct is dynamically-created then its absence in a preview refresh should not signal that the construct should be deactivated. Rather, a dynamic construct should only have its activation state toggled if it has a corresponding construct created in PHP when the preview refreshes to explicitly indicate its `active` state. Otherwise, the management of the `active` state for a construct created in JS should also be the responsibility of client-side code.
Props westonruter, sayedwp.
Fixes #37270.
Built from https://develop.svn.wordpress.org/trunk@38464
git-svn-id: http://core.svn.wordpress.org/trunk@38405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
||
|---|---|---|
| .. | ||
| accordion.js | ||
| accordion.min.js | ||
| bookmarklet.js | ||
| bookmarklet.min.js | ||
| color-picker.js | ||
| color-picker.min.js | ||
| comment.js | ||
| comment.min.js | ||
| common.js | ||
| common.min.js | ||
| custom-background.js | ||
| custom-background.min.js | ||
| custom-header.js | ||
| customize-controls.js | ||
| customize-controls.min.js | ||
| customize-nav-menus.js | ||
| customize-nav-menus.min.js | ||
| customize-widgets.js | ||
| customize-widgets.min.js | ||
| dashboard.js | ||
| dashboard.min.js | ||
| edit-comments.js | ||
| edit-comments.min.js | ||
| editor-expand.js | ||
| editor-expand.min.js | ||
| editor.js | ||
| editor.min.js | ||
| farbtastic.js | ||
| gallery.js | ||
| gallery.min.js | ||
| image-edit.js | ||
| image-edit.min.js | ||
| inline-edit-post.js | ||
| inline-edit-post.min.js | ||
| inline-edit-tax.js | ||
| inline-edit-tax.min.js | ||
| iris.min.js | ||
| language-chooser.js | ||
| language-chooser.min.js | ||
| link.js | ||
| link.min.js | ||
| media-gallery.js | ||
| media-gallery.min.js | ||
| media-upload.js | ||
| media-upload.min.js | ||
| media.js | ||
| media.min.js | ||
| nav-menu.js | ||
| nav-menu.min.js | ||
| password-strength-meter.js | ||
| password-strength-meter.min.js | ||
| plugin-install.js | ||
| plugin-install.min.js | ||
| post.js | ||
| post.min.js | ||
| postbox.js | ||
| postbox.min.js | ||
| press-this.js | ||
| press-this.min.js | ||
| revisions.js | ||
| revisions.min.js | ||
| set-post-thumbnail.js | ||
| set-post-thumbnail.min.js | ||
| svg-painter.js | ||
| svg-painter.min.js | ||
| tags-box.js | ||
| tags-box.min.js | ||
| tags.js | ||
| tags.min.js | ||
| theme.js | ||
| theme.min.js | ||
| updates.js | ||
| updates.min.js | ||
| user-profile.js | ||
| user-profile.min.js | ||
| user-suggest.js | ||
| user-suggest.min.js | ||
| widgets.js | ||
| widgets.min.js | ||
| word-count.js | ||
| word-count.min.js | ||
| wp-fullscreen-stub.js | ||
| wp-fullscreen-stub.min.js | ||
| xfn.js | ||
| xfn.min.js | ||