mirror of
https://github.com/WordPress/WordPress.git
synced 2024-08-21 05:12:59 +02:00
Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0. There are a number of ways to mitigate this: * If it is an accidental typo for a declared property: fix the typo. * For known properties: declare them on the class. * For unknown properties: add the magic `__get()`, `__set()`, et al. methods to the class or let the class extend `stdClass` which has highly optimized versions of these magic methods built in. * For unknown ''use'' of dynamic properties, the `#[AllowDynamicProperties]` attribute can be added to the class. The attribute will automatically be inherited by child classes. Trac ticket #56034 is open to investigate and handle the third and fourth type of situations, however it has become clear this will need more time and will not be ready in time for WP 6.1. To reduce “noise” in the meantime, both in the error logs of WP users moving onto PHP 8.2, in the test run logs of WP itself, in test runs of plugins and themes, as well as to prevent duplicate tickets from being opened for the same issue, this commit adds the `#[AllowDynamicProperties]` attribute to all “parent” classes in WP. The logic used for this commit is as follows: * If a class already has the attribute: no action needed. * If a class does not `extend`: add the attribute. * If a class does `extend`: - If it extends `stdClass`: no action needed (as `stdClass` supports dynamic properties). - If it extends a PHP native class: add the attribute. - If it extends a class from one of WP's external dependencies: add the attribute. * In all other cases: no action — the attribute should not be needed as child classes inherit from the parent. Whether or not a class contains magic methods has not been taken into account, as a review of the currently existing magic methods has shown that those are generally not sturdy enough and often even set dynamic properties (which they should not). See the [https://www.youtube.com/watch?v=vDZWepDQQVE live stream from August 16, 2022] for more details. This commit only affects classes in the `src` directory of WordPress core. * Tests should not get this attribute, but should be fixed to not use dynamic properties instead. Patches for this are already being committed under ticket #56033. * While a number bundled themes (2014, 2019, 2020, 2021) contain classes, they are not a part of this commit and may be updated separately. Reference: [https://wiki.php.net/rfc/deprecate_dynamic_properties PHP RFC: Deprecate dynamic properties]. Follow-up to [53922]. Props jrf, hellofromTonya, markjaquith, peterwilsoncc, costdev, knutsp, aristath. See #56513, #56034. Built from https://develop.svn.wordpress.org/trunk@54133 git-svn-id: http://core.svn.wordpress.org/trunk@53692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
131 lines
3.4 KiB
PHP
131 lines
3.4 KiB
PHP
<?php
|
|
/**
|
|
* Error Protection API: WP_Recovery_Mode_Link_Handler class
|
|
*
|
|
* @package WordPress
|
|
* @since 5.2.0
|
|
*/
|
|
|
|
/**
|
|
* Core class used to generate and handle recovery mode links.
|
|
*
|
|
* @since 5.2.0
|
|
*/
|
|
#[AllowDynamicProperties]
|
|
class WP_Recovery_Mode_Link_Service {
|
|
const LOGIN_ACTION_ENTER = 'enter_recovery_mode';
|
|
const LOGIN_ACTION_ENTERED = 'entered_recovery_mode';
|
|
|
|
/**
|
|
* Service to generate and validate recovery mode keys.
|
|
*
|
|
* @since 5.2.0
|
|
* @var WP_Recovery_Mode_Key_Service
|
|
*/
|
|
private $key_service;
|
|
|
|
/**
|
|
* Service to handle cookies.
|
|
*
|
|
* @since 5.2.0
|
|
* @var WP_Recovery_Mode_Cookie_Service
|
|
*/
|
|
private $cookie_service;
|
|
|
|
/**
|
|
* WP_Recovery_Mode_Link_Service constructor.
|
|
*
|
|
* @since 5.2.0
|
|
*
|
|
* @param WP_Recovery_Mode_Cookie_Service $cookie_service Service to handle setting the recovery mode cookie.
|
|
* @param WP_Recovery_Mode_Key_Service $key_service Service to handle generating recovery mode keys.
|
|
*/
|
|
public function __construct( WP_Recovery_Mode_Cookie_Service $cookie_service, WP_Recovery_Mode_Key_Service $key_service ) {
|
|
$this->cookie_service = $cookie_service;
|
|
$this->key_service = $key_service;
|
|
}
|
|
|
|
/**
|
|
* Generates a URL to begin recovery mode.
|
|
*
|
|
* Only one recovery mode URL can may be valid at the same time.
|
|
*
|
|
* @since 5.2.0
|
|
*
|
|
* @return string Generated URL.
|
|
*/
|
|
public function generate_url() {
|
|
$token = $this->key_service->generate_recovery_mode_token();
|
|
$key = $this->key_service->generate_and_store_recovery_mode_key( $token );
|
|
|
|
return $this->get_recovery_mode_begin_url( $token, $key );
|
|
}
|
|
|
|
/**
|
|
* Enters recovery mode when the user hits wp-login.php with a valid recovery mode link.
|
|
*
|
|
* @since 5.2.0
|
|
*
|
|
* @global string $pagenow The filename of the current screen.
|
|
*
|
|
* @param int $ttl Number of seconds the link should be valid for.
|
|
*/
|
|
public function handle_begin_link( $ttl ) {
|
|
if ( ! isset( $GLOBALS['pagenow'] ) || 'wp-login.php' !== $GLOBALS['pagenow'] ) {
|
|
return;
|
|
}
|
|
|
|
if ( ! isset( $_GET['action'], $_GET['rm_token'], $_GET['rm_key'] ) || self::LOGIN_ACTION_ENTER !== $_GET['action'] ) {
|
|
return;
|
|
}
|
|
|
|
if ( ! function_exists( 'wp_generate_password' ) ) {
|
|
require_once ABSPATH . WPINC . '/pluggable.php';
|
|
}
|
|
|
|
$validated = $this->key_service->validate_recovery_mode_key( $_GET['rm_token'], $_GET['rm_key'], $ttl );
|
|
|
|
if ( is_wp_error( $validated ) ) {
|
|
wp_die( $validated, '' );
|
|
}
|
|
|
|
$this->cookie_service->set_cookie();
|
|
|
|
$url = add_query_arg( 'action', self::LOGIN_ACTION_ENTERED, wp_login_url() );
|
|
wp_redirect( $url );
|
|
die;
|
|
}
|
|
|
|
/**
|
|
* Gets a URL to begin recovery mode.
|
|
*
|
|
* @since 5.2.0
|
|
*
|
|
* @param string $token Recovery Mode token created by {@see generate_recovery_mode_token()}.
|
|
* @param string $key Recovery Mode key created by {@see generate_and_store_recovery_mode_key()}.
|
|
* @return string Recovery mode begin URL.
|
|
*/
|
|
private function get_recovery_mode_begin_url( $token, $key ) {
|
|
|
|
$url = add_query_arg(
|
|
array(
|
|
'action' => self::LOGIN_ACTION_ENTER,
|
|
'rm_token' => $token,
|
|
'rm_key' => $key,
|
|
),
|
|
wp_login_url()
|
|
);
|
|
|
|
/**
|
|
* Filters the URL to begin recovery mode.
|
|
*
|
|
* @since 5.2.0
|
|
*
|
|
* @param string $url The generated recovery mode begin URL.
|
|
* @param string $token The token used to identify the key.
|
|
* @param string $key The recovery mode key.
|
|
*/
|
|
return apply_filters( 'recovery_mode_begin_url', $url, $token, $key );
|
|
}
|
|
}
|