WordPress/wp-admin/includes
Boone Gorges 0e7c1d3b14 Use wp_installing() instead of WP_INSTALLING constant.
The `WP_INSTALLING` constant is a flag that WordPress sets in a number of
places, telling the system that options should be fetched directly from the
database instead of from the cache, that WP should not ping wordpress.org for
updates, that the normal "not installed" checks should be bypassed, and so on.

A constant is generally necessary for this purpose, because the flag is
typically set before the WP bootstrap, meaning that WP functions are not yet
available.  However, it is possible - notably, during `wpmu_create_blog()` -
for the "installing" flag to be set after WP has already loaded. In these
cases, `WP_INSTALLING` would be set for the remainder of the process, since
there's no way to change a constant once it's defined. This, in turn, polluted
later function calls that ought to have been outside the scope of site
creation, particularly the non-caching of option data. The problem was
particularly evident in the case of the automated tests, where `WP_INSTALLING`
was set the first time a site was created, and remained set for the rest of the
suite.

The new `wp_installing()` function allows developers to fetch the current
installation status (when called without any arguments) or to set the
installation status (when called with a boolean `true` or `false`). Use of
the `WP_INSTALLING` constant is still supported; `wp_installing()` will default
to `true` if the constant is defined during the bootstrap.

Props boonebgorges, jeremyfelt.
See #31130.
Built from https://develop.svn.wordpress.org/trunk@34828


git-svn-id: http://core.svn.wordpress.org/trunk@34793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-05 15:06:28 +00:00
..
admin-filters.php Move media hooks out of admin-filters.php as sometimes editors are used on the front end. 2015-08-06 20:40:26 +00:00
admin.php Move WP_Screen to its own file. 2015-09-15 04:08:24 +00:00
ajax-actions.php MS: Use *_network_option() functions throughout core. 2015-10-02 19:08:26 +00:00
bookmark.php Provide more helpful feedback than just "Cheatin' uh?" for permission errors in wp-admin/includes/bookmark.php. 2015-09-03 08:59:24 +00:00
class-ftp-pure.php Updates: FTP/PemFTP Library: Remove the usage of deprecated regular expression functions (ereg replaced by PCRE). 2015-09-18 08:20:27 +00:00
class-ftp-sockets.php Updates: FTP/PemFTP Library: Remove the usage of deprecated regular expression functions (ereg replaced by PCRE). 2015-09-18 08:20:27 +00:00
class-ftp.php Updates: FTP: Add a missing PCRE modifer in [34281]. 2015-09-18 08:23:25 +00:00
class-pclzip.php Deprecate php4 style constructors 2015-06-28 15:27:24 +00:00
class-walker-category-checklist.php Docs: Clarify the file header summary for wp-admin/includes/class-walker-category-checklist.php, introduced in [34241]. 2015-09-22 14:33:48 +00:00
class-walker-nav-menu-checklist.php Move the admin Nav Menu Walker subclasses into their own files. Load in nav-menu.php to remain BC. 2015-09-15 04:02:25 +00:00
class-walker-nav-menu-edit.php Move the admin Nav Menu Walker subclasses into their own files. Load in nav-menu.php to remain BC. 2015-09-15 04:02:25 +00:00
class-wp-comments-list-table.php Comments List Table: fix the translators comment for all count after [34506]. 2015-09-24 18:40:24 +00:00
class-wp-filesystem-base.php Add @access docs to class-wp-filesystem-* files. 2015-09-10 01:21:24 +00:00
class-wp-filesystem-direct.php Add @access docs to class-wp-filesystem-* files. 2015-09-10 01:21:24 +00:00
class-wp-filesystem-ftpext.php Updates: Try a more compatible method to detect if a file exists when using the FTP Extension. 2015-10-01 05:09:25 +00:00
class-wp-filesystem-ftpsockets.php Docs: Add a summary, version, and parameter and return descriptions to the DocBlock for WP_Filesystem_ftpsockets::get_contents(). 2015-09-24 14:22:24 +00:00
class-wp-filesystem-ssh2.php Updates: SSH2 Transport: Add a connection error when the SFTP subsystem cannot be initialized. 2015-10-01 05:43:25 +00:00
class-wp-importer.php Remove unnecessary feedback message from WP_Importer::is_user_over_quota(). 2015-06-30 20:32:25 +00:00
class-wp-internal-pointers.php Docs: Clarify the file header summary for wp-admin/includes/class-wp-internal-pointers.php, introduced in [34241]. 2015-09-22 14:35:25 +00:00
class-wp-links-list-table.php List Tables: 2015-07-14 17:47:24 +00:00
class-wp-list-table.php Post List Table: Ensure that edit.php with no query string produces the proper markup and links in the date column header. 2015-10-01 02:10:25 +00:00
class-wp-media-list-table.php Remove some unused globals and/or their docs. 2015-09-22 20:27:25 +00:00
class-wp-ms-sites-list-table.php MS: Remove registration of ID column in Sites and Users list tables. 2015-10-01 20:58:24 +00:00
class-wp-ms-themes-list-table.php List Tables: when comparing string literals (non-numeric in nature) against vars, strict comparison can/should be used. 2015-09-22 06:06:25 +00:00
class-wp-ms-users-list-table.php Users: Don't pass the current WP_Users_List_Table or WP_MS_Users_List_Table instance to the users_list_table_query_args filter after all. 2015-10-03 21:49:24 +00:00
class-wp-plugin-install-list-table.php Plugins: on the Install page, move the name of each plugin into the <h4> to accommodate screen readers. 2015-10-02 04:16:27 +00:00
class-wp-plugins-list-table.php Remove the unnecessary dynamic prefix used in the plugin_action_links filter name, and in those of its brethren. This way, network_admin_plugin_action_links gets listed as a separate filter. 2015-10-02 23:44:26 +00:00
class-wp-post-comments-list-table.php Docs: Clarify the file header summary for wp-admin/includes/class-wp-post-comments-list-table.php, introduced in [34223]. 2015-09-22 14:31:24 +00:00
class-wp-posts-list-table.php Post List Table: Ensure that edit.php with no query string produces the proper markup and links in the date column header. 2015-10-01 02:10:25 +00:00
class-wp-press-this.php Press This: Make the regular expressions for matching images easier to read by not requiring escaping. 2015-10-01 05:16:25 +00:00
class-wp-screen.php Docs: Clarify the class DocBlock summary for WP_Screen. 2015-09-22 14:28:24 +00:00
class-wp-site-icon.php Don't ever use the guid value when retrieving URLs for media, use wp_get_attachment_url(). Use get_attached_file() for path to file. 2015-09-15 02:50:25 +00:00
class-wp-terms-list-table.php List Tables: when comparing string literals (non-numeric in nature) against vars, strict comparison can/should be used. 2015-09-22 06:06:25 +00:00
class-wp-theme-install-list-table.php List Tables: when comparing string literals (non-numeric in nature) against vars, strict comparison can/should be used. 2015-09-22 06:06:25 +00:00
class-wp-themes-list-table.php MS: Use *_network_option() functions throughout core. 2015-10-02 19:08:26 +00:00
class-wp-upgrader-skins.php Upgrader: Avoid using an HTML tag in a translation string, add translator comments. 2015-09-20 08:59:24 +00:00
class-wp-upgrader.php Use wp_installing() instead of WP_INSTALLING constant. 2015-10-05 15:06:28 +00:00
class-wp-users-list-table.php Users: Don't pass the current WP_Users_List_Table or WP_MS_Users_List_Table instance to the users_list_table_query_args filter after all. 2015-10-03 21:49:24 +00:00
comment.php Allow comment_exists() to match based on GMT date. 2015-09-23 18:16:26 +00:00
continents-cities.php
credits.php Move ad hoc functions from wp-admin/credits.php to wp-admin/includes/credits.php, which is only included by the former. 2015-09-11 04:55:26 +00:00
dashboard.php Switch the remaining user-facing links to wordpress.org over to HTTPS. 2015-10-02 22:46:28 +00:00
deprecated.php Docs: Add missing method summaries for the deprecated WP_User_Search class, including prepare_query(), query(), prepare_vars_for_template_usage(), do_paging(), and get_results(). 2015-10-05 02:35:25 +00:00
edit-tag-messages.php Don't redirect to the Term list table after submitting the form on the Edit Term page. 2015-09-15 15:59:42 +00:00
export.php Export: Add late-escaping to the contents of several nodes to avoid creating invalid XML and XML parse errors. 2015-09-19 18:53:25 +00:00
file.php Use wp_installing() instead of WP_INSTALLING constant. 2015-10-05 15:06:28 +00:00
image-edit.php Docs: Put "it's" in its place (again). 2015-09-16 12:46:28 +00:00
image.php After [34374], ensure that $iptc is defined. 2015-09-22 04:49:24 +00:00
import.php callback is not a valid type in PHP, PSR-5, or phpDocumentor. callable should be used instead. 2015-09-25 23:58:25 +00:00
list-table.php Comments: Fix a fatal error in Comments meta box after [34223]. 2015-09-16 11:37:25 +00:00
media.php Docs: Add missing DocBlock summaries for a multitude of functions in wp-admin/includes/media.php. 2015-10-05 02:44:25 +00:00
menu.php Don't loosely compare functions that return bool against a literal bool. 2015-06-12 17:19:27 +00:00
meta-boxes.php callback is not a valid type in PHP, PSR-5, or phpDocumentor. callable should be used instead. 2015-09-25 23:58:25 +00:00
misc.php Use wp_installing() instead of WP_INSTALLING constant. 2015-10-05 15:06:28 +00:00
ms-admin-filters.php Cleanup (ms-)?admin-filters.php 2015-06-19 21:18:25 +00:00
ms-deprecated.php Docs: Standardize @deprecated tag formatting for deprecated functions in wp-admin/includes/ms-deprecated.php. 2015-08-20 22:26:24 +00:00
ms.php MS: Use *_network_option() functions throughout core. 2015-10-02 19:08:26 +00:00
nav-menu.php Docs: Add a file header to wp-admin/includes/nav-menus.php. 2015-09-22 14:27:24 +00:00
network.php MS: Use *_network_option() functions throughout core. 2015-10-02 19:08:26 +00:00
noop.php Create a new file, wp-admin/includes/noop.php, which loads all of the noop functions for load-script|styles.php and is only loaded by those files. DRYs in the process. 2015-09-11 05:04:23 +00:00
options.php Move ad hoc Options functions to wp-admin/includes/options.php: 2015-09-10 21:45:24 +00:00
plugin-install.php Docs: Also clarify the expected element types depending on the value of $action in the hook doc for the plugins_api filter. 2015-10-02 04:52:25 +00:00
plugin.php Docs: Add missing DocBlock summaries to three functions in wp-admin/includes/plugin.php. 2015-10-05 02:55:24 +00:00
post.php Post List Table: Ensure that edit.php with no query string produces the proper markup and links in the date column header. 2015-10-01 02:10:25 +00:00
revision.php Revisions: add a 'wp_prepare_revision_for_js' filter. 2015-09-25 14:04:24 +00:00
schema.php MS: Use *_network_option() functions throughout core. 2015-10-02 19:08:26 +00:00
screen.php Move WP_Screen to its own file. 2015-09-15 04:08:24 +00:00
taxonomy.php Docs: There are quite alot of typos in core inline comments. 2015-09-30 04:13:48 +00:00
template-functions.php Docs: Add missing DocBlock summaries for five functions in wp-admin/includes/template-functions.php. 2015-10-05 03:03:25 +00:00
template.php wp-admin/includes/template.php is now a loader for 3 files made via svn cp: 2015-09-16 15:35:23 +00:00
theme-install.php Add doc blocks to functions that are missing them. 2015-05-31 03:18:25 +00:00
theme.php Docs: Improve the hook documentation for the themes_api filter. 2015-09-27 23:01:24 +00:00
translation-install.php Use wp_installing() instead of WP_INSTALLING constant. 2015-10-05 15:06:28 +00:00
update-core.php MS: Use *_network_option() functions throughout core. 2015-10-02 19:08:26 +00:00
update.php MS: Use *_network_option() functions throughout core. 2015-10-02 19:08:26 +00:00
upgrade.php MS: Use *_network_option() functions throughout core. 2015-10-02 19:08:26 +00:00
user.php Pinking shears. 2015-09-25 04:44:25 +00:00
widgets.php Docs: Add a missing DocBlock summary for wp_list_widget_controls_dynamic_sidebar(). 2015-10-05 03:06:24 +00:00