WordPress/wp-includes
Boone Gorges 0e7c1d3b14 Use wp_installing() instead of WP_INSTALLING constant.
The `WP_INSTALLING` constant is a flag that WordPress sets in a number of
places, telling the system that options should be fetched directly from the
database instead of from the cache, that WP should not ping wordpress.org for
updates, that the normal "not installed" checks should be bypassed, and so on.

A constant is generally necessary for this purpose, because the flag is
typically set before the WP bootstrap, meaning that WP functions are not yet
available.  However, it is possible - notably, during `wpmu_create_blog()` -
for the "installing" flag to be set after WP has already loaded. In these
cases, `WP_INSTALLING` would be set for the remainder of the process, since
there's no way to change a constant once it's defined. This, in turn, polluted
later function calls that ought to have been outside the scope of site
creation, particularly the non-caching of option data. The problem was
particularly evident in the case of the automated tests, where `WP_INSTALLING`
was set the first time a site was created, and remained set for the rest of the
suite.

The new `wp_installing()` function allows developers to fetch the current
installation status (when called without any arguments) or to set the
installation status (when called with a boolean `true` or `false`). Use of
the `WP_INSTALLING` constant is still supported; `wp_installing()` will default
to `true` if the constant is defined during the bootstrap.

Props boonebgorges, jeremyfelt.
See #31130.
Built from https://develop.svn.wordpress.org/trunk@34828


git-svn-id: http://core.svn.wordpress.org/trunk@34793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-05 15:06:28 +00:00
..
certificates HTTP: Update the Root Certificate bundle. 2015-09-18 08:43:26 +00:00
css Update links to the user profile editing screen in the admin toolbar when the current logged in user has no role on the current site. Covers single site and Multisite and introduces tests. 2015-09-14 17:10:26 +00:00
fonts
ID3
images
js MediaElement, update wp-mediaelement.js: 2015-09-20 03:17:24 +00:00
pomo Pass false as the 2nd argument to class_exists() to disable autoloading and to not cause problems for those who define __autoload(). 2015-09-20 03:52:25 +00:00
SimplePie callback is not a valid type in PHP, PSR-5, or phpDocumentor. callable should be used instead. 2015-09-25 23:58:25 +00:00
Text
theme-compat Theme Compat: Remove two strings from comments-popup.php. 2015-09-20 08:49:27 +00:00
widgets RSS Widget: add a class, rss-widget-icon, to the RSS icon to allow devs to hide it. Not going to remove to not break visual BC. 2015-09-29 04:32:25 +00:00
admin-bar.php Pass false as the 2nd argument to class_exists() to disable autoloading and to not cause problems for those who define __autoload(). 2015-09-20 03:52:25 +00:00
atomlib.php
author-template.php Introduce get_the_author_posts_link(), which returns the HTML link to the author page for the current post's author. 2015-09-29 01:49:25 +00:00
bookmark-template.php
bookmark.php
cache.php Docs: Improve documentation for the WP_Object_Cache class. 2015-09-16 10:03:26 +00:00
canonical.php Canonical: remove unused code (commented-out) from redirect_canonical(). 2015-10-01 05:09:50 +00:00
capabilities-functions.php MS: Use *_network_option() functions throughout core. 2015-10-02 19:08:26 +00:00
capabilities.php Docs: The Users subpackage is plural. 2015-09-22 13:46:25 +00:00
category-functions.php Docs: Clarify the file header summary and subpackage for wp-includes/category-functions.php, introduced in [34110]. 2015-09-22 14:21:23 +00:00
category-template.php Fix 'exclude_tree' in wp_list_categories(). 2015-09-29 19:12:27 +00:00
category.php Docs: Clarify the file header for wp-includes/category.php. 2015-09-22 14:20:24 +00:00
class-feed.php Pass false as the 2nd argument to class_exists() to disable autoloading and to not cause problems for those who define __autoload(). 2015-09-20 03:52:25 +00:00
class-http.php Docs: object != class 2015-09-26 07:04:28 +00:00
class-IXR.php XML-RPC: IXR_Server::output() is notoriously bad at returning the right value for the Content-Length HTTP header. This header is not required, so we will remove it. 2015-09-26 03:11:24 +00:00
class-json.php Docs: Put "it's" in its place (again). 2015-09-16 12:46:28 +00:00
class-oembed.php Add VideoPress as a trusted oEmbed provider. 2015-10-02 23:20:28 +00:00
class-phpass.php
class-phpmailer.php
class-pop3.php Docs: Put "it's" in its place (again). 2015-09-16 12:46:28 +00:00
class-simplepie.php Pass false as the 2nd argument to class_exists() to disable autoloading and to not cause problems for those who define __autoload(). 2015-09-20 03:52:25 +00:00
class-smtp.php
class-snoopy.php Pass false as the 2nd argument to class_exists() to disable autoloading and to not cause problems for those who define __autoload(). 2015-09-20 03:52:25 +00:00
class-walker-category-dropdown.php Docs: Clarify the file header for wp-includes/class-walker-category-dropdown.php, introduced in [34110]. 2015-09-22 14:03:25 +00:00
class-walker-category.php Docs: Clarify the file header summary for wp-includes/class-walker-category.php, introduced in [34110]. 2015-09-22 14:01:25 +00:00
class-walker-comment.php Docs: The Comment API is singular. 2015-09-22 13:43:25 +00:00
class-walker-page-dropdown.php Docs: Clarify the file header subpackage for wp-includes/class-walker-page-dropdown.php, introduced in [34109]. 2015-09-22 13:58:24 +00:00
class-walker-page.php Docs: Actually, the subpackage for Walker_Page should be Template. 2015-09-22 15:09:24 +00:00
class-wp-admin-bar.php
class-wp-ajax-response.php
class-wp-comment-query.php Prevent extra db queries in WP_Comment::get_children(). 2015-10-01 03:58:23 +00:00
class-wp-comment.php Prevent extra db queries in WP_Comment::get_children(). 2015-10-01 03:58:23 +00:00
class-wp-customize-control.php Customizer: make "Current header" clickable in the same way that "Background Image" is - will open the media modal. 2015-09-29 21:40:24 +00:00
class-wp-customize-manager.php Customize: Flesh out phpdoc for WP_Customize_Manager. 2015-09-19 06:40:26 +00:00
class-wp-customize-nav-menus.php Customizer: Use the plural label for available menu item types. 2015-09-24 09:16:25 +00:00
class-wp-customize-panel.php Customize: Remove redundant aria-label attributes. 2015-09-13 06:16:26 +00:00
class-wp-customize-section.php
class-wp-customize-setting.php
class-wp-customize-widgets.php Customizer: Defer embedding widget controls to improve DOM performance and initial load time. 2015-09-25 21:02:27 +00:00
class-wp-editor.php Docs: There are quite alot of typos in core inline comments. 2015-09-30 04:13:48 +00:00
class-wp-embed.php
class-wp-error.php
class-wp-http-cookie.php Docs: object != class 2015-09-26 07:04:28 +00:00
class-wp-http-curl.php Don't set CURLOPT_CAINFO when sslverify is false when sending HTTP API requests through cURL. This avoids sending redundant information to cURL, and avoids a bug in Apple's SecureTransport library which causes a request to fail when a CA bundle is set but certificate verification is disabled. 2015-09-27 21:37:24 +00:00
class-wp-http-encoding.php
class-wp-http-ixr-client.php Docs: Update the hook doc summary for the wp_http_ixr_client_headers filter, introduced in [34164]. 2015-09-15 16:16:43 +00:00
class-wp-http-proxy.php
class-wp-http-streams.php Docs: object != class 2015-09-26 07:04:28 +00:00
class-wp-image-editor-gd.php
class-wp-image-editor-imagick.php Pass false as the 2nd argument to class_exists() to disable autoloading and to not cause problems for those who define __autoload(). 2015-09-20 03:52:25 +00:00
class-wp-image-editor.php
class-wp-meta-query.php Docs: Add a file header to wp-includes/class-wp-meta-query.php, introduced in [33761]. 2015-09-22 13:26:23 +00:00
class-wp-network.php MS: Populate site_name property in a new WP_Network. 2015-10-04 20:51:25 +00:00
class-wp-post.php Docs: Add a file header to wp-includes/class-wp-post.php, introduced in [33759]. 2015-09-22 13:10:24 +00:00
class-wp-rewrite.php Rewrite: allow add_rewrite_rule|WP_Rewrite::add_rule() to accept an associative array for the value of $redirect instead of requiring a query string. 2015-09-30 01:11:25 +00:00
class-wp-role.php Docs: The Users subpackage is plural. 2015-09-22 13:46:25 +00:00
class-wp-roles.php Docs: The Users subpackage is plural. 2015-09-22 13:46:25 +00:00
class-wp-tax-query.php Docs: Add a file header to wp-includes/class-wp-tax-query.php, introduced in [33760]. 2015-09-22 13:16:30 +00:00
class-wp-theme.php MS: Use *_network_option() functions throughout core. 2015-10-02 19:08:26 +00:00
class-wp-user-query.php Ensure that WP_User_Query vars are filled after 'pre_get_users'. 2015-10-03 18:45:25 +00:00
class-wp-user.php Users: in WP_User::__unset(), don't reset the deprecated prop id to ID. Still throw the deprecated notice. 2015-09-24 00:49:25 +00:00
class-wp-walker.php Docs: Add missing parameter and return descriptions for Walker::get_number_of_root_elements(). 2015-09-14 15:33:27 +00:00
class-wp-widget-factory.php Docs: The Widgets subpackage is plural. 2015-09-22 13:48:25 +00:00
class-wp-widget.php Docs: Fix the placement and ordering of some @since tags following [34780]. 2015-10-02 20:50:25 +00:00
class-wp-xmlrpc-server.php Merge some strings with the same meaning in wp-includes/class-wp-xmlrpc-server.php. 2015-10-03 14:09:43 +00:00
class-wp.php Docs: Fix some syntatical issues in the DocBlock for WP::send_headers() following [34632]. 2015-09-27 18:49:29 +00:00
class.wp-dependencies.php
class.wp-scripts.php
class.wp-styles.php
comment-functions.php Rechristen the get_page_of_comment filter. 2015-10-03 22:43:27 +00:00
comment-template.php Remove dead code added to get_comment_link() in [34735]. 2015-10-03 01:27:24 +00:00
comment.php Docs: The Comment API is singular. 2015-09-22 13:44:25 +00:00
compat.php
cron.php Cron: In spawn_cron(), when using ALTERNATE_WP_CRON, return early for any non-GET, instead of naively checking ! empty( $_POST ). 2015-09-26 04:51:26 +00:00
date.php
default-constants.php MS: Use *_network_option() functions throughout core. 2015-10-02 19:08:26 +00:00
default-filters.php Improve lazyloading of comment meta in WP_Query loops. 2015-09-30 01:35:26 +00:00
default-widgets.php Docs: Clarify the file header summary for wp-includes/default-widgets.php, the top-level file for bringing in the core widget classes. 2015-09-22 13:36:25 +00:00
deprecated.php Docs: Add an @see reference for the "use-instead-of" function in the DocBlock for force_ssl_login(), deprecated in [34700]. 2015-09-29 22:46:25 +00:00
feed-atom-comments.php
feed-atom.php
feed-rdf.php
feed-rss2-comments.php
feed-rss2.php
feed-rss.php
feed.php Docs: Make a minor adjustment to the description syntax for the optional $comment argument in the DocBlock for comment_link(), introduced in [34071]. 2015-09-16 11:02:24 +00:00
formatting.php Docs: Remove documentation for a phantom parameter not actually passed to the is_email filter. 2015-10-02 07:03:25 +00:00
functions.php Use wp_installing() instead of WP_INSTALLING constant. 2015-10-05 15:06:28 +00:00
functions.wp-scripts.php
functions.wp-styles.php
general-template.php shttp is not a protocol. 2015-10-02 22:48:26 +00:00
http-functions.php HTTP: Add some new Cookie helper functions: 2015-09-22 03:14:25 +00:00
http.php
kses.php
l10n.php Use wp_installing() instead of WP_INSTALLING constant. 2015-10-05 15:06:28 +00:00
link-template.php Docs: There are quite alot of typos in core inline comments. 2015-09-30 04:13:48 +00:00
load.php Use wp_installing() instead of WP_INSTALLING constant. 2015-10-05 15:06:28 +00:00
locale.php Docs: Add a summary, version, and @access tag to the property DocBlock for WP_Locale->number_format. 2015-09-24 13:26:24 +00:00
media-template.php
media.php After [34629], use $size_class instead of $size. 2015-09-28 02:50:24 +00:00
meta-functions.php Docs: Clarify the file header summary for wp-includes/meta-functions.php, introduced in [33761]. 2015-09-22 13:27:24 +00:00
meta.php Docs: Clarify the file header summary for wp-includes/meta.php, the top-level file for the core Meta API. 2015-09-22 13:30:24 +00:00
ms-blogs.php
ms-default-constants.php MS: Use *_network_option() functions throughout core. 2015-10-02 19:08:26 +00:00
ms-default-filters.php Move new user notification emails to add_action() callbacks. 2015-09-16 22:19:24 +00:00
ms-deprecated.php MS: Use *_network_option() functions throughout core. 2015-10-02 19:08:26 +00:00
ms-files.php
ms-functions.php Use wp_installing() instead of WP_INSTALLING constant. 2015-10-05 15:06:28 +00:00
ms-load.php MS: Use *_network_option() functions throughout core. 2015-10-02 19:08:26 +00:00
ms-settings.php Use wp_installing() instead of WP_INSTALLING constant. 2015-10-05 15:06:28 +00:00
nav-menu-template.php Add a nav_menu_item_title filter for filtering nav menu item titles. 2015-09-28 18:41:26 +00:00
nav-menu.php Introduce the wp_add_nav_menu_item action, fired immediately after a new nav menu item has been added. 2015-10-02 06:46:24 +00:00
option.php Use wp_installing() instead of WP_INSTALLING constant. 2015-10-05 15:06:28 +00:00
pluggable-deprecated.php Pass false as the 2nd argument to class_exists() to disable autoloading and to not cause problems for those who define __autoload(). 2015-09-20 03:52:25 +00:00
pluggable.php MS: Use *_network_option() functions throughout core. 2015-10-02 19:08:26 +00:00
plugin.php callback is not a valid type in PHP, PSR-5, or phpDocumentor. callable should be used instead. 2015-09-25 23:58:25 +00:00
post-formats.php
post-functions.php Posts: In wp_insert_post(), don't set post_date to current time if it can be derived from a passed value for post_date_gmt. 2015-10-02 04:36:24 +00:00
post-template.php Docs: Fix a few syntatical issues with inline documentation in wp-includes/post-template.php. 2015-10-02 06:38:26 +00:00
post-thumbnail-template.php Update get_the_post_thumbnail_url() so it returns false on failure, to bring it inline with wp_get_attachment_image_url(). Correct and introduce new tests. 2015-09-28 15:34:25 +00:00
post.php Docs: Clarify the file header summary for wp-includes/post.php, the top-level file for the Post API. 2015-09-22 13:13:26 +00:00
query.php Remove search_terms from WP_Query doc block. 2015-10-03 04:36:27 +00:00
registration-functions.php
registration.php
revision.php
rewrite-constants.php
rewrite-functions.php Docs: Mark a few optional parameters as such in wp-includes/rewrite-functions.php. 2015-09-30 02:42:26 +00:00
rewrite.php
rss-functions.php
rss.php
script-loader.php Use wp_installing() instead of WP_INSTALLING constant. 2015-10-05 15:06:28 +00:00
session.php
shortcodes.php Shortcodes/Formatting: Add PCRE Performance Testing 2015-10-02 04:26:25 +00:00
taxonomy-functions.php Update the taxonomy relationship cache in is_object_in_term(). 2015-10-03 21:19:23 +00:00
taxonomy.php Docs: Clarify the file header summary for wp-includes/taxonomy.php, the top-level file for the core Taxonomy API. 2015-09-22 13:23:25 +00:00
template-loader.php
template.php Add single-{post_type}-{post_name}.php to the top of the template hierarchy for single posts. 2015-10-03 15:00:25 +00:00
theme.php Use wp_installing() instead of WP_INSTALLING constant. 2015-10-05 15:06:28 +00:00
update.php Use wp_installing() instead of WP_INSTALLING constant. 2015-10-05 15:06:28 +00:00
user-functions.php Use home_url() instead of get_option( 'siteurl' ) in notifications that are sent when a user's email address or password is changed. 2015-10-04 23:03:26 +00:00
user.php Docs: The User API is singular. 2015-09-22 13:03:24 +00:00
vars.php
version.php Use wp_installing() instead of WP_INSTALLING constant. 2015-10-05 15:06:28 +00:00
widget-functions.php callback is not a valid type in PHP, PSR-5, or phpDocumentor. callable should be used instead. 2015-09-25 23:58:25 +00:00
widgets.php
wlwmanifest.xml
wp-db.php WPDB: Allow null values in the CRUD functions. 2015-10-01 05:37:26 +00:00
wp-diff.php Pass false as the 2nd argument to class_exists() to disable autoloading and to not cause problems for those who define __autoload(). 2015-09-20 03:52:25 +00:00