WordPress/wp-admin/includes
Sergey Biryukov 0609e04266 Administration: Relax the default value check for the $position argument added to add_submenu_page() and related functions in [46197].
Due to a confusion with `add_menu_page()`, which takes the `$icon_url` parameter, while `add_submenu_page()` does not, some plugins were passing in a string instead of integer as `$position`, causing backward compatibility issues.

A `_doing_it_wrong()` message is now added to alert developers of the wrong parameter type.

Props david.binda, desrosj, 123host, dennis_f, MattyRob.
Reviewed by desrosj.
Fixes #48249.
Built from https://develop.svn.wordpress.org/trunk@46570


git-svn-id: http://core.svn.wordpress.org/trunk@46367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-22 17:52:04 +00:00
..
admin-filters.php Privacy tools: Organize privacy functions into logical files and classes. 2019-05-26 20:50:53 +00:00
admin.php Privacy tools: Organize privacy functions into logical files and classes. 2019-05-26 20:50:53 +00:00
ajax-actions.php Upload: Set custom header with the attachment ID for all uploads from media_handle_upload(). Let the REST API endpoint set it separately. 2019-10-07 15:30:02 +00:00
bookmark.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
class-automatic-upgrader-skin.php Code Modernisation: Introduce the spread operator in wp-admin/includes/class-*-upgrader-skin.php. 2019-09-15 10:42:54 +00:00
class-bulk-plugin-upgrader-skin.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
class-bulk-theme-upgrader-skin.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
class-bulk-upgrader-skin.php Code Modernisation: Introduce the spread operator in wp-admin/includes/class-*-upgrader-skin.php. 2019-09-15 10:42:54 +00:00
class-core-upgrader.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
class-custom-background.php Docs: Fix placement of some duplicate hook references. 2019-09-10 19:23:55 +00:00
class-custom-image-header.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
class-file-upload-upgrader.php Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in wp-admin. 2019-07-01 12:52:01 +00:00
class-ftp-pure.php Docs: Correct grammar in PemFTP description. 2019-03-17 01:20:49 +00:00
class-ftp-sockets.php Docs: Correct grammar in PemFTP description. 2019-03-17 01:20:49 +00:00
class-ftp.php PHP 7.4 compatibility fix / accessing arrays/string using curly brace syntax 2019-08-03 20:21:55 +00:00
class-language-pack-upgrader-skin.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
class-language-pack-upgrader.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
class-pclzip.php GENERAL: Remove magic quote functions 2019-09-13 22:21:01 +00:00
class-plugin-installer-skin.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
class-plugin-upgrader-skin.php Upgrade/Install: Escape the % in width="100%" in a printf() call in Plugin_Upgrader_Skin::after(). 2019-09-06 06:26:56 +00:00
class-plugin-upgrader.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
class-theme-installer-skin.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
class-theme-upgrader-skin.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
class-theme-upgrader.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
class-walker-category-checklist.php Docs: Fix placement of some duplicate hook references. 2019-09-10 19:23:55 +00:00
class-walker-nav-menu-checklist.php Menus: Fix typo in the class attribute for the hidden title field in Walker_Nav_Menu_Checklist. 2019-10-03 20:03:56 +00:00
class-walker-nav-menu-edit.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
class-wp-ajax-upgrader-skin.php Docs: Add a @since note about new parameters with the spread operator added to function signatures. 2019-10-09 04:28:02 +00:00
class-wp-automatic-updater.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
class-wp-comments-list-table.php Docs: Add missing description for $comment global. 2019-10-04 22:19:57 +00:00
class-wp-community-events.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
class-wp-debug-data.php Build/Test Tools: Introduce automated PHP compatibility checking. 2019-09-25 13:47:58 +00:00
class-wp-filesystem-base.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
class-wp-filesystem-direct.php Filesystem API: Check correct variable in WP_Filesystem_Direct::dirlist() after [45611]. 2019-07-09 15:58:57 +00:00
class-wp-filesystem-ftpext.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
class-wp-filesystem-ftpsockets.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
class-wp-filesystem-ssh2.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
class-wp-importer.php PHP 7.4 compatibility fix / accessing arrays/string using curly brace syntax 2019-08-03 20:21:55 +00:00
class-wp-internal-pointers.php Docs: Fix code example for removing internal pointers. 2019-10-03 20:39:58 +00:00
class-wp-links-list-table.php General: Correct strict comparison in WP_Links_List_Table::column_categories() introduced in [46313]. 2019-09-26 01:24:56 +00:00
class-wp-list-table-compat.php Code is Poetry. 2017-11-30 23:11:00 +00:00
class-wp-list-table.php Docs: Improve documentation for ::display() methods in various list tables. 2019-09-29 11:04:58 +00:00
class-wp-media-list-table.php Accessibility: Media: Improve the search media field labelling. 2019-10-07 12:43:03 +00:00
class-wp-ms-sites-list-table.php Network Admin: Improve Site States in List Table rows. 2019-10-08 17:46:02 +00:00
class-wp-ms-themes-list-table.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
class-wp-ms-users-list-table.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
class-wp-plugin-install-list-table.php Docs: Improve documentation for ::display() methods in various list tables. 2019-09-29 11:04:58 +00:00
class-wp-plugins-list-table.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
class-wp-post-comments-list-table.php Coding Standards: Upgrade WPCS to 1.0.0 2018-08-17 01:51:36 +00:00
class-wp-posts-list-table.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
class-wp-privacy-data-export-requests-list-table.php Privacy: Remove inline CSS within personal data request list tables. 2019-06-04 23:40:55 +00:00
class-wp-privacy-data-removal-requests-list-table.php Privacy: Show a success message for personal data erasure. 2019-09-23 19:13:58 +00:00
class-wp-privacy-policy-content.php Docs: Improve consistency in @since tags for parameters that were made optional. 2019-09-24 12:54:57 +00:00
class-wp-privacy-requests-table.php Privacy: Remove unused $wpdb global in WP_Privacy_Requests_Table::prepare_items(). 2019-10-02 23:22:58 +00:00
class-wp-screen.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
class-wp-site-health-auto-updates.php Site Health: Move "The folder ... was detected as being under version control" message from failure to warning. 2019-09-23 21:24:56 +00:00
class-wp-site-health.php Site Health: Improve the wording for UTF8MB4 test description. 2019-10-05 02:39:58 +00:00
class-wp-site-icon.php Replace usages of basename() with wp_basename() in order to support multibyte filenames 2019-03-01 20:58:52 +00:00
class-wp-terms-list-table.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
class-wp-theme-install-list-table.php Docs: Improve documentation for ::display() methods in various list tables. 2019-09-29 11:04:58 +00:00
class-wp-themes-list-table.php I18N: Add missing comma in a translator comment. 2019-10-04 22:09:57 +00:00
class-wp-upgrader-skin.php Code Modernisation: Introduce the spread operator in wp-admin/includes/class-*-upgrader-skin.php. 2019-09-15 10:42:54 +00:00
class-wp-upgrader-skins.php Docs: Add missing @deprecated tags in the file docblock of some deprecated files. 2019-10-08 17:19:04 +00:00
class-wp-upgrader.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
class-wp-users-list-table.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
comment.php Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in wp-admin. 2019-07-01 12:52:01 +00:00
continents-cities.php I18N: Update list of continents and cities for the timezone selection. 2018-07-18 11:21:25 +00:00
credits.php Code is Poetry. 2017-11-30 23:11:00 +00:00
dashboard.php Docs: Add a @since note about new parameters with the spread operator added to function signatures. 2019-10-09 04:28:02 +00:00
deprecated.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
edit-tag-messages.php Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in wp-admin. 2019-07-01 12:52:01 +00:00
export.php Docs: Add missing description for $post global. 2019-08-04 12:28:56 +00:00
file.php Filesystem API: Use strict type check in the in_array() call for the $skip_list parameter in copy_dir() and _copy_dir(). 2019-10-05 02:16:56 +00:00
image-edit.php Media: Prevents clipping of text when scaling image edit screen. 2019-09-30 17:56:57 +00:00
image.php Media/Upload: When the users upload big images and WordPress creates a scaled image to use as the largest size, append scaled- to the file names of the scaled images to make them easier to recognize. 2019-10-21 21:43:04 +00:00
import.php Replace usages of basename() with wp_basename() in order to support multibyte filenames 2019-03-01 20:58:52 +00:00
list-table.php Privacy: Remove reinstated wp-admin/options-privacy.php from $_old_files. 2019-05-27 02:40:53 +00:00
media.php Docs: Add a @since note about new parameters with the spread operator added to function signatures. 2019-10-09 04:28:02 +00:00
menu.php Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in wp-admin. 2019-07-01 12:52:01 +00:00
meta-boxes.php Accessibility: Media: Replace @ with at in the displayed date format. 2019-09-09 00:07:57 +00:00
misc.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
ms-admin-filters.php Code is Poetry. 2017-11-30 23:11:00 +00:00
ms-deprecated.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
ms.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
nav-menu.php Menus: Replace http with https in placeholders. 2019-09-26 20:32:55 +00:00
network.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
noop.php Code Modernization: Remove conditional use of PHP realpath(). 2019-09-20 20:46:56 +00:00
options.php General: First pass at replacing Codex URLs with a corresponding HelpHub or DevHub article. 2019-07-25 22:45:57 +00:00
plugin-install.php Docs: Add requires_php to the list of fields returned by plugins_api(). 2019-10-12 02:35:04 +00:00
plugin.php Administration: Relax the default value check for the $position argument added to add_submenu_page() and related functions in [46197]. 2019-10-22 17:52:04 +00:00
post.php Editor: Add missing block data fields for blocks registered server side. 2019-09-11 14:52:56 +00:00
privacy-tools.php Privacy: Introduce wp_privacy_personal_data_email_to and wp_privacy_personal_data_email_subject filters. 2019-09-23 19:25:57 +00:00
revision.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
schema.php Multisite: Remove the redundant blog_versions table. 2019-09-19 22:07:57 +00:00
screen.php Docs: Add missing description for $current_screen global. 2019-08-04 02:03:55 +00:00
taxonomy.php Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in wp-admin. 2019-07-01 12:52:01 +00:00
template.php Docs: Improve documentation for _post_states() and get_post_states(). 2019-09-26 00:57:58 +00:00
theme-install.php Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in wp-admin. 2019-07-01 12:52:01 +00:00
theme.php Docs: Docblock corrections and improvements, mostly related to various pre_* filters. 2019-09-21 17:41:57 +00:00
translation-install.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
update-core.php Upgrade/Install: Use a unique error code when an update fails due to the PHP JSON extension missing. 2019-10-16 21:03:02 +00:00
update.php PHP 7.4: Fix another instance of array access on a datatype that cannot be accessed as an array. 2019-09-19 14:30:56 +00:00
upgrade.php Build/Test Tools: Introduce automated PHP compatibility checking. 2019-09-25 13:47:58 +00:00
user.php I18N: Capitalize translator comments consistently, add trailing punctuation. 2019-09-03 00:41:05 +00:00
widgets.php Code Modernisation: Replace call_user_func_array() in wp-admin/includes/widgets.php and associated unit tests with a direct function call. 2019-09-15 11:41:55 +00:00