WordPress/wp-admin
hellofromTonya 28b0710360 Application Passwords: Show HTTPS required message without filtering when not enabled or not in local environment.
When `add_filter( 'wp_is_application_passwords_available', '__return_false' )` exists, HTTPS requirement message is shown even if HTTPS is enabled on the site. This happens because `wp_is_application_passwords_available_for_user()` first invokes `wp_is_application_passwords_available()` which is filterable. The situation could happen if the `'wp_is_application_passwords_available_for_user'` filter returns `false`.

To fix this, the check for HTTPS (or if in a 'local' environment) is moved to a new function called `wp_is_application_passwords_supported()`. Then the return from this function is used as an OR condition for the Application Passwords section and for displaying the HTTPS required message.

Tests are included for both `wp_is_application_passwords_supported()` and `wp_is_application_passwords_available()`.

Follow-up to [51980], [51988].

Props davidbinda, SergeyBiryukov, ocean90, felipeelia, costdev, hellofromTonya.
Fixes #53658.
Built from https://develop.svn.wordpress.org/trunk@52398


git-svn-id: http://core.svn.wordpress.org/trunk@51990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-12-21 02:45:03 +00:00
..
css Editor: Hide visibility and status settings for wp_navigation post type. 2021-11-30 21:01:02 +00:00
images Coding Standards: Revert accidental image changes in [52171]. 2021-11-16 00:04:01 +00:00
includes Customize: Overlay incompatible banner for block themes. 2021-12-14 15:33:01 +00:00
js External Libraries: Further fix jQuery deprecations in WordPress core. 2021-11-30 17:18:01 +00:00
maint Database: Check the correct value for displaying the "Successfully repaired table" or "Failed to repair" messages on Database Repair screen. 2020-12-04 15:50:12 +00:00
network Docs: Various inline documentation corrections and improvements. 2021-12-07 12:20:02 +00:00
user Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
about.php Docs: Add a comment about the $title global usage in various admin files. 2021-07-22 13:53:00 +00:00
admin-ajax.php Login and Registration: Improve the UX of the Reset Password screen. 2021-02-02 18:13:04 +00:00
admin-footer.php Coding Standards: Simplify a condition in wp-admin/admin-footer.php. 2021-06-01 11:30:57 +00:00
admin-functions.php Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
admin-header.php External Libraries: Further fix jQuery deprecations in WordPress core. 2021-11-30 17:18:01 +00:00
admin-post.php Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
admin.php Docs: Add a comment about the $title global usage in various admin files. 2021-07-22 13:53:00 +00:00
async-upload.php Media: Improve upload page media item layout on smaller screens. 2021-06-22 04:26:58 +00:00
authorize-application.php App Passwords: Remove placeholder from the app password name input field. 2021-10-01 13:49:00 +00:00
comment.php Docs: Add a comment about the $title global usage in various admin files. 2021-07-22 13:53:00 +00:00
credits.php Docs: Add a comment about the $title global usage in various admin files. 2021-07-22 13:53:00 +00:00
custom-background.php Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
custom-header.php Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
customize.php Admin/Help: add docs links to several screens. 2021-11-08 21:43:01 +00:00
edit-comments.php Admin/Comments: remove bespoke truncation from search string HTML. 2021-11-02 15:57:59 +00:00
edit-form-advanced.php Editor: Use a consistent way to retrieve post ID on Edit Post screens. 2021-04-09 11:31:09 +00:00
edit-form-blocks.php Editor: Check the correct post type support property for initial_edits. 2021-11-22 08:42:03 +00:00
edit-form-comment.php Comments: Escape comment author's email in the Edit Comment form. 2021-06-07 18:47:02 +00:00
edit-link-form.php Posts, Post Types: Update the styling of the legacy Links editing screen. 2021-02-16 18:50:03 +00:00
edit-tag-form.php Taxonomy: Clarify the taxonomy labels for customizing the field descriptions on Edit Tags screen: 2021-11-15 16:45:01 +00:00
edit-tags.php Taxonomy: Clarify the taxonomy labels for customizing the field descriptions on Edit Tags screen: 2021-11-15 16:45:01 +00:00
edit.php General: Fix code quality issues which were identified by static analysis. 2021-09-22 21:01:00 +00:00
erase-personal-data.php Coding Standards: Remove wrapping HTML tags from translatable strings. 2021-07-08 17:07:58 +00:00
export-personal-data.php Coding Standards: Remove wrapping HTML tags from translatable strings. 2021-07-08 17:07:58 +00:00
export.php External Libraries: Further fix jQuery deprecations in WordPress core. 2021-11-30 17:18:01 +00:00
freedoms.php Docs: Add a comment about the $title global usage in various admin files. 2021-07-22 13:53:00 +00:00
import.php Docs: Add a comment about the $title global usage in various admin files. 2021-07-22 13:53:00 +00:00
index.php Help/About: Improve typography in the Welcome to your WordPress Dashboard! text. 2021-11-03 03:16:57 +00:00
install-helper.php Docs: Improve documentation for functions in wp-admin/install-helper.php per the documentation standards. 2020-05-12 18:40:07 +00:00
install.php Coding Standards: Move some translator comments to the correct place. 2021-03-21 13:13:03 +00:00
link-add.php Docs: Add a comment about the $title global usage in various admin files. 2021-07-22 13:53:00 +00:00
link-manager.php Docs: Add a comment about the $title global usage in various admin files. 2021-07-22 13:53:00 +00:00
link-parse-opml.php XML-RPC: Explicitly unset the reference to the parser resource after calling xml_parser_free() to avoid memory leaks in PHP 7.0.0 or higher. 2020-07-05 15:22:01 +00:00
link.php Coding Standards: Apply some alignment fixes from composer format. 2021-07-27 19:01:59 +00:00
load-scripts.php Docs: Update a comment in wp-admin/load-styles.php per the documentation standards. 2021-12-12 14:52:02 +00:00
load-styles.php Docs: Update a comment in wp-admin/load-styles.php per the documentation standards. 2021-12-12 14:52:02 +00:00
media-new.php Docs: Add a comment about the $title global usage in various admin files. 2021-07-22 13:53:00 +00:00
media-upload.php Docs: Add examples of possible names for various hooks whose name contains a dynamic portion. 2021-03-07 12:32:09 +00:00
media.php Docs: Add a comment about the $title global usage in various admin files. 2021-07-22 13:53:00 +00:00
menu-header.php Coding Standards: Replace alias PHP functions with the canonical names. 2020-10-18 17:27:06 +00:00
menu.php Themes: Better names for WP_Theme::is_block_theme() and wp_is_block_theme() and make wp_is_block_theme() a wrapper. 2021-12-07 00:02:02 +00:00
moderation.php Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
ms-admin.php Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
ms-delete-site.php Docs: Add a comment about the $title global usage in various admin files. 2021-07-22 13:53:00 +00:00
ms-edit.php Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
ms-options.php Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
ms-sites.php Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
ms-themes.php Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
ms-upgrade-network.php Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
ms-users.php Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
my-sites.php Docs: Add a comment about the $title global usage in various admin files. 2021-07-22 13:53:00 +00:00
nav-menus.php Menus: Add audible notice on menu item add or remove. 2021-11-15 20:00:59 +00:00
network.php Docs: Add a comment about the $title global usage in various admin files. 2021-07-22 13:53:00 +00:00
options-discussion.php Admin/Discussion Settings: attempt to clarify intent of "Default post settings" section. 2021-11-02 16:42:59 +00:00
options-general.php Docs: Add a comment about the $title global usage in various admin files. 2021-07-22 13:53:00 +00:00
options-head.php Administration: Replace legacy updated message type in add_settings_error() calls with success. 2019-08-16 00:39:55 +00:00
options-media.php Docs: Add a comment about the $title global usage in various admin files. 2021-07-22 13:53:00 +00:00
options-permalink.php Permalinks: Move the Nginx documentation link to help sidebar in wp-admin/options-permalink.php. 2021-10-05 23:11:06 +00:00
options-privacy.php Admin/Help: add commas to end of multi-line array items. 2021-11-08 21:55:00 +00:00
options-reading.php Docs: Add a comment about the $title global usage in various admin files. 2021-07-22 13:53:00 +00:00
options-writing.php Docs: Add a comment about the $title global usage in various admin files. 2021-07-22 13:53:00 +00:00
options.php Docs: Add a comment about the $title global usage in various admin files. 2021-07-22 13:53:00 +00:00
plugin-editor.php Admin/UI-Copy: reword some "we" usages. 2021-11-02 17:37:57 +00:00
plugin-install.php Docs: Document some more common names for dynamic hooks and standardise the phrasing used. 2021-09-21 18:21:00 +00:00
plugins.php Docs: Add a comment about the $title global usage in various admin files. 2021-07-22 13:53:00 +00:00
post-new.php Coding Standards: Use strict comparison where static strings are involved. 2020-05-16 18:42:12 +00:00
post.php Block Editor: Use a unique name for the nonce of the custom fields toggle form. 2021-02-08 21:39:16 +00:00
press-this.php Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
privacy-policy-guide.php Coding Standards: Use static closures when not using $this. 2021-08-26 12:59:02 +00:00
privacy.php Docs: Add a comment about the $title global usage in various admin files. 2021-07-22 13:53:00 +00:00
profile.php Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
revision.php Coding Standards: Apply some alignment fixes from composer format. 2021-07-27 19:01:59 +00:00
setup-config.php Upgrade/Install: Use consistent capitalization for "web host" in setup messages. 2021-08-14 12:06:59 +00:00
site-editor.php Themes: Rename public static functions in WP_Theme_JSON_Resolver to remove custom_post_type references. 2021-12-14 16:14:01 +00:00
site-health-info.php Site Health: Internationalizes count in the info section headings. 2021-11-01 22:36:59 +00:00
site-health.php Site Health: Typo correction in Site Health help tab. 2021-12-18 21:02:04 +00:00
term.php Coding Standards: Use strict type check for in_array() and array_search() where strings are involved. 2020-04-05 03:02:11 +00:00
theme-editor.php Themes: Better names for WP_Theme::is_block_theme() and wp_is_block_theme() and make wp_is_block_theme() a wrapper. 2021-12-07 00:02:02 +00:00
theme-install.php Coding Standards: Improve escaping in wp-admin/theme-install.php. 2021-10-20 19:18:01 +00:00
themes.php Themes: Show only "Customize" or "Activate" button in block theme's Theme Details modal. 2021-12-10 20:33:00 +00:00
tools.php Docs: Add a comment about the $title global usage in various admin files. 2021-07-22 13:53:00 +00:00
update-core.php Upgrade/Install: Add timezone info to last checked update time. 2021-11-18 09:25:03 +00:00
update.php Docs: Add a comment about the $title global usage in various admin files. 2021-07-22 13:53:00 +00:00
upgrade-functions.php Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
upgrade.php Coding Standards: Move some translator comments to the correct place. 2021-03-21 13:13:03 +00:00
upload.php Coding Standards: Use strict comparisons in wp-admin/upload.php. 2021-08-05 03:37:56 +00:00
user-edit.php Application Passwords: Show HTTPS required message without filtering when not enabled or not in local environment. 2021-12-21 02:45:03 +00:00
user-new.php Docs: Add a comment about the $title global usage in various admin files. 2021-07-22 13:53:00 +00:00
users.php Docs: Add a comment about the $title global usage in various admin files. 2021-07-22 13:53:00 +00:00
widgets-form-blocks.php REST API: Support custom namespaces for custom post types. 2021-10-31 23:16:58 +00:00
widgets-form.php Widgets: Revert [51705]. 2021-09-09 21:40:57 +00:00
widgets.php Docs: Add a comment about the $title global usage in various admin files. 2021-07-22 13:53:00 +00:00