mirror of
https://github.com/WordPress/WordPress.git
synced 2024-11-10 21:00:59 +01:00
27b776fd90
When SimplePie parses HTTP headers, it combines multiple values for the same header into a comma-separated string. `WP_SimplePie_File` overrides the parsing, but was leaving them as an array instead. That lead to a fatal error in PHP 8, because other parts of the codebase ended up passing an array to a function that expected a string. Props david.binda, litemotiv, inc2734, NicolasKulka, hellofromTonya, mbabker, skithund, SergeyBiryukov, desrosj, timothyblynjacobs. Reviewed by SergeyBiryukov, iandunn. Merges [49803] and [49805] to the 5.6 branch. Fixes #51056. See #51956. Built from https://develop.svn.wordpress.org/branches/5.6@49806 git-svn-id: http://core.svn.wordpress.org/branches/5.6@49529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
103 lines
3.2 KiB
PHP
103 lines
3.2 KiB
PHP
<?php
|
|
/**
|
|
* Feed API: WP_SimplePie_File class
|
|
*
|
|
* @package WordPress
|
|
* @subpackage Feed
|
|
* @since 4.7.0
|
|
*/
|
|
|
|
/**
|
|
* Core class for fetching remote files and reading local files with SimplePie.
|
|
*
|
|
* This uses Core's HTTP API to make requests, which gives plugins the ability
|
|
* to hook into the process.
|
|
*
|
|
* @since 2.8.0
|
|
*
|
|
* @see SimplePie_File
|
|
*/
|
|
class WP_SimplePie_File extends SimplePie_File {
|
|
|
|
/**
|
|
* Constructor.
|
|
*
|
|
* @since 2.8.0
|
|
* @since 3.2.0 Updated to use a PHP5 constructor.
|
|
* @since 5.6.1 Multiple headers are concatenated into a comma-separated string, rather than remaining
|
|
* an array.
|
|
*
|
|
* @param string $url Remote file URL.
|
|
* @param int $timeout Optional. How long the connection should stay open in seconds.
|
|
* Default 10.
|
|
* @param int $redirects Optional. The number of allowed redirects. Default 5.
|
|
* @param string|array $headers Optional. Array or string of headers to send with the request.
|
|
* Default null.
|
|
* @param string $useragent Optional. User-agent value sent. Default null.
|
|
* @param bool $force_fsockopen Optional. Whether to force opening internet or unix domain socket
|
|
* connection or not. Default false.
|
|
*/
|
|
public function __construct( $url, $timeout = 10, $redirects = 5, $headers = null, $useragent = null, $force_fsockopen = false ) {
|
|
$this->url = $url;
|
|
$this->timeout = $timeout;
|
|
$this->redirects = $redirects;
|
|
$this->headers = $headers;
|
|
$this->useragent = $useragent;
|
|
|
|
$this->method = SIMPLEPIE_FILE_SOURCE_REMOTE;
|
|
|
|
if ( preg_match( '/^http(s)?:\/\//i', $url ) ) {
|
|
$args = array(
|
|
'timeout' => $this->timeout,
|
|
'redirection' => $this->redirects,
|
|
);
|
|
|
|
if ( ! empty( $this->headers ) ) {
|
|
$args['headers'] = $this->headers;
|
|
}
|
|
|
|
if ( SIMPLEPIE_USERAGENT != $this->useragent ) { // Use default WP user agent unless custom has been specified.
|
|
$args['user-agent'] = $this->useragent;
|
|
}
|
|
|
|
$res = wp_safe_remote_request( $url, $args );
|
|
|
|
if ( is_wp_error( $res ) ) {
|
|
$this->error = 'WP HTTP Error: ' . $res->get_error_message();
|
|
$this->success = false;
|
|
|
|
} else {
|
|
$this->headers = wp_remote_retrieve_headers( $res );
|
|
|
|
/*
|
|
* SimplePie expects multiple headers to be stored as a comma-separated string, but
|
|
* `wp_remote_retrieve_headers()` returns them as an array, so they need to be
|
|
* converted.
|
|
*
|
|
* The only exception to that is the `content-type` header, which should ignore any
|
|
* previous values and only use the last one.
|
|
*
|
|
* @see SimplePie_HTTP_Parser::new_line().
|
|
*/
|
|
foreach ( $this->headers as $name => $value ) {
|
|
if ( ! is_array( $value ) ) {
|
|
continue;
|
|
}
|
|
|
|
if ( 'content-type' === $name ) {
|
|
$this->headers[ $name ] = array_pop( $value );
|
|
} else {
|
|
$this->headers[ $name ] = implode( ', ', $value );
|
|
}
|
|
}
|
|
|
|
$this->body = wp_remote_retrieve_body( $res );
|
|
$this->status_code = wp_remote_retrieve_response_code( $res );
|
|
}
|
|
} else {
|
|
$this->error = '';
|
|
$this->success = false;
|
|
}
|
|
}
|
|
}
|