mirror of
https://github.com/WordPress/WordPress.git
synced 2024-08-28 00:29:40 +02:00
The parent class uses `$current_object_id` while most of the child classes use `$id`. As the parent class' is more descriptive, renaming the last parameter in each of child class. Why? PHP 8 introduces the ability to pass named arguments to function/method calls. This means the child and parent method signatures (i.e. parameter names) need to match. Changes for readability: - `@since` clearly specifies the original parameter name and its new name as well as why the change happened. - In methods longer than a single line, the generic parameter is reassigned to the original parameter restoring it for context for use within the method. An inline comment is added to explain why this reassignment is made. - In cases where the original parameter name was too generic or misleading, renamed (when reassigning) to a more descriptive name for use within the method. Follow-up to [7737], [8900], [8970], [14248], [15077], [16100], [25642], [25644], [37051], [37054], [37056], [46271], [47189], [51739]. Props jrf, hellofromTonya, sergeybiryukov, azaozz, desrosj, johnbillion. See #51553. Built from https://develop.svn.wordpress.org/trunk@51779 git-svn-id: http://core.svn.wordpress.org/trunk@51386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
97 lines
2.6 KiB
PHP
97 lines
2.6 KiB
PHP
<?php
|
|
/**
|
|
* Post API: Walker_PageDropdown class
|
|
*
|
|
* @package WordPress
|
|
* @subpackage Post
|
|
* @since 4.4.0
|
|
*/
|
|
|
|
/**
|
|
* Core class used to create an HTML drop-down list of pages.
|
|
*
|
|
* @since 2.1.0
|
|
*
|
|
* @see Walker
|
|
*/
|
|
class Walker_PageDropdown extends Walker {
|
|
|
|
/**
|
|
* What the class handles.
|
|
*
|
|
* @since 2.1.0
|
|
* @var string
|
|
*
|
|
* @see Walker::$tree_type
|
|
*/
|
|
public $tree_type = 'page';
|
|
|
|
/**
|
|
* Database fields to use.
|
|
*
|
|
* @since 2.1.0
|
|
* @var array
|
|
*
|
|
* @see Walker::$db_fields
|
|
* @todo Decouple this
|
|
*/
|
|
public $db_fields = array(
|
|
'parent' => 'post_parent',
|
|
'id' => 'ID',
|
|
);
|
|
|
|
/**
|
|
* Starts the element output.
|
|
*
|
|
* @since 2.1.0
|
|
* @since 5.9.0 Renamed `$page` to `$data_object` and `$id` to `$current_object_id`
|
|
* to match parent class for PHP 8 named parameter support.
|
|
*
|
|
* @see Walker::start_el()
|
|
*
|
|
* @param string $output Used to append additional content. Passed by reference.
|
|
* @param WP_Post $data_object Page data object.
|
|
* @param int $depth Optional. Depth of page in reference to parent pages.
|
|
* Used for padding. Default 0.
|
|
* @param array $args Optional. Uses 'selected' argument for selected page to
|
|
* set selected HTML attribute for option element. Uses
|
|
* 'value_field' argument to fill "value" attribute.
|
|
* See wp_dropdown_pages(). Default empty array.
|
|
* @param int $current_object_id Optional. ID of the current page. Default 0.
|
|
*/
|
|
public function start_el( &$output, $data_object, $depth = 0, $args = array(), $current_object_id = 0 ) {
|
|
// Restores the more descriptive, specific name for use within this method.
|
|
$page = $data_object;
|
|
$pad = str_repeat( ' ', $depth * 3 );
|
|
|
|
if ( ! isset( $args['value_field'] ) || ! isset( $page->{$args['value_field']} ) ) {
|
|
$args['value_field'] = 'ID';
|
|
}
|
|
|
|
$output .= "\t<option class=\"level-$depth\" value=\"" . esc_attr( $page->{$args['value_field']} ) . '"';
|
|
if ( $page->ID == $args['selected'] ) {
|
|
$output .= ' selected="selected"';
|
|
}
|
|
$output .= '>';
|
|
|
|
$title = $page->post_title;
|
|
if ( '' === $title ) {
|
|
/* translators: %d: ID of a post. */
|
|
$title = sprintf( __( '#%d (no title)' ), $page->ID );
|
|
}
|
|
|
|
/**
|
|
* Filters the page title when creating an HTML drop-down list of pages.
|
|
*
|
|
* @since 3.1.0
|
|
*
|
|
* @param string $title Page title.
|
|
* @param WP_Post $page Page data object.
|
|
*/
|
|
$title = apply_filters( 'list_pages', $title, $page );
|
|
|
|
$output .= $pad . esc_html( $title );
|
|
$output .= "</option>\n";
|
|
}
|
|
}
|