Sergey Biryukov c03305852e Code Modernization: Add AllowDynamicProperties attribute to all (parent) classes. ... Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0. There are a number of ways to mitigate this: * If it is an accidental typo for a declared property: fix the typo. * For known properties: declare them on the class. * For unknown properties: add the magic `__get()`, `__set()`, et al. methods to the class or let the class extend `stdClass` which has highly optimized versions of these magic methods built in. * For unknown ''use'' of dynamic properties, the `#[AllowDynamicProperties]` attribute can be added to the class. The attribute will automatically be inherited by child classes. Trac ticket #56034 is open to investigate and handle the third and fourth type of situations, however it has become clear this will need more time and will not be ready in time for WP 6.1. To reduce “noise” in the meantime, both in the error logs of WP users moving onto PHP 8.2, in the test run logs of WP itself, in test runs of plugins and themes, as well as to prevent duplicate tickets from being opened for the same issue, this commit adds the `#[AllowDynamicProperties]` attribute to all “parent” classes in WP. The logic used for this commit is as follows: * If a class already has the attribute: no action needed. * If a class does not `extend`: add the attribute. * If a class does `extend`: - If it extends `stdClass`: no action needed (as `stdClass` supports dynamic properties). - If it extends a PHP native class: add the attribute. - If it extends a class from one of WP's external dependencies: add the attribute. * In all other cases: no action — the attribute should not be needed as child classes inherit from the parent. Whether or not a class contains magic methods has not been taken into account, as a review of the currently existing magic methods has shown that those are generally not sturdy enough and often even set dynamic properties (which they should not). See the [https://www.youtube.com/watch?v=vDZWepDQQVE live stream from August 16, 2022] for more details. This commit only affects classes in the `src` directory of WordPress core. * Tests should not get this attribute, but should be fixed to not use dynamic properties instead. Patches for this are already being committed under ticket #56033. * While a number bundled themes (2014, 2019, 2020, 2021) contain classes, they are not a part of this commit and may be updated separately. Reference: [https://wiki.php.net/rfc/deprecate_dynamic_properties PHP RFC: Deprecate dynamic properties]. Follow-up to [53922]. Props jrf, hellofromTonya, markjaquith, peterwilsoncc, costdev, knutsp, aristath. See #56513, #56034. Built from https://develop.svn.wordpress.org/trunk@54133 git-svn-id: http://core.svn.wordpress.org/trunk@53692 1a063a9b-81f0-0310-95a4-ce76da25c4cd		2022-09-12 15:47:14 +00:00
..
admin-filters.php	Editor: Refresh nones for metaboxes after reauthentication.	2022-09-11 20:46:10 +00:00
admin.php	Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant.	2020-02-06 06:33:11 +00:00
ajax-actions.php	Media: Cache parent posts in query-attachments AJAX endpoint.	2022-08-12 00:17:07 +00:00
bookmark.php	Docs: Add missing description for $pagenow global in various functions.	2022-04-04 18:26:06 +00:00
class-automatic-upgrader-skin.php	Code Modernization: Fix reserved keyword and parameter name mismatches for parent/child classes in WP_Upgrader_Skin::feedback().	2021-09-09 13:48:56 +00:00
class-bulk-plugin-upgrader-skin.php	Code Modernization: Explicitly declare all properties in WP_Ajax_Upgrader_Skin.	2022-08-29 12:46:10 +00:00
class-bulk-theme-upgrader-skin.php	Code Modernization: Explicitly declare all properties in WP_Ajax_Upgrader_Skin.	2022-08-29 12:46:10 +00:00
class-bulk-upgrader-skin.php	Code Modernization: Fix parameter name mismatches for parent/child classes in WP_Upgrader_Skin::error().	2021-09-09 13:59:56 +00:00
class-core-upgrader.php	Administration: Replace "can not" with "cannot" after [53131].	2022-04-11 11:50:01 +00:00
class-custom-background.php	Code Modernization: Add AllowDynamicProperties attribute to all (parent) classes.	2022-09-12 15:47:14 +00:00
class-custom-image-header.php	Code Modernization: Add AllowDynamicProperties attribute to all (parent) classes.	2022-09-12 15:47:14 +00:00
class-file-upload-upgrader.php	Code Modernization: Add AllowDynamicProperties attribute to all (parent) classes.	2022-09-12 15:47:14 +00:00
class-ftp-pure.php	Docs: Update URLs in some @link tags and switch them to HTTPS.	2019-11-01 14:57:02 +00:00
class-ftp-sockets.php	Administration: Replace contracted verb forms for better consistency.	2022-03-22 16:25:03 +00:00
class-ftp.php	Code Modernization: Rename parameters that use reserved keywords in wp-admin/includes/class-ftp.php.	2022-03-26 15:28:08 +00:00
class-language-pack-upgrader-skin.php	Code Modernization: Fix parameter name mismatches for parent/child classes in WP_Upgrader_Skin::error().	2021-09-09 13:59:56 +00:00
class-language-pack-upgrader.php	Administration: Remove self-reference ("we") in WordPress Admin.	2022-04-11 11:42:04 +00:00
class-pclzip.php	Filesystem API: Make sure to only call fread() on non-empty files in PclZip::privAddFile().	2021-08-29 01:33:58 +00:00
class-plugin-installer-skin.php	Code Modernization: Replace phpversion() function calls with PHP_VERSION constant.	2022-05-20 17:38:14 +00:00
class-plugin-upgrader-skin.php	Text Changes: Unify various "Back to..." vs. "Return to..." vs. "Go to..." strings.	2020-11-09 10:53:10 +00:00
class-plugin-upgrader.php	Code Modernization: Replace phpversion() function calls with PHP_VERSION constant.	2022-05-20 17:38:14 +00:00
class-theme-installer-skin.php	Code Modernization: Replace phpversion() function calls with PHP_VERSION constant.	2022-05-20 17:38:14 +00:00
class-theme-upgrader-skin.php	Text Changes: Unify various "Back to..." vs. "Return to..." vs. "Go to..." strings.	2020-11-09 10:53:10 +00:00
class-theme-upgrader.php	Code Modernization: Replace phpversion() function calls with PHP_VERSION constant.	2022-05-20 17:38:14 +00:00
class-walker-category-checklist.php	Code Modernization: Fix reserved keyword and parameter name mismatches for parent/child classes in Walker::end_el().	2021-09-09 13:03:55 +00:00
class-walker-nav-menu-checklist.php	Code Modernization: Fix last parameter name mismatches for parent/child classes in Walker::start_el().	2021-09-09 12:39:59 +00:00
class-walker-nav-menu-edit.php	Menus: Use more appropriate escaping functions in class Walker_Nav_Menu_Edit.	2022-07-05 08:06:17 +00:00
class-wp-ajax-upgrader-skin.php	Code Modernization: Explicitly declare all properties in WP_Ajax_Upgrader_Skin.	2022-08-29 12:46:10 +00:00
class-wp-application-passwords-list-table.php	Application Passwords: Allow enter key to submit profile form.	2021-06-07 23:49:58 +00:00
class-wp-automatic-updater.php	Code Modernization: Add AllowDynamicProperties attribute to all (parent) classes.	2022-09-12 15:47:14 +00:00
class-wp-comments-list-table.php	Coding Standards: Use more meaningful variable names for output in the admin.	2022-09-05 17:19:09 +00:00
class-wp-community-events.php	Code Modernization: Add AllowDynamicProperties attribute to all (parent) classes.	2022-09-12 15:47:14 +00:00
class-wp-debug-data.php	Code Modernization: Add AllowDynamicProperties attribute to all (parent) classes.	2022-09-12 15:47:14 +00:00
class-wp-filesystem-base.php	Code Modernization: Add AllowDynamicProperties attribute to all (parent) classes.	2022-09-12 15:47:14 +00:00
class-wp-filesystem-direct.php	Coding Standards: Rename the $file parameter to $path in some WP_Filesystem_* methods.	2022-08-09 11:33:10 +00:00
class-wp-filesystem-ftpext.php	Upgrade/Install: Make WP_Filesystem_FTPext::size() return false on failure.	2022-08-16 13:41:14 +00:00
class-wp-filesystem-ftpsockets.php	Coding Standards: Rename the $file parameter to $path in some WP_Filesystem_* methods.	2022-08-09 11:33:10 +00:00
class-wp-filesystem-ssh2.php	Coding Standards: Rename the $file parameter to $path in some WP_Filesystem_* methods.	2022-08-09 11:33:10 +00:00
class-wp-importer.php	Code Modernization: Add AllowDynamicProperties attribute to all (parent) classes.	2022-09-12 15:47:14 +00:00
class-wp-internal-pointers.php	Code Modernization: Add AllowDynamicProperties attribute to all (parent) classes.	2022-09-12 15:47:14 +00:00
class-wp-links-list-table.php	Code Modernization: Fix parameter name mismatches for parent/child classes in WP_List_Table::handle_row_actions().	2021-09-07 19:24:53 +00:00
class-wp-list-table-compat.php	Docs: Add missing descriptions for _WP_List_Table_Compat methods.	2020-11-14 16:54:08 +00:00
class-wp-list-table.php	Code Modernization: Add AllowDynamicProperties attribute to all (parent) classes.	2022-09-12 15:47:14 +00:00
class-wp-media-list-table.php	Media: Call update_post_parent_caches function in WP_Media_List_Table class.	2022-09-08 09:37:17 +00:00
class-wp-ms-sites-list-table.php	Coding Standards: Use more meaningful variable names for output in the admin.	2022-09-05 17:19:09 +00:00
class-wp-ms-themes-list-table.php	Accessibility: Administration: Improve aria-label on network admin Themes screen.	2021-09-10 14:49:00 +00:00
class-wp-ms-users-list-table.php	Coding Standards: Use more meaningful variable names for output in the admin.	2022-09-05 17:19:09 +00:00
class-wp-plugin-install-list-table.php	Docs: Use third-person singular verbs for various function descriptions, as per docblocks standards.	2022-09-02 06:58:09 +00:00
class-wp-plugins-list-table.php	Coding Standards: Use a consistent markup for line break tags across Core.	2022-09-02 06:51:13 +00:00
class-wp-post-comments-list-table.php
class-wp-posts-list-table.php	Posts, Post Types: Call update_post_author_caches function in WP_Posts_List_Table class.	2022-09-08 10:17:12 +00:00
class-wp-privacy-data-export-requests-list-table.php	Privacy: Fix "Retry" action after a personal data export failure.	2022-03-10 19:22:01 +00:00
class-wp-privacy-data-removal-requests-list-table.php	Coding Standards: Fix WPCS issues in [49258].	2020-10-20 21:20:07 +00:00
class-wp-privacy-policy-content.php	Code Modernization: Add AllowDynamicProperties attribute to all (parent) classes.	2022-09-12 15:47:14 +00:00
class-wp-privacy-requests-table.php	Docs: Document the globals used in some Privacy API methods.	2021-11-24 11:41:03 +00:00
class-wp-screen.php	Code Modernization: Add AllowDynamicProperties attribute to all (parent) classes.	2022-09-12 15:47:14 +00:00
class-wp-site-health-auto-updates.php	Code Modernization: Add AllowDynamicProperties attribute to all (parent) classes.	2022-09-12 15:47:14 +00:00
class-wp-site-health.php	Code Modernization: Add AllowDynamicProperties attribute to all (parent) classes.	2022-09-12 15:47:14 +00:00
class-wp-site-icon.php	Code Modernization: Add AllowDynamicProperties attribute to all (parent) classes.	2022-09-12 15:47:14 +00:00
class-wp-terms-list-table.php	Coding Standards: Use more meaningful variable names for output in the admin.	2022-09-05 17:19:09 +00:00
class-wp-theme-install-list-table.php	Themes: Add version to theme screenshot URL for better browser cache handling.	2022-03-17 22:21:07 +00:00
class-wp-themes-list-table.php	Themes: Add version to theme screenshot URL in WP_Themes_List_Table.	2022-03-18 12:44:04 +00:00
class-wp-upgrader-skin.php	Code Modernization: Add AllowDynamicProperties attribute to all (parent) classes.	2022-09-12 15:47:14 +00:00
class-wp-upgrader-skins.php	Docs: Add missing @deprecated tags in the file docblock of some deprecated files.	2019-10-08 17:19:04 +00:00
class-wp-upgrader.php	Code Modernization: Add AllowDynamicProperties attribute to all (parent) classes.	2022-09-12 15:47:14 +00:00
class-wp-users-list-table.php	Coding Standards: Use more meaningful variable names in WP_Users_List_Table.	2022-09-05 16:02:09 +00:00
comment.php	Docs: Use third-person singular verbs for function descriptions in wp-admin/includes/comment.php, as per docblocks standards.	2022-07-20 22:15:10 +00:00
continents-cities.php	I18N: Update list of continents and cities for the timezone selection.	2021-03-19 15:42:04 +00:00
credits.php	Help/About: Don't output empty <span> tags on Credits screen.	2021-10-19 23:09:00 +00:00
dashboard.php	Coding Standards: Use more meaningful variable names for output in the admin.	2022-09-05 17:19:09 +00:00
deprecated.php	Media: Remove attachment_fields_to_save filter and deprecate image_attachment_fields_to_save().	2022-04-20 08:13:10 +00:00
edit-tag-messages.php	Docs: Various inline documentation corrections and improvements.	2021-12-07 12:20:02 +00:00
export.php	Docs: Various docblock improvements in Export Administration API, as per docs standards.	2022-07-29 08:14:12 +00:00
file.php	Coding Standards: Clarify time units for various timeout or expiration values.	2022-09-09 08:16:18 +00:00
image-edit.php	Media: Output WebP by default when uploading JPEGs.	2022-09-06 21:15:08 +00:00
image.php	Media: Generate WebP only for certain registered image sizes.	2022-09-07 21:45:14 +00:00
import.php	Docs: Various docblock improvements in Importer Administration API, as per docs standards.	2022-07-29 09:22:10 +00:00
list-table.php	Code Modernization: Rename parameters that use reserved keywords in wp-admin/includes/list-table.php.	2022-04-15 10:52:11 +00:00
media.php	Media: Move wp_default_image_output_mapping() filter callback to frontend scope.	2022-09-07 15:41:15 +00:00
menu.php	Coding Standards: Correct the $items_count variable in add_menu_classes().	2022-04-17 14:44:07 +00:00
meta-boxes.php	Revisions: Use wp_get_latest_revision_id_and_total_count() where appropriate.	2022-08-05 13:39:11 +00:00
misc.php	Editor: Refresh nones for metaboxes after reauthentication.	2022-09-11 20:46:10 +00:00
ms-admin-filters.php	Docs: Improve comments in some wp-admin files per the documentation standards.	2020-01-29 00:35:08 +00:00
ms-deprecated.php	I18N: Capitalize translator comments consistently, add trailing punctuation.	2019-09-03 00:41:05 +00:00
ms.php	Code Modernization: Rename parameters that use reserved keywords in wp-admin/includes/ms.php.	2022-04-18 10:33:09 +00:00
nav-menu.php	Menus: Use correct parameter in _wp_nav_menu_meta_box_object().	2022-04-19 15:59:10 +00:00
network.php	Administration: Add labels to read-only form fields.	2022-07-21 09:04:14 +00:00
noop.php	Code Modernization: Remove conditional use of PHP realpath().	2019-09-20 20:46:56 +00:00
options.php	External Libraries: Further fix jQuery deprecations in WordPress core.	2021-11-30 17:18:01 +00:00
plugin-install.php	Coding standards: Properly escape URLs returned by self_admin_url() calls.	2022-08-05 06:12:10 +00:00
plugin.php	Docs: Remove code tags from WordPress function names within inline documentation.	2022-08-11 13:55:08 +00:00
post.php	Editor: Refresh nones for metaboxes after reauthentication.	2022-09-11 20:46:10 +00:00
privacy-tools.php	General: Replace all esc_url_raw() calls in core with sanitize_url().	2022-06-01 18:14:10 +00:00
revision.php	Revisions: Update the "last revision" wording to "latest revision" in various files.	2022-07-25 19:30:09 +00:00
schema.php	Administration: Change default site tagline to an empty string.	2022-08-03 12:20:16 +00:00
screen.php	Coding Standards: Use strict comparison in wp-admin/includes/screen.php.	2021-05-09 20:27:02 +00:00
taxonomy.php	Docs: Use third-person singular verbs for function descriptions in the Taxonomy Administration API.	2022-06-16 23:39:08 +00:00
template.php	Coding Standards: Use more meaningful variable names for output in the admin.	2022-09-05 17:19:09 +00:00
theme-install.php	Coding standards: Properly escape URLs returned by self_admin_url() calls.	2022-08-05 06:00:09 +00:00
theme.php	General: Replace all esc_url_raw() calls in core with sanitize_url().	2022-06-01 18:14:10 +00:00
translation-install.php	Docs: Fix incorrect type in translations_api and translations_api_result docblocks.	2022-01-27 21:15:03 +00:00
update-core.php	Upgrade/Install: Update $_old_files for 6.0.	2022-05-23 17:02:16 +00:00
update.php	Docs: Improve description for wp_plugin_update_rows() and wp_theme_update_rows().	2022-07-09 12:59:11 +00:00
upgrade.php	Database: Ignore display width for integer data types in dbDelta() on MySQL 8.0.17 or later.	2022-08-15 13:18:13 +00:00
user.php	Text Changes: Improve consistency of admin error notices.	2022-06-02 15:05:13 +00:00
widgets.php	Docs: Capitalize "ID", when referring to a widget ID or sidebar ID, in a more consistent way.	2021-12-13 10:21:07 +00:00