WordPress/wp-admin
whyisjake 471fc1e913 Media: Pass the appropriate reference into wp_getimagesize.
With changes that were introduced in [49889] the second parameter for getimagesize() function is expecting a a reference.

Previously, most calls did not pass the 2nd param, and as a result, we are getting unexpected results.

This was only a problem with applications that are using a custom stream wrapper, and the image contained EXIF data.

For more see:

* https://github.com/humanmade/S3-Uploads/issues/496
* https://github.com/aws/aws-sdk-php/issues/1923

Fixes #52826.
Props terriann, SergeyBiryukov, Mista-Flo, hellofromTonya, rinatkhaziev, whyisjake.


Built from https://develop.svn.wordpress.org/trunk@50552


git-svn-id: http://core.svn.wordpress.org/trunk@50165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-19 00:01:03 +00:00
..
css Administration: Make focus states consistent in admin menu when collapsed. 2021-03-18 21:44:09 +00:00
images Help/About: WordPress 5.7 About Page. 2021-02-23 18:41:05 +00:00
includes Media: Pass the appropriate reference into wp_getimagesize. 2021-03-19 00:01:03 +00:00
js External Libraries: Further fix jQuery deprecations in WordPress core. 2021-03-18 19:01:03 +00:00
maint Database: Check the correct value for displaying the "Successfully repaired table" or "Failed to repair" messages on Database Repair screen. 2020-12-04 15:50:12 +00:00
network I18N: Add context for the Public string in site attributes list on Edit Site screen. 2021-01-15 17:39:12 +00:00
user Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
about.php Help/About: Run image comparison script after all assets have loaded. 2021-03-15 19:51:09 +00:00
admin-ajax.php Login and Registration: Improve the UX of the Reset Password screen. 2021-02-02 18:13:04 +00:00
admin-footer.php Coding Standards: Use strict comparison for JS fragment in some admin files. 2021-03-18 14:13:08 +00:00
admin-functions.php Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
admin-header.php Block Editor: Remove the .is-dark-theme body class from the admin header. 2021-02-02 13:05:02 +00:00
admin-post.php Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
admin.php Upgrade/Install: Don't trigger database upgrade on Ajax requests via wp-admin/async-upload.php. 2020-07-22 12:56:04 +00:00
async-upload.php Docs: Add examples of possible names for various hooks whose name contains a dynamic portion. 2021-03-07 12:32:09 +00:00
authorize-application.php App Passwords: Extract Basic Auth check into a reusable filterable function. 2021-01-24 02:57:59 +00:00
comment.php Docs: Update the URL for PHP date formats table in translator comments. 2020-09-18 10:37:08 +00:00
credits.php Help/About: Use absolute URLs for inline images on About pages. 2021-03-11 21:38:08 +00:00
custom-background.php Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
custom-header.php Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
customize.php Docs: Correct documentation for customize_controls_head hook and _customizer_mobile_viewport_meta() function. 2020-07-10 11:36:07 +00:00
edit-comments.php Quick/Bulk Edit: By the power vested in me, I hereby declare the top bulk actions and the bottom bulk actions joined forever in MatrimonyScript. 2021-01-07 16:23:07 +00:00
edit-form-advanced.php Docs: Update the URL for PHP date formats table in translator comments. 2020-09-18 10:37:08 +00:00
edit-form-blocks.php Block Editor: Remove extra quotes from the default font stack for editor styles. 2021-02-12 07:55:06 +00:00
edit-form-comment.php Docs: Update the URL for PHP date formats table in translator comments. 2020-09-18 10:37:08 +00:00
edit-link-form.php Posts, Post Types: Update the styling of the legacy Links editing screen. 2021-02-16 18:50:03 +00:00
edit-tag-form.php Docs: Add examples of possible names for various hooks whose name contains a dynamic portion. 2021-03-07 12:32:09 +00:00
edit-tags.php Docs: Add examples of possible names for various hooks whose name contains a dynamic portion. 2021-03-07 12:32:09 +00:00
edit.php Coding Standards: Split long printf() calls for search results for better readability. 2020-10-23 17:19:14 +00:00
erase-personal-data.php I18N: Remove extra spaces from translatable strings in Privacy help tabs. 2021-02-21 16:04:11 +00:00
export-personal-data.php I18N: Remove extra spaces from translatable strings in Privacy help tabs. 2021-02-21 16:04:11 +00:00
export.php External Libraries: First pass at fixing jQuery deprecations in WordPress core and bundled themes. 2021-01-22 12:32:03 +00:00
freedoms.php Help/About: Use absolute URLs for inline images on About pages. 2021-03-11 21:38:08 +00:00
import.php I18N: Add context to some plugin and theme strings for consistency. 2020-07-20 23:14:05 +00:00
index.php Help/About: Add Site Health Status dashboard widget to the Help → Content tab. 2020-11-10 19:05:10 +00:00
install-helper.php Docs: Improve documentation for functions in wp-admin/install-helper.php per the documentation standards. 2020-05-12 18:40:07 +00:00
install.php Site Health: Improve the error message displayed when activating a plugin that requires a higher version of PHP or WordPress. 2020-06-26 00:27:09 +00:00
link-add.php Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
link-manager.php Coding Standards: Split long printf() calls for search results for better readability. 2020-10-23 17:19:14 +00:00
link-parse-opml.php XML-RPC: Explicitly unset the reference to the parser resource after calling xml_parser_free() to avoid memory leaks in PHP 7.0.0 or higher. 2020-07-05 15:22:01 +00:00
link.php Coding Standards: Replace alias PHP functions with the canonical names. 2020-10-18 17:27:06 +00:00
load-scripts.php Coding Standards: Fix instances of Generic.WhiteSpace.ArbitraryParenthesesSpacing.FoundEmpty. 2020-05-26 09:37:10 +00:00
load-styles.php Coding Standards: Fix instances of Generic.WhiteSpace.ArbitraryParenthesesSpacing.FoundEmpty. 2020-05-26 09:37:10 +00:00
media-new.php Coding standards: Modify escaping functions to avoid potential false positives. 2020-10-29 18:03:11 +00:00
media-upload.php Docs: Add examples of possible names for various hooks whose name contains a dynamic portion. 2021-03-07 12:32:09 +00:00
media.php Coding Standards: Fix instances of Generic.WhiteSpace.ArbitraryParenthesesSpacing.FoundEmpty. 2020-05-26 09:37:10 +00:00
menu-header.php Coding Standards: Replace alias PHP functions with the canonical names. 2020-10-18 17:27:06 +00:00
menu.php Docs: Update the reference to Appearance → Theme Editor admin menu item in the inline documentation. 2020-12-18 15:46:04 +00:00
moderation.php Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
ms-admin.php Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
ms-delete-site.php Docs: Various docblock improvements related to user and site signup functionality. 2020-09-30 21:54:07 +00:00
ms-edit.php Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
ms-options.php Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
ms-sites.php Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
ms-themes.php Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
ms-upgrade-network.php Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
ms-users.php Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
my-sites.php Coding Standards: Use strict comparison in some wp-admin files. 2020-05-12 18:32:08 +00:00
nav-menus.php Administration: Better targeting for required form field highlighting. 2020-10-23 15:05:09 +00:00
network.php Coding Standards: Use strict comparison for count() calls. 2020-05-23 11:38:08 +00:00
options-discussion.php General: Update code for readability and inclusion 2020-07-23 03:14:06 +00:00
options-general.php Docs: Update the URL for PHP date formats table in translator comments. 2020-09-18 10:37:08 +00:00
options-head.php Administration: Replace legacy updated message type in add_settings_error() calls with success. 2019-08-16 00:39:55 +00:00
options-media.php Docs: Correct and clarify an inline comment about the upload_url_path and upload_path options in wp-admin/options-media.php. 2020-06-01 11:22:13 +00:00
options-permalink.php Permalinks: Don't show "You should update your .htaccess file now" message when saving permalink settings on Multisite. 2020-08-02 12:57:08 +00:00
options-privacy.php Privacy: Redesign the Privacy settings pages. 2021-02-02 20:14:03 +00:00
options-reading.php Help/About: Clarify that discouraging search engines does not prevent them from crawling the site. 2020-10-23 18:07:13 +00:00
options-writing.php Docs: Second pass at replacing Codex URLs with a corresponding HelpHub or DevHub article. 2020-12-29 20:14:11 +00:00
options.php Docs: Correct the alternative hook name for the deprecated whitelist_options hook. 2021-02-17 12:42:03 +00:00
plugin-editor.php Administration: Remove italic text to improve readability. 2021-01-27 21:03:57 +00:00
plugin-install.php Accessibility: Plugins: Accessibility and CSS improvements for the Plugins pages. 2020-07-03 08:51:05 +00:00
plugins.php Plugins: Check if _error_nonce is set before attempting to verify it. 2020-11-23 13:36:07 +00:00
post-new.php Coding Standards: Use strict comparison where static strings are involved. 2020-05-16 18:42:12 +00:00
post.php Block Editor: Use a unique name for the nonce of the custom fields toggle form. 2021-02-08 21:39:16 +00:00
press-this.php Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
privacy-policy-guide.php Privacy: Redesign the Privacy settings pages. 2021-02-02 20:14:03 +00:00
privacy.php Help/About: Use absolute URLs for inline images on About pages. 2021-03-11 21:38:08 +00:00
profile.php Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
revision.php Text Changes: Unify various "Back to..." vs. "Return to..." vs. "Go to..." strings. 2020-11-09 10:53:10 +00:00
setup-config.php Docs: Upgrade more parameters in docblocks to used typed array notation. 2020-11-24 21:27:05 +00:00
site-health-info.php Accessibility: Site Health: Improve the "Copy site info" button accessibility. 2020-06-30 13:26:03 +00:00
site-health.php Security, Site Health: Make migrating a site to HTTPS a one-click interaction. 2021-02-02 00:10:01 +00:00
term.php Coding Standards: Use strict type check for in_array() and array_search() where strings are involved. 2020-04-05 03:02:11 +00:00
theme-editor.php Administration: Remove italic text to improve readability. 2021-01-27 21:03:57 +00:00
theme-install.php Docs: Add examples of possible names for various hooks whose name contains a dynamic portion. 2021-03-07 12:32:09 +00:00
themes.php Customize: Update button label reference in themes help text to reflect the label introduced in [41626]. 2021-01-17 17:01:08 +00:00
tools.php Privacy: Redesign the Privacy settings pages. 2021-02-02 20:14:03 +00:00
update-core.php Upgrade/Install: Display version number on the "Update now" button on WordPress Updates screen. 2021-03-08 11:31:09 +00:00
update.php Upgrade/Install: Ensure cleanup after canceled update. 2020-07-10 06:08:06 +00:00
upgrade-functions.php Code Modernization: Replace dirname( __FILE__ ) calls with __DIR__ magic constant. 2020-02-06 06:33:11 +00:00
upgrade.php Site Health: Improve the error message displayed when activating a plugin that requires a higher version of PHP or WordPress. 2020-06-26 00:27:09 +00:00
upload.php Coding Standards: Split long printf() calls for search results for better readability. 2020-10-23 17:19:14 +00:00
user-edit.php Users: Give the Password Reset table row its own wrapper class. 2021-02-23 14:35:03 +00:00
user-new.php Coding Standards: Remove unused $current_role variable from Add New User form. 2020-10-24 12:49:05 +00:00
users.php Users: Allow the role of users to be bulk changed to no role from the Users listing screen. 2021-02-05 14:40:08 +00:00
widgets.php Accessibility: Widgets: Add a "Cancel" link when editing a widget in accessibility mode. 2020-10-09 15:53:08 +00:00