mirror of
https://github.com/WordPress/WordPress.git
synced 2024-12-22 17:18:32 +01:00
9bf6faff7c
`_wp_array_get()` is an expensive function, and it's called thousands of times on each page view on the front end. While the function performance was slightly improved in #58376, it is still called more times than it should be. This commit aims to further optimize its usage: * In many cases, `_wp_array_get()` can be replaced with a much simpler and faster `isset()` check. * The `isset()` function is capable of checking nested arrays, so `isset( $foo['a']['b']['c'] )` will return false even if `$foo['a']` is unset, without throwing any errors or warnings. * When `_wp_array_get()` cannot be directly replaced with `isset()`, it would be good practice to wrap it in an `isset()` function so that `_wp_array_get()` only runs when it needs to. Original PR from Gutenberg repository: * [https://github.com/WordPress/gutenberg/pull/51116 #51116 Performance improvement: Reduce the use of the _wp_array_get() function] Follow-up to [55851], [56382]. Props aristath, jrf, spacedmonkey, mukesh27, swissspidy, hellofromTonya. Fixes #59405. Built from https://develop.svn.wordpress.org/trunk@56709 git-svn-id: http://core.svn.wordpress.org/trunk@56221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
90 lines
2.8 KiB
PHP
90 lines
2.8 KiB
PHP
<?php
|
|
/**
|
|
* Spacing block support flag.
|
|
*
|
|
* For backwards compatibility, this remains separate to the dimensions.php
|
|
* block support despite both belonging under a single panel in the editor.
|
|
*
|
|
* @package WordPress
|
|
* @since 5.8.0
|
|
*/
|
|
|
|
/**
|
|
* Registers the style block attribute for block types that support it.
|
|
*
|
|
* @since 5.8.0
|
|
* @access private
|
|
*
|
|
* @param WP_Block_Type $block_type Block Type.
|
|
*/
|
|
function wp_register_spacing_support( $block_type ) {
|
|
$has_spacing_support = block_has_support( $block_type, 'spacing', false );
|
|
|
|
// Setup attributes and styles within that if needed.
|
|
if ( ! $block_type->attributes ) {
|
|
$block_type->attributes = array();
|
|
}
|
|
|
|
if ( $has_spacing_support && ! array_key_exists( 'style', $block_type->attributes ) ) {
|
|
$block_type->attributes['style'] = array(
|
|
'type' => 'object',
|
|
);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Adds CSS classes for block spacing to the incoming attributes array.
|
|
* This will be applied to the block markup in the front-end.
|
|
*
|
|
* @since 5.8.0
|
|
* @since 6.1.0 Implemented the style engine to generate CSS and classnames.
|
|
* @access private
|
|
*
|
|
* @param WP_Block_Type $block_type Block Type.
|
|
* @param array $block_attributes Block attributes.
|
|
* @return array Block spacing CSS classes and inline styles.
|
|
*/
|
|
function wp_apply_spacing_support( $block_type, $block_attributes ) {
|
|
if ( wp_should_skip_block_supports_serialization( $block_type, 'spacing' ) ) {
|
|
return array();
|
|
}
|
|
|
|
$attributes = array();
|
|
$has_padding_support = block_has_support( $block_type, array( 'spacing', 'padding' ), false );
|
|
$has_margin_support = block_has_support( $block_type, array( 'spacing', 'margin' ), false );
|
|
$block_styles = isset( $block_attributes['style'] ) ? $block_attributes['style'] : null;
|
|
|
|
if ( ! $block_styles ) {
|
|
return $attributes;
|
|
}
|
|
|
|
$skip_padding = wp_should_skip_block_supports_serialization( $block_type, 'spacing', 'padding' );
|
|
$skip_margin = wp_should_skip_block_supports_serialization( $block_type, 'spacing', 'margin' );
|
|
$spacing_block_styles = array(
|
|
'padding' => null,
|
|
'margin' => null,
|
|
);
|
|
if ( $has_padding_support && ! $skip_padding ) {
|
|
$spacing_block_styles['padding'] = isset( $block_styles['spacing']['padding'] ) ? $block_styles['spacing']['padding'] : null;
|
|
}
|
|
if ( $has_margin_support && ! $skip_margin ) {
|
|
$spacing_block_styles['margin'] = isset( $block_styles['spacing']['margin'] ) ? $block_styles['spacing']['margin'] : null;
|
|
}
|
|
$styles = wp_style_engine_get_styles( array( 'spacing' => $spacing_block_styles ) );
|
|
|
|
if ( ! empty( $styles['css'] ) ) {
|
|
$attributes['style'] = $styles['css'];
|
|
}
|
|
|
|
return $attributes;
|
|
}
|
|
|
|
// Register the block support.
|
|
WP_Block_Supports::get_instance()->register(
|
|
'spacing',
|
|
array(
|
|
'register_attribute' => 'wp_register_spacing_support',
|
|
'apply' => 'wp_apply_spacing_support',
|
|
)
|
|
);
|