Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-17 08:05:21 +01:00
Code Issues Projects Releases Wiki Activity
5b643782b6
WordPress/wp-includes
History
Boone Gorges d8ab8aa97c In Walker_CategoryDropdown::start_el(), cast values to strings before deciding whether to append 'selected' attribute. 
As of [32484], `wp_dropdown_categories()` uses the `$value_field` value to
decide whether a given `<option>` should be 'selected'. However, `$value_field`
can refer to a value that is a string, such as a category's slug. This causes
problems when doing a loose comparison (`==`) with the value of the 'selected'
parameter, which defaults to `0`, because when doing a loose comparison
between an integer and a string, PHP will cast the string to an integer. This
creates false matches, resulting in `<option>` elements getting a 'selected'
attribute incorrectly.

We address the issue by casting the comparison values to strings, and then
using the strict comparison operator `===`.

Merges [33681] to the 4.3 branch.

Fixes #33452 for 4.3.1.

Built from https://develop.svn.wordpress.org/branches/4.3@33949


git-svn-id: http://core.svn.wordpress.org/branches/4.3@33918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-08 19:04:23 +00:00
..
certificates Revert [33845] 2015-09-03 03:33:24 +00:00
css Customize: Fix logic for determining the container element when focusing on a panel, section, or control. 2015-09-07 06:05:23 +00:00
fonts Revert [33845] 2015-09-03 03:33:24 +00:00
ID3 Revert [33845] 2015-09-03 03:33:24 +00:00
images Revert [33845] 2015-09-03 03:33:24 +00:00
js Revert [33845] 2015-09-03 03:33:24 +00:00
pomo Revert [33845] 2015-09-03 03:33:24 +00:00
SimplePie Revert [33845] 2015-09-03 03:33:24 +00:00
Text Revert [33845] 2015-09-03 03:33:24 +00:00
theme-compat Revert [33845] 2015-09-03 03:33:24 +00:00
admin-bar.php Revert [33845] 2015-09-03 03:33:24 +00:00
atomlib.php Revert [33845] 2015-09-03 03:33:24 +00:00
author-template.php Revert [33845] 2015-09-03 03:33:24 +00:00
bookmark-template.php Revert [33845] 2015-09-03 03:33:24 +00:00
bookmark.php Revert [33845] 2015-09-03 03:33:24 +00:00
cache.php Revert [33845] 2015-09-03 03:33:24 +00:00
canonical.php Revert [33845] 2015-09-03 03:33:24 +00:00
capabilities.php Revert [33845] 2015-09-03 03:33:24 +00:00
category-template.php In Walker_CategoryDropdown::start_el(), cast values to strings before deciding whether to append 'selected' attribute. 2015-09-08 19:04:23 +00:00
category.php Revert [33845] 2015-09-03 03:33:24 +00:00
class-feed.php Revert [33845] 2015-09-03 03:33:24 +00:00
class-http.php Revert [33845] 2015-09-03 03:33:24 +00:00
class-IXR.php Revert [33845] 2015-09-03 03:33:24 +00:00
class-json.php Revert [33845] 2015-09-03 03:33:24 +00:00
class-oembed.php Revert [33845] 2015-09-03 03:33:24 +00:00
class-phpass.php Revert [33845] 2015-09-03 03:33:24 +00:00
class-phpmailer.php Revert [33845] 2015-09-03 03:33:24 +00:00
class-pop3.php Revert [33845] 2015-09-03 03:33:24 +00:00
class-simplepie.php Revert [33845] 2015-09-03 03:33:24 +00:00
class-smtp.php Revert [33845] 2015-09-03 03:33:24 +00:00
class-snoopy.php Revert [33845] 2015-09-03 03:33:24 +00:00
class-wp-admin-bar.php Revert [33845] 2015-09-03 03:33:24 +00:00
class-wp-ajax-response.php Revert [33845] 2015-09-03 03:33:24 +00:00
class-wp-customize-control.php Revert [33845] 2015-09-03 03:33:24 +00:00
class-wp-customize-manager.php Revert [33845] 2015-09-03 03:33:24 +00:00
class-wp-customize-nav-menus.php Revert [33845] 2015-09-03 03:33:24 +00:00
class-wp-customize-panel.php Revert [33845] 2015-09-03 03:33:24 +00:00
class-wp-customize-section.php Revert [33845] 2015-09-03 03:33:24 +00:00
class-wp-customize-setting.php Revert [33845] 2015-09-03 03:33:24 +00:00
class-wp-customize-widgets.php Revert [33845] 2015-09-03 03:33:24 +00:00
class-wp-editor.php Revert [33845] 2015-09-03 03:33:24 +00:00
class-wp-embed.php Revert [33845] 2015-09-03 03:33:24 +00:00
class-wp-error.php Revert [33845] 2015-09-03 03:33:24 +00:00
class-wp-http-ixr-client.php Revert [33845] 2015-09-03 03:33:24 +00:00
class-wp-image-editor-gd.php Revert [33845] 2015-09-03 03:33:24 +00:00
class-wp-image-editor-imagick.php Revert [33845] 2015-09-03 03:33:24 +00:00
class-wp-image-editor.php Revert [33845] 2015-09-03 03:33:24 +00:00
class-wp-theme.php Revert [33845] 2015-09-03 03:33:24 +00:00
class-wp-walker.php Revert [33845] 2015-09-03 03:33:24 +00:00
class-wp-xmlrpc-server.php Revert [33845] 2015-09-03 03:33:24 +00:00
class-wp.php Revert [33845] 2015-09-03 03:33:24 +00:00
class.wp-dependencies.php Revert [33845] 2015-09-03 03:33:24 +00:00
class.wp-scripts.php Revert [33845] 2015-09-03 03:33:24 +00:00
class.wp-styles.php Revert [33845] 2015-09-03 03:33:24 +00:00
comment-template.php Revert [33845] 2015-09-03 03:33:24 +00:00
comment.php Revert [33845] 2015-09-03 03:33:24 +00:00
compat.php Revert [33845] 2015-09-03 03:33:24 +00:00
cron.php Revert [33845] 2015-09-03 03:33:24 +00:00
date.php Revert [33845] 2015-09-03 03:33:24 +00:00
default-constants.php Revert [33845] 2015-09-03 03:33:24 +00:00
default-filters.php Revert [33845] 2015-09-03 03:33:24 +00:00
default-widgets.php Customizer: Collapse any expanded panel/sections before expanding other panel/sections. 2015-09-07 06:20:23 +00:00
deprecated.php Revert [33845] 2015-09-03 03:33:24 +00:00
feed-atom-comments.php Revert [33845] 2015-09-03 03:33:24 +00:00
feed-atom.php Revert [33845] 2015-09-03 03:33:24 +00:00
feed-rdf.php Revert [33845] 2015-09-03 03:33:24 +00:00
feed-rss2-comments.php Revert [33845] 2015-09-03 03:33:24 +00:00
feed-rss2.php Revert [33845] 2015-09-03 03:33:24 +00:00
feed-rss.php Revert [33845] 2015-09-03 03:33:24 +00:00
feed.php Revert [33845] 2015-09-03 03:33:24 +00:00
formatting.php Revert [33845] 2015-09-03 03:33:24 +00:00
functions.php Revert [33845] 2015-09-03 03:33:24 +00:00
functions.wp-scripts.php Revert [33845] 2015-09-03 03:33:24 +00:00
functions.wp-styles.php Revert [33845] 2015-09-03 03:33:24 +00:00
general-template.php Revert [33845] 2015-09-03 03:33:24 +00:00
http.php Revert [33845] 2015-09-03 03:33:24 +00:00
kses.php Revert [33845] 2015-09-03 03:33:24 +00:00
l10n.php Revert [33845] 2015-09-03 03:33:24 +00:00
link-template.php Revert [33845] 2015-09-03 03:33:24 +00:00
load.php Revert [33845] 2015-09-03 03:33:24 +00:00
locale.php Revert [33845] 2015-09-03 03:33:24 +00:00
media-template.php Revert [33845] 2015-09-03 03:33:24 +00:00
media.php Revert [33845] 2015-09-03 03:33:24 +00:00
meta.php Revert [33845] 2015-09-03 03:33:24 +00:00
ms-blogs.php Revert [33845] 2015-09-03 03:33:24 +00:00
ms-default-constants.php Revert [33845] 2015-09-03 03:33:24 +00:00
ms-default-filters.php Revert [33845] 2015-09-03 03:33:24 +00:00
ms-deprecated.php Revert [33845] 2015-09-03 03:33:24 +00:00
ms-files.php Revert [33845] 2015-09-03 03:33:24 +00:00
ms-functions.php Revert [33845] 2015-09-03 03:33:24 +00:00
ms-load.php Revert [33845] 2015-09-03 03:33:24 +00:00
ms-settings.php Revert [33845] 2015-09-03 03:33:24 +00:00
nav-menu-template.php Revert [33845] 2015-09-03 03:33:24 +00:00
nav-menu.php Revert [33845] 2015-09-03 03:33:24 +00:00
option.php Revert [33845] 2015-09-03 03:33:24 +00:00
pluggable-deprecated.php Revert [33845] 2015-09-03 03:33:24 +00:00
pluggable.php Revert [33845] 2015-09-03 03:33:24 +00:00
plugin.php Revert [33845] 2015-09-03 03:33:24 +00:00
post-formats.php Revert [33845] 2015-09-03 03:33:24 +00:00
post-template.php Revert [33845] 2015-09-03 03:33:24 +00:00
post-thumbnail-template.php Revert [33845] 2015-09-03 03:33:24 +00:00
post.php Revert [33845] 2015-09-03 03:33:24 +00:00
query.php Revert [33845] 2015-09-03 03:33:24 +00:00
registration-functions.php Revert [33845] 2015-09-03 03:33:24 +00:00
registration.php Revert [33845] 2015-09-03 03:33:24 +00:00
revision.php Revert [33845] 2015-09-03 03:33:24 +00:00
rewrite.php Revert [33845] 2015-09-03 03:33:24 +00:00
rss-functions.php Revert [33845] 2015-09-03 03:33:24 +00:00
rss.php Revert [33845] 2015-09-03 03:33:24 +00:00
script-loader.php Revert [33845] 2015-09-03 03:33:24 +00:00
session.php Revert [33845] 2015-09-03 03:33:24 +00:00
shortcodes.php Revert [33845] 2015-09-03 03:33:24 +00:00
taxonomy.php WP_Filesystem: SSH2 handler: Remove support for is_writable() via SSH, it turns out PHP doesn't verify the writability via SFTP and instead uses a comparison based on the current php system process user instead of the ssh user. 2015-09-03 04:38:15 +00:00
template-loader.php Revert [33845] 2015-09-03 03:33:24 +00:00
template.php Revert [33845] 2015-09-03 03:33:24 +00:00
theme.php Revert [33845] 2015-09-03 03:33:24 +00:00
update.php Revert [33845] 2015-09-03 03:33:24 +00:00
user.php Revert [33845] 2015-09-03 03:33:24 +00:00
vars.php Revert [33845] 2015-09-03 03:33:24 +00:00
version.php WP_Filesystem: SSH2 handler: Remove support for is_writable() via SSH, it turns out PHP doesn't verify the writability via SFTP and instead uses a comparison based on the current php system process user instead of the ssh user. 2015-09-03 04:38:15 +00:00
widgets.php WP_Filesystem: SSH2 handler: Remove support for is_writable() via SSH, it turns out PHP doesn't verify the writability via SFTP and instead uses a comparison based on the current php system process user instead of the ssh user. 2015-09-03 04:38:15 +00:00
wlwmanifest.xml Revert [33845] 2015-09-03 03:33:24 +00:00
wp-db.php Revert [33845] 2015-09-03 03:33:24 +00:00
wp-diff.php Revert [33845] 2015-09-03 03:33:24 +00:00