mirror of
https://github.com/WordPress/WordPress.git
synced 2024-12-24 10:09:47 +01:00
c03305852e
Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0. There are a number of ways to mitigate this: * If it is an accidental typo for a declared property: fix the typo. * For known properties: declare them on the class. * For unknown properties: add the magic `__get()`, `__set()`, et al. methods to the class or let the class extend `stdClass` which has highly optimized versions of these magic methods built in. * For unknown ''use'' of dynamic properties, the `#[AllowDynamicProperties]` attribute can be added to the class. The attribute will automatically be inherited by child classes. Trac ticket #56034 is open to investigate and handle the third and fourth type of situations, however it has become clear this will need more time and will not be ready in time for WP 6.1. To reduce “noise” in the meantime, both in the error logs of WP users moving onto PHP 8.2, in the test run logs of WP itself, in test runs of plugins and themes, as well as to prevent duplicate tickets from being opened for the same issue, this commit adds the `#[AllowDynamicProperties]` attribute to all “parent” classes in WP. The logic used for this commit is as follows: * If a class already has the attribute: no action needed. * If a class does not `extend`: add the attribute. * If a class does `extend`: - If it extends `stdClass`: no action needed (as `stdClass` supports dynamic properties). - If it extends a PHP native class: add the attribute. - If it extends a class from one of WP's external dependencies: add the attribute. * In all other cases: no action — the attribute should not be needed as child classes inherit from the parent. Whether or not a class contains magic methods has not been taken into account, as a review of the currently existing magic methods has shown that those are generally not sturdy enough and often even set dynamic properties (which they should not). See the [https://www.youtube.com/watch?v=vDZWepDQQVE live stream from August 16, 2022] for more details. This commit only affects classes in the `src` directory of WordPress core. * Tests should not get this attribute, but should be fixed to not use dynamic properties instead. Patches for this are already being committed under ticket #56033. * While a number bundled themes (2014, 2019, 2020, 2021) contain classes, they are not a part of this commit and may be updated separately. Reference: [https://wiki.php.net/rfc/deprecate_dynamic_properties PHP RFC: Deprecate dynamic properties]. Follow-up to [53922]. Props jrf, hellofromTonya, markjaquith, peterwilsoncc, costdev, knutsp, aristath. See #56513, #56034. Built from https://develop.svn.wordpress.org/trunk@54133 git-svn-id: http://core.svn.wordpress.org/trunk@53692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
228 lines
5.8 KiB
PHP
228 lines
5.8 KiB
PHP
<?php
|
|
/**
|
|
* HTTP API: WP_HTTP_Proxy class
|
|
*
|
|
* @package WordPress
|
|
* @subpackage HTTP
|
|
* @since 4.4.0
|
|
*/
|
|
|
|
/**
|
|
* Core class used to implement HTTP API proxy support.
|
|
*
|
|
* There are caveats to proxy support. It requires that defines be made in the wp-config.php file to
|
|
* enable proxy support. There are also a few filters that plugins can hook into for some of the
|
|
* constants.
|
|
*
|
|
* Please note that only BASIC authentication is supported by most transports.
|
|
* cURL MAY support more methods (such as NTLM authentication) depending on your environment.
|
|
*
|
|
* The constants are as follows:
|
|
* <ol>
|
|
* <li>WP_PROXY_HOST - Enable proxy support and host for connecting.</li>
|
|
* <li>WP_PROXY_PORT - Proxy port for connection. No default, must be defined.</li>
|
|
* <li>WP_PROXY_USERNAME - Proxy username, if it requires authentication.</li>
|
|
* <li>WP_PROXY_PASSWORD - Proxy password, if it requires authentication.</li>
|
|
* <li>WP_PROXY_BYPASS_HOSTS - Will prevent the hosts in this list from going through the proxy.
|
|
* You do not need to have localhost and the site host in this list, because they will not be passed
|
|
* through the proxy. The list should be presented in a comma separated list, wildcards using * are supported. Example: *.wordpress.org</li>
|
|
* </ol>
|
|
*
|
|
* An example can be as seen below.
|
|
*
|
|
* define('WP_PROXY_HOST', '192.168.84.101');
|
|
* define('WP_PROXY_PORT', '8080');
|
|
* define('WP_PROXY_BYPASS_HOSTS', 'localhost, www.example.com, *.wordpress.org');
|
|
*
|
|
* @link https://core.trac.wordpress.org/ticket/4011 Proxy support ticket in WordPress.
|
|
* @link https://core.trac.wordpress.org/ticket/14636 Allow wildcard domains in WP_PROXY_BYPASS_HOSTS
|
|
*
|
|
* @since 2.8.0
|
|
*/
|
|
#[AllowDynamicProperties]
|
|
class WP_HTTP_Proxy {
|
|
|
|
/**
|
|
* Whether proxy connection should be used.
|
|
*
|
|
* Constants which control this behaviour:
|
|
*
|
|
* - `WP_PROXY_HOST`
|
|
* - `WP_PROXY_PORT`
|
|
*
|
|
* @since 2.8.0
|
|
*
|
|
* @return bool
|
|
*/
|
|
public function is_enabled() {
|
|
return defined( 'WP_PROXY_HOST' ) && defined( 'WP_PROXY_PORT' );
|
|
}
|
|
|
|
/**
|
|
* Whether authentication should be used.
|
|
*
|
|
* Constants which control this behaviour:
|
|
*
|
|
* - `WP_PROXY_USERNAME`
|
|
* - `WP_PROXY_PASSWORD`
|
|
*
|
|
* @since 2.8.0
|
|
*
|
|
* @return bool
|
|
*/
|
|
public function use_authentication() {
|
|
return defined( 'WP_PROXY_USERNAME' ) && defined( 'WP_PROXY_PASSWORD' );
|
|
}
|
|
|
|
/**
|
|
* Retrieve the host for the proxy server.
|
|
*
|
|
* @since 2.8.0
|
|
*
|
|
* @return string
|
|
*/
|
|
public function host() {
|
|
if ( defined( 'WP_PROXY_HOST' ) ) {
|
|
return WP_PROXY_HOST;
|
|
}
|
|
|
|
return '';
|
|
}
|
|
|
|
/**
|
|
* Retrieve the port for the proxy server.
|
|
*
|
|
* @since 2.8.0
|
|
*
|
|
* @return string
|
|
*/
|
|
public function port() {
|
|
if ( defined( 'WP_PROXY_PORT' ) ) {
|
|
return WP_PROXY_PORT;
|
|
}
|
|
|
|
return '';
|
|
}
|
|
|
|
/**
|
|
* Retrieve the username for proxy authentication.
|
|
*
|
|
* @since 2.8.0
|
|
*
|
|
* @return string
|
|
*/
|
|
public function username() {
|
|
if ( defined( 'WP_PROXY_USERNAME' ) ) {
|
|
return WP_PROXY_USERNAME;
|
|
}
|
|
|
|
return '';
|
|
}
|
|
|
|
/**
|
|
* Retrieve the password for proxy authentication.
|
|
*
|
|
* @since 2.8.0
|
|
*
|
|
* @return string
|
|
*/
|
|
public function password() {
|
|
if ( defined( 'WP_PROXY_PASSWORD' ) ) {
|
|
return WP_PROXY_PASSWORD;
|
|
}
|
|
|
|
return '';
|
|
}
|
|
|
|
/**
|
|
* Retrieve authentication string for proxy authentication.
|
|
*
|
|
* @since 2.8.0
|
|
*
|
|
* @return string
|
|
*/
|
|
public function authentication() {
|
|
return $this->username() . ':' . $this->password();
|
|
}
|
|
|
|
/**
|
|
* Retrieve header string for proxy authentication.
|
|
*
|
|
* @since 2.8.0
|
|
*
|
|
* @return string
|
|
*/
|
|
public function authentication_header() {
|
|
return 'Proxy-Authorization: Basic ' . base64_encode( $this->authentication() );
|
|
}
|
|
|
|
/**
|
|
* Determines whether the request should be sent through a proxy.
|
|
*
|
|
* We want to keep localhost and the site URL from being sent through the proxy, because
|
|
* some proxies can not handle this. We also have the constant available for defining other
|
|
* hosts that won't be sent through the proxy.
|
|
*
|
|
* @since 2.8.0
|
|
*
|
|
* @param string $uri URL of the request.
|
|
* @return bool Whether to send the request through the proxy.
|
|
*/
|
|
public function send_through_proxy( $uri ) {
|
|
$check = parse_url( $uri );
|
|
|
|
// Malformed URL, can not process, but this could mean ssl, so let through anyway.
|
|
if ( false === $check ) {
|
|
return true;
|
|
}
|
|
|
|
$home = parse_url( get_option( 'siteurl' ) );
|
|
|
|
/**
|
|
* Filters whether to preempt sending the request through the proxy.
|
|
*
|
|
* Returning false will bypass the proxy; returning true will send
|
|
* the request through the proxy. Returning null bypasses the filter.
|
|
*
|
|
* @since 3.5.0
|
|
*
|
|
* @param bool|null $override Whether to send the request through the proxy. Default null.
|
|
* @param string $uri URL of the request.
|
|
* @param array $check Associative array result of parsing the request URL with `parse_url()`.
|
|
* @param array $home Associative array result of parsing the site URL with `parse_url()`.
|
|
*/
|
|
$result = apply_filters( 'pre_http_send_through_proxy', null, $uri, $check, $home );
|
|
if ( ! is_null( $result ) ) {
|
|
return $result;
|
|
}
|
|
|
|
if ( 'localhost' === $check['host'] || ( isset( $home['host'] ) && $home['host'] === $check['host'] ) ) {
|
|
return false;
|
|
}
|
|
|
|
if ( ! defined( 'WP_PROXY_BYPASS_HOSTS' ) ) {
|
|
return true;
|
|
}
|
|
|
|
static $bypass_hosts = null;
|
|
static $wildcard_regex = array();
|
|
if ( null === $bypass_hosts ) {
|
|
$bypass_hosts = preg_split( '|,\s*|', WP_PROXY_BYPASS_HOSTS );
|
|
|
|
if ( false !== strpos( WP_PROXY_BYPASS_HOSTS, '*' ) ) {
|
|
$wildcard_regex = array();
|
|
foreach ( $bypass_hosts as $host ) {
|
|
$wildcard_regex[] = str_replace( '\*', '.+', preg_quote( $host, '/' ) );
|
|
}
|
|
$wildcard_regex = '/^(' . implode( '|', $wildcard_regex ) . ')$/i';
|
|
}
|
|
}
|
|
|
|
if ( ! empty( $wildcard_regex ) ) {
|
|
return ! preg_match( $wildcard_regex, $check['host'] );
|
|
} else {
|
|
return ! in_array( $check['host'], $bypass_hosts, true );
|
|
}
|
|
}
|
|
}
|