mirror of
https://github.com/WordPress/WordPress.git
synced 2024-11-10 21:00:59 +01:00
9bf6faff7c
`_wp_array_get()` is an expensive function, and it's called thousands of times on each page view on the front end. While the function performance was slightly improved in #58376, it is still called more times than it should be. This commit aims to further optimize its usage: * In many cases, `_wp_array_get()` can be replaced with a much simpler and faster `isset()` check. * The `isset()` function is capable of checking nested arrays, so `isset( $foo['a']['b']['c'] )` will return false even if `$foo['a']` is unset, without throwing any errors or warnings. * When `_wp_array_get()` cannot be directly replaced with `isset()`, it would be good practice to wrap it in an `isset()` function so that `_wp_array_get()` only runs when it needs to. Original PR from Gutenberg repository: * [https://github.com/WordPress/gutenberg/pull/51116 #51116 Performance improvement: Reduce the use of the _wp_array_get() function] Follow-up to [55851], [56382]. Props aristath, jrf, spacedmonkey, mukesh27, swissspidy, hellofromTonya. Fixes #59405. Built from https://develop.svn.wordpress.org/trunk@56709 git-svn-id: http://core.svn.wordpress.org/trunk@56221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
152 lines
4.2 KiB
PHP
152 lines
4.2 KiB
PHP
<?php
|
|
/**
|
|
* Position block support flag.
|
|
*
|
|
* @package WordPress
|
|
* @since 6.2.0
|
|
*/
|
|
|
|
/**
|
|
* Registers the style block attribute for block types that support it.
|
|
*
|
|
* @since 6.2.0
|
|
* @access private
|
|
*
|
|
* @param WP_Block_Type $block_type Block Type.
|
|
*/
|
|
function wp_register_position_support( $block_type ) {
|
|
$has_position_support = block_has_support( $block_type, 'position', false );
|
|
|
|
// Set up attributes and styles within that if needed.
|
|
if ( ! $block_type->attributes ) {
|
|
$block_type->attributes = array();
|
|
}
|
|
|
|
if ( $has_position_support && ! array_key_exists( 'style', $block_type->attributes ) ) {
|
|
$block_type->attributes['style'] = array(
|
|
'type' => 'object',
|
|
);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Renders position styles to the block wrapper.
|
|
*
|
|
* @since 6.2.0
|
|
* @access private
|
|
*
|
|
* @param string $block_content Rendered block content.
|
|
* @param array $block Block object.
|
|
* @return string Filtered block content.
|
|
*/
|
|
function wp_render_position_support( $block_content, $block ) {
|
|
$block_type = WP_Block_Type_Registry::get_instance()->get_registered( $block['blockName'] );
|
|
$has_position_support = block_has_support( $block_type, 'position', false );
|
|
|
|
if (
|
|
! $has_position_support ||
|
|
empty( $block['attrs']['style']['position'] )
|
|
) {
|
|
return $block_content;
|
|
}
|
|
|
|
$global_settings = wp_get_global_settings();
|
|
$theme_has_sticky_support = isset( $global_settings['position']['sticky'] ) ? $global_settings['position']['sticky'] : false;
|
|
$theme_has_fixed_support = isset( $global_settings['position']['fixed'] ) ? $global_settings['position']['fixed'] : false;
|
|
|
|
// Only allow output for position types that the theme supports.
|
|
$allowed_position_types = array();
|
|
if ( true === $theme_has_sticky_support ) {
|
|
$allowed_position_types[] = 'sticky';
|
|
}
|
|
if ( true === $theme_has_fixed_support ) {
|
|
$allowed_position_types[] = 'fixed';
|
|
}
|
|
|
|
$style_attribute = isset( $block['attrs']['style'] ) ? $block['attrs']['style'] : null;
|
|
$class_name = wp_unique_id( 'wp-container-' );
|
|
$selector = ".$class_name";
|
|
$position_styles = array();
|
|
$position_type = isset( $style_attribute['position']['type'] ) ? $style_attribute['position']['type'] : '';
|
|
$wrapper_classes = array();
|
|
|
|
if (
|
|
in_array( $position_type, $allowed_position_types, true )
|
|
) {
|
|
$wrapper_classes[] = $class_name;
|
|
$wrapper_classes[] = 'is-position-' . $position_type;
|
|
$sides = array( 'top', 'right', 'bottom', 'left' );
|
|
|
|
foreach ( $sides as $side ) {
|
|
$side_value = isset( $style_attribute['position'][ $side ] ) ? $style_attribute['position'][ $side ] : null;
|
|
if ( null !== $side_value ) {
|
|
/*
|
|
* For fixed or sticky top positions,
|
|
* ensure the value includes an offset for the logged in admin bar.
|
|
*/
|
|
if (
|
|
'top' === $side &&
|
|
( 'fixed' === $position_type || 'sticky' === $position_type )
|
|
) {
|
|
// Ensure 0 values can be used in `calc()` calculations.
|
|
if ( '0' === $side_value || 0 === $side_value ) {
|
|
$side_value = '0px';
|
|
}
|
|
|
|
// Ensure current side value also factors in the height of the logged in admin bar.
|
|
$side_value = "calc($side_value + var(--wp-admin--admin-bar--position-offset, 0px))";
|
|
}
|
|
|
|
$position_styles[] =
|
|
array(
|
|
'selector' => $selector,
|
|
'declarations' => array(
|
|
$side => $side_value,
|
|
),
|
|
);
|
|
}
|
|
}
|
|
|
|
$position_styles[] =
|
|
array(
|
|
'selector' => $selector,
|
|
'declarations' => array(
|
|
'position' => $position_type,
|
|
'z-index' => '10',
|
|
),
|
|
);
|
|
}
|
|
|
|
if ( ! empty( $position_styles ) ) {
|
|
/*
|
|
* Add to the style engine store to enqueue and render position styles.
|
|
*/
|
|
wp_style_engine_get_stylesheet_from_css_rules(
|
|
$position_styles,
|
|
array(
|
|
'context' => 'block-supports',
|
|
'prettify' => false,
|
|
)
|
|
);
|
|
|
|
// Inject class name to block container markup.
|
|
$content = new WP_HTML_Tag_Processor( $block_content );
|
|
$content->next_tag();
|
|
foreach ( $wrapper_classes as $class ) {
|
|
$content->add_class( $class );
|
|
}
|
|
return (string) $content;
|
|
}
|
|
|
|
return $block_content;
|
|
}
|
|
|
|
// Register the block support.
|
|
WP_Block_Supports::get_instance()->register(
|
|
'position',
|
|
array(
|
|
'register_attribute' => 'wp_register_position_support',
|
|
)
|
|
);
|
|
add_filter( 'render_block', 'wp_render_position_support', 10, 2 );
|