WordPress/wp-includes
hellofromTonya bb4c9b56f3 REST API: Fix autovivification deprecation notice in WP_Test_REST_Widgets_Controller::set_up().
If the `'widget_testwidget'` option does not exist, `false` was returned from `get_option()`. The `set_up()` logic expects an `array()` and assigns values to keys without checking for an array. The automatic creation of an array (autovivification) triggers a `Deprecated: Automatic conversion of false to array is deprecated in` deprecation notice on PHP 8.1.

This commit:
- Fixes the deprecation notice by making the default value an empty array.
- Moves getting the option within the conditional where it's needed.
- Provides a micro-optimization by only getting the options when the conditions are correct for processing.
- Makes the code consistent within the `set_up()` for both `get_option()` instances.

Follow-up to [51029].

Props jrf, hellofromTonya, BinaryKitten.
See #53635.
Built from https://develop.svn.wordpress.org/trunk@51830


git-svn-id: http://core.svn.wordpress.org/trunk@51437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-09-20 18:49:58 +00:00
..
assets Editor: Update block editor packages for WordPress 5.8.1. 2021-09-01 19:08:24 +00:00
block-patterns Block Editor: Backport fixes targetted for WordPress 5.8 RC4. 2021-07-15 18:55:29 +00:00
block-supports Coding Standards: Use static closures when not using $this. 2021-08-26 12:59:02 +00:00
blocks Build: Split packages and blocks to their webpack configs 2021-07-28 10:06:59 +00:00
certificates
css Coding Standards: Apply coding standards on CSS. 2021-09-02 22:18:00 +00:00
customize Code Modernization: Fix parameter name mismatch with parent in WP_Customize_Custom_CSS_Setting::validate(). 2021-09-09 15:18:55 +00:00
fonts
ID3
images
IXR
js External Libraries: Update jQuery UI to 1.13.0-rc2. 2021-09-10 00:02:59 +00:00
php-compat Docs: Improve documentation for a few functions per the documentation standards. 2021-08-10 13:45:57 +00:00
PHPMailer External Libraries: Restore the phpcs:ignore statements in PHPMailer. 2021-08-18 14:08:56 +00:00
pomo Code Modernization: Silence the deprecation warning for auto_detect_line_endings. 2021-08-18 21:58:57 +00:00
random_compat
Requests
rest-api Widgets: Revert [51705]. 2021-09-09 21:40:57 +00:00
SimplePie
sitemaps Code Modernization: Fix parameter name mismatches for parent/child classes in WP_Sitemaps_Provider::get_max_num_pages(). 2021-09-09 19:42:56 +00:00
sodium_compat Upgrade/Install: Update sodium_compat to v1.17.0. 2021-08-10 13:04:57 +00:00
Text
theme-compat
widgets I18N: Add a translator comment to clarify the "Block HTML" string in the Block widget settings form. 2021-09-15 11:49:01 +00:00
admin-bar.php Toolbar: Provide a CSS custom property for the admin bar height. 2021-08-26 18:24:58 +00:00
atomlib.php
author-template.php Users: Escape get_author_posts_url() link in wp_list_authors(). 2021-06-21 06:06:57 +00:00
block-editor.php Docs: Fix typo in the get_block_editor_settings() description. 2021-08-15 12:45:59 +00:00
block-i18n.json Blocks: Add support for variations in block.json` file 2021-08-11 09:08:01 +00:00
block-patterns.php Editor: Ensure the Query block pattern category is translatable. 2021-07-02 14:35:58 +00:00
block-template-utils.php Docs: Descriptive improvements and corrections for various docblocks. 2021-07-01 21:12:58 +00:00
block-template.php Coding Standards: Use static closures when not using $this. 2021-08-26 12:59:02 +00:00
blocks.php Editor: Ensure block attribute serialization in PHP matches the JavaScript equivalent. 2021-08-26 19:10:58 +00:00
bookmark-template.php
bookmark.php
cache-compat.php
cache.php
canonical.php Permalinks: Revert the changes stemming from pagination limits. 2021-06-08 23:32:56 +00:00
capabilities.php
category-template.php Docs: Add and correct examples of common names for various dynamic hooks. 2021-07-03 21:42:59 +00:00
category.php
class-feed.php
class-http.php Coding Standards: Rename the $processedHeaders variable to $processed_headers in WP_Http::request(). 2021-09-20 12:07:00 +00:00
class-IXR.php
class-json.php
class-oembed.php
class-phpass.php
class-phpmailer.php
class-pop3.php
class-requests.php External Libraries: Update the Requests library to version 1.8.1. 2021-06-06 14:05:56 +00:00
class-simplepie.php
class-smtp.php
class-snoopy.php
class-walker-category-dropdown.php Code Modernization: Fix last parameter name mismatches for parent/child classes in Walker::start_el(). 2021-09-09 12:39:59 +00:00
class-walker-category.php Code Modernization: Fix reserved keyword and parameter name mismatches for parent/child classes in Walker::end_el(). 2021-09-09 13:03:55 +00:00
class-walker-comment.php Code Modernization: Fix reserved keyword and parameter name mismatches for parent/child classes in Walker::end_el(). 2021-09-09 13:03:55 +00:00
class-walker-nav-menu.php Code Modernization: Fix reserved keyword and parameter name mismatches for parent/child classes in Walker::end_el(). 2021-09-09 13:03:55 +00:00
class-walker-page-dropdown.php Code Modernization: Fix last parameter name mismatches for parent/child classes in Walker::start_el(). 2021-09-09 12:39:59 +00:00
class-walker-page.php Code Modernization: Fix reserved keyword and parameter name mismatches for parent/child classes in Walker::end_el(). 2021-09-09 13:03:55 +00:00
class-wp-admin-bar.php
class-wp-ajax-response.php
class-wp-application-passwords.php Application Passwords: Improve various user-facing and developer-facing terminology. 2021-07-19 21:14:57 +00:00
class-wp-block-editor-context.php
class-wp-block-list.php Code Modernization: Silence the deprecation warnings for missing return type in WP_Block_List. 2021-08-03 11:12:55 +00:00
class-wp-block-parser.php
class-wp-block-pattern-categories-registry.php Coding Standards: Remove a one-time $message variable in some _doing_it_wrong() calls. 2021-06-15 15:22:58 +00:00
class-wp-block-patterns-registry.php Coding Standards: Remove a one-time $message variable in some _doing_it_wrong() calls. 2021-06-15 15:22:58 +00:00
class-wp-block-styles-registry.php Coding Standards: Remove a one-time $message variable in some _doing_it_wrong() calls. 2021-06-15 15:22:58 +00:00
class-wp-block-supports.php
class-wp-block-template.php
class-wp-block-type-registry.php Coding Standards: Remove a one-time $message variable in some _doing_it_wrong() calls. 2021-06-15 15:22:58 +00:00
class-wp-block-type.php Build: Split packages and blocks to their webpack configs 2021-07-28 10:06:59 +00:00
class-wp-block.php Build: Split packages and blocks to their webpack configs 2021-07-28 10:06:59 +00:00
class-wp-comment-query.php Code Modernization: Fix "passing null to non-nullable" deprecation notice in WP_Comment_Query::get_comment_ids(). 2021-09-13 18:54:59 +00:00
class-wp-comment.php
class-wp-customize-control.php Docs: Replace $this in hook param docs with more appropriate names. 2021-07-30 19:35:58 +00:00
class-wp-customize-manager.php Docs: Fix typo in a comment in WP_Customize_Manager::get_return_url(). 2021-09-04 00:39:04 +00:00
class-wp-customize-nav-menus.php Coding Standards: Use strict comparison in wp-includes/class-wp-customize-nav-menus.php. 2021-05-30 19:18:01 +00:00
class-wp-customize-panel.php Docs: Replace $this in hook param docs with more appropriate names. 2021-07-30 19:35:58 +00:00
class-wp-customize-section.php Docs: Replace $this in hook param docs with more appropriate names. 2021-07-30 19:35:58 +00:00
class-wp-customize-setting.php Code Modernization: Fix parameter name mismatches for parent/child classes in WP_Customize_Setting::sanitize(). 2021-09-09 14:32:57 +00:00
class-wp-customize-widgets.php Widgets: Revert [51705]. 2021-09-09 21:40:57 +00:00
class-wp-date-query.php Docs: Replace $this in hook param docs with more appropriate names. 2021-07-30 19:35:58 +00:00
class-wp-dependency.php Docs: Various corrections to inline docblocks. 2020-07-23 00:48:06 +00:00
class-wp-editor.php Editor: Revert [51748] and [51649]. They intorduced a bug where wp.editor may be replaced with wp.oldEditor in certain cases. 2021-09-08 23:29:58 +00:00
class-wp-embed.php Administration: Consistently escape admin_url() links. 2021-06-17 14:37:00 +00:00
class-wp-error.php
class-wp-fatal-error-handler.php Booststrap/Load: Only reference recovery mode email when it can be sent. 2021-06-05 15:46:57 +00:00
class-wp-feed-cache-transient.php
class-wp-feed-cache.php
class-wp-hook.php Code Modernization: Silence the deprecation warnings for missing return type in WP_Hook. 2021-08-03 11:02:00 +00:00
class-wp-http-cookie.php Coding Standards: Rename the $arrURL variable to $parsed_url in WP_Http_Cookie::__construct(). 2021-09-19 16:59:56 +00:00
class-wp-http-curl.php
class-wp-http-encoding.php
class-wp-http-ixr-client.php
class-wp-http-proxy.php
class-wp-http-requests-hooks.php Docs: Descriptive improvements and corrections for various docblocks. 2021-07-01 21:12:58 +00:00
class-wp-http-requests-response.php
class-wp-http-response.php
class-wp-http-streams.php Coding Standards: Rename the $arrURL variable to $parsed_url in WP_Http_Streams::request(). 2021-09-19 17:00:57 +00:00
class-wp-image-editor-gd.php Code Modernization: Fix parameter name mismatches for parent/child classes in WP_Image_Editor::save(). 2021-09-09 20:39:58 +00:00
class-wp-image-editor-imagick.php Code Modernization: Fix parameter name mismatches for parent/child classes in WP_Image_Editor::save(). 2021-09-09 20:39:58 +00:00
class-wp-image-editor.php Code Modernization: Fix parameter name mismatches for parent/child classes in WP_Image_Editor::save(). 2021-09-09 20:39:58 +00:00
class-wp-list-util.php Docs: Improve documentation for wp_list_filter() and wp_filter_object_list(). 2021-05-28 18:04:57 +00:00
class-wp-locale-switcher.php
class-wp-locale.php
class-wp-matchesmapregex.php
class-wp-meta-query.php Code Modernization: Fix null to non-nullable deprecations in WP_Meta_Query::get_sql_for_clause(). 2021-09-10 16:01:03 +00:00
class-wp-metadata-lazyloader.php
class-wp-network-query.php Docs: Replace $this in hook param docs with more appropriate names. 2021-07-30 19:35:58 +00:00
class-wp-network.php
class-wp-object-cache.php
class-wp-oembed-controller.php Docs: Document the usage of $wp_embed global in WP_oEmbed_Controller::get_proxy_item(). 2021-06-15 10:24:57 +00:00
class-wp-oembed.php Embeds: Add Pinterest as a trusted oEmbed provider. 2021-09-17 03:13:56 +00:00
class-wp-paused-extensions-storage.php
class-wp-post-type.php
class-wp-post.php
class-wp-query.php Docs: Add missing documentation for the minute parameter of WP_Query. 2021-07-30 10:53:58 +00:00
class-wp-recovery-mode-cookie-service.php Docs: Consistently use third-person singular verbs for various filter descriptions, per the documentation standards. 2020-08-11 00:34:08 +00:00
class-wp-recovery-mode-email-service.php
class-wp-recovery-mode-key-service.php
class-wp-recovery-mode-link-service.php
class-wp-recovery-mode.php
class-wp-rewrite.php Docs: Replace $this in hook param docs with more appropriate names. 2021-07-30 19:35:58 +00:00
class-wp-role.php
class-wp-roles.php Docs: Replace $this in hook param docs with more appropriate names. 2021-07-30 19:35:58 +00:00
class-wp-session-tokens.php
class-wp-simplepie-file.php
class-wp-simplepie-sanitize-kses.php
class-wp-site-query.php Docs: Replace $this in hook param docs with more appropriate names. 2021-07-30 19:35:58 +00:00
class-wp-site.php
class-wp-tax-query.php
class-wp-taxonomy.php
class-wp-term-query.php Docs: Replace $this in hook param docs with more appropriate names. 2021-07-30 19:35:58 +00:00
class-wp-term.php
class-wp-text-diff-renderer-inline.php
class-wp-text-diff-renderer-table.php
class-wp-theme-json-resolver.php Coding Standards: Apply some minor alignment fixes. 2021-08-30 14:09:58 +00:00
class-wp-theme-json.php Coding Standards: Use static closures when not using $this. 2021-08-26 12:59:02 +00:00
class-wp-theme.php Code Modernization: Silence the deprecation warnings for missing return type in WP_Theme. 2021-08-02 22:31:56 +00:00
class-wp-user-meta-session-tokens.php
class-wp-user-query.php
class-wp-user-request.php
class-wp-user.php
class-wp-walker.php Code Modernization: Fix reserved keyword and parameter name mismatches for parent/child classes in Walker::end_el(). 2021-09-09 13:03:55 +00:00
class-wp-widget-factory.php Widgets: Fix widget preview not working if widget registered via a instance 2021-06-23 01:34:58 +00:00
class-wp-widget.php Coding Standards: Simplify the logic in WP_Widget::get_field_name() and ::get_field_id(). 2021-06-04 10:47:58 +00:00
class-wp-xmlrpc-server.php Docs: Add a @see reference to the xmlrpc_enabled filter in wp_xmlrpc_server::set_is_enabled(). 2021-08-10 12:54:56 +00:00
class-wp.php Code Modernization: Check the return type of parse_url() in WP::parse_request(). 2021-08-16 20:17:57 +00:00
class.wp-dependencies.php
class.wp-scripts.php Docs: Replace $this in hook param docs with more appropriate names. 2021-07-30 19:35:58 +00:00
class.wp-styles.php Docs: Replace $this in hook param docs with more appropriate names. 2021-07-30 19:35:58 +00:00
comment-template.php Docs: Add and correct examples of common names for various dynamic hooks. 2021-07-03 21:42:59 +00:00
comment.php
compat.php Docs: Correct a comment about WebP constants in wp-includes/compat.php. 2021-07-22 13:07:57 +00:00
cron.php Code Modernization: Add input validation to _set_cron_array(). 2021-08-30 15:20:56 +00:00
date.php
default-constants.php
default-filters.php Widgets: Warn when wp-editor script or wp-edit-post style is enqueued in widgets editor 2021-07-09 01:18:57 +00:00
default-widgets.php
deprecated.php General: Restore (un-deprecate) the sanitize_url() function. 2021-08-10 19:44:59 +00:00
embed-template.php
embed.php Coding Standards: Apply coding standards on CSS. 2021-09-02 22:18:00 +00:00
error-protection.php
feed-atom-comments.php
feed-atom.php
feed-rdf.php
feed-rss2-comments.php
feed-rss2.php
feed-rss.php
feed.php
formatting.php Coding Standards: Use static closures when not using $this. 2021-08-26 12:59:02 +00:00
functions.php Code Modernization: Fix null to non-nullable deprecation in wp_privacy_anonymize_ip(). 2021-09-09 22:56:56 +00:00
functions.wp-scripts.php Docs: Provide a more accurate description for a few script and style functions. 2021-09-02 08:30:58 +00:00
functions.wp-styles.php Docs: Provide a more accurate description for a few script and style functions. 2021-09-02 08:30:58 +00:00
general-template.php Editor: Revert [51748] and [51649]. They intorduced a bug where wp.editor may be replaced with wp.oldEditor in certain cases. 2021-09-08 23:29:58 +00:00
http.php
https-detection.php
https-migration.php
kses.php Docs: Move @since notes from the safe_style_css filter to the safecss_filter_attr() function. 2021-09-03 01:37:57 +00:00
l10n.php Blocks: Add support for variations in block.json` file 2021-08-11 09:08:01 +00:00
link-template.php Coding Standards: Remove redundant type casting to array in WP_Query::get_posts(). 2021-06-30 17:44:58 +00:00
load.php Multisite: Log error/warnings/notices from ms-files.php. 2021-07-06 20:21:57 +00:00
locale.php
media-template.php Media: Add / character to <img> tag in wp_print_media_templates(). 2021-08-04 14:25:58 +00:00
media.php Media: Fix $content parameter default value in img_caption_shortcode(). 2021-09-15 19:06:57 +00:00
meta.php Docs: Document common names for dynamic hooks relating to metadata. 2021-07-03 21:32:58 +00:00
ms-blogs.php
ms-default-constants.php Code Modernization: Check the return type of parse_url() in ms_cookie_constants(). 2021-08-17 22:08:57 +00:00
ms-default-filters.php
ms-deprecated.php
ms-files.php Multisite: Log error/warnings/notices from ms-files.php. 2021-07-06 20:21:57 +00:00
ms-functions.php Networks and Sites: Replace two remaining occurrences of "blog" with "site" in user-facing strings. 2021-07-28 10:02:00 +00:00
ms-load.php
ms-network.php
ms-settings.php
ms-site.php Docs: Add a reference to WP_Site_Query::__construct() for information on accepted arguments in get_sites(). 2021-06-19 20:57:01 +00:00
nav-menu-template.php
nav-menu.php Docs: Undo the accidental revert of [51299] made in [51300]. 2021-07-01 21:29:56 +00:00
option.php Docs: Remove deprecated option groups from register_setting() and add_option_update_handler(). 2021-09-20 16:20:00 +00:00
pluggable-deprecated.php
pluggable.php Docs: Undo the accidental revert of [51299] made in [51300]. 2021-07-01 21:29:56 +00:00
plugin.php
post-formats.php
post-template.php
post-thumbnail-template.php
post.php Docs: Synchronize the $post_id argument description for some post and attachment functions. 2021-07-14 08:14:01 +00:00
query.php Coding Standards: Remove a one-time $message variable in some _doing_it_wrong() calls. 2021-06-15 15:22:58 +00:00
registration-functions.php
registration.php
rest-api.php Coding Standards: Use static closures when not using $this. 2021-08-26 12:59:02 +00:00
revision.php Docs: Add and correct examples of common names for various dynamic hooks. 2021-07-03 21:42:59 +00:00
rewrite.php
robots-template.php
rss-functions.php
rss.php
script-loader.php Block editor: Cache global stylesheet by theme key. 2021-09-16 18:05:00 +00:00
session.php
shortcodes.php Coding Standards: Remove a one-time $message variable in some _doing_it_wrong() calls. 2021-06-15 15:22:58 +00:00
sitemaps.php
spl-autoload-compat.php
taxonomy.php Code Modernization: Fix null to non-nullable deprecation in term_exists(). 2021-09-10 15:03:57 +00:00
template-canvas.php
template-loader.php
template.php
theme-i18n.json
theme-templates.php Block Editor: Package updates for Beta 3. 2021-06-22 10:00:50 +00:00
theme.json Block Editor: Add missing border setting on button block. 2021-08-03 18:14:58 +00:00
theme.php Widgets: Revert [51705]. 2021-09-09 21:40:57 +00:00
update.php Coding Standards: Use static closures when not using $this. 2021-08-26 12:59:02 +00:00
user.php Users: Introduce a meta_input argument for wp_insert_user(). 2021-09-07 21:31:55 +00:00
vars.php
version.php REST API: Fix autovivification deprecation notice in WP_Test_REST_Widgets_Controller::set_up(). 2021-09-20 18:49:58 +00:00
widgets.php Widgets: Revert [51705]. 2021-09-09 21:40:57 +00:00
wlwmanifest.xml
wp-db.php Code Modernization: Fix "passing null to non-nullable" deprecation in wpdb::_real_escape(). 2021-09-10 16:36:57 +00:00
wp-diff.php