mirror of
https://github.com/WordPress/WordPress.git
synced 2024-11-20 01:25:30 +01:00
c03305852e
Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0. There are a number of ways to mitigate this: * If it is an accidental typo for a declared property: fix the typo. * For known properties: declare them on the class. * For unknown properties: add the magic `__get()`, `__set()`, et al. methods to the class or let the class extend `stdClass` which has highly optimized versions of these magic methods built in. * For unknown ''use'' of dynamic properties, the `#[AllowDynamicProperties]` attribute can be added to the class. The attribute will automatically be inherited by child classes. Trac ticket #56034 is open to investigate and handle the third and fourth type of situations, however it has become clear this will need more time and will not be ready in time for WP 6.1. To reduce “noise” in the meantime, both in the error logs of WP users moving onto PHP 8.2, in the test run logs of WP itself, in test runs of plugins and themes, as well as to prevent duplicate tickets from being opened for the same issue, this commit adds the `#[AllowDynamicProperties]` attribute to all “parent” classes in WP. The logic used for this commit is as follows: * If a class already has the attribute: no action needed. * If a class does not `extend`: add the attribute. * If a class does `extend`: - If it extends `stdClass`: no action needed (as `stdClass` supports dynamic properties). - If it extends a PHP native class: add the attribute. - If it extends a class from one of WP's external dependencies: add the attribute. * In all other cases: no action — the attribute should not be needed as child classes inherit from the parent. Whether or not a class contains magic methods has not been taken into account, as a review of the currently existing magic methods has shown that those are generally not sturdy enough and often even set dynamic properties (which they should not). See the [https://www.youtube.com/watch?v=vDZWepDQQVE live stream from August 16, 2022] for more details. This commit only affects classes in the `src` directory of WordPress core. * Tests should not get this attribute, but should be fixed to not use dynamic properties instead. Patches for this are already being committed under ticket #56033. * While a number bundled themes (2014, 2019, 2020, 2021) contain classes, they are not a part of this commit and may be updated separately. Reference: [https://wiki.php.net/rfc/deprecate_dynamic_properties PHP RFC: Deprecate dynamic properties]. Follow-up to [53922]. Props jrf, hellofromTonya, markjaquith, peterwilsoncc, costdev, knutsp, aristath. See #56513, #56034. Built from https://develop.svn.wordpress.org/trunk@54133 git-svn-id: http://core.svn.wordpress.org/trunk@53692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
199 lines
5.7 KiB
PHP
199 lines
5.7 KiB
PHP
<?php
|
|
/**
|
|
* Blocks API: WP_Block_Styles_Registry class
|
|
*
|
|
* @package WordPress
|
|
* @subpackage Blocks
|
|
* @since 5.3.0
|
|
*/
|
|
|
|
/**
|
|
* Class used for interacting with block styles.
|
|
*
|
|
* @since 5.3.0
|
|
*/
|
|
#[AllowDynamicProperties]
|
|
final class WP_Block_Styles_Registry {
|
|
/**
|
|
* Registered block styles, as `$block_name => $block_style_name => $block_style_properties` multidimensional arrays.
|
|
*
|
|
* @since 5.3.0
|
|
*
|
|
* @var array[]
|
|
*/
|
|
private $registered_block_styles = array();
|
|
|
|
/**
|
|
* Container for the main instance of the class.
|
|
*
|
|
* @since 5.3.0
|
|
*
|
|
* @var WP_Block_Styles_Registry|null
|
|
*/
|
|
private static $instance = null;
|
|
|
|
/**
|
|
* Registers a block style for the given block type.
|
|
*
|
|
* If the block styles are present in a standalone stylesheet, register it and pass
|
|
* its handle as the `style_handle` argument. If the block styles should be inline,
|
|
* use the `inline_style` argument. Usually, one of them would be used to pass CSS
|
|
* styles. However, you could also skip them and provide CSS styles in any stylesheet
|
|
* or with an inline tag.
|
|
*
|
|
* @since 5.3.0
|
|
*
|
|
* @link https://developer.wordpress.org/block-editor/reference-guides/block-api/block-styles/
|
|
*
|
|
* @param string $block_name Block type name including namespace.
|
|
* @param array $style_properties {
|
|
* Array containing the properties of the style.
|
|
*
|
|
* @type string $name The identifier of the style used to compute a CSS class.
|
|
* @type string $label A human-readable label for the style.
|
|
* @type string $inline_style Inline CSS code that registers the CSS class required
|
|
* for the style.
|
|
* @type string $style_handle The handle to an already registered style that should be
|
|
* enqueued in places where block styles are needed.
|
|
* @type bool $is_default Whether this is the default style for the block type.
|
|
* }
|
|
* @return bool True if the block style was registered with success and false otherwise.
|
|
*/
|
|
public function register( $block_name, $style_properties ) {
|
|
|
|
if ( ! isset( $block_name ) || ! is_string( $block_name ) ) {
|
|
_doing_it_wrong(
|
|
__METHOD__,
|
|
__( 'Block name must be a string.' ),
|
|
'5.3.0'
|
|
);
|
|
return false;
|
|
}
|
|
|
|
if ( ! isset( $style_properties['name'] ) || ! is_string( $style_properties['name'] ) ) {
|
|
_doing_it_wrong(
|
|
__METHOD__,
|
|
__( 'Block style name must be a string.' ),
|
|
'5.3.0'
|
|
);
|
|
return false;
|
|
}
|
|
|
|
if ( str_contains( $style_properties['name'], ' ' ) ) {
|
|
_doing_it_wrong(
|
|
__METHOD__,
|
|
__( 'Block style name must not contain any spaces.' ),
|
|
'5.9.0'
|
|
);
|
|
return false;
|
|
}
|
|
|
|
$block_style_name = $style_properties['name'];
|
|
|
|
if ( ! isset( $this->registered_block_styles[ $block_name ] ) ) {
|
|
$this->registered_block_styles[ $block_name ] = array();
|
|
}
|
|
$this->registered_block_styles[ $block_name ][ $block_style_name ] = $style_properties;
|
|
|
|
return true;
|
|
}
|
|
|
|
/**
|
|
* Unregisters a block style of the given block type.
|
|
*
|
|
* @since 5.3.0
|
|
*
|
|
* @param string $block_name Block type name including namespace.
|
|
* @param string $block_style_name Block style name.
|
|
* @return bool True if the block style was unregistered with success and false otherwise.
|
|
*/
|
|
public function unregister( $block_name, $block_style_name ) {
|
|
if ( ! $this->is_registered( $block_name, $block_style_name ) ) {
|
|
_doing_it_wrong(
|
|
__METHOD__,
|
|
/* translators: 1: Block name, 2: Block style name. */
|
|
sprintf( __( 'Block "%1$s" does not contain a style named "%2$s".' ), $block_name, $block_style_name ),
|
|
'5.3.0'
|
|
);
|
|
return false;
|
|
}
|
|
|
|
unset( $this->registered_block_styles[ $block_name ][ $block_style_name ] );
|
|
|
|
return true;
|
|
}
|
|
|
|
/**
|
|
* Retrieves the properties of a registered block style for the given block type.
|
|
*
|
|
* @since 5.3.0
|
|
*
|
|
* @param string $block_name Block type name including namespace.
|
|
* @param string $block_style_name Block style name.
|
|
* @return array Registered block style properties.
|
|
*/
|
|
public function get_registered( $block_name, $block_style_name ) {
|
|
if ( ! $this->is_registered( $block_name, $block_style_name ) ) {
|
|
return null;
|
|
}
|
|
|
|
return $this->registered_block_styles[ $block_name ][ $block_style_name ];
|
|
}
|
|
|
|
/**
|
|
* Retrieves all registered block styles.
|
|
*
|
|
* @since 5.3.0
|
|
*
|
|
* @return array[] Array of arrays containing the registered block styles properties grouped by block type.
|
|
*/
|
|
public function get_all_registered() {
|
|
return $this->registered_block_styles;
|
|
}
|
|
|
|
/**
|
|
* Retrieves registered block styles for a specific block type.
|
|
*
|
|
* @since 5.3.0
|
|
*
|
|
* @param string $block_name Block type name including namespace.
|
|
* @return array[] Array whose keys are block style names and whose values are block style properties.
|
|
*/
|
|
public function get_registered_styles_for_block( $block_name ) {
|
|
if ( isset( $this->registered_block_styles[ $block_name ] ) ) {
|
|
return $this->registered_block_styles[ $block_name ];
|
|
}
|
|
return array();
|
|
}
|
|
|
|
/**
|
|
* Checks if a block style is registered for the given block type.
|
|
*
|
|
* @since 5.3.0
|
|
*
|
|
* @param string $block_name Block type name including namespace.
|
|
* @param string $block_style_name Block style name.
|
|
* @return bool True if the block style is registered, false otherwise.
|
|
*/
|
|
public function is_registered( $block_name, $block_style_name ) {
|
|
return isset( $this->registered_block_styles[ $block_name ][ $block_style_name ] );
|
|
}
|
|
|
|
/**
|
|
* Utility method to retrieve the main instance of the class.
|
|
*
|
|
* The instance will be created if it does not exist yet.
|
|
*
|
|
* @since 5.3.0
|
|
*
|
|
* @return WP_Block_Styles_Registry The main instance.
|
|
*/
|
|
public static function get_instance() {
|
|
if ( null === self::$instance ) {
|
|
self::$instance = new self();
|
|
}
|
|
|
|
return self::$instance;
|
|
}
|
|
}
|