WordPress/wp-includes
Scott Taylor daa4b531e8 Fix several esoteric errors related to AJAX unit tests for comments:
* `wp_ajax_get_comments()` relies on the `$post_id` global - even though `$_POST['p']` is passed to every action in the test methods. If `$post_id` is still lingering in between tests and doesn't match `p` in the request, the cap check might pass while the queries for comments will blow up. I added `unset( $GLOBALS['post_id'] )` to `Tests_Ajax_GetComments::setUp()`.
* If the global `$post_id` is empty, but `$_REQUEST['p']` is not, `$post_id` is now set to `absint( $_REQUEST['p'] )` and sanity-checked in `wp_ajax_get_comments()`.
* `map_meta_cap()` always assumes that `get_comment()` succeeds when checking for the `edit_comment` cap. It doesn't. I added sanity checks in a few places where it will break early if `get_post()` or `get_comment()` are empty.
* `wp_update_comment()` always assumes `get_comment()` succeeds. It doesn't. I added a check for empty.

All AJAX unit tests run and pass in debug mode. All general unit tests pass against these changes.

Fixes #25282.


Built from https://develop.svn.wordpress.org/trunk@25438


git-svn-id: http://core.svn.wordpress.org/trunk@25360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-14 18:36:09 +00:00
..
certificates WP_HTTP: Replacing the Fsockopen & Streams Transports with a new Streams transport which fully supports HTTPS communication. 2013-09-04 04:49:12 +00:00
css New develop.svn.wordpress.org repository based on the old core.svn repository. 2013-08-07 05:49:02 +00:00
ID3 ID3 1.9.7. 2013-07-13 00:37:36 +00:00
images Copy wpspin_light to wp-includes as wpspin.gif. Use it in media views. see #22728. 2012-12-04 16:18:53 +00:00
js Remove the banner when concatenating TinyMCE so wp-tinymce.js.gz doesn't change every time the build process is run. See #25159. 2013-08-31 22:02:10 +00:00
pomo Avoid 'Only variables should be passed by reference' warning. fixes #23232. 2013-01-31 01:01:19 +00:00
SimplePie SimplePie: Fix use of DOMElement as array. 2013-09-11 04:02:10 +00:00
Text Declare Text_Diff::trimNewlines() as static. Upstream is not back compat. props aaroncampbell. fixes #24372. 2013-05-25 22:10:53 +00:00
theme-compat Don't return encoded ampersands from get_post_comments_feed_link() to avoid canonical redirect issues. Apply esc_url() when appropriate. 2012-11-07 19:56:10 +00:00
admin-bar.php Network Admin toolbar menu: Add Plugins and Themes, remove Visit Network. 2013-08-26 15:22:11 +00:00
atomlib.php Use correct variable in atomlib library, inside an error message. props rlerdorf, see #24110. 2013-05-07 16:37:21 +00:00
author-template.php Inline documentation for hooks in wp-includes/author-template.php. 2013-09-13 19:25:10 +00:00
bookmark-template.php In wp_list_bookmarks(), don't stomp the categorize argument. Fixes categorized display in the links widget. 2012-11-28 23:19:03 +00:00
bookmark.php Fix potential SQLi through improper use of API functions. 2013-07-29 18:16:47 +00:00
cache.php Correct inline docs for cache.php. props ocean90. fixes #23058. 2013-01-22 20:44:30 +00:00
canonical.php Check bad dates and redirect, instead of 404ing, as necessary and appropriate. 2013-09-06 16:36:09 +00:00
capabilities.php Fix several esoteric errors related to AJAX unit tests for comments: 2013-09-14 18:36:09 +00:00
category-template.php Make sure the queried object is non-null before accessing its properties. 2013-09-10 02:28:11 +00:00
category.php Pinking shears 2012-11-17 15:11:29 +00:00
class-feed.php Use wp_safe_remote_request() and friends instead of reject_unsafe_urls = true. 2013-07-31 06:52:13 +00:00
class-http.php Switch WP_HTTP over to using the mbstring.func_overload helper functions. This change moves the check from within the Streaming-handling function to wrap the individual request, this fixes it for both cURL and Streams and any future changes to the transports which use strlen() on binary data. See #25259 See #16057 2013-09-11 08:13:10 +00:00
class-IXR.php
class-json.php Patch Services_JSON to use the proper function name and avoid a fatal error. see #24210. 2013-07-08 16:55:34 +00:00
class-oembed.php Use wp_safe_remote_request() and friends instead of reject_unsafe_urls = true. 2013-07-31 06:52:13 +00:00
class-phpass.php Add strict check to phpass's CheckPassword() method to avoid issues when the method is improperly called. 2013-06-21 01:21:12 +00:00
class-phpmailer.php Update to PHPMailer 5.2.4. props bpetty. fixes #21074. 2013-02-28 18:33:13 +00:00
class-pop3.php
class-simplepie.php Update SimplePie to 1.3.1. Props rmccue, ocean90. fixes #22321 2012-11-05 14:25:25 +00:00
class-smtp.php Update to PHPMailer 5.2.4. props bpetty. fixes #21074. 2013-02-28 18:33:13 +00:00
class-snoopy.php Use correct variable in the deprecated and abandoned Snoopy HTTP client. see #24210. 2013-07-08 17:17:46 +00:00
class-wp-admin-bar.php Don't render the screen reader shortcut 'Log Out' link in the toolbar when the user is not logged in. 2013-06-19 08:15:04 +00:00
class-wp-ajax-response.php
class-wp-customize-control.php Remove /extend/ from URLs to wordpress.org/plugins, /themes, and /mobile, as those are all now top-level. see #24389. 2013-05-22 21:01:57 +00:00
class-wp-customize-manager.php Avoid empty header color after enabling header text via Customizer. props obenland, fixes #23761. 2013-07-12 20:41:46 +00:00
class-wp-customize-section.php Actually display customizer section descriptions in a meaningful way. props obenland, helen. fixes #24392. 2013-08-23 16:18:10 +00:00
class-wp-customize-setting.php Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes(). 2013-03-03 16:30:38 +00:00
class-wp-editor.php Document 'wp_link_query_args' and 'wp_link_query' filters. props DrewAPicture. fixes #18042. 2013-09-07 19:47:10 +00:00
class-wp-embed.php Use correct escaping function. props duck_. 2013-01-22 16:37:54 +00:00
class-wp-error.php Correct inline docs for is_wp_error(). props johnbillion. fixes #24637. 2013-06-24 18:23:45 +00:00
class-wp-http-ixr-client.php
class-wp-image-editor-gd.php Fix editing images with GD when using streams. 2013-07-17 21:16:44 +00:00
class-wp-image-editor-imagick.php Remove debug. 2013-07-22 17:13:41 +00:00
class-wp-image-editor.php Pinking shears 2013-08-22 15:56:08 +00:00
class-wp-theme.php Revert [23394] until there is a consensus on target="_blank" (or not) for these external links. see #20839. 2013-07-08 13:04:07 +00:00
class-wp-walker.php Fix E_STRICT notices in walkers. props dvarga. see #24356. 2013-05-28 03:29:15 +00:00
class-wp-xmlrpc-server.php Introduce show_in_menu for register_taxonomy. 2013-08-26 22:35:10 +00:00
class-wp.php Remove double-strip on HTTP_IF_NONE_MATCH, which was done years ago (in #2597). see #21767. 2013-03-01 17:51:16 +00:00
class.wp-dependencies.php Revert [21420] and [21481]. Accepting a string caused back compat problems including the possibility of revealing previously hidden circular dependencies resulting in infinite loops. 2012-10-23 20:32:12 +00:00
class.wp-scripts.php If someone tries to localize 'jquery', which is now an alias with jquery-core and jquery-migrate dependencies, add the data to jquery-core. 2013-07-10 05:38:17 +00:00
class.wp-styles.php Prevent WP_Styles::do_item() from adding its own style tags when concatenation is disabled. props stephenharris. fixes #24813. 2013-09-01 13:15:09 +00:00
comment-template.php Inline documentation for get_comment_reply_link() and 'comment_reply_link' filter. 2013-09-13 19:20:09 +00:00
comment.php Fix several esoteric errors related to AJAX unit tests for comments: 2013-09-14 18:36:09 +00:00
compat.php
cron.php Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes(). 2013-03-03 16:30:38 +00:00
date.php WP_Date_Query. 2013-08-27 16:39:09 +00:00
default-constants.php Make Twenty Thirteen the default theme. 2013-02-28 19:01:07 +00:00
default-filters.php Pass the taxonomy around to relevant nav menu actions to avoid arbitrarily deleting all items with menu-item-type of taxonomy. Adds unit test for wp_get_associated_nav_menu_items(). 2013-08-29 16:45:10 +00:00
default-widgets.php Use wp_get_nav_menus() instead of get_terms('nav_menu') in WP_Nav_Menu_Widget to preserve use of `wp_get_nav_menus' filter. 2013-09-10 23:30:10 +00:00
deprecated.php Fix context for get_post() in the deprecated wp_get_single_post(). fixes #24602. 2013-06-19 07:58:28 +00:00
feed-atom-comments.php its <=> it's in documentation, along with a rogue the, The, and looses. props trepmal. fixes #22665. 2012-12-20 15:55:32 +00:00
feed-atom.php Don't return encoded ampersands from get_post_comments_feed_link() to avoid canonical redirect issues. Apply esc_url() when appropriate. 2012-11-07 19:56:10 +00:00
feed-rdf.php Consistently wrap author and excerpt nodes with CDATA in feeds. 2013-09-10 16:55:09 +00:00
feed-rss.php
feed-rss2-comments.php Use a CDATA second for comment authors in RSS2 comment feeds so that HTML in comments doesn't kill the XML validation. 2013-08-07 13:43:43 +00:00
feed-rss2.php Consistently wrap author and excerpt nodes with CDATA in feeds. 2013-09-10 16:55:09 +00:00
feed.php Pass the $sep function argument to the wp_title_rss and get_wp_title_rss filters. props scribu, fixes #16983. 2013-08-06 18:41:10 +00:00
formatting.php Use a better variable name in antispambot() introduced with [25055]. Props duck_ Fixes #16754 2013-08-28 01:47:09 +00:00
functions.php Add 'image' type/extensions to wp_ext2type() and make it case insensitive. props xparham. fixes #25176. 2013-09-14 14:34:09 +00:00
functions.wp-scripts.php Fix typo in phpdoc. props fanquake. fixes #23737. 2013-03-11 09:39:55 +00:00
functions.wp-styles.php Introduce wp_style_add_data() as a wrapper for $wp_styles->add_data(). 2013-07-18 19:46:38 +00:00
general-template.php Move checks for post_type being an array inline. See [25291], [25292], #18614. 2013-09-10 03:02:10 +00:00
http.php Inline documentation for hooks in http.php. 2013-09-08 22:04:09 +00:00
kses.php Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767 2013-03-01 16:28:40 +00:00
l10n.php Pinking shears 2013-08-22 15:56:08 +00:00
link-template.php Fix the failing Tests_Link::test_wp_get_shortlink() assertion: 2013-09-12 17:30:10 +00:00
load.php Fix wp_guess_url() to work in every scenario I could find, allows us to use it to determine the correct path to the WordPress Site URL before installation for install.php and setup-config.php redirects. Fixes #24480 Fixes #16884 2013-09-12 06:57:09 +00:00
locale.php Remove ultimately unnecessary visibility keyword from a WP_Locale method because this file is included when we bail for PHP 4. props ocean90. fixes #24915. for trunk. 2013-08-01 19:47:36 +00:00
media-template.php Media: Fix embedding of audio/video players when the file was just uploaded. 2013-07-23 17:29:55 +00:00
media.php Ignore case differences when checking file extension in wp_audio_shortcode() and wp_video_shortcode(). props nofearinc, bhengh. fixes #25140. 2013-08-26 19:21:10 +00:00
meta.php Move get_meta_type() into the WP_Meta_Query class as get_cast_for_type(). WP_Query can then access it like: $this->meta_query->get_cast_for_type(). 2013-09-05 23:32:09 +00:00
ms-blogs.php Deprecate get_blogaddress_by_domain(), unused since [25261]. props jeremyfelt. fixes #25235. 2013-09-06 11:41:09 +00:00
ms-default-constants.php Multisite in a subdirectory: For subdomain installs, use a root admin cookie path, not a wp-admin specific one. 2012-12-04 00:51:02 +00:00
ms-default-filters.php Additional checks when evaluating the safety of an HTTP request, to avoid false negatives. 2013-07-31 06:44:57 +00:00
ms-deprecated.php Deprecate get_blogaddress_by_domain(), unused since [25261]. props jeremyfelt. fixes #25235. 2013-09-06 11:41:09 +00:00
ms-files.php Use stripslashes() instead of wp_unslash() in ms-files.php to avoid formatting.php dependency. props devesine, fixes #24374. 2013-05-20 20:20:22 +00:00
ms-functions.php * Fill in undefined var in Tests_Option_BlogOption 2013-09-12 07:17:11 +00:00
ms-load.php Remove some old debug cruft left by yours truly. fixes #24462. 2013-06-26 19:33:58 +00:00
ms-settings.php
nav-menu-template.php Inline docs for hooks in wp-includes/nav-menu-template.php. props Faison. see #25229. 2013-09-12 18:48:09 +00:00
nav-menu.php Introduce wp_using_ext_object_cache() - mimic wp_suspend_cache_invalidation() and discourage direct access to $_wp_using_ext_object_cache, cleaning up importing of globals in functions and provides function to modify that global. Loads the packaged object cache when an external cache hasn't been loaded or doesn't contain wp_cache_init(). 2013-09-06 18:10:09 +00:00
option.php Fix the action that set_site_transient() fires so as not to include the private option prefix. This brings set_site_transient() back in line with it's documented behaviour, and the behaviour of all other transient functions. Fixes #25213 2013-09-11 08:46:10 +00:00
pluggable-deprecated.php Remove /extend/ from URLs to wordpress.org/plugins, /themes, and /mobile, as those are all now top-level. see #24389. 2013-05-22 21:01:57 +00:00
pluggable.php Fix some undefined index notices related to Comment unit tests: 2013-09-13 22:18:08 +00:00
plugin.php Close an HTML tag inside the add_filter() inline doc. props johnbillion, fixes #24772. 2013-07-16 13:59:43 +00:00
post-formats.php Allow has_post_format() to accept an array of formats to check. props ericmann. fixes #17320. 2013-07-28 20:48:09 +00:00
post-template.php Remove display of 'Previously restored by' in the revisions meta box as it is busted. 2013-08-31 01:33:09 +00:00
post-thumbnail-template.php Fix the PHPDoc for the_post_thumbnail(). props georgestephanis. fixes #22885 2012-12-29 17:59:08 +00:00
post.php Move checks for post_type being an array inline. See [25291], [25292], #18614. 2013-09-10 03:02:10 +00:00
query.php Move checks for post_type being an array inline. See [25291], [25292], #18614. 2013-09-10 03:02:10 +00:00
registration-functions.php
registration.php
revision.php Revisions changes. 2013-07-24 06:08:14 +00:00
rewrite.php Add filter flush_rewrite_rules_hard to give devs chance to prevent writing to file when hard-flushing rewrite rules. 2013-09-10 22:19:09 +00:00
rss-functions.php
rss.php Inline docs for hooks in MagPie. 2013-09-06 17:19:09 +00:00
script-loader.php Ensure zxcvbn.min.js loads when we are guessing the wp-includes URL. 2013-09-04 21:16:09 +00:00
shortcodes.php Inline documentation for hooks in wp-includes/shortcodes.php. 2013-09-13 09:02:09 +00:00
taxonomy.php Use reset() to access the first element of an array, don't assume there is an item at index 0. 2013-09-12 05:09:09 +00:00
template-loader.php Check the value passed to get_post_type_object(). If it's an array, use the first item. get_query_var( 'post_type' ) can be an array if the query has been altered via filters/actions. There are several places in core that pass the query var. Adds unit tests. 2013-09-06 23:39:09 +00:00
template.php Add sanity checks to get_*_template() functions to ensure that the return value of get_queried_object() is compatible with the assumed context. 2013-09-12 05:32:10 +00:00
theme.php Upgrader: Make clearing the Plugin and Theme update caches optional during install and upgrade proceedures. See #22704 2013-09-06 01:33:09 +00:00
update.php WordPress Core Automatic Updates: Add the first slice of Automatic Upgrades, This is presently disabled, and requires a filter to enable ( 'auto_upgrade_core' ). See #22704 2013-09-13 06:19:12 +00:00
user.php * Add isset() checks all over WP_User_Query::prepare_query() and WP_User_Query::query(). When a WP_User_Query instance is constructed without passing args, no query vars are filled in, thus $qv doesn't contain most of the expected indices. 2013-09-12 06:25:09 +00:00
vars.php Support IIS 8 and above. 2013-07-08 20:27:06 +00:00
version.php Clear all transients (regardless of expiration) on all database upgrades. see #20316. 2013-09-12 21:14:10 +00:00
widgets.php Remove reference to unused variable. fixes #24965. 2013-08-06 09:38:24 +00:00
wlwmanifest.xml
wp-db.php Document the 'query' filter in wp-db. 2013-09-06 17:07:09 +00:00
wp-diff.php Go back to plain text diffs between revisions instead of attempting partial rendering. 2013-05-07 20:34:58 +00:00