Swap the if() in the state flag test to make it more readable.

This commit is contained in:
sk89q 2014-08-15 13:54:33 -07:00
parent 8a11752253
commit c0d4ba5c6c

View File

@ -284,15 +284,18 @@ private State calculateState(StateFlag flag, @Nullable LocalPlayer player, @Null
}
}
if (regionsThatCountExistHere) {
if (player != null) {
State membership = allowOrNone(needsClear.isEmpty());
return combine(state, membership);
if (player != null) {
State fallback;
if (regionsThatCountExistHere) {
fallback = allowOrNone(needsClear.isEmpty());
} else {
return combine(state, getDefault(flag, null));
fallback = getDefault(flag, player);
}
return combine(state, fallback);
} else {
return combine(getDefault(flag, player));
return combine(state, getDefault(flag, null));
}
}