Upstream
/
WorldGuard
mirror of https://github.com/EngineHub/WorldGuard.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Deprecate and immediately void setMin/MaxPoint in ProtectedCuboidRegion. 

Not sure why these were here to begin with, Poly doesn't have them either
and mutating regions after creation leads to undefined behavior.
This commit is contained in:
wizjany 2021-04-12 14:18:11 -04:00
parent d2c2bfbab2
commit de22a5cd25
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
worldguard-core/src/main/java/com/sk89q/worldguard/protection/regions/ProtectedCuboidRegion.java
View File

@ -23,6 +23,7 @@ import static com.google.common.base.Preconditions.checkNotNull;
import com.sk89q.worldedit.math.BlockVector2;
import com.sk89q.worldedit.math.BlockVector3;
import com.sk89q.worldguard.WorldGuard;
import com.sk89q.worldguard.util.MathUtils;
import java.awt.Rectangle;
@ -84,18 +85,24 @@ public class ProtectedCuboidRegion extends ProtectedRegion {
* Set the lower point of the cuboid.
*
* @param position the point to set as the minimum point
* @deprecated ProtectedRegion bounds should never be mutated. Regions must be redefined to move them.
* This method will be removed in a future release.
*/
@Deprecated
public void setMinimumPoint(BlockVector3 position) {
setMinMaxPoints(position, max);
WorldGuard.logger.warning("ProtectedCuboidRegion#setMinimumPoint call ignored. Mutating regions leads to undefined behavior.");
}
/**
* Set the upper point of the cuboid.
*
* @param position the point to set as the maximum point
* @deprecated ProtectedRegion bounds should never be mutated. Regions must be redefined to move them.
* This method will be removed in a future release.
*/
@Deprecated
public void setMaximumPoint(BlockVector3 position) {
setMinMaxPoints(min, position);
WorldGuard.logger.warning("ProtectedCuboidRegion#setMaximumPoint call ignored. Mutating regions leads to undefined behavior.");
}
@Override