From 38fce9a4b07459ffc54d839ae4cb72ea0990309e Mon Sep 17 00:00:00 2001
From: BONNe <bonne@bonne.id.lv>
Date: Wed, 23 Jan 2019 19:49:13 +0200
Subject: [PATCH] Fix issue when Challenge and ChallengeLevel icons were stored
 with glowing effect and lore from admin panel.

This issue happened because PanelItem overwrites ItemStack metaData.
It is fixed by returning clone of icon element instead of returning actual icon.
---
 .../world/bentobox/challenges/database/object/Challenge.java    | 2 +-
 .../bentobox/challenges/database/object/ChallengeLevel.java     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/main/java/world/bentobox/challenges/database/object/Challenge.java b/src/main/java/world/bentobox/challenges/database/object/Challenge.java
index 6f6f829..6d73716 100644
--- a/src/main/java/world/bentobox/challenges/database/object/Challenge.java
+++ b/src/main/java/world/bentobox/challenges/database/object/Challenge.java
@@ -308,7 +308,7 @@ public class Challenge implements DataObject
      */
     public ItemStack getIcon()
     {
-        return icon;
+        return icon.clone();
     }
 
 
diff --git a/src/main/java/world/bentobox/challenges/database/object/ChallengeLevel.java b/src/main/java/world/bentobox/challenges/database/object/ChallengeLevel.java
index cae1976..de4c71b 100644
--- a/src/main/java/world/bentobox/challenges/database/object/ChallengeLevel.java
+++ b/src/main/java/world/bentobox/challenges/database/object/ChallengeLevel.java
@@ -138,7 +138,7 @@ public class ChallengeLevel implements DataObject, Comparable<ChallengeLevel>
      */
     public ItemStack getIcon()
     {
-        return icon;
+        return icon.clone();
     }