From e04ed5fb756477732fc21d4dab87c13e9b89744e Mon Sep 17 00:00:00 2001
From: BONNe <bonne@bonne.id.lv>
Date: Tue, 5 Mar 2019 10:30:19 +0200
Subject: [PATCH] Upgrade ChallengesPom

- Move all dependency versions to properties section.
- Add profiles that allows to change project version based on BUILD_NUMBER and GIT_BRANCH
---
 pom.xml | 51 +++++++++++++++++++++++++++++++++++++++++++++------
 1 file changed, 45 insertions(+), 6 deletions(-)

diff --git a/pom.xml b/pom.xml
index 1d0019b..cee953b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -6,7 +6,7 @@
 
 	<groupId>world.bentobox</groupId>
 	<artifactId>challenges</artifactId>
-	<version>0.6.0</version>
+	<version>${revision}</version>
 
 	<name>Challenges</name>
 	<description>Challenges is an add-on for BentoBox, an expandable Minecraft Bukkit plugin for island-type games like SkyBlock, AcidIsland or CaveBlock.</description>
@@ -34,8 +34,47 @@
 		<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
 		<java.version>1.8</java.version>
 		<powermock.version>1.7.4</powermock.version>
+		<!-- More visible way how to change dependency versions -->
+		<spigot.version>1.13.2-R0.1-SNAPSHOT</spigot.version>
+		<bentobox.version>1.3.0</bentobox.version>
+		<level.version>1.3.0</level.version>
+		<vault.version>68f14ec</vault.version>
+		<!-- Revision variable removes warning about dynamic version -->
+		<revision>${build.version}</revision>
+		<!-- This allows to change between versions and snapshots. -->
+		<build.version>0.6.1</build.version>
 	</properties>
 
+	<profiles>
+		<profile>
+			<id>develop</id>
+			<activation>
+				<property>
+					<name>env.BUILD_NUMBER</name>
+				</property>
+			</activation>
+			<properties>
+				<!-- Override only if necessary -->
+				<revision>${build.version}-SNAPSHOT #${env.BUILD_NUMBER}</revision>
+				<!-- GIT_BRANCH -->
+			</properties>
+		</profile>
+		<profile>
+			<id>master</id>
+			<activation>
+				<property>
+					<name>env.GIT_BRANCH</name>
+					<value>origin/master</value>
+				</property>
+			</activation>
+			<properties>
+				<!-- Override only if necessary -->
+				<revision>${build.version}</revision>
+				<!-- GIT_BRANCH -->
+			</properties>
+		</profile>
+	</profiles>
+
 	<distributionManagement>
 		<snapshotRepository>
 			<id>codemc-snapshots</id>
@@ -75,13 +114,13 @@
 		<dependency>
 			<groupId>org.spigotmc</groupId>
 			<artifactId>spigot-api</artifactId>
-			<version>1.13.2-R0.1-SNAPSHOT</version>
+			<version>${spigot.version}</version>
 			<scope>provided</scope>
 		</dependency>
 		<dependency>
 			<groupId>org.spigotmc</groupId>
 			<artifactId>spigot</artifactId>
-			<version>1.13.2-R0.1-SNAPSHOT</version>
+			<version>${spigot.version}</version>
 			<scope>provided</scope>
 		</dependency>
 		<dependency>
@@ -105,19 +144,19 @@
 		<dependency>
 			<groupId>world.bentobox</groupId>
 			<artifactId>bentobox</artifactId>
-			<version>1.3.0</version>
+			<version>${bentobox.version}</version>
 			<scope>provided</scope>
 		</dependency>
 		<dependency>
 			<groupId>world.bentobox</groupId>
 			<artifactId>level</artifactId>
-			<version>1.3.0</version>
+			<version>${level.version}</version>
 			<scope>provided</scope>
 		</dependency>
 		<dependency>
 			<groupId>com.github.MilkBowl</groupId>
 			<artifactId>VaultAPI</artifactId>
-			<version>68f14ec</version>
+			<version>${vault.version}</version>
 			<scope>provided</scope>
 		</dependency>
 		<dependency>